{"action":"created","issue":{"url":"https://api.github.com/repos/apache/parquet-mr/issues/290","labels_url":"https://api.github.com/repos/apache/parquet-mr/issues/290/labels{/name}","comments_url":"https://api.github.com/repos/apache/parquet-mr/issues/290/comments","events_url":"https://api.github.com/repos/apache/parquet-mr/issues/290/events","html_url":"https://github.com/apache/parquet-mr/pull/290","id":118731609,"number":290,"title":"PARQUET-305: Update logging to SLF4J.","user":{"login":"rdblue","id":87915,"avatar_url":"https://avatars.githubusercontent.com/u/87915?v=3","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-25T00:16:36Z","updated_at":"2015-11-25T06:33:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/290","html_url":"https://github.com/apache/parquet-mr/pull/290","diff_url":"https://github.com/apache/parquet-mr/pull/290.diff","patch_url":"https://github.com/apache/parquet-mr/pull/290.patch"},"body":"This removes the Log implementation based on java.util.logging and\r\nreplaces it with SLF4J. The compiler removal of debug log messages still\r\nworks because Log.DEBUG and similar final constants are unchanged.\r\n\r\nThe Log class and API is now deprecated in favor of using SLF4J\r\ndirectly. The main reason is to avoid expensive string construction when\r\npossible by exposing the full SLF4J API.\r\n\r\nThis commit adds slf4j-simple as the test logger implementation.\r\nConfiguration for slf4j-simple is in the root pom. Two modules can't use\r\nslf4j-simple, parquet-pig and parquet-thrift, and use slf4j-log4j12\r\ninstead because pig depends on log4j and tests die without it."},"comment":{"url":"https://api.github.com/repos/apache/parquet-mr/issues/comments/159510423","html_url":"https://github.com/apache/parquet-mr/pull/290#issuecomment-159510423","issue_url":"https://api.github.com/repos/apache/parquet-mr/issues/290","id":159510423,"user":{"login":"julienledem","id":367841,"avatar_url":"https://avatars.githubusercontent.com/u/367841?v=3","gravatar_id":"","url":"https://api.github.com/users/julienledem","html_url":"https://github.com/julienledem","followers_url":"https://api.github.com/users/julienledem/followers","following_url":"https://api.github.com/users/julienledem/following{/other_user}","gists_url":"https://api.github.com/users/julienledem/gists{/gist_id}","starred_url":"https://api.github.com/users/julienledem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienledem/subscriptions","organizations_url":"https://api.github.com/users/julienledem/orgs","repos_url":"https://api.github.com/users/julienledem/repos","events_url":"https://api.github.com/users/julienledem/events{/privacy}","received_events_url":"https://api.github.com/users/julienledem/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T06:33:43Z","updated_at":"2015-11-25T06:33:43Z","body":"Thanks for updating the dependency and use slf4j under the hood.\r\nI don't see the need to migrate all the logs to the slf4j api.\r\nI would not deprecate the Log class and just keep it as is as a seen wrapper to slf4j.\r\n"}}