{"action":"created","comment":{"url":"https://api.github.com/repos/rasmus/EventFlow/pulls/comments/38262786","id":38262786,"diff_hunk":"@@ -35,8 +35,13 @@ public interface IAggregateRoot\n         IEnumerable<IAggregateEvent> UncommittedEvents { get; }\n         bool IsNew { get; }\n \n-        Task<IReadOnlyCollection<IDomainEvent>> CommitAsync(IEventStore eventStore, CancellationToken cancellationToken);\n+        Task<IReadOnlyCollection<IDomainEvent>> CommitAsync(\n+            IEventStore eventStore,\n+            ISourceId sourceId,","path":"Source/EventFlow/Aggregates/IAggregateRoot.cs","position":7,"original_position":7,"commit_id":"bdc991705c8a6e23ead3535f9aeb5f413dd5b2dc","original_commit_id":"bdc991705c8a6e23ead3535f9aeb5f413dd5b2dc","user":{"login":"MartinHave","id":1706133,"avatar_url":"https://avatars.githubusercontent.com/u/1706133?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinHave","html_url":"https://github.com/MartinHave","followers_url":"https://api.github.com/users/MartinHave/followers","following_url":"https://api.github.com/users/MartinHave/following{/other_user}","gists_url":"https://api.github.com/users/MartinHave/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinHave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinHave/subscriptions","organizations_url":"https://api.github.com/users/MartinHave/orgs","repos_url":"https://api.github.com/users/MartinHave/repos","events_url":"https://api.github.com/users/MartinHave/events{/privacy}","received_events_url":"https://api.github.com/users/MartinHave/received_events","type":"User","site_admin":false},"body":"@rasmus This is a breaking change. Consider extending the IAggregateRoot interface with the old implementation. If the aggregate does not care about the sourceId then it can be omitted.","created_at":"2015-08-29T14:53:27Z","updated_at":"2015-08-29T14:53:27Z","html_url":"https://github.com/rasmus/EventFlow/pull/89#discussion_r38262786","pull_request_url":"https://api.github.com/repos/rasmus/EventFlow/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/comments/38262786"},"html":{"href":"https://github.com/rasmus/EventFlow/pull/89#discussion_r38262786"},"pull_request":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/rasmus/EventFlow/pulls/89","id":42894280,"html_url":"https://github.com/rasmus/EventFlow/pull/89","diff_url":"https://github.com/rasmus/EventFlow/pull/89.diff","patch_url":"https://github.com/rasmus/EventFlow/pull/89.patch","issue_url":"https://api.github.com/repos/rasmus/EventFlow/issues/89","number":89,"state":"open","locked":false,"title":"Command IDs","user":{"login":"rasmus","id":18956,"avatar_url":"https://avatars.githubusercontent.com/u/18956?v=3","gravatar_id":"","url":"https://api.github.com/users/rasmus","html_url":"https://github.com/rasmus","followers_url":"https://api.github.com/users/rasmus/followers","following_url":"https://api.github.com/users/rasmus/following{/other_user}","gists_url":"https://api.github.com/users/rasmus/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmus/subscriptions","organizations_url":"https://api.github.com/users/rasmus/orgs","repos_url":"https://api.github.com/users/rasmus/repos","events_url":"https://api.github.com/users/rasmus/events{/privacy}","received_events_url":"https://api.github.com/users/rasmus/received_events","type":"User","site_admin":false},"body":"Command IDs can be used for a few different things.\r\n\r\n- Doing truly asynchronous execution of commands using e.g. RabbitMQ. Commands are basically value objects, so it would be possible to send them using RabbitMQ. The command IDs will allow applications that send the commands, to receive a notification when the command was executed and with a success code.\r\n- Traceability and auditing as the command ID can be logged","created_at":"2015-08-20T06:01:46Z","updated_at":"2015-08-29T14:53:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6d9e59ec519b2b07edd0c5bdaa3ea4f81e58e90","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rasmus/EventFlow/pulls/89/commits","review_comments_url":"https://api.github.com/repos/rasmus/EventFlow/pulls/89/comments","review_comment_url":"https://api.github.com/repos/rasmus/EventFlow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rasmus/EventFlow/issues/89/comments","statuses_url":"https://api.github.com/repos/rasmus/EventFlow/statuses/bdc991705c8a6e23ead3535f9aeb5f413dd5b2dc","head":{"label":"rasmus:command-id","ref":"command-id","sha":"bdc991705c8a6e23ead3535f9aeb5f413dd5b2dc","user":{"login":"rasmus","id":18956,"avatar_url":"https://avatars.githubusercontent.com/u/18956?v=3","gravatar_id":"","url":"https://api.github.com/users/rasmus","html_url":"https://github.com/rasmus","followers_url":"https://api.github.com/users/rasmus/followers","following_url":"https://api.github.com/users/rasmus/following{/other_user}","gists_url":"https://api.github.com/users/rasmus/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmus/subscriptions","organizations_url":"https://api.github.com/users/rasmus/orgs","repos_url":"https://api.github.com/users/rasmus/repos","events_url":"https://api.github.com/users/rasmus/events{/privacy}","received_events_url":"https://api.github.com/users/rasmus/received_events","type":"User","site_admin":false},"repo":{"id":32411368,"name":"EventFlow","full_name":"rasmus/EventFlow","owner":{"login":"rasmus","id":18956,"avatar_url":"https://avatars.githubusercontent.com/u/18956?v=3","gravatar_id":"","url":"https://api.github.com/users/rasmus","html_url":"https://github.com/rasmus","followers_url":"https://api.github.com/users/rasmus/followers","following_url":"https://api.github.com/users/rasmus/following{/other_user}","gists_url":"https://api.github.com/users/rasmus/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmus/subscriptions","organizations_url":"https://api.github.com/users/rasmus/orgs","repos_url":"https://api.github.com/users/rasmus/repos","events_url":"https://api.github.com/users/rasmus/events{/privacy}","received_events_url":"https://api.github.com/users/rasmus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rasmus/EventFlow","description":"CQRS+ES framework","fork":false,"url":"https://api.github.com/repos/rasmus/EventFlow","forks_url":"https://api.github.com/repos/rasmus/EventFlow/forks","keys_url":"https://api.github.com/repos/rasmus/EventFlow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rasmus/EventFlow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rasmus/EventFlow/teams","hooks_url":"https://api.github.com/repos/rasmus/EventFlow/hooks","issue_events_url":"https://api.github.com/repos/rasmus/EventFlow/issues/events{/number}","events_url":"https://api.github.com/repos/rasmus/EventFlow/events","assignees_url":"https://api.github.com/repos/rasmus/EventFlow/assignees{/user}","branches_url":"https://api.github.com/repos/rasmus/EventFlow/branches{/branch}","tags_url":"https://api.github.com/repos/rasmus/EventFlow/tags","blobs_url":"https://api.github.com/repos/rasmus/EventFlow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rasmus/EventFlow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rasmus/EventFlow/git/refs{/sha}","trees_url":"https://api.github.com/repos/rasmus/EventFlow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rasmus/EventFlow/statuses/{sha}","languages_url":"https://api.github.com/repos/rasmus/EventFlow/languages","stargazers_url":"https://api.github.com/repos/rasmus/EventFlow/stargazers","contributors_url":"https://api.github.com/repos/rasmus/EventFlow/contributors","subscribers_url":"https://api.github.com/repos/rasmus/EventFlow/subscribers","subscription_url":"https://api.github.com/repos/rasmus/EventFlow/subscription","commits_url":"https://api.github.com/repos/rasmus/EventFlow/commits{/sha}","git_commits_url":"https://api.github.com/repos/rasmus/EventFlow/git/commits{/sha}","comments_url":"https://api.github.com/repos/rasmus/EventFlow/comments{/number}","issue_comment_url":"https://api.github.com/repos/rasmus/EventFlow/issues/comments{/number}","contents_url":"https://api.github.com/repos/rasmus/EventFlow/contents/{+path}","compare_url":"https://api.github.com/repos/rasmus/EventFlow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rasmus/EventFlow/merges","archive_url":"https://api.github.com/repos/rasmus/EventFlow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rasmus/EventFlow/downloads","issues_url":"https://api.github.com/repos/rasmus/EventFlow/issues{/number}","pulls_url":"https://api.github.com/repos/rasmus/EventFlow/pulls{/number}","milestones_url":"https://api.github.com/repos/rasmus/EventFlow/milestones{/number}","notifications_url":"https://api.github.com/repos/rasmus/EventFlow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rasmus/EventFlow/labels{/name}","releases_url":"https://api.github.com/repos/rasmus/EventFlow/releases{/id}","created_at":"2015-03-17T18:11:23Z","updated_at":"2015-08-29T00:57:04Z","pushed_at":"2015-08-28T23:03:56Z","git_url":"git://github.com/rasmus/EventFlow.git","ssh_url":"git@github.com:rasmus/EventFlow.git","clone_url":"https://github.com/rasmus/EventFlow.git","svn_url":"https://github.com/rasmus/EventFlow","homepage":"","size":3318,"stargazers_count":15,"watchers_count":15,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":25,"forks":5,"open_issues":25,"watchers":15,"default_branch":"develop"}},"base":{"label":"rasmus:develop","ref":"develop","sha":"ee525b7bdd4c2eb5df63ecb0aed68e48d7849b85","user":{"login":"rasmus","id":18956,"avatar_url":"https://avatars.githubusercontent.com/u/18956?v=3","gravatar_id":"","url":"https://api.github.com/users/rasmus","html_url":"https://github.com/rasmus","followers_url":"https://api.github.com/users/rasmus/followers","following_url":"https://api.github.com/users/rasmus/following{/other_user}","gists_url":"https://api.github.com/users/rasmus/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmus/subscriptions","organizations_url":"https://api.github.com/users/rasmus/orgs","repos_url":"https://api.github.com/users/rasmus/repos","events_url":"https://api.github.com/users/rasmus/events{/privacy}","received_events_url":"https://api.github.com/users/rasmus/received_events","type":"User","site_admin":false},"repo":{"id":32411368,"name":"EventFlow","full_name":"rasmus/EventFlow","owner":{"login":"rasmus","id":18956,"avatar_url":"https://avatars.githubusercontent.com/u/18956?v=3","gravatar_id":"","url":"https://api.github.com/users/rasmus","html_url":"https://github.com/rasmus","followers_url":"https://api.github.com/users/rasmus/followers","following_url":"https://api.github.com/users/rasmus/following{/other_user}","gists_url":"https://api.github.com/users/rasmus/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmus/subscriptions","organizations_url":"https://api.github.com/users/rasmus/orgs","repos_url":"https://api.github.com/users/rasmus/repos","events_url":"https://api.github.com/users/rasmus/events{/privacy}","received_events_url":"https://api.github.com/users/rasmus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rasmus/EventFlow","description":"CQRS+ES framework","fork":false,"url":"https://api.github.com/repos/rasmus/EventFlow","forks_url":"https://api.github.com/repos/rasmus/EventFlow/forks","keys_url":"https://api.github.com/repos/rasmus/EventFlow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rasmus/EventFlow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rasmus/EventFlow/teams","hooks_url":"https://api.github.com/repos/rasmus/EventFlow/hooks","issue_events_url":"https://api.github.com/repos/rasmus/EventFlow/issues/events{/number}","events_url":"https://api.github.com/repos/rasmus/EventFlow/events","assignees_url":"https://api.github.com/repos/rasmus/EventFlow/assignees{/user}","branches_url":"https://api.github.com/repos/rasmus/EventFlow/branches{/branch}","tags_url":"https://api.github.com/repos/rasmus/EventFlow/tags","blobs_url":"https://api.github.com/repos/rasmus/EventFlow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rasmus/EventFlow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rasmus/EventFlow/git/refs{/sha}","trees_url":"https://api.github.com/repos/rasmus/EventFlow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rasmus/EventFlow/statuses/{sha}","languages_url":"https://api.github.com/repos/rasmus/EventFlow/languages","stargazers_url":"https://api.github.com/repos/rasmus/EventFlow/stargazers","contributors_url":"https://api.github.com/repos/rasmus/EventFlow/contributors","subscribers_url":"https://api.github.com/repos/rasmus/EventFlow/subscribers","subscription_url":"https://api.github.com/repos/rasmus/EventFlow/subscription","commits_url":"https://api.github.com/repos/rasmus/EventFlow/commits{/sha}","git_commits_url":"https://api.github.com/repos/rasmus/EventFlow/git/commits{/sha}","comments_url":"https://api.github.com/repos/rasmus/EventFlow/comments{/number}","issue_comment_url":"https://api.github.com/repos/rasmus/EventFlow/issues/comments{/number}","contents_url":"https://api.github.com/repos/rasmus/EventFlow/contents/{+path}","compare_url":"https://api.github.com/repos/rasmus/EventFlow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rasmus/EventFlow/merges","archive_url":"https://api.github.com/repos/rasmus/EventFlow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rasmus/EventFlow/downloads","issues_url":"https://api.github.com/repos/rasmus/EventFlow/issues{/number}","pulls_url":"https://api.github.com/repos/rasmus/EventFlow/pulls{/number}","milestones_url":"https://api.github.com/repos/rasmus/EventFlow/milestones{/number}","notifications_url":"https://api.github.com/repos/rasmus/EventFlow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rasmus/EventFlow/labels{/name}","releases_url":"https://api.github.com/repos/rasmus/EventFlow/releases{/id}","created_at":"2015-03-17T18:11:23Z","updated_at":"2015-08-29T00:57:04Z","pushed_at":"2015-08-28T23:03:56Z","git_url":"git://github.com/rasmus/EventFlow.git","ssh_url":"git@github.com:rasmus/EventFlow.git","clone_url":"https://github.com/rasmus/EventFlow.git","svn_url":"https://github.com/rasmus/EventFlow","homepage":"","size":3318,"stargazers_count":15,"watchers_count":15,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":25,"forks":5,"open_issues":25,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/89"},"html":{"href":"https://github.com/rasmus/EventFlow/pull/89"},"issue":{"href":"https://api.github.com/repos/rasmus/EventFlow/issues/89"},"comments":{"href":"https://api.github.com/repos/rasmus/EventFlow/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/rasmus/EventFlow/statuses/bdc991705c8a6e23ead3535f9aeb5f413dd5b2dc"}}}}