{"action":"created","issue":{"url":"https://api.github.com/repos/ZhongMeiZhou/scraper_project/issues/36","labels_url":"https://api.github.com/repos/ZhongMeiZhou/scraper_project/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/ZhongMeiZhou/scraper_project/issues/36/comments","events_url":"https://api.github.com/repos/ZhongMeiZhou/scraper_project/issues/36/events","html_url":"https://github.com/ZhongMeiZhou/scraper_project/issues/36","id":113148449,"number":36,"title":"Tests are too specific?","user":{"login":"soumyaray","id":1926704,"avatar_url":"https://avatars.githubusercontent.com/u/1926704?v=3","gravatar_id":"","url":"https://api.github.com/users/soumyaray","html_url":"https://github.com/soumyaray","followers_url":"https://api.github.com/users/soumyaray/followers","following_url":"https://api.github.com/users/soumyaray/following{/other_user}","gists_url":"https://api.github.com/users/soumyaray/gists{/gist_id}","starred_url":"https://api.github.com/users/soumyaray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumyaray/subscriptions","organizations_url":"https://api.github.com/users/soumyaray/orgs","repos_url":"https://api.github.com/users/soumyaray/repos","events_url":"https://api.github.com/users/soumyaray/events{/privacy}","received_events_url":"https://api.github.com/users/soumyaray/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-24T09:57:48Z","updated_at":"2015-10-24T11:12:47Z","closed_at":null,"body":"Your code looks good!  But I'm worried your tests are looking at data that is very likely to change in the near future (Taiwan tour titles, prices, etc.). Might it not be better just to make sure you are finding some tours without matching the data to stored results?  For example, maybe just check that you've found at least 6 tours, and that they have real prices (numbers), titles (strings), etc.  What do you all think?"},"comment":{"url":"https://api.github.com/repos/ZhongMeiZhou/scraper_project/issues/comments/150785000","html_url":"https://github.com/ZhongMeiZhou/scraper_project/issues/36#issuecomment-150785000","issue_url":"https://api.github.com/repos/ZhongMeiZhou/scraper_project/issues/36","id":150785000,"user":{"login":"soumyaray","id":1926704,"avatar_url":"https://avatars.githubusercontent.com/u/1926704?v=3","gravatar_id":"","url":"https://api.github.com/users/soumyaray","html_url":"https://github.com/soumyaray","followers_url":"https://api.github.com/users/soumyaray/followers","following_url":"https://api.github.com/users/soumyaray/following{/other_user}","gists_url":"https://api.github.com/users/soumyaray/gists{/gist_id}","starred_url":"https://api.github.com/users/soumyaray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumyaray/subscriptions","organizations_url":"https://api.github.com/users/soumyaray/orgs","repos_url":"https://api.github.com/users/soumyaray/repos","events_url":"https://api.github.com/users/soumyaray/events{/privacy}","received_events_url":"https://api.github.com/users/soumyaray/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T11:12:47Z","updated_at":"2015-10-24T11:12:47Z","body":"I really do appreciate the rigorous testing you've already done though! But yeah, I think the tests need to be made a bit more flexible. Its not a priority for this week's class, but let's try and get it done in the next week or two? Leave a comment here after you've adjusted your tests -- I'll take another look at it before closing the issue."}}