{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/32664217","id":32664217,"diff_hunk":"@@ -1,5 +1,5 @@\n-var rxAppPage = require('../rxApp.page').rxApp;\n-var rxPage = require('../rxApp.page').rxPage;\n+var rxAppPage = encore.rxApp;\n+var rxPage = encore.rxPage;","path":"src/rxApp/docs/rxApp.midway.js","position":4,"original_position":4,"commit_id":"3509dfbc2bcac94e11909641b3824d972d7f2d7d","original_commit_id":"3509dfbc2bcac94e11909641b3824d972d7f2d7d","user":{"login":"parlarjb","id":9376,"avatar_url":"https://avatars.githubusercontent.com/u/9376?v=3","gravatar_id":"","url":"https://api.github.com/users/parlarjb","html_url":"https://github.com/parlarjb","followers_url":"https://api.github.com/users/parlarjb/followers","following_url":"https://api.github.com/users/parlarjb/following{/other_user}","gists_url":"https://api.github.com/users/parlarjb/gists{/gist_id}","starred_url":"https://api.github.com/users/parlarjb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parlarjb/subscriptions","organizations_url":"https://api.github.com/users/parlarjb/orgs","repos_url":"https://api.github.com/users/parlarjb/repos","events_url":"https://api.github.com/users/parlarjb/events{/privacy}","received_events_url":"https://api.github.com/users/parlarjb/received_events","type":"User","site_admin":false},"body":"Needs a change?","created_at":"2015-06-17T19:20:44Z","updated_at":"2015-06-17T19:20:44Z","html_url":"https://github.com/rackerlabs/encore-ui/pull/1046#discussion_r32664217","pull_request_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1046","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/32664217"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/1046#discussion_r32664217"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1046"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1046","id":37740030,"html_url":"https://github.com/rackerlabs/encore-ui/pull/1046","diff_url":"https://github.com/rackerlabs/encore-ui/pull/1046.diff","patch_url":"https://github.com/rackerlabs/encore-ui/pull/1046.patch","issue_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1046","number":1046,"state":"open","locked":false,"title":"fix(e2e): Use published version for testing","user":{"login":"Droogans","id":1214609,"avatar_url":"https://avatars.githubusercontent.com/u/1214609?v=3","gravatar_id":"","url":"https://api.github.com/users/Droogans","html_url":"https://github.com/Droogans","followers_url":"https://api.github.com/users/Droogans/followers","following_url":"https://api.github.com/users/Droogans/following{/other_user}","gists_url":"https://api.github.com/users/Droogans/gists{/gist_id}","starred_url":"https://api.github.com/users/Droogans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Droogans/subscriptions","organizations_url":"https://api.github.com/users/Droogans/orgs","repos_url":"https://api.github.com/users/Droogans/repos","events_url":"https://api.github.com/users/Droogans/events{/privacy}","received_events_url":"https://api.github.com/users/Droogans/received_events","type":"User","site_admin":false},"body":"fix(rxBulkSelect): Require from exports\r\n\r\nhttps://goo.gl/OEY6EE\r\n\r\nThis link explains how you must try to require from both exports (for\r\nthe rx-page-objects finished product) vs. using the page object under\r\nsrc. If you don't do this users who download rx-page-objects will get\r\nerrors in their end to end tests from bad require statements.\r\n\r\nhttps://github.com/rackerlabs/encore-ui/issues/1044 is related.\r\n\r\nfix(rxSelectFilter): Require from exports\r\n\r\ntest(visualRegression): Remove from dev conf\r\n\r\nDevelopers who create new components need to run end to end tests\r\nagainst them. This requires that they remove the `snappit` stuff from\r\nit, since it's been left out of all environments (except the PR builder)\r\non purpose.\r\n\r\nIt was originally left in there in case a developer should decide to add\r\na visual regression test inside of the existing end to end test suite,\r\nbut it really doesn't make much sense.\r\n\r\nCloses #1041\r\n\r\nfix(testing): Unify to a single style of imports\r\n\r\nCloses #1044","created_at":"2015-06-15T21:57:01Z","updated_at":"2015-06-17T19:20:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36978463baaa36edf7ed4f7381460243cd933715","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1046/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1046/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1046/comments","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/3509dfbc2bcac94e11909641b3824d972d7f2d7d","head":{"label":"rackerlabs:use-built-page-objects-for-testing","ref":"use-built-page-objects-for-testing","sha":"3509dfbc2bcac94e11909641b3824d972d7f2d7d","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","created_at":"2013-07-15T20:06:52Z","updated_at":"2015-06-15T14:18:48Z","pushed_at":"2015-06-17T15:37:44Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":29182,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":98,"forks":33,"open_issues":98,"watchers":27,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"5d56945529ed94fbbe574be3be9ef850f2dfb538","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","created_at":"2013-07-15T20:06:52Z","updated_at":"2015-06-15T14:18:48Z","pushed_at":"2015-06-17T15:37:44Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":29182,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"open_issues_count":98,"forks":33,"open_issues":98,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1046"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/1046"},"issue":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1046"},"comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1046/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1046/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1046/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/3509dfbc2bcac94e11909641b3824d972d7f2d7d"}}}}