{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/12577","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12577/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12577/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12577/events","html_url":"https://github.com/cms-sw/cmssw/pull/12577","id":119043561,"number":12577,"title":"add a specific duplicateMerge algorithm","user":{"login":"VinInn","id":4143702,"avatar_url":"https://avatars.githubusercontent.com/u/4143702?v=3","gravatar_id":"","url":"https://api.github.com/users/VinInn","html_url":"https://github.com/VinInn","followers_url":"https://api.github.com/users/VinInn/followers","following_url":"https://api.github.com/users/VinInn/following{/other_user}","gists_url":"https://api.github.com/users/VinInn/gists{/gist_id}","starred_url":"https://api.github.com/users/VinInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VinInn/subscriptions","organizations_url":"https://api.github.com/users/VinInn/orgs","repos_url":"https://api.github.com/users/VinInn/repos","events_url":"https://api.github.com/users/VinInn/events{/privacy}","received_events_url":"https://api.github.com/users/VinInn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_0_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/57/labels","id":1362157,"number":57,"title":"Next CMSSW_8_0_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":64,"closed_issues":266,"state":"open","created_at":"2015-10-18T08:35:44Z","updated_at":"2015-11-27T13:01:09Z","due_on":null,"closed_at":null},"comments":26,"created_at":"2015-11-26T13:22:35Z","updated_at":"2015-11-27T13:10:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/12577","html_url":"https://github.com/cms-sw/cmssw/pull/12577","diff_url":"https://github.com/cms-sw/cmssw/pull/12577.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/12577.patch"},"body":"duplicate-Merged tracks were inheriting the algorithm of the innermost piece.\r\nThis was causing confusion at many levels (besides the difficulties in validating and analyzing these tracks)\r\n\r\nHere we assign them their own algo flag.\r\n\r\npurely technical change.  Track migration form previous algo to the new one expected.\r\nsee https://innocent.web.cern.ch/innocent/RelVal/pu15_80_dma/\r\nIf physics change, there is a bug downstream, most probably in code other than tracker."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/160136468","html_url":"https://github.com/cms-sw/cmssw/pull/12577#issuecomment-160136468","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/12577","id":160136468,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2015-11-27T13:10:25Z","updated_at":"2015-11-27T13:10:25Z","body":"On 11/27/15 12:05 AM, Matti Kortelainen wrote:\n> I'm (again) confused by the comparison. Alternative-comparisons show\n> differences in histograms where relmon gives green (so relmon has some\n> threshold for marking histograms different?). But even\n> alternative-comparisons is inconsistent with itself: from differences in\n> certain (MTV) histograms I'd except differences in other (MTV)\n> histograms, but I don't see them (so alternative-comparisons has also\n> some threshold?). These make it a bit difficult in certain occasions to\n> judge if the changes are as expected, and also difficult to trust that\n> histograms flagged as \"no changes\" would actually be unchanged. </rant>\n\n\nYes, there are thresholds for both relmon and alternative-comparisons\nbased on the number of differences found in validateJR.\n\nWithout thresholds outputs will take too long to generate and will\ntake a noticeable fraction of GB.\n\nYou can rerun either relmon or alternative-comparisons locally (DQM\nfiles are available)\n\n> \n> Anyway, there is pile of changes in e.g. electrons and taus, and also\n> increase in \"PackedCandidates/lostTracks\". Apparently we need further\n> migration. In fact, e.g. |git grep ::initialStep| reveals a bunch of\n> files (many inside PF) that are not changed in this PR that could,\n> naively thinking, lead to changes downstream.\n> \n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/cms-sw/cmssw/pull/12577#issuecomment-160064268>.\n> \n"}}