{"action":"created","comment":{"url":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/comments/35632881","id":35632881,"diff_hunk":"@@ -7,11 +9,12 @@ def __init__(self, **kwargs):\n         self.clientId = kwargs['clientId']\n         self.accessToken = kwargs['accessToken']\n \n+        self.logger = logging.getLogger(__name__)","path":"taskcluster_util/model/credentials.py","position":11,"original_position":11,"commit_id":"cca22c849c3b2364b95c9b07569359348326748a","original_commit_id":"cca22c849c3b2364b95c9b07569359348326748a","user":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"body":"I think we can set the logger at the class level. Example:\r\n```python\r\nclass Credentials(dict):\r\n    logger = logging.getLogger(__name__)\r\n    def __init__(self, **kwargs):\r\n```","created_at":"2015-07-28T10:15:45Z","updated_at":"2015-07-28T10:15:45Z","html_url":"https://github.com/askeing/taskcluster-util-python/pull/5#discussion_r35632881","pull_request_url":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/comments/35632881"},"html":{"href":"https://github.com/askeing/taskcluster-util-python/pull/5#discussion_r35632881"},"pull_request":{"href":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/5","id":40992854,"html_url":"https://github.com/askeing/taskcluster-util-python/pull/5","diff_url":"https://github.com/askeing/taskcluster-util-python/pull/5.diff","patch_url":"https://github.com/askeing/taskcluster-util-python/pull/5.patch","issue_url":"https://api.github.com/repos/askeing/taskcluster-util-python/issues/5","number":5,"state":"open","locked":false,"title":"Fix the logging issues","user":{"login":"askeing","id":1042649,"avatar_url":"https://avatars.githubusercontent.com/u/1042649?v=3","gravatar_id":"","url":"https://api.github.com/users/askeing","html_url":"https://github.com/askeing","followers_url":"https://api.github.com/users/askeing/followers","following_url":"https://api.github.com/users/askeing/following{/other_user}","gists_url":"https://api.github.com/users/askeing/gists{/gist_id}","starred_url":"https://api.github.com/users/askeing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askeing/subscriptions","organizations_url":"https://api.github.com/users/askeing/orgs","repos_url":"https://api.github.com/users/askeing/repos","events_url":"https://api.github.com/users/askeing/events{/privacy}","received_events_url":"https://api.github.com/users/askeing/received_events","type":"User","site_admin":false},"body":"- fix #1","created_at":"2015-07-28T09:45:20Z","updated_at":"2015-07-28T10:15:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45a00b8c988d75c7a9adf03f635a7e07b3fcbce2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/5/commits","review_comments_url":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/5/comments","review_comment_url":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/askeing/taskcluster-util-python/issues/5/comments","statuses_url":"https://api.github.com/repos/askeing/taskcluster-util-python/statuses/cca22c849c3b2364b95c9b07569359348326748a","head":{"label":"askeing:fix_the_logging_issues","ref":"fix_the_logging_issues","sha":"cca22c849c3b2364b95c9b07569359348326748a","user":{"login":"askeing","id":1042649,"avatar_url":"https://avatars.githubusercontent.com/u/1042649?v=3","gravatar_id":"","url":"https://api.github.com/users/askeing","html_url":"https://github.com/askeing","followers_url":"https://api.github.com/users/askeing/followers","following_url":"https://api.github.com/users/askeing/following{/other_user}","gists_url":"https://api.github.com/users/askeing/gists{/gist_id}","starred_url":"https://api.github.com/users/askeing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askeing/subscriptions","organizations_url":"https://api.github.com/users/askeing/orgs","repos_url":"https://api.github.com/users/askeing/repos","events_url":"https://api.github.com/users/askeing/events{/privacy}","received_events_url":"https://api.github.com/users/askeing/received_events","type":"User","site_admin":false},"repo":{"id":39122071,"name":"taskcluster-util-python","full_name":"askeing/taskcluster-util-python","owner":{"login":"askeing","id":1042649,"avatar_url":"https://avatars.githubusercontent.com/u/1042649?v=3","gravatar_id":"","url":"https://api.github.com/users/askeing","html_url":"https://github.com/askeing","followers_url":"https://api.github.com/users/askeing/followers","following_url":"https://api.github.com/users/askeing/following{/other_user}","gists_url":"https://api.github.com/users/askeing/gists{/gist_id}","starred_url":"https://api.github.com/users/askeing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askeing/subscriptions","organizations_url":"https://api.github.com/users/askeing/orgs","repos_url":"https://api.github.com/users/askeing/repos","events_url":"https://api.github.com/users/askeing/events{/privacy}","received_events_url":"https://api.github.com/users/askeing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/askeing/taskcluster-util-python","description":"Python Taskcluster Utilities","fork":false,"url":"https://api.github.com/repos/askeing/taskcluster-util-python","forks_url":"https://api.github.com/repos/askeing/taskcluster-util-python/forks","keys_url":"https://api.github.com/repos/askeing/taskcluster-util-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/askeing/taskcluster-util-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/askeing/taskcluster-util-python/teams","hooks_url":"https://api.github.com/repos/askeing/taskcluster-util-python/hooks","issue_events_url":"https://api.github.com/repos/askeing/taskcluster-util-python/issues/events{/number}","events_url":"https://api.github.com/repos/askeing/taskcluster-util-python/events","assignees_url":"https://api.github.com/repos/askeing/taskcluster-util-python/assignees{/user}","branches_url":"https://api.github.com/repos/askeing/taskcluster-util-python/branches{/branch}","tags_url":"https://api.github.com/repos/askeing/taskcluster-util-python/tags","blobs_url":"https://api.github.com/repos/askeing/taskcluster-util-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/askeing/taskcluster-util-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/askeing/taskcluster-util-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/askeing/taskcluster-util-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/askeing/taskcluster-util-python/statuses/{sha}","languages_url":"https://api.github.com/repos/askeing/taskcluster-util-python/languages","stargazers_url":"https://api.github.com/repos/askeing/taskcluster-util-python/stargazers","contributors_url":"https://api.github.com/repos/askeing/taskcluster-util-python/contributors","subscribers_url":"https://api.github.com/repos/askeing/taskcluster-util-python/subscribers","subscription_url":"https://api.github.com/repos/askeing/taskcluster-util-python/subscription","commits_url":"https://api.github.com/repos/askeing/taskcluster-util-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/askeing/taskcluster-util-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/askeing/taskcluster-util-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/askeing/taskcluster-util-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/askeing/taskcluster-util-python/contents/{+path}","compare_url":"https://api.github.com/repos/askeing/taskcluster-util-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/askeing/taskcluster-util-python/merges","archive_url":"https://api.github.com/repos/askeing/taskcluster-util-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/askeing/taskcluster-util-python/downloads","issues_url":"https://api.github.com/repos/askeing/taskcluster-util-python/issues{/number}","pulls_url":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls{/number}","milestones_url":"https://api.github.com/repos/askeing/taskcluster-util-python/milestones{/number}","notifications_url":"https://api.github.com/repos/askeing/taskcluster-util-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/askeing/taskcluster-util-python/labels{/name}","releases_url":"https://api.github.com/repos/askeing/taskcluster-util-python/releases{/id}","created_at":"2015-07-15T07:09:55Z","updated_at":"2015-07-20T16:42:13Z","pushed_at":"2015-07-28T09:45:20Z","git_url":"git://github.com/askeing/taskcluster-util-python.git","ssh_url":"git@github.com:askeing/taskcluster-util-python.git","clone_url":"https://github.com/askeing/taskcluster-util-python.git","svn_url":"https://github.com/askeing/taskcluster-util-python","homepage":"https://pypi.python.org/pypi/taskcluster_util","size":163,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"askeing:master","ref":"master","sha":"01f363fd863ddcdb30a389f8e20b23744596e81d","user":{"login":"askeing","id":1042649,"avatar_url":"https://avatars.githubusercontent.com/u/1042649?v=3","gravatar_id":"","url":"https://api.github.com/users/askeing","html_url":"https://github.com/askeing","followers_url":"https://api.github.com/users/askeing/followers","following_url":"https://api.github.com/users/askeing/following{/other_user}","gists_url":"https://api.github.com/users/askeing/gists{/gist_id}","starred_url":"https://api.github.com/users/askeing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askeing/subscriptions","organizations_url":"https://api.github.com/users/askeing/orgs","repos_url":"https://api.github.com/users/askeing/repos","events_url":"https://api.github.com/users/askeing/events{/privacy}","received_events_url":"https://api.github.com/users/askeing/received_events","type":"User","site_admin":false},"repo":{"id":39122071,"name":"taskcluster-util-python","full_name":"askeing/taskcluster-util-python","owner":{"login":"askeing","id":1042649,"avatar_url":"https://avatars.githubusercontent.com/u/1042649?v=3","gravatar_id":"","url":"https://api.github.com/users/askeing","html_url":"https://github.com/askeing","followers_url":"https://api.github.com/users/askeing/followers","following_url":"https://api.github.com/users/askeing/following{/other_user}","gists_url":"https://api.github.com/users/askeing/gists{/gist_id}","starred_url":"https://api.github.com/users/askeing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askeing/subscriptions","organizations_url":"https://api.github.com/users/askeing/orgs","repos_url":"https://api.github.com/users/askeing/repos","events_url":"https://api.github.com/users/askeing/events{/privacy}","received_events_url":"https://api.github.com/users/askeing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/askeing/taskcluster-util-python","description":"Python Taskcluster Utilities","fork":false,"url":"https://api.github.com/repos/askeing/taskcluster-util-python","forks_url":"https://api.github.com/repos/askeing/taskcluster-util-python/forks","keys_url":"https://api.github.com/repos/askeing/taskcluster-util-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/askeing/taskcluster-util-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/askeing/taskcluster-util-python/teams","hooks_url":"https://api.github.com/repos/askeing/taskcluster-util-python/hooks","issue_events_url":"https://api.github.com/repos/askeing/taskcluster-util-python/issues/events{/number}","events_url":"https://api.github.com/repos/askeing/taskcluster-util-python/events","assignees_url":"https://api.github.com/repos/askeing/taskcluster-util-python/assignees{/user}","branches_url":"https://api.github.com/repos/askeing/taskcluster-util-python/branches{/branch}","tags_url":"https://api.github.com/repos/askeing/taskcluster-util-python/tags","blobs_url":"https://api.github.com/repos/askeing/taskcluster-util-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/askeing/taskcluster-util-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/askeing/taskcluster-util-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/askeing/taskcluster-util-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/askeing/taskcluster-util-python/statuses/{sha}","languages_url":"https://api.github.com/repos/askeing/taskcluster-util-python/languages","stargazers_url":"https://api.github.com/repos/askeing/taskcluster-util-python/stargazers","contributors_url":"https://api.github.com/repos/askeing/taskcluster-util-python/contributors","subscribers_url":"https://api.github.com/repos/askeing/taskcluster-util-python/subscribers","subscription_url":"https://api.github.com/repos/askeing/taskcluster-util-python/subscription","commits_url":"https://api.github.com/repos/askeing/taskcluster-util-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/askeing/taskcluster-util-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/askeing/taskcluster-util-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/askeing/taskcluster-util-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/askeing/taskcluster-util-python/contents/{+path}","compare_url":"https://api.github.com/repos/askeing/taskcluster-util-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/askeing/taskcluster-util-python/merges","archive_url":"https://api.github.com/repos/askeing/taskcluster-util-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/askeing/taskcluster-util-python/downloads","issues_url":"https://api.github.com/repos/askeing/taskcluster-util-python/issues{/number}","pulls_url":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls{/number}","milestones_url":"https://api.github.com/repos/askeing/taskcluster-util-python/milestones{/number}","notifications_url":"https://api.github.com/repos/askeing/taskcluster-util-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/askeing/taskcluster-util-python/labels{/name}","releases_url":"https://api.github.com/repos/askeing/taskcluster-util-python/releases{/id}","created_at":"2015-07-15T07:09:55Z","updated_at":"2015-07-20T16:42:13Z","pushed_at":"2015-07-28T09:45:20Z","git_url":"git://github.com/askeing/taskcluster-util-python.git","ssh_url":"git@github.com:askeing/taskcluster-util-python.git","clone_url":"https://github.com/askeing/taskcluster-util-python.git","svn_url":"https://github.com/askeing/taskcluster-util-python","homepage":"https://pypi.python.org/pypi/taskcluster_util","size":163,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/5"},"html":{"href":"https://github.com/askeing/taskcluster-util-python/pull/5"},"issue":{"href":"https://api.github.com/repos/askeing/taskcluster-util-python/issues/5"},"comments":{"href":"https://api.github.com/repos/askeing/taskcluster-util-python/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/askeing/taskcluster-util-python/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/askeing/taskcluster-util-python/statuses/cca22c849c3b2364b95c9b07569359348326748a"}}}}