{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/12408","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/12408/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/12408/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/12408/events","html_url":"https://github.com/elastic/elasticsearch/pull/12408","id":96722882,"number":12408,"title":"Adapt pluginmanager to the new world","user":{"login":"rmuir","id":504194,"avatar_url":"https://avatars.githubusercontent.com/u/504194?v=3","gravatar_id":"","url":"https://api.github.com/users/rmuir","html_url":"https://github.com/rmuir","followers_url":"https://api.github.com/users/rmuir/followers","following_url":"https://api.github.com/users/rmuir/following{/other_user}","gists_url":"https://api.github.com/users/rmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/rmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmuir/subscriptions","organizations_url":"https://api.github.com/users/rmuir/orgs","repos_url":"https://api.github.com/users/rmuir/repos","events_url":"https://api.github.com/users/rmuir/events{/privacy}","received_events_url":"https://api.github.com/users/rmuir/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Plugins","name":":Plugins","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/breaking","name":"breaking","color":"ff0000"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v2.0.0-beta1","name":"v2.0.0-beta1","color":"dddddd"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-07-23T03:58:09Z","updated_at":"2015-08-22T13:19:03Z","closed_at":"2015-07-23T11:16:59Z","pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/12408","html_url":"https://github.com/elastic/elasticsearch/pull/12408","diff_url":"https://github.com/elastic/elasticsearch/pull/12408.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/12408.patch"},"body":"Now that plugins have some structure / e.g. required descriptor file, make pluginmanager strict and prevent mistakes from screwing up the installation. \r\n\r\nToday it is still lenient and will basically accept any .zip or .jar and who knows what will happen. There is no sense in leniency, PluginService is going to reject any bullshit on startup.\r\n\r\n* Read/validate descriptor file, remove heuristics around _site or not\r\n* Look for descriptor file to find the plugin \"root\" in a simpler/safer way, when plugin-a.zip expands to plugin-a/ and we have to deal with that.\r\n* Proper jar hell check for non-isolated plugins: we check the candidate against any other non-isolated plugins already installed.\r\n* Fix tests to not use embedded zip files, instead create them on the fly for testing.\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/133702892","html_url":"https://github.com/elastic/elasticsearch/pull/12408#issuecomment-133702892","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/12408","id":133702892,"user":{"login":"YannBrrd","id":2820034,"avatar_url":"https://avatars.githubusercontent.com/u/2820034?v=3","gravatar_id":"","url":"https://api.github.com/users/YannBrrd","html_url":"https://github.com/YannBrrd","followers_url":"https://api.github.com/users/YannBrrd/followers","following_url":"https://api.github.com/users/YannBrrd/following{/other_user}","gists_url":"https://api.github.com/users/YannBrrd/gists{/gist_id}","starred_url":"https://api.github.com/users/YannBrrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YannBrrd/subscriptions","organizations_url":"https://api.github.com/users/YannBrrd/orgs","repos_url":"https://api.github.com/users/YannBrrd/repos","events_url":"https://api.github.com/users/YannBrrd/events{/privacy}","received_events_url":"https://api.github.com/users/YannBrrd/received_events","type":"User","site_admin":false},"created_at":"2015-08-22T13:19:03Z","updated_at":"2015-08-22T13:19:03Z","body":"Ok. I'll release a new version asap. :-)\n\nLe sam. 25 juil. 2015 à 23:03, leonardo menezes <notifications@github.com>\na écrit :\n\n> [image: :+1:]\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/elastic/elasticsearch/pull/12408#issuecomment-124893533>\n> .\n>\n-- \nCordialement,\nYann Barraud\n"}}