{"action":"closed","number":57,"pull_request":{"url":"https://api.github.com/repos/Gankro/collect-rs/pulls/57","id":26747859,"html_url":"https://github.com/Gankro/collect-rs/pull/57","diff_url":"https://github.com/Gankro/collect-rs/pull/57.diff","patch_url":"https://github.com/Gankro/collect-rs/pull/57.patch","issue_url":"https://api.github.com/repos/Gankro/collect-rs/issues/57","number":57,"state":"closed","locked":false,"title":"impl Send and Sync for LruCache","user":{"login":"csouth3","id":6758080,"avatar_url":"https://avatars.githubusercontent.com/u/6758080?v=3","gravatar_id":"","url":"https://api.github.com/users/csouth3","html_url":"https://github.com/csouth3","followers_url":"https://api.github.com/users/csouth3/followers","following_url":"https://api.github.com/users/csouth3/following{/other_user}","gists_url":"https://api.github.com/users/csouth3/gists{/gist_id}","starred_url":"https://api.github.com/users/csouth3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csouth3/subscriptions","organizations_url":"https://api.github.com/users/csouth3/orgs","repos_url":"https://api.github.com/users/csouth3/repos","events_url":"https://api.github.com/users/csouth3/events{/privacy}","received_events_url":"https://api.github.com/users/csouth3/received_events","type":"User","site_admin":false},"body":"There's no reason `LruCache` can't be Send/Sync so long as both `K` and `V` are.\r\n\r\nThere are two ways to approach the problem: converting all `*mut`'s used by `LruCache` to `Unique`'s, or impl'ing `Send` and `Sync` for `LruCache` with the appropriate bounds on `K` and `V`.  I ran into a couple of interesting issues while attempting to implement the former solution, and the latter is much cleaner (and was suggested by @cgaebel besides.).\r\n\r\nCloses #47.","created_at":"2015-01-02T00:12:46Z","updated_at":"2015-01-02T02:25:35Z","closed_at":"2015-01-02T02:25:35Z","merged_at":"2015-01-02T02:25:35Z","merge_commit_sha":"95e6d82095ae2fcf6bd3d45ef2f9cb7a461e398b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Gankro/collect-rs/pulls/57/commits","review_comments_url":"https://api.github.com/repos/Gankro/collect-rs/pulls/57/comments","review_comment_url":"https://api.github.com/repos/Gankro/collect-rs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Gankro/collect-rs/issues/57/comments","statuses_url":"https://api.github.com/repos/Gankro/collect-rs/statuses/89efe35d41202e0997c61049b9cb10489e1a4154","head":{"label":"csouth3:master","ref":"master","sha":"89efe35d41202e0997c61049b9cb10489e1a4154","user":{"login":"csouth3","id":6758080,"avatar_url":"https://avatars.githubusercontent.com/u/6758080?v=3","gravatar_id":"","url":"https://api.github.com/users/csouth3","html_url":"https://github.com/csouth3","followers_url":"https://api.github.com/users/csouth3/followers","following_url":"https://api.github.com/users/csouth3/following{/other_user}","gists_url":"https://api.github.com/users/csouth3/gists{/gist_id}","starred_url":"https://api.github.com/users/csouth3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csouth3/subscriptions","organizations_url":"https://api.github.com/users/csouth3/orgs","repos_url":"https://api.github.com/users/csouth3/repos","events_url":"https://api.github.com/users/csouth3/events{/privacy}","received_events_url":"https://api.github.com/users/csouth3/received_events","type":"User","site_admin":false},"repo":{"id":28219246,"name":"collect-rs","full_name":"csouth3/collect-rs","owner":{"login":"csouth3","id":6758080,"avatar_url":"https://avatars.githubusercontent.com/u/6758080?v=3","gravatar_id":"","url":"https://api.github.com/users/csouth3","html_url":"https://github.com/csouth3","followers_url":"https://api.github.com/users/csouth3/followers","following_url":"https://api.github.com/users/csouth3/following{/other_user}","gists_url":"https://api.github.com/users/csouth3/gists{/gist_id}","starred_url":"https://api.github.com/users/csouth3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csouth3/subscriptions","organizations_url":"https://api.github.com/users/csouth3/orgs","repos_url":"https://api.github.com/users/csouth3/repos","events_url":"https://api.github.com/users/csouth3/events{/privacy}","received_events_url":"https://api.github.com/users/csouth3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csouth3/collect-rs","description":"Miscellaneous Collections","fork":true,"url":"https://api.github.com/repos/csouth3/collect-rs","forks_url":"https://api.github.com/repos/csouth3/collect-rs/forks","keys_url":"https://api.github.com/repos/csouth3/collect-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csouth3/collect-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csouth3/collect-rs/teams","hooks_url":"https://api.github.com/repos/csouth3/collect-rs/hooks","issue_events_url":"https://api.github.com/repos/csouth3/collect-rs/issues/events{/number}","events_url":"https://api.github.com/repos/csouth3/collect-rs/events","assignees_url":"https://api.github.com/repos/csouth3/collect-rs/assignees{/user}","branches_url":"https://api.github.com/repos/csouth3/collect-rs/branches{/branch}","tags_url":"https://api.github.com/repos/csouth3/collect-rs/tags","blobs_url":"https://api.github.com/repos/csouth3/collect-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csouth3/collect-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csouth3/collect-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/csouth3/collect-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csouth3/collect-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/csouth3/collect-rs/languages","stargazers_url":"https://api.github.com/repos/csouth3/collect-rs/stargazers","contributors_url":"https://api.github.com/repos/csouth3/collect-rs/contributors","subscribers_url":"https://api.github.com/repos/csouth3/collect-rs/subscribers","subscription_url":"https://api.github.com/repos/csouth3/collect-rs/subscription","commits_url":"https://api.github.com/repos/csouth3/collect-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/csouth3/collect-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/csouth3/collect-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/csouth3/collect-rs/issues/comments/{number}","contents_url":"https://api.github.com/repos/csouth3/collect-rs/contents/{+path}","compare_url":"https://api.github.com/repos/csouth3/collect-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csouth3/collect-rs/merges","archive_url":"https://api.github.com/repos/csouth3/collect-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csouth3/collect-rs/downloads","issues_url":"https://api.github.com/repos/csouth3/collect-rs/issues{/number}","pulls_url":"https://api.github.com/repos/csouth3/collect-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/csouth3/collect-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/csouth3/collect-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csouth3/collect-rs/labels{/name}","releases_url":"https://api.github.com/repos/csouth3/collect-rs/releases{/id}","created_at":"2014-12-19T07:30:27Z","updated_at":"2015-01-02T00:03:46Z","pushed_at":"2015-01-02T00:03:45Z","git_url":"git://github.com/csouth3/collect-rs.git","ssh_url":"git@github.com:csouth3/collect-rs.git","clone_url":"https://github.com/csouth3/collect-rs.git","svn_url":"https://github.com/csouth3/collect-rs","homepage":"","size":216,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Gankro:master","ref":"master","sha":"941f904b5b0d5f4a37d5d920eb2ae8a3d90fbe45","user":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"repo":{"id":25849693,"name":"collect-rs","full_name":"Gankro/collect-rs","owner":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gankro/collect-rs","description":"Miscellaneous Collections","fork":false,"url":"https://api.github.com/repos/Gankro/collect-rs","forks_url":"https://api.github.com/repos/Gankro/collect-rs/forks","keys_url":"https://api.github.com/repos/Gankro/collect-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gankro/collect-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gankro/collect-rs/teams","hooks_url":"https://api.github.com/repos/Gankro/collect-rs/hooks","issue_events_url":"https://api.github.com/repos/Gankro/collect-rs/issues/events{/number}","events_url":"https://api.github.com/repos/Gankro/collect-rs/events","assignees_url":"https://api.github.com/repos/Gankro/collect-rs/assignees{/user}","branches_url":"https://api.github.com/repos/Gankro/collect-rs/branches{/branch}","tags_url":"https://api.github.com/repos/Gankro/collect-rs/tags","blobs_url":"https://api.github.com/repos/Gankro/collect-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gankro/collect-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gankro/collect-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gankro/collect-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gankro/collect-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/Gankro/collect-rs/languages","stargazers_url":"https://api.github.com/repos/Gankro/collect-rs/stargazers","contributors_url":"https://api.github.com/repos/Gankro/collect-rs/contributors","subscribers_url":"https://api.github.com/repos/Gankro/collect-rs/subscribers","subscription_url":"https://api.github.com/repos/Gankro/collect-rs/subscription","commits_url":"https://api.github.com/repos/Gankro/collect-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gankro/collect-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gankro/collect-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gankro/collect-rs/issues/comments/{number}","contents_url":"https://api.github.com/repos/Gankro/collect-rs/contents/{+path}","compare_url":"https://api.github.com/repos/Gankro/collect-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gankro/collect-rs/merges","archive_url":"https://api.github.com/repos/Gankro/collect-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gankro/collect-rs/downloads","issues_url":"https://api.github.com/repos/Gankro/collect-rs/issues{/number}","pulls_url":"https://api.github.com/repos/Gankro/collect-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/Gankro/collect-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/Gankro/collect-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gankro/collect-rs/labels{/name}","releases_url":"https://api.github.com/repos/Gankro/collect-rs/releases{/id}","created_at":"2014-10-28T02:35:00Z","updated_at":"2015-01-02T01:00:37Z","pushed_at":"2015-01-02T02:25:35Z","git_url":"git://github.com/Gankro/collect-rs.git","ssh_url":"git@github.com:Gankro/collect-rs.git","clone_url":"https://github.com/Gankro/collect-rs.git","svn_url":"https://github.com/Gankro/collect-rs","homepage":"","size":861,"stargazers_count":49,"watchers_count":49,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":20,"forks":16,"open_issues":20,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Gankro/collect-rs/pulls/57"},"html":{"href":"https://github.com/Gankro/collect-rs/pull/57"},"issue":{"href":"https://api.github.com/repos/Gankro/collect-rs/issues/57"},"comments":{"href":"https://api.github.com/repos/Gankro/collect-rs/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/Gankro/collect-rs/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/Gankro/collect-rs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Gankro/collect-rs/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/Gankro/collect-rs/statuses/89efe35d41202e0997c61049b9cb10489e1a4154"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"reem","id":4745181,"avatar_url":"https://avatars.githubusercontent.com/u/4745181?v=3","gravatar_id":"","url":"https://api.github.com/users/reem","html_url":"https://github.com/reem","followers_url":"https://api.github.com/users/reem/followers","following_url":"https://api.github.com/users/reem/following{/other_user}","gists_url":"https://api.github.com/users/reem/gists{/gist_id}","starred_url":"https://api.github.com/users/reem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reem/subscriptions","organizations_url":"https://api.github.com/users/reem/orgs","repos_url":"https://api.github.com/users/reem/repos","events_url":"https://api.github.com/users/reem/events{/privacy}","received_events_url":"https://api.github.com/users/reem/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":4,"deletions":0,"changed_files":1}}