{"action":"closed","number":140,"pull_request":{"url":"https://api.github.com/repos/jeremytregunna/ruby-trello/pulls/140","id":44264683,"html_url":"https://github.com/jeremytregunna/ruby-trello/pull/140","diff_url":"https://github.com/jeremytregunna/ruby-trello/pull/140.diff","patch_url":"https://github.com/jeremytregunna/ruby-trello/pull/140.patch","issue_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/issues/140","number":140,"state":"closed","locked":false,"title":"Tests/migrate to expect syntax","user":{"login":"acuppy","id":87721,"avatar_url":"https://avatars.githubusercontent.com/u/87721?v=3","gravatar_id":"","url":"https://api.github.com/users/acuppy","html_url":"https://github.com/acuppy","followers_url":"https://api.github.com/users/acuppy/followers","following_url":"https://api.github.com/users/acuppy/following{/other_user}","gists_url":"https://api.github.com/users/acuppy/gists{/gist_id}","starred_url":"https://api.github.com/users/acuppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acuppy/subscriptions","organizations_url":"https://api.github.com/users/acuppy/orgs","repos_url":"https://api.github.com/users/acuppy/repos","events_url":"https://api.github.com/users/acuppy/events{/privacy}","received_events_url":"https://api.github.com/users/acuppy/received_events","type":"User","site_admin":false},"body":"I'm working on migrating current specs to utilize the `expect` syntax over `should`.  Components of the migration include...\r\n\r\n1. Replace `object.value.should == 'expected'` with `expect(object.value).to eq 'expected'`\r\n3. Replace `object.should_receive(:method)` with `expect(object).to receive(:method)`\r\n1. Replace `object.stub(:method)` with `allow(object).to receive(:method)`\r\n2. Move stubs to a `before` block and out of the `it` expectation blocks\r\n4. In certain cases, DRY-up specs by extract common values into `let` and use `context` blocks to redefine a value, without duplicating the stub.\r\n5. Utilize RSpec's support for predicate methods: `expect(object.valid?).to be(true)` to `expect(object).to be_valid`","created_at":"2015-09-04T21:47:14Z","updated_at":"2015-09-22T00:06:39Z","closed_at":"2015-09-22T00:06:39Z","merged_at":"2015-09-22T00:06:39Z","merge_commit_sha":"e1df03343291b1ce352c2ba80f3875d7556ebdd7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/pulls/140/commits","review_comments_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/pulls/140/comments","review_comment_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/issues/140/comments","statuses_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/statuses/95aca658ebf627b1bc76b1794745ced865ef0542","head":{"label":"CodingZeal:tests/migrate-to-expect-syntax","ref":"tests/migrate-to-expect-syntax","sha":"95aca658ebf627b1bc76b1794745ced865ef0542","user":{"login":"CodingZeal","id":3019646,"avatar_url":"https://avatars.githubusercontent.com/u/3019646?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingZeal","html_url":"https://github.com/CodingZeal","followers_url":"https://api.github.com/users/CodingZeal/followers","following_url":"https://api.github.com/users/CodingZeal/following{/other_user}","gists_url":"https://api.github.com/users/CodingZeal/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingZeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingZeal/subscriptions","organizations_url":"https://api.github.com/users/CodingZeal/orgs","repos_url":"https://api.github.com/users/CodingZeal/repos","events_url":"https://api.github.com/users/CodingZeal/events{/privacy}","received_events_url":"https://api.github.com/users/CodingZeal/received_events","type":"Organization","site_admin":false},"repo":{"id":41776514,"name":"ruby-trello","full_name":"CodingZeal/ruby-trello","owner":{"login":"CodingZeal","id":3019646,"avatar_url":"https://avatars.githubusercontent.com/u/3019646?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingZeal","html_url":"https://github.com/CodingZeal","followers_url":"https://api.github.com/users/CodingZeal/followers","following_url":"https://api.github.com/users/CodingZeal/following{/other_user}","gists_url":"https://api.github.com/users/CodingZeal/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingZeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingZeal/subscriptions","organizations_url":"https://api.github.com/users/CodingZeal/orgs","repos_url":"https://api.github.com/users/CodingZeal/repos","events_url":"https://api.github.com/users/CodingZeal/events{/privacy}","received_events_url":"https://api.github.com/users/CodingZeal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodingZeal/ruby-trello","description":"Implementation of the Trello API for Ruby","fork":true,"url":"https://api.github.com/repos/CodingZeal/ruby-trello","forks_url":"https://api.github.com/repos/CodingZeal/ruby-trello/forks","keys_url":"https://api.github.com/repos/CodingZeal/ruby-trello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodingZeal/ruby-trello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodingZeal/ruby-trello/teams","hooks_url":"https://api.github.com/repos/CodingZeal/ruby-trello/hooks","issue_events_url":"https://api.github.com/repos/CodingZeal/ruby-trello/issues/events{/number}","events_url":"https://api.github.com/repos/CodingZeal/ruby-trello/events","assignees_url":"https://api.github.com/repos/CodingZeal/ruby-trello/assignees{/user}","branches_url":"https://api.github.com/repos/CodingZeal/ruby-trello/branches{/branch}","tags_url":"https://api.github.com/repos/CodingZeal/ruby-trello/tags","blobs_url":"https://api.github.com/repos/CodingZeal/ruby-trello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodingZeal/ruby-trello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodingZeal/ruby-trello/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodingZeal/ruby-trello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodingZeal/ruby-trello/statuses/{sha}","languages_url":"https://api.github.com/repos/CodingZeal/ruby-trello/languages","stargazers_url":"https://api.github.com/repos/CodingZeal/ruby-trello/stargazers","contributors_url":"https://api.github.com/repos/CodingZeal/ruby-trello/contributors","subscribers_url":"https://api.github.com/repos/CodingZeal/ruby-trello/subscribers","subscription_url":"https://api.github.com/repos/CodingZeal/ruby-trello/subscription","commits_url":"https://api.github.com/repos/CodingZeal/ruby-trello/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodingZeal/ruby-trello/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodingZeal/ruby-trello/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodingZeal/ruby-trello/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodingZeal/ruby-trello/contents/{+path}","compare_url":"https://api.github.com/repos/CodingZeal/ruby-trello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodingZeal/ruby-trello/merges","archive_url":"https://api.github.com/repos/CodingZeal/ruby-trello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodingZeal/ruby-trello/downloads","issues_url":"https://api.github.com/repos/CodingZeal/ruby-trello/issues{/number}","pulls_url":"https://api.github.com/repos/CodingZeal/ruby-trello/pulls{/number}","milestones_url":"https://api.github.com/repos/CodingZeal/ruby-trello/milestones{/number}","notifications_url":"https://api.github.com/repos/CodingZeal/ruby-trello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodingZeal/ruby-trello/labels{/name}","releases_url":"https://api.github.com/repos/CodingZeal/ruby-trello/releases{/id}","created_at":"2015-09-02T03:03:52Z","updated_at":"2015-09-02T03:03:52Z","pushed_at":"2015-09-21T18:16:53Z","git_url":"git://github.com/CodingZeal/ruby-trello.git","ssh_url":"git@github.com:CodingZeal/ruby-trello.git","clone_url":"https://github.com/CodingZeal/ruby-trello.git","svn_url":"https://github.com/CodingZeal/ruby-trello","homepage":"","size":965,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jeremytregunna:master","ref":"master","sha":"1d6ec1f37f98ae3d19f9126c4c71bfd4e2c098df","user":{"login":"jeremytregunna","id":261615,"avatar_url":"https://avatars.githubusercontent.com/u/261615?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremytregunna","html_url":"https://github.com/jeremytregunna","followers_url":"https://api.github.com/users/jeremytregunna/followers","following_url":"https://api.github.com/users/jeremytregunna/following{/other_user}","gists_url":"https://api.github.com/users/jeremytregunna/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremytregunna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremytregunna/subscriptions","organizations_url":"https://api.github.com/users/jeremytregunna/orgs","repos_url":"https://api.github.com/users/jeremytregunna/repos","events_url":"https://api.github.com/users/jeremytregunna/events{/privacy}","received_events_url":"https://api.github.com/users/jeremytregunna/received_events","type":"User","site_admin":false},"repo":{"id":3125120,"name":"ruby-trello","full_name":"jeremytregunna/ruby-trello","owner":{"login":"jeremytregunna","id":261615,"avatar_url":"https://avatars.githubusercontent.com/u/261615?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremytregunna","html_url":"https://github.com/jeremytregunna","followers_url":"https://api.github.com/users/jeremytregunna/followers","following_url":"https://api.github.com/users/jeremytregunna/following{/other_user}","gists_url":"https://api.github.com/users/jeremytregunna/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremytregunna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremytregunna/subscriptions","organizations_url":"https://api.github.com/users/jeremytregunna/orgs","repos_url":"https://api.github.com/users/jeremytregunna/repos","events_url":"https://api.github.com/users/jeremytregunna/events{/privacy}","received_events_url":"https://api.github.com/users/jeremytregunna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremytregunna/ruby-trello","description":"Implementation of the Trello API for Ruby","fork":false,"url":"https://api.github.com/repos/jeremytregunna/ruby-trello","forks_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/forks","keys_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/teams","hooks_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/hooks","issue_events_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/issues/events{/number}","events_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/events","assignees_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/assignees{/user}","branches_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/branches{/branch}","tags_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/tags","blobs_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/languages","stargazers_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/stargazers","contributors_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/contributors","subscribers_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/subscribers","subscription_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/subscription","commits_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/contents/{+path}","compare_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/merges","archive_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/downloads","issues_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/issues{/number}","pulls_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/labels{/name}","releases_url":"https://api.github.com/repos/jeremytregunna/ruby-trello/releases{/id}","created_at":"2012-01-07T15:54:31Z","updated_at":"2015-09-18T22:56:56Z","pushed_at":"2015-09-22T00:06:39Z","git_url":"git://github.com/jeremytregunna/ruby-trello.git","ssh_url":"git@github.com:jeremytregunna/ruby-trello.git","clone_url":"https://github.com/jeremytregunna/ruby-trello.git","svn_url":"https://github.com/jeremytregunna/ruby-trello","homepage":"","size":1741,"stargazers_count":463,"watchers_count":463,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":12,"forks":159,"open_issues":12,"watchers":463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jeremytregunna/ruby-trello/pulls/140"},"html":{"href":"https://github.com/jeremytregunna/ruby-trello/pull/140"},"issue":{"href":"https://api.github.com/repos/jeremytregunna/ruby-trello/issues/140"},"comments":{"href":"https://api.github.com/repos/jeremytregunna/ruby-trello/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/jeremytregunna/ruby-trello/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/jeremytregunna/ruby-trello/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jeremytregunna/ruby-trello/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/jeremytregunna/ruby-trello/statuses/95aca658ebf627b1bc76b1794745ced865ef0542"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"joneslee85","id":135605,"avatar_url":"https://avatars.githubusercontent.com/u/135605?v=3","gravatar_id":"","url":"https://api.github.com/users/joneslee85","html_url":"https://github.com/joneslee85","followers_url":"https://api.github.com/users/joneslee85/followers","following_url":"https://api.github.com/users/joneslee85/following{/other_user}","gists_url":"https://api.github.com/users/joneslee85/gists{/gist_id}","starred_url":"https://api.github.com/users/joneslee85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joneslee85/subscriptions","organizations_url":"https://api.github.com/users/joneslee85/orgs","repos_url":"https://api.github.com/users/joneslee85/repos","events_url":"https://api.github.com/users/joneslee85/events{/privacy}","received_events_url":"https://api.github.com/users/joneslee85/received_events","type":"User","site_admin":false},"comments":8,"review_comments":1,"commits":26,"additions":1075,"deletions":563,"changed_files":24}}