{"action":"created","issue":{"url":"https://api.github.com/repos/zquestz/omniauth-google-oauth2/issues/164","labels_url":"https://api.github.com/repos/zquestz/omniauth-google-oauth2/issues/164/labels{/name}","comments_url":"https://api.github.com/repos/zquestz/omniauth-google-oauth2/issues/164/comments","events_url":"https://api.github.com/repos/zquestz/omniauth-google-oauth2/issues/164/events","html_url":"https://github.com/zquestz/omniauth-google-oauth2/pull/164","id":59350948,"number":164,"title":"Add support for upgrading OpenID logins to OAuth logins","user":{"login":"tomhughes","id":147741,"avatar_url":"https://avatars.githubusercontent.com/u/147741?v=3","gravatar_id":"","url":"https://api.github.com/users/tomhughes","html_url":"https://github.com/tomhughes","followers_url":"https://api.github.com/users/tomhughes/followers","following_url":"https://api.github.com/users/tomhughes/following{/other_user}","gists_url":"https://api.github.com/users/tomhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/tomhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomhughes/subscriptions","organizations_url":"https://api.github.com/users/tomhughes/orgs","repos_url":"https://api.github.com/users/tomhughes/repos","events_url":"https://api.github.com/users/tomhughes/events{/privacy}","received_events_url":"https://api.github.com/users/tomhughes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-28T17:59:01Z","updated_at":"2015-03-12T18:27:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zquestz/omniauth-google-oauth2/pulls/164","html_url":"https://github.com/zquestz/omniauth-google-oauth2/pull/164","diff_url":"https://github.com/zquestz/omniauth-google-oauth2/pull/164.diff","patch_url":"https://github.com/zquestz/omniauth-google-oauth2/pull/164.patch"},"body":"This allows `openid.realm` to be specified in the request, and adds a copy of the decrypted ID token to the authentication hash so that the callback can access `openid_id` in order to do the upgrade.\r\n\r\nIt may be that there is a better way to make `openid_id` available than this, but the key thing is that it only seems to be available in the returned ID token, and not in the `/plus/v1/people/me/openIdConnect` response object. Currently the signature on the ID token is not being verified when decoding it, but `custom_build_access_token` has already done so I believe, and Google suggest it's not necessary for a server that has got the token directly from Google:\r\n\r\n* https://developers.google.com/accounts/docs/OpenIDConnect#obtainuserinfo\r\n* https://developers.google.com/accounts/docs/OpenIDConnect#validatinganidtoken\r\n\r\nThere are probably going to be an increasing number of people looking to be able to do this upgrade because OpenID 2.0 support is going away on 20th April (https://developers.google.com/accounts/docs/OpenID#shutdown-timetable)."},"comment":{"url":"https://api.github.com/repos/zquestz/omniauth-google-oauth2/issues/comments/78557226","html_url":"https://github.com/zquestz/omniauth-google-oauth2/pull/164#issuecomment-78557226","issue_url":"https://api.github.com/repos/zquestz/omniauth-google-oauth2/issues/164","id":78557226,"user":{"login":"ChrisBr","id":3799140,"avatar_url":"https://avatars.githubusercontent.com/u/3799140?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisBr","html_url":"https://github.com/ChrisBr","followers_url":"https://api.github.com/users/ChrisBr/followers","following_url":"https://api.github.com/users/ChrisBr/following{/other_user}","gists_url":"https://api.github.com/users/ChrisBr/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisBr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisBr/subscriptions","organizations_url":"https://api.github.com/users/ChrisBr/orgs","repos_url":"https://api.github.com/users/ChrisBr/repos","events_url":"https://api.github.com/users/ChrisBr/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisBr/received_events","type":"User","site_admin":false},"created_at":"2015-03-12T18:27:44Z","updated_at":"2015-03-12T18:27:44Z","body":"@zquestz Any chance to get this merged soon?\r\nAs @tomhughes pointed out, it would be very useful to upgrade from OpenID2.0"}}