{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/28300278","id":28300278,"diff_hunk":"@@ -10779,47 +10779,62 @@ static void f_jobresize(typval_T *argvars, typval_T *rettv)\n   rettv->vval.v_number = 1;\n }\n \n-// \"jobstart()\" function\n-static void f_jobstart(typval_T *argvars, typval_T *rettv)\n+static char** list_to_argv(list_T *args)","path":"src/nvim/eval.c","position":6,"original_position":6,"commit_id":"44e3f637eb541398904e237b722f2d6cdbf25ef8","original_commit_id":"44e3f637eb541398904e237b722f2d6cdbf25ef8","user":{"login":"Pyrohh","id":4174345,"avatar_url":"https://avatars.githubusercontent.com/u/4174345?v=3","gravatar_id":"","url":"https://api.github.com/users/Pyrohh","html_url":"https://github.com/Pyrohh","followers_url":"https://api.github.com/users/Pyrohh/followers","following_url":"https://api.github.com/users/Pyrohh/following{/other_user}","gists_url":"https://api.github.com/users/Pyrohh/gists{/gist_id}","starred_url":"https://api.github.com/users/Pyrohh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pyrohh/subscriptions","organizations_url":"https://api.github.com/users/Pyrohh/orgs","repos_url":"https://api.github.com/users/Pyrohh/repos","events_url":"https://api.github.com/users/Pyrohh/events{/privacy}","received_events_url":"https://api.github.com/users/Pyrohh/received_events","type":"User","site_admin":false},"body":"pointer alignment (I like the way you're doing it, but it's not project style)","created_at":"2015-04-14T04:43:14Z","updated_at":"2015-04-14T04:43:14Z","html_url":"https://github.com/neovim/neovim/pull/2424#discussion_r28300278","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/2424","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/28300278"},"html":{"href":"https://github.com/neovim/neovim/pull/2424#discussion_r28300278"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2424"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/2424","id":33225551,"html_url":"https://github.com/neovim/neovim/pull/2424","diff_url":"https://github.com/neovim/neovim/pull/2424.diff","patch_url":"https://github.com/neovim/neovim/pull/2424.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/2424","number":2424,"state":"open","locked":false,"title":"[WIP] term: use an argument vector for termopen().","user":{"login":"splinterofchaos","id":38515,"avatar_url":"https://avatars.githubusercontent.com/u/38515?v=3","gravatar_id":"","url":"https://api.github.com/users/splinterofchaos","html_url":"https://github.com/splinterofchaos","followers_url":"https://api.github.com/users/splinterofchaos/followers","following_url":"https://api.github.com/users/splinterofchaos/following{/other_user}","gists_url":"https://api.github.com/users/splinterofchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/splinterofchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splinterofchaos/subscriptions","organizations_url":"https://api.github.com/users/splinterofchaos/orgs","repos_url":"https://api.github.com/users/splinterofchaos/repos","events_url":"https://api.github.com/users/splinterofchaos/events{/privacy}","received_events_url":"https://api.github.com/users/splinterofchaos/received_events","type":"User","site_admin":false},"body":"Old behaviour: termopen('cmd') would run `&shell &shcf \"cmd\"`, which\r\ncaused the functional tests to fail on some systems due to the process\r\nnot \"owning\" the terminal. Also, it is inconsistent with jobstart().\r\n\r\nModify termopen() so that &shell is not invoked, but maintain the old\r\nbehaviour with :terminal. Factor the common code for building the\r\nargument vector from jobstart() and modify the functional tests to call\r\ntermopen() instead of :terminal (fixes #2354).\r\n\r\n---\r\n\r\nStill [WIP] because I have yet to implement a correct naming scheme for the buffer (https://github.com/neovim/neovim/issues/2354#issuecomment-92532588), though I'm considering an alternative: add a `'name'` field to the options dictionary and set it to `{cmd}` from `ex_terminal`. Could be useful in general.\r\n\r\nAlso, I added a few tests for `:terminal`, since its behaviour now differs from `termopen()`, but I couldn't avoid using the Unix-specific `sh` without rewriting `tty-test.c` to not propagate the problem from #2354, or make another test shell. \r\n\r\nWill work on this more tomorrow.","created_at":"2015-04-14T04:28:54Z","updated_at":"2015-04-14T04:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59150999e3f3d86c444e0d36d34f8c6bc9810222","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/2424/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/2424/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/2424/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/44e3f637eb541398904e237b722f2d6cdbf25ef8","head":{"label":"splinterofchaos:term-no-sh","ref":"term-no-sh","sha":"44e3f637eb541398904e237b722f2d6cdbf25ef8","user":{"login":"splinterofchaos","id":38515,"avatar_url":"https://avatars.githubusercontent.com/u/38515?v=3","gravatar_id":"","url":"https://api.github.com/users/splinterofchaos","html_url":"https://github.com/splinterofchaos","followers_url":"https://api.github.com/users/splinterofchaos/followers","following_url":"https://api.github.com/users/splinterofchaos/following{/other_user}","gists_url":"https://api.github.com/users/splinterofchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/splinterofchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splinterofchaos/subscriptions","organizations_url":"https://api.github.com/users/splinterofchaos/orgs","repos_url":"https://api.github.com/users/splinterofchaos/repos","events_url":"https://api.github.com/users/splinterofchaos/events{/privacy}","received_events_url":"https://api.github.com/users/splinterofchaos/received_events","type":"User","site_admin":false},"repo":{"id":21571013,"name":"neovim","full_name":"splinterofchaos/neovim","owner":{"login":"splinterofchaos","id":38515,"avatar_url":"https://avatars.githubusercontent.com/u/38515?v=3","gravatar_id":"","url":"https://api.github.com/users/splinterofchaos","html_url":"https://github.com/splinterofchaos","followers_url":"https://api.github.com/users/splinterofchaos/followers","following_url":"https://api.github.com/users/splinterofchaos/following{/other_user}","gists_url":"https://api.github.com/users/splinterofchaos/gists{/gist_id}","starred_url":"https://api.github.com/users/splinterofchaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splinterofchaos/subscriptions","organizations_url":"https://api.github.com/users/splinterofchaos/orgs","repos_url":"https://api.github.com/users/splinterofchaos/repos","events_url":"https://api.github.com/users/splinterofchaos/events{/privacy}","received_events_url":"https://api.github.com/users/splinterofchaos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/splinterofchaos/neovim","description":"vim for the 21st century","fork":true,"url":"https://api.github.com/repos/splinterofchaos/neovim","forks_url":"https://api.github.com/repos/splinterofchaos/neovim/forks","keys_url":"https://api.github.com/repos/splinterofchaos/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splinterofchaos/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splinterofchaos/neovim/teams","hooks_url":"https://api.github.com/repos/splinterofchaos/neovim/hooks","issue_events_url":"https://api.github.com/repos/splinterofchaos/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/splinterofchaos/neovim/events","assignees_url":"https://api.github.com/repos/splinterofchaos/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/splinterofchaos/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/splinterofchaos/neovim/tags","blobs_url":"https://api.github.com/repos/splinterofchaos/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splinterofchaos/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splinterofchaos/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/splinterofchaos/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splinterofchaos/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/splinterofchaos/neovim/languages","stargazers_url":"https://api.github.com/repos/splinterofchaos/neovim/stargazers","contributors_url":"https://api.github.com/repos/splinterofchaos/neovim/contributors","subscribers_url":"https://api.github.com/repos/splinterofchaos/neovim/subscribers","subscription_url":"https://api.github.com/repos/splinterofchaos/neovim/subscription","commits_url":"https://api.github.com/repos/splinterofchaos/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/splinterofchaos/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/splinterofchaos/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/splinterofchaos/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/splinterofchaos/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/splinterofchaos/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splinterofchaos/neovim/merges","archive_url":"https://api.github.com/repos/splinterofchaos/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splinterofchaos/neovim/downloads","issues_url":"https://api.github.com/repos/splinterofchaos/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/splinterofchaos/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/splinterofchaos/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/splinterofchaos/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splinterofchaos/neovim/labels{/name}","releases_url":"https://api.github.com/repos/splinterofchaos/neovim/releases{/id}","created_at":"2014-07-07T13:13:12Z","updated_at":"2015-04-12T21:59:36Z","pushed_at":"2015-04-14T04:17:38Z","git_url":"git://github.com/splinterofchaos/neovim.git","ssh_url":"git@github.com:splinterofchaos/neovim.git","clone_url":"https://github.com/splinterofchaos/neovim.git","svn_url":"https://github.com/splinterofchaos/neovim","homepage":"http://neovim.org/","size":31356,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"54bd3843384af34c895942acb32ca3996d5cb614","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim out of the box","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2015-04-14T03:38:16Z","pushed_at":"2015-04-14T04:28:55Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org","size":64743,"stargazers_count":12880,"watchers_count":12880,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":869,"mirror_url":null,"open_issues_count":436,"forks":869,"open_issues":436,"watchers":12880,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2424"},"html":{"href":"https://github.com/neovim/neovim/pull/2424"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/2424"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/2424/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2424/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2424/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/44e3f637eb541398904e237b722f2d6cdbf25ef8"}}}}