{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/38505614","id":38505614,"diff_hunk":"@@ -66,6 +71,118 @@ static unsigned long HostToIP(const std::string& host)\n   return inet_addr(ip.c_str());\n }\n \n+#define LOCALIZED(id) g_localizeStrings.Get(id)\n+\n+static void ShowDiscoveryMessage(const char* function, const char* server_name, bool new_entry)\n+{\n+  std::string message, heading = LOCALIZED(13033);\n+\n+  if (new_entry)\n+  {\n+    CLog::Log(LOGINFO, \"%s - Create new entry for host '%s'\", function, server_name);\n+    message = StringUtils::Format(LOCALIZED(13035).c_str(), server_name);\n+  }\n+  else\n+  {\n+    CLog::Log(LOGINFO, \"%s - Update existing entry for host '%s'\", function, server_name);\n+    message = StringUtils::Format(LOCALIZED(13034).c_str(), server_name);\n+  }\n+  CGUIDialogKaiToast::QueueNotification(CGUIDialogKaiToast::Info, heading, message, 4000, true, 3000);","path":"xbmc/network/WakeOnAccess.cpp","position":32,"original_position":32,"commit_id":"db552ce43d6a000746be1ee5c9e65256fb1c1108","original_commit_id":"db552ce43d6a000746be1ee5c9e65256fb1c1108","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"body":"Yes it's relatively new. Look for `CEventLog::GetInstance()` in the existing code base. I added a few usages. You can either just create an event for the event log or also tell it to show a kai toast notification.\r\n\r\nBut I wouldn't let this block this PR, it was just an idea.","created_at":"2015-09-02T07:37:53Z","updated_at":"2015-09-02T07:37:53Z","html_url":"https://github.com/xbmc/xbmc/pull/4940#discussion_r38505614","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/4940","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/38505614"},"html":{"href":"https://github.com/xbmc/xbmc/pull/4940#discussion_r38505614"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/4940"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/4940","id":17391956,"html_url":"https://github.com/xbmc/xbmc/pull/4940","diff_url":"https://github.com/xbmc/xbmc/pull/4940.diff","patch_url":"https://github.com/xbmc/xbmc/pull/4940.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/4940","number":4940,"state":"open","locked":false,"title":"wake on access - upnp support (v2)","user":{"login":"t4-ravenbird","id":1905855,"avatar_url":"https://avatars.githubusercontent.com/u/1905855?v=3","gravatar_id":"","url":"https://api.github.com/users/t4-ravenbird","html_url":"https://github.com/t4-ravenbird","followers_url":"https://api.github.com/users/t4-ravenbird/followers","following_url":"https://api.github.com/users/t4-ravenbird/following{/other_user}","gists_url":"https://api.github.com/users/t4-ravenbird/gists{/gist_id}","starred_url":"https://api.github.com/users/t4-ravenbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t4-ravenbird/subscriptions","organizations_url":"https://api.github.com/users/t4-ravenbird/orgs","repos_url":"https://api.github.com/users/t4-ravenbird/repos","events_url":"https://api.github.com/users/t4-ravenbird/events{/privacy}","received_events_url":"https://api.github.com/users/t4-ravenbird/received_events","type":"User","site_admin":false},"body":"This pr adds support for waking upnp-servers and replaces PR https://github.com/xbmc/xbmc/pull/4104\r\n\r\nref this post and onwards : http://forum.xbmc.org/showthread.php?tid=124340&pid=1611088#pid1611088\r\nand : http://trac.xbmc.org/ticket/14880\r\n\r\nShould work fine also for upnp-servers hosted on machines with DHCP assigned ipaddresses since alive-test ('ping') now is done by probing availability of the upnp-server rather than actual ping","created_at":"2014-06-20T07:13:54Z","updated_at":"2015-09-02T07:37:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70edd101ec00601c75c4f9e4c8d0ee6fa46a767b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/4940/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/4940/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/4940/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/db552ce43d6a000746be1ee5c9e65256fb1c1108","head":{"label":"t4-ravenbird:woa_upnp2","ref":"woa_upnp2","sha":"db552ce43d6a000746be1ee5c9e65256fb1c1108","user":{"login":"t4-ravenbird","id":1905855,"avatar_url":"https://avatars.githubusercontent.com/u/1905855?v=3","gravatar_id":"","url":"https://api.github.com/users/t4-ravenbird","html_url":"https://github.com/t4-ravenbird","followers_url":"https://api.github.com/users/t4-ravenbird/followers","following_url":"https://api.github.com/users/t4-ravenbird/following{/other_user}","gists_url":"https://api.github.com/users/t4-ravenbird/gists{/gist_id}","starred_url":"https://api.github.com/users/t4-ravenbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t4-ravenbird/subscriptions","organizations_url":"https://api.github.com/users/t4-ravenbird/orgs","repos_url":"https://api.github.com/users/t4-ravenbird/repos","events_url":"https://api.github.com/users/t4-ravenbird/events{/privacy}","received_events_url":"https://api.github.com/users/t4-ravenbird/received_events","type":"User","site_admin":false},"repo":{"id":4831944,"name":"xbmc","full_name":"t4-ravenbird/xbmc","owner":{"login":"t4-ravenbird","id":1905855,"avatar_url":"https://avatars.githubusercontent.com/u/1905855?v=3","gravatar_id":"","url":"https://api.github.com/users/t4-ravenbird","html_url":"https://github.com/t4-ravenbird","followers_url":"https://api.github.com/users/t4-ravenbird/followers","following_url":"https://api.github.com/users/t4-ravenbird/following{/other_user}","gists_url":"https://api.github.com/users/t4-ravenbird/gists{/gist_id}","starred_url":"https://api.github.com/users/t4-ravenbird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t4-ravenbird/subscriptions","organizations_url":"https://api.github.com/users/t4-ravenbird/orgs","repos_url":"https://api.github.com/users/t4-ravenbird/repos","events_url":"https://api.github.com/users/t4-ravenbird/events{/privacy}","received_events_url":"https://api.github.com/users/t4-ravenbird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/t4-ravenbird/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/t4-ravenbird/xbmc","forks_url":"https://api.github.com/repos/t4-ravenbird/xbmc/forks","keys_url":"https://api.github.com/repos/t4-ravenbird/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/t4-ravenbird/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/t4-ravenbird/xbmc/teams","hooks_url":"https://api.github.com/repos/t4-ravenbird/xbmc/hooks","issue_events_url":"https://api.github.com/repos/t4-ravenbird/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/t4-ravenbird/xbmc/events","assignees_url":"https://api.github.com/repos/t4-ravenbird/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/t4-ravenbird/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/t4-ravenbird/xbmc/tags","blobs_url":"https://api.github.com/repos/t4-ravenbird/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/t4-ravenbird/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/t4-ravenbird/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/t4-ravenbird/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/t4-ravenbird/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/t4-ravenbird/xbmc/languages","stargazers_url":"https://api.github.com/repos/t4-ravenbird/xbmc/stargazers","contributors_url":"https://api.github.com/repos/t4-ravenbird/xbmc/contributors","subscribers_url":"https://api.github.com/repos/t4-ravenbird/xbmc/subscribers","subscription_url":"https://api.github.com/repos/t4-ravenbird/xbmc/subscription","commits_url":"https://api.github.com/repos/t4-ravenbird/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/t4-ravenbird/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/t4-ravenbird/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/t4-ravenbird/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/t4-ravenbird/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/t4-ravenbird/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/t4-ravenbird/xbmc/merges","archive_url":"https://api.github.com/repos/t4-ravenbird/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/t4-ravenbird/xbmc/downloads","issues_url":"https://api.github.com/repos/t4-ravenbird/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/t4-ravenbird/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/t4-ravenbird/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/t4-ravenbird/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/t4-ravenbird/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/t4-ravenbird/xbmc/releases{/id}","created_at":"2012-06-29T12:16:40Z","updated_at":"2014-07-08T08:38:42Z","pushed_at":"2015-09-02T07:14:33Z","git_url":"git://github.com/t4-ravenbird/xbmc.git","ssh_url":"git@github.com:t4-ravenbird/xbmc.git","clone_url":"https://github.com/t4-ravenbird/xbmc.git","svn_url":"https://github.com/t4-ravenbird/xbmc","homepage":"http://xbmc.org","size":522099,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"a9a6ad6b69c1195ac705d02e2c7be68af9eb7b02","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-09-02T03:04:48Z","pushed_at":"2015-09-02T07:14:35Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1887471,"stargazers_count":4078,"watchers_count":4078,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2997,"mirror_url":null,"open_issues_count":201,"forks":2997,"open_issues":201,"watchers":4078,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/4940"},"html":{"href":"https://github.com/xbmc/xbmc/pull/4940"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/4940"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/4940/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/4940/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/4940/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/db552ce43d6a000746be1ee5c9e65256fb1c1108"}}}}