{"action":"opened","number":20,"pull_request":{"url":"https://api.github.com/repos/manukall/phoenix_token_auth/pulls/20","id":39917079,"html_url":"https://github.com/manukall/phoenix_token_auth/pull/20","diff_url":"https://github.com/manukall/phoenix_token_auth/pull/20.diff","patch_url":"https://github.com/manukall/phoenix_token_auth/pull/20.patch","issue_url":"https://api.github.com/repos/manukall/phoenix_token_auth/issues/20","number":20,"state":"open","locked":false,"title":"Refactor","user":{"login":"alexjp","id":85806,"avatar_url":"https://avatars.githubusercontent.com/u/85806?v=3","gravatar_id":"","url":"https://api.github.com/users/alexjp","html_url":"https://github.com/alexjp","followers_url":"https://api.github.com/users/alexjp/followers","following_url":"https://api.github.com/users/alexjp/following{/other_user}","gists_url":"https://api.github.com/users/alexjp/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjp/subscriptions","organizations_url":"https://api.github.com/users/alexjp/orgs","repos_url":"https://api.github.com/users/alexjp/repos","events_url":"https://api.github.com/users/alexjp/events{/privacy}","received_events_url":"https://api.github.com/users/alexjp/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI made a clean new approach, change as little as i can.\r\nThis should be all that is needed to work with simple-ember-auth. ( one pull request without touching the email settings ( will be next ) )\r\nI think the correct \"functional programming\" way is to create a new function with the correct params ( as opposed to creating ifs and elses ).\r\n\r\nWhat do you think ? Is the refactor branch the correct one  ?","created_at":"2015-07-14T13:46:46Z","updated_at":"2015-07-14T13:46:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/manukall/phoenix_token_auth/pulls/20/commits","review_comments_url":"https://api.github.com/repos/manukall/phoenix_token_auth/pulls/20/comments","review_comment_url":"https://api.github.com/repos/manukall/phoenix_token_auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/manukall/phoenix_token_auth/issues/20/comments","statuses_url":"https://api.github.com/repos/manukall/phoenix_token_auth/statuses/648655d571f0092838467f54b9c8365393c80a93","head":{"label":"alexjp:refactor","ref":"refactor","sha":"648655d571f0092838467f54b9c8365393c80a93","user":{"login":"alexjp","id":85806,"avatar_url":"https://avatars.githubusercontent.com/u/85806?v=3","gravatar_id":"","url":"https://api.github.com/users/alexjp","html_url":"https://github.com/alexjp","followers_url":"https://api.github.com/users/alexjp/followers","following_url":"https://api.github.com/users/alexjp/following{/other_user}","gists_url":"https://api.github.com/users/alexjp/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjp/subscriptions","organizations_url":"https://api.github.com/users/alexjp/orgs","repos_url":"https://api.github.com/users/alexjp/repos","events_url":"https://api.github.com/users/alexjp/events{/privacy}","received_events_url":"https://api.github.com/users/alexjp/received_events","type":"User","site_admin":false},"repo":{"id":38300032,"name":"phoenix_token_auth","full_name":"alexjp/phoenix_token_auth","owner":{"login":"alexjp","id":85806,"avatar_url":"https://avatars.githubusercontent.com/u/85806?v=3","gravatar_id":"","url":"https://api.github.com/users/alexjp","html_url":"https://github.com/alexjp","followers_url":"https://api.github.com/users/alexjp/followers","following_url":"https://api.github.com/users/alexjp/following{/other_user}","gists_url":"https://api.github.com/users/alexjp/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjp/subscriptions","organizations_url":"https://api.github.com/users/alexjp/orgs","repos_url":"https://api.github.com/users/alexjp/repos","events_url":"https://api.github.com/users/alexjp/events{/privacy}","received_events_url":"https://api.github.com/users/alexjp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexjp/phoenix_token_auth","description":"Token authentication solution for Phoenix. Useful for APIs for i.e. single page apps.","fork":true,"url":"https://api.github.com/repos/alexjp/phoenix_token_auth","forks_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/forks","keys_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/teams","hooks_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/hooks","issue_events_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/issues/events{/number}","events_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/events","assignees_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/assignees{/user}","branches_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/branches{/branch}","tags_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/tags","blobs_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/statuses/{sha}","languages_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/languages","stargazers_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/stargazers","contributors_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/contributors","subscribers_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/subscribers","subscription_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/subscription","commits_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/contents/{+path}","compare_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/merges","archive_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/downloads","issues_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/issues{/number}","pulls_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/pulls{/number}","milestones_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/milestones{/number}","notifications_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/labels{/name}","releases_url":"https://api.github.com/repos/alexjp/phoenix_token_auth/releases{/id}","created_at":"2015-06-30T09:24:05Z","updated_at":"2015-07-14T13:28:06Z","pushed_at":"2015-07-14T13:44:32Z","git_url":"git://github.com/alexjp/phoenix_token_auth.git","ssh_url":"git@github.com:alexjp/phoenix_token_auth.git","clone_url":"https://github.com/alexjp/phoenix_token_auth.git","svn_url":"https://github.com/alexjp/phoenix_token_auth","homepage":null,"size":203,"stargazers_count":2,"watchers_count":2,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"manukall:refactor","ref":"refactor","sha":"bf135ab893b711b9dba45954bc145703a903a392","user":{"login":"manukall","id":117418,"avatar_url":"https://avatars.githubusercontent.com/u/117418?v=3","gravatar_id":"","url":"https://api.github.com/users/manukall","html_url":"https://github.com/manukall","followers_url":"https://api.github.com/users/manukall/followers","following_url":"https://api.github.com/users/manukall/following{/other_user}","gists_url":"https://api.github.com/users/manukall/gists{/gist_id}","starred_url":"https://api.github.com/users/manukall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manukall/subscriptions","organizations_url":"https://api.github.com/users/manukall/orgs","repos_url":"https://api.github.com/users/manukall/repos","events_url":"https://api.github.com/users/manukall/events{/privacy}","received_events_url":"https://api.github.com/users/manukall/received_events","type":"User","site_admin":false},"repo":{"id":32013650,"name":"phoenix_token_auth","full_name":"manukall/phoenix_token_auth","owner":{"login":"manukall","id":117418,"avatar_url":"https://avatars.githubusercontent.com/u/117418?v=3","gravatar_id":"","url":"https://api.github.com/users/manukall","html_url":"https://github.com/manukall","followers_url":"https://api.github.com/users/manukall/followers","following_url":"https://api.github.com/users/manukall/following{/other_user}","gists_url":"https://api.github.com/users/manukall/gists{/gist_id}","starred_url":"https://api.github.com/users/manukall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manukall/subscriptions","organizations_url":"https://api.github.com/users/manukall/orgs","repos_url":"https://api.github.com/users/manukall/repos","events_url":"https://api.github.com/users/manukall/events{/privacy}","received_events_url":"https://api.github.com/users/manukall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manukall/phoenix_token_auth","description":"Token authentication solution for Phoenix. Useful for APIs for i.e. single page apps.","fork":false,"url":"https://api.github.com/repos/manukall/phoenix_token_auth","forks_url":"https://api.github.com/repos/manukall/phoenix_token_auth/forks","keys_url":"https://api.github.com/repos/manukall/phoenix_token_auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manukall/phoenix_token_auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manukall/phoenix_token_auth/teams","hooks_url":"https://api.github.com/repos/manukall/phoenix_token_auth/hooks","issue_events_url":"https://api.github.com/repos/manukall/phoenix_token_auth/issues/events{/number}","events_url":"https://api.github.com/repos/manukall/phoenix_token_auth/events","assignees_url":"https://api.github.com/repos/manukall/phoenix_token_auth/assignees{/user}","branches_url":"https://api.github.com/repos/manukall/phoenix_token_auth/branches{/branch}","tags_url":"https://api.github.com/repos/manukall/phoenix_token_auth/tags","blobs_url":"https://api.github.com/repos/manukall/phoenix_token_auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manukall/phoenix_token_auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manukall/phoenix_token_auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/manukall/phoenix_token_auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manukall/phoenix_token_auth/statuses/{sha}","languages_url":"https://api.github.com/repos/manukall/phoenix_token_auth/languages","stargazers_url":"https://api.github.com/repos/manukall/phoenix_token_auth/stargazers","contributors_url":"https://api.github.com/repos/manukall/phoenix_token_auth/contributors","subscribers_url":"https://api.github.com/repos/manukall/phoenix_token_auth/subscribers","subscription_url":"https://api.github.com/repos/manukall/phoenix_token_auth/subscription","commits_url":"https://api.github.com/repos/manukall/phoenix_token_auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/manukall/phoenix_token_auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/manukall/phoenix_token_auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/manukall/phoenix_token_auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/manukall/phoenix_token_auth/contents/{+path}","compare_url":"https://api.github.com/repos/manukall/phoenix_token_auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manukall/phoenix_token_auth/merges","archive_url":"https://api.github.com/repos/manukall/phoenix_token_auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manukall/phoenix_token_auth/downloads","issues_url":"https://api.github.com/repos/manukall/phoenix_token_auth/issues{/number}","pulls_url":"https://api.github.com/repos/manukall/phoenix_token_auth/pulls{/number}","milestones_url":"https://api.github.com/repos/manukall/phoenix_token_auth/milestones{/number}","notifications_url":"https://api.github.com/repos/manukall/phoenix_token_auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manukall/phoenix_token_auth/labels{/name}","releases_url":"https://api.github.com/repos/manukall/phoenix_token_auth/releases{/id}","created_at":"2015-03-11T11:17:25Z","updated_at":"2015-07-13T19:40:58Z","pushed_at":"2015-07-10T08:55:36Z","git_url":"git://github.com/manukall/phoenix_token_auth.git","ssh_url":"git@github.com:manukall/phoenix_token_auth.git","clone_url":"https://github.com/manukall/phoenix_token_auth.git","svn_url":"https://github.com/manukall/phoenix_token_auth","homepage":null,"size":314,"stargazers_count":44,"watchers_count":44,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/manukall/phoenix_token_auth/pulls/20"},"html":{"href":"https://github.com/manukall/phoenix_token_auth/pull/20"},"issue":{"href":"https://api.github.com/repos/manukall/phoenix_token_auth/issues/20"},"comments":{"href":"https://api.github.com/repos/manukall/phoenix_token_auth/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/manukall/phoenix_token_auth/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/manukall/phoenix_token_auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/manukall/phoenix_token_auth/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/manukall/phoenix_token_auth/statuses/648655d571f0092838467f54b9c8365393c80a93"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":22,"deletions":3,"changed_files":3}}