{"action":"created","comment":{"url":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/comments/42770203","id":42770203,"diff_hunk":"@@ -74,8 +74,8 @@ namespace AnaSamples\n         }\n \n         const T& null() const {return nullT_;}\n-    protected:\n         std::map<std::string, T> sampleSet_;\n+    protected:","path":"Tools/samples.h","position":6,"original_position":6,"commit_id":"f19c4d91d5ebb06eaaa80b8b771ba794c1938a88","original_commit_id":"f19c4d91d5ebb06eaaa80b8b771ba794c1938a88","user":{"login":"pastika","id":4933791,"avatar_url":"https://avatars.githubusercontent.com/u/4933791?v=3","gravatar_id":"","url":"https://api.github.com/users/pastika","html_url":"https://github.com/pastika","followers_url":"https://api.github.com/users/pastika/followers","following_url":"https://api.github.com/users/pastika/following{/other_user}","gists_url":"https://api.github.com/users/pastika/gists{/gist_id}","starred_url":"https://api.github.com/users/pastika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pastika/subscriptions","organizations_url":"https://api.github.com/users/pastika/orgs","repos_url":"https://api.github.com/users/pastika/repos","events_url":"https://api.github.com/users/pastika/events{/privacy}","received_events_url":"https://api.github.com/users/pastika/received_events","type":"User","site_admin":false},"body":"I would rather keep this variable protected, what functionality does this allow?","created_at":"2015-10-22T16:19:17Z","updated_at":"2015-10-22T16:19:17Z","html_url":"https://github.com/susy2015/SusyAnaTools/pull/43#discussion_r42770203","pull_request_url":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/comments/42770203"},"html":{"href":"https://github.com/susy2015/SusyAnaTools/pull/43#discussion_r42770203"},"pull_request":{"href":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/43","id":48476668,"html_url":"https://github.com/susy2015/SusyAnaTools/pull/43","diff_url":"https://github.com/susy2015/SusyAnaTools/pull/43.diff","patch_url":"https://github.com/susy2015/SusyAnaTools/pull/43.patch","issue_url":"https://api.github.com/repos/susy2015/SusyAnaTools/issues/43","number":43,"state":"open","locked":false,"title":"NtupleReader for both Spring15 and PHY14","user":{"login":"zhenbinwu","id":1052165,"avatar_url":"https://avatars.githubusercontent.com/u/1052165?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenbinwu","html_url":"https://github.com/zhenbinwu","followers_url":"https://api.github.com/users/zhenbinwu/followers","following_url":"https://api.github.com/users/zhenbinwu/following{/other_user}","gists_url":"https://api.github.com/users/zhenbinwu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenbinwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenbinwu/subscriptions","organizations_url":"https://api.github.com/users/zhenbinwu/orgs","repos_url":"https://api.github.com/users/zhenbinwu/repos","events_url":"https://api.github.com/users/zhenbinwu/events{/privacy}","received_events_url":"https://api.github.com/users/zhenbinwu/received_events","type":"User","site_admin":false},"body":"Propose to just merge the NtupleReader.h and baselineDef.h, in case other uses\r\nneeded. \r\n\r\nUsing a throw to catch the expectation when running on PHYS14 samples\r\nAdded a getMap function to retrieve the std::map without casted to vector<pair>\r\n\r\nPlease rebase the other changes in files, which is needed for my own framework\r\n\r\n","created_at":"2015-10-22T15:57:30Z","updated_at":"2015-10-22T16:19:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"692df05c74ae6493f44ce4b4d4e3d8ed6b18d70a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/43/commits","review_comments_url":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/43/comments","review_comment_url":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/susy2015/SusyAnaTools/issues/43/comments","statuses_url":"https://api.github.com/repos/susy2015/SusyAnaTools/statuses/f19c4d91d5ebb06eaaa80b8b771ba794c1938a88","head":{"label":"susy2015:ZhenbinLocal","ref":"ZhenbinLocal","sha":"f19c4d91d5ebb06eaaa80b8b771ba794c1938a88","user":{"login":"susy2015","id":10456629,"avatar_url":"https://avatars.githubusercontent.com/u/10456629?v=3","gravatar_id":"","url":"https://api.github.com/users/susy2015","html_url":"https://github.com/susy2015","followers_url":"https://api.github.com/users/susy2015/followers","following_url":"https://api.github.com/users/susy2015/following{/other_user}","gists_url":"https://api.github.com/users/susy2015/gists{/gist_id}","starred_url":"https://api.github.com/users/susy2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susy2015/subscriptions","organizations_url":"https://api.github.com/users/susy2015/orgs","repos_url":"https://api.github.com/users/susy2015/repos","events_url":"https://api.github.com/users/susy2015/events{/privacy}","received_events_url":"https://api.github.com/users/susy2015/received_events","type":"Organization","site_admin":false},"repo":{"id":28991617,"name":"SusyAnaTools","full_name":"susy2015/SusyAnaTools","owner":{"login":"susy2015","id":10456629,"avatar_url":"https://avatars.githubusercontent.com/u/10456629?v=3","gravatar_id":"","url":"https://api.github.com/users/susy2015","html_url":"https://github.com/susy2015","followers_url":"https://api.github.com/users/susy2015/followers","following_url":"https://api.github.com/users/susy2015/following{/other_user}","gists_url":"https://api.github.com/users/susy2015/gists{/gist_id}","starred_url":"https://api.github.com/users/susy2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susy2015/subscriptions","organizations_url":"https://api.github.com/users/susy2015/orgs","repos_url":"https://api.github.com/users/susy2015/repos","events_url":"https://api.github.com/users/susy2015/events{/privacy}","received_events_url":"https://api.github.com/users/susy2015/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/susy2015/SusyAnaTools","description":"","fork":false,"url":"https://api.github.com/repos/susy2015/SusyAnaTools","forks_url":"https://api.github.com/repos/susy2015/SusyAnaTools/forks","keys_url":"https://api.github.com/repos/susy2015/SusyAnaTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/susy2015/SusyAnaTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/susy2015/SusyAnaTools/teams","hooks_url":"https://api.github.com/repos/susy2015/SusyAnaTools/hooks","issue_events_url":"https://api.github.com/repos/susy2015/SusyAnaTools/issues/events{/number}","events_url":"https://api.github.com/repos/susy2015/SusyAnaTools/events","assignees_url":"https://api.github.com/repos/susy2015/SusyAnaTools/assignees{/user}","branches_url":"https://api.github.com/repos/susy2015/SusyAnaTools/branches{/branch}","tags_url":"https://api.github.com/repos/susy2015/SusyAnaTools/tags","blobs_url":"https://api.github.com/repos/susy2015/SusyAnaTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/susy2015/SusyAnaTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/susy2015/SusyAnaTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/susy2015/SusyAnaTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/susy2015/SusyAnaTools/statuses/{sha}","languages_url":"https://api.github.com/repos/susy2015/SusyAnaTools/languages","stargazers_url":"https://api.github.com/repos/susy2015/SusyAnaTools/stargazers","contributors_url":"https://api.github.com/repos/susy2015/SusyAnaTools/contributors","subscribers_url":"https://api.github.com/repos/susy2015/SusyAnaTools/subscribers","subscription_url":"https://api.github.com/repos/susy2015/SusyAnaTools/subscription","commits_url":"https://api.github.com/repos/susy2015/SusyAnaTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/susy2015/SusyAnaTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/susy2015/SusyAnaTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/susy2015/SusyAnaTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/susy2015/SusyAnaTools/contents/{+path}","compare_url":"https://api.github.com/repos/susy2015/SusyAnaTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/susy2015/SusyAnaTools/merges","archive_url":"https://api.github.com/repos/susy2015/SusyAnaTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/susy2015/SusyAnaTools/downloads","issues_url":"https://api.github.com/repos/susy2015/SusyAnaTools/issues{/number}","pulls_url":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls{/number}","milestones_url":"https://api.github.com/repos/susy2015/SusyAnaTools/milestones{/number}","notifications_url":"https://api.github.com/repos/susy2015/SusyAnaTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/susy2015/SusyAnaTools/labels{/name}","releases_url":"https://api.github.com/repos/susy2015/SusyAnaTools/releases{/id}","created_at":"2015-01-08T23:36:57Z","updated_at":"2015-09-21T21:22:20Z","pushed_at":"2015-10-22T15:57:31Z","git_url":"git://github.com/susy2015/SusyAnaTools.git","ssh_url":"git@github.com:susy2015/SusyAnaTools.git","clone_url":"https://github.com/susy2015/SusyAnaTools.git","svn_url":"https://github.com/susy2015/SusyAnaTools","homepage":null,"size":3718,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"susy2015:master","ref":"master","sha":"9ccfc82b359bea19c5394da9d70f7d2909e11cf3","user":{"login":"susy2015","id":10456629,"avatar_url":"https://avatars.githubusercontent.com/u/10456629?v=3","gravatar_id":"","url":"https://api.github.com/users/susy2015","html_url":"https://github.com/susy2015","followers_url":"https://api.github.com/users/susy2015/followers","following_url":"https://api.github.com/users/susy2015/following{/other_user}","gists_url":"https://api.github.com/users/susy2015/gists{/gist_id}","starred_url":"https://api.github.com/users/susy2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susy2015/subscriptions","organizations_url":"https://api.github.com/users/susy2015/orgs","repos_url":"https://api.github.com/users/susy2015/repos","events_url":"https://api.github.com/users/susy2015/events{/privacy}","received_events_url":"https://api.github.com/users/susy2015/received_events","type":"Organization","site_admin":false},"repo":{"id":28991617,"name":"SusyAnaTools","full_name":"susy2015/SusyAnaTools","owner":{"login":"susy2015","id":10456629,"avatar_url":"https://avatars.githubusercontent.com/u/10456629?v=3","gravatar_id":"","url":"https://api.github.com/users/susy2015","html_url":"https://github.com/susy2015","followers_url":"https://api.github.com/users/susy2015/followers","following_url":"https://api.github.com/users/susy2015/following{/other_user}","gists_url":"https://api.github.com/users/susy2015/gists{/gist_id}","starred_url":"https://api.github.com/users/susy2015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susy2015/subscriptions","organizations_url":"https://api.github.com/users/susy2015/orgs","repos_url":"https://api.github.com/users/susy2015/repos","events_url":"https://api.github.com/users/susy2015/events{/privacy}","received_events_url":"https://api.github.com/users/susy2015/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/susy2015/SusyAnaTools","description":"","fork":false,"url":"https://api.github.com/repos/susy2015/SusyAnaTools","forks_url":"https://api.github.com/repos/susy2015/SusyAnaTools/forks","keys_url":"https://api.github.com/repos/susy2015/SusyAnaTools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/susy2015/SusyAnaTools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/susy2015/SusyAnaTools/teams","hooks_url":"https://api.github.com/repos/susy2015/SusyAnaTools/hooks","issue_events_url":"https://api.github.com/repos/susy2015/SusyAnaTools/issues/events{/number}","events_url":"https://api.github.com/repos/susy2015/SusyAnaTools/events","assignees_url":"https://api.github.com/repos/susy2015/SusyAnaTools/assignees{/user}","branches_url":"https://api.github.com/repos/susy2015/SusyAnaTools/branches{/branch}","tags_url":"https://api.github.com/repos/susy2015/SusyAnaTools/tags","blobs_url":"https://api.github.com/repos/susy2015/SusyAnaTools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/susy2015/SusyAnaTools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/susy2015/SusyAnaTools/git/refs{/sha}","trees_url":"https://api.github.com/repos/susy2015/SusyAnaTools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/susy2015/SusyAnaTools/statuses/{sha}","languages_url":"https://api.github.com/repos/susy2015/SusyAnaTools/languages","stargazers_url":"https://api.github.com/repos/susy2015/SusyAnaTools/stargazers","contributors_url":"https://api.github.com/repos/susy2015/SusyAnaTools/contributors","subscribers_url":"https://api.github.com/repos/susy2015/SusyAnaTools/subscribers","subscription_url":"https://api.github.com/repos/susy2015/SusyAnaTools/subscription","commits_url":"https://api.github.com/repos/susy2015/SusyAnaTools/commits{/sha}","git_commits_url":"https://api.github.com/repos/susy2015/SusyAnaTools/git/commits{/sha}","comments_url":"https://api.github.com/repos/susy2015/SusyAnaTools/comments{/number}","issue_comment_url":"https://api.github.com/repos/susy2015/SusyAnaTools/issues/comments{/number}","contents_url":"https://api.github.com/repos/susy2015/SusyAnaTools/contents/{+path}","compare_url":"https://api.github.com/repos/susy2015/SusyAnaTools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/susy2015/SusyAnaTools/merges","archive_url":"https://api.github.com/repos/susy2015/SusyAnaTools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/susy2015/SusyAnaTools/downloads","issues_url":"https://api.github.com/repos/susy2015/SusyAnaTools/issues{/number}","pulls_url":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls{/number}","milestones_url":"https://api.github.com/repos/susy2015/SusyAnaTools/milestones{/number}","notifications_url":"https://api.github.com/repos/susy2015/SusyAnaTools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/susy2015/SusyAnaTools/labels{/name}","releases_url":"https://api.github.com/repos/susy2015/SusyAnaTools/releases{/id}","created_at":"2015-01-08T23:36:57Z","updated_at":"2015-09-21T21:22:20Z","pushed_at":"2015-10-22T15:57:31Z","git_url":"git://github.com/susy2015/SusyAnaTools.git","ssh_url":"git@github.com:susy2015/SusyAnaTools.git","clone_url":"https://github.com/susy2015/SusyAnaTools.git","svn_url":"https://github.com/susy2015/SusyAnaTools","homepage":null,"size":3718,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/43"},"html":{"href":"https://github.com/susy2015/SusyAnaTools/pull/43"},"issue":{"href":"https://api.github.com/repos/susy2015/SusyAnaTools/issues/43"},"comments":{"href":"https://api.github.com/repos/susy2015/SusyAnaTools/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/susy2015/SusyAnaTools/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/susy2015/SusyAnaTools/statuses/f19c4d91d5ebb06eaaa80b8b771ba794c1938a88"}}}}