{"action":"created","issue":{"url":"https://api.github.com/repos/biometrics/janus/issues/17","labels_url":"https://api.github.com/repos/biometrics/janus/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/biometrics/janus/issues/17/comments","events_url":"https://api.github.com/repos/biometrics/janus/issues/17/events","html_url":"https://github.com/biometrics/janus/pull/17","id":68717657,"number":17,"title":"Proposed Phase 2 API changes","user":{"login":"jklontz","id":682795,"avatar_url":"https://avatars.githubusercontent.com/u/682795?v=3","gravatar_id":"","url":"https://api.github.com/users/jklontz","html_url":"https://github.com/jklontz","followers_url":"https://api.github.com/users/jklontz/followers","following_url":"https://api.github.com/users/jklontz/following{/other_user}","gists_url":"https://api.github.com/users/jklontz/gists{/gist_id}","starred_url":"https://api.github.com/users/jklontz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklontz/subscriptions","organizations_url":"https://api.github.com/users/jklontz/orgs","repos_url":"https://api.github.com/users/jklontz/repos","events_url":"https://api.github.com/users/jklontz/events{/privacy}","received_events_url":"https://api.github.com/users/jklontz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-15T15:46:58Z","updated_at":"2015-04-15T17:50:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/biometrics/janus/pulls/17","html_url":"https://github.com/biometrics/janus/pull/17","diff_url":"https://github.com/biometrics/janus/pull/17.diff","patch_url":"https://github.com/biometrics/janus/pull/17.patch"},"body":"The pull request contains the API changes proposed for phase 2. Here's the summary of changes:\r\n\r\n- `janus_attributes_list` refactored as `janus_attributes`:\r\nThe new `janus_attributes` obviates the need for memory allocation on the implementation side, and thus obviates the need to introduce a function to deallocate the memory. It's also now easier for clients to retrieve the value of a specific attribute. The tradeoff is that the client must allocate memory to store all possible `JANUS_NUM_ATTRIBUTES` attributes, some of which may end up being unpopulated.\r\n\r\n- `janus_detect` introduced:\r\nThis is now a prerequisite for `janus_augment`.\r\n\r\n- `janus_track` dropped:\r\nA change in the semantics of `janus_augment` obviated the need for this function.\r\n\r\n- `JANUS_INVALID_ATTRIBUTE` enum dropped:\r\nThe change in semantics of `janus_attributes` obviated the need for this enum value.\r\n\r\n- `JANUS_FRAME` enum dropped:\r\nThere isn't a clean way to propagate this information, and it doesn't seem to be needed anyway.\r\n\r\n- `int` parameters in `janus_search` changed to `size_t`.\r\n- Bumped version number to 0.4.0.\r\n- Removed `iarpa_janus_aux.h` placeholder header file.\r\n\r\nThe evaluation harness will be updated after the API changes are accepted."},"comment":{"url":"https://api.github.com/repos/biometrics/janus/issues/comments/93499325","html_url":"https://github.com/biometrics/janus/pull/17#issuecomment-93499325","issue_url":"https://api.github.com/repos/biometrics/janus/issues/17","id":93499325,"user":{"login":"bhklein","id":5815577,"avatar_url":"https://avatars.githubusercontent.com/u/5815577?v=3","gravatar_id":"","url":"https://api.github.com/users/bhklein","html_url":"https://github.com/bhklein","followers_url":"https://api.github.com/users/bhklein/followers","following_url":"https://api.github.com/users/bhklein/following{/other_user}","gists_url":"https://api.github.com/users/bhklein/gists{/gist_id}","starred_url":"https://api.github.com/users/bhklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhklein/subscriptions","organizations_url":"https://api.github.com/users/bhklein/orgs","repos_url":"https://api.github.com/users/bhklein/repos","events_url":"https://api.github.com/users/bhklein/events{/privacy}","received_events_url":"https://api.github.com/users/bhklein/received_events","type":"User","site_admin":false},"created_at":"2015-04-15T17:50:11Z","updated_at":"2015-04-15T17:50:11Z","body":"looks good to me"}}