{"action":"opened","number":32,"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/32","id":45972640,"html_url":"https://github.com/rapid7/metasploit-payloads/pull/32","diff_url":"https://github.com/rapid7/metasploit-payloads/pull/32.diff","patch_url":"https://github.com/rapid7/metasploit-payloads/pull/32.patch","issue_url":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/32","number":32,"state":"open","locked":false,"title":"Support transport failover for SSL cert failures","user":{"login":"OJ","id":28896,"avatar_url":"https://avatars.githubusercontent.com/u/28896?v=3","gravatar_id":"","url":"https://api.github.com/users/OJ","html_url":"https://github.com/OJ","followers_url":"https://api.github.com/users/OJ/followers","following_url":"https://api.github.com/users/OJ/following{/other_user}","gists_url":"https://api.github.com/users/OJ/gists{/gist_id}","starred_url":"https://api.github.com/users/OJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJ/subscriptions","organizations_url":"https://api.github.com/users/OJ/orgs","repos_url":"https://api.github.com/users/OJ/repos","events_url":"https://api.github.com/users/OJ/events{/privacy}","received_events_url":"https://api.github.com/users/OJ/received_events","type":"User","site_admin":false},"body":"This commit will result in SSL cert failures causing failovers to other transports, even to itself, instead of shutting the session down. This will result in repeated calls back to the endpoint, every \"retry wait\" seconds, and will continue to do so until the session expires, or the SSL verification works.\r\n\r\nBe warned, this can be noisy in your console if you haven't configured things properly. The result is a lot of callbacks over the life of the session.\r\n\r\nThis is the result of the discussion located here https://github.com/rapid7/metasploit-framework/issues/5661\r\n\r\n### Verification\r\n\r\nTest 1:\r\n- [ ] Create a stageless https payload that requires SSL validation.\r\n- [ ] Create a listener on the same configuration that uses a different SSL cert (ie. don't specify one at all).\r\n- [ ] Run the payload, and watch it fail after redirection. Constantly.\r\n\r\nTest 2:\r\n- [ ] Create a normal tcp payload.\r\n- [ ] Create a tcp listener for the payload.\r\n- [ ] Run the payload, establish a meterpreter session.\r\n- [ ] Create an https listener without a cert.\r\n- [ ] Add a new transport to the existing meterpreter session that uses SSL verfication: `transport add -t reverse_https -l <host> -p <port> -c <path to PEM>`\r\n- [ ] Swap transports: `transport next`\r\n- [ ] Verify that the transport attempts to connect to the https endpoint, but immediately gives up and reverts to the TCP transport.","created_at":"2015-09-25T02:55:06Z","updated_at":"2015-09-25T02:55:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/32/commits","review_comments_url":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/32/comments","review_comment_url":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/32/comments","statuses_url":"https://api.github.com/repos/rapid7/metasploit-payloads/statuses/2422f0926be6e6c620973e2dd0c1f7f8e08a977c","head":{"label":"OJ:ssl-verify-fix","ref":"ssl-verify-fix","sha":"2422f0926be6e6c620973e2dd0c1f7f8e08a977c","user":{"login":"OJ","id":28896,"avatar_url":"https://avatars.githubusercontent.com/u/28896?v=3","gravatar_id":"","url":"https://api.github.com/users/OJ","html_url":"https://github.com/OJ","followers_url":"https://api.github.com/users/OJ/followers","following_url":"https://api.github.com/users/OJ/following{/other_user}","gists_url":"https://api.github.com/users/OJ/gists{/gist_id}","starred_url":"https://api.github.com/users/OJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJ/subscriptions","organizations_url":"https://api.github.com/users/OJ/orgs","repos_url":"https://api.github.com/users/OJ/repos","events_url":"https://api.github.com/users/OJ/events{/privacy}","received_events_url":"https://api.github.com/users/OJ/received_events","type":"User","site_admin":false},"repo":{"id":38216107,"name":"metasploit-payloads","full_name":"OJ/metasploit-payloads","owner":{"login":"OJ","id":28896,"avatar_url":"https://avatars.githubusercontent.com/u/28896?v=3","gravatar_id":"","url":"https://api.github.com/users/OJ","html_url":"https://github.com/OJ","followers_url":"https://api.github.com/users/OJ/followers","following_url":"https://api.github.com/users/OJ/following{/other_user}","gists_url":"https://api.github.com/users/OJ/gists{/gist_id}","starred_url":"https://api.github.com/users/OJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OJ/subscriptions","organizations_url":"https://api.github.com/users/OJ/orgs","repos_url":"https://api.github.com/users/OJ/repos","events_url":"https://api.github.com/users/OJ/events{/privacy}","received_events_url":"https://api.github.com/users/OJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OJ/metasploit-payloads","description":"Unified repository for different Metasploit Framework payloads","fork":true,"url":"https://api.github.com/repos/OJ/metasploit-payloads","forks_url":"https://api.github.com/repos/OJ/metasploit-payloads/forks","keys_url":"https://api.github.com/repos/OJ/metasploit-payloads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OJ/metasploit-payloads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OJ/metasploit-payloads/teams","hooks_url":"https://api.github.com/repos/OJ/metasploit-payloads/hooks","issue_events_url":"https://api.github.com/repos/OJ/metasploit-payloads/issues/events{/number}","events_url":"https://api.github.com/repos/OJ/metasploit-payloads/events","assignees_url":"https://api.github.com/repos/OJ/metasploit-payloads/assignees{/user}","branches_url":"https://api.github.com/repos/OJ/metasploit-payloads/branches{/branch}","tags_url":"https://api.github.com/repos/OJ/metasploit-payloads/tags","blobs_url":"https://api.github.com/repos/OJ/metasploit-payloads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OJ/metasploit-payloads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OJ/metasploit-payloads/git/refs{/sha}","trees_url":"https://api.github.com/repos/OJ/metasploit-payloads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OJ/metasploit-payloads/statuses/{sha}","languages_url":"https://api.github.com/repos/OJ/metasploit-payloads/languages","stargazers_url":"https://api.github.com/repos/OJ/metasploit-payloads/stargazers","contributors_url":"https://api.github.com/repos/OJ/metasploit-payloads/contributors","subscribers_url":"https://api.github.com/repos/OJ/metasploit-payloads/subscribers","subscription_url":"https://api.github.com/repos/OJ/metasploit-payloads/subscription","commits_url":"https://api.github.com/repos/OJ/metasploit-payloads/commits{/sha}","git_commits_url":"https://api.github.com/repos/OJ/metasploit-payloads/git/commits{/sha}","comments_url":"https://api.github.com/repos/OJ/metasploit-payloads/comments{/number}","issue_comment_url":"https://api.github.com/repos/OJ/metasploit-payloads/issues/comments{/number}","contents_url":"https://api.github.com/repos/OJ/metasploit-payloads/contents/{+path}","compare_url":"https://api.github.com/repos/OJ/metasploit-payloads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OJ/metasploit-payloads/merges","archive_url":"https://api.github.com/repos/OJ/metasploit-payloads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OJ/metasploit-payloads/downloads","issues_url":"https://api.github.com/repos/OJ/metasploit-payloads/issues{/number}","pulls_url":"https://api.github.com/repos/OJ/metasploit-payloads/pulls{/number}","milestones_url":"https://api.github.com/repos/OJ/metasploit-payloads/milestones{/number}","notifications_url":"https://api.github.com/repos/OJ/metasploit-payloads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OJ/metasploit-payloads/labels{/name}","releases_url":"https://api.github.com/repos/OJ/metasploit-payloads/releases{/id}","created_at":"2015-06-28T22:10:43Z","updated_at":"2015-06-28T22:10:52Z","pushed_at":"2015-09-25T02:49:23Z","git_url":"git://github.com/OJ/metasploit-payloads.git","ssh_url":"git@github.com:OJ/metasploit-payloads.git","clone_url":"https://github.com/OJ/metasploit-payloads.git","svn_url":"https://github.com/OJ/metasploit-payloads","homepage":"","size":21971,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"863a729ebe6417616694e420b7c036b254345fc6","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":18418533,"name":"metasploit-payloads","full_name":"rapid7/metasploit-payloads","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/metasploit-payloads","description":"Unified repository for different Metasploit Framework payloads","fork":false,"url":"https://api.github.com/repos/rapid7/metasploit-payloads","forks_url":"https://api.github.com/repos/rapid7/metasploit-payloads/forks","keys_url":"https://api.github.com/repos/rapid7/metasploit-payloads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/metasploit-payloads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/metasploit-payloads/teams","hooks_url":"https://api.github.com/repos/rapid7/metasploit-payloads/hooks","issue_events_url":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/metasploit-payloads/events","assignees_url":"https://api.github.com/repos/rapid7/metasploit-payloads/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/metasploit-payloads/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/metasploit-payloads/tags","blobs_url":"https://api.github.com/repos/rapid7/metasploit-payloads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/metasploit-payloads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/metasploit-payloads/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/metasploit-payloads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/metasploit-payloads/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/metasploit-payloads/languages","stargazers_url":"https://api.github.com/repos/rapid7/metasploit-payloads/stargazers","contributors_url":"https://api.github.com/repos/rapid7/metasploit-payloads/contributors","subscribers_url":"https://api.github.com/repos/rapid7/metasploit-payloads/subscribers","subscription_url":"https://api.github.com/repos/rapid7/metasploit-payloads/subscription","commits_url":"https://api.github.com/repos/rapid7/metasploit-payloads/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/metasploit-payloads/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/metasploit-payloads/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/metasploit-payloads/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/metasploit-payloads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/metasploit-payloads/merges","archive_url":"https://api.github.com/repos/rapid7/metasploit-payloads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/metasploit-payloads/downloads","issues_url":"https://api.github.com/repos/rapid7/metasploit-payloads/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/metasploit-payloads/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/metasploit-payloads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/metasploit-payloads/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/metasploit-payloads/releases{/id}","created_at":"2014-04-03T21:18:24Z","updated_at":"2015-09-19T22:47:55Z","pushed_at":"2015-09-24T06:27:14Z","git_url":"git://github.com/rapid7/metasploit-payloads.git","ssh_url":"git@github.com:rapid7/metasploit-payloads.git","clone_url":"https://github.com/rapid7/metasploit-payloads.git","svn_url":"https://github.com/rapid7/metasploit-payloads","homepage":"","size":22394,"stargazers_count":34,"watchers_count":34,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":7,"forks":27,"open_issues":7,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/32"},"html":{"href":"https://github.com/rapid7/metasploit-payloads/pull/32"},"issue":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/32"},"comments":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/metasploit-payloads/statuses/2422f0926be6e6c620973e2dd0c1f7f8e08a977c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":22,"deletions":12,"changed_files":2}}