{"action":"created","comment":{"url":"https://api.github.com/repos/fontforge/fontforge/pulls/comments/33461612","id":33461612,"diff_hunk":"@@ -9142,63 +9142,81 @@ return( NULL );\n return( sf );\n }\n \n-static int ask_about_file(FILE *asfd,int *state,char *filename) {\n+/**\n+ * Asks the user whether or not to recover, skip or delete an autosaved file.\n+ * If requested by the user, this function will attempt to delete the file.\n+ * @param [in] filename The path to the autosaved file.\n+ * @param [in,out] state The current state.\n+ *                 state&1: Recover all. state&2: Forget all.\n+ * @param [out] asfd Location to store the file pointer to the autosaved file.\n+ * @return true iff the file is to be recovered. If true, asfd will hold the\n+ *         corresponding file pointer, which must be closed by the caller. If\n+ *         false, asfd will hold NULL.\n+ */\n+static int ask_about_file(char *filename, int *state, FILE **asfd) {","path":"fontforge/sfd.c","position":16,"original_position":16,"commit_id":"f810b3f4b9e963ddba3dfc2ed2a996f13b2d50ba","original_commit_id":"f810b3f4b9e963ddba3dfc2ed2a996f13b2d50ba","user":{"login":"jtanx","id":5137410,"avatar_url":"https://avatars.githubusercontent.com/u/5137410?v=3","gravatar_id":"","url":"https://api.github.com/users/jtanx","html_url":"https://github.com/jtanx","followers_url":"https://api.github.com/users/jtanx/followers","following_url":"https://api.github.com/users/jtanx/following{/other_user}","gists_url":"https://api.github.com/users/jtanx/gists{/gist_id}","starred_url":"https://api.github.com/users/jtanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtanx/subscriptions","organizations_url":"https://api.github.com/users/jtanx/orgs","repos_url":"https://api.github.com/users/jtanx/repos","events_url":"https://api.github.com/users/jtanx/events{/privacy}","received_events_url":"https://api.github.com/users/jtanx/received_events","type":"User","site_admin":false},"body":"Mostly it was just about ordering input parameters before output parameters.","created_at":"2015-06-29T13:13:12Z","updated_at":"2015-06-29T13:13:12Z","html_url":"https://github.com/fontforge/fontforge/pull/2375#discussion_r33461612","pull_request_url":"https://api.github.com/repos/fontforge/fontforge/pulls/2375","_links":{"self":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/comments/33461612"},"html":{"href":"https://github.com/fontforge/fontforge/pull/2375#discussion_r33461612"},"pull_request":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/2375"}}},"pull_request":{"url":"https://api.github.com/repos/fontforge/fontforge/pulls/2375","id":37675316,"html_url":"https://github.com/fontforge/fontforge/pull/2375","diff_url":"https://github.com/fontforge/fontforge/pull/2375.diff","patch_url":"https://github.com/fontforge/fontforge/pull/2375.patch","issue_url":"https://api.github.com/repos/fontforge/fontforge/issues/2375","number":2375,"state":"open","locked":false,"title":"Windows Mingw+CygWin patches","user":{"login":"jtanx","id":5137410,"avatar_url":"https://avatars.githubusercontent.com/u/5137410?v=3","gravatar_id":"","url":"https://api.github.com/users/jtanx","html_url":"https://github.com/jtanx","followers_url":"https://api.github.com/users/jtanx/followers","following_url":"https://api.github.com/users/jtanx/following{/other_user}","gists_url":"https://api.github.com/users/jtanx/gists{/gist_id}","starred_url":"https://api.github.com/users/jtanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtanx/subscriptions","organizations_url":"https://api.github.com/users/jtanx/orgs","repos_url":"https://api.github.com/users/jtanx/repos","events_url":"https://api.github.com/users/jtanx/events{/privacy}","received_events_url":"https://api.github.com/users/jtanx/received_events","type":"User","site_admin":false},"body":"This was split from #2299.\r\n\r\n* Fix autorecover 'forget about it' and 'forget to all' bug on Windows (MinGW) @frank-trampe I added more comments and slightly reworked it to make it more obvious that the file pointer may be closed by `ask_about_file`.\r\n* Fix hotkey saving on Windows (MinGW)\r\n* Pull in most of the patches from the [CygWin build](http://www.geocities.jp/meir000/fontforge/fontforge-20150121-cygwin.patch.txt).\r\n\r\n-----\r\nOn Windows, you can only unlink a file that has no open file handles.\r\nSo do `fclose` before `unlink`.","created_at":"2015-06-15T09:58:30Z","updated_at":"2015-06-29T13:13:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e66cd9e2a2117366eda8577f0d964dee88edf81a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fontforge/fontforge/pulls/2375/commits","review_comments_url":"https://api.github.com/repos/fontforge/fontforge/pulls/2375/comments","review_comment_url":"https://api.github.com/repos/fontforge/fontforge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fontforge/fontforge/issues/2375/comments","statuses_url":"https://api.github.com/repos/fontforge/fontforge/statuses/f810b3f4b9e963ddba3dfc2ed2a996f13b2d50ba","head":{"label":"jtanx:winbugs","ref":"winbugs","sha":"f810b3f4b9e963ddba3dfc2ed2a996f13b2d50ba","user":{"login":"jtanx","id":5137410,"avatar_url":"https://avatars.githubusercontent.com/u/5137410?v=3","gravatar_id":"","url":"https://api.github.com/users/jtanx","html_url":"https://github.com/jtanx","followers_url":"https://api.github.com/users/jtanx/followers","following_url":"https://api.github.com/users/jtanx/following{/other_user}","gists_url":"https://api.github.com/users/jtanx/gists{/gist_id}","starred_url":"https://api.github.com/users/jtanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtanx/subscriptions","organizations_url":"https://api.github.com/users/jtanx/orgs","repos_url":"https://api.github.com/users/jtanx/repos","events_url":"https://api.github.com/users/jtanx/events{/privacy}","received_events_url":"https://api.github.com/users/jtanx/received_events","type":"User","site_admin":false},"repo":{"id":15699071,"name":"fontforge","full_name":"jtanx/fontforge","owner":{"login":"jtanx","id":5137410,"avatar_url":"https://avatars.githubusercontent.com/u/5137410?v=3","gravatar_id":"","url":"https://api.github.com/users/jtanx","html_url":"https://github.com/jtanx","followers_url":"https://api.github.com/users/jtanx/followers","following_url":"https://api.github.com/users/jtanx/following{/other_user}","gists_url":"https://api.github.com/users/jtanx/gists{/gist_id}","starred_url":"https://api.github.com/users/jtanx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtanx/subscriptions","organizations_url":"https://api.github.com/users/jtanx/orgs","repos_url":"https://api.github.com/users/jtanx/repos","events_url":"https://api.github.com/users/jtanx/events{/privacy}","received_events_url":"https://api.github.com/users/jtanx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtanx/fontforge","description":"A font editor","fork":true,"url":"https://api.github.com/repos/jtanx/fontforge","forks_url":"https://api.github.com/repos/jtanx/fontforge/forks","keys_url":"https://api.github.com/repos/jtanx/fontforge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtanx/fontforge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtanx/fontforge/teams","hooks_url":"https://api.github.com/repos/jtanx/fontforge/hooks","issue_events_url":"https://api.github.com/repos/jtanx/fontforge/issues/events{/number}","events_url":"https://api.github.com/repos/jtanx/fontforge/events","assignees_url":"https://api.github.com/repos/jtanx/fontforge/assignees{/user}","branches_url":"https://api.github.com/repos/jtanx/fontforge/branches{/branch}","tags_url":"https://api.github.com/repos/jtanx/fontforge/tags","blobs_url":"https://api.github.com/repos/jtanx/fontforge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtanx/fontforge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtanx/fontforge/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtanx/fontforge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtanx/fontforge/statuses/{sha}","languages_url":"https://api.github.com/repos/jtanx/fontforge/languages","stargazers_url":"https://api.github.com/repos/jtanx/fontforge/stargazers","contributors_url":"https://api.github.com/repos/jtanx/fontforge/contributors","subscribers_url":"https://api.github.com/repos/jtanx/fontforge/subscribers","subscription_url":"https://api.github.com/repos/jtanx/fontforge/subscription","commits_url":"https://api.github.com/repos/jtanx/fontforge/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtanx/fontforge/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtanx/fontforge/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtanx/fontforge/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtanx/fontforge/contents/{+path}","compare_url":"https://api.github.com/repos/jtanx/fontforge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtanx/fontforge/merges","archive_url":"https://api.github.com/repos/jtanx/fontforge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtanx/fontforge/downloads","issues_url":"https://api.github.com/repos/jtanx/fontforge/issues{/number}","pulls_url":"https://api.github.com/repos/jtanx/fontforge/pulls{/number}","milestones_url":"https://api.github.com/repos/jtanx/fontforge/milestones{/number}","notifications_url":"https://api.github.com/repos/jtanx/fontforge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtanx/fontforge/labels{/name}","releases_url":"https://api.github.com/repos/jtanx/fontforge/releases{/id}","created_at":"2014-01-07T08:32:40Z","updated_at":"2015-04-25T01:17:11Z","pushed_at":"2015-06-29T13:08:47Z","git_url":"git://github.com/jtanx/fontforge.git","ssh_url":"git@github.com:jtanx/fontforge.git","clone_url":"https://github.com/jtanx/fontforge.git","svn_url":"https://github.com/jtanx/fontforge","homepage":"http://fontforge.org","size":76546,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fontforge:master","ref":"master","sha":"99da6faa1ea3b4f80ecd333f596ea7dab205325e","user":{"login":"fontforge","id":2048660,"avatar_url":"https://avatars.githubusercontent.com/u/2048660?v=3","gravatar_id":"","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"repo":{"id":5390156,"name":"fontforge","full_name":"fontforge/fontforge","owner":{"login":"fontforge","id":2048660,"avatar_url":"https://avatars.githubusercontent.com/u/2048660?v=3","gravatar_id":"","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fontforge/fontforge","description":"Free (libre) font editor for Windows, Mac OS X and GNU+Linux","fork":false,"url":"https://api.github.com/repos/fontforge/fontforge","forks_url":"https://api.github.com/repos/fontforge/fontforge/forks","keys_url":"https://api.github.com/repos/fontforge/fontforge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fontforge/fontforge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fontforge/fontforge/teams","hooks_url":"https://api.github.com/repos/fontforge/fontforge/hooks","issue_events_url":"https://api.github.com/repos/fontforge/fontforge/issues/events{/number}","events_url":"https://api.github.com/repos/fontforge/fontforge/events","assignees_url":"https://api.github.com/repos/fontforge/fontforge/assignees{/user}","branches_url":"https://api.github.com/repos/fontforge/fontforge/branches{/branch}","tags_url":"https://api.github.com/repos/fontforge/fontforge/tags","blobs_url":"https://api.github.com/repos/fontforge/fontforge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fontforge/fontforge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fontforge/fontforge/git/refs{/sha}","trees_url":"https://api.github.com/repos/fontforge/fontforge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fontforge/fontforge/statuses/{sha}","languages_url":"https://api.github.com/repos/fontforge/fontforge/languages","stargazers_url":"https://api.github.com/repos/fontforge/fontforge/stargazers","contributors_url":"https://api.github.com/repos/fontforge/fontforge/contributors","subscribers_url":"https://api.github.com/repos/fontforge/fontforge/subscribers","subscription_url":"https://api.github.com/repos/fontforge/fontforge/subscription","commits_url":"https://api.github.com/repos/fontforge/fontforge/commits{/sha}","git_commits_url":"https://api.github.com/repos/fontforge/fontforge/git/commits{/sha}","comments_url":"https://api.github.com/repos/fontforge/fontforge/comments{/number}","issue_comment_url":"https://api.github.com/repos/fontforge/fontforge/issues/comments{/number}","contents_url":"https://api.github.com/repos/fontforge/fontforge/contents/{+path}","compare_url":"https://api.github.com/repos/fontforge/fontforge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fontforge/fontforge/merges","archive_url":"https://api.github.com/repos/fontforge/fontforge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fontforge/fontforge/downloads","issues_url":"https://api.github.com/repos/fontforge/fontforge/issues{/number}","pulls_url":"https://api.github.com/repos/fontforge/fontforge/pulls{/number}","milestones_url":"https://api.github.com/repos/fontforge/fontforge/milestones{/number}","notifications_url":"https://api.github.com/repos/fontforge/fontforge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fontforge/fontforge/labels{/name}","releases_url":"https://api.github.com/repos/fontforge/fontforge/releases{/id}","created_at":"2012-08-12T17:08:20Z","updated_at":"2015-06-26T10:28:20Z","pushed_at":"2015-06-29T00:45:10Z","git_url":"git://github.com/fontforge/fontforge.git","ssh_url":"git@github.com:fontforge/fontforge.git","clone_url":"https://github.com/fontforge/fontforge.git","svn_url":"https://github.com/fontforge/fontforge","homepage":"http://fontforge.github.io/","size":88250,"stargazers_count":529,"watchers_count":529,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":613,"forks":141,"open_issues":613,"watchers":529,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/2375"},"html":{"href":"https://github.com/fontforge/fontforge/pull/2375"},"issue":{"href":"https://api.github.com/repos/fontforge/fontforge/issues/2375"},"comments":{"href":"https://api.github.com/repos/fontforge/fontforge/issues/2375/comments"},"review_comments":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/2375/comments"},"review_comment":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/2375/commits"},"statuses":{"href":"https://api.github.com/repos/fontforge/fontforge/statuses/f810b3f4b9e963ddba3dfc2ed2a996f13b2d50ba"}}}}