{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/observe/pulls/comments/46888926","id":46888926,"diff_hunk":"@@ -269,6 +269,16 @@ _runTests() {\n       });\n     });\n \n+    test('sort or 2 elements from reaction fn', () {\n+      ObservableList list = toObservable([3, 1]);","path":"test/observable_list_test.dart","position":5,"original_position":5,"commit_id":"83a4ae84bc4314891ced56227d4387314caf78b5","original_commit_id":"83a4ae84bc4314891ced56227d4387314caf78b5","user":{"login":"jmesserly","id":1081711,"avatar_url":"https://avatars.githubusercontent.com/u/1081711?v=3","gravatar_id":"","url":"https://api.github.com/users/jmesserly","html_url":"https://github.com/jmesserly","followers_url":"https://api.github.com/users/jmesserly/followers","following_url":"https://api.github.com/users/jmesserly/following{/other_user}","gists_url":"https://api.github.com/users/jmesserly/gists{/gist_id}","starred_url":"https://api.github.com/users/jmesserly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmesserly/subscriptions","organizations_url":"https://api.github.com/users/jmesserly/orgs","repos_url":"https://api.github.com/users/jmesserly/repos","events_url":"https://api.github.com/users/jmesserly/events{/privacy}","received_events_url":"https://api.github.com/users/jmesserly/received_events","type":"User","site_admin":false},"body":"I think this should be \"var list = \" ... for consistency","created_at":"2015-12-07T22:36:32Z","updated_at":"2015-12-07T22:36:32Z","html_url":"https://github.com/dart-lang/observe/pull/80#discussion_r46888926","pull_request_url":"https://api.github.com/repos/dart-lang/observe/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/observe/pulls/comments/46888926"},"html":{"href":"https://github.com/dart-lang/observe/pull/80#discussion_r46888926"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/observe/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/observe/pulls/80","id":52906336,"html_url":"https://github.com/dart-lang/observe/pull/80","diff_url":"https://github.com/dart-lang/observe/pull/80.diff","patch_url":"https://github.com/dart-lang/observe/pull/80.patch","issue_url":"https://api.github.com/repos/dart-lang/observe/issues/80","number":80,"state":"open","locked":false,"title":"Fix infinite loop when sorting from reaction function","user":{"login":"eRaz0rHead","id":4214020,"avatar_url":"https://avatars.githubusercontent.com/u/4214020?v=3","gravatar_id":"","url":"https://api.github.com/users/eRaz0rHead","html_url":"https://github.com/eRaz0rHead","followers_url":"https://api.github.com/users/eRaz0rHead/followers","following_url":"https://api.github.com/users/eRaz0rHead/following{/other_user}","gists_url":"https://api.github.com/users/eRaz0rHead/gists{/gist_id}","starred_url":"https://api.github.com/users/eRaz0rHead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eRaz0rHead/subscriptions","organizations_url":"https://api.github.com/users/eRaz0rHead/orgs","repos_url":"https://api.github.com/users/eRaz0rHead/repos","events_url":"https://api.github.com/users/eRaz0rHead/events{/privacy}","received_events_url":"https://api.github.com/users/eRaz0rHead/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/dart-lang/observe/issues/79\r\n","created_at":"2015-12-07T21:52:13Z","updated_at":"2015-12-07T22:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfaaa54b4b1af5684dc86a51e875f7fedf28d5ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/observe/pulls/80/commits","review_comments_url":"https://api.github.com/repos/dart-lang/observe/pulls/80/comments","review_comment_url":"https://api.github.com/repos/dart-lang/observe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/observe/issues/80/comments","statuses_url":"https://api.github.com/repos/dart-lang/observe/statuses/83a4ae84bc4314891ced56227d4387314caf78b5","head":{"label":"eRaz0rHead:master","ref":"master","sha":"83a4ae84bc4314891ced56227d4387314caf78b5","user":{"login":"eRaz0rHead","id":4214020,"avatar_url":"https://avatars.githubusercontent.com/u/4214020?v=3","gravatar_id":"","url":"https://api.github.com/users/eRaz0rHead","html_url":"https://github.com/eRaz0rHead","followers_url":"https://api.github.com/users/eRaz0rHead/followers","following_url":"https://api.github.com/users/eRaz0rHead/following{/other_user}","gists_url":"https://api.github.com/users/eRaz0rHead/gists{/gist_id}","starred_url":"https://api.github.com/users/eRaz0rHead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eRaz0rHead/subscriptions","organizations_url":"https://api.github.com/users/eRaz0rHead/orgs","repos_url":"https://api.github.com/users/eRaz0rHead/repos","events_url":"https://api.github.com/users/eRaz0rHead/events{/privacy}","received_events_url":"https://api.github.com/users/eRaz0rHead/received_events","type":"User","site_admin":false},"repo":{"id":47580092,"name":"observe","full_name":"eRaz0rHead/observe","owner":{"login":"eRaz0rHead","id":4214020,"avatar_url":"https://avatars.githubusercontent.com/u/4214020?v=3","gravatar_id":"","url":"https://api.github.com/users/eRaz0rHead","html_url":"https://github.com/eRaz0rHead","followers_url":"https://api.github.com/users/eRaz0rHead/followers","following_url":"https://api.github.com/users/eRaz0rHead/following{/other_user}","gists_url":"https://api.github.com/users/eRaz0rHead/gists{/gist_id}","starred_url":"https://api.github.com/users/eRaz0rHead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eRaz0rHead/subscriptions","organizations_url":"https://api.github.com/users/eRaz0rHead/orgs","repos_url":"https://api.github.com/users/eRaz0rHead/repos","events_url":"https://api.github.com/users/eRaz0rHead/events{/privacy}","received_events_url":"https://api.github.com/users/eRaz0rHead/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eRaz0rHead/observe","description":"Support for marking objects as observable, and getting notifications when those objects are mutated","fork":true,"url":"https://api.github.com/repos/eRaz0rHead/observe","forks_url":"https://api.github.com/repos/eRaz0rHead/observe/forks","keys_url":"https://api.github.com/repos/eRaz0rHead/observe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eRaz0rHead/observe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eRaz0rHead/observe/teams","hooks_url":"https://api.github.com/repos/eRaz0rHead/observe/hooks","issue_events_url":"https://api.github.com/repos/eRaz0rHead/observe/issues/events{/number}","events_url":"https://api.github.com/repos/eRaz0rHead/observe/events","assignees_url":"https://api.github.com/repos/eRaz0rHead/observe/assignees{/user}","branches_url":"https://api.github.com/repos/eRaz0rHead/observe/branches{/branch}","tags_url":"https://api.github.com/repos/eRaz0rHead/observe/tags","blobs_url":"https://api.github.com/repos/eRaz0rHead/observe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eRaz0rHead/observe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eRaz0rHead/observe/git/refs{/sha}","trees_url":"https://api.github.com/repos/eRaz0rHead/observe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eRaz0rHead/observe/statuses/{sha}","languages_url":"https://api.github.com/repos/eRaz0rHead/observe/languages","stargazers_url":"https://api.github.com/repos/eRaz0rHead/observe/stargazers","contributors_url":"https://api.github.com/repos/eRaz0rHead/observe/contributors","subscribers_url":"https://api.github.com/repos/eRaz0rHead/observe/subscribers","subscription_url":"https://api.github.com/repos/eRaz0rHead/observe/subscription","commits_url":"https://api.github.com/repos/eRaz0rHead/observe/commits{/sha}","git_commits_url":"https://api.github.com/repos/eRaz0rHead/observe/git/commits{/sha}","comments_url":"https://api.github.com/repos/eRaz0rHead/observe/comments{/number}","issue_comment_url":"https://api.github.com/repos/eRaz0rHead/observe/issues/comments{/number}","contents_url":"https://api.github.com/repos/eRaz0rHead/observe/contents/{+path}","compare_url":"https://api.github.com/repos/eRaz0rHead/observe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eRaz0rHead/observe/merges","archive_url":"https://api.github.com/repos/eRaz0rHead/observe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eRaz0rHead/observe/downloads","issues_url":"https://api.github.com/repos/eRaz0rHead/observe/issues{/number}","pulls_url":"https://api.github.com/repos/eRaz0rHead/observe/pulls{/number}","milestones_url":"https://api.github.com/repos/eRaz0rHead/observe/milestones{/number}","notifications_url":"https://api.github.com/repos/eRaz0rHead/observe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eRaz0rHead/observe/labels{/name}","releases_url":"https://api.github.com/repos/eRaz0rHead/observe/releases{/id}","created_at":"2015-12-07T21:24:27Z","updated_at":"2015-12-07T21:24:28Z","pushed_at":"2015-12-07T21:50:32Z","git_url":"git://github.com/eRaz0rHead/observe.git","ssh_url":"git@github.com:eRaz0rHead/observe.git","clone_url":"https://github.com/eRaz0rHead/observe.git","svn_url":"https://github.com/eRaz0rHead/observe","homepage":"https://pub.dartlang.org/packages/observe","size":235,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"636720f88ab93850dcebb981555722ee42dec684","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":24338328,"name":"observe","full_name":"dart-lang/observe","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/observe","description":"Support for marking objects as observable, and getting notifications when those objects are mutated","fork":false,"url":"https://api.github.com/repos/dart-lang/observe","forks_url":"https://api.github.com/repos/dart-lang/observe/forks","keys_url":"https://api.github.com/repos/dart-lang/observe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/observe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/observe/teams","hooks_url":"https://api.github.com/repos/dart-lang/observe/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/observe/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/observe/events","assignees_url":"https://api.github.com/repos/dart-lang/observe/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/observe/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/observe/tags","blobs_url":"https://api.github.com/repos/dart-lang/observe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/observe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/observe/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/observe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/observe/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/observe/languages","stargazers_url":"https://api.github.com/repos/dart-lang/observe/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/observe/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/observe/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/observe/subscription","commits_url":"https://api.github.com/repos/dart-lang/observe/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/observe/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/observe/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/observe/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/observe/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/observe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/observe/merges","archive_url":"https://api.github.com/repos/dart-lang/observe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/observe/downloads","issues_url":"https://api.github.com/repos/dart-lang/observe/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/observe/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/observe/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/observe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/observe/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/observe/releases{/id}","created_at":"2014-09-22T17:33:50Z","updated_at":"2015-10-28T12:00:44Z","pushed_at":"2015-12-07T21:52:13Z","git_url":"git://github.com/dart-lang/observe.git","ssh_url":"git@github.com:dart-lang/observe.git","clone_url":"https://github.com/dart-lang/observe.git","svn_url":"https://github.com/dart-lang/observe","homepage":"https://pub.dartlang.org/packages/observe","size":588,"stargazers_count":9,"watchers_count":9,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":25,"forks":5,"open_issues":25,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/observe/pulls/80"},"html":{"href":"https://github.com/dart-lang/observe/pull/80"},"issue":{"href":"https://api.github.com/repos/dart-lang/observe/issues/80"},"comments":{"href":"https://api.github.com/repos/dart-lang/observe/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/observe/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/observe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/observe/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/observe/statuses/83a4ae84bc4314891ced56227d4387314caf78b5"}}}}