{"action":"created","issue":{"url":"https://api.github.com/repos/antlr/antlr4/issues/997","labels_url":"https://api.github.com/repos/antlr/antlr4/issues/997/labels{/name}","comments_url":"https://api.github.com/repos/antlr/antlr4/issues/997/comments","events_url":"https://api.github.com/repos/antlr/antlr4/issues/997/events","html_url":"https://github.com/antlr/antlr4/pull/997","id":107056504,"number":997,"title":"Added proper visit function in ParseTreeVisitor","user":{"login":"krzkaczor","id":1814312,"avatar_url":"https://avatars.githubusercontent.com/u/1814312?v=3","gravatar_id":"","url":"https://api.github.com/users/krzkaczor","html_url":"https://github.com/krzkaczor","followers_url":"https://api.github.com/users/krzkaczor/followers","following_url":"https://api.github.com/users/krzkaczor/following{/other_user}","gists_url":"https://api.github.com/users/krzkaczor/gists{/gist_id}","starred_url":"https://api.github.com/users/krzkaczor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzkaczor/subscriptions","organizations_url":"https://api.github.com/users/krzkaczor/orgs","repos_url":"https://api.github.com/users/krzkaczor/repos","events_url":"https://api.github.com/users/krzkaczor/events{/privacy}","received_events_url":"https://api.github.com/users/krzkaczor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-17T19:29:35Z","updated_at":"2015-09-18T17:14:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/antlr/antlr4/pulls/997","html_url":"https://github.com/antlr/antlr4/pull/997","diff_url":"https://github.com/antlr/antlr4/pull/997.diff","patch_url":"https://github.com/antlr/antlr4/pull/997.patch"},"body":"It provides proper implementation for visit function which is essential for visitors. It fires appropriate visit function in visitors. It behaves in the same way as java implementation.\r\n\r\nI have also fixed bug that prevented running runtime on nodejs. There is no importScripts symbol in scope so JS throws exception - we need to use typeof operator to avoid it."},"comment":{"url":"https://api.github.com/repos/antlr/antlr4/issues/comments/141510651","html_url":"https://github.com/antlr/antlr4/pull/997#issuecomment-141510651","issue_url":"https://api.github.com/repos/antlr/antlr4/issues/997","id":141510651,"user":{"login":"krzkaczor","id":1814312,"avatar_url":"https://avatars.githubusercontent.com/u/1814312?v=3","gravatar_id":"","url":"https://api.github.com/users/krzkaczor","html_url":"https://github.com/krzkaczor","followers_url":"https://api.github.com/users/krzkaczor/followers","following_url":"https://api.github.com/users/krzkaczor/following{/other_user}","gists_url":"https://api.github.com/users/krzkaczor/gists{/gist_id}","starred_url":"https://api.github.com/users/krzkaczor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzkaczor/subscriptions","organizations_url":"https://api.github.com/users/krzkaczor/orgs","repos_url":"https://api.github.com/users/krzkaczor/repos","events_url":"https://api.github.com/users/krzkaczor/events{/privacy}","received_events_url":"https://api.github.com/users/krzkaczor/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T17:14:57Z","updated_at":"2015-09-18T17:14:57Z","body":"@sharwell Thanks :) I wanted to do so in the first place but I don't know where can I find tests? I looked at package.json test command and it's not implemented. \r\n\r\nNow I found runtime-testsuite directory but tests are written in java and I am not sure how proper test should look like.\r\n\r\nI will  create issue for that and maybe I will time in future to implement it."}}