{"action":"created","issue":{"url":"https://api.github.com/repos/dashpay/dash/issues/612","labels_url":"https://api.github.com/repos/dashpay/dash/issues/612/labels{/name}","comments_url":"https://api.github.com/repos/dashpay/dash/issues/612/comments","events_url":"https://api.github.com/repos/dashpay/dash/issues/612/events","html_url":"https://github.com/dashpay/dash/pull/612","id":106197410,"number":612,"title":"UI: theme-dependent icons/images Step 2-5","user":{"login":"crowning-","id":10080039,"avatar_url":"https://avatars.githubusercontent.com/u/10080039?v=3","gravatar_id":"","url":"https://api.github.com/users/crowning-","html_url":"https://github.com/crowning-","followers_url":"https://api.github.com/users/crowning-/followers","following_url":"https://api.github.com/users/crowning-/following{/other_user}","gists_url":"https://api.github.com/users/crowning-/gists{/gist_id}","starred_url":"https://api.github.com/users/crowning-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowning-/subscriptions","organizations_url":"https://api.github.com/users/crowning-/orgs","repos_url":"https://api.github.com/users/crowning-/repos","events_url":"https://api.github.com/users/crowning-/events{/privacy}","received_events_url":"https://api.github.com/users/crowning-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-13T03:42:16Z","updated_at":"2015-09-17T01:44:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dashpay/dash/pulls/612","html_url":"https://github.com/dashpay/dash/pull/612","diff_url":"https://github.com/dashpay/dash/pull/612.diff","patch_url":"https://github.com/dashpay/dash/pull/612.patch"},"body":"There are now individual folders for icons and images for each wallet-theme, so adding new themes will be much easier in the future.\r\n\r\n**Steps to add a new theme:**\r\n* optionsdialog.cpp: add your new theme to the Options dialogue: ui->theme->addItem(QString(\"DASH-\\<visible_theme_name\\>\"), QVariant(\"\\<theme\\>\"));\r\n* create CSS file: res/css/\\<theme\\>.css and do whatever CSS-magic you need to make the wallet look good\r\n* create folders res/icons/\\<theme\\> and res/images/\\<theme\\> and copy your icons/images there. The file names must stay the same\r\n* add resources to src/qt/dash.qrc and src/Makefile.qt.include\r\n\r\n**Limitations:**\r\n* For obvious reasons the icons for the executables cannot be made theme-dependent (res/icons/*.ico are always used)\r\n* networkstyle.cpp and rpcconsole.cpp use static arrays for (some of) their icons. If someone finds a simple(!) way to make this theme dependent please do. If not I'll replace the arrays somewhere in the future\r\n* helpmessagedialog.ui always uses (hardcoded) res/images/drkblue/about.png. I'll change that later, I think we can live with that for a while\r\n\r\nTested with Linux, OSX and Windows, builds fine with Gitian. As a simple test whether you're using my new coding or not  switch back to the traditional theme, the old and ugly Bitcoin-icons for the in/outgoing transactions are used there :-)\r\n\r\nFeedback appreciated."},"comment":{"url":"https://api.github.com/repos/dashpay/dash/issues/comments/140941092","html_url":"https://github.com/dashpay/dash/pull/612#issuecomment-140941092","issue_url":"https://api.github.com/repos/dashpay/dash/issues/612","id":140941092,"user":{"login":"UdjinM6","id":1935069,"avatar_url":"https://avatars.githubusercontent.com/u/1935069?v=3","gravatar_id":"","url":"https://api.github.com/users/UdjinM6","html_url":"https://github.com/UdjinM6","followers_url":"https://api.github.com/users/UdjinM6/followers","following_url":"https://api.github.com/users/UdjinM6/following{/other_user}","gists_url":"https://api.github.com/users/UdjinM6/gists{/gist_id}","starred_url":"https://api.github.com/users/UdjinM6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UdjinM6/subscriptions","organizations_url":"https://api.github.com/users/UdjinM6/orgs","repos_url":"https://api.github.com/users/UdjinM6/repos","events_url":"https://api.github.com/users/UdjinM6/events{/privacy}","received_events_url":"https://api.github.com/users/UdjinM6/received_events","type":"User","site_admin":false},"created_at":"2015-09-17T01:44:47Z","updated_at":"2015-09-17T01:44:47Z","body":"Tested and works as expected :+1: \r\n\r\nPS. Crownium theme is... o_O\r\n:smile: "}}