{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/29170212","id":29170212,"diff_hunk":"@@ -289,6 +289,12 @@ impl StyleSharingCandidate {\n             return false\n         }\n \n+        let mut matching_rules = vec![];\n+        element.synthesize_presentational_hints_for_legacy_attributes(&mut matching_rules);\n+        if !matching_rules.is_empty() {\n+            return false;\n+        }","path":"components/layout/css/matching.rs","position":17,"original_position":17,"commit_id":"e3440c8a593b4b64908f0ca42b5d17c82965a7f4","original_commit_id":"e3440c8a593b4b64908f0ca42b5d17c82965a7f4","user":{"login":"pcwalton","id":157897,"avatar_url":"https://avatars.githubusercontent.com/u/157897?v=3","gravatar_id":"","url":"https://api.github.com/users/pcwalton","html_url":"https://github.com/pcwalton","followers_url":"https://api.github.com/users/pcwalton/followers","following_url":"https://api.github.com/users/pcwalton/following{/other_user}","gists_url":"https://api.github.com/users/pcwalton/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwalton/subscriptions","organizations_url":"https://api.github.com/users/pcwalton/orgs","repos_url":"https://api.github.com/users/pcwalton/repos","events_url":"https://api.github.com/users/pcwalton/events{/privacy}","received_events_url":"https://api.github.com/users/pcwalton/received_events","type":"User","site_admin":false},"body":"This is probably going to be too slow. `can_share_style_with` is called zillions of times. Can you avoid creating the vector?","created_at":"2015-04-27T17:39:30Z","updated_at":"2015-04-27T17:39:30Z","html_url":"https://github.com/servo/servo/pull/5857#discussion_r29170212","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/5857","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/29170212"},"html":{"href":"https://github.com/servo/servo/pull/5857#discussion_r29170212"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/5857"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/5857","id":34129411,"html_url":"https://github.com/servo/servo/pull/5857","diff_url":"https://github.com/servo/servo/pull/5857.diff","patch_url":"https://github.com/servo/servo/pull/5857.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/5857","number":5857,"state":"open","locked":false,"title":"Create a new infrastructure for presentational hints.","user":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/5857)\n<!-- Reviewable:end -->\n","created_at":"2015-04-26T20:31:30Z","updated_at":"2015-04-27T17:39:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"570319cfe90c008a8ea778baed275204b42da7d0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/5857/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/5857/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/5857/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/e3440c8a593b4b64908f0ca42b5d17c82965a7f4","head":{"label":"Ms2ger:preshints","ref":"preshints","sha":"e3440c8a593b4b64908f0ca42b5d17c82965a7f4","user":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"repo":{"id":12599239,"name":"servo","full_name":"Ms2ger/servo","owner":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ms2ger/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/Ms2ger/servo","forks_url":"https://api.github.com/repos/Ms2ger/servo/forks","keys_url":"https://api.github.com/repos/Ms2ger/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ms2ger/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ms2ger/servo/teams","hooks_url":"https://api.github.com/repos/Ms2ger/servo/hooks","issue_events_url":"https://api.github.com/repos/Ms2ger/servo/issues/events{/number}","events_url":"https://api.github.com/repos/Ms2ger/servo/events","assignees_url":"https://api.github.com/repos/Ms2ger/servo/assignees{/user}","branches_url":"https://api.github.com/repos/Ms2ger/servo/branches{/branch}","tags_url":"https://api.github.com/repos/Ms2ger/servo/tags","blobs_url":"https://api.github.com/repos/Ms2ger/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ms2ger/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ms2ger/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ms2ger/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ms2ger/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/Ms2ger/servo/languages","stargazers_url":"https://api.github.com/repos/Ms2ger/servo/stargazers","contributors_url":"https://api.github.com/repos/Ms2ger/servo/contributors","subscribers_url":"https://api.github.com/repos/Ms2ger/servo/subscribers","subscription_url":"https://api.github.com/repos/Ms2ger/servo/subscription","commits_url":"https://api.github.com/repos/Ms2ger/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ms2ger/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ms2ger/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ms2ger/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ms2ger/servo/contents/{+path}","compare_url":"https://api.github.com/repos/Ms2ger/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ms2ger/servo/merges","archive_url":"https://api.github.com/repos/Ms2ger/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ms2ger/servo/downloads","issues_url":"https://api.github.com/repos/Ms2ger/servo/issues{/number}","pulls_url":"https://api.github.com/repos/Ms2ger/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/Ms2ger/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/Ms2ger/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ms2ger/servo/labels{/name}","releases_url":"https://api.github.com/repos/Ms2ger/servo/releases{/id}","created_at":"2013-09-04T18:49:05Z","updated_at":"2015-04-24T17:58:07Z","pushed_at":"2015-04-27T16:48:56Z","git_url":"git://github.com/Ms2ger/servo.git","ssh_url":"git@github.com:Ms2ger/servo.git","clone_url":"https://github.com/Ms2ger/servo.git","svn_url":"https://github.com/Ms2ger/servo","homepage":"","size":103385,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"56a7981c9c9c6df30fbb3add3d8d0085916fe313","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-04-27T17:29:14Z","pushed_at":"2015-04-27T17:37:14Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"","size":1878329,"stargazers_count":3736,"watchers_count":3736,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":607,"mirror_url":null,"open_issues_count":851,"forks":607,"open_issues":851,"watchers":3736,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/5857"},"html":{"href":"https://github.com/servo/servo/pull/5857"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/5857"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/5857/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/5857/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/5857/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/e3440c8a593b4b64908f0ca42b5d17c82965a7f4"}}}}