{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/donejs/css/pulls/25","id":47551747,"html_url":"https://github.com/donejs/css/pull/25","diff_url":"https://github.com/donejs/css/pull/25.diff","patch_url":"https://github.com/donejs/css/pull/25.patch","issue_url":"https://api.github.com/repos/donejs/css/issues/25","number":25,"state":"closed","locked":false,"title":"Refactors live-reload support to be simplified.","user":{"login":"matthewp","id":361671,"avatar_url":"https://avatars.githubusercontent.com/u/361671?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewp","html_url":"https://github.com/matthewp","followers_url":"https://api.github.com/users/matthewp/followers","following_url":"https://api.github.com/users/matthewp/following{/other_user}","gists_url":"https://api.github.com/users/matthewp/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewp/subscriptions","organizations_url":"https://api.github.com/users/matthewp/orgs","repos_url":"https://api.github.com/users/matthewp/repos","events_url":"https://api.github.com/users/matthewp/events{/privacy}","received_events_url":"https://api.github.com/users/matthewp/received_events","type":"User","site_admin":false},"body":"This change refactors our live-reload support to make it simplified.\nInstead of listening to several different events we do something more\nsimple:\n\nListen for the module to be disposed. When this happens listen for\nthe reload cycle to be complete. When it is complete we can remove the\nold style. This is safe because:\n\n1) We always want to remove the old style. So if a css module is\nreloaded we always want to remove the old one.\n2) By always removing the old we ensure orphans are removed as well.\n\nThe key feature of this refactor is that we no longer listen for the\nreload event for the css module. We don't care if that css module is\nreloaded or not. We only care that 1) it is disposed 2) the reload cycle\nfinishes (at some point).","created_at":"2015-10-13T15:51:54Z","updated_at":"2015-10-13T16:09:34Z","closed_at":"2015-10-13T16:09:34Z","merged_at":"2015-10-13T16:09:34Z","merge_commit_sha":"b31835048578ff7bd264e21c3fdc149a9d9eb183","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/donejs/css/pulls/25/commits","review_comments_url":"https://api.github.com/repos/donejs/css/pulls/25/comments","review_comment_url":"https://api.github.com/repos/donejs/css/pulls/comments{/number}","comments_url":"https://api.github.com/repos/donejs/css/issues/25/comments","statuses_url":"https://api.github.com/repos/donejs/css/statuses/9023ff8ad4a90bf322453ec59d46f2b1dc0a1bdb","head":{"label":"donejs:lr-simplify","ref":"lr-simplify","sha":"9023ff8ad4a90bf322453ec59d46f2b1dc0a1bdb","user":{"login":"donejs","id":8229389,"avatar_url":"https://avatars.githubusercontent.com/u/8229389?v=3","gravatar_id":"","url":"https://api.github.com/users/donejs","html_url":"https://github.com/donejs","followers_url":"https://api.github.com/users/donejs/followers","following_url":"https://api.github.com/users/donejs/following{/other_user}","gists_url":"https://api.github.com/users/donejs/gists{/gist_id}","starred_url":"https://api.github.com/users/donejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donejs/subscriptions","organizations_url":"https://api.github.com/users/donejs/orgs","repos_url":"https://api.github.com/users/donejs/repos","events_url":"https://api.github.com/users/donejs/events{/privacy}","received_events_url":"https://api.github.com/users/donejs/received_events","type":"Organization","site_admin":false},"repo":{"id":35685308,"name":"css","full_name":"donejs/css","owner":{"login":"donejs","id":8229389,"avatar_url":"https://avatars.githubusercontent.com/u/8229389?v=3","gravatar_id":"","url":"https://api.github.com/users/donejs","html_url":"https://github.com/donejs","followers_url":"https://api.github.com/users/donejs/followers","following_url":"https://api.github.com/users/donejs/following{/other_user}","gists_url":"https://api.github.com/users/donejs/gists{/gist_id}","starred_url":"https://api.github.com/users/donejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donejs/subscriptions","organizations_url":"https://api.github.com/users/donejs/orgs","repos_url":"https://api.github.com/users/donejs/repos","events_url":"https://api.github.com/users/donejs/events{/privacy}","received_events_url":"https://api.github.com/users/donejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/donejs/css","description":"A CSS Plugin for DoneJS projects","fork":false,"url":"https://api.github.com/repos/donejs/css","forks_url":"https://api.github.com/repos/donejs/css/forks","keys_url":"https://api.github.com/repos/donejs/css/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donejs/css/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donejs/css/teams","hooks_url":"https://api.github.com/repos/donejs/css/hooks","issue_events_url":"https://api.github.com/repos/donejs/css/issues/events{/number}","events_url":"https://api.github.com/repos/donejs/css/events","assignees_url":"https://api.github.com/repos/donejs/css/assignees{/user}","branches_url":"https://api.github.com/repos/donejs/css/branches{/branch}","tags_url":"https://api.github.com/repos/donejs/css/tags","blobs_url":"https://api.github.com/repos/donejs/css/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donejs/css/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donejs/css/git/refs{/sha}","trees_url":"https://api.github.com/repos/donejs/css/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donejs/css/statuses/{sha}","languages_url":"https://api.github.com/repos/donejs/css/languages","stargazers_url":"https://api.github.com/repos/donejs/css/stargazers","contributors_url":"https://api.github.com/repos/donejs/css/contributors","subscribers_url":"https://api.github.com/repos/donejs/css/subscribers","subscription_url":"https://api.github.com/repos/donejs/css/subscription","commits_url":"https://api.github.com/repos/donejs/css/commits{/sha}","git_commits_url":"https://api.github.com/repos/donejs/css/git/commits{/sha}","comments_url":"https://api.github.com/repos/donejs/css/comments{/number}","issue_comment_url":"https://api.github.com/repos/donejs/css/issues/comments{/number}","contents_url":"https://api.github.com/repos/donejs/css/contents/{+path}","compare_url":"https://api.github.com/repos/donejs/css/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donejs/css/merges","archive_url":"https://api.github.com/repos/donejs/css/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donejs/css/downloads","issues_url":"https://api.github.com/repos/donejs/css/issues{/number}","pulls_url":"https://api.github.com/repos/donejs/css/pulls{/number}","milestones_url":"https://api.github.com/repos/donejs/css/milestones{/number}","notifications_url":"https://api.github.com/repos/donejs/css/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donejs/css/labels{/name}","releases_url":"https://api.github.com/repos/donejs/css/releases{/id}","created_at":"2015-05-15T16:44:59Z","updated_at":"2015-08-12T05:03:47Z","pushed_at":"2015-10-13T16:09:34Z","git_url":"git://github.com/donejs/css.git","ssh_url":"git@github.com:donejs/css.git","clone_url":"https://github.com/donejs/css.git","svn_url":"https://github.com/donejs/css","homepage":null,"size":348,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"donejs:master","ref":"master","sha":"21838af43bedf63babb48eab35ea7a92d6fc4939","user":{"login":"donejs","id":8229389,"avatar_url":"https://avatars.githubusercontent.com/u/8229389?v=3","gravatar_id":"","url":"https://api.github.com/users/donejs","html_url":"https://github.com/donejs","followers_url":"https://api.github.com/users/donejs/followers","following_url":"https://api.github.com/users/donejs/following{/other_user}","gists_url":"https://api.github.com/users/donejs/gists{/gist_id}","starred_url":"https://api.github.com/users/donejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donejs/subscriptions","organizations_url":"https://api.github.com/users/donejs/orgs","repos_url":"https://api.github.com/users/donejs/repos","events_url":"https://api.github.com/users/donejs/events{/privacy}","received_events_url":"https://api.github.com/users/donejs/received_events","type":"Organization","site_admin":false},"repo":{"id":35685308,"name":"css","full_name":"donejs/css","owner":{"login":"donejs","id":8229389,"avatar_url":"https://avatars.githubusercontent.com/u/8229389?v=3","gravatar_id":"","url":"https://api.github.com/users/donejs","html_url":"https://github.com/donejs","followers_url":"https://api.github.com/users/donejs/followers","following_url":"https://api.github.com/users/donejs/following{/other_user}","gists_url":"https://api.github.com/users/donejs/gists{/gist_id}","starred_url":"https://api.github.com/users/donejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donejs/subscriptions","organizations_url":"https://api.github.com/users/donejs/orgs","repos_url":"https://api.github.com/users/donejs/repos","events_url":"https://api.github.com/users/donejs/events{/privacy}","received_events_url":"https://api.github.com/users/donejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/donejs/css","description":"A CSS Plugin for DoneJS projects","fork":false,"url":"https://api.github.com/repos/donejs/css","forks_url":"https://api.github.com/repos/donejs/css/forks","keys_url":"https://api.github.com/repos/donejs/css/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donejs/css/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donejs/css/teams","hooks_url":"https://api.github.com/repos/donejs/css/hooks","issue_events_url":"https://api.github.com/repos/donejs/css/issues/events{/number}","events_url":"https://api.github.com/repos/donejs/css/events","assignees_url":"https://api.github.com/repos/donejs/css/assignees{/user}","branches_url":"https://api.github.com/repos/donejs/css/branches{/branch}","tags_url":"https://api.github.com/repos/donejs/css/tags","blobs_url":"https://api.github.com/repos/donejs/css/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donejs/css/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donejs/css/git/refs{/sha}","trees_url":"https://api.github.com/repos/donejs/css/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donejs/css/statuses/{sha}","languages_url":"https://api.github.com/repos/donejs/css/languages","stargazers_url":"https://api.github.com/repos/donejs/css/stargazers","contributors_url":"https://api.github.com/repos/donejs/css/contributors","subscribers_url":"https://api.github.com/repos/donejs/css/subscribers","subscription_url":"https://api.github.com/repos/donejs/css/subscription","commits_url":"https://api.github.com/repos/donejs/css/commits{/sha}","git_commits_url":"https://api.github.com/repos/donejs/css/git/commits{/sha}","comments_url":"https://api.github.com/repos/donejs/css/comments{/number}","issue_comment_url":"https://api.github.com/repos/donejs/css/issues/comments{/number}","contents_url":"https://api.github.com/repos/donejs/css/contents/{+path}","compare_url":"https://api.github.com/repos/donejs/css/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donejs/css/merges","archive_url":"https://api.github.com/repos/donejs/css/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donejs/css/downloads","issues_url":"https://api.github.com/repos/donejs/css/issues{/number}","pulls_url":"https://api.github.com/repos/donejs/css/pulls{/number}","milestones_url":"https://api.github.com/repos/donejs/css/milestones{/number}","notifications_url":"https://api.github.com/repos/donejs/css/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donejs/css/labels{/name}","releases_url":"https://api.github.com/repos/donejs/css/releases{/id}","created_at":"2015-05-15T16:44:59Z","updated_at":"2015-08-12T05:03:47Z","pushed_at":"2015-10-13T16:09:34Z","git_url":"git://github.com/donejs/css.git","ssh_url":"git@github.com:donejs/css.git","clone_url":"https://github.com/donejs/css.git","svn_url":"https://github.com/donejs/css","homepage":null,"size":348,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/donejs/css/pulls/25"},"html":{"href":"https://github.com/donejs/css/pull/25"},"issue":{"href":"https://api.github.com/repos/donejs/css/issues/25"},"comments":{"href":"https://api.github.com/repos/donejs/css/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/donejs/css/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/donejs/css/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/donejs/css/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/donejs/css/statuses/9023ff8ad4a90bf322453ec59d46f2b1dc0a1bdb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"matthewp","id":361671,"avatar_url":"https://avatars.githubusercontent.com/u/361671?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewp","html_url":"https://github.com/matthewp","followers_url":"https://api.github.com/users/matthewp/followers","following_url":"https://api.github.com/users/matthewp/following{/other_user}","gists_url":"https://api.github.com/users/matthewp/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewp/subscriptions","organizations_url":"https://api.github.com/users/matthewp/orgs","repos_url":"https://api.github.com/users/matthewp/repos","events_url":"https://api.github.com/users/matthewp/events{/privacy}","received_events_url":"https://api.github.com/users/matthewp/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":19,"changed_files":3}}