{"action":"created","issue":{"url":"https://api.github.com/repos/MacTee/KSP-Mod-Admin-aOS/issues/101","labels_url":"https://api.github.com/repos/MacTee/KSP-Mod-Admin-aOS/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/MacTee/KSP-Mod-Admin-aOS/issues/101/comments","events_url":"https://api.github.com/repos/MacTee/KSP-Mod-Admin-aOS/issues/101/events","html_url":"https://github.com/MacTee/KSP-Mod-Admin-aOS/issues/101","id":78455352,"number":101,"title":"Update and Import still don't works if mod has multible files with same filename.","user":{"login":"MacTee","id":5434397,"avatar_url":"https://avatars.githubusercontent.com/u/5434397?v=3","gravatar_id":"","url":"https://api.github.com/users/MacTee","html_url":"https://github.com/MacTee","followers_url":"https://api.github.com/users/MacTee/followers","following_url":"https://api.github.com/users/MacTee/following{/other_user}","gists_url":"https://api.github.com/users/MacTee/gists{/gist_id}","starred_url":"https://api.github.com/users/MacTee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MacTee/subscriptions","organizations_url":"https://api.github.com/users/MacTee/orgs","repos_url":"https://api.github.com/users/MacTee/repos","events_url":"https://api.github.com/users/MacTee/events{/privacy}","received_events_url":"https://api.github.com/users/MacTee/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MacTee/KSP-Mod-Admin-aOS/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-20T09:47:52Z","updated_at":"2015-05-20T14:04:11Z","closed_at":null,"body":"Sample Chatterer 0.9.1\r\n\r\nTest:\r\n- Clean ModSelection\r\n- Add Chatterer https://kerbalstuff.com/mod/124/Chatterer\r\n- Edit ModInfo (dates and version number)\r\n- Click \"Update Mod\"\r\n- Compare the Nodes \"Chatterer/GameData/Chatterer/Sounds/chatter/apollo11/capsule/capsule_XX.ogg\" and \"Chatterer/GameData/Chatterer/Sounds/chatter/sts1/capsule/capsule_XX.ogg\" \r\n\r\nThe function TryCopyDestToMatchingNodes of ModNodeHandler and ModPackHandler is the problem.\r\nA fix could be, to search for the complete TreePath of the node to copy and not just the parent + node.\r\nThe problem with this is the sligtest change in the new mod archive will break the relation.\r\n\r\nPseudoCode:\r\n- Get FullTreePath (without MainNode of the mod it might contain version number)\r\n- Search the new mod for that path.\r\n- Copy all infos on a match\r\nQuestion: What should happen if a node wasn't found?"},"comment":{"url":"https://api.github.com/repos/MacTee/KSP-Mod-Admin-aOS/issues/comments/103898350","html_url":"https://github.com/MacTee/KSP-Mod-Admin-aOS/issues/101#issuecomment-103898350","issue_url":"https://api.github.com/repos/MacTee/KSP-Mod-Admin-aOS/issues/101","id":103898350,"user":{"login":"MacTee","id":5434397,"avatar_url":"https://avatars.githubusercontent.com/u/5434397?v=3","gravatar_id":"","url":"https://api.github.com/users/MacTee","html_url":"https://github.com/MacTee","followers_url":"https://api.github.com/users/MacTee/followers","following_url":"https://api.github.com/users/MacTee/following{/other_user}","gists_url":"https://api.github.com/users/MacTee/gists{/gist_id}","starred_url":"https://api.github.com/users/MacTee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MacTee/subscriptions","organizations_url":"https://api.github.com/users/MacTee/orgs","repos_url":"https://api.github.com/users/MacTee/repos","events_url":"https://api.github.com/users/MacTee/events{/privacy}","received_events_url":"https://api.github.com/users/MacTee/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T14:04:11Z","updated_at":"2015-05-20T14:04:11Z","body":"Fixed with commit https://github.com/MacTee/KSP-Mod-Admin-aOS/commit/688fb5e13c8ca98b9777e2cd6c2e761c1a953bad.\r\nA TryCopy... fails when one old file don't find a match in the new archive.\r\nOn a fail during auto update the update of the mod will be aborted, during a import the half imported mod stays as is =(."}}