{"action":"closed","number":368,"pull_request":{"url":"https://api.github.com/repos/esvit/ng-table/pulls/368","id":18401887,"html_url":"https://github.com/esvit/ng-table/pull/368","diff_url":"https://github.com/esvit/ng-table/pull/368.diff","patch_url":"https://github.com/esvit/ng-table/pull/368.patch","issue_url":"https://api.github.com/repos/esvit/ng-table/issues/368","number":368,"state":"closed","locked":false,"title":"Fix multiple pagination instances","user":{"login":"maxaon","id":3187207,"avatar_url":"https://avatars.githubusercontent.com/u/3187207?v=3","gravatar_id":"","url":"https://api.github.com/users/maxaon","html_url":"https://github.com/maxaon","followers_url":"https://api.github.com/users/maxaon/followers","following_url":"https://api.github.com/users/maxaon/following{/other_user}","gists_url":"https://api.github.com/users/maxaon/gists{/gist_id}","starred_url":"https://api.github.com/users/maxaon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxaon/subscriptions","organizations_url":"https://api.github.com/users/maxaon/orgs","repos_url":"https://api.github.com/users/maxaon/repos","events_url":"https://api.github.com/users/maxaon/events{/privacy}","received_events_url":"https://api.github.com/users/maxaon/received_events","type":"User","site_admin":false},"body":"Paginstion shouldn't use `scope.params.settings().$scope` and shoul listen only current scope.\r\nBut becouse event `ngTableAfterReloadData` is emited in other scope it cannot come into isolated leaf scope. That's why using small hack to listen scope, where `ngTableAfterReloadData` event can occur.\r\n\r\nBetter way is change layout: ng-table > pagination, table, pagination.  And then use broadcast in ng-table/","created_at":"2014-07-15T11:20:53Z","updated_at":"2015-08-08T18:03:04Z","closed_at":"2015-08-08T18:03:04Z","merged_at":null,"merge_commit_sha":"9b3679d6c63fb6a7501ee11ea12931c84a2ddd50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/esvit/ng-table/pulls/368/commits","review_comments_url":"https://api.github.com/repos/esvit/ng-table/pulls/368/comments","review_comment_url":"https://api.github.com/repos/esvit/ng-table/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esvit/ng-table/issues/368/comments","statuses_url":"https://api.github.com/repos/esvit/ng-table/statuses/6801246d1faa17d67a11ce44810b6badabf542c2","head":{"label":"maxaon:fix-pagination","ref":"fix-pagination","sha":"6801246d1faa17d67a11ce44810b6badabf542c2","user":{"login":"maxaon","id":3187207,"avatar_url":"https://avatars.githubusercontent.com/u/3187207?v=3","gravatar_id":"","url":"https://api.github.com/users/maxaon","html_url":"https://github.com/maxaon","followers_url":"https://api.github.com/users/maxaon/followers","following_url":"https://api.github.com/users/maxaon/following{/other_user}","gists_url":"https://api.github.com/users/maxaon/gists{/gist_id}","starred_url":"https://api.github.com/users/maxaon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxaon/subscriptions","organizations_url":"https://api.github.com/users/maxaon/orgs","repos_url":"https://api.github.com/users/maxaon/repos","events_url":"https://api.github.com/users/maxaon/events{/privacy}","received_events_url":"https://api.github.com/users/maxaon/received_events","type":"User","site_admin":false},"repo":{"id":21856668,"name":"ng-table","full_name":"maxaon/ng-table","owner":{"login":"maxaon","id":3187207,"avatar_url":"https://avatars.githubusercontent.com/u/3187207?v=3","gravatar_id":"","url":"https://api.github.com/users/maxaon","html_url":"https://github.com/maxaon","followers_url":"https://api.github.com/users/maxaon/followers","following_url":"https://api.github.com/users/maxaon/following{/other_user}","gists_url":"https://api.github.com/users/maxaon/gists{/gist_id}","starred_url":"https://api.github.com/users/maxaon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxaon/subscriptions","organizations_url":"https://api.github.com/users/maxaon/orgs","repos_url":"https://api.github.com/users/maxaon/repos","events_url":"https://api.github.com/users/maxaon/events{/privacy}","received_events_url":"https://api.github.com/users/maxaon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxaon/ng-table","description":"Simple table with sorting and filtering on AngularJS","fork":true,"url":"https://api.github.com/repos/maxaon/ng-table","forks_url":"https://api.github.com/repos/maxaon/ng-table/forks","keys_url":"https://api.github.com/repos/maxaon/ng-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxaon/ng-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxaon/ng-table/teams","hooks_url":"https://api.github.com/repos/maxaon/ng-table/hooks","issue_events_url":"https://api.github.com/repos/maxaon/ng-table/issues/events{/number}","events_url":"https://api.github.com/repos/maxaon/ng-table/events","assignees_url":"https://api.github.com/repos/maxaon/ng-table/assignees{/user}","branches_url":"https://api.github.com/repos/maxaon/ng-table/branches{/branch}","tags_url":"https://api.github.com/repos/maxaon/ng-table/tags","blobs_url":"https://api.github.com/repos/maxaon/ng-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxaon/ng-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxaon/ng-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxaon/ng-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxaon/ng-table/statuses/{sha}","languages_url":"https://api.github.com/repos/maxaon/ng-table/languages","stargazers_url":"https://api.github.com/repos/maxaon/ng-table/stargazers","contributors_url":"https://api.github.com/repos/maxaon/ng-table/contributors","subscribers_url":"https://api.github.com/repos/maxaon/ng-table/subscribers","subscription_url":"https://api.github.com/repos/maxaon/ng-table/subscription","commits_url":"https://api.github.com/repos/maxaon/ng-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxaon/ng-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxaon/ng-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxaon/ng-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxaon/ng-table/contents/{+path}","compare_url":"https://api.github.com/repos/maxaon/ng-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxaon/ng-table/merges","archive_url":"https://api.github.com/repos/maxaon/ng-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxaon/ng-table/downloads","issues_url":"https://api.github.com/repos/maxaon/ng-table/issues{/number}","pulls_url":"https://api.github.com/repos/maxaon/ng-table/pulls{/number}","milestones_url":"https://api.github.com/repos/maxaon/ng-table/milestones{/number}","notifications_url":"https://api.github.com/repos/maxaon/ng-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxaon/ng-table/labels{/name}","releases_url":"https://api.github.com/repos/maxaon/ng-table/releases{/id}","created_at":"2014-07-15T11:09:19Z","updated_at":"2014-07-15T10:02:26Z","pushed_at":"2014-11-13T15:39:43Z","git_url":"git://github.com/maxaon/ng-table.git","ssh_url":"git@github.com:maxaon/ng-table.git","clone_url":"https://github.com/maxaon/ng-table.git","svn_url":"https://github.com/maxaon/ng-table","homepage":"http://bazalt-cms.com/ng-table/","size":2328,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"esvit:master","ref":"master","sha":"6bb2aba8ce89a5afdf36f1fe42b7bd71efcf6b81","user":{"login":"esvit","id":1222467,"avatar_url":"https://avatars.githubusercontent.com/u/1222467?v=3","gravatar_id":"","url":"https://api.github.com/users/esvit","html_url":"https://github.com/esvit","followers_url":"https://api.github.com/users/esvit/followers","following_url":"https://api.github.com/users/esvit/following{/other_user}","gists_url":"https://api.github.com/users/esvit/gists{/gist_id}","starred_url":"https://api.github.com/users/esvit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esvit/subscriptions","organizations_url":"https://api.github.com/users/esvit/orgs","repos_url":"https://api.github.com/users/esvit/repos","events_url":"https://api.github.com/users/esvit/events{/privacy}","received_events_url":"https://api.github.com/users/esvit/received_events","type":"User","site_admin":false},"repo":{"id":9542455,"name":"ng-table","full_name":"esvit/ng-table","owner":{"login":"esvit","id":1222467,"avatar_url":"https://avatars.githubusercontent.com/u/1222467?v=3","gravatar_id":"","url":"https://api.github.com/users/esvit","html_url":"https://github.com/esvit","followers_url":"https://api.github.com/users/esvit/followers","following_url":"https://api.github.com/users/esvit/following{/other_user}","gists_url":"https://api.github.com/users/esvit/gists{/gist_id}","starred_url":"https://api.github.com/users/esvit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esvit/subscriptions","organizations_url":"https://api.github.com/users/esvit/orgs","repos_url":"https://api.github.com/users/esvit/repos","events_url":"https://api.github.com/users/esvit/events{/privacy}","received_events_url":"https://api.github.com/users/esvit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/esvit/ng-table","description":"Simple table with sorting and filtering on AngularJS","fork":false,"url":"https://api.github.com/repos/esvit/ng-table","forks_url":"https://api.github.com/repos/esvit/ng-table/forks","keys_url":"https://api.github.com/repos/esvit/ng-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esvit/ng-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esvit/ng-table/teams","hooks_url":"https://api.github.com/repos/esvit/ng-table/hooks","issue_events_url":"https://api.github.com/repos/esvit/ng-table/issues/events{/number}","events_url":"https://api.github.com/repos/esvit/ng-table/events","assignees_url":"https://api.github.com/repos/esvit/ng-table/assignees{/user}","branches_url":"https://api.github.com/repos/esvit/ng-table/branches{/branch}","tags_url":"https://api.github.com/repos/esvit/ng-table/tags","blobs_url":"https://api.github.com/repos/esvit/ng-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esvit/ng-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esvit/ng-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/esvit/ng-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esvit/ng-table/statuses/{sha}","languages_url":"https://api.github.com/repos/esvit/ng-table/languages","stargazers_url":"https://api.github.com/repos/esvit/ng-table/stargazers","contributors_url":"https://api.github.com/repos/esvit/ng-table/contributors","subscribers_url":"https://api.github.com/repos/esvit/ng-table/subscribers","subscription_url":"https://api.github.com/repos/esvit/ng-table/subscription","commits_url":"https://api.github.com/repos/esvit/ng-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/esvit/ng-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/esvit/ng-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/esvit/ng-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/esvit/ng-table/contents/{+path}","compare_url":"https://api.github.com/repos/esvit/ng-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esvit/ng-table/merges","archive_url":"https://api.github.com/repos/esvit/ng-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esvit/ng-table/downloads","issues_url":"https://api.github.com/repos/esvit/ng-table/issues{/number}","pulls_url":"https://api.github.com/repos/esvit/ng-table/pulls{/number}","milestones_url":"https://api.github.com/repos/esvit/ng-table/milestones{/number}","notifications_url":"https://api.github.com/repos/esvit/ng-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esvit/ng-table/labels{/name}","releases_url":"https://api.github.com/repos/esvit/ng-table/releases{/id}","created_at":"2013-04-19T09:46:25Z","updated_at":"2015-08-07T17:06:31Z","pushed_at":"2015-08-08T17:59:37Z","git_url":"git://github.com/esvit/ng-table.git","ssh_url":"git@github.com:esvit/ng-table.git","clone_url":"https://github.com/esvit/ng-table.git","svn_url":"https://github.com/esvit/ng-table","homepage":"http://ng-table.com/","size":5424,"stargazers_count":1687,"watchers_count":1687,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":541,"mirror_url":null,"open_issues_count":141,"forks":541,"open_issues":141,"watchers":1687,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esvit/ng-table/pulls/368"},"html":{"href":"https://github.com/esvit/ng-table/pull/368"},"issue":{"href":"https://api.github.com/repos/esvit/ng-table/issues/368"},"comments":{"href":"https://api.github.com/repos/esvit/ng-table/issues/368/comments"},"review_comments":{"href":"https://api.github.com/repos/esvit/ng-table/pulls/368/comments"},"review_comment":{"href":"https://api.github.com/repos/esvit/ng-table/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esvit/ng-table/pulls/368/commits"},"statuses":{"href":"https://api.github.com/repos/esvit/ng-table/statuses/6801246d1faa17d67a11ce44810b6badabf542c2"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":5,"deletions":4,"changed_files":4}}