{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4556","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4556/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4556/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4556/events","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4556","id":103647757,"number":4556,"title":"MINOR: Drop wasteful 'allow-failures' builds.","user":{"login":"sminnee","id":59968,"avatar_url":"https://avatars.githubusercontent.com/u/59968?v=3","gravatar_id":"","url":"https://api.github.com/users/sminnee","html_url":"https://github.com/sminnee","followers_url":"https://api.github.com/users/sminnee/followers","following_url":"https://api.github.com/users/sminnee/following{/other_user}","gists_url":"https://api.github.com/users/sminnee/gists{/gist_id}","starred_url":"https://api.github.com/users/sminnee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sminnee/subscriptions","organizations_url":"https://api.github.com/users/sminnee/orgs","repos_url":"https://api.github.com/users/sminnee/repos","events_url":"https://api.github.com/users/sminnee/events{/privacy}","received_events_url":"https://api.github.com/users/sminnee/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-28T04:51:14Z","updated_at":"2015-08-28T05:02:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/4556","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4556","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/4556.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/4556.patch"},"body":"Our build time is an impediment: frequently we're slowed down waiting for\r\ntest runs to complete. In this context, running allowed-failure builds\r\nthat everyone ignores is just a waste.\r\n\r\nI'd love to see HHVM work, but that's going to require that someone\r\nactually gets the build to pass. At that point, we can add it back into\r\nthe build matrix.\r\n\r\nI'm working on a PHP7 branch that will hopefully also fix our nightly\r\nbuilds. Once I get that going, I'll add those two back, but not have\r\n'allow failures'\r\n\r\nEven if we decide, at some point in the future, that supporting nightly\r\ndoesn't make sense, I see the *only* value of Travis is maintaining our\r\ngreen tick. We either care about builds or we don't: I've never seen a\r\n'grey area' build result in anything other than embarrassment and\r\ntechnical debt.\r\n\r\nLet's decide what matters to us and treat it like it matters to us:\r\nit's part of the build or not."},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/135636610","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/4556#issuecomment-135636610","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/4556","id":135636610,"user":{"login":"sminnee","id":59968,"avatar_url":"https://avatars.githubusercontent.com/u/59968?v=3","gravatar_id":"","url":"https://api.github.com/users/sminnee","html_url":"https://github.com/sminnee","followers_url":"https://api.github.com/users/sminnee/followers","following_url":"https://api.github.com/users/sminnee/following{/other_user}","gists_url":"https://api.github.com/users/sminnee/gists{/gist_id}","starred_url":"https://api.github.com/users/sminnee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sminnee/subscriptions","organizations_url":"https://api.github.com/users/sminnee/orgs","repos_url":"https://api.github.com/users/sminnee/repos","events_url":"https://api.github.com/users/sminnee/events{/privacy}","received_events_url":"https://api.github.com/users/sminnee/received_events","type":"User","site_admin":false},"created_at":"2015-08-28T05:02:37Z","updated_at":"2015-08-28T05:02:37Z","body":"> Number of failed tests over time could prevent us from breaking builds on HHVM even more than already, but that's not an easy metric to track from Travis.\r\n\r\nI've heard about this in theory. In practise I've only seen it work when there's a dedicated test manager (Phil B), and even then it was a soul-destroying uphill battle.\r\n\r\nNote: I'm inclined to take the same approach with stuff like trailing whitespace: fix it all and then treat any violation as a build failure."}}