{"action":"created","comment":{"url":"https://api.github.com/repos/SpiderOak/crypton/pulls/comments/40575129","id":40575129,"diff_hunk":"@@ -19,7 +19,6 @@\n 'use strict';\n \n var app = process.app;\n-var db = app.datastore;","path":"server/routes/item.js","position":4,"original_position":4,"commit_id":"3fe7a34997f1c8be6aefb81f596d5f788d631efe","original_commit_id":"35986c944c5208d3868db68e807fe3cf0bb84de1","user":{"login":"grempe","id":117,"avatar_url":"https://avatars.githubusercontent.com/u/117?v=3","gravatar_id":"","url":"https://api.github.com/users/grempe","html_url":"https://github.com/grempe","followers_url":"https://api.github.com/users/grempe/followers","following_url":"https://api.github.com/users/grempe/following{/other_user}","gists_url":"https://api.github.com/users/grempe/gists{/gist_id}","starred_url":"https://api.github.com/users/grempe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grempe/subscriptions","organizations_url":"https://api.github.com/users/grempe/orgs","repos_url":"https://api.github.com/users/grempe/repos","events_url":"https://api.github.com/users/grempe/events{/privacy}","received_events_url":"https://api.github.com/users/grempe/received_events","type":"User","site_admin":false},"body":"That's our friend jshint you can thank.  I am also looking at http://jscs.info\r\n\r\nI think both of these should be made to run on test runs and failures should fail test.","created_at":"2015-09-28T16:48:02Z","updated_at":"2015-09-28T16:48:02Z","html_url":"https://github.com/SpiderOak/crypton/pull/406#discussion_r40575129","pull_request_url":"https://api.github.com/repos/SpiderOak/crypton/pulls/406","_links":{"self":{"href":"https://api.github.com/repos/SpiderOak/crypton/pulls/comments/40575129"},"html":{"href":"https://github.com/SpiderOak/crypton/pull/406#discussion_r40575129"},"pull_request":{"href":"https://api.github.com/repos/SpiderOak/crypton/pulls/406"}}},"pull_request":{"url":"https://api.github.com/repos/SpiderOak/crypton/pulls/406","id":46106577,"html_url":"https://github.com/SpiderOak/crypton/pull/406","diff_url":"https://github.com/SpiderOak/crypton/pull/406.diff","patch_url":"https://github.com/SpiderOak/crypton/pull/406.patch","issue_url":"https://api.github.com/repos/SpiderOak/crypton/issues/406","number":406,"state":"open","locked":false,"title":"Stricter","user":{"login":"grempe","id":117,"avatar_url":"https://avatars.githubusercontent.com/u/117?v=3","gravatar_id":"","url":"https://api.github.com/users/grempe","html_url":"https://github.com/grempe","followers_url":"https://api.github.com/users/grempe/followers","following_url":"https://api.github.com/users/grempe/following{/other_user}","gists_url":"https://api.github.com/users/grempe/gists{/gist_id}","starred_url":"https://api.github.com/users/grempe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grempe/subscriptions","organizations_url":"https://api.github.com/users/grempe/orgs","repos_url":"https://api.github.com/users/grempe/repos","events_url":"https://api.github.com/users/grempe/events{/privacy}","received_events_url":"https://api.github.com/users/grempe/received_events","type":"User","site_admin":false},"body":"Each commit should be very small and self-contained to make it easier to review. These are mostly tiny fixes for jshint and de-crufting bits of old code I found.  Getting to the bottom of these now. This pass is just addressing issues in the server dir.\r\n\r\nPerhaps you can take a closer look at the FIXME statements I added as well.  I didn't want to address those in detail on this quick pass.","created_at":"2015-09-27T19:07:24Z","updated_at":"2015-09-28T16:48:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da8e35242b7870effe229a8e1f5a80266691b185","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpiderOak/crypton/pulls/406/commits","review_comments_url":"https://api.github.com/repos/SpiderOak/crypton/pulls/406/comments","review_comment_url":"https://api.github.com/repos/SpiderOak/crypton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpiderOak/crypton/issues/406/comments","statuses_url":"https://api.github.com/repos/SpiderOak/crypton/statuses/3fe7a34997f1c8be6aefb81f596d5f788d631efe","head":{"label":"grempe:stricter","ref":"stricter","sha":"3fe7a34997f1c8be6aefb81f596d5f788d631efe","user":{"login":"grempe","id":117,"avatar_url":"https://avatars.githubusercontent.com/u/117?v=3","gravatar_id":"","url":"https://api.github.com/users/grempe","html_url":"https://github.com/grempe","followers_url":"https://api.github.com/users/grempe/followers","following_url":"https://api.github.com/users/grempe/following{/other_user}","gists_url":"https://api.github.com/users/grempe/gists{/gist_id}","starred_url":"https://api.github.com/users/grempe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grempe/subscriptions","organizations_url":"https://api.github.com/users/grempe/orgs","repos_url":"https://api.github.com/users/grempe/repos","events_url":"https://api.github.com/users/grempe/events{/privacy}","received_events_url":"https://api.github.com/users/grempe/received_events","type":"User","site_admin":false},"repo":{"id":42545188,"name":"crypton","full_name":"grempe/crypton","owner":{"login":"grempe","id":117,"avatar_url":"https://avatars.githubusercontent.com/u/117?v=3","gravatar_id":"","url":"https://api.github.com/users/grempe","html_url":"https://github.com/grempe","followers_url":"https://api.github.com/users/grempe/followers","following_url":"https://api.github.com/users/grempe/following{/other_user}","gists_url":"https://api.github.com/users/grempe/gists{/gist_id}","starred_url":"https://api.github.com/users/grempe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grempe/subscriptions","organizations_url":"https://api.github.com/users/grempe/orgs","repos_url":"https://api.github.com/users/grempe/repos","events_url":"https://api.github.com/users/grempe/events{/privacy}","received_events_url":"https://api.github.com/users/grempe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grempe/crypton","description":":lock: A framework for creating zero-knowledge mobile & desktop applications","fork":true,"url":"https://api.github.com/repos/grempe/crypton","forks_url":"https://api.github.com/repos/grempe/crypton/forks","keys_url":"https://api.github.com/repos/grempe/crypton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grempe/crypton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grempe/crypton/teams","hooks_url":"https://api.github.com/repos/grempe/crypton/hooks","issue_events_url":"https://api.github.com/repos/grempe/crypton/issues/events{/number}","events_url":"https://api.github.com/repos/grempe/crypton/events","assignees_url":"https://api.github.com/repos/grempe/crypton/assignees{/user}","branches_url":"https://api.github.com/repos/grempe/crypton/branches{/branch}","tags_url":"https://api.github.com/repos/grempe/crypton/tags","blobs_url":"https://api.github.com/repos/grempe/crypton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grempe/crypton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grempe/crypton/git/refs{/sha}","trees_url":"https://api.github.com/repos/grempe/crypton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grempe/crypton/statuses/{sha}","languages_url":"https://api.github.com/repos/grempe/crypton/languages","stargazers_url":"https://api.github.com/repos/grempe/crypton/stargazers","contributors_url":"https://api.github.com/repos/grempe/crypton/contributors","subscribers_url":"https://api.github.com/repos/grempe/crypton/subscribers","subscription_url":"https://api.github.com/repos/grempe/crypton/subscription","commits_url":"https://api.github.com/repos/grempe/crypton/commits{/sha}","git_commits_url":"https://api.github.com/repos/grempe/crypton/git/commits{/sha}","comments_url":"https://api.github.com/repos/grempe/crypton/comments{/number}","issue_comment_url":"https://api.github.com/repos/grempe/crypton/issues/comments{/number}","contents_url":"https://api.github.com/repos/grempe/crypton/contents/{+path}","compare_url":"https://api.github.com/repos/grempe/crypton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grempe/crypton/merges","archive_url":"https://api.github.com/repos/grempe/crypton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grempe/crypton/downloads","issues_url":"https://api.github.com/repos/grempe/crypton/issues{/number}","pulls_url":"https://api.github.com/repos/grempe/crypton/pulls{/number}","milestones_url":"https://api.github.com/repos/grempe/crypton/milestones{/number}","notifications_url":"https://api.github.com/repos/grempe/crypton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grempe/crypton/labels{/name}","releases_url":"https://api.github.com/repos/grempe/crypton/releases{/id}","created_at":"2015-09-15T20:38:18Z","updated_at":"2015-09-15T20:38:19Z","pushed_at":"2015-09-28T16:43:41Z","git_url":"git://github.com/grempe/crypton.git","ssh_url":"git@github.com:grempe/crypton.git","clone_url":"https://github.com/grempe/crypton.git","svn_url":"https://github.com/grempe/crypton","homepage":"https://crypton.io/","size":2735,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpiderOak:master","ref":"master","sha":"9814ba878d829a4ec979c79b231e5fa5807d3471","user":{"login":"SpiderOak","id":2637005,"avatar_url":"https://avatars.githubusercontent.com/u/2637005?v=3","gravatar_id":"","url":"https://api.github.com/users/SpiderOak","html_url":"https://github.com/SpiderOak","followers_url":"https://api.github.com/users/SpiderOak/followers","following_url":"https://api.github.com/users/SpiderOak/following{/other_user}","gists_url":"https://api.github.com/users/SpiderOak/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiderOak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiderOak/subscriptions","organizations_url":"https://api.github.com/users/SpiderOak/orgs","repos_url":"https://api.github.com/users/SpiderOak/repos","events_url":"https://api.github.com/users/SpiderOak/events{/privacy}","received_events_url":"https://api.github.com/users/SpiderOak/received_events","type":"Organization","site_admin":false},"repo":{"id":8081366,"name":"crypton","full_name":"SpiderOak/crypton","owner":{"login":"SpiderOak","id":2637005,"avatar_url":"https://avatars.githubusercontent.com/u/2637005?v=3","gravatar_id":"","url":"https://api.github.com/users/SpiderOak","html_url":"https://github.com/SpiderOak","followers_url":"https://api.github.com/users/SpiderOak/followers","following_url":"https://api.github.com/users/SpiderOak/following{/other_user}","gists_url":"https://api.github.com/users/SpiderOak/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiderOak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiderOak/subscriptions","organizations_url":"https://api.github.com/users/SpiderOak/orgs","repos_url":"https://api.github.com/users/SpiderOak/repos","events_url":"https://api.github.com/users/SpiderOak/events{/privacy}","received_events_url":"https://api.github.com/users/SpiderOak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpiderOak/crypton","description":":lock: A framework for creating zero-knowledge mobile & desktop applications","fork":false,"url":"https://api.github.com/repos/SpiderOak/crypton","forks_url":"https://api.github.com/repos/SpiderOak/crypton/forks","keys_url":"https://api.github.com/repos/SpiderOak/crypton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpiderOak/crypton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpiderOak/crypton/teams","hooks_url":"https://api.github.com/repos/SpiderOak/crypton/hooks","issue_events_url":"https://api.github.com/repos/SpiderOak/crypton/issues/events{/number}","events_url":"https://api.github.com/repos/SpiderOak/crypton/events","assignees_url":"https://api.github.com/repos/SpiderOak/crypton/assignees{/user}","branches_url":"https://api.github.com/repos/SpiderOak/crypton/branches{/branch}","tags_url":"https://api.github.com/repos/SpiderOak/crypton/tags","blobs_url":"https://api.github.com/repos/SpiderOak/crypton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpiderOak/crypton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpiderOak/crypton/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpiderOak/crypton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpiderOak/crypton/statuses/{sha}","languages_url":"https://api.github.com/repos/SpiderOak/crypton/languages","stargazers_url":"https://api.github.com/repos/SpiderOak/crypton/stargazers","contributors_url":"https://api.github.com/repos/SpiderOak/crypton/contributors","subscribers_url":"https://api.github.com/repos/SpiderOak/crypton/subscribers","subscription_url":"https://api.github.com/repos/SpiderOak/crypton/subscription","commits_url":"https://api.github.com/repos/SpiderOak/crypton/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpiderOak/crypton/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpiderOak/crypton/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpiderOak/crypton/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpiderOak/crypton/contents/{+path}","compare_url":"https://api.github.com/repos/SpiderOak/crypton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpiderOak/crypton/merges","archive_url":"https://api.github.com/repos/SpiderOak/crypton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpiderOak/crypton/downloads","issues_url":"https://api.github.com/repos/SpiderOak/crypton/issues{/number}","pulls_url":"https://api.github.com/repos/SpiderOak/crypton/pulls{/number}","milestones_url":"https://api.github.com/repos/SpiderOak/crypton/milestones{/number}","notifications_url":"https://api.github.com/repos/SpiderOak/crypton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpiderOak/crypton/labels{/name}","releases_url":"https://api.github.com/repos/SpiderOak/crypton/releases{/id}","created_at":"2013-02-07T20:49:35Z","updated_at":"2015-09-28T05:58:19Z","pushed_at":"2015-09-28T16:43:41Z","git_url":"git://github.com/SpiderOak/crypton.git","ssh_url":"git@github.com:SpiderOak/crypton.git","clone_url":"https://github.com/SpiderOak/crypton.git","svn_url":"https://github.com/SpiderOak/crypton","homepage":"https://crypton.io/","size":7082,"stargazers_count":861,"watchers_count":861,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":161,"forks":71,"open_issues":161,"watchers":861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpiderOak/crypton/pulls/406"},"html":{"href":"https://github.com/SpiderOak/crypton/pull/406"},"issue":{"href":"https://api.github.com/repos/SpiderOak/crypton/issues/406"},"comments":{"href":"https://api.github.com/repos/SpiderOak/crypton/issues/406/comments"},"review_comments":{"href":"https://api.github.com/repos/SpiderOak/crypton/pulls/406/comments"},"review_comment":{"href":"https://api.github.com/repos/SpiderOak/crypton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpiderOak/crypton/pulls/406/commits"},"statuses":{"href":"https://api.github.com/repos/SpiderOak/crypton/statuses/3fe7a34997f1c8be6aefb81f596d5f788d631efe"}}}}