{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/34959536","id":34959536,"diff_hunk":"@@ -106,10 +106,12 @@ of the child images is sufficient.  However, certain instructions require\n a little more examination and explanation.\n \n * In the case of the `ADD` and `COPY` instructions, the contents of the file(s)","path":"docs/articles/dockerfile_best-practices.md","position":3,"original_position":3,"commit_id":"8751384bf0fbf3109ce7609535a6e7064c6ca6c4","original_commit_id":"8751384bf0fbf3109ce7609535a6e7064c6ca6c4","user":{"login":"moxiegirl","id":1347209,"avatar_url":"https://avatars.githubusercontent.com/u/1347209?v=3","gravatar_id":"","url":"https://api.github.com/users/moxiegirl","html_url":"https://github.com/moxiegirl","followers_url":"https://api.github.com/users/moxiegirl/followers","following_url":"https://api.github.com/users/moxiegirl/following{/other_user}","gists_url":"https://api.github.com/users/moxiegirl/gists{/gist_id}","starred_url":"https://api.github.com/users/moxiegirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxiegirl/subscriptions","organizations_url":"https://api.github.com/users/moxiegirl/orgs","repos_url":"https://api.github.com/users/moxiegirl/repos","events_url":"https://api.github.com/users/moxiegirl/events{/privacy}","received_events_url":"https://api.github.com/users/moxiegirl/received_events","type":"User","site_admin":false},"body":"Thanks for doing this @charleswhchan.  These sentence can be empowered by a little tweaking.\r\n\r\n--> https://gist.github.com/moxiegirl/f8b7c0ac1f98232c3baf\r\n\r\n* For the `ADD` and `COPY` instructions, the contents of the file(s)\r\nin the image are examined and a checksum is calculated for each file. \r\nThe last-modified and last-accessed times of the file(s) are not considered in these checksums.\r\nDuring the cache lookup, the checksum is compared against the checksum in the existing images.\r\nIf anything has changed in the file(s), such as the contents and metadata,\r\nthen the cache is invalidated. \r\n","created_at":"2015-07-19T16:25:24Z","updated_at":"2015-07-19T16:25:24Z","html_url":"https://github.com/docker/docker/pull/14725#discussion_r34959536","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/14725","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/34959536"},"html":{"href":"https://github.com/docker/docker/pull/14725#discussion_r34959536"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/14725"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/14725","id":40286498,"html_url":"https://github.com/docker/docker/pull/14725","diff_url":"https://github.com/docker/docker/pull/14725.diff","patch_url":"https://github.com/docker/docker/pull/14725.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/14725","number":14725,"state":"open","locked":false,"title":"Issue #14433","user":{"login":"charleswhchan","id":679475,"avatar_url":"https://avatars.githubusercontent.com/u/679475?v=3","gravatar_id":"","url":"https://api.github.com/users/charleswhchan","html_url":"https://github.com/charleswhchan","followers_url":"https://api.github.com/users/charleswhchan/followers","following_url":"https://api.github.com/users/charleswhchan/following{/other_user}","gists_url":"https://api.github.com/users/charleswhchan/gists{/gist_id}","starred_url":"https://api.github.com/users/charleswhchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charleswhchan/subscriptions","organizations_url":"https://api.github.com/users/charleswhchan/orgs","repos_url":"https://api.github.com/users/charleswhchan/repos","events_url":"https://api.github.com/users/charleswhchan/events{/privacy}","received_events_url":"https://api.github.com/users/charleswhchan/received_events","type":"User","site_admin":false},"body":"Try to improve the cache behavior for `ADD` and `COPY` commands.\r\n\r\nSigned-off-by: Charles Chan <charleswhchan@users.noreply.github.com>","created_at":"2015-07-18T04:24:54Z","updated_at":"2015-07-19T16:25:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a70390c5640a9b19d9c660caeaf0d6943e624e74","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/14725/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/14725/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/14725/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/8751384bf0fbf3109ce7609535a6e7064c6ca6c4","head":{"label":"charleswhchan:issue-14433","ref":"issue-14433","sha":"8751384bf0fbf3109ce7609535a6e7064c6ca6c4","user":{"login":"charleswhchan","id":679475,"avatar_url":"https://avatars.githubusercontent.com/u/679475?v=3","gravatar_id":"","url":"https://api.github.com/users/charleswhchan","html_url":"https://github.com/charleswhchan","followers_url":"https://api.github.com/users/charleswhchan/followers","following_url":"https://api.github.com/users/charleswhchan/following{/other_user}","gists_url":"https://api.github.com/users/charleswhchan/gists{/gist_id}","starred_url":"https://api.github.com/users/charleswhchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charleswhchan/subscriptions","organizations_url":"https://api.github.com/users/charleswhchan/orgs","repos_url":"https://api.github.com/users/charleswhchan/repos","events_url":"https://api.github.com/users/charleswhchan/events{/privacy}","received_events_url":"https://api.github.com/users/charleswhchan/received_events","type":"User","site_admin":false},"repo":{"id":38986282,"name":"docker","full_name":"charleswhchan/docker","owner":{"login":"charleswhchan","id":679475,"avatar_url":"https://avatars.githubusercontent.com/u/679475?v=3","gravatar_id":"","url":"https://api.github.com/users/charleswhchan","html_url":"https://github.com/charleswhchan","followers_url":"https://api.github.com/users/charleswhchan/followers","following_url":"https://api.github.com/users/charleswhchan/following{/other_user}","gists_url":"https://api.github.com/users/charleswhchan/gists{/gist_id}","starred_url":"https://api.github.com/users/charleswhchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charleswhchan/subscriptions","organizations_url":"https://api.github.com/users/charleswhchan/orgs","repos_url":"https://api.github.com/users/charleswhchan/repos","events_url":"https://api.github.com/users/charleswhchan/events{/privacy}","received_events_url":"https://api.github.com/users/charleswhchan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charleswhchan/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/charleswhchan/docker","forks_url":"https://api.github.com/repos/charleswhchan/docker/forks","keys_url":"https://api.github.com/repos/charleswhchan/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charleswhchan/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charleswhchan/docker/teams","hooks_url":"https://api.github.com/repos/charleswhchan/docker/hooks","issue_events_url":"https://api.github.com/repos/charleswhchan/docker/issues/events{/number}","events_url":"https://api.github.com/repos/charleswhchan/docker/events","assignees_url":"https://api.github.com/repos/charleswhchan/docker/assignees{/user}","branches_url":"https://api.github.com/repos/charleswhchan/docker/branches{/branch}","tags_url":"https://api.github.com/repos/charleswhchan/docker/tags","blobs_url":"https://api.github.com/repos/charleswhchan/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charleswhchan/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charleswhchan/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/charleswhchan/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charleswhchan/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/charleswhchan/docker/languages","stargazers_url":"https://api.github.com/repos/charleswhchan/docker/stargazers","contributors_url":"https://api.github.com/repos/charleswhchan/docker/contributors","subscribers_url":"https://api.github.com/repos/charleswhchan/docker/subscribers","subscription_url":"https://api.github.com/repos/charleswhchan/docker/subscription","commits_url":"https://api.github.com/repos/charleswhchan/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/charleswhchan/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/charleswhchan/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/charleswhchan/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/charleswhchan/docker/contents/{+path}","compare_url":"https://api.github.com/repos/charleswhchan/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charleswhchan/docker/merges","archive_url":"https://api.github.com/repos/charleswhchan/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charleswhchan/docker/downloads","issues_url":"https://api.github.com/repos/charleswhchan/docker/issues{/number}","pulls_url":"https://api.github.com/repos/charleswhchan/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/charleswhchan/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/charleswhchan/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charleswhchan/docker/labels{/name}","releases_url":"https://api.github.com/repos/charleswhchan/docker/releases{/id}","created_at":"2015-07-13T02:03:05Z","updated_at":"2015-07-13T02:03:12Z","pushed_at":"2015-07-19T13:59:17Z","git_url":"git://github.com/charleswhchan/docker.git","ssh_url":"git@github.com:charleswhchan/docker.git","clone_url":"https://github.com/charleswhchan/docker.git","svn_url":"https://github.com/charleswhchan/docker","homepage":"http://www.docker.com","size":60455,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"a0a0b8499e068c5c9a4caf5bab83d39ddd362078","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-07-19T15:31:58Z","pushed_at":"2015-07-19T13:59:22Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":228211,"stargazers_count":23372,"watchers_count":23372,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5806,"mirror_url":null,"open_issues_count":1044,"forks":5806,"open_issues":1044,"watchers":23372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/14725"},"html":{"href":"https://github.com/docker/docker/pull/14725"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/14725"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/14725/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/14725/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/14725/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/8751384bf0fbf3109ce7609535a6e7064c6ca6c4"}}}}