{"action":"opened","number":338,"pull_request":{"url":"https://api.github.com/repos/dockyard/reefpoints/pulls/338","id":34044444,"html_url":"https://github.com/dockyard/reefpoints/pull/338","diff_url":"https://github.com/dockyard/reefpoints/pull/338.diff","patch_url":"https://github.com/dockyard/reefpoints/pull/338.patch","issue_url":"https://api.github.com/repos/dockyard/reefpoints/issues/338","number":338,"state":"open","locked":false,"title":"Clean up Atom links","user":{"login":"cllns","id":632942,"avatar_url":"https://avatars.githubusercontent.com/u/632942?v=3","gravatar_id":"","url":"https://api.github.com/users/cllns","html_url":"https://github.com/cllns","followers_url":"https://api.github.com/users/cllns/followers","following_url":"https://api.github.com/users/cllns/following{/other_user}","gists_url":"https://api.github.com/users/cllns/gists{/gist_id}","starred_url":"https://api.github.com/users/cllns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cllns/subscriptions","organizations_url":"https://api.github.com/users/cllns/orgs","repos_url":"https://api.github.com/users/cllns/repos","events_url":"https://api.github.com/users/cllns/events{/privacy}","received_events_url":"https://api.github.com/users/cllns/received_events","type":"User","site_admin":false},"body":"Three changes:\r\n\r\n1. Change the RSS (atom.xml) link in the footer to be relative to root, so it works when using middleman locally.\r\n2. Get rid of `feed.xml.builder`, since it wasn't used (In the config, it should have layout: false, like atom.xml, but it doesn't, so it wasn't valid XML).\r\n3. Add a [link in the header to the atom feed](http://en.wikipedia.org/wiki/Atom_%28standard%29#Including_in_HTML).\r\n\r\n**3)** was the reason I made this PR (and others). I tried adding `reefpoints.dockyard.com` to my feed reader (Vienna) and it didn't pick up on the feed automatically, since usually it does. It worked fine when I found the `reefpoints.dockyard.com/atom.xml` link. This tag should tell feed readers where to find the feed. \r\n\r\nImportant note: I tried to add `localhost:4567` to Vienna and it still didn't work. A couple possibilities I've thought of:\r\n\r\n- Vienna treats local URL's differently.\r\n- Vienna doesn't auto-detect Atom feeds, though it has no problem adding them. \r\n\r\nRegardless, the wikipedia page linked above encourages adding the link like I've done here. \r\n\r\n\r\nAlso, I'm not sure what the preferred styling is, of [Reefpoints](https://github.com/dockyard/reefpoints/blob/master/source/atom.xml.builder#L4) vs [ReefPoints](https://github.com/dockyard/reefpoints/blob/master/source/layouts/layout.html.haml#L90). Though, I don't think the `title` attribute here is used for anything.\r\n\r\n","created_at":"2015-04-24T12:38:09Z","updated_at":"2015-04-24T12:38:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dockyard/reefpoints/pulls/338/commits","review_comments_url":"https://api.github.com/repos/dockyard/reefpoints/pulls/338/comments","review_comment_url":"https://api.github.com/repos/dockyard/reefpoints/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dockyard/reefpoints/issues/338/comments","statuses_url":"https://api.github.com/repos/dockyard/reefpoints/statuses/8f83858c1ae66d2b850dbb6073a7efc42d895f85","head":{"label":"cllns:clean-up-rss-links","ref":"clean-up-rss-links","sha":"8f83858c1ae66d2b850dbb6073a7efc42d895f85","user":{"login":"cllns","id":632942,"avatar_url":"https://avatars.githubusercontent.com/u/632942?v=3","gravatar_id":"","url":"https://api.github.com/users/cllns","html_url":"https://github.com/cllns","followers_url":"https://api.github.com/users/cllns/followers","following_url":"https://api.github.com/users/cllns/following{/other_user}","gists_url":"https://api.github.com/users/cllns/gists{/gist_id}","starred_url":"https://api.github.com/users/cllns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cllns/subscriptions","organizations_url":"https://api.github.com/users/cllns/orgs","repos_url":"https://api.github.com/users/cllns/repos","events_url":"https://api.github.com/users/cllns/events{/privacy}","received_events_url":"https://api.github.com/users/cllns/received_events","type":"User","site_admin":false},"repo":{"id":34491512,"name":"reefpoints","full_name":"cllns/reefpoints","owner":{"login":"cllns","id":632942,"avatar_url":"https://avatars.githubusercontent.com/u/632942?v=3","gravatar_id":"","url":"https://api.github.com/users/cllns","html_url":"https://github.com/cllns","followers_url":"https://api.github.com/users/cllns/followers","following_url":"https://api.github.com/users/cllns/following{/other_user}","gists_url":"https://api.github.com/users/cllns/gists{/gist_id}","starred_url":"https://api.github.com/users/cllns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cllns/subscriptions","organizations_url":"https://api.github.com/users/cllns/orgs","repos_url":"https://api.github.com/users/cllns/repos","events_url":"https://api.github.com/users/cllns/events{/privacy}","received_events_url":"https://api.github.com/users/cllns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cllns/reefpoints","description":"DockYard Blog","fork":true,"url":"https://api.github.com/repos/cllns/reefpoints","forks_url":"https://api.github.com/repos/cllns/reefpoints/forks","keys_url":"https://api.github.com/repos/cllns/reefpoints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cllns/reefpoints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cllns/reefpoints/teams","hooks_url":"https://api.github.com/repos/cllns/reefpoints/hooks","issue_events_url":"https://api.github.com/repos/cllns/reefpoints/issues/events{/number}","events_url":"https://api.github.com/repos/cllns/reefpoints/events","assignees_url":"https://api.github.com/repos/cllns/reefpoints/assignees{/user}","branches_url":"https://api.github.com/repos/cllns/reefpoints/branches{/branch}","tags_url":"https://api.github.com/repos/cllns/reefpoints/tags","blobs_url":"https://api.github.com/repos/cllns/reefpoints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cllns/reefpoints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cllns/reefpoints/git/refs{/sha}","trees_url":"https://api.github.com/repos/cllns/reefpoints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cllns/reefpoints/statuses/{sha}","languages_url":"https://api.github.com/repos/cllns/reefpoints/languages","stargazers_url":"https://api.github.com/repos/cllns/reefpoints/stargazers","contributors_url":"https://api.github.com/repos/cllns/reefpoints/contributors","subscribers_url":"https://api.github.com/repos/cllns/reefpoints/subscribers","subscription_url":"https://api.github.com/repos/cllns/reefpoints/subscription","commits_url":"https://api.github.com/repos/cllns/reefpoints/commits{/sha}","git_commits_url":"https://api.github.com/repos/cllns/reefpoints/git/commits{/sha}","comments_url":"https://api.github.com/repos/cllns/reefpoints/comments{/number}","issue_comment_url":"https://api.github.com/repos/cllns/reefpoints/issues/comments{/number}","contents_url":"https://api.github.com/repos/cllns/reefpoints/contents/{+path}","compare_url":"https://api.github.com/repos/cllns/reefpoints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cllns/reefpoints/merges","archive_url":"https://api.github.com/repos/cllns/reefpoints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cllns/reefpoints/downloads","issues_url":"https://api.github.com/repos/cllns/reefpoints/issues{/number}","pulls_url":"https://api.github.com/repos/cllns/reefpoints/pulls{/number}","milestones_url":"https://api.github.com/repos/cllns/reefpoints/milestones{/number}","notifications_url":"https://api.github.com/repos/cllns/reefpoints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cllns/reefpoints/labels{/name}","releases_url":"https://api.github.com/repos/cllns/reefpoints/releases{/id}","created_at":"2015-04-24T01:38:47Z","updated_at":"2015-04-24T01:38:51Z","pushed_at":"2015-04-24T12:21:42Z","git_url":"git://github.com/cllns/reefpoints.git","ssh_url":"git@github.com:cllns/reefpoints.git","clone_url":"https://github.com/cllns/reefpoints.git","svn_url":"https://github.com/cllns/reefpoints","homepage":"http://reefpoints.dockyard.com","size":84320,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dockyard:master","ref":"master","sha":"0e8a5cb0f160aec04f35afe827df146dbfee29de","user":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?v=3","gravatar_id":"","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"repo":{"id":2262874,"name":"reefpoints","full_name":"dockyard/reefpoints","owner":{"login":"dockyard","id":873981,"avatar_url":"https://avatars.githubusercontent.com/u/873981?v=3","gravatar_id":"","url":"https://api.github.com/users/dockyard","html_url":"https://github.com/dockyard","followers_url":"https://api.github.com/users/dockyard/followers","following_url":"https://api.github.com/users/dockyard/following{/other_user}","gists_url":"https://api.github.com/users/dockyard/gists{/gist_id}","starred_url":"https://api.github.com/users/dockyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dockyard/subscriptions","organizations_url":"https://api.github.com/users/dockyard/orgs","repos_url":"https://api.github.com/users/dockyard/repos","events_url":"https://api.github.com/users/dockyard/events{/privacy}","received_events_url":"https://api.github.com/users/dockyard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dockyard/reefpoints","description":"DockYard Blog","fork":false,"url":"https://api.github.com/repos/dockyard/reefpoints","forks_url":"https://api.github.com/repos/dockyard/reefpoints/forks","keys_url":"https://api.github.com/repos/dockyard/reefpoints/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dockyard/reefpoints/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dockyard/reefpoints/teams","hooks_url":"https://api.github.com/repos/dockyard/reefpoints/hooks","issue_events_url":"https://api.github.com/repos/dockyard/reefpoints/issues/events{/number}","events_url":"https://api.github.com/repos/dockyard/reefpoints/events","assignees_url":"https://api.github.com/repos/dockyard/reefpoints/assignees{/user}","branches_url":"https://api.github.com/repos/dockyard/reefpoints/branches{/branch}","tags_url":"https://api.github.com/repos/dockyard/reefpoints/tags","blobs_url":"https://api.github.com/repos/dockyard/reefpoints/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dockyard/reefpoints/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dockyard/reefpoints/git/refs{/sha}","trees_url":"https://api.github.com/repos/dockyard/reefpoints/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dockyard/reefpoints/statuses/{sha}","languages_url":"https://api.github.com/repos/dockyard/reefpoints/languages","stargazers_url":"https://api.github.com/repos/dockyard/reefpoints/stargazers","contributors_url":"https://api.github.com/repos/dockyard/reefpoints/contributors","subscribers_url":"https://api.github.com/repos/dockyard/reefpoints/subscribers","subscription_url":"https://api.github.com/repos/dockyard/reefpoints/subscription","commits_url":"https://api.github.com/repos/dockyard/reefpoints/commits{/sha}","git_commits_url":"https://api.github.com/repos/dockyard/reefpoints/git/commits{/sha}","comments_url":"https://api.github.com/repos/dockyard/reefpoints/comments{/number}","issue_comment_url":"https://api.github.com/repos/dockyard/reefpoints/issues/comments{/number}","contents_url":"https://api.github.com/repos/dockyard/reefpoints/contents/{+path}","compare_url":"https://api.github.com/repos/dockyard/reefpoints/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dockyard/reefpoints/merges","archive_url":"https://api.github.com/repos/dockyard/reefpoints/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dockyard/reefpoints/downloads","issues_url":"https://api.github.com/repos/dockyard/reefpoints/issues{/number}","pulls_url":"https://api.github.com/repos/dockyard/reefpoints/pulls{/number}","milestones_url":"https://api.github.com/repos/dockyard/reefpoints/milestones{/number}","notifications_url":"https://api.github.com/repos/dockyard/reefpoints/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dockyard/reefpoints/labels{/name}","releases_url":"https://api.github.com/repos/dockyard/reefpoints/releases{/id}","created_at":"2011-08-24T16:55:40Z","updated_at":"2015-04-24T12:23:48Z","pushed_at":"2015-04-24T12:25:21Z","git_url":"git://github.com/dockyard/reefpoints.git","ssh_url":"git@github.com:dockyard/reefpoints.git","clone_url":"https://github.com/dockyard/reefpoints.git","svn_url":"https://github.com/dockyard/reefpoints","homepage":"http://reefpoints.dockyard.com","size":84320,"stargazers_count":33,"watchers_count":33,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":11,"forks":64,"open_issues":11,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dockyard/reefpoints/pulls/338"},"html":{"href":"https://github.com/dockyard/reefpoints/pull/338"},"issue":{"href":"https://api.github.com/repos/dockyard/reefpoints/issues/338"},"comments":{"href":"https://api.github.com/repos/dockyard/reefpoints/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/dockyard/reefpoints/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/dockyard/reefpoints/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dockyard/reefpoints/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/dockyard/reefpoints/statuses/8f83858c1ae66d2b850dbb6073a7efc42d895f85"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":4,"deletions":26,"changed_files":3}}