{"action":"created","comment":{"url":"https://api.github.com/repos/wireload/screenly-ose/pulls/comments/41138230","id":41138230,"diff_hunk":"@@ -28,7 +30,7 @@ def is_active(asset, at_time=None):\n \n     if asset['is_enabled'] and asset['start_date'] and asset['end_date']:\n         at = at_time or get_time()\n-        return asset['start_date'] <= at <= asset['end_date']\n+        return asset['start_date'] < at < asset['end_date']","path":"assets_helper.py","position":14,"original_position":14,"commit_id":"d9a833dad93e0fba5e625c4d3d51fcfcb23b0a4e","original_commit_id":"d9a833dad93e0fba5e625c4d3d51fcfcb23b0a4e","user":{"login":"aljungberg","id":154423,"avatar_url":"https://avatars.githubusercontent.com/u/154423?v=3","gravatar_id":"","url":"https://api.github.com/users/aljungberg","html_url":"https://github.com/aljungberg","followers_url":"https://api.github.com/users/aljungberg/followers","following_url":"https://api.github.com/users/aljungberg/following{/other_user}","gists_url":"https://api.github.com/users/aljungberg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljungberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljungberg/subscriptions","organizations_url":"https://api.github.com/users/aljungberg/orgs","repos_url":"https://api.github.com/users/aljungberg/repos","events_url":"https://api.github.com/users/aljungberg/events{/privacy}","received_events_url":"https://api.github.com/users/aljungberg/received_events","type":"User","site_admin":false},"body":"Aren't date ranges normally inclusive for the beginning? E.g. if you want to play something between 12:00 and 13:00, it would start at 12:00 but it may end 12:59:59.999.","created_at":"2015-10-05T12:36:39Z","updated_at":"2015-10-05T12:36:39Z","html_url":"https://github.com/wireload/screenly-ose/pull/313#discussion_r41138230","pull_request_url":"https://api.github.com/repos/wireload/screenly-ose/pulls/313","_links":{"self":{"href":"https://api.github.com/repos/wireload/screenly-ose/pulls/comments/41138230"},"html":{"href":"https://github.com/wireload/screenly-ose/pull/313#discussion_r41138230"},"pull_request":{"href":"https://api.github.com/repos/wireload/screenly-ose/pulls/313"}}},"pull_request":{"url":"https://api.github.com/repos/wireload/screenly-ose/pulls/313","id":46243601,"html_url":"https://github.com/wireload/screenly-ose/pull/313","diff_url":"https://github.com/wireload/screenly-ose/pull/313.diff","patch_url":"https://github.com/wireload/screenly-ose/pull/313.patch","issue_url":"https://api.github.com/repos/wireload/screenly-ose/issues/313","number":313,"state":"open","locked":false,"title":"Feature/merge new viewer","user":{"login":"over64","id":2621273,"avatar_url":"https://avatars.githubusercontent.com/u/2621273?v=3","gravatar_id":"","url":"https://api.github.com/users/over64","html_url":"https://github.com/over64","followers_url":"https://api.github.com/users/over64/followers","following_url":"https://api.github.com/users/over64/following{/other_user}","gists_url":"https://api.github.com/users/over64/gists{/gist_id}","starred_url":"https://api.github.com/users/over64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/over64/subscriptions","organizations_url":"https://api.github.com/users/over64/orgs","repos_url":"https://api.github.com/users/over64/repos","events_url":"https://api.github.com/users/over64/events{/privacy}","received_events_url":"https://api.github.com/users/over64/received_events","type":"User","site_admin":false},"body":"Merge with viewer PRO.\r\nhttps://github.com/wireload/screenly-ose/issues/305","created_at":"2015-09-29T07:17:44Z","updated_at":"2015-10-05T12:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95894f24a895653148e4ea2ba6c3caa95fe2a72d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wireload/screenly-ose/pulls/313/commits","review_comments_url":"https://api.github.com/repos/wireload/screenly-ose/pulls/313/comments","review_comment_url":"https://api.github.com/repos/wireload/screenly-ose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireload/screenly-ose/issues/313/comments","statuses_url":"https://api.github.com/repos/wireload/screenly-ose/statuses/d9a833dad93e0fba5e625c4d3d51fcfcb23b0a4e","head":{"label":"over64:feature/merge_new_viewer","ref":"feature/merge_new_viewer","sha":"d9a833dad93e0fba5e625c4d3d51fcfcb23b0a4e","user":{"login":"over64","id":2621273,"avatar_url":"https://avatars.githubusercontent.com/u/2621273?v=3","gravatar_id":"","url":"https://api.github.com/users/over64","html_url":"https://github.com/over64","followers_url":"https://api.github.com/users/over64/followers","following_url":"https://api.github.com/users/over64/following{/other_user}","gists_url":"https://api.github.com/users/over64/gists{/gist_id}","starred_url":"https://api.github.com/users/over64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/over64/subscriptions","organizations_url":"https://api.github.com/users/over64/orgs","repos_url":"https://api.github.com/users/over64/repos","events_url":"https://api.github.com/users/over64/events{/privacy}","received_events_url":"https://api.github.com/users/over64/received_events","type":"User","site_admin":false},"repo":{"id":43047348,"name":"screenly-ose","full_name":"over64/screenly-ose","owner":{"login":"over64","id":2621273,"avatar_url":"https://avatars.githubusercontent.com/u/2621273?v=3","gravatar_id":"","url":"https://api.github.com/users/over64","html_url":"https://github.com/over64","followers_url":"https://api.github.com/users/over64/followers","following_url":"https://api.github.com/users/over64/following{/other_user}","gists_url":"https://api.github.com/users/over64/gists{/gist_id}","starred_url":"https://api.github.com/users/over64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/over64/subscriptions","organizations_url":"https://api.github.com/users/over64/orgs","repos_url":"https://api.github.com/users/over64/repos","events_url":"https://api.github.com/users/over64/events{/privacy}","received_events_url":"https://api.github.com/users/over64/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/over64/screenly-ose","description":"Screenly OSE -- Digital Signage for the Raspberry Pi","fork":true,"url":"https://api.github.com/repos/over64/screenly-ose","forks_url":"https://api.github.com/repos/over64/screenly-ose/forks","keys_url":"https://api.github.com/repos/over64/screenly-ose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/over64/screenly-ose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/over64/screenly-ose/teams","hooks_url":"https://api.github.com/repos/over64/screenly-ose/hooks","issue_events_url":"https://api.github.com/repos/over64/screenly-ose/issues/events{/number}","events_url":"https://api.github.com/repos/over64/screenly-ose/events","assignees_url":"https://api.github.com/repos/over64/screenly-ose/assignees{/user}","branches_url":"https://api.github.com/repos/over64/screenly-ose/branches{/branch}","tags_url":"https://api.github.com/repos/over64/screenly-ose/tags","blobs_url":"https://api.github.com/repos/over64/screenly-ose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/over64/screenly-ose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/over64/screenly-ose/git/refs{/sha}","trees_url":"https://api.github.com/repos/over64/screenly-ose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/over64/screenly-ose/statuses/{sha}","languages_url":"https://api.github.com/repos/over64/screenly-ose/languages","stargazers_url":"https://api.github.com/repos/over64/screenly-ose/stargazers","contributors_url":"https://api.github.com/repos/over64/screenly-ose/contributors","subscribers_url":"https://api.github.com/repos/over64/screenly-ose/subscribers","subscription_url":"https://api.github.com/repos/over64/screenly-ose/subscription","commits_url":"https://api.github.com/repos/over64/screenly-ose/commits{/sha}","git_commits_url":"https://api.github.com/repos/over64/screenly-ose/git/commits{/sha}","comments_url":"https://api.github.com/repos/over64/screenly-ose/comments{/number}","issue_comment_url":"https://api.github.com/repos/over64/screenly-ose/issues/comments{/number}","contents_url":"https://api.github.com/repos/over64/screenly-ose/contents/{+path}","compare_url":"https://api.github.com/repos/over64/screenly-ose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/over64/screenly-ose/merges","archive_url":"https://api.github.com/repos/over64/screenly-ose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/over64/screenly-ose/downloads","issues_url":"https://api.github.com/repos/over64/screenly-ose/issues{/number}","pulls_url":"https://api.github.com/repos/over64/screenly-ose/pulls{/number}","milestones_url":"https://api.github.com/repos/over64/screenly-ose/milestones{/number}","notifications_url":"https://api.github.com/repos/over64/screenly-ose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/over64/screenly-ose/labels{/name}","releases_url":"https://api.github.com/repos/over64/screenly-ose/releases{/id}","created_at":"2015-09-24T05:47:03Z","updated_at":"2015-09-24T05:47:04Z","pushed_at":"2015-10-03T05:08:07Z","git_url":"git://github.com/over64/screenly-ose.git","ssh_url":"git@github.com:over64/screenly-ose.git","clone_url":"https://github.com/over64/screenly-ose.git","svn_url":"https://github.com/over64/screenly-ose","homepage":"","size":1318,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wireload:master","ref":"master","sha":"7c7055d7521ff23845aa64e57f8c3d3eb85049c2","user":{"login":"wireload","id":886398,"avatar_url":"https://avatars.githubusercontent.com/u/886398?v=3","gravatar_id":"","url":"https://api.github.com/users/wireload","html_url":"https://github.com/wireload","followers_url":"https://api.github.com/users/wireload/followers","following_url":"https://api.github.com/users/wireload/following{/other_user}","gists_url":"https://api.github.com/users/wireload/gists{/gist_id}","starred_url":"https://api.github.com/users/wireload/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireload/subscriptions","organizations_url":"https://api.github.com/users/wireload/orgs","repos_url":"https://api.github.com/users/wireload/repos","events_url":"https://api.github.com/users/wireload/events{/privacy}","received_events_url":"https://api.github.com/users/wireload/received_events","type":"Organization","site_admin":false},"repo":{"id":5169716,"name":"screenly-ose","full_name":"wireload/screenly-ose","owner":{"login":"wireload","id":886398,"avatar_url":"https://avatars.githubusercontent.com/u/886398?v=3","gravatar_id":"","url":"https://api.github.com/users/wireload","html_url":"https://github.com/wireload","followers_url":"https://api.github.com/users/wireload/followers","following_url":"https://api.github.com/users/wireload/following{/other_user}","gists_url":"https://api.github.com/users/wireload/gists{/gist_id}","starred_url":"https://api.github.com/users/wireload/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireload/subscriptions","organizations_url":"https://api.github.com/users/wireload/orgs","repos_url":"https://api.github.com/users/wireload/repos","events_url":"https://api.github.com/users/wireload/events{/privacy}","received_events_url":"https://api.github.com/users/wireload/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireload/screenly-ose","description":"Screenly OSE -- Digital Signage for the Raspberry Pi","fork":false,"url":"https://api.github.com/repos/wireload/screenly-ose","forks_url":"https://api.github.com/repos/wireload/screenly-ose/forks","keys_url":"https://api.github.com/repos/wireload/screenly-ose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireload/screenly-ose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireload/screenly-ose/teams","hooks_url":"https://api.github.com/repos/wireload/screenly-ose/hooks","issue_events_url":"https://api.github.com/repos/wireload/screenly-ose/issues/events{/number}","events_url":"https://api.github.com/repos/wireload/screenly-ose/events","assignees_url":"https://api.github.com/repos/wireload/screenly-ose/assignees{/user}","branches_url":"https://api.github.com/repos/wireload/screenly-ose/branches{/branch}","tags_url":"https://api.github.com/repos/wireload/screenly-ose/tags","blobs_url":"https://api.github.com/repos/wireload/screenly-ose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireload/screenly-ose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireload/screenly-ose/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireload/screenly-ose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireload/screenly-ose/statuses/{sha}","languages_url":"https://api.github.com/repos/wireload/screenly-ose/languages","stargazers_url":"https://api.github.com/repos/wireload/screenly-ose/stargazers","contributors_url":"https://api.github.com/repos/wireload/screenly-ose/contributors","subscribers_url":"https://api.github.com/repos/wireload/screenly-ose/subscribers","subscription_url":"https://api.github.com/repos/wireload/screenly-ose/subscription","commits_url":"https://api.github.com/repos/wireload/screenly-ose/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireload/screenly-ose/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireload/screenly-ose/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireload/screenly-ose/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireload/screenly-ose/contents/{+path}","compare_url":"https://api.github.com/repos/wireload/screenly-ose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireload/screenly-ose/merges","archive_url":"https://api.github.com/repos/wireload/screenly-ose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireload/screenly-ose/downloads","issues_url":"https://api.github.com/repos/wireload/screenly-ose/issues{/number}","pulls_url":"https://api.github.com/repos/wireload/screenly-ose/pulls{/number}","milestones_url":"https://api.github.com/repos/wireload/screenly-ose/milestones{/number}","notifications_url":"https://api.github.com/repos/wireload/screenly-ose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireload/screenly-ose/labels{/name}","releases_url":"https://api.github.com/repos/wireload/screenly-ose/releases{/id}","created_at":"2012-07-24T18:48:50Z","updated_at":"2015-09-23T05:37:01Z","pushed_at":"2015-10-05T12:32:59Z","git_url":"git://github.com/wireload/screenly-ose.git","ssh_url":"git@github.com:wireload/screenly-ose.git","clone_url":"https://github.com/wireload/screenly-ose.git","svn_url":"https://github.com/wireload/screenly-ose","homepage":"","size":2546,"stargazers_count":248,"watchers_count":248,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":133,"mirror_url":null,"open_issues_count":49,"forks":133,"open_issues":49,"watchers":248,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wireload/screenly-ose/pulls/313"},"html":{"href":"https://github.com/wireload/screenly-ose/pull/313"},"issue":{"href":"https://api.github.com/repos/wireload/screenly-ose/issues/313"},"comments":{"href":"https://api.github.com/repos/wireload/screenly-ose/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/wireload/screenly-ose/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/wireload/screenly-ose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireload/screenly-ose/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/wireload/screenly-ose/statuses/d9a833dad93e0fba5e625c4d3d51fcfcb23b0a4e"}}}}