{"action":"created","issue":{"url":"https://api.github.com/repos/piwik/piwik/issues/7878","labels_url":"https://api.github.com/repos/piwik/piwik/issues/7878/labels{/name}","comments_url":"https://api.github.com/repos/piwik/piwik/issues/7878/comments","events_url":"https://api.github.com/repos/piwik/piwik/issues/7878/events","html_url":"https://github.com/piwik/piwik/pull/7878","id":75064161,"number":7878,"title":"Fixes #7774 column headers missing in RowEvolution graph export.","user":{"login":"diosmosis","id":125140,"avatar_url":"https://avatars.githubusercontent.com/u/125140?v=3","gravatar_id":"","url":"https://api.github.com/users/diosmosis","html_url":"https://github.com/diosmosis","followers_url":"https://api.github.com/users/diosmosis/followers","following_url":"https://api.github.com/users/diosmosis/following{/other_user}","gists_url":"https://api.github.com/users/diosmosis/gists{/gist_id}","starred_url":"https://api.github.com/users/diosmosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diosmosis/subscriptions","organizations_url":"https://api.github.com/users/diosmosis/orgs","repos_url":"https://api.github.com/users/diosmosis/repos","events_url":"https://api.github.com/users/diosmosis/events{/privacy}","received_events_url":"https://api.github.com/users/diosmosis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/piwik/piwik/labels/Bug","name":"Bug","color":"fc2929"},{"url":"https://api.github.com/repos/piwik/piwik/labels/Needs%20Review","name":"Needs Review","color":"fad8c7"},{"url":"https://api.github.com/repos/piwik/piwik/labels/not-in-changelog","name":"not-in-changelog","color":"ffffff"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/piwik/piwik/milestones/79","html_url":"https://github.com/piwik/piwik/milestones/2.14.0","labels_url":"https://api.github.com/repos/piwik/piwik/milestones/79/labels","id":1005076,"number":79,"title":"2.14.0","description":"","creator":{"login":"mattab","id":466765,"avatar_url":"https://avatars.githubusercontent.com/u/466765?v=3","gravatar_id":"","url":"https://api.github.com/users/mattab","html_url":"https://github.com/mattab","followers_url":"https://api.github.com/users/mattab/followers","following_url":"https://api.github.com/users/mattab/following{/other_user}","gists_url":"https://api.github.com/users/mattab/gists{/gist_id}","starred_url":"https://api.github.com/users/mattab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattab/subscriptions","organizations_url":"https://api.github.com/users/mattab/orgs","repos_url":"https://api.github.com/users/mattab/repos","events_url":"https://api.github.com/users/mattab/events{/privacy}","received_events_url":"https://api.github.com/users/mattab/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":36,"state":"open","created_at":"2015-03-04T03:03:44Z","updated_at":"2015-05-11T05:58:02Z","due_on":"2015-05-19T12:00:00Z","closed_at":null},"comments":5,"created_at":"2015-05-11T02:52:35Z","updated_at":"2015-05-12T03:29:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/piwik/piwik/pulls/7878","html_url":"https://github.com/piwik/piwik/pull/7878","diff_url":"https://github.com/piwik/piwik/pull/7878.diff","patch_url":"https://github.com/piwik/piwik/pull/7878.patch"},"body":"This PR includes the small fix mentioned in a comment by @tsteur as well as UI tests for the report exporting feature. The new tests download the export links in phantomjs and compare the contents w/ expected files. To do this, I've added a new keyword `file` and a new assertion `pageContents`, which can be used as follows:\r\n\r\n```\r\nexpect.file('file.xml').to.be.pageContents(function (page) {\r\n   // ...\r\n});\r\n```\r\n\r\nThere is also a new page renderer method `downloadLink` which hacks around one of phantomjs' limitations. phantomjs will not display non-HTML files by default, so we can't just click an export link. Instead, we have to download via AJAX and set the page contents manually.\r\n\r\nRefs #7774"},"comment":{"url":"https://api.github.com/repos/piwik/piwik/issues/comments/101116150","html_url":"https://github.com/piwik/piwik/pull/7878#issuecomment-101116150","issue_url":"https://api.github.com/repos/piwik/piwik/issues/7878","id":101116150,"user":{"login":"diosmosis","id":125140,"avatar_url":"https://avatars.githubusercontent.com/u/125140?v=3","gravatar_id":"","url":"https://api.github.com/users/diosmosis","html_url":"https://github.com/diosmosis","followers_url":"https://api.github.com/users/diosmosis/followers","following_url":"https://api.github.com/users/diosmosis/following{/other_user}","gists_url":"https://api.github.com/users/diosmosis/gists{/gist_id}","starred_url":"https://api.github.com/users/diosmosis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diosmosis/subscriptions","organizations_url":"https://api.github.com/users/diosmosis/orgs","repos_url":"https://api.github.com/users/diosmosis/repos","events_url":"https://api.github.com/users/diosmosis/events{/privacy}","received_events_url":"https://api.github.com/users/diosmosis/received_events","type":"User","site_admin":false},"created_at":"2015-05-12T03:29:25Z","updated_at":"2015-05-12T03:29:25Z","body":"Those are tests for the export links; they need expected output. I was going to put them in after the merge. Otherwise I can create a branch on the ui screenshot repo, but then the merge will have to be done from the command line."}}