{"action":"created","comment":{"url":"https://api.github.com/repos/espressopp/espressopp/pulls/comments/27140705","id":27140705,"diff_hunk":"@@ -34,28 +35,36 @@\n namespace espressopp {\n \n   Version::Version() {\n-\t  name          = \"ESPResSo++\";\n-      major         = MAJORVERSION;\n-\t  minor         = MINORVERSION;\n-\t  patchlevel    = PATCHLEVEL;\n-\t  gitrevision    = gitversion;\n-      boostversion  = BOOST_LIB_VERSION;\n-\t  date          = __DATE__;\n-\t  time          = __TIME__;\n+    name_          = \"ESPResSo++\";\n+    major_         = MAJORVERSION;\n+    minor_         = MINORVERSION;\n+    patchlevel_    = PATCHLEVEL;\n+    gitrevision_    = gitversion;\n+    boostversion_  = BOOST_LIB_VERSION;\n+    date_          = __DATE__;\n+    time_          = __TIME__;","path":"src/Version.cpp","position":31,"original_position":31,"commit_id":"d5e365207af79ac9f9e5cef0b421d8371c35180e","original_commit_id":"d5e365207af79ac9f9e5cef0b421d8371c35180e","user":{"login":"MrTheodor","id":563684,"avatar_url":"https://avatars.githubusercontent.com/u/563684?v=3","gravatar_id":"","url":"https://api.github.com/users/MrTheodor","html_url":"https://github.com/MrTheodor","followers_url":"https://api.github.com/users/MrTheodor/followers","following_url":"https://api.github.com/users/MrTheodor/following{/other_user}","gists_url":"https://api.github.com/users/MrTheodor/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTheodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTheodor/subscriptions","organizations_url":"https://api.github.com/users/MrTheodor/orgs","repos_url":"https://api.github.com/users/MrTheodor/repos","events_url":"https://api.github.com/users/MrTheodor/events{/privacy}","received_events_url":"https://api.github.com/users/MrTheodor/received_events","type":"User","site_admin":false},"body":"1. clean up, there was a mix of tabs and spaces.\r\n2. the variable name 'name_' allows me to have ver.name() in the code, of course that's a matter of taste, nothing ore. (following: https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Variable_Names)","created_at":"2015-03-25T16:52:29Z","updated_at":"2015-03-25T16:52:29Z","html_url":"https://github.com/espressopp/espressopp/pull/5#discussion_r27140705","pull_request_url":"https://api.github.com/repos/espressopp/espressopp/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/comments/27140705"},"html":{"href":"https://github.com/espressopp/espressopp/pull/5#discussion_r27140705"},"pull_request":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/espressopp/espressopp/pulls/5","id":31935825,"html_url":"https://github.com/espressopp/espressopp/pull/5","diff_url":"https://github.com/espressopp/espressopp/pull/5.diff","patch_url":"https://github.com/espressopp/espressopp/pull/5.patch","issue_url":"https://api.github.com/repos/espressopp/espressopp/issues/5","number":5,"state":"open","locked":false,"title":"H5MD writer","user":{"login":"MrTheodor","id":563684,"avatar_url":"https://avatars.githubusercontent.com/u/563684?v=3","gravatar_id":"","url":"https://api.github.com/users/MrTheodor","html_url":"https://github.com/MrTheodor","followers_url":"https://api.github.com/users/MrTheodor/followers","following_url":"https://api.github.com/users/MrTheodor/following{/other_user}","gists_url":"https://api.github.com/users/MrTheodor/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTheodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTheodor/subscriptions","organizations_url":"https://api.github.com/users/MrTheodor/orgs","repos_url":"https://api.github.com/users/MrTheodor/repos","events_url":"https://api.github.com/users/MrTheodor/events{/privacy}","received_events_url":"https://api.github.com/users/MrTheodor/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-25T15:52:38Z","updated_at":"2015-03-25T16:52:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af538d5ea6ce919a61c19a5204c0bd6602e39169","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/espressopp/espressopp/pulls/5/commits","review_comments_url":"https://api.github.com/repos/espressopp/espressopp/pulls/5/comments","review_comment_url":"https://api.github.com/repos/espressopp/espressopp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espressopp/espressopp/issues/5/comments","statuses_url":"https://api.github.com/repos/espressopp/espressopp/statuses/d5e365207af79ac9f9e5cef0b421d8371c35180e","head":{"label":"MrTheodor:h5md","ref":"h5md","sha":"d5e365207af79ac9f9e5cef0b421d8371c35180e","user":{"login":"MrTheodor","id":563684,"avatar_url":"https://avatars.githubusercontent.com/u/563684?v=3","gravatar_id":"","url":"https://api.github.com/users/MrTheodor","html_url":"https://github.com/MrTheodor","followers_url":"https://api.github.com/users/MrTheodor/followers","following_url":"https://api.github.com/users/MrTheodor/following{/other_user}","gists_url":"https://api.github.com/users/MrTheodor/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTheodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTheodor/subscriptions","organizations_url":"https://api.github.com/users/MrTheodor/orgs","repos_url":"https://api.github.com/users/MrTheodor/repos","events_url":"https://api.github.com/users/MrTheodor/events{/privacy}","received_events_url":"https://api.github.com/users/MrTheodor/received_events","type":"User","site_admin":false},"repo":{"id":31235216,"name":"espressopp","full_name":"MrTheodor/espressopp","owner":{"login":"MrTheodor","id":563684,"avatar_url":"https://avatars.githubusercontent.com/u/563684?v=3","gravatar_id":"","url":"https://api.github.com/users/MrTheodor","html_url":"https://github.com/MrTheodor","followers_url":"https://api.github.com/users/MrTheodor/followers","following_url":"https://api.github.com/users/MrTheodor/following{/other_user}","gists_url":"https://api.github.com/users/MrTheodor/gists{/gist_id}","starred_url":"https://api.github.com/users/MrTheodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrTheodor/subscriptions","organizations_url":"https://api.github.com/users/MrTheodor/orgs","repos_url":"https://api.github.com/users/MrTheodor/repos","events_url":"https://api.github.com/users/MrTheodor/events{/privacy}","received_events_url":"https://api.github.com/users/MrTheodor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrTheodor/espressopp","description":"Fork of espressopp repository","fork":true,"url":"https://api.github.com/repos/MrTheodor/espressopp","forks_url":"https://api.github.com/repos/MrTheodor/espressopp/forks","keys_url":"https://api.github.com/repos/MrTheodor/espressopp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrTheodor/espressopp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrTheodor/espressopp/teams","hooks_url":"https://api.github.com/repos/MrTheodor/espressopp/hooks","issue_events_url":"https://api.github.com/repos/MrTheodor/espressopp/issues/events{/number}","events_url":"https://api.github.com/repos/MrTheodor/espressopp/events","assignees_url":"https://api.github.com/repos/MrTheodor/espressopp/assignees{/user}","branches_url":"https://api.github.com/repos/MrTheodor/espressopp/branches{/branch}","tags_url":"https://api.github.com/repos/MrTheodor/espressopp/tags","blobs_url":"https://api.github.com/repos/MrTheodor/espressopp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrTheodor/espressopp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrTheodor/espressopp/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrTheodor/espressopp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrTheodor/espressopp/statuses/{sha}","languages_url":"https://api.github.com/repos/MrTheodor/espressopp/languages","stargazers_url":"https://api.github.com/repos/MrTheodor/espressopp/stargazers","contributors_url":"https://api.github.com/repos/MrTheodor/espressopp/contributors","subscribers_url":"https://api.github.com/repos/MrTheodor/espressopp/subscribers","subscription_url":"https://api.github.com/repos/MrTheodor/espressopp/subscription","commits_url":"https://api.github.com/repos/MrTheodor/espressopp/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrTheodor/espressopp/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrTheodor/espressopp/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrTheodor/espressopp/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrTheodor/espressopp/contents/{+path}","compare_url":"https://api.github.com/repos/MrTheodor/espressopp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrTheodor/espressopp/merges","archive_url":"https://api.github.com/repos/MrTheodor/espressopp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrTheodor/espressopp/downloads","issues_url":"https://api.github.com/repos/MrTheodor/espressopp/issues{/number}","pulls_url":"https://api.github.com/repos/MrTheodor/espressopp/pulls{/number}","milestones_url":"https://api.github.com/repos/MrTheodor/espressopp/milestones{/number}","notifications_url":"https://api.github.com/repos/MrTheodor/espressopp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrTheodor/espressopp/labels{/name}","releases_url":"https://api.github.com/repos/MrTheodor/espressopp/releases{/id}","created_at":"2015-02-23T23:16:04Z","updated_at":"2015-03-23T09:25:54Z","pushed_at":"2015-03-25T15:40:32Z","git_url":"git://github.com/MrTheodor/espressopp.git","ssh_url":"git@github.com:MrTheodor/espressopp.git","clone_url":"https://github.com/MrTheodor/espressopp.git","svn_url":"https://github.com/MrTheodor/espressopp","homepage":"","size":57735,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"espressopp:master","ref":"master","sha":"be54b281468a758f98bf327869c21979f44d5b51","user":{"login":"espressopp","id":9050876,"avatar_url":"https://avatars.githubusercontent.com/u/9050876?v=3","gravatar_id":"","url":"https://api.github.com/users/espressopp","html_url":"https://github.com/espressopp","followers_url":"https://api.github.com/users/espressopp/followers","following_url":"https://api.github.com/users/espressopp/following{/other_user}","gists_url":"https://api.github.com/users/espressopp/gists{/gist_id}","starred_url":"https://api.github.com/users/espressopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressopp/subscriptions","organizations_url":"https://api.github.com/users/espressopp/orgs","repos_url":"https://api.github.com/users/espressopp/repos","events_url":"https://api.github.com/users/espressopp/events{/privacy}","received_events_url":"https://api.github.com/users/espressopp/received_events","type":"Organization","site_admin":false},"repo":{"id":24889759,"name":"espressopp","full_name":"espressopp/espressopp","owner":{"login":"espressopp","id":9050876,"avatar_url":"https://avatars.githubusercontent.com/u/9050876?v=3","gravatar_id":"","url":"https://api.github.com/users/espressopp","html_url":"https://github.com/espressopp","followers_url":"https://api.github.com/users/espressopp/followers","following_url":"https://api.github.com/users/espressopp/following{/other_user}","gists_url":"https://api.github.com/users/espressopp/gists{/gist_id}","starred_url":"https://api.github.com/users/espressopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espressopp/subscriptions","organizations_url":"https://api.github.com/users/espressopp/orgs","repos_url":"https://api.github.com/users/espressopp/repos","events_url":"https://api.github.com/users/espressopp/events{/privacy}","received_events_url":"https://api.github.com/users/espressopp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/espressopp/espressopp","description":"Main ESPResSo++ repository","fork":false,"url":"https://api.github.com/repos/espressopp/espressopp","forks_url":"https://api.github.com/repos/espressopp/espressopp/forks","keys_url":"https://api.github.com/repos/espressopp/espressopp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espressopp/espressopp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espressopp/espressopp/teams","hooks_url":"https://api.github.com/repos/espressopp/espressopp/hooks","issue_events_url":"https://api.github.com/repos/espressopp/espressopp/issues/events{/number}","events_url":"https://api.github.com/repos/espressopp/espressopp/events","assignees_url":"https://api.github.com/repos/espressopp/espressopp/assignees{/user}","branches_url":"https://api.github.com/repos/espressopp/espressopp/branches{/branch}","tags_url":"https://api.github.com/repos/espressopp/espressopp/tags","blobs_url":"https://api.github.com/repos/espressopp/espressopp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espressopp/espressopp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espressopp/espressopp/git/refs{/sha}","trees_url":"https://api.github.com/repos/espressopp/espressopp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espressopp/espressopp/statuses/{sha}","languages_url":"https://api.github.com/repos/espressopp/espressopp/languages","stargazers_url":"https://api.github.com/repos/espressopp/espressopp/stargazers","contributors_url":"https://api.github.com/repos/espressopp/espressopp/contributors","subscribers_url":"https://api.github.com/repos/espressopp/espressopp/subscribers","subscription_url":"https://api.github.com/repos/espressopp/espressopp/subscription","commits_url":"https://api.github.com/repos/espressopp/espressopp/commits{/sha}","git_commits_url":"https://api.github.com/repos/espressopp/espressopp/git/commits{/sha}","comments_url":"https://api.github.com/repos/espressopp/espressopp/comments{/number}","issue_comment_url":"https://api.github.com/repos/espressopp/espressopp/issues/comments{/number}","contents_url":"https://api.github.com/repos/espressopp/espressopp/contents/{+path}","compare_url":"https://api.github.com/repos/espressopp/espressopp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espressopp/espressopp/merges","archive_url":"https://api.github.com/repos/espressopp/espressopp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espressopp/espressopp/downloads","issues_url":"https://api.github.com/repos/espressopp/espressopp/issues{/number}","pulls_url":"https://api.github.com/repos/espressopp/espressopp/pulls{/number}","milestones_url":"https://api.github.com/repos/espressopp/espressopp/milestones{/number}","notifications_url":"https://api.github.com/repos/espressopp/espressopp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espressopp/espressopp/labels{/name}","releases_url":"https://api.github.com/repos/espressopp/espressopp/releases{/id}","created_at":"2014-10-07T12:44:28Z","updated_at":"2015-03-19T23:36:02Z","pushed_at":"2015-03-25T15:52:39Z","git_url":"git://github.com/espressopp/espressopp.git","ssh_url":"git@github.com:espressopp/espressopp.git","clone_url":"https://github.com/espressopp/espressopp.git","svn_url":"https://github.com/espressopp/espressopp","homepage":"http://www.espresso-pp.de/","size":57894,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/5"},"html":{"href":"https://github.com/espressopp/espressopp/pull/5"},"issue":{"href":"https://api.github.com/repos/espressopp/espressopp/issues/5"},"comments":{"href":"https://api.github.com/repos/espressopp/espressopp/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espressopp/espressopp/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/espressopp/espressopp/statuses/d5e365207af79ac9f9e5cef0b421d8371c35180e"}}}}