{"action":"created","issue":{"url":"https://api.github.com/repos/appropriate/docker-jetty/issues/16","labels_url":"https://api.github.com/repos/appropriate/docker-jetty/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/appropriate/docker-jetty/issues/16/comments","events_url":"https://api.github.com/repos/appropriate/docker-jetty/issues/16/events","html_url":"https://github.com/appropriate/docker-jetty/pull/16","id":103149681,"number":16,"title":"Directly execute start.jar rather than use shell script","user":{"login":"gregw","id":70829,"avatar_url":"https://avatars.githubusercontent.com/u/70829?v=3","gravatar_id":"","url":"https://api.github.com/users/gregw","html_url":"https://github.com/gregw","followers_url":"https://api.github.com/users/gregw/followers","following_url":"https://api.github.com/users/gregw/following{/other_user}","gists_url":"https://api.github.com/users/gregw/gists{/gist_id}","starred_url":"https://api.github.com/users/gregw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregw/subscriptions","organizations_url":"https://api.github.com/users/gregw/orgs","repos_url":"https://api.github.com/users/gregw/repos","events_url":"https://api.github.com/users/gregw/events{/privacy}","received_events_url":"https://api.github.com/users/gregw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":32,"created_at":"2015-08-26T01:29:47Z","updated_at":"2015-08-27T03:22:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/appropriate/docker-jetty/pulls/16","html_url":"https://github.com/appropriate/docker-jetty/pull/16","diff_url":"https://github.com/appropriate/docker-jetty/pull/16.diff","patch_url":"https://github.com/appropriate/docker-jetty/pull/16.patch"},"body":"Rather than use the shell script to start Jetty, I believe it would be better to directly run the start.jar\r\n\r\nThe jetty shell script is really intended as an /etc/init.d script and does all the location of java, home and base, which is already known in the ENV settings of the Dockerfile.\r\n\r\nSo we can avoid creating a shell process, which will be some time and space savings, but more importantly we are able to pass in command line arguments to the start.jar, so you can do things like:\r\n````\r\ndocker run jetty-9.3-jre8 --list-config\r\n````\r\nTo see the configuration of the image.\r\n\r\n````\r\ndocker run jetty-9.3-jre8 --module=debug\r\n````\r\nruns jetty, but with the debug module enabled\r\n\r\n````\r\ndocker run jetty-9.3-jre8 --dry-run\r\n````\r\nReports the exact command line that would be run by start.jar, which can be used to craft an Entry-Point for another image that avoids even the start.jar startup time and memory.\r\n\r\nI've only updated 9.3 image at the moment.... if this is considered a good idea I can do all the versions... or perhaps we only do it for versions going forward?  or perhaps it is a bad idea for some reason I don't know yet???\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/appropriate/docker-jetty/issues/comments/135273718","html_url":"https://github.com/appropriate/docker-jetty/pull/16#issuecomment-135273718","issue_url":"https://api.github.com/repos/appropriate/docker-jetty/issues/16","id":135273718,"user":{"login":"md5","id":76367,"avatar_url":"https://avatars.githubusercontent.com/u/76367?v=3","gravatar_id":"","url":"https://api.github.com/users/md5","html_url":"https://github.com/md5","followers_url":"https://api.github.com/users/md5/followers","following_url":"https://api.github.com/users/md5/following{/other_user}","gists_url":"https://api.github.com/users/md5/gists{/gist_id}","starred_url":"https://api.github.com/users/md5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/md5/subscriptions","organizations_url":"https://api.github.com/users/md5/orgs","repos_url":"https://api.github.com/users/md5/repos","events_url":"https://api.github.com/users/md5/events{/privacy}","received_events_url":"https://api.github.com/users/md5/received_events","type":"User","site_admin":false},"created_at":"2015-08-27T03:22:55Z","updated_at":"2015-08-27T03:22:55Z","body":"Gah! You're totally I right about my missing the `ENTRYPOINT` directive. Duh...\r\n\r\nI'll fix this up and squash it."}}