{"action":"created","comment":{"url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/comments/48182088","id":48182088,"diff_hunk":"@@ -89,17 +127,22 @@ public GLAccount getGLAccount(String glCode, String fromDate, String toDate) thr\n \t * @throws MambuApiException\r\n \t *             in case of an error\r\n \t */\r\n-\tpublic List<GLJournalEntry> getGLJournalEntries(Date fromDate, Date toDate) throws MambuApiException {\r","path":"src/com/mambu/apisdk/services/AccountingService.java","position":105,"original_position":105,"commit_id":"359958da3f737efc1a2e442100b398e60528b95a","original_commit_id":"359958da3f737efc1a2e442100b398e60528b95a","user":{"login":"mdanilkis","id":3077634,"avatar_url":"https://avatars.githubusercontent.com/u/3077634?v=3","gravatar_id":"","url":"https://api.github.com/users/mdanilkis","html_url":"https://github.com/mdanilkis","followers_url":"https://api.github.com/users/mdanilkis/followers","following_url":"https://api.github.com/users/mdanilkis/following{/other_user}","gists_url":"https://api.github.com/users/mdanilkis/gists{/gist_id}","starred_url":"https://api.github.com/users/mdanilkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdanilkis/subscriptions","organizations_url":"https://api.github.com/users/mdanilkis/orgs","repos_url":"https://api.github.com/users/mdanilkis/repos","events_url":"https://api.github.com/users/mdanilkis/events{/privacy}","received_events_url":"https://api.github.com/users/mdanilkis/received_events","type":"User","site_admin":false},"body":"Right.  I will add back methods with no \"branchId\" parameter and will deprecate them","created_at":"2015-12-21T19:39:04Z","updated_at":"2015-12-21T19:39:04Z","html_url":"https://github.com/mambu-gmbh/Mambu-APIs-Java/pull/54#discussion_r48182088","pull_request_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/comments/48182088"},"html":{"href":"https://github.com/mambu-gmbh/Mambu-APIs-Java/pull/54#discussion_r48182088"},"pull_request":{"href":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/54","id":52620726,"html_url":"https://github.com/mambu-gmbh/Mambu-APIs-Java/pull/54","diff_url":"https://github.com/mambu-gmbh/Mambu-APIs-Java/pull/54.diff","patch_url":"https://github.com/mambu-gmbh/Mambu-APIs-Java/pull/54.patch","issue_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/issues/54","number":54,"state":"open","locked":false,"title":"Updated to support API changes for Mambu 3.14","user":{"login":"mdanilkis","id":3077634,"avatar_url":"https://avatars.githubusercontent.com/u/3077634?v=3","gravatar_id":"","url":"https://api.github.com/users/mdanilkis","html_url":"https://github.com/mdanilkis","followers_url":"https://api.github.com/users/mdanilkis/followers","following_url":"https://api.github.com/users/mdanilkis/following{/other_user}","gists_url":"https://api.github.com/users/mdanilkis/gists{/gist_id}","starred_url":"https://api.github.com/users/mdanilkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdanilkis/subscriptions","organizations_url":"https://api.github.com/users/mdanilkis/orgs","repos_url":"https://api.github.com/users/mdanilkis/repos","events_url":"https://api.github.com/users/mdanilkis/events{/privacy}","received_events_url":"https://api.github.com/users/mdanilkis/received_events","type":"User","site_admin":false},"body":"Major additions:\r\n- Update Savings Account Terms API. See MBU-10447\r\n- GET User Roles and GET User Role APIs. See MBU-9263 and MBU-9263\r\n- Write Off Loan Accounts API. See MBU-10423\r\n- GET Document Templates API: GET Populated Account and Transaction Templates. See MBU-10631) and  MBU-10632 . Added DocumentTemplatesService\r\n- GET  loan accounts funded by a deposit investor account. See MBU-10905\r\n- GET Entities by Custom View API now supports BASIC and FULL_DETAILS  result types. See MBU-10842. Added CustomViewsService.\r\n- Added missing methods for GET GL accounts and GET Journal Entries. Available since v2.0. See MBU-1543 and MBU-1736\r\n- Added missing (since 3.6) methods to GET Documents for Products, Users, Branches and Centres. Enhanced existent methods to support pagination. See MBU-5084\r\n\r\nChanges:\r\n- Communication Messages History can be now searched via On The Fly filtering APIs.  See MBU-10646\r\n- Repayments Schedule API:  added support for Fixed Days instalments (which now can be specified at the account level). See MBU-10205\r\n\r\nMiscellaneous Enhancements:\r\nDemoTests:\r\na) added support for running regression tests for accounts in a loop for all supported product types\r\nb) added support for testing new Revolving Credit product types. See MBU-10111, MBU-10546\r\nc) testing support for On the Fly Search API:  Sorting Columns (MBU-10444) and filter entities based on Another Entity criteria (MBU-8985).\r\nd) added support for Search API to test searching Lines of Credit.  New in 3.14\r\n\r\nUpdated to support 3.14 model changes. Example, MBU-9725,  MBU-10949","created_at":"2015-12-04T01:57:44Z","updated_at":"2015-12-21T19:39:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e23ed68597cb39c865a83953ee1acf9a6e6fef92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/54/commits","review_comments_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/54/comments","review_comment_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/issues/54/comments","statuses_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/statuses/359958da3f737efc1a2e442100b398e60528b95a","head":{"label":"mdanilkis:master","ref":"master","sha":"359958da3f737efc1a2e442100b398e60528b95a","user":{"login":"mdanilkis","id":3077634,"avatar_url":"https://avatars.githubusercontent.com/u/3077634?v=3","gravatar_id":"","url":"https://api.github.com/users/mdanilkis","html_url":"https://github.com/mdanilkis","followers_url":"https://api.github.com/users/mdanilkis/followers","following_url":"https://api.github.com/users/mdanilkis/following{/other_user}","gists_url":"https://api.github.com/users/mdanilkis/gists{/gist_id}","starred_url":"https://api.github.com/users/mdanilkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdanilkis/subscriptions","organizations_url":"https://api.github.com/users/mdanilkis/orgs","repos_url":"https://api.github.com/users/mdanilkis/repos","events_url":"https://api.github.com/users/mdanilkis/events{/privacy}","received_events_url":"https://api.github.com/users/mdanilkis/received_events","type":"User","site_admin":false},"repo":{"id":7281087,"name":"Mambu-APIs-Java","full_name":"mdanilkis/Mambu-APIs-Java","owner":{"login":"mdanilkis","id":3077634,"avatar_url":"https://avatars.githubusercontent.com/u/3077634?v=3","gravatar_id":"","url":"https://api.github.com/users/mdanilkis","html_url":"https://github.com/mdanilkis","followers_url":"https://api.github.com/users/mdanilkis/followers","following_url":"https://api.github.com/users/mdanilkis/following{/other_user}","gists_url":"https://api.github.com/users/mdanilkis/gists{/gist_id}","starred_url":"https://api.github.com/users/mdanilkis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdanilkis/subscriptions","organizations_url":"https://api.github.com/users/mdanilkis/orgs","repos_url":"https://api.github.com/users/mdanilkis/repos","events_url":"https://api.github.com/users/mdanilkis/events{/privacy}","received_events_url":"https://api.github.com/users/mdanilkis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdanilkis/Mambu-APIs-Java","description":"Java Library for working the the Mambu APIs","fork":true,"url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java","forks_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/forks","keys_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/teams","hooks_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/hooks","issue_events_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/issues/events{/number}","events_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/events","assignees_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/assignees{/user}","branches_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/branches{/branch}","tags_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/tags","blobs_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/statuses/{sha}","languages_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/languages","stargazers_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/stargazers","contributors_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/contributors","subscribers_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/subscribers","subscription_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/subscription","commits_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/contents/{+path}","compare_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/merges","archive_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/downloads","issues_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/issues{/number}","pulls_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/pulls{/number}","milestones_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/milestones{/number}","notifications_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/labels{/name}","releases_url":"https://api.github.com/repos/mdanilkis/Mambu-APIs-Java/releases{/id}","created_at":"2012-12-22T00:46:59Z","updated_at":"2015-05-08T04:03:00Z","pushed_at":"2015-12-04T01:33:36Z","git_url":"git://github.com/mdanilkis/Mambu-APIs-Java.git","ssh_url":"git@github.com:mdanilkis/Mambu-APIs-Java.git","clone_url":"https://github.com/mdanilkis/Mambu-APIs-Java.git","svn_url":"https://github.com/mdanilkis/Mambu-APIs-Java","homepage":"www.mambu.com","size":69504,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mambu-gmbh:master","ref":"master","sha":"55500cd8e00639d395eaf8b66f2d402097979202","user":{"login":"mambu-gmbh","id":1001313,"avatar_url":"https://avatars.githubusercontent.com/u/1001313?v=3","gravatar_id":"","url":"https://api.github.com/users/mambu-gmbh","html_url":"https://github.com/mambu-gmbh","followers_url":"https://api.github.com/users/mambu-gmbh/followers","following_url":"https://api.github.com/users/mambu-gmbh/following{/other_user}","gists_url":"https://api.github.com/users/mambu-gmbh/gists{/gist_id}","starred_url":"https://api.github.com/users/mambu-gmbh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mambu-gmbh/subscriptions","organizations_url":"https://api.github.com/users/mambu-gmbh/orgs","repos_url":"https://api.github.com/users/mambu-gmbh/repos","events_url":"https://api.github.com/users/mambu-gmbh/events{/privacy}","received_events_url":"https://api.github.com/users/mambu-gmbh/received_events","type":"Organization","site_admin":false},"repo":{"id":2475461,"name":"Mambu-APIs-Java","full_name":"mambu-gmbh/Mambu-APIs-Java","owner":{"login":"mambu-gmbh","id":1001313,"avatar_url":"https://avatars.githubusercontent.com/u/1001313?v=3","gravatar_id":"","url":"https://api.github.com/users/mambu-gmbh","html_url":"https://github.com/mambu-gmbh","followers_url":"https://api.github.com/users/mambu-gmbh/followers","following_url":"https://api.github.com/users/mambu-gmbh/following{/other_user}","gists_url":"https://api.github.com/users/mambu-gmbh/gists{/gist_id}","starred_url":"https://api.github.com/users/mambu-gmbh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mambu-gmbh/subscriptions","organizations_url":"https://api.github.com/users/mambu-gmbh/orgs","repos_url":"https://api.github.com/users/mambu-gmbh/repos","events_url":"https://api.github.com/users/mambu-gmbh/events{/privacy}","received_events_url":"https://api.github.com/users/mambu-gmbh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mambu-gmbh/Mambu-APIs-Java","description":"Java Library for working the the Mambu APIs","fork":false,"url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java","forks_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/forks","keys_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/teams","hooks_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/hooks","issue_events_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/issues/events{/number}","events_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/events","assignees_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/assignees{/user}","branches_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/branches{/branch}","tags_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/tags","blobs_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/git/refs{/sha}","trees_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/statuses/{sha}","languages_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/languages","stargazers_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/stargazers","contributors_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/contributors","subscribers_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/subscribers","subscription_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/subscription","commits_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/commits{/sha}","git_commits_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/git/commits{/sha}","comments_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/comments{/number}","issue_comment_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/issues/comments{/number}","contents_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/contents/{+path}","compare_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/merges","archive_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/downloads","issues_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/issues{/number}","pulls_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls{/number}","milestones_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/milestones{/number}","notifications_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/labels{/name}","releases_url":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/releases{/id}","created_at":"2011-09-28T14:31:44Z","updated_at":"2015-12-07T08:00:12Z","pushed_at":"2015-12-04T01:57:44Z","git_url":"git://github.com/mambu-gmbh/Mambu-APIs-Java.git","ssh_url":"git@github.com:mambu-gmbh/Mambu-APIs-Java.git","clone_url":"https://github.com/mambu-gmbh/Mambu-APIs-Java.git","svn_url":"https://github.com/mambu-gmbh/Mambu-APIs-Java","homepage":"www.mambu.com","size":69510,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":6,"forks":8,"open_issues":6,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/54"},"html":{"href":"https://github.com/mambu-gmbh/Mambu-APIs-Java/pull/54"},"issue":{"href":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/issues/54"},"comments":{"href":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/mambu-gmbh/Mambu-APIs-Java/statuses/359958da3f737efc1a2e442100b398e60528b95a"}}}}