{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/27444316","id":27444316,"diff_hunk":"@@ -353,7 +353,7 @@ void                dspRegMask(regMaskTP regMask, size_t minSiz)\n #endif // _TARGET_*\n             }\n             // We've already printed a register. Is this the end of a range?\n-            else if ((regNum == REG_INT_LAST)\n+            else if (regNum == REG_INT_LAST","path":"src/jit/utils.cpp","position":5,"original_position":5,"commit_id":"d98fe2cba6d4b87848f97ad753a4e86bdaed5056","original_commit_id":"d98fe2cba6d4b87848f97ad753a4e86bdaed5056","user":{"login":"janvorli","id":10758568,"avatar_url":"https://avatars.githubusercontent.com/u/10758568?v=3","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"body":"The reason was the same as for the first case. I understand that it violates the coding conventions, so if you think that duplicating the term in #else branch is better I'll do it that way. ","created_at":"2015-03-31T00:19:08Z","updated_at":"2015-03-31T00:19:08Z","html_url":"https://github.com/dotnet/coreclr/pull/599#discussion_r27444316","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/599","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/27444316"},"html":{"href":"https://github.com/dotnet/coreclr/pull/599#discussion_r27444316"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/599"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/599","id":32261112,"html_url":"https://github.com/dotnet/coreclr/pull/599","diff_url":"https://github.com/dotnet/coreclr/pull/599.diff","patch_url":"https://github.com/dotnet/coreclr/pull/599.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/599","number":599,"state":"open","locked":false,"title":"Fix next round of warning types","user":{"login":"janvorli","id":10758568,"avatar_url":"https://avatars.githubusercontent.com/u/10758568?v=3","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"body":"This change fixes the following warnings:\r\n1) Assignment in a condition should be wrapped in ()\r\n2) Priority of && / || should be indicated by parentheses. It has uncovered 3 real bugs.\r\n3) Unknown #pragma optimize ifdefed out for non MSVC\r\n4) Unused functions deleted or put under #ifdef\r\n5) Extra tokens warning disabling moved to the CMakeLists.txt in the src/inc\r\n6) Self assignment of a member or local variable\r\n7) Assigning ~0 to a bitfield member that was just 8 bit wide\r\n\r\nIt also fixes a bug in the STRESS_LOGxx macro invocation in exceptionhandling.cpp and\r\nstackwalk.cpp related to recent adding the DBG_ADDR macro usage. This macro expanded\r\na single parameter into two expressions to extract high / low 32 bits separately.\r\nBut the STRESS_LOGxx parameters are passed to the StressLog::LogMsg method as follows:\r\n(void*)(size_t)(data1)\r\nThat means that the expanded pair x, y would be inserted as data 1 and that leads\r\nto ignoring the x due to the comma operator.","created_at":"2015-03-30T19:56:20Z","updated_at":"2015-03-31T00:19:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cb898cf29319e9a0dbd21af5071b401c0944fee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/599/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/599/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/599/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/d98fe2cba6d4b87848f97ad753a4e86bdaed5056","head":{"label":"janvorli:warnings-cleanup-2a","ref":"warnings-cleanup-2a","sha":"d98fe2cba6d4b87848f97ad753a4e86bdaed5056","user":{"login":"janvorli","id":10758568,"avatar_url":"https://avatars.githubusercontent.com/u/10758568?v=3","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"repo":{"id":30583176,"name":"coreclr","full_name":"janvorli/coreclr","owner":{"login":"janvorli","id":10758568,"avatar_url":"https://avatars.githubusercontent.com/u/10758568?v=3","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janvorli/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/janvorli/coreclr","forks_url":"https://api.github.com/repos/janvorli/coreclr/forks","keys_url":"https://api.github.com/repos/janvorli/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janvorli/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janvorli/coreclr/teams","hooks_url":"https://api.github.com/repos/janvorli/coreclr/hooks","issue_events_url":"https://api.github.com/repos/janvorli/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/janvorli/coreclr/events","assignees_url":"https://api.github.com/repos/janvorli/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/janvorli/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/janvorli/coreclr/tags","blobs_url":"https://api.github.com/repos/janvorli/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janvorli/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janvorli/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/janvorli/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janvorli/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/janvorli/coreclr/languages","stargazers_url":"https://api.github.com/repos/janvorli/coreclr/stargazers","contributors_url":"https://api.github.com/repos/janvorli/coreclr/contributors","subscribers_url":"https://api.github.com/repos/janvorli/coreclr/subscribers","subscription_url":"https://api.github.com/repos/janvorli/coreclr/subscription","commits_url":"https://api.github.com/repos/janvorli/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/janvorli/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/janvorli/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/janvorli/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/janvorli/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/janvorli/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janvorli/coreclr/merges","archive_url":"https://api.github.com/repos/janvorli/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janvorli/coreclr/downloads","issues_url":"https://api.github.com/repos/janvorli/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/janvorli/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/janvorli/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/janvorli/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janvorli/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/janvorli/coreclr/releases{/id}","created_at":"2015-02-10T08:49:34Z","updated_at":"2015-02-10T08:49:57Z","pushed_at":"2015-03-30T19:38:23Z","git_url":"git://github.com/janvorli/coreclr.git","ssh_url":"git@github.com:janvorli/coreclr.git","clone_url":"https://github.com/janvorli/coreclr.git","svn_url":"https://github.com/janvorli/coreclr","homepage":"","size":28223,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"82440897d45e16d706e80dc96918d362339d0d95","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-03-30T23:37:23Z","pushed_at":"2015-03-30T19:56:20Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"","size":34781,"stargazers_count":4051,"watchers_count":4051,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":709,"mirror_url":null,"open_issues_count":82,"forks":709,"open_issues":82,"watchers":4051,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/599"},"html":{"href":"https://github.com/dotnet/coreclr/pull/599"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/599"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/599/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/599/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/599/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/d98fe2cba6d4b87848f97ad753a4e86bdaed5056"}}}}