{"action":"created","comment":{"url":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/comments/25155251","id":25155251,"diff_hunk":"@@ -1031,15 +1030,22 @@ can.Model(\"can.Model.Cacheable\", {\n     return RefreshQueue.refresh_all(this, props, true);\n   },\n   get_filter_vals: function(keys, mappings){\n-    typeof keys === 'undefined' && (keys = this.class.filter_keys);\n-    typeof mappings === 'undefined' && (mappings = this.class.filter_mappings);\n-    var values = {};\n-    $.map(keys, function(key){\n+    keys === undefined && (keys = this.class.filter_keys);\n+    mappings === undefined && (mappings = this.class.filter_mappings);\n+\n+    var values = {},\n+        long_title = this.type.toLowerCase() + \" title\";\n+\n+    mappings[long_title] || (mappings[long_title] = \"title\");","path":"src/ggrc/assets/javascripts/models/cacheable.js","position":22,"original_position":22,"commit_id":"3be71aa6a6637d4966f0946b342fe4d1285f19cd","original_commit_id":"3be71aa6a6637d4966f0946b342fe4d1285f19cd","user":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"body":"You are making my linter cry again.\r\n\r\n```\r\nif (mappings[long_title]) {\r\n  mappings[long_title] = \"title\"\r\n}\r\n```","created_at":"2015-02-23T10:48:36Z","updated_at":"2015-02-23T10:48:36Z","html_url":"https://github.com/reciprocity/ggrc-core/pull/2417#discussion_r25155251","pull_request_url":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/2417","_links":{"self":{"href":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/comments/25155251"},"html":{"href":"https://github.com/reciprocity/ggrc-core/pull/2417#discussion_r25155251"},"pull_request":{"href":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/2417"}}},"pull_request":{"url":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/2417","id":29693884,"html_url":"https://github.com/reciprocity/ggrc-core/pull/2417","diff_url":"https://github.com/reciprocity/ggrc-core/pull/2417.diff","patch_url":"https://github.com/reciprocity/ggrc-core/pull/2417.patch","issue_url":"https://api.github.com/repos/reciprocity/ggrc-core/issues/2417","number":2417,"state":"open","locked":false,"title":"fix date and title","user":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"body":"- filter by long title works\r\n- use momentjs to allow MM/DD/YYYY format\r\n- the filter keys are now case insensitive.","created_at":"2015-02-20T13:00:17Z","updated_at":"2015-02-23T10:48:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f3c723735c578c24369f0c7ccc12e6e74fe79d4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/2417/commits","review_comments_url":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/2417/comments","review_comment_url":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reciprocity/ggrc-core/issues/2417/comments","statuses_url":"https://api.github.com/repos/reciprocity/ggrc-core/statuses/3be71aa6a6637d4966f0946b342fe4d1285f19cd","head":{"label":"zidarsk8:feature/filter-date-fix","ref":"feature/filter-date-fix","sha":"3be71aa6a6637d4966f0946b342fe4d1285f19cd","user":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"repo":{"id":27515613,"name":"ggrc-core","full_name":"zidarsk8/ggrc-core","owner":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zidarsk8/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/zidarsk8/ggrc-core","forks_url":"https://api.github.com/repos/zidarsk8/ggrc-core/forks","keys_url":"https://api.github.com/repos/zidarsk8/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zidarsk8/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zidarsk8/ggrc-core/teams","hooks_url":"https://api.github.com/repos/zidarsk8/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/zidarsk8/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/zidarsk8/ggrc-core/events","assignees_url":"https://api.github.com/repos/zidarsk8/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/zidarsk8/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/zidarsk8/ggrc-core/tags","blobs_url":"https://api.github.com/repos/zidarsk8/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zidarsk8/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zidarsk8/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zidarsk8/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zidarsk8/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/zidarsk8/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/zidarsk8/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/zidarsk8/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/zidarsk8/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/zidarsk8/ggrc-core/subscription","commits_url":"https://api.github.com/repos/zidarsk8/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zidarsk8/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zidarsk8/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zidarsk8/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/zidarsk8/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/zidarsk8/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zidarsk8/ggrc-core/merges","archive_url":"https://api.github.com/repos/zidarsk8/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zidarsk8/ggrc-core/downloads","issues_url":"https://api.github.com/repos/zidarsk8/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/zidarsk8/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/zidarsk8/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/zidarsk8/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zidarsk8/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/zidarsk8/ggrc-core/releases{/id}","created_at":"2014-12-04T00:47:01Z","updated_at":"2015-02-22T12:17:03Z","pushed_at":"2015-02-22T21:04:56Z","git_url":"git://github.com/zidarsk8/ggrc-core.git","ssh_url":"git@github.com:zidarsk8/ggrc-core.git","clone_url":"https://github.com/zidarsk8/ggrc-core.git","svn_url":"https://github.com/zidarsk8/ggrc-core","homepage":null,"size":29896,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"reciprocity:develop","ref":"develop","sha":"201e63bb0511ef891af87ccc478b717b6f210d8b","user":{"login":"reciprocity","id":274649,"avatar_url":"https://avatars.githubusercontent.com/u/274649?v=3","gravatar_id":"","url":"https://api.github.com/users/reciprocity","html_url":"https://github.com/reciprocity","followers_url":"https://api.github.com/users/reciprocity/followers","following_url":"https://api.github.com/users/reciprocity/following{/other_user}","gists_url":"https://api.github.com/users/reciprocity/gists{/gist_id}","starred_url":"https://api.github.com/users/reciprocity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reciprocity/subscriptions","organizations_url":"https://api.github.com/users/reciprocity/orgs","repos_url":"https://api.github.com/users/reciprocity/repos","events_url":"https://api.github.com/users/reciprocity/events{/privacy}","received_events_url":"https://api.github.com/users/reciprocity/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"reciprocity/ggrc-core","owner":{"login":"reciprocity","id":274649,"avatar_url":"https://avatars.githubusercontent.com/u/274649?v=3","gravatar_id":"","url":"https://api.github.com/users/reciprocity","html_url":"https://github.com/reciprocity","followers_url":"https://api.github.com/users/reciprocity/followers","following_url":"https://api.github.com/users/reciprocity/following{/other_user}","gists_url":"https://api.github.com/users/reciprocity/gists{/gist_id}","starred_url":"https://api.github.com/users/reciprocity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reciprocity/subscriptions","organizations_url":"https://api.github.com/users/reciprocity/orgs","repos_url":"https://api.github.com/users/reciprocity/repos","events_url":"https://api.github.com/users/reciprocity/events{/privacy}","received_events_url":"https://api.github.com/users/reciprocity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reciprocity/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/reciprocity/ggrc-core","forks_url":"https://api.github.com/repos/reciprocity/ggrc-core/forks","keys_url":"https://api.github.com/repos/reciprocity/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reciprocity/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reciprocity/ggrc-core/teams","hooks_url":"https://api.github.com/repos/reciprocity/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/reciprocity/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/reciprocity/ggrc-core/events","assignees_url":"https://api.github.com/repos/reciprocity/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/reciprocity/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/reciprocity/ggrc-core/tags","blobs_url":"https://api.github.com/repos/reciprocity/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reciprocity/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reciprocity/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/reciprocity/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reciprocity/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/reciprocity/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/reciprocity/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/reciprocity/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/reciprocity/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/reciprocity/ggrc-core/subscription","commits_url":"https://api.github.com/repos/reciprocity/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/reciprocity/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/reciprocity/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/reciprocity/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/reciprocity/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/reciprocity/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reciprocity/ggrc-core/merges","archive_url":"https://api.github.com/repos/reciprocity/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reciprocity/ggrc-core/downloads","issues_url":"https://api.github.com/repos/reciprocity/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/reciprocity/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/reciprocity/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/reciprocity/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reciprocity/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/reciprocity/ggrc-core/releases{/id}","created_at":"2013-04-08T19:16:28Z","updated_at":"2015-02-22T12:49:30Z","pushed_at":"2015-02-22T12:49:29Z","git_url":"git://github.com/reciprocity/ggrc-core.git","ssh_url":"git@github.com:reciprocity/ggrc-core.git","clone_url":"https://github.com/reciprocity/ggrc-core.git","svn_url":"https://github.com/reciprocity/ggrc-core","homepage":null,"size":57311,"stargazers_count":17,"watchers_count":17,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":7,"forks":11,"open_issues":7,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/2417"},"html":{"href":"https://github.com/reciprocity/ggrc-core/pull/2417"},"issue":{"href":"https://api.github.com/repos/reciprocity/ggrc-core/issues/2417"},"comments":{"href":"https://api.github.com/repos/reciprocity/ggrc-core/issues/2417/comments"},"review_comments":{"href":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/2417/comments"},"review_comment":{"href":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reciprocity/ggrc-core/pulls/2417/commits"},"statuses":{"href":"https://api.github.com/repos/reciprocity/ggrc-core/statuses/3be71aa6a6637d4966f0946b342fe4d1285f19cd"}}}}