{"action":"created","issue":{"url":"https://api.github.com/repos/empirical-org/Quill-Grammar/issues/30","labels_url":"https://api.github.com/repos/empirical-org/Quill-Grammar/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/empirical-org/Quill-Grammar/issues/30/comments","events_url":"https://api.github.com/repos/empirical-org/Quill-Grammar/issues/30/events","html_url":"https://github.com/empirical-org/Quill-Grammar/issues/30","id":63360797,"number":30,"title":"brainpop comments","user":{"login":"ccowdery","id":6025451,"avatar_url":"https://avatars.githubusercontent.com/u/6025451?v=3","gravatar_id":"","url":"https://api.github.com/users/ccowdery","html_url":"https://github.com/ccowdery","followers_url":"https://api.github.com/users/ccowdery/followers","following_url":"https://api.github.com/users/ccowdery/following{/other_user}","gists_url":"https://api.github.com/users/ccowdery/gists{/gist_id}","starred_url":"https://api.github.com/users/ccowdery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccowdery/subscriptions","organizations_url":"https://api.github.com/users/ccowdery/orgs","repos_url":"https://api.github.com/users/ccowdery/repos","events_url":"https://api.github.com/users/ccowdery/events{/privacy}","received_events_url":"https://api.github.com/users/ccowdery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-21T04:36:57Z","updated_at":"2015-03-26T21:58:30Z","closed_at":null,"body":"Bug # 1\r\nIn the princess and the turtle story, there are no parentheses in the text encapsulating the errors, and yet the directions still state that the students should remember to delete them before pressing submit.\r\n\r\nNote: Since we are electing to pivot towards the type 1 word model, rather than the whole sentence model, having an auto select feature that would select the whole word when its clicked on, including the parentheses errors, so that its 1 click to select the error, then type the correct word, then click to blank space to finish the change.\r\n\r\nThere is also a possibility that we would want to put in a \"revert to native text\" function on the stories, so that in case students are working on a passage and they get over their heads, they can press the revert button to set the whole passage back to its starting text without any of their additions.\r\n\r\nBUG # 2\r\nWhen I finished the story, it gave an incorrect text saying I found 5 of 1 errors, it always incorrectly lists amount of errors found.\r\n\r\n![bug 1](https://cloud.githubusercontent.com/assets/6025451/6763704/8f876d5c-cf5f-11e4-9fb9-2632e670d177.png)\r\n\r\nNOTE:  I find pages that the dialog box moves around on to be somewhat disctracting, so an idea would be to make the error box on the app stay stationary, while the page moves around it so the student doesn't have to move the mouse to click the next button again, not an urgent change.\r\n\r\nBUG # 3\r\nThe grammatical concepts listed on the errors on the errors found all say Grammar Concept TODO\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6025451/6763721/08b565a8-cf60-11e4-9c7f-490b4b899b14.png)\r\n\r\nNOTE: I think that the \"check work\" button should disappear after you click it once and it takes you through the errors. Having it there at the bottom, once the student is reviewing their work on the story, can only confuse the student. Once the review phase of the story has started, the button need to disappear or  be renamed.\r\n\r\nBUG # 4\r\nCustom results page does not load at all, just gives the text \"Custom Results Page\"\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6025451/6763737/7b54851c-cf60-11e4-86f6-7b51f3e92a43.png)\r\n\r\nNOTE: there might be a button that takes you back to back to the home page at BrainPop showing the Quill landing page, but if the results page does not load, then there is no way to get back. \r\n\r\nNOTE # 2: Quill does not show up if the word is searched on the brainpop search bar right above our page. We need to get that fixed asap, really urgent.\r\n\r\nBUG # 5\r\nThe correct answer to sentence questions after the paragrpaph has been completed do not appear.\r\nIt reads instead, \"Incorrect Answer: correct answer here\"\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6025451/6763748/11904278-cf61-11e4-9574-3ab8933c53c5.png)\r\n\r\nBUG # 6\r\nSome of the spacing of errors is incorrect, where there are too many spaces before the slash (choice 1 / choice 2) is correct, but we have an extra space before the (near / on) error, as well as some other errors, in the Apollo 8 story.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6025451/6763769/48631cc0-cf62-11e4-83d0-8db0d10b236d.png)\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/empirical-org/Quill-Grammar/issues/comments/86732441","html_url":"https://github.com/empirical-org/Quill-Grammar/issues/30#issuecomment-86732441","issue_url":"https://api.github.com/repos/empirical-org/Quill-Grammar/issues/30","id":86732441,"user":{"login":"RyanNovas","id":6655439,"avatar_url":"https://avatars.githubusercontent.com/u/6655439?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanNovas","html_url":"https://github.com/RyanNovas","followers_url":"https://api.github.com/users/RyanNovas/followers","following_url":"https://api.github.com/users/RyanNovas/following{/other_user}","gists_url":"https://api.github.com/users/RyanNovas/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanNovas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanNovas/subscriptions","organizations_url":"https://api.github.com/users/RyanNovas/orgs","repos_url":"https://api.github.com/users/RyanNovas/repos","events_url":"https://api.github.com/users/RyanNovas/events{/privacy}","received_events_url":"https://api.github.com/users/RyanNovas/received_events","type":"User","site_admin":false},"created_at":"2015-03-26T21:58:30Z","updated_at":"2015-03-26T21:58:30Z","body":"*Proofreading*\r\n\r\n- [ ] \"View Results\" button does not work after getting every error\r\n\r\n- [ ] \"View Results\" page is only showing one concept for \"Princes and Turtle\" (but this may be an problem with how we mapped out the concepts rather than the app)\r\n\r\n- [ ] If no text is selected, backspace brings user to previous screen. The paragraph breaks are large, so this becomes problematic. We should either autoselect text, or turn these paragraph breaks into textual areas.\r\n\r\n- [ ] Edits that are made without hitting \"check results\" do not persist.\r\n\r\n- [ ] It says \"you must find at least 50% of errors\" However, finding them isn't enough -- they need to be solved. Let's change \"find\" to \"solve\" or just make it be \"you must make x edits\". \r\n\r\n- [ ] Instead of \"Words Changed\" in the counter, I think it should just say \"Edits Made\" this is for two reasons. 1) Edit is the correct terminology in proofreading. 2) Not all edits will be to words, some may be changing punctuation, etc..\r\n\r\n- [ ] Similar to the above item, in the review view, it should be \"Correct Edit\" rather than \"Correct Word\"\r\n\r\n- [ ] If an entire word is deleted, it does not count on the counter.\r\n\r\n- [ ] The review counter counts all edits. While it makes sense for the primary one to do so, I think that the review one should only count edits to inserted errors (i.e. max out at X of X errors).\r\n![screen shot 2015-03-26 at 5 52 58 pm](https://cloud.githubusercontent.com/assets/6655439/6857976/15673e54-d3e1-11e4-9b30-4a94f90a8874.png)\r\n\r\n\r\n\r\n*Sentence Writing*\r\n- [ ] If I click \"Check Work\" with nothing entered, nothing happens. There should be a notification that says something like \"You must enter a sentence for us to check.\"\r\n\r\n- [ ] In the sentence writing section, the sentence can be cut and pasted. We got rid of this functionality in the original app.\r\n\r\n- [ ] After two wrong answers, it says \"Next Activity\" It should says \"Next Problem\" or \"Next Challenge\" or something else. The activity is the whole experience.\r\n\r\n\r\n*Results Page*\r\n- [ ] We should indicate the typing errors on the results page. Right now, we point out that students have made them, but there is no follow up.\r\n\r\n- [ ] On the results page, the grammar concepts are broken up for passage proofreading, but not sentence writing. Not sure if that was the plan, but I think it should be in both.\r\n\r\n- [ ] \"How do we grade?\" on top of the results page does not link anywhere"}}