{"action":"created","comment":{"url":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/comments/32589588","id":32589588,"diff_hunk":"@@ -842,7 +842,7 @@ def serialize_rule(rule):\n         if rule.interval != 1:\n             values.append((u'INTERVAL', [str(int(rule.interval))]))\n         if rule.wkst:\n-            values.append((u'WKST', [Rule.weekdays[rule.wkst]]))\n+            values.append((u'WKST', [Rule.weekdays[rule.wkst.weekday]]))","path":"recurrence/base.py","position":5,"original_position":5,"commit_id":"90de6ea629f9c14faf5d6d6a62a0e3872cc65681","original_commit_id":"90de6ea629f9c14faf5d6d6a62a0e3872cc65681","user":{"login":"bradmontgomery","id":103113,"avatar_url":"https://avatars.githubusercontent.com/u/103113?v=3","gravatar_id":"","url":"https://api.github.com/users/bradmontgomery","html_url":"https://github.com/bradmontgomery","followers_url":"https://api.github.com/users/bradmontgomery/followers","following_url":"https://api.github.com/users/bradmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/bradmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/bradmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradmontgomery/subscriptions","organizations_url":"https://api.github.com/users/bradmontgomery/orgs","repos_url":"https://api.github.com/users/bradmontgomery/repos","events_url":"https://api.github.com/users/bradmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/bradmontgomery/received_events","type":"User","site_admin":false},"body":"The failed tests are interesting. I'm running python 3.4 and Django 1.8, and here, `rule.wkst` is a `Weekday` instance, but in some of the test suites, this seems to be an int.\r\n\r\nAny ideas what I may be doing wrong?","created_at":"2015-06-17T01:46:39Z","updated_at":"2015-06-17T01:46:39Z","html_url":"https://github.com/django-recurrence/django-recurrence/pull/46#discussion_r32589588","pull_request_url":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/comments/32589588"},"html":{"href":"https://github.com/django-recurrence/django-recurrence/pull/46#discussion_r32589588"},"pull_request":{"href":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/46","id":37840472,"html_url":"https://github.com/django-recurrence/django-recurrence/pull/46","diff_url":"https://github.com/django-recurrence/django-recurrence/pull/46.diff","patch_url":"https://github.com/django-recurrence/django-recurrence/pull/46.patch","issue_url":"https://api.github.com/repos/django-recurrence/django-recurrence/issues/46","number":46,"state":"open","locked":false,"title":"Serializing Rule.wkst fails do to lookup via Weekday object instead of index value","user":{"login":"bradmontgomery","id":103113,"avatar_url":"https://avatars.githubusercontent.com/u/103113?v=3","gravatar_id":"","url":"https://api.github.com/users/bradmontgomery","html_url":"https://github.com/bradmontgomery","followers_url":"https://api.github.com/users/bradmontgomery/followers","following_url":"https://api.github.com/users/bradmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/bradmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/bradmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradmontgomery/subscriptions","organizations_url":"https://api.github.com/users/bradmontgomery/orgs","repos_url":"https://api.github.com/users/bradmontgomery/repos","events_url":"https://api.github.com/users/bradmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/bradmontgomery/received_events","type":"User","site_admin":false},"body":"If an rule included a `WKST`, serializing it would fail with the following exception, because the `Rule.wkst` attribute was used to look up the string representation instead of the weekday's index.\r\n\r\n    TypeError: tuple indices must be integers, not Weekday","created_at":"2015-06-16T20:56:08Z","updated_at":"2015-06-17T01:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5fac46b7350bbe6bcd8894b21b151de52cbd7e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/46/commits","review_comments_url":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/46/comments","review_comment_url":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django-recurrence/django-recurrence/issues/46/comments","statuses_url":"https://api.github.com/repos/django-recurrence/django-recurrence/statuses/90de6ea629f9c14faf5d6d6a62a0e3872cc65681","head":{"label":"bradmontgomery:master","ref":"master","sha":"90de6ea629f9c14faf5d6d6a62a0e3872cc65681","user":{"login":"bradmontgomery","id":103113,"avatar_url":"https://avatars.githubusercontent.com/u/103113?v=3","gravatar_id":"","url":"https://api.github.com/users/bradmontgomery","html_url":"https://github.com/bradmontgomery","followers_url":"https://api.github.com/users/bradmontgomery/followers","following_url":"https://api.github.com/users/bradmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/bradmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/bradmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradmontgomery/subscriptions","organizations_url":"https://api.github.com/users/bradmontgomery/orgs","repos_url":"https://api.github.com/users/bradmontgomery/repos","events_url":"https://api.github.com/users/bradmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/bradmontgomery/received_events","type":"User","site_admin":false},"repo":{"id":37554004,"name":"django-recurrence","full_name":"bradmontgomery/django-recurrence","owner":{"login":"bradmontgomery","id":103113,"avatar_url":"https://avatars.githubusercontent.com/u/103113?v=3","gravatar_id":"","url":"https://api.github.com/users/bradmontgomery","html_url":"https://github.com/bradmontgomery","followers_url":"https://api.github.com/users/bradmontgomery/followers","following_url":"https://api.github.com/users/bradmontgomery/following{/other_user}","gists_url":"https://api.github.com/users/bradmontgomery/gists{/gist_id}","starred_url":"https://api.github.com/users/bradmontgomery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradmontgomery/subscriptions","organizations_url":"https://api.github.com/users/bradmontgomery/orgs","repos_url":"https://api.github.com/users/bradmontgomery/repos","events_url":"https://api.github.com/users/bradmontgomery/events{/privacy}","received_events_url":"https://api.github.com/users/bradmontgomery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bradmontgomery/django-recurrence","description":"Utility for working with recurring dates in Django.","fork":true,"url":"https://api.github.com/repos/bradmontgomery/django-recurrence","forks_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/forks","keys_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/teams","hooks_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/hooks","issue_events_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/issues/events{/number}","events_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/events","assignees_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/assignees{/user}","branches_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/branches{/branch}","tags_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/tags","blobs_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/statuses/{sha}","languages_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/languages","stargazers_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/stargazers","contributors_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/contributors","subscribers_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/subscribers","subscription_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/subscription","commits_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/contents/{+path}","compare_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/merges","archive_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/downloads","issues_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/issues{/number}","pulls_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/pulls{/number}","milestones_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/milestones{/number}","notifications_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/labels{/name}","releases_url":"https://api.github.com/repos/bradmontgomery/django-recurrence/releases{/id}","created_at":"2015-06-16T20:23:23Z","updated_at":"2015-06-16T20:23:24Z","pushed_at":"2015-06-16T20:49:56Z","git_url":"git://github.com/bradmontgomery/django-recurrence.git","ssh_url":"git@github.com:bradmontgomery/django-recurrence.git","clone_url":"https://github.com/bradmontgomery/django-recurrence.git","svn_url":"https://github.com/bradmontgomery/django-recurrence","homepage":"https://django-recurrence.readthedocs.org/","size":781,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django-recurrence:master","ref":"master","sha":"fc18124a8b8b216028fabc950fe718099a13365b","user":{"login":"django-recurrence","id":2780100,"avatar_url":"https://avatars.githubusercontent.com/u/2780100?v=3","gravatar_id":"","url":"https://api.github.com/users/django-recurrence","html_url":"https://github.com/django-recurrence","followers_url":"https://api.github.com/users/django-recurrence/followers","following_url":"https://api.github.com/users/django-recurrence/following{/other_user}","gists_url":"https://api.github.com/users/django-recurrence/gists{/gist_id}","starred_url":"https://api.github.com/users/django-recurrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-recurrence/subscriptions","organizations_url":"https://api.github.com/users/django-recurrence/orgs","repos_url":"https://api.github.com/users/django-recurrence/repos","events_url":"https://api.github.com/users/django-recurrence/events{/privacy}","received_events_url":"https://api.github.com/users/django-recurrence/received_events","type":"Organization","site_admin":false},"repo":{"id":3498641,"name":"django-recurrence","full_name":"django-recurrence/django-recurrence","owner":{"login":"django-recurrence","id":2780100,"avatar_url":"https://avatars.githubusercontent.com/u/2780100?v=3","gravatar_id":"","url":"https://api.github.com/users/django-recurrence","html_url":"https://github.com/django-recurrence","followers_url":"https://api.github.com/users/django-recurrence/followers","following_url":"https://api.github.com/users/django-recurrence/following{/other_user}","gists_url":"https://api.github.com/users/django-recurrence/gists{/gist_id}","starred_url":"https://api.github.com/users/django-recurrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django-recurrence/subscriptions","organizations_url":"https://api.github.com/users/django-recurrence/orgs","repos_url":"https://api.github.com/users/django-recurrence/repos","events_url":"https://api.github.com/users/django-recurrence/events{/privacy}","received_events_url":"https://api.github.com/users/django-recurrence/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django-recurrence/django-recurrence","description":"Utility for working with recurring dates in Django.","fork":false,"url":"https://api.github.com/repos/django-recurrence/django-recurrence","forks_url":"https://api.github.com/repos/django-recurrence/django-recurrence/forks","keys_url":"https://api.github.com/repos/django-recurrence/django-recurrence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django-recurrence/django-recurrence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django-recurrence/django-recurrence/teams","hooks_url":"https://api.github.com/repos/django-recurrence/django-recurrence/hooks","issue_events_url":"https://api.github.com/repos/django-recurrence/django-recurrence/issues/events{/number}","events_url":"https://api.github.com/repos/django-recurrence/django-recurrence/events","assignees_url":"https://api.github.com/repos/django-recurrence/django-recurrence/assignees{/user}","branches_url":"https://api.github.com/repos/django-recurrence/django-recurrence/branches{/branch}","tags_url":"https://api.github.com/repos/django-recurrence/django-recurrence/tags","blobs_url":"https://api.github.com/repos/django-recurrence/django-recurrence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django-recurrence/django-recurrence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django-recurrence/django-recurrence/git/refs{/sha}","trees_url":"https://api.github.com/repos/django-recurrence/django-recurrence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django-recurrence/django-recurrence/statuses/{sha}","languages_url":"https://api.github.com/repos/django-recurrence/django-recurrence/languages","stargazers_url":"https://api.github.com/repos/django-recurrence/django-recurrence/stargazers","contributors_url":"https://api.github.com/repos/django-recurrence/django-recurrence/contributors","subscribers_url":"https://api.github.com/repos/django-recurrence/django-recurrence/subscribers","subscription_url":"https://api.github.com/repos/django-recurrence/django-recurrence/subscription","commits_url":"https://api.github.com/repos/django-recurrence/django-recurrence/commits{/sha}","git_commits_url":"https://api.github.com/repos/django-recurrence/django-recurrence/git/commits{/sha}","comments_url":"https://api.github.com/repos/django-recurrence/django-recurrence/comments{/number}","issue_comment_url":"https://api.github.com/repos/django-recurrence/django-recurrence/issues/comments{/number}","contents_url":"https://api.github.com/repos/django-recurrence/django-recurrence/contents/{+path}","compare_url":"https://api.github.com/repos/django-recurrence/django-recurrence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django-recurrence/django-recurrence/merges","archive_url":"https://api.github.com/repos/django-recurrence/django-recurrence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django-recurrence/django-recurrence/downloads","issues_url":"https://api.github.com/repos/django-recurrence/django-recurrence/issues{/number}","pulls_url":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls{/number}","milestones_url":"https://api.github.com/repos/django-recurrence/django-recurrence/milestones{/number}","notifications_url":"https://api.github.com/repos/django-recurrence/django-recurrence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django-recurrence/django-recurrence/labels{/name}","releases_url":"https://api.github.com/repos/django-recurrence/django-recurrence/releases{/id}","created_at":"2012-02-20T22:41:02Z","updated_at":"2015-06-06T01:56:05Z","pushed_at":"2015-06-16T20:56:08Z","git_url":"git://github.com/django-recurrence/django-recurrence.git","ssh_url":"git@github.com:django-recurrence/django-recurrence.git","clone_url":"https://github.com/django-recurrence/django-recurrence.git","svn_url":"https://github.com/django-recurrence/django-recurrence","homepage":"https://django-recurrence.readthedocs.org/","size":781,"stargazers_count":43,"watchers_count":43,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":15,"forks":33,"open_issues":15,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/46"},"html":{"href":"https://github.com/django-recurrence/django-recurrence/pull/46"},"issue":{"href":"https://api.github.com/repos/django-recurrence/django-recurrence/issues/46"},"comments":{"href":"https://api.github.com/repos/django-recurrence/django-recurrence/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django-recurrence/django-recurrence/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/django-recurrence/django-recurrence/statuses/90de6ea629f9c14faf5d6d6a62a0e3872cc65681"}}}}