{"action":"opened","number":1050,"pull_request":{"url":"https://api.github.com/repos/zeromq/czmq/pulls/1050","id":41012703,"html_url":"https://github.com/zeromq/czmq/pull/1050","diff_url":"https://github.com/zeromq/czmq/pull/1050.diff","patch_url":"https://github.com/zeromq/czmq/pull/1050.patch","issue_url":"https://api.github.com/repos/zeromq/czmq/issues/1050","number":1050,"state":"open","locked":false,"title":"Pass zsock_t instead of handle to zsock_resolve aware functions ","user":{"login":"bigusbangus","id":13528451,"avatar_url":"https://avatars.githubusercontent.com/u/13528451?v=3","gravatar_id":"","url":"https://api.github.com/users/bigusbangus","html_url":"https://github.com/bigusbangus","followers_url":"https://api.github.com/users/bigusbangus/followers","following_url":"https://api.github.com/users/bigusbangus/following{/other_user}","gists_url":"https://api.github.com/users/bigusbangus/gists{/gist_id}","starred_url":"https://api.github.com/users/bigusbangus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigusbangus/subscriptions","organizations_url":"https://api.github.com/users/bigusbangus/orgs","repos_url":"https://api.github.com/users/bigusbangus/repos","events_url":"https://api.github.com/users/bigusbangus/events{/privacy}","received_events_url":"https://api.github.com/users/bigusbangus/received_events","type":"User","site_admin":false},"body":"Ported my analysis code from czmq 2.2.0 to 3.0.2 and noticed a 50% slowdown with czmq 3.0.2.  Profiled the code on OSX and saw a huge overhead in getsockopt being called from sock_resolve from my calls to zmsg_send.  zsock_resolve was converting zsock_t* to a void* and then sub-functions were then calling zsock_resolve on the void*. This commit passes the original zsock_t to any function that then calls zsock_resolve so that getsockopt is almost never called.  This fixed my slowdown.","created_at":"2015-07-28T13:44:52Z","updated_at":"2015-07-28T13:44:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zeromq/czmq/pulls/1050/commits","review_comments_url":"https://api.github.com/repos/zeromq/czmq/pulls/1050/comments","review_comment_url":"https://api.github.com/repos/zeromq/czmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeromq/czmq/issues/1050/comments","statuses_url":"https://api.github.com/repos/zeromq/czmq/statuses/61421f5a3a42486e931927018fc9d0a06cb580c8","head":{"label":"bigusbangus:master","ref":"master","sha":"61421f5a3a42486e931927018fc9d0a06cb580c8","user":{"login":"bigusbangus","id":13528451,"avatar_url":"https://avatars.githubusercontent.com/u/13528451?v=3","gravatar_id":"","url":"https://api.github.com/users/bigusbangus","html_url":"https://github.com/bigusbangus","followers_url":"https://api.github.com/users/bigusbangus/followers","following_url":"https://api.github.com/users/bigusbangus/following{/other_user}","gists_url":"https://api.github.com/users/bigusbangus/gists{/gist_id}","starred_url":"https://api.github.com/users/bigusbangus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigusbangus/subscriptions","organizations_url":"https://api.github.com/users/bigusbangus/orgs","repos_url":"https://api.github.com/users/bigusbangus/repos","events_url":"https://api.github.com/users/bigusbangus/events{/privacy}","received_events_url":"https://api.github.com/users/bigusbangus/received_events","type":"User","site_admin":false},"repo":{"id":39834010,"name":"czmq","full_name":"bigusbangus/czmq","owner":{"login":"bigusbangus","id":13528451,"avatar_url":"https://avatars.githubusercontent.com/u/13528451?v=3","gravatar_id":"","url":"https://api.github.com/users/bigusbangus","html_url":"https://github.com/bigusbangus","followers_url":"https://api.github.com/users/bigusbangus/followers","following_url":"https://api.github.com/users/bigusbangus/following{/other_user}","gists_url":"https://api.github.com/users/bigusbangus/gists{/gist_id}","starred_url":"https://api.github.com/users/bigusbangus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigusbangus/subscriptions","organizations_url":"https://api.github.com/users/bigusbangus/orgs","repos_url":"https://api.github.com/users/bigusbangus/repos","events_url":"https://api.github.com/users/bigusbangus/events{/privacy}","received_events_url":"https://api.github.com/users/bigusbangus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bigusbangus/czmq","description":"High-level C binding for ØMQ","fork":true,"url":"https://api.github.com/repos/bigusbangus/czmq","forks_url":"https://api.github.com/repos/bigusbangus/czmq/forks","keys_url":"https://api.github.com/repos/bigusbangus/czmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigusbangus/czmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigusbangus/czmq/teams","hooks_url":"https://api.github.com/repos/bigusbangus/czmq/hooks","issue_events_url":"https://api.github.com/repos/bigusbangus/czmq/issues/events{/number}","events_url":"https://api.github.com/repos/bigusbangus/czmq/events","assignees_url":"https://api.github.com/repos/bigusbangus/czmq/assignees{/user}","branches_url":"https://api.github.com/repos/bigusbangus/czmq/branches{/branch}","tags_url":"https://api.github.com/repos/bigusbangus/czmq/tags","blobs_url":"https://api.github.com/repos/bigusbangus/czmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigusbangus/czmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigusbangus/czmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigusbangus/czmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigusbangus/czmq/statuses/{sha}","languages_url":"https://api.github.com/repos/bigusbangus/czmq/languages","stargazers_url":"https://api.github.com/repos/bigusbangus/czmq/stargazers","contributors_url":"https://api.github.com/repos/bigusbangus/czmq/contributors","subscribers_url":"https://api.github.com/repos/bigusbangus/czmq/subscribers","subscription_url":"https://api.github.com/repos/bigusbangus/czmq/subscription","commits_url":"https://api.github.com/repos/bigusbangus/czmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigusbangus/czmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigusbangus/czmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigusbangus/czmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigusbangus/czmq/contents/{+path}","compare_url":"https://api.github.com/repos/bigusbangus/czmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigusbangus/czmq/merges","archive_url":"https://api.github.com/repos/bigusbangus/czmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigusbangus/czmq/downloads","issues_url":"https://api.github.com/repos/bigusbangus/czmq/issues{/number}","pulls_url":"https://api.github.com/repos/bigusbangus/czmq/pulls{/number}","milestones_url":"https://api.github.com/repos/bigusbangus/czmq/milestones{/number}","notifications_url":"https://api.github.com/repos/bigusbangus/czmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigusbangus/czmq/labels{/name}","releases_url":"https://api.github.com/repos/bigusbangus/czmq/releases{/id}","created_at":"2015-07-28T12:58:39Z","updated_at":"2015-07-28T12:58:40Z","pushed_at":"2015-07-28T13:36:56Z","git_url":"git://github.com/bigusbangus/czmq.git","ssh_url":"git@github.com:bigusbangus/czmq.git","clone_url":"https://github.com/bigusbangus/czmq.git","svn_url":"https://github.com/bigusbangus/czmq","homepage":"czmq.zeromq.org","size":13630,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zeromq:master","ref":"master","sha":"491ab44a1ef54433d69ec9a9b8f597a942452ddc","user":{"login":"zeromq","id":109777,"avatar_url":"https://avatars.githubusercontent.com/u/109777?v=3","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"repo":{"id":1510809,"name":"czmq","full_name":"zeromq/czmq","owner":{"login":"zeromq","id":109777,"avatar_url":"https://avatars.githubusercontent.com/u/109777?v=3","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeromq/czmq","description":"High-level C binding for ØMQ","fork":false,"url":"https://api.github.com/repos/zeromq/czmq","forks_url":"https://api.github.com/repos/zeromq/czmq/forks","keys_url":"https://api.github.com/repos/zeromq/czmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeromq/czmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeromq/czmq/teams","hooks_url":"https://api.github.com/repos/zeromq/czmq/hooks","issue_events_url":"https://api.github.com/repos/zeromq/czmq/issues/events{/number}","events_url":"https://api.github.com/repos/zeromq/czmq/events","assignees_url":"https://api.github.com/repos/zeromq/czmq/assignees{/user}","branches_url":"https://api.github.com/repos/zeromq/czmq/branches{/branch}","tags_url":"https://api.github.com/repos/zeromq/czmq/tags","blobs_url":"https://api.github.com/repos/zeromq/czmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeromq/czmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeromq/czmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeromq/czmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeromq/czmq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeromq/czmq/languages","stargazers_url":"https://api.github.com/repos/zeromq/czmq/stargazers","contributors_url":"https://api.github.com/repos/zeromq/czmq/contributors","subscribers_url":"https://api.github.com/repos/zeromq/czmq/subscribers","subscription_url":"https://api.github.com/repos/zeromq/czmq/subscription","commits_url":"https://api.github.com/repos/zeromq/czmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeromq/czmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeromq/czmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeromq/czmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeromq/czmq/contents/{+path}","compare_url":"https://api.github.com/repos/zeromq/czmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeromq/czmq/merges","archive_url":"https://api.github.com/repos/zeromq/czmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeromq/czmq/downloads","issues_url":"https://api.github.com/repos/zeromq/czmq/issues{/number}","pulls_url":"https://api.github.com/repos/zeromq/czmq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeromq/czmq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeromq/czmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeromq/czmq/labels{/name}","releases_url":"https://api.github.com/repos/zeromq/czmq/releases{/id}","created_at":"2011-03-22T10:42:27Z","updated_at":"2015-07-27T16:26:50Z","pushed_at":"2015-07-28T01:29:13Z","git_url":"git://github.com/zeromq/czmq.git","ssh_url":"git@github.com:zeromq/czmq.git","clone_url":"https://github.com/zeromq/czmq.git","svn_url":"https://github.com/zeromq/czmq","homepage":"czmq.zeromq.org","size":13630,"stargazers_count":354,"watchers_count":354,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":26,"forks":223,"open_issues":26,"watchers":354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/1050"},"html":{"href":"https://github.com/zeromq/czmq/pull/1050"},"issue":{"href":"https://api.github.com/repos/zeromq/czmq/issues/1050"},"comments":{"href":"https://api.github.com/repos/zeromq/czmq/issues/1050/comments"},"review_comments":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/1050/comments"},"review_comment":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeromq/czmq/pulls/1050/commits"},"statuses":{"href":"https://api.github.com/repos/zeromq/czmq/statuses/61421f5a3a42486e931927018fc9d0a06cb580c8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":9,"deletions":13,"changed_files":4}}