{"action":"created","comment":{"url":"https://api.github.com/repos/mltsp/mltsp/pulls/comments/45896967","id":45896967,"diff_hunk":"@@ -227,8 +227,9 @@\n # Specify number of time series to featurize as part of a \"test run\"\n TEST_N = 5\n \n-# Specify default measurement error value (for measurements without errors)\n-ERROR_VALUE = 1e-4\n+# Specify default values for missing times/errors\n+DEFAULT_MAX_TIME = 1.0\n+DEFAULT_ERROR_VALUE = 1e-4","path":"mltsp/cfg.py","position":8,"original_position":8,"commit_id":"08403c2ea70e95f1174c757304791f4bb318e9c0","original_commit_id":"08403c2ea70e95f1174c757304791f4bb318e9c0","user":{"login":"bnaul","id":903655,"avatar_url":"https://avatars.githubusercontent.com/u/903655?v=3","gravatar_id":"","url":"https://api.github.com/users/bnaul","html_url":"https://github.com/bnaul","followers_url":"https://api.github.com/users/bnaul/followers","following_url":"https://api.github.com/users/bnaul/following{/other_user}","gists_url":"https://api.github.com/users/bnaul/gists{/gist_id}","starred_url":"https://api.github.com/users/bnaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnaul/subscriptions","organizations_url":"https://api.github.com/users/bnaul/orgs","repos_url":"https://api.github.com/users/bnaul/repos","events_url":"https://api.github.com/users/bnaul/events{/privacy}","received_events_url":"https://api.github.com/users/bnaul/received_events","type":"User","site_admin":false},"body":"I would like for it to, but currently a lot of the old TCP features will break if errors aren't passed in, or if they're taken to be zero. Even worse, we'd actually get different feature values if we changed this to 1e-1 or 1e-10; I'm just choosing 1e-4 to stay consistent with the old code.","created_at":"2015-11-25T17:41:41Z","updated_at":"2015-11-25T17:41:41Z","html_url":"https://github.com/mltsp/mltsp/pull/108#discussion_r45896967","pull_request_url":"https://api.github.com/repos/mltsp/mltsp/pulls/108","_links":{"self":{"href":"https://api.github.com/repos/mltsp/mltsp/pulls/comments/45896967"},"html":{"href":"https://github.com/mltsp/mltsp/pull/108#discussion_r45896967"},"pull_request":{"href":"https://api.github.com/repos/mltsp/mltsp/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/mltsp/mltsp/pulls/108","id":51293935,"html_url":"https://github.com/mltsp/mltsp/pull/108","diff_url":"https://github.com/mltsp/mltsp/pull/108.diff","patch_url":"https://github.com/mltsp/mltsp/pull/108.patch","issue_url":"https://api.github.com/repos/mltsp/mltsp/issues/108","number":108,"state":"closed","locked":false,"title":"Featurization API tweaks","user":{"login":"bnaul","id":903655,"avatar_url":"https://avatars.githubusercontent.com/u/903655?v=3","gravatar_id":"","url":"https://api.github.com/users/bnaul","html_url":"https://github.com/bnaul","followers_url":"https://api.github.com/users/bnaul/followers","following_url":"https://api.github.com/users/bnaul/following{/other_user}","gists_url":"https://api.github.com/users/bnaul/gists{/gist_id}","starred_url":"https://api.github.com/users/bnaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnaul/subscriptions","organizations_url":"https://api.github.com/users/bnaul/orgs","repos_url":"https://api.github.com/users/bnaul/repos","events_url":"https://api.github.com/users/bnaul/events{/privacy}","received_events_url":"https://api.github.com/users/bnaul/received_events","type":"User","site_admin":false},"body":"- Allow unequal-length multichannel data (passed in as lists of lists of 1d arrays), e.g. in the case of wavelet-transformed data\r\n- Add support for directly passing custom features as a dict `{'some_feature': f}` where `f(t,m,e)` is a featurization function, or as a dask graph `{'some_feature': (f, 't', 'm', 'e')}`.\r\n- Use default values for times/errors when omitted from `featurize_time_series`","created_at":"2015-11-19T22:53:54Z","updated_at":"2015-11-25T17:41:41Z","closed_at":"2015-11-25T02:18:20Z","merged_at":"2015-11-25T02:18:20Z","merge_commit_sha":"2f26a1d804e90c99a5fa770e93e202889d9653ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mltsp/mltsp/pulls/108/commits","review_comments_url":"https://api.github.com/repos/mltsp/mltsp/pulls/108/comments","review_comment_url":"https://api.github.com/repos/mltsp/mltsp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mltsp/mltsp/issues/108/comments","statuses_url":"https://api.github.com/repos/mltsp/mltsp/statuses/08403c2ea70e95f1174c757304791f4bb318e9c0","head":{"label":"bnaul:bnaul-eeg_example","ref":"bnaul-eeg_example","sha":"08403c2ea70e95f1174c757304791f4bb318e9c0","user":{"login":"bnaul","id":903655,"avatar_url":"https://avatars.githubusercontent.com/u/903655?v=3","gravatar_id":"","url":"https://api.github.com/users/bnaul","html_url":"https://github.com/bnaul","followers_url":"https://api.github.com/users/bnaul/followers","following_url":"https://api.github.com/users/bnaul/following{/other_user}","gists_url":"https://api.github.com/users/bnaul/gists{/gist_id}","starred_url":"https://api.github.com/users/bnaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnaul/subscriptions","organizations_url":"https://api.github.com/users/bnaul/orgs","repos_url":"https://api.github.com/users/bnaul/repos","events_url":"https://api.github.com/users/bnaul/events{/privacy}","received_events_url":"https://api.github.com/users/bnaul/received_events","type":"User","site_admin":false},"repo":{"id":41396103,"name":"mltsp","full_name":"bnaul/mltsp","owner":{"login":"bnaul","id":903655,"avatar_url":"https://avatars.githubusercontent.com/u/903655?v=3","gravatar_id":"","url":"https://api.github.com/users/bnaul","html_url":"https://github.com/bnaul","followers_url":"https://api.github.com/users/bnaul/followers","following_url":"https://api.github.com/users/bnaul/following{/other_user}","gists_url":"https://api.github.com/users/bnaul/gists{/gist_id}","starred_url":"https://api.github.com/users/bnaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnaul/subscriptions","organizations_url":"https://api.github.com/users/bnaul/orgs","repos_url":"https://api.github.com/users/bnaul/repos","events_url":"https://api.github.com/users/bnaul/events{/privacy}","received_events_url":"https://api.github.com/users/bnaul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bnaul/mltsp","description":"Machine Learning Time-Series Platform","fork":true,"url":"https://api.github.com/repos/bnaul/mltsp","forks_url":"https://api.github.com/repos/bnaul/mltsp/forks","keys_url":"https://api.github.com/repos/bnaul/mltsp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bnaul/mltsp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bnaul/mltsp/teams","hooks_url":"https://api.github.com/repos/bnaul/mltsp/hooks","issue_events_url":"https://api.github.com/repos/bnaul/mltsp/issues/events{/number}","events_url":"https://api.github.com/repos/bnaul/mltsp/events","assignees_url":"https://api.github.com/repos/bnaul/mltsp/assignees{/user}","branches_url":"https://api.github.com/repos/bnaul/mltsp/branches{/branch}","tags_url":"https://api.github.com/repos/bnaul/mltsp/tags","blobs_url":"https://api.github.com/repos/bnaul/mltsp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bnaul/mltsp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bnaul/mltsp/git/refs{/sha}","trees_url":"https://api.github.com/repos/bnaul/mltsp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bnaul/mltsp/statuses/{sha}","languages_url":"https://api.github.com/repos/bnaul/mltsp/languages","stargazers_url":"https://api.github.com/repos/bnaul/mltsp/stargazers","contributors_url":"https://api.github.com/repos/bnaul/mltsp/contributors","subscribers_url":"https://api.github.com/repos/bnaul/mltsp/subscribers","subscription_url":"https://api.github.com/repos/bnaul/mltsp/subscription","commits_url":"https://api.github.com/repos/bnaul/mltsp/commits{/sha}","git_commits_url":"https://api.github.com/repos/bnaul/mltsp/git/commits{/sha}","comments_url":"https://api.github.com/repos/bnaul/mltsp/comments{/number}","issue_comment_url":"https://api.github.com/repos/bnaul/mltsp/issues/comments{/number}","contents_url":"https://api.github.com/repos/bnaul/mltsp/contents/{+path}","compare_url":"https://api.github.com/repos/bnaul/mltsp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bnaul/mltsp/merges","archive_url":"https://api.github.com/repos/bnaul/mltsp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bnaul/mltsp/downloads","issues_url":"https://api.github.com/repos/bnaul/mltsp/issues{/number}","pulls_url":"https://api.github.com/repos/bnaul/mltsp/pulls{/number}","milestones_url":"https://api.github.com/repos/bnaul/mltsp/milestones{/number}","notifications_url":"https://api.github.com/repos/bnaul/mltsp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bnaul/mltsp/labels{/name}","releases_url":"https://api.github.com/repos/bnaul/mltsp/releases{/id}","created_at":"2015-08-26T00:59:56Z","updated_at":"2015-08-26T00:59:59Z","pushed_at":"2015-11-20T19:31:33Z","git_url":"git://github.com/bnaul/mltsp.git","ssh_url":"git@github.com:bnaul/mltsp.git","clone_url":"https://github.com/bnaul/mltsp.git","svn_url":"https://github.com/bnaul/mltsp","homepage":null,"size":21493,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mltsp:master","ref":"master","sha":"dc129b06c07c45f351a9d7b732dd5a17345054c2","user":{"login":"mltsp","id":9449578,"avatar_url":"https://avatars.githubusercontent.com/u/9449578?v=3","gravatar_id":"","url":"https://api.github.com/users/mltsp","html_url":"https://github.com/mltsp","followers_url":"https://api.github.com/users/mltsp/followers","following_url":"https://api.github.com/users/mltsp/following{/other_user}","gists_url":"https://api.github.com/users/mltsp/gists{/gist_id}","starred_url":"https://api.github.com/users/mltsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mltsp/subscriptions","organizations_url":"https://api.github.com/users/mltsp/orgs","repos_url":"https://api.github.com/users/mltsp/repos","events_url":"https://api.github.com/users/mltsp/events{/privacy}","received_events_url":"https://api.github.com/users/mltsp/received_events","type":"Organization","site_admin":false},"repo":{"id":25928850,"name":"mltsp","full_name":"mltsp/mltsp","owner":{"login":"mltsp","id":9449578,"avatar_url":"https://avatars.githubusercontent.com/u/9449578?v=3","gravatar_id":"","url":"https://api.github.com/users/mltsp","html_url":"https://github.com/mltsp","followers_url":"https://api.github.com/users/mltsp/followers","following_url":"https://api.github.com/users/mltsp/following{/other_user}","gists_url":"https://api.github.com/users/mltsp/gists{/gist_id}","starred_url":"https://api.github.com/users/mltsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mltsp/subscriptions","organizations_url":"https://api.github.com/users/mltsp/orgs","repos_url":"https://api.github.com/users/mltsp/repos","events_url":"https://api.github.com/users/mltsp/events{/privacy}","received_events_url":"https://api.github.com/users/mltsp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mltsp/mltsp","description":"Machine Learning Time-Series Platform","fork":false,"url":"https://api.github.com/repos/mltsp/mltsp","forks_url":"https://api.github.com/repos/mltsp/mltsp/forks","keys_url":"https://api.github.com/repos/mltsp/mltsp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mltsp/mltsp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mltsp/mltsp/teams","hooks_url":"https://api.github.com/repos/mltsp/mltsp/hooks","issue_events_url":"https://api.github.com/repos/mltsp/mltsp/issues/events{/number}","events_url":"https://api.github.com/repos/mltsp/mltsp/events","assignees_url":"https://api.github.com/repos/mltsp/mltsp/assignees{/user}","branches_url":"https://api.github.com/repos/mltsp/mltsp/branches{/branch}","tags_url":"https://api.github.com/repos/mltsp/mltsp/tags","blobs_url":"https://api.github.com/repos/mltsp/mltsp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mltsp/mltsp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mltsp/mltsp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mltsp/mltsp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mltsp/mltsp/statuses/{sha}","languages_url":"https://api.github.com/repos/mltsp/mltsp/languages","stargazers_url":"https://api.github.com/repos/mltsp/mltsp/stargazers","contributors_url":"https://api.github.com/repos/mltsp/mltsp/contributors","subscribers_url":"https://api.github.com/repos/mltsp/mltsp/subscribers","subscription_url":"https://api.github.com/repos/mltsp/mltsp/subscription","commits_url":"https://api.github.com/repos/mltsp/mltsp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mltsp/mltsp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mltsp/mltsp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mltsp/mltsp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mltsp/mltsp/contents/{+path}","compare_url":"https://api.github.com/repos/mltsp/mltsp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mltsp/mltsp/merges","archive_url":"https://api.github.com/repos/mltsp/mltsp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mltsp/mltsp/downloads","issues_url":"https://api.github.com/repos/mltsp/mltsp/issues{/number}","pulls_url":"https://api.github.com/repos/mltsp/mltsp/pulls{/number}","milestones_url":"https://api.github.com/repos/mltsp/mltsp/milestones{/number}","notifications_url":"https://api.github.com/repos/mltsp/mltsp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mltsp/mltsp/labels{/name}","releases_url":"https://api.github.com/repos/mltsp/mltsp/releases{/id}","created_at":"2014-10-29T16:00:02Z","updated_at":"2015-10-27T19:07:48Z","pushed_at":"2015-11-25T02:18:21Z","git_url":"git://github.com/mltsp/mltsp.git","ssh_url":"git@github.com:mltsp/mltsp.git","clone_url":"https://github.com/mltsp/mltsp.git","svn_url":"https://github.com/mltsp/mltsp","homepage":null,"size":21514,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":29,"forks":7,"open_issues":29,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mltsp/mltsp/pulls/108"},"html":{"href":"https://github.com/mltsp/mltsp/pull/108"},"issue":{"href":"https://api.github.com/repos/mltsp/mltsp/issues/108"},"comments":{"href":"https://api.github.com/repos/mltsp/mltsp/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/mltsp/mltsp/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/mltsp/mltsp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mltsp/mltsp/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/mltsp/mltsp/statuses/08403c2ea70e95f1174c757304791f4bb318e9c0"}}}}