{"action":"closed","number":8854,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/8854","id":52774595,"html_url":"https://github.com/servo/servo/pull/8854","diff_url":"https://github.com/servo/servo/pull/8854.diff","patch_url":"https://github.com/servo/servo/pull/8854.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/8854","number":8854,"state":"closed","locked":false,"title":"Treat 'undefined' passed to optional JS arguments as missing","user":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"body":"@frewsxcv please don't hurt me for this.\r\n\r\nI've added an AND condition to check whether the value being passed is undefined while checking whether the argument exists at all. Essentially, this is now treating undefined arguments the same as missing arguments.\r\n\r\nFixes #8813.\r\nFixes #6558.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/8854)\r\n<!-- Reviewable:end -->\r\n","created_at":"2015-12-06T07:07:31Z","updated_at":"2015-12-13T06:02:56Z","closed_at":"2015-12-13T06:02:56Z","merged_at":"2015-12-13T06:02:56Z","merge_commit_sha":"0f708a3b9af0b770d82e37477c8a79dcf4c55ab7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/8854/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/8854/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/8854/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/db92a8b0303c2955e8f569418ffdf748381a4b68","head":{"label":"KiChjang:undefined-as-missing","ref":"undefined-as-missing","sha":"db92a8b0303c2955e8f569418ffdf748381a4b68","user":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"repo":{"id":30110248,"name":"servo","full_name":"KiChjang/servo","owner":{"login":"KiChjang","id":3248587,"avatar_url":"https://avatars.githubusercontent.com/u/3248587?v=3","gravatar_id":"","url":"https://api.github.com/users/KiChjang","html_url":"https://github.com/KiChjang","followers_url":"https://api.github.com/users/KiChjang/followers","following_url":"https://api.github.com/users/KiChjang/following{/other_user}","gists_url":"https://api.github.com/users/KiChjang/gists{/gist_id}","starred_url":"https://api.github.com/users/KiChjang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KiChjang/subscriptions","organizations_url":"https://api.github.com/users/KiChjang/orgs","repos_url":"https://api.github.com/users/KiChjang/repos","events_url":"https://api.github.com/users/KiChjang/events{/privacy}","received_events_url":"https://api.github.com/users/KiChjang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KiChjang/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/KiChjang/servo","forks_url":"https://api.github.com/repos/KiChjang/servo/forks","keys_url":"https://api.github.com/repos/KiChjang/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KiChjang/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KiChjang/servo/teams","hooks_url":"https://api.github.com/repos/KiChjang/servo/hooks","issue_events_url":"https://api.github.com/repos/KiChjang/servo/issues/events{/number}","events_url":"https://api.github.com/repos/KiChjang/servo/events","assignees_url":"https://api.github.com/repos/KiChjang/servo/assignees{/user}","branches_url":"https://api.github.com/repos/KiChjang/servo/branches{/branch}","tags_url":"https://api.github.com/repos/KiChjang/servo/tags","blobs_url":"https://api.github.com/repos/KiChjang/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KiChjang/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KiChjang/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/KiChjang/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KiChjang/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/KiChjang/servo/languages","stargazers_url":"https://api.github.com/repos/KiChjang/servo/stargazers","contributors_url":"https://api.github.com/repos/KiChjang/servo/contributors","subscribers_url":"https://api.github.com/repos/KiChjang/servo/subscribers","subscription_url":"https://api.github.com/repos/KiChjang/servo/subscription","commits_url":"https://api.github.com/repos/KiChjang/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/KiChjang/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/KiChjang/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/KiChjang/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/KiChjang/servo/contents/{+path}","compare_url":"https://api.github.com/repos/KiChjang/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KiChjang/servo/merges","archive_url":"https://api.github.com/repos/KiChjang/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KiChjang/servo/downloads","issues_url":"https://api.github.com/repos/KiChjang/servo/issues{/number}","pulls_url":"https://api.github.com/repos/KiChjang/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/KiChjang/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/KiChjang/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KiChjang/servo/labels{/name}","releases_url":"https://api.github.com/repos/KiChjang/servo/releases{/id}","created_at":"2015-01-31T11:19:01Z","updated_at":"2015-09-28T19:38:32Z","pushed_at":"2015-12-13T05:27:04Z","git_url":"git://github.com/KiChjang/servo.git","ssh_url":"git@github.com:KiChjang/servo.git","clone_url":"https://github.com/KiChjang/servo.git","svn_url":"https://github.com/KiChjang/servo","homepage":"","size":161546,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"e493a0655e69c1472a53708d213fd102decc59cb","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-12-12T19:26:45Z","pushed_at":"2015-12-13T06:02:49Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"http://servo.org/","size":185159,"stargazers_count":5336,"watchers_count":5336,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":886,"mirror_url":null,"open_issues_count":1268,"forks":886,"open_issues":1268,"watchers":5336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/8854"},"html":{"href":"https://github.com/servo/servo/pull/8854"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/8854"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/8854/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/8854/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/8854/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/db92a8b0303c2955e8f569418ffdf748381a4b68"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"comments":50,"review_comments":6,"commits":1,"additions":8,"deletions":62,"changed_files":15}}