{"action":"created","issue":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/1722","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/1722/labels{/name}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/1722/comments","events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/1722/events","html_url":"https://github.com/checkstyle/checkstyle/pull/1722","id":101284437,"number":1722,"title":"solution to \"FinalLocalVariable doesn't report variable when first as…","user":{"login":"Bhavik3","id":8848873,"avatar_url":"https://avatars.githubusercontent.com/u/8848873?v=3","gravatar_id":"","url":"https://api.github.com/users/Bhavik3","html_url":"https://github.com/Bhavik3","followers_url":"https://api.github.com/users/Bhavik3/followers","following_url":"https://api.github.com/users/Bhavik3/following{/other_user}","gists_url":"https://api.github.com/users/Bhavik3/gists{/gist_id}","starred_url":"https://api.github.com/users/Bhavik3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bhavik3/subscriptions","organizations_url":"https://api.github.com/users/Bhavik3/orgs","repos_url":"https://api.github.com/users/Bhavik3/repos","events_url":"https://api.github.com/users/Bhavik3/events{/privacy}","received_events_url":"https://api.github.com/users/Bhavik3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-16T17:52:50Z","updated_at":"2015-08-31T19:46:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/1722","html_url":"https://github.com/checkstyle/checkstyle/pull/1722","diff_url":"https://github.com/checkstyle/checkstyle/pull/1722.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/1722.patch"},"body":"…signment is separated\" #1551"},"comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments/136479975","html_url":"https://github.com/checkstyle/checkstyle/pull/1722#issuecomment-136479975","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/1722","id":136479975,"user":{"login":"romani","id":812984,"avatar_url":"https://avatars.githubusercontent.com/u/812984?v=3","gravatar_id":"","url":"https://api.github.com/users/romani","html_url":"https://github.com/romani","followers_url":"https://api.github.com/users/romani/followers","following_url":"https://api.github.com/users/romani/following{/other_user}","gists_url":"https://api.github.com/users/romani/gists{/gist_id}","starred_url":"https://api.github.com/users/romani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romani/subscriptions","organizations_url":"https://api.github.com/users/romani/orgs","repos_url":"https://api.github.com/users/romani/repos","events_url":"https://api.github.com/users/romani/events{/privacy}","received_events_url":"https://api.github.com/users/romani/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T19:45:59Z","updated_at":"2015-08-31T19:45:59Z","body":"FinalLocalVariableCheck.java\r\n\r\n1) \r\n> An example of how to configure the check is:\r\n\r\nplease make it as \"An example of how to configure the check to validate variable definition is:\"\r\n\r\n2)\r\n> &lt;property name=\"token\" value=\"VARIABLE_DEF\"/&gt;\r\n\r\nmismatch of documentation and getRequiredTokens(). please update all examples (javadoc, xdoc).\r\n\r\n3)\r\n>\r\n```\r\n    private final Deque<Map<String, DetailAST>> scopeStack = new ArrayDeque<>();\r\n\r\n    private Deque<DetailAST> unInitializedVariable = new ArrayDeque<>();\r\n```\r\n\r\nplease create new class that will store all information about scope (Map<String, DetailAST> + Deque<DetailAST>). \r\n\r\n4) Please create UT that show that variables in different but nested scopes are named the same and one of them final another is not final and issue is reported to required variable.\r\n\r\n5)\r\nplease generate reports against project to see that new violations are correct , please do check all of them your self.\r\n\r\n6)\r\n> getDefaultToekns() , get AcceptableTokes()\r\n\r\npelase move TokenTypes.VARIABLE_DEF to the end of list to let future developer easily see a difference between collections,\r\n\r\n7)\r\n>private boolean defAndInitInDifferentLoop(DetailAST ast1, DetailAST ast2) \r\n\r\nWhy only Loops are checked there, that should be processing for any block structure that create extra scope (scope is \"{  }\")."}}