{"action":"created","comment":{"url":"https://api.github.com/repos/yeoman/generator-node/pulls/comments/34208397","id":34208397,"diff_hunk":"@@ -15,6 +15,11 @@ describe('node:cli', function () {\n     assert.fileContent('lib/cli.js', 'import meow from \\'meow\\'');\n   });\n \n+  it('Contains package name references', function() {\n+    assert.noFileContent('lib/cli.js', 'var = require(\\'./\\');');","path":"test/cli.js","position":5,"original_position":5,"commit_id":"1272ec70ae296335a46bf80a8ce0807790ef4fe7","original_commit_id":"1272ec70ae296335a46bf80a8ce0807790ef4fe7","user":{"login":"SBoudrias","id":923865,"avatar_url":"https://avatars.githubusercontent.com/u/923865?v=3","gravatar_id":"","url":"https://api.github.com/users/SBoudrias","html_url":"https://github.com/SBoudrias","followers_url":"https://api.github.com/users/SBoudrias/followers","following_url":"https://api.github.com/users/SBoudrias/following{/other_user}","gists_url":"https://api.github.com/users/SBoudrias/gists{/gist_id}","starred_url":"https://api.github.com/users/SBoudrias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SBoudrias/subscriptions","organizations_url":"https://api.github.com/users/SBoudrias/orgs","repos_url":"https://api.github.com/users/SBoudrias/repos","events_url":"https://api.github.com/users/SBoudrias/events{/privacy}","received_events_url":"https://api.github.com/users/SBoudrias/received_events","type":"User","site_admin":false},"body":"let's assert the correct behavior. Negative assertion are not useful to prove something is working correctly.\r\n\r\nAs you can see, here you have two assertions and both are passing. But one of them wouldn't fail even before your fix.\r\n\r\nThis mean you need to add two tests, one for the normal mode and one for the Babel mode.","created_at":"2015-07-08T22:58:34Z","updated_at":"2015-07-08T22:58:34Z","html_url":"https://github.com/yeoman/generator-node/pull/132#discussion_r34208397","pull_request_url":"https://api.github.com/repos/yeoman/generator-node/pulls/132","_links":{"self":{"href":"https://api.github.com/repos/yeoman/generator-node/pulls/comments/34208397"},"html":{"href":"https://github.com/yeoman/generator-node/pull/132#discussion_r34208397"},"pull_request":{"href":"https://api.github.com/repos/yeoman/generator-node/pulls/132"}}},"pull_request":{"url":"https://api.github.com/repos/yeoman/generator-node/pulls/132","id":39529956,"html_url":"https://github.com/yeoman/generator-node/pull/132","diff_url":"https://github.com/yeoman/generator-node/pull/132.diff","patch_url":"https://github.com/yeoman/generator-node/pull/132.patch","issue_url":"https://api.github.com/repos/yeoman/generator-node/issues/132","number":132,"state":"open","locked":false,"title":"Fixed missing package name in generated cli.js","user":{"login":"petersandor","id":3933866,"avatar_url":"https://avatars.githubusercontent.com/u/3933866?v=3","gravatar_id":"","url":"https://api.github.com/users/petersandor","html_url":"https://github.com/petersandor","followers_url":"https://api.github.com/users/petersandor/followers","following_url":"https://api.github.com/users/petersandor/following{/other_user}","gists_url":"https://api.github.com/users/petersandor/gists{/gist_id}","starred_url":"https://api.github.com/users/petersandor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petersandor/subscriptions","organizations_url":"https://api.github.com/users/petersandor/orgs","repos_url":"https://api.github.com/users/petersandor/repos","events_url":"https://api.github.com/users/petersandor/events{/privacy}","received_events_url":"https://api.github.com/users/petersandor/received_events","type":"User","site_admin":false},"body":"`this.options.name` was undefined since CLI generator doesn't have any `name` option specified.","created_at":"2015-07-08T22:18:58Z","updated_at":"2015-07-08T22:58:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16837b4e223884072e21090b459bd423253f3045","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yeoman/generator-node/pulls/132/commits","review_comments_url":"https://api.github.com/repos/yeoman/generator-node/pulls/132/comments","review_comment_url":"https://api.github.com/repos/yeoman/generator-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yeoman/generator-node/issues/132/comments","statuses_url":"https://api.github.com/repos/yeoman/generator-node/statuses/1272ec70ae296335a46bf80a8ce0807790ef4fe7","head":{"label":"petersandor:fix/generator-cli","ref":"fix/generator-cli","sha":"1272ec70ae296335a46bf80a8ce0807790ef4fe7","user":{"login":"petersandor","id":3933866,"avatar_url":"https://avatars.githubusercontent.com/u/3933866?v=3","gravatar_id":"","url":"https://api.github.com/users/petersandor","html_url":"https://github.com/petersandor","followers_url":"https://api.github.com/users/petersandor/followers","following_url":"https://api.github.com/users/petersandor/following{/other_user}","gists_url":"https://api.github.com/users/petersandor/gists{/gist_id}","starred_url":"https://api.github.com/users/petersandor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petersandor/subscriptions","organizations_url":"https://api.github.com/users/petersandor/orgs","repos_url":"https://api.github.com/users/petersandor/repos","events_url":"https://api.github.com/users/petersandor/events{/privacy}","received_events_url":"https://api.github.com/users/petersandor/received_events","type":"User","site_admin":false},"repo":{"id":38782501,"name":"generator-node","full_name":"petersandor/generator-node","owner":{"login":"petersandor","id":3933866,"avatar_url":"https://avatars.githubusercontent.com/u/3933866?v=3","gravatar_id":"","url":"https://api.github.com/users/petersandor","html_url":"https://github.com/petersandor","followers_url":"https://api.github.com/users/petersandor/followers","following_url":"https://api.github.com/users/petersandor/following{/other_user}","gists_url":"https://api.github.com/users/petersandor/gists{/gist_id}","starred_url":"https://api.github.com/users/petersandor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petersandor/subscriptions","organizations_url":"https://api.github.com/users/petersandor/orgs","repos_url":"https://api.github.com/users/petersandor/repos","events_url":"https://api.github.com/users/petersandor/events{/privacy}","received_events_url":"https://api.github.com/users/petersandor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petersandor/generator-node","description":"Create a Node.js module","fork":true,"url":"https://api.github.com/repos/petersandor/generator-node","forks_url":"https://api.github.com/repos/petersandor/generator-node/forks","keys_url":"https://api.github.com/repos/petersandor/generator-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petersandor/generator-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petersandor/generator-node/teams","hooks_url":"https://api.github.com/repos/petersandor/generator-node/hooks","issue_events_url":"https://api.github.com/repos/petersandor/generator-node/issues/events{/number}","events_url":"https://api.github.com/repos/petersandor/generator-node/events","assignees_url":"https://api.github.com/repos/petersandor/generator-node/assignees{/user}","branches_url":"https://api.github.com/repos/petersandor/generator-node/branches{/branch}","tags_url":"https://api.github.com/repos/petersandor/generator-node/tags","blobs_url":"https://api.github.com/repos/petersandor/generator-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petersandor/generator-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petersandor/generator-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/petersandor/generator-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petersandor/generator-node/statuses/{sha}","languages_url":"https://api.github.com/repos/petersandor/generator-node/languages","stargazers_url":"https://api.github.com/repos/petersandor/generator-node/stargazers","contributors_url":"https://api.github.com/repos/petersandor/generator-node/contributors","subscribers_url":"https://api.github.com/repos/petersandor/generator-node/subscribers","subscription_url":"https://api.github.com/repos/petersandor/generator-node/subscription","commits_url":"https://api.github.com/repos/petersandor/generator-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/petersandor/generator-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/petersandor/generator-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/petersandor/generator-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/petersandor/generator-node/contents/{+path}","compare_url":"https://api.github.com/repos/petersandor/generator-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petersandor/generator-node/merges","archive_url":"https://api.github.com/repos/petersandor/generator-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petersandor/generator-node/downloads","issues_url":"https://api.github.com/repos/petersandor/generator-node/issues{/number}","pulls_url":"https://api.github.com/repos/petersandor/generator-node/pulls{/number}","milestones_url":"https://api.github.com/repos/petersandor/generator-node/milestones{/number}","notifications_url":"https://api.github.com/repos/petersandor/generator-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petersandor/generator-node/labels{/name}","releases_url":"https://api.github.com/repos/petersandor/generator-node/releases{/id}","created_at":"2015-07-08T22:04:11Z","updated_at":"2015-07-08T22:04:12Z","pushed_at":"2015-07-08T22:53:38Z","git_url":"git://github.com/petersandor/generator-node.git","ssh_url":"git@github.com:petersandor/generator-node.git","clone_url":"https://github.com/petersandor/generator-node.git","svn_url":"https://github.com/petersandor/generator-node","homepage":"http://yeoman.io","size":1009,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yeoman:master","ref":"master","sha":"1fac8c2baae53f8655b0c1b923459718b5bd1327","user":{"login":"yeoman","id":1714870,"avatar_url":"https://avatars.githubusercontent.com/u/1714870?v=3","gravatar_id":"","url":"https://api.github.com/users/yeoman","html_url":"https://github.com/yeoman","followers_url":"https://api.github.com/users/yeoman/followers","following_url":"https://api.github.com/users/yeoman/following{/other_user}","gists_url":"https://api.github.com/users/yeoman/gists{/gist_id}","starred_url":"https://api.github.com/users/yeoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeoman/subscriptions","organizations_url":"https://api.github.com/users/yeoman/orgs","repos_url":"https://api.github.com/users/yeoman/repos","events_url":"https://api.github.com/users/yeoman/events{/privacy}","received_events_url":"https://api.github.com/users/yeoman/received_events","type":"Organization","site_admin":false},"repo":{"id":10081651,"name":"generator-node","full_name":"yeoman/generator-node","owner":{"login":"yeoman","id":1714870,"avatar_url":"https://avatars.githubusercontent.com/u/1714870?v=3","gravatar_id":"","url":"https://api.github.com/users/yeoman","html_url":"https://github.com/yeoman","followers_url":"https://api.github.com/users/yeoman/followers","following_url":"https://api.github.com/users/yeoman/following{/other_user}","gists_url":"https://api.github.com/users/yeoman/gists{/gist_id}","starred_url":"https://api.github.com/users/yeoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeoman/subscriptions","organizations_url":"https://api.github.com/users/yeoman/orgs","repos_url":"https://api.github.com/users/yeoman/repos","events_url":"https://api.github.com/users/yeoman/events{/privacy}","received_events_url":"https://api.github.com/users/yeoman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yeoman/generator-node","description":"Create a Node.js module","fork":false,"url":"https://api.github.com/repos/yeoman/generator-node","forks_url":"https://api.github.com/repos/yeoman/generator-node/forks","keys_url":"https://api.github.com/repos/yeoman/generator-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yeoman/generator-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yeoman/generator-node/teams","hooks_url":"https://api.github.com/repos/yeoman/generator-node/hooks","issue_events_url":"https://api.github.com/repos/yeoman/generator-node/issues/events{/number}","events_url":"https://api.github.com/repos/yeoman/generator-node/events","assignees_url":"https://api.github.com/repos/yeoman/generator-node/assignees{/user}","branches_url":"https://api.github.com/repos/yeoman/generator-node/branches{/branch}","tags_url":"https://api.github.com/repos/yeoman/generator-node/tags","blobs_url":"https://api.github.com/repos/yeoman/generator-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yeoman/generator-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yeoman/generator-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/yeoman/generator-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yeoman/generator-node/statuses/{sha}","languages_url":"https://api.github.com/repos/yeoman/generator-node/languages","stargazers_url":"https://api.github.com/repos/yeoman/generator-node/stargazers","contributors_url":"https://api.github.com/repos/yeoman/generator-node/contributors","subscribers_url":"https://api.github.com/repos/yeoman/generator-node/subscribers","subscription_url":"https://api.github.com/repos/yeoman/generator-node/subscription","commits_url":"https://api.github.com/repos/yeoman/generator-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/yeoman/generator-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/yeoman/generator-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/yeoman/generator-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/yeoman/generator-node/contents/{+path}","compare_url":"https://api.github.com/repos/yeoman/generator-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yeoman/generator-node/merges","archive_url":"https://api.github.com/repos/yeoman/generator-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yeoman/generator-node/downloads","issues_url":"https://api.github.com/repos/yeoman/generator-node/issues{/number}","pulls_url":"https://api.github.com/repos/yeoman/generator-node/pulls{/number}","milestones_url":"https://api.github.com/repos/yeoman/generator-node/milestones{/number}","notifications_url":"https://api.github.com/repos/yeoman/generator-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yeoman/generator-node/labels{/name}","releases_url":"https://api.github.com/repos/yeoman/generator-node/releases{/id}","created_at":"2013-05-15T15:15:10Z","updated_at":"2015-07-08T17:25:09Z","pushed_at":"2015-07-08T22:53:38Z","git_url":"git://github.com/yeoman/generator-node.git","ssh_url":"git@github.com:yeoman/generator-node.git","clone_url":"https://github.com/yeoman/generator-node.git","svn_url":"https://github.com/yeoman/generator-node","homepage":"http://yeoman.io","size":1009,"stargazers_count":172,"watchers_count":172,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":5,"forks":68,"open_issues":5,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yeoman/generator-node/pulls/132"},"html":{"href":"https://github.com/yeoman/generator-node/pull/132"},"issue":{"href":"https://api.github.com/repos/yeoman/generator-node/issues/132"},"comments":{"href":"https://api.github.com/repos/yeoman/generator-node/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/yeoman/generator-node/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/yeoman/generator-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yeoman/generator-node/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/yeoman/generator-node/statuses/1272ec70ae296335a46bf80a8ce0807790ef4fe7"}}}}