{"action":"created","comment":{"url":"https://api.github.com/repos/legoktm/jsonchecker/pulls/comments/47896718","id":47896718,"diff_hunk":"@@ -42,7 +42,8 @@ def check_directory(self, directory):\n         else:\n             files = [directory]\n         for fname in files:\n-            if fname.startswith('.'):\n+            first_directory = fname.split(os.path.sep)[0]","path":"jsonchecker/__init__.py","position":5,"original_position":5,"commit_id":"7a798891f93a0cc6e63a3a8fe8082aa75aaec60b","original_commit_id":"7a798891f93a0cc6e63a3a8fe8082aa75aaec60b","user":{"login":"jayvdb","id":15092,"avatar_url":"https://avatars.githubusercontent.com/u/15092?v=3","gravatar_id":"","url":"https://api.github.com/users/jayvdb","html_url":"https://github.com/jayvdb","followers_url":"https://api.github.com/users/jayvdb/followers","following_url":"https://api.github.com/users/jayvdb/following{/other_user}","gists_url":"https://api.github.com/users/jayvdb/gists{/gist_id}","starred_url":"https://api.github.com/users/jayvdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayvdb/subscriptions","organizations_url":"https://api.github.com/users/jayvdb/orgs","repos_url":"https://api.github.com/users/jayvdb/repos","events_url":"https://api.github.com/users/jayvdb/events{/privacy}","received_events_url":"https://api.github.com/users/jayvdb/received_events","type":"User","site_admin":false},"body":"this solution also skips files if they are requested like\r\n```\r\n$ jsonchecker ./good.json \r\n```\r\n\r\nI believe this is intended to prevent looking at dot-files , because `os.listdir` doesnt return entries for `.` or `..`, and dot-directories (like digging around in `.git` or `.hg` which will be a waste of effort)  Your current solution doesnt prevent that.","created_at":"2015-12-17T11:44:34Z","updated_at":"2015-12-17T11:44:34Z","html_url":"https://github.com/legoktm/jsonchecker/pull/9#discussion_r47896718","pull_request_url":"https://api.github.com/repos/legoktm/jsonchecker/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/legoktm/jsonchecker/pulls/comments/47896718"},"html":{"href":"https://github.com/legoktm/jsonchecker/pull/9#discussion_r47896718"},"pull_request":{"href":"https://api.github.com/repos/legoktm/jsonchecker/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/legoktm/jsonchecker/pulls/9","id":53961557,"html_url":"https://github.com/legoktm/jsonchecker/pull/9","diff_url":"https://github.com/legoktm/jsonchecker/pull/9.diff","patch_url":"https://github.com/legoktm/jsonchecker/pull/9.patch","issue_url":"https://api.github.com/repos/legoktm/jsonchecker/issues/9","number":9,"state":"open","locked":false,"title":"Don't misinterpret dirs in .. as .","user":{"login":"hugovk","id":1324225,"avatar_url":"https://avatars.githubusercontent.com/u/1324225?v=3","gravatar_id":"","url":"https://api.github.com/users/hugovk","html_url":"https://github.com/hugovk","followers_url":"https://api.github.com/users/hugovk/followers","following_url":"https://api.github.com/users/hugovk/following{/other_user}","gists_url":"https://api.github.com/users/hugovk/gists{/gist_id}","starred_url":"https://api.github.com/users/hugovk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugovk/subscriptions","organizations_url":"https://api.github.com/users/hugovk/orgs","repos_url":"https://api.github.com/users/hugovk/repos","events_url":"https://api.github.com/users/hugovk/events{/privacy}","received_events_url":"https://api.github.com/users/hugovk/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/legoktm/jsonchecker/issues/8.\r\n\r\nThe problem was it was misinterpreting directories like `..\\data\\subdir` as being under the current directory and skipping them, rather than further processing them.","created_at":"2015-12-17T10:55:56Z","updated_at":"2015-12-17T11:44:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"084bd93ff6396b86463fa93f337b765bcf32104f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/legoktm/jsonchecker/pulls/9/commits","review_comments_url":"https://api.github.com/repos/legoktm/jsonchecker/pulls/9/comments","review_comment_url":"https://api.github.com/repos/legoktm/jsonchecker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/legoktm/jsonchecker/issues/9/comments","statuses_url":"https://api.github.com/repos/legoktm/jsonchecker/statuses/7a798891f93a0cc6e63a3a8fe8082aa75aaec60b","head":{"label":"hugovk:current_dir_bug","ref":"current_dir_bug","sha":"7a798891f93a0cc6e63a3a8fe8082aa75aaec60b","user":{"login":"hugovk","id":1324225,"avatar_url":"https://avatars.githubusercontent.com/u/1324225?v=3","gravatar_id":"","url":"https://api.github.com/users/hugovk","html_url":"https://github.com/hugovk","followers_url":"https://api.github.com/users/hugovk/followers","following_url":"https://api.github.com/users/hugovk/following{/other_user}","gists_url":"https://api.github.com/users/hugovk/gists{/gist_id}","starred_url":"https://api.github.com/users/hugovk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugovk/subscriptions","organizations_url":"https://api.github.com/users/hugovk/orgs","repos_url":"https://api.github.com/users/hugovk/repos","events_url":"https://api.github.com/users/hugovk/events{/privacy}","received_events_url":"https://api.github.com/users/hugovk/received_events","type":"User","site_admin":false},"repo":{"id":48033816,"name":"jsonchecker","full_name":"hugovk/jsonchecker","owner":{"login":"hugovk","id":1324225,"avatar_url":"https://avatars.githubusercontent.com/u/1324225?v=3","gravatar_id":"","url":"https://api.github.com/users/hugovk","html_url":"https://github.com/hugovk","followers_url":"https://api.github.com/users/hugovk/followers","following_url":"https://api.github.com/users/hugovk/following{/other_user}","gists_url":"https://api.github.com/users/hugovk/gists{/gist_id}","starred_url":"https://api.github.com/users/hugovk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugovk/subscriptions","organizations_url":"https://api.github.com/users/hugovk/orgs","repos_url":"https://api.github.com/users/hugovk/repos","events_url":"https://api.github.com/users/hugovk/events{/privacy}","received_events_url":"https://api.github.com/users/hugovk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hugovk/jsonchecker","description":"A JSON linter","fork":true,"url":"https://api.github.com/repos/hugovk/jsonchecker","forks_url":"https://api.github.com/repos/hugovk/jsonchecker/forks","keys_url":"https://api.github.com/repos/hugovk/jsonchecker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hugovk/jsonchecker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hugovk/jsonchecker/teams","hooks_url":"https://api.github.com/repos/hugovk/jsonchecker/hooks","issue_events_url":"https://api.github.com/repos/hugovk/jsonchecker/issues/events{/number}","events_url":"https://api.github.com/repos/hugovk/jsonchecker/events","assignees_url":"https://api.github.com/repos/hugovk/jsonchecker/assignees{/user}","branches_url":"https://api.github.com/repos/hugovk/jsonchecker/branches{/branch}","tags_url":"https://api.github.com/repos/hugovk/jsonchecker/tags","blobs_url":"https://api.github.com/repos/hugovk/jsonchecker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hugovk/jsonchecker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hugovk/jsonchecker/git/refs{/sha}","trees_url":"https://api.github.com/repos/hugovk/jsonchecker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hugovk/jsonchecker/statuses/{sha}","languages_url":"https://api.github.com/repos/hugovk/jsonchecker/languages","stargazers_url":"https://api.github.com/repos/hugovk/jsonchecker/stargazers","contributors_url":"https://api.github.com/repos/hugovk/jsonchecker/contributors","subscribers_url":"https://api.github.com/repos/hugovk/jsonchecker/subscribers","subscription_url":"https://api.github.com/repos/hugovk/jsonchecker/subscription","commits_url":"https://api.github.com/repos/hugovk/jsonchecker/commits{/sha}","git_commits_url":"https://api.github.com/repos/hugovk/jsonchecker/git/commits{/sha}","comments_url":"https://api.github.com/repos/hugovk/jsonchecker/comments{/number}","issue_comment_url":"https://api.github.com/repos/hugovk/jsonchecker/issues/comments{/number}","contents_url":"https://api.github.com/repos/hugovk/jsonchecker/contents/{+path}","compare_url":"https://api.github.com/repos/hugovk/jsonchecker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hugovk/jsonchecker/merges","archive_url":"https://api.github.com/repos/hugovk/jsonchecker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hugovk/jsonchecker/downloads","issues_url":"https://api.github.com/repos/hugovk/jsonchecker/issues{/number}","pulls_url":"https://api.github.com/repos/hugovk/jsonchecker/pulls{/number}","milestones_url":"https://api.github.com/repos/hugovk/jsonchecker/milestones{/number}","notifications_url":"https://api.github.com/repos/hugovk/jsonchecker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hugovk/jsonchecker/labels{/name}","releases_url":"https://api.github.com/repos/hugovk/jsonchecker/releases{/id}","created_at":"2015-12-15T09:45:52Z","updated_at":"2015-12-15T09:45:53Z","pushed_at":"2015-12-17T10:53:12Z","git_url":"git://github.com/hugovk/jsonchecker.git","ssh_url":"git@github.com:hugovk/jsonchecker.git","clone_url":"https://github.com/hugovk/jsonchecker.git","svn_url":"https://github.com/hugovk/jsonchecker","homepage":"","size":27,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"legoktm:master","ref":"master","sha":"b0f0c14ec7bd7014c65fca9223e21c60525e8ac9","user":{"login":"legoktm","id":81392,"avatar_url":"https://avatars.githubusercontent.com/u/81392?v=3","gravatar_id":"","url":"https://api.github.com/users/legoktm","html_url":"https://github.com/legoktm","followers_url":"https://api.github.com/users/legoktm/followers","following_url":"https://api.github.com/users/legoktm/following{/other_user}","gists_url":"https://api.github.com/users/legoktm/gists{/gist_id}","starred_url":"https://api.github.com/users/legoktm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legoktm/subscriptions","organizations_url":"https://api.github.com/users/legoktm/orgs","repos_url":"https://api.github.com/users/legoktm/repos","events_url":"https://api.github.com/users/legoktm/events{/privacy}","received_events_url":"https://api.github.com/users/legoktm/received_events","type":"User","site_admin":false},"repo":{"id":25718644,"name":"jsonchecker","full_name":"legoktm/jsonchecker","owner":{"login":"legoktm","id":81392,"avatar_url":"https://avatars.githubusercontent.com/u/81392?v=3","gravatar_id":"","url":"https://api.github.com/users/legoktm","html_url":"https://github.com/legoktm","followers_url":"https://api.github.com/users/legoktm/followers","following_url":"https://api.github.com/users/legoktm/following{/other_user}","gists_url":"https://api.github.com/users/legoktm/gists{/gist_id}","starred_url":"https://api.github.com/users/legoktm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legoktm/subscriptions","organizations_url":"https://api.github.com/users/legoktm/orgs","repos_url":"https://api.github.com/users/legoktm/repos","events_url":"https://api.github.com/users/legoktm/events{/privacy}","received_events_url":"https://api.github.com/users/legoktm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/legoktm/jsonchecker","description":"A JSON linter","fork":false,"url":"https://api.github.com/repos/legoktm/jsonchecker","forks_url":"https://api.github.com/repos/legoktm/jsonchecker/forks","keys_url":"https://api.github.com/repos/legoktm/jsonchecker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legoktm/jsonchecker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legoktm/jsonchecker/teams","hooks_url":"https://api.github.com/repos/legoktm/jsonchecker/hooks","issue_events_url":"https://api.github.com/repos/legoktm/jsonchecker/issues/events{/number}","events_url":"https://api.github.com/repos/legoktm/jsonchecker/events","assignees_url":"https://api.github.com/repos/legoktm/jsonchecker/assignees{/user}","branches_url":"https://api.github.com/repos/legoktm/jsonchecker/branches{/branch}","tags_url":"https://api.github.com/repos/legoktm/jsonchecker/tags","blobs_url":"https://api.github.com/repos/legoktm/jsonchecker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legoktm/jsonchecker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legoktm/jsonchecker/git/refs{/sha}","trees_url":"https://api.github.com/repos/legoktm/jsonchecker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legoktm/jsonchecker/statuses/{sha}","languages_url":"https://api.github.com/repos/legoktm/jsonchecker/languages","stargazers_url":"https://api.github.com/repos/legoktm/jsonchecker/stargazers","contributors_url":"https://api.github.com/repos/legoktm/jsonchecker/contributors","subscribers_url":"https://api.github.com/repos/legoktm/jsonchecker/subscribers","subscription_url":"https://api.github.com/repos/legoktm/jsonchecker/subscription","commits_url":"https://api.github.com/repos/legoktm/jsonchecker/commits{/sha}","git_commits_url":"https://api.github.com/repos/legoktm/jsonchecker/git/commits{/sha}","comments_url":"https://api.github.com/repos/legoktm/jsonchecker/comments{/number}","issue_comment_url":"https://api.github.com/repos/legoktm/jsonchecker/issues/comments{/number}","contents_url":"https://api.github.com/repos/legoktm/jsonchecker/contents/{+path}","compare_url":"https://api.github.com/repos/legoktm/jsonchecker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legoktm/jsonchecker/merges","archive_url":"https://api.github.com/repos/legoktm/jsonchecker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legoktm/jsonchecker/downloads","issues_url":"https://api.github.com/repos/legoktm/jsonchecker/issues{/number}","pulls_url":"https://api.github.com/repos/legoktm/jsonchecker/pulls{/number}","milestones_url":"https://api.github.com/repos/legoktm/jsonchecker/milestones{/number}","notifications_url":"https://api.github.com/repos/legoktm/jsonchecker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legoktm/jsonchecker/labels{/name}","releases_url":"https://api.github.com/repos/legoktm/jsonchecker/releases{/id}","created_at":"2014-10-25T03:27:58Z","updated_at":"2015-02-11T00:26:46Z","pushed_at":"2015-12-17T10:55:56Z","git_url":"git://github.com/legoktm/jsonchecker.git","ssh_url":"git@github.com:legoktm/jsonchecker.git","clone_url":"https://github.com/legoktm/jsonchecker.git","svn_url":"https://github.com/legoktm/jsonchecker","homepage":"","size":23,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/legoktm/jsonchecker/pulls/9"},"html":{"href":"https://github.com/legoktm/jsonchecker/pull/9"},"issue":{"href":"https://api.github.com/repos/legoktm/jsonchecker/issues/9"},"comments":{"href":"https://api.github.com/repos/legoktm/jsonchecker/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/legoktm/jsonchecker/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/legoktm/jsonchecker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/legoktm/jsonchecker/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/legoktm/jsonchecker/statuses/7a798891f93a0cc6e63a3a8fe8082aa75aaec60b"}}}}