{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7078","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7078/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7078/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7078/events","html_url":"https://github.com/bitcoin/bitcoin/pull/7078","id":118307118,"number":7078,"title":"uint256::GetCheapHash bigendian compatibility","user":{"login":"arowser","id":541066,"avatar_url":"https://avatars.githubusercontent.com/u/541066?v=3","gravatar_id":"","url":"https://api.github.com/users/arowser","html_url":"https://github.com/arowser","followers_url":"https://api.github.com/users/arowser/followers","following_url":"https://api.github.com/users/arowser/following{/other_user}","gists_url":"https://api.github.com/users/arowser/gists{/gist_id}","starred_url":"https://api.github.com/users/arowser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arowser/subscriptions","organizations_url":"https://api.github.com/users/arowser/orgs","repos_url":"https://api.github.com/users/arowser/repos","events_url":"https://api.github.com/users/arowser/events{/privacy}","received_events_url":"https://api.github.com/users/arowser/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-11-23T02:10:45Z","updated_at":"2015-11-26T20:53:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7078","html_url":"https://github.com/bitcoin/bitcoin/pull/7078","diff_url":"https://github.com/bitcoin/bitcoin/pull/7078.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7078.patch"},"body":"Tested on PPC/MIPS :\r\nBefore change:\r\n```\r\ntest_bitcoin --run_test=addrman_tests\r\nRunning 5 test cases...\r\ntest/addrman_tests.cpp(141): error in \"addrman_new_collisions\": check addrman.size() == 3 failed\r\ntest/addrman_tests.cpp(145): error in \"addrman_new_collisions\": check addrman.size() == 4 failed\r\ntest/addrman_tests.cpp(166): error in \"addrman_tried_collisions\": check addrman.size() == i failed\r\ntest/addrman_tests.cpp(166): error in \"addrman_tried_collisions\": check addrman.size() == i failed\r\ntest/addrman_tests.cpp(166): error in \"addrman_tried_collisions\": check addrman.size() == i failed\r\n\r\n*** 5 failures detected in test suite \"Bitcoin Test Suite\"\r\n\r\n```\r\nAfter:\r\n```\r\ntest_bitcoin --run_test=addrman_tests\r\nRunning 5 test cases...\r\n\r\n*** No errors detected\r\n```"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/159993015","html_url":"https://github.com/bitcoin/bitcoin/pull/7078#issuecomment-159993015","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7078","id":159993015,"user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"created_at":"2015-11-26T20:53:39Z","updated_at":"2015-11-26T20:53:39Z","body":"I doubt the performance penalty of ReadLE64 is going to matter really on any system.\r\n\r\nI liked the idea of having an unportable fast function, though, but being able to rely on behaviour does make testing easier too.\r\n\r\nUnsure."}}