{"action":"closed","number":67,"pull_request":{"url":"https://api.github.com/repos/tobscure/json-api/pulls/67","id":50844445,"html_url":"https://github.com/tobscure/json-api/pull/67","diff_url":"https://github.com/tobscure/json-api/pull/67.diff","patch_url":"https://github.com/tobscure/json-api/pull/67.patch","issue_url":"https://api.github.com/repos/tobscure/json-api/issues/67","number":67,"state":"closed","locked":false,"title":"Unification the API + a little bit improvements with tests ","user":{"login":"pomek","id":2270764,"avatar_url":"https://avatars.githubusercontent.com/u/2270764?v=3","gravatar_id":"","url":"https://api.github.com/users/pomek","html_url":"https://github.com/pomek","followers_url":"https://api.github.com/users/pomek/followers","following_url":"https://api.github.com/users/pomek/following{/other_user}","gists_url":"https://api.github.com/users/pomek/gists{/gist_id}","starred_url":"https://api.github.com/users/pomek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomek/subscriptions","organizations_url":"https://api.github.com/users/pomek/orgs","repos_url":"https://api.github.com/users/pomek/repos","events_url":"https://api.github.com/users/pomek/events{/privacy}","received_events_url":"https://api.github.com/users/pomek/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nMy changes will break down the API compatibility. \r\n\r\nIn my opinion, classes which are necessary only for tests should be defined in dedicated (`stubs`) namespace. I've done it. All classes from test scenarios have been moved to `tests/stubs` directory.\r\n\r\nAnother change what I've done is change in the interface (API). In my opinion the method `SerializerInterface::getAttributes()` should be called with some `$model` and some `$fields`, but the `$fields` parameter should always be an array. The next one change is method `getType()` in the same Interface. I've removed unused parameter `$model`. \r\n\r\nAdditionally I've fixed phpDoc in some classes, nothing special :)\r\n\r\nI'm open on your opinion. If is anything what I could improvement, tell me.\r\n","created_at":"2015-11-16T18:06:30Z","updated_at":"2015-11-16T22:43:21Z","closed_at":"2015-11-16T22:43:21Z","merged_at":null,"merge_commit_sha":"a4f138ce5098fec8aad6928428ea6e4190663c76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tobscure/json-api/pulls/67/commits","review_comments_url":"https://api.github.com/repos/tobscure/json-api/pulls/67/comments","review_comment_url":"https://api.github.com/repos/tobscure/json-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tobscure/json-api/issues/67/comments","statuses_url":"https://api.github.com/repos/tobscure/json-api/statuses/12d8837aacb848bae5a192b5817c962e38f1d530","head":{"label":"pomek:master","ref":"master","sha":"12d8837aacb848bae5a192b5817c962e38f1d530","user":{"login":"pomek","id":2270764,"avatar_url":"https://avatars.githubusercontent.com/u/2270764?v=3","gravatar_id":"","url":"https://api.github.com/users/pomek","html_url":"https://github.com/pomek","followers_url":"https://api.github.com/users/pomek/followers","following_url":"https://api.github.com/users/pomek/following{/other_user}","gists_url":"https://api.github.com/users/pomek/gists{/gist_id}","starred_url":"https://api.github.com/users/pomek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomek/subscriptions","organizations_url":"https://api.github.com/users/pomek/orgs","repos_url":"https://api.github.com/users/pomek/repos","events_url":"https://api.github.com/users/pomek/events{/privacy}","received_events_url":"https://api.github.com/users/pomek/received_events","type":"User","site_admin":false},"repo":{"id":46289481,"name":"json-api","full_name":"pomek/json-api","owner":{"login":"pomek","id":2270764,"avatar_url":"https://avatars.githubusercontent.com/u/2270764?v=3","gravatar_id":"","url":"https://api.github.com/users/pomek","html_url":"https://github.com/pomek","followers_url":"https://api.github.com/users/pomek/followers","following_url":"https://api.github.com/users/pomek/following{/other_user}","gists_url":"https://api.github.com/users/pomek/gists{/gist_id}","starred_url":"https://api.github.com/users/pomek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomek/subscriptions","organizations_url":"https://api.github.com/users/pomek/orgs","repos_url":"https://api.github.com/users/pomek/repos","events_url":"https://api.github.com/users/pomek/events{/privacy}","received_events_url":"https://api.github.com/users/pomek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pomek/json-api","description":"JSON-API (http://jsonapi.org) responses in PHP.","fork":true,"url":"https://api.github.com/repos/pomek/json-api","forks_url":"https://api.github.com/repos/pomek/json-api/forks","keys_url":"https://api.github.com/repos/pomek/json-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pomek/json-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pomek/json-api/teams","hooks_url":"https://api.github.com/repos/pomek/json-api/hooks","issue_events_url":"https://api.github.com/repos/pomek/json-api/issues/events{/number}","events_url":"https://api.github.com/repos/pomek/json-api/events","assignees_url":"https://api.github.com/repos/pomek/json-api/assignees{/user}","branches_url":"https://api.github.com/repos/pomek/json-api/branches{/branch}","tags_url":"https://api.github.com/repos/pomek/json-api/tags","blobs_url":"https://api.github.com/repos/pomek/json-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pomek/json-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pomek/json-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/pomek/json-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pomek/json-api/statuses/{sha}","languages_url":"https://api.github.com/repos/pomek/json-api/languages","stargazers_url":"https://api.github.com/repos/pomek/json-api/stargazers","contributors_url":"https://api.github.com/repos/pomek/json-api/contributors","subscribers_url":"https://api.github.com/repos/pomek/json-api/subscribers","subscription_url":"https://api.github.com/repos/pomek/json-api/subscription","commits_url":"https://api.github.com/repos/pomek/json-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/pomek/json-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/pomek/json-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/pomek/json-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/pomek/json-api/contents/{+path}","compare_url":"https://api.github.com/repos/pomek/json-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pomek/json-api/merges","archive_url":"https://api.github.com/repos/pomek/json-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pomek/json-api/downloads","issues_url":"https://api.github.com/repos/pomek/json-api/issues{/number}","pulls_url":"https://api.github.com/repos/pomek/json-api/pulls{/number}","milestones_url":"https://api.github.com/repos/pomek/json-api/milestones{/number}","notifications_url":"https://api.github.com/repos/pomek/json-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pomek/json-api/labels{/name}","releases_url":"https://api.github.com/repos/pomek/json-api/releases{/id}","created_at":"2015-11-16T17:07:26Z","updated_at":"2015-11-16T17:07:27Z","pushed_at":"2015-11-16T18:09:59Z","git_url":"git://github.com/pomek/json-api.git","ssh_url":"git@github.com:pomek/json-api.git","clone_url":"https://github.com/pomek/json-api.git","svn_url":"https://github.com/pomek/json-api","homepage":"","size":140,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tobscure:master","ref":"master","sha":"ef939dbd4339d46e1d277633a0b60c34721751de","user":{"login":"tobscure","id":128862,"avatar_url":"https://avatars.githubusercontent.com/u/128862?v=3","gravatar_id":"","url":"https://api.github.com/users/tobscure","html_url":"https://github.com/tobscure","followers_url":"https://api.github.com/users/tobscure/followers","following_url":"https://api.github.com/users/tobscure/following{/other_user}","gists_url":"https://api.github.com/users/tobscure/gists{/gist_id}","starred_url":"https://api.github.com/users/tobscure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobscure/subscriptions","organizations_url":"https://api.github.com/users/tobscure/orgs","repos_url":"https://api.github.com/users/tobscure/repos","events_url":"https://api.github.com/users/tobscure/events{/privacy}","received_events_url":"https://api.github.com/users/tobscure/received_events","type":"User","site_admin":false},"repo":{"id":21789906,"name":"json-api","full_name":"tobscure/json-api","owner":{"login":"tobscure","id":128862,"avatar_url":"https://avatars.githubusercontent.com/u/128862?v=3","gravatar_id":"","url":"https://api.github.com/users/tobscure","html_url":"https://github.com/tobscure","followers_url":"https://api.github.com/users/tobscure/followers","following_url":"https://api.github.com/users/tobscure/following{/other_user}","gists_url":"https://api.github.com/users/tobscure/gists{/gist_id}","starred_url":"https://api.github.com/users/tobscure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobscure/subscriptions","organizations_url":"https://api.github.com/users/tobscure/orgs","repos_url":"https://api.github.com/users/tobscure/repos","events_url":"https://api.github.com/users/tobscure/events{/privacy}","received_events_url":"https://api.github.com/users/tobscure/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tobscure/json-api","description":"JSON-API (http://jsonapi.org) responses in PHP.","fork":false,"url":"https://api.github.com/repos/tobscure/json-api","forks_url":"https://api.github.com/repos/tobscure/json-api/forks","keys_url":"https://api.github.com/repos/tobscure/json-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobscure/json-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobscure/json-api/teams","hooks_url":"https://api.github.com/repos/tobscure/json-api/hooks","issue_events_url":"https://api.github.com/repos/tobscure/json-api/issues/events{/number}","events_url":"https://api.github.com/repos/tobscure/json-api/events","assignees_url":"https://api.github.com/repos/tobscure/json-api/assignees{/user}","branches_url":"https://api.github.com/repos/tobscure/json-api/branches{/branch}","tags_url":"https://api.github.com/repos/tobscure/json-api/tags","blobs_url":"https://api.github.com/repos/tobscure/json-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobscure/json-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobscure/json-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobscure/json-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobscure/json-api/statuses/{sha}","languages_url":"https://api.github.com/repos/tobscure/json-api/languages","stargazers_url":"https://api.github.com/repos/tobscure/json-api/stargazers","contributors_url":"https://api.github.com/repos/tobscure/json-api/contributors","subscribers_url":"https://api.github.com/repos/tobscure/json-api/subscribers","subscription_url":"https://api.github.com/repos/tobscure/json-api/subscription","commits_url":"https://api.github.com/repos/tobscure/json-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobscure/json-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobscure/json-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobscure/json-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/tobscure/json-api/contents/{+path}","compare_url":"https://api.github.com/repos/tobscure/json-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobscure/json-api/merges","archive_url":"https://api.github.com/repos/tobscure/json-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobscure/json-api/downloads","issues_url":"https://api.github.com/repos/tobscure/json-api/issues{/number}","pulls_url":"https://api.github.com/repos/tobscure/json-api/pulls{/number}","milestones_url":"https://api.github.com/repos/tobscure/json-api/milestones{/number}","notifications_url":"https://api.github.com/repos/tobscure/json-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobscure/json-api/labels{/name}","releases_url":"https://api.github.com/repos/tobscure/json-api/releases{/id}","created_at":"2014-07-13T12:34:23Z","updated_at":"2015-11-16T16:49:25Z","pushed_at":"2015-11-16T18:09:59Z","git_url":"git://github.com/tobscure/json-api.git","ssh_url":"git@github.com:tobscure/json-api.git","clone_url":"https://github.com/tobscure/json-api.git","svn_url":"https://github.com/tobscure/json-api","homepage":"","size":633,"stargazers_count":155,"watchers_count":155,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":4,"forks":18,"open_issues":4,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tobscure/json-api/pulls/67"},"html":{"href":"https://github.com/tobscure/json-api/pull/67"},"issue":{"href":"https://api.github.com/repos/tobscure/json-api/issues/67"},"comments":{"href":"https://api.github.com/repos/tobscure/json-api/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/tobscure/json-api/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/tobscure/json-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tobscure/json-api/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/tobscure/json-api/statuses/12d8837aacb848bae5a192b5817c962e38f1d530"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":4,"additions":190,"deletions":124,"changed_files":17}}