{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/14251","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/14251/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/14251/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/14251/events","html_url":"https://github.com/elastic/elasticsearch/pull/14251","id":112802088,"number":14251,"title":"Replace IndexSettings annotation with a full-fledged class","user":{"login":"s1monw","id":973334,"avatar_url":"https://avatars.githubusercontent.com/u/973334?v=3","gravatar_id":"","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Settings","name":":Settings","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/breaking","name":"breaking","color":"ff0000"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v3.0.0","name":"v3.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-22T13:21:01Z","updated_at":"2015-10-23T13:34:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/14251","html_url":"https://github.com/elastic/elasticsearch/pull/14251","diff_url":"https://github.com/elastic/elasticsearch/pull/14251.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/14251.patch"},"body":"The @IndexSettings annoationat has been used to differentiate between node-level\r\nand index level settings. It was also decoupled from realtime-updates such that\r\nthe settings object that a class got injected when it was created was static and\r\nnot subject to change when an update was applied. This change removes the annoation\r\nand replaces it with a full-fledged class that adds type-safety and encapsulates additional\r\nfunctionality as well as checks on the settings."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/150574147","html_url":"https://github.com/elastic/elasticsearch/pull/14251#issuecomment-150574147","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/14251","id":150574147,"user":{"login":"jaymode","id":4339958,"avatar_url":"https://avatars.githubusercontent.com/u/4339958?v=3","gravatar_id":"","url":"https://api.github.com/users/jaymode","html_url":"https://github.com/jaymode","followers_url":"https://api.github.com/users/jaymode/followers","following_url":"https://api.github.com/users/jaymode/following{/other_user}","gists_url":"https://api.github.com/users/jaymode/gists{/gist_id}","starred_url":"https://api.github.com/users/jaymode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaymode/subscriptions","organizations_url":"https://api.github.com/users/jaymode/orgs","repos_url":"https://api.github.com/users/jaymode/repos","events_url":"https://api.github.com/users/jaymode/events{/privacy}","received_events_url":"https://api.github.com/users/jaymode/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T13:34:34Z","updated_at":"2015-10-23T13:34:34Z","body":"left a few minor comments. Other than that LGTM! This is a nice change and makes it easier to follow IMO"}}