{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/attm2x/m2x-mruby/pulls/1","id":40324122,"html_url":"https://github.com/attm2x/m2x-mruby/pull/1","diff_url":"https://github.com/attm2x/m2x-mruby/pull/1.diff","patch_url":"https://github.com/attm2x/m2x-mruby/pull/1.patch","issue_url":"https://api.github.com/repos/attm2x/m2x-mruby/issues/1","number":1,"state":"closed","locked":false,"title":"Small fixes","user":{"login":"xxuejie","id":340446,"avatar_url":"https://avatars.githubusercontent.com/u/340446?v=3","gravatar_id":"","url":"https://api.github.com/users/xxuejie","html_url":"https://github.com/xxuejie","followers_url":"https://api.github.com/users/xxuejie/followers","following_url":"https://api.github.com/users/xxuejie/following{/other_user}","gists_url":"https://api.github.com/users/xxuejie/gists{/gist_id}","starred_url":"https://api.github.com/users/xxuejie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xxuejie/subscriptions","organizations_url":"https://api.github.com/users/xxuejie/orgs","repos_url":"https://api.github.com/users/xxuejie/repos","events_url":"https://api.github.com/users/xxuejie/events{/privacy}","received_events_url":"https://api.github.com/users/xxuejie/received_events","type":"User","site_admin":false},"body":"This PR fixes 2 things:\r\n\r\n1. When I was testing on a Raspberry Pi 2, building the library directly will signal the following error:\r\n\r\n```\r\npi@raspberrypi ~/mruby $ ./minirake                                                                                                                  \r\n(in /home/pi/mruby)\r\nGIT CHECKOUT master \r\nAlready on 'master'\r\nrake aborted!\r\n/home/pi/mruby/build/mrbgems/m2x-mruby/mrbgem.rake:4: invalid multibyte char (US-ASCII)\r\n/home/pi/mruby/build/mrbgems/m2x-mruby/mrbgem.rake:4: invalid multibyte char (US-ASCII)\r\n/home/pi/mruby/build/mrbgems/m2x-mruby/mrbgem.rake:4: syntax error, unexpected $end, expecting keyword_end\r\n  spec.summary = 'Client library for AT&T’s M2X API'\r\n                                           ^\r\nRakefile:15:in `load'\r\n```\r\n\r\nI know this is probably due to encoding configurations on a Pi, and chances are I might be able to fix this on the Pi end. However, since this library is mostly dealing with embedded systems which might have all kinds of encoding settings. Maybe it's simply better to remove the affect character, since it's not a big deal, correct?\r\n\r\n2. Last time I check, mruby does not have `Class#name` method, a little testing shows the same result:\r\n\r\n```\r\n> device = m2x.device(\"<a valid device ID>\")                              \r\n/home/pi/mruby/build/mrbgems/m2x-mruby/mrblib/m2x-client-resource.rb:35: undefined method 'name' for #<Class:0xd57b00> (NoMethodError)\r\n```\r\n\r\nSo I simply use `Class#to_s` to replace `Class#name`.","created_at":"2015-07-20T05:20:10Z","updated_at":"2015-07-20T14:43:35Z","closed_at":"2015-07-20T14:43:35Z","merged_at":"2015-07-20T14:43:35Z","merge_commit_sha":"088e0ae83599b2844555aa054bff9070b34ce850","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/attm2x/m2x-mruby/pulls/1/commits","review_comments_url":"https://api.github.com/repos/attm2x/m2x-mruby/pulls/1/comments","review_comment_url":"https://api.github.com/repos/attm2x/m2x-mruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/attm2x/m2x-mruby/issues/1/comments","statuses_url":"https://api.github.com/repos/attm2x/m2x-mruby/statuses/f10c60dac796a5673781c0f81720145b847f32eb","head":{"label":"attm2x:small-fixes","ref":"small-fixes","sha":"f10c60dac796a5673781c0f81720145b847f32eb","user":{"login":"attm2x","id":5272295,"avatar_url":"https://avatars.githubusercontent.com/u/5272295?v=3","gravatar_id":"","url":"https://api.github.com/users/attm2x","html_url":"https://github.com/attm2x","followers_url":"https://api.github.com/users/attm2x/followers","following_url":"https://api.github.com/users/attm2x/following{/other_user}","gists_url":"https://api.github.com/users/attm2x/gists{/gist_id}","starred_url":"https://api.github.com/users/attm2x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attm2x/subscriptions","organizations_url":"https://api.github.com/users/attm2x/orgs","repos_url":"https://api.github.com/users/attm2x/repos","events_url":"https://api.github.com/users/attm2x/events{/privacy}","received_events_url":"https://api.github.com/users/attm2x/received_events","type":"Organization","site_admin":false},"repo":{"id":18202203,"name":"m2x-mruby","full_name":"attm2x/m2x-mruby","owner":{"login":"attm2x","id":5272295,"avatar_url":"https://avatars.githubusercontent.com/u/5272295?v=3","gravatar_id":"","url":"https://api.github.com/users/attm2x","html_url":"https://github.com/attm2x","followers_url":"https://api.github.com/users/attm2x/followers","following_url":"https://api.github.com/users/attm2x/following{/other_user}","gists_url":"https://api.github.com/users/attm2x/gists{/gist_id}","starred_url":"https://api.github.com/users/attm2x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attm2x/subscriptions","organizations_url":"https://api.github.com/users/attm2x/orgs","repos_url":"https://api.github.com/users/attm2x/repos","events_url":"https://api.github.com/users/attm2x/events{/privacy}","received_events_url":"https://api.github.com/users/attm2x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/attm2x/m2x-mruby","description":"AT&T M2X mRuby Library","fork":false,"url":"https://api.github.com/repos/attm2x/m2x-mruby","forks_url":"https://api.github.com/repos/attm2x/m2x-mruby/forks","keys_url":"https://api.github.com/repos/attm2x/m2x-mruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/attm2x/m2x-mruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/attm2x/m2x-mruby/teams","hooks_url":"https://api.github.com/repos/attm2x/m2x-mruby/hooks","issue_events_url":"https://api.github.com/repos/attm2x/m2x-mruby/issues/events{/number}","events_url":"https://api.github.com/repos/attm2x/m2x-mruby/events","assignees_url":"https://api.github.com/repos/attm2x/m2x-mruby/assignees{/user}","branches_url":"https://api.github.com/repos/attm2x/m2x-mruby/branches{/branch}","tags_url":"https://api.github.com/repos/attm2x/m2x-mruby/tags","blobs_url":"https://api.github.com/repos/attm2x/m2x-mruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/attm2x/m2x-mruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/attm2x/m2x-mruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/attm2x/m2x-mruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/attm2x/m2x-mruby/statuses/{sha}","languages_url":"https://api.github.com/repos/attm2x/m2x-mruby/languages","stargazers_url":"https://api.github.com/repos/attm2x/m2x-mruby/stargazers","contributors_url":"https://api.github.com/repos/attm2x/m2x-mruby/contributors","subscribers_url":"https://api.github.com/repos/attm2x/m2x-mruby/subscribers","subscription_url":"https://api.github.com/repos/attm2x/m2x-mruby/subscription","commits_url":"https://api.github.com/repos/attm2x/m2x-mruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/attm2x/m2x-mruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/attm2x/m2x-mruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/attm2x/m2x-mruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/attm2x/m2x-mruby/contents/{+path}","compare_url":"https://api.github.com/repos/attm2x/m2x-mruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/attm2x/m2x-mruby/merges","archive_url":"https://api.github.com/repos/attm2x/m2x-mruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/attm2x/m2x-mruby/downloads","issues_url":"https://api.github.com/repos/attm2x/m2x-mruby/issues{/number}","pulls_url":"https://api.github.com/repos/attm2x/m2x-mruby/pulls{/number}","milestones_url":"https://api.github.com/repos/attm2x/m2x-mruby/milestones{/number}","notifications_url":"https://api.github.com/repos/attm2x/m2x-mruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/attm2x/m2x-mruby/labels{/name}","releases_url":"https://api.github.com/repos/attm2x/m2x-mruby/releases{/id}","created_at":"2014-03-28T05:39:52Z","updated_at":"2015-03-23T21:10:45Z","pushed_at":"2015-07-20T14:43:35Z","git_url":"git://github.com/attm2x/m2x-mruby.git","ssh_url":"git@github.com:attm2x/m2x-mruby.git","clone_url":"https://github.com/attm2x/m2x-mruby.git","svn_url":"https://github.com/attm2x/m2x-mruby","homepage":"https://m2x.att.com/developer/client-libraries","size":205,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"attm2x:master","ref":"master","sha":"d4a3eefc7177ac6b10f546b4698680bfc18d2e5f","user":{"login":"attm2x","id":5272295,"avatar_url":"https://avatars.githubusercontent.com/u/5272295?v=3","gravatar_id":"","url":"https://api.github.com/users/attm2x","html_url":"https://github.com/attm2x","followers_url":"https://api.github.com/users/attm2x/followers","following_url":"https://api.github.com/users/attm2x/following{/other_user}","gists_url":"https://api.github.com/users/attm2x/gists{/gist_id}","starred_url":"https://api.github.com/users/attm2x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attm2x/subscriptions","organizations_url":"https://api.github.com/users/attm2x/orgs","repos_url":"https://api.github.com/users/attm2x/repos","events_url":"https://api.github.com/users/attm2x/events{/privacy}","received_events_url":"https://api.github.com/users/attm2x/received_events","type":"Organization","site_admin":false},"repo":{"id":18202203,"name":"m2x-mruby","full_name":"attm2x/m2x-mruby","owner":{"login":"attm2x","id":5272295,"avatar_url":"https://avatars.githubusercontent.com/u/5272295?v=3","gravatar_id":"","url":"https://api.github.com/users/attm2x","html_url":"https://github.com/attm2x","followers_url":"https://api.github.com/users/attm2x/followers","following_url":"https://api.github.com/users/attm2x/following{/other_user}","gists_url":"https://api.github.com/users/attm2x/gists{/gist_id}","starred_url":"https://api.github.com/users/attm2x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attm2x/subscriptions","organizations_url":"https://api.github.com/users/attm2x/orgs","repos_url":"https://api.github.com/users/attm2x/repos","events_url":"https://api.github.com/users/attm2x/events{/privacy}","received_events_url":"https://api.github.com/users/attm2x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/attm2x/m2x-mruby","description":"AT&T M2X mRuby Library","fork":false,"url":"https://api.github.com/repos/attm2x/m2x-mruby","forks_url":"https://api.github.com/repos/attm2x/m2x-mruby/forks","keys_url":"https://api.github.com/repos/attm2x/m2x-mruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/attm2x/m2x-mruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/attm2x/m2x-mruby/teams","hooks_url":"https://api.github.com/repos/attm2x/m2x-mruby/hooks","issue_events_url":"https://api.github.com/repos/attm2x/m2x-mruby/issues/events{/number}","events_url":"https://api.github.com/repos/attm2x/m2x-mruby/events","assignees_url":"https://api.github.com/repos/attm2x/m2x-mruby/assignees{/user}","branches_url":"https://api.github.com/repos/attm2x/m2x-mruby/branches{/branch}","tags_url":"https://api.github.com/repos/attm2x/m2x-mruby/tags","blobs_url":"https://api.github.com/repos/attm2x/m2x-mruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/attm2x/m2x-mruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/attm2x/m2x-mruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/attm2x/m2x-mruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/attm2x/m2x-mruby/statuses/{sha}","languages_url":"https://api.github.com/repos/attm2x/m2x-mruby/languages","stargazers_url":"https://api.github.com/repos/attm2x/m2x-mruby/stargazers","contributors_url":"https://api.github.com/repos/attm2x/m2x-mruby/contributors","subscribers_url":"https://api.github.com/repos/attm2x/m2x-mruby/subscribers","subscription_url":"https://api.github.com/repos/attm2x/m2x-mruby/subscription","commits_url":"https://api.github.com/repos/attm2x/m2x-mruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/attm2x/m2x-mruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/attm2x/m2x-mruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/attm2x/m2x-mruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/attm2x/m2x-mruby/contents/{+path}","compare_url":"https://api.github.com/repos/attm2x/m2x-mruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/attm2x/m2x-mruby/merges","archive_url":"https://api.github.com/repos/attm2x/m2x-mruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/attm2x/m2x-mruby/downloads","issues_url":"https://api.github.com/repos/attm2x/m2x-mruby/issues{/number}","pulls_url":"https://api.github.com/repos/attm2x/m2x-mruby/pulls{/number}","milestones_url":"https://api.github.com/repos/attm2x/m2x-mruby/milestones{/number}","notifications_url":"https://api.github.com/repos/attm2x/m2x-mruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/attm2x/m2x-mruby/labels{/name}","releases_url":"https://api.github.com/repos/attm2x/m2x-mruby/releases{/id}","created_at":"2014-03-28T05:39:52Z","updated_at":"2015-03-23T21:10:45Z","pushed_at":"2015-07-20T14:43:35Z","git_url":"git://github.com/attm2x/m2x-mruby.git","ssh_url":"git@github.com:attm2x/m2x-mruby.git","clone_url":"https://github.com/attm2x/m2x-mruby.git","svn_url":"https://github.com/attm2x/m2x-mruby","homepage":"https://m2x.att.com/developer/client-libraries","size":205,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/attm2x/m2x-mruby/pulls/1"},"html":{"href":"https://github.com/attm2x/m2x-mruby/pull/1"},"issue":{"href":"https://api.github.com/repos/attm2x/m2x-mruby/issues/1"},"comments":{"href":"https://api.github.com/repos/attm2x/m2x-mruby/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/attm2x/m2x-mruby/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/attm2x/m2x-mruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/attm2x/m2x-mruby/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/attm2x/m2x-mruby/statuses/f10c60dac796a5673781c0f81720145b847f32eb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"xxuejie","id":340446,"avatar_url":"https://avatars.githubusercontent.com/u/340446?v=3","gravatar_id":"","url":"https://api.github.com/users/xxuejie","html_url":"https://github.com/xxuejie","followers_url":"https://api.github.com/users/xxuejie/followers","following_url":"https://api.github.com/users/xxuejie/following{/other_user}","gists_url":"https://api.github.com/users/xxuejie/gists{/gist_id}","starred_url":"https://api.github.com/users/xxuejie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xxuejie/subscriptions","organizations_url":"https://api.github.com/users/xxuejie/orgs","repos_url":"https://api.github.com/users/xxuejie/repos","events_url":"https://api.github.com/users/xxuejie/events{/privacy}","received_events_url":"https://api.github.com/users/xxuejie/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":3,"deletions":3,"changed_files":2}}