{"action":"created","comment":{"url":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/comments/47349894","id":47349894,"diff_hunk":"@@ -34,7 +34,7 @@ public function testGetCodeBlockDisabled()\n \n     public function testGetCodeBlock()\n     {\n-        $config = new UrlLoader(['loaders' => ['url' => ['enabled' => true, 'extensions' => 'png', 'limit' => 100]]]);\n+        $config = new UrlLoader(['loaders' => ['url' => ['enabled' => true, 'image_extensions' => 'png', 'font_extensions' => 'woff2', 'limit' => 100]]]);\n         $block  = $config->getCodeBlocks()[0];","path":"test/Component/Configuration/Loader/UrlLoaderTest.php","position":6,"original_position":6,"commit_id":"6c231ae8d60aa9540458346ea78609f6f4e72e99","original_commit_id":"6c231ae8d60aa9540458346ea78609f6f4e72e99","user":{"login":"iltar","id":1754678,"avatar_url":"https://avatars.githubusercontent.com/u/1754678?v=3","gravatar_id":"","url":"https://api.github.com/users/iltar","html_url":"https://github.com/iltar","followers_url":"https://api.github.com/users/iltar/followers","following_url":"https://api.github.com/users/iltar/following{/other_user}","gists_url":"https://api.github.com/users/iltar/gists{/gist_id}","starred_url":"https://api.github.com/users/iltar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iltar/subscriptions","organizations_url":"https://api.github.com/users/iltar/orgs","repos_url":"https://api.github.com/users/iltar/repos","events_url":"https://api.github.com/users/iltar/events{/privacy}","received_events_url":"https://api.github.com/users/iltar/received_events","type":"User","site_admin":false},"body":"Can you add a test case where you test with multiple and no extensions of both? It's mainly because of the different behavior they have now when you've got multiple fonts/images.","created_at":"2015-12-11T12:25:31Z","updated_at":"2015-12-11T12:25:31Z","html_url":"https://github.com/hostnet/webpack-bundle/pull/32#discussion_r47349894","pull_request_url":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/comments/47349894"},"html":{"href":"https://github.com/hostnet/webpack-bundle/pull/32#discussion_r47349894"},"pull_request":{"href":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/32","id":53386183,"html_url":"https://github.com/hostnet/webpack-bundle/pull/32","diff_url":"https://github.com/hostnet/webpack-bundle/pull/32.diff","patch_url":"https://github.com/hostnet/webpack-bundle/pull/32.patch","issue_url":"https://api.github.com/repos/hostnet/webpack-bundle/issues/32","number":32,"state":"open","locked":false,"title":"differentiate fonts from images","user":{"login":"eljam","id":121432,"avatar_url":"https://avatars.githubusercontent.com/u/121432?v=3","gravatar_id":"","url":"https://api.github.com/users/eljam","html_url":"https://github.com/eljam","followers_url":"https://api.github.com/users/eljam/followers","following_url":"https://api.github.com/users/eljam/following{/other_user}","gists_url":"https://api.github.com/users/eljam/gists{/gist_id}","starred_url":"https://api.github.com/users/eljam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eljam/subscriptions","organizations_url":"https://api.github.com/users/eljam/orgs","repos_url":"https://api.github.com/users/eljam/repos","events_url":"https://api.github.com/users/eljam/events{/privacy}","received_events_url":"https://api.github.com/users/eljam/received_events","type":"User","site_admin":false},"body":"I think we need to make a different between images and fonts because in some font framework like font awesome they add something like `eot?v=23`","created_at":"2015-12-11T12:19:10Z","updated_at":"2015-12-11T12:25:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aba566f1b2e539317ca49d57a3642b2bbc8a891c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/32/commits","review_comments_url":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/32/comments","review_comment_url":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hostnet/webpack-bundle/issues/32/comments","statuses_url":"https://api.github.com/repos/hostnet/webpack-bundle/statuses/6c231ae8d60aa9540458346ea78609f6f4e72e99","head":{"label":"eljam:update-url-loader","ref":"update-url-loader","sha":"6c231ae8d60aa9540458346ea78609f6f4e72e99","user":{"login":"eljam","id":121432,"avatar_url":"https://avatars.githubusercontent.com/u/121432?v=3","gravatar_id":"","url":"https://api.github.com/users/eljam","html_url":"https://github.com/eljam","followers_url":"https://api.github.com/users/eljam/followers","following_url":"https://api.github.com/users/eljam/following{/other_user}","gists_url":"https://api.github.com/users/eljam/gists{/gist_id}","starred_url":"https://api.github.com/users/eljam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eljam/subscriptions","organizations_url":"https://api.github.com/users/eljam/orgs","repos_url":"https://api.github.com/users/eljam/repos","events_url":"https://api.github.com/users/eljam/events{/privacy}","received_events_url":"https://api.github.com/users/eljam/received_events","type":"User","site_admin":false},"repo":{"id":47753744,"name":"webpack-bundle","full_name":"eljam/webpack-bundle","owner":{"login":"eljam","id":121432,"avatar_url":"https://avatars.githubusercontent.com/u/121432?v=3","gravatar_id":"","url":"https://api.github.com/users/eljam","html_url":"https://github.com/eljam","followers_url":"https://api.github.com/users/eljam/followers","following_url":"https://api.github.com/users/eljam/following{/other_user}","gists_url":"https://api.github.com/users/eljam/gists{/gist_id}","starred_url":"https://api.github.com/users/eljam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eljam/subscriptions","organizations_url":"https://api.github.com/users/eljam/orgs","repos_url":"https://api.github.com/users/eljam/repos","events_url":"https://api.github.com/users/eljam/events{/privacy}","received_events_url":"https://api.github.com/users/eljam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eljam/webpack-bundle","description":"","fork":true,"url":"https://api.github.com/repos/eljam/webpack-bundle","forks_url":"https://api.github.com/repos/eljam/webpack-bundle/forks","keys_url":"https://api.github.com/repos/eljam/webpack-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eljam/webpack-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eljam/webpack-bundle/teams","hooks_url":"https://api.github.com/repos/eljam/webpack-bundle/hooks","issue_events_url":"https://api.github.com/repos/eljam/webpack-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/eljam/webpack-bundle/events","assignees_url":"https://api.github.com/repos/eljam/webpack-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/eljam/webpack-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/eljam/webpack-bundle/tags","blobs_url":"https://api.github.com/repos/eljam/webpack-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eljam/webpack-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eljam/webpack-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/eljam/webpack-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eljam/webpack-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/eljam/webpack-bundle/languages","stargazers_url":"https://api.github.com/repos/eljam/webpack-bundle/stargazers","contributors_url":"https://api.github.com/repos/eljam/webpack-bundle/contributors","subscribers_url":"https://api.github.com/repos/eljam/webpack-bundle/subscribers","subscription_url":"https://api.github.com/repos/eljam/webpack-bundle/subscription","commits_url":"https://api.github.com/repos/eljam/webpack-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/eljam/webpack-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/eljam/webpack-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/eljam/webpack-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/eljam/webpack-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/eljam/webpack-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eljam/webpack-bundle/merges","archive_url":"https://api.github.com/repos/eljam/webpack-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eljam/webpack-bundle/downloads","issues_url":"https://api.github.com/repos/eljam/webpack-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/eljam/webpack-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/eljam/webpack-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/eljam/webpack-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eljam/webpack-bundle/labels{/name}","releases_url":"https://api.github.com/repos/eljam/webpack-bundle/releases{/id}","created_at":"2015-12-10T10:07:45Z","updated_at":"2015-12-10T10:07:45Z","pushed_at":"2015-12-11T12:18:37Z","git_url":"git://github.com/eljam/webpack-bundle.git","ssh_url":"git@github.com:eljam/webpack-bundle.git","clone_url":"https://github.com/eljam/webpack-bundle.git","svn_url":"https://github.com/eljam/webpack-bundle","homepage":null,"size":163,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hostnet:master","ref":"master","sha":"1e1cabf39b364891729c696fb1f9fd998bf7833d","user":{"login":"hostnet","id":1465011,"avatar_url":"https://avatars.githubusercontent.com/u/1465011?v=3","gravatar_id":"","url":"https://api.github.com/users/hostnet","html_url":"https://github.com/hostnet","followers_url":"https://api.github.com/users/hostnet/followers","following_url":"https://api.github.com/users/hostnet/following{/other_user}","gists_url":"https://api.github.com/users/hostnet/gists{/gist_id}","starred_url":"https://api.github.com/users/hostnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hostnet/subscriptions","organizations_url":"https://api.github.com/users/hostnet/orgs","repos_url":"https://api.github.com/users/hostnet/repos","events_url":"https://api.github.com/users/hostnet/events{/privacy}","received_events_url":"https://api.github.com/users/hostnet/received_events","type":"Organization","site_admin":false},"repo":{"id":41296415,"name":"webpack-bundle","full_name":"hostnet/webpack-bundle","owner":{"login":"hostnet","id":1465011,"avatar_url":"https://avatars.githubusercontent.com/u/1465011?v=3","gravatar_id":"","url":"https://api.github.com/users/hostnet","html_url":"https://github.com/hostnet","followers_url":"https://api.github.com/users/hostnet/followers","following_url":"https://api.github.com/users/hostnet/following{/other_user}","gists_url":"https://api.github.com/users/hostnet/gists{/gist_id}","starred_url":"https://api.github.com/users/hostnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hostnet/subscriptions","organizations_url":"https://api.github.com/users/hostnet/orgs","repos_url":"https://api.github.com/users/hostnet/repos","events_url":"https://api.github.com/users/hostnet/events{/privacy}","received_events_url":"https://api.github.com/users/hostnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hostnet/webpack-bundle","description":"","fork":false,"url":"https://api.github.com/repos/hostnet/webpack-bundle","forks_url":"https://api.github.com/repos/hostnet/webpack-bundle/forks","keys_url":"https://api.github.com/repos/hostnet/webpack-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hostnet/webpack-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hostnet/webpack-bundle/teams","hooks_url":"https://api.github.com/repos/hostnet/webpack-bundle/hooks","issue_events_url":"https://api.github.com/repos/hostnet/webpack-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/hostnet/webpack-bundle/events","assignees_url":"https://api.github.com/repos/hostnet/webpack-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/hostnet/webpack-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/hostnet/webpack-bundle/tags","blobs_url":"https://api.github.com/repos/hostnet/webpack-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hostnet/webpack-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hostnet/webpack-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/hostnet/webpack-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hostnet/webpack-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/hostnet/webpack-bundle/languages","stargazers_url":"https://api.github.com/repos/hostnet/webpack-bundle/stargazers","contributors_url":"https://api.github.com/repos/hostnet/webpack-bundle/contributors","subscribers_url":"https://api.github.com/repos/hostnet/webpack-bundle/subscribers","subscription_url":"https://api.github.com/repos/hostnet/webpack-bundle/subscription","commits_url":"https://api.github.com/repos/hostnet/webpack-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/hostnet/webpack-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/hostnet/webpack-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/hostnet/webpack-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/hostnet/webpack-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/hostnet/webpack-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hostnet/webpack-bundle/merges","archive_url":"https://api.github.com/repos/hostnet/webpack-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hostnet/webpack-bundle/downloads","issues_url":"https://api.github.com/repos/hostnet/webpack-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/hostnet/webpack-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/hostnet/webpack-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/hostnet/webpack-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hostnet/webpack-bundle/labels{/name}","releases_url":"https://api.github.com/repos/hostnet/webpack-bundle/releases{/id}","created_at":"2015-08-24T10:09:51Z","updated_at":"2015-12-10T17:53:05Z","pushed_at":"2015-12-11T12:19:11Z","git_url":"git://github.com/hostnet/webpack-bundle.git","ssh_url":"git@github.com:hostnet/webpack-bundle.git","clone_url":"https://github.com/hostnet/webpack-bundle.git","svn_url":"https://github.com/hostnet/webpack-bundle","homepage":null,"size":163,"stargazers_count":8,"watchers_count":8,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":10,"forks":9,"open_issues":10,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/32"},"html":{"href":"https://github.com/hostnet/webpack-bundle/pull/32"},"issue":{"href":"https://api.github.com/repos/hostnet/webpack-bundle/issues/32"},"comments":{"href":"https://api.github.com/repos/hostnet/webpack-bundle/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hostnet/webpack-bundle/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/hostnet/webpack-bundle/statuses/6c231ae8d60aa9540458346ea78609f6f4e72e99"}}}}