{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef-web-core/pulls/comments/44344468","id":44344468,"diff_hunk":"@@ -82,145 +35,109 @@ Add the `skinny` modifier to get a thinner bar more appropriate for apps or smal\n ```\n \n <div data-alert class=\"alert-box secondary radius\">\n-  The Top Bar component also requires a JavaScript module to work properly. Be sure to include \n-  chef.js in your page, along with whatever additional scripts you might need. See the \n+  The Top Bar component also requires a JavaScript module in order for the\n+  mobile menu dropdown to work properly. Be sure to include\n+  chef.js in your page, along with whatever additional scripts you might need. See the\n   <a href=\"/getting-started\">Getting Started</a> section for more information.\n </div>\n \n-## More Information\n-  * [Foundation Top Bar documentation](http://foundation.zurb.com/docs/components/topbar.html)\n */\n \n-@import '../settings';\n-@import '../base/typography';\n-@import '../themes/default';\n-@import '../layouts/default';\n-@import 'button';\n-@import 'logo';\n-\n-$topbar-bg-color:                   $chef-white !default;\n-$topbar-bg:                         $topbar-bg-color !default;\n-$topbar-dropdown-bg:                $topbar-bg !default;\n-$topbar-logo-margin:                10px !default;\n-$topbar-height:                     rem-calc($logo-height + ($topbar-logo-margin * 2)) !default;\n-$topbar-link-color:                 scale-color($chef-dark-blue, $lightness: 10%) !default;\n-$topbar-link-color-active:          $topbar-link-color !default;\n-$topbar-link-color-active-hover:    $topbar-link-color !default;\n-$topbar-link-color-hover:           scale-color($topbar-link-color, $lightness: 20%) !default;\n-$topbar-link-bg-hover:              $topbar-bg !default;\n-$topbar-link-bg-color-hover:        $topbar-bg !default;\n-$topbar-link-font-family:           $chef-type-label !default;\n-$topbar-link-font-size:             16px !default;\n-$topbar-link-padding:               $topbar-height / 8 !default;\n-$topbar-link-text-transform:        uppercase !default;\n-$topbar-link-weight:                bold !default;\n-$topbar-button-height:              rem-calc($topbar-link-font-size) + ($topbar-link-padding * 2);\n-$topbar-menu-link-color:            $topbar-link-color !default;\n-$topbar-menu-icon-color:            $topbar-link-color !default;\n-$topbar-menu-link-font-size:        rem-calc(13) !default;\n-$topbar-menu-link-transform:        uppercase !default;\n-$topbar-menu-link-weight:           normal !default;\n-$topbar-margin-bottom:              $paragraph-margin-bottom !default;\n-\n-@import 'foundation/components/top-bar';\n-\n-@mixin top-bar($scale: 1, $height: $topbar-height, $link-font-size: $topbar-link-font-size) {\n-  $scaled-height: $height * $scale;\n-  \n-  max-height: $scaled-height;\n-  transition: max-height .4s ease-in;\n-\n-  .title-area {\n-    height: $scaled-height;\n-\n-    .name {\n-      h1 {\n-        line-height: $scaled-height;\n-\n-        a.logo {\n-          width: $logo-width-vertical * $scale;\n-          height: $logo-height * $scale;\n-          margin-top: $topbar-logo-margin * $scale;\n-          margin-left: ($column-gutter / 2) * $scale;\n-          padding: 0;\n-\n-          &.horizontal {\n-            width: $logo-width-horizontal * $scale;\n-          }\n-        }\n-      }\n-    }\n+@import \"chef/settings\";\n+\n+.top-bar {\n+  line-height: 1;\n+  margin-bottom: 20px;\n+  min-height: 50px;\n+  padding: 11px 0.9375rem;","path":"lib/assets/stylesheets/chef/components/top-bar.scss","position":174,"original_position":174,"commit_id":"0b3bc544795b811cbd2ef089c2b8c03ff3b07269","original_commit_id":"0b3bc544795b811cbd2ef089c2b8c03ff3b07269","user":{"login":"smith","id":9912,"avatar_url":"https://avatars.githubusercontent.com/u/9912?v=3","gravatar_id":"","url":"https://api.github.com/users/smith","html_url":"https://github.com/smith","followers_url":"https://api.github.com/users/smith/followers","following_url":"https://api.github.com/users/smith/following{/other_user}","gists_url":"https://api.github.com/users/smith/gists{/gist_id}","starred_url":"https://api.github.com/users/smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smith/subscriptions","organizations_url":"https://api.github.com/users/smith/orgs","repos_url":"https://api.github.com/users/smith/repos","events_url":"https://api.github.com/users/smith/events{/privacy}","received_events_url":"https://api.github.com/users/smith/received_events","type":"User","site_admin":false},"body":"To make it match what I was seeing on downloads:\r\n\r\n![screenshot](https://dl.dropboxusercontent.com/s/7wg828y3z84tg3k/2015-11-09%20at%204.42%20PM.png)\r\n\r\nThe markup is different, but I wanted it to be as close as possible.","created_at":"2015-11-09T22:44:08Z","updated_at":"2015-11-09T22:44:08Z","html_url":"https://github.com/chef/chef-web-core/pull/127#discussion_r44344468","pull_request_url":"https://api.github.com/repos/chef/chef-web-core/pulls/127","_links":{"self":{"href":"https://api.github.com/repos/chef/chef-web-core/pulls/comments/44344468"},"html":{"href":"https://github.com/chef/chef-web-core/pull/127#discussion_r44344468"},"pull_request":{"href":"https://api.github.com/repos/chef/chef-web-core/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef-web-core/pulls/127","id":49915075,"html_url":"https://github.com/chef/chef-web-core/pull/127","diff_url":"https://github.com/chef/chef-web-core/pull/127.diff","patch_url":"https://github.com/chef/chef-web-core/pull/127.patch","issue_url":"https://api.github.com/repos/chef/chef-web-core/issues/127","number":127,"state":"open","locked":false,"title":"Update top bar component to fit new styles","user":{"login":"smith","id":9912,"avatar_url":"https://avatars.githubusercontent.com/u/9912?v=3","gravatar_id":"","url":"https://api.github.com/users/smith","html_url":"https://github.com/smith","followers_url":"https://api.github.com/users/smith/followers","following_url":"https://api.github.com/users/smith/following{/other_user}","gists_url":"https://api.github.com/users/smith/gists{/gist_id}","starred_url":"https://api.github.com/users/smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smith/subscriptions","organizations_url":"https://api.github.com/users/smith/orgs","repos_url":"https://api.github.com/users/smith/repos","events_url":"https://api.github.com/users/smith/events{/privacy}","received_events_url":"https://api.github.com/users/smith/received_events","type":"User","site_admin":false},"body":"This implements the \"solution 4\" style top nav bar. Tried to match the\r\nlook an behavior of Downloads as closely as possibly and simplify the\r\nmarkup and CSS to depend less on Foundation.","created_at":"2015-11-06T04:27:45Z","updated_at":"2015-11-09T22:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36808b9d0a0dba7d7eaf520b71b06eceb220b354","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef-web-core/pulls/127/commits","review_comments_url":"https://api.github.com/repos/chef/chef-web-core/pulls/127/comments","review_comment_url":"https://api.github.com/repos/chef/chef-web-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef-web-core/issues/127/comments","statuses_url":"https://api.github.com/repos/chef/chef-web-core/statuses/0b3bc544795b811cbd2ef089c2b8c03ff3b07269","head":{"label":"chef:nls/solution-4","ref":"nls/solution-4","sha":"0b3bc544795b811cbd2ef089c2b8c03ff3b07269","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":19290171,"name":"chef-web-core","full_name":"chef/chef-web-core","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-web-core","description":"Shared resources for Chef web properties","fork":false,"url":"https://api.github.com/repos/chef/chef-web-core","forks_url":"https://api.github.com/repos/chef/chef-web-core/forks","keys_url":"https://api.github.com/repos/chef/chef-web-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-web-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-web-core/teams","hooks_url":"https://api.github.com/repos/chef/chef-web-core/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-web-core/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-web-core/events","assignees_url":"https://api.github.com/repos/chef/chef-web-core/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-web-core/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-web-core/tags","blobs_url":"https://api.github.com/repos/chef/chef-web-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-web-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-web-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-web-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-web-core/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-web-core/languages","stargazers_url":"https://api.github.com/repos/chef/chef-web-core/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-web-core/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-web-core/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-web-core/subscription","commits_url":"https://api.github.com/repos/chef/chef-web-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-web-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-web-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-web-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-web-core/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-web-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-web-core/merges","archive_url":"https://api.github.com/repos/chef/chef-web-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-web-core/downloads","issues_url":"https://api.github.com/repos/chef/chef-web-core/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-web-core/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-web-core/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-web-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-web-core/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-web-core/releases{/id}","created_at":"2014-04-29T20:11:53Z","updated_at":"2015-10-16T10:47:07Z","pushed_at":"2015-11-07T05:51:00Z","git_url":"git://github.com/chef/chef-web-core.git","ssh_url":"git@github.com:chef/chef-web-core.git","clone_url":"https://github.com/chef/chef-web-core.git","svn_url":"https://github.com/chef/chef-web-core","homepage":"http://style.chef.io","size":30795,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"d0fd894a62deeaae541d6405b1343b535a1da3b2","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":19290171,"name":"chef-web-core","full_name":"chef/chef-web-core","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef-web-core","description":"Shared resources for Chef web properties","fork":false,"url":"https://api.github.com/repos/chef/chef-web-core","forks_url":"https://api.github.com/repos/chef/chef-web-core/forks","keys_url":"https://api.github.com/repos/chef/chef-web-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef-web-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef-web-core/teams","hooks_url":"https://api.github.com/repos/chef/chef-web-core/hooks","issue_events_url":"https://api.github.com/repos/chef/chef-web-core/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef-web-core/events","assignees_url":"https://api.github.com/repos/chef/chef-web-core/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef-web-core/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef-web-core/tags","blobs_url":"https://api.github.com/repos/chef/chef-web-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef-web-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef-web-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef-web-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef-web-core/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef-web-core/languages","stargazers_url":"https://api.github.com/repos/chef/chef-web-core/stargazers","contributors_url":"https://api.github.com/repos/chef/chef-web-core/contributors","subscribers_url":"https://api.github.com/repos/chef/chef-web-core/subscribers","subscription_url":"https://api.github.com/repos/chef/chef-web-core/subscription","commits_url":"https://api.github.com/repos/chef/chef-web-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef-web-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef-web-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef-web-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef-web-core/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef-web-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef-web-core/merges","archive_url":"https://api.github.com/repos/chef/chef-web-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef-web-core/downloads","issues_url":"https://api.github.com/repos/chef/chef-web-core/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef-web-core/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef-web-core/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef-web-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef-web-core/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef-web-core/releases{/id}","created_at":"2014-04-29T20:11:53Z","updated_at":"2015-10-16T10:47:07Z","pushed_at":"2015-11-07T05:51:00Z","git_url":"git://github.com/chef/chef-web-core.git","ssh_url":"git@github.com:chef/chef-web-core.git","clone_url":"https://github.com/chef/chef-web-core.git","svn_url":"https://github.com/chef/chef-web-core","homepage":"http://style.chef.io","size":30795,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef-web-core/pulls/127"},"html":{"href":"https://github.com/chef/chef-web-core/pull/127"},"issue":{"href":"https://api.github.com/repos/chef/chef-web-core/issues/127"},"comments":{"href":"https://api.github.com/repos/chef/chef-web-core/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef-web-core/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef-web-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef-web-core/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef-web-core/statuses/0b3bc544795b811cbd2ef089c2b8c03ff3b07269"}}}}