{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/14","labels_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/14/comments","events_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/14/events","html_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/14","id":53992341,"number":14,"title":"[FIXED JENKINS-9277 JENKINS-25448 JENKINS-23614] Disallow special chars in axis names and values","user":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-11T13:54:46Z","updated_at":"2015-01-12T08:16:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/14","html_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/14","diff_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/14.diff","patch_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/14.patch"},"body":"Fixes [JENKINS-9277](https://issues.jenkins-ci.org/browse/JENKINS-9277), [JENKINS-25448](https://issues.jenkins-ci.org/browse/JENKINS-25448), [JENKINS-23614](https://issues.jenkins-ci.org/browse/JENKINS-23614).\r\n\r\nFrom now on:\r\n- Axis needs to provide non-empty name otherwise form submission is rejected.\r\n- Axis name can not contain `=`and `,`, values can not contain `,` as those have special meaning. Form submission is rejected in such a case.\r\n- Empty list of axis values are allowed, though I am not aware of any use case for that."},"comment":{"url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/comments/69539043","html_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/14#issuecomment-69539043","issue_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/14","id":69539043,"user":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"created_at":"2015-01-12T08:16:00Z","updated_at":"2015-01-12T08:16:00Z","body":"> I was not able to get the escaping approach to work as Combination#toString/fromString is used for more than just UI. Let me get back to that.\r\n\r\nIt may be required to modify the core. Even if it is possible to workaround display/handling issues in Matrix Project, the same situation may happen for Maven projects, folders, etc. \r\n\r\nAll <code>ModelObject</code>s are potentially affected by escaping issues in URLs. We also have corner-cases like <code>.../search</code> links, which may conflict with job names and axis values. No idea how to handle all cases w/o compatibility breaks."}}