{"action":"created","comment":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/40321526","id":40321526,"diff_hunk":"@@ -1,101 +1,114 @@\n # Make a copy of this file named robottelo.properties\n-\n-[main]\n-\n+[server]\n # A hostname is required. scheme (default: https) and port are optional.\n # Suggested values for \"scheme\" are \"http\" and \"https\".\n-server.hostname=\n-#server.scheme=https\n-#server.port=\n-\n-server.ssh.key_private=/home/whoami/.ssh/id_hudson_dsa\n-server.ssh.username=root\n-\n-# For LDAP Authentication.\n-ldap.hostname=\n-ldap.username=\n-ldap.passwd=\n-ldap.basedn=\n-ldap.grpbasedn=\n-\n+hostname=\n+# scheme=https\n+# port=\n+ssh_key=/home/whoami/.ssh/id_hudson_dsa\n+ssh_username=root\n+# ssh_password=\n+admin_username=admin\n+admin_password=changeme\n+\n+# Override robottelo configuration\n+# [robottelo]\n # The directory where screenshots will be saved.\n # Note:- Content under /tmp may be deleted after a reboot.\n-screenshots.base_path=/tmp/robottelo/screenshots/\n+# screenshots_path=/tmp/robottelo/screenshots/\n # Enter only 'sat' for Satellite and 'sam' for SAM\n-project=sat\n-locale=en_US.UTF-8\n-remote=0\n-smoke=0\n-# Update upstream=0 for downstream run\n-upstream=1\n-\n-# For testing with fake manifests, zipfile containing valid manifest is required,\n-# as well as key/cert pair. All of these settings are urls.\n-manifest.fake_url=http://example.org/valid-redhat-manifest.zip\n-manifest.key_url=http://example.org/fake_manifest.key\n-manifest.cert_url=http://example.org/fake_manifest.crt\n-\n-verbosity=2\n+# project=sat\n+# locale=en_US.UTF-8\n+# Update upstream=false for downstream run\n+# upstream=true\n+# Logging verbosity, one of debug, info, warning, error, critical\n+# verbosity=debug\n+# Selenium webdriver to use\n+# webdriver=firefox\n \n # Virtual display controls if PyVirtualDisplay should be used to run UI tests\n-# when setting it to 1 then make sure to install required dependencies\n-virtual_display=0\n+# when setting it to true then make sure to install required dependencies\n+# virtual_display=false\n \n-# If virtual_display=1 and window_manager_command is set, the window manager\n+# If virtual_display=true and window_manager_command is set, the window manager\n # command will be run before opening any browser window\n-window_manager_command=\n+# window_manager_command=\n+\n+# Provide link to rhel6/7 repo here, as puppet rpm\n+# would require packages from RHEL 6/7 repo and syncing the entire repo\n+# on the fly would take longer for tests to run\n+# Specify the *.repo link to an internal repo for tests to execute properly\n+# rhel6_repo=http://example.com/yum/repo_files/rhel6-updates.repo\n+# rhel7_repo=http://example.com/yum/repo_files/rhel7-updates.repo\n+","path":"robottelo.properties.sample","position":79,"original_position":79,"commit_id":"992d841ae67cce750019260758e285f331057a2a","original_commit_id":"992d841ae67cce750019260758e285f331057a2a","user":{"login":"sthirugn","id":3309189,"avatar_url":"https://avatars.githubusercontent.com/u/3309189?v=3","gravatar_id":"","url":"https://api.github.com/users/sthirugn","html_url":"https://github.com/sthirugn","followers_url":"https://api.github.com/users/sthirugn/followers","following_url":"https://api.github.com/users/sthirugn/following{/other_user}","gists_url":"https://api.github.com/users/sthirugn/gists{/gist_id}","starred_url":"https://api.github.com/users/sthirugn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthirugn/subscriptions","organizations_url":"https://api.github.com/users/sthirugn/orgs","repos_url":"https://api.github.com/users/sthirugn/repos","events_url":"https://api.github.com/users/sthirugn/events{/privacy}","received_events_url":"https://api.github.com/users/sthirugn/received_events","type":"User","site_admin":false},"body":"Add an other extra line here to show the section end","created_at":"2015-09-24T14:02:56Z","updated_at":"2015-09-24T14:02:56Z","html_url":"https://github.com/SatelliteQE/robottelo/pull/2807#discussion_r40321526","pull_request_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2807","_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/40321526"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/2807#discussion_r40321526"},"pull_request":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2807"}}},"pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2807","id":45817774,"html_url":"https://github.com/SatelliteQE/robottelo/pull/2807","diff_url":"https://github.com/SatelliteQE/robottelo/pull/2807.diff","patch_url":"https://github.com/SatelliteQE/robottelo/pull/2807.patch","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/2807","number":2807,"state":"open","locked":false,"title":"Refactor config","user":{"login":"elyezer","id":48132,"avatar_url":"https://avatars.githubusercontent.com/u/48132?v=3","gravatar_id":"","url":"https://api.github.com/users/elyezer","html_url":"https://github.com/elyezer","followers_url":"https://api.github.com/users/elyezer/followers","following_url":"https://api.github.com/users/elyezer/following{/other_user}","gists_url":"https://api.github.com/users/elyezer/gists{/gist_id}","starred_url":"https://api.github.com/users/elyezer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyezer/subscriptions","organizations_url":"https://api.github.com/users/elyezer/orgs","repos_url":"https://api.github.com/users/elyezer/repos","events_url":"https://api.github.com/users/elyezer/events{/privacy}","received_events_url":"https://api.github.com/users/elyezer/received_events","type":"User","site_admin":false},"body":"Make Robottelo config smarter by validating the configuration and\r\nallowing switching on and off some feature that depends on some\r\ninfrastructure, like client provisioning.\r\n\r\nSending this PR to the newconfig branch in order to get feedback about the new approach for robottelo's configuration. Still pending: tests, adding to docs, refactor modules that use old config and skip tests based on the availability of the feature.\r\n\r\nUpdate: refactored the entire framework to use the new settings.","created_at":"2015-09-23T19:01:47Z","updated_at":"2015-09-24T14:02:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06828fcf32f9b85e59f2e1acc8beaed661a23463","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2807/commits","review_comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2807/comments","review_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/2807/comments","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/992d841ae67cce750019260758e285f331057a2a","head":{"label":"elyezer:refactor-config","ref":"refactor-config","sha":"992d841ae67cce750019260758e285f331057a2a","user":{"login":"elyezer","id":48132,"avatar_url":"https://avatars.githubusercontent.com/u/48132?v=3","gravatar_id":"","url":"https://api.github.com/users/elyezer","html_url":"https://github.com/elyezer","followers_url":"https://api.github.com/users/elyezer/followers","following_url":"https://api.github.com/users/elyezer/following{/other_user}","gists_url":"https://api.github.com/users/elyezer/gists{/gist_id}","starred_url":"https://api.github.com/users/elyezer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyezer/subscriptions","organizations_url":"https://api.github.com/users/elyezer/orgs","repos_url":"https://api.github.com/users/elyezer/repos","events_url":"https://api.github.com/users/elyezer/events{/privacy}","received_events_url":"https://api.github.com/users/elyezer/received_events","type":"User","site_admin":false},"repo":{"id":14159745,"name":"robottelo","full_name":"elyezer/robottelo","owner":{"login":"elyezer","id":48132,"avatar_url":"https://avatars.githubusercontent.com/u/48132?v=3","gravatar_id":"","url":"https://api.github.com/users/elyezer","html_url":"https://github.com/elyezer","followers_url":"https://api.github.com/users/elyezer/followers","following_url":"https://api.github.com/users/elyezer/following{/other_user}","gists_url":"https://api.github.com/users/elyezer/gists{/gist_id}","starred_url":"https://api.github.com/users/elyezer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyezer/subscriptions","organizations_url":"https://api.github.com/users/elyezer/orgs","repos_url":"https://api.github.com/users/elyezer/repos","events_url":"https://api.github.com/users/elyezer/events{/privacy}","received_events_url":"https://api.github.com/users/elyezer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elyezer/robottelo","description":"An automation testing framework for the Foreman project.","fork":true,"url":"https://api.github.com/repos/elyezer/robottelo","forks_url":"https://api.github.com/repos/elyezer/robottelo/forks","keys_url":"https://api.github.com/repos/elyezer/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elyezer/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elyezer/robottelo/teams","hooks_url":"https://api.github.com/repos/elyezer/robottelo/hooks","issue_events_url":"https://api.github.com/repos/elyezer/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/elyezer/robottelo/events","assignees_url":"https://api.github.com/repos/elyezer/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/elyezer/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/elyezer/robottelo/tags","blobs_url":"https://api.github.com/repos/elyezer/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elyezer/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elyezer/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/elyezer/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elyezer/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/elyezer/robottelo/languages","stargazers_url":"https://api.github.com/repos/elyezer/robottelo/stargazers","contributors_url":"https://api.github.com/repos/elyezer/robottelo/contributors","subscribers_url":"https://api.github.com/repos/elyezer/robottelo/subscribers","subscription_url":"https://api.github.com/repos/elyezer/robottelo/subscription","commits_url":"https://api.github.com/repos/elyezer/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/elyezer/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/elyezer/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/elyezer/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/elyezer/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/elyezer/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elyezer/robottelo/merges","archive_url":"https://api.github.com/repos/elyezer/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elyezer/robottelo/downloads","issues_url":"https://api.github.com/repos/elyezer/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/elyezer/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/elyezer/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/elyezer/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elyezer/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/elyezer/robottelo/releases{/id}","created_at":"2013-11-06T01:31:06Z","updated_at":"2015-05-08T20:30:32Z","pushed_at":"2015-09-23T23:53:33Z","git_url":"git://github.com/elyezer/robottelo.git","ssh_url":"git@github.com:elyezer/robottelo.git","clone_url":"https://github.com/elyezer/robottelo.git","svn_url":"https://github.com/elyezer/robottelo","homepage":"","size":11152,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SatelliteQE:newconfig","ref":"newconfig","sha":"206ca6a83254615d66ac631c5ad0f246d5cae742","user":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"SatelliteQE/robottelo","owner":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SatelliteQE/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":false,"url":"https://api.github.com/repos/SatelliteQE/robottelo","forks_url":"https://api.github.com/repos/SatelliteQE/robottelo/forks","keys_url":"https://api.github.com/repos/SatelliteQE/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SatelliteQE/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SatelliteQE/robottelo/teams","hooks_url":"https://api.github.com/repos/SatelliteQE/robottelo/hooks","issue_events_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/SatelliteQE/robottelo/events","assignees_url":"https://api.github.com/repos/SatelliteQE/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/SatelliteQE/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/tags","blobs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/SatelliteQE/robottelo/languages","stargazers_url":"https://api.github.com/repos/SatelliteQE/robottelo/stargazers","contributors_url":"https://api.github.com/repos/SatelliteQE/robottelo/contributors","subscribers_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscribers","subscription_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscription","commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/SatelliteQE/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/SatelliteQE/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SatelliteQE/robottelo/merges","archive_url":"https://api.github.com/repos/SatelliteQE/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SatelliteQE/robottelo/downloads","issues_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/SatelliteQE/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/SatelliteQE/robottelo/releases{/id}","created_at":"2012-04-12T01:36:39Z","updated_at":"2015-08-04T16:49:37Z","pushed_at":"2015-09-24T13:37:01Z","git_url":"git://github.com/SatelliteQE/robottelo.git","ssh_url":"git@github.com:SatelliteQE/robottelo.git","clone_url":"https://github.com/SatelliteQE/robottelo.git","svn_url":"https://github.com/SatelliteQE/robottelo","homepage":"","size":19471,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":221,"forks":32,"open_issues":221,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2807"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/2807"},"issue":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/2807"},"comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/2807/comments"},"review_comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2807/comments"},"review_comment":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2807/commits"},"statuses":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/992d841ae67cce750019260758e285f331057a2a"}}}}