{"action":"created","comment":{"url":"https://api.github.com/repos/inaka/elvis/pulls/comments/38341505","id":38341505,"diff_hunk":"@@ -387,19 +387,50 @@ verify_max_function_length(_Config) ->\n \n     PathFail = \"fail_max_function_length.erl\",\n     {ok, FileFail} = elvis_test_utils:find_file(SrcDirs, PathFail),\n-    RuleConfig = #{max_length => 4},\n+\n+    CountAllRuleConfig = #{count_comments => true, count_whitespace => true},\n+\n+    ct:comment(\"Count whitespace and comment lines\"),\n+    RuleConfig = CountAllRuleConfig#{max_length => 4},\n     [_, _, _] =\n-         elvis_style:max_function_length(ElvisConfig, FileFail, RuleConfig),\n+        elvis_style:max_function_length(ElvisConfig, FileFail, RuleConfig),\n \n-    RuleConfig1 = #{max_length => 9},\n+    RuleConfig1 = CountAllRuleConfig#{max_length => 9},\n     [_, _] =\n         elvis_style:max_function_length(ElvisConfig, FileFail, RuleConfig1),\n \n-    RuleConfig2 = #{max_length => 14},\n+    RuleConfig2 = CountAllRuleConfig#{max_length => 14},\n     [_] = elvis_style:max_function_length(ElvisConfig, FileFail, RuleConfig2),\n \n-    RuleConfig3 = #{max_length => 15},\n-    [] = elvis_style:max_function_length(ElvisConfig, FileFail, RuleConfig3).\n+    RuleConfig3 = CountAllRuleConfig#{max_length => 15},\n+    [] = elvis_style:max_function_length(ElvisConfig, FileFail, RuleConfig3),\n+\n+    ct:comment(\"Don't count whitespace lines\"),\n+    WhitespaceRuleConfig = CountAllRuleConfig#{count_whitespace => false},\n+\n+    RuleConfig4 = WhitespaceRuleConfig#{max_length => 3},\n+    [_, _, _] = elvis_style:max_function_length(ElvisConfig, FileFail, RuleConfig4),\n+\n+    RuleConfig5 = WhitespaceRuleConfig#{max_length => 7},\n+    [_, _] = elvis_style:max_function_length(ElvisConfig, FileFail, RuleConfig5),","path":"test/style_SUITE.erl","position":35,"original_position":35,"commit_id":"88b253739426d289126e9c537e9b0d8fa905871a","original_commit_id":"88b253739426d289126e9c537e9b0d8fa905871a","user":{"login":"gadgetci","id":10134338,"avatar_url":"https://avatars.githubusercontent.com/u/10134338?v=3","gravatar_id":"","url":"https://api.github.com/users/gadgetci","html_url":"https://github.com/gadgetci","followers_url":"https://api.github.com/users/gadgetci/followers","following_url":"https://api.github.com/users/gadgetci/following{/other_user}","gists_url":"https://api.github.com/users/gadgetci/gists{/gist_id}","starred_url":"https://api.github.com/users/gadgetci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadgetci/subscriptions","organizations_url":"https://api.github.com/users/gadgetci/orgs","repos_url":"https://api.github.com/users/gadgetci/repos","events_url":"https://api.github.com/users/gadgetci/events{/privacy}","received_events_url":"https://api.github.com/users/gadgetci/received_events","type":"User","site_admin":false},"body":"According to **Elvis**:\n> Line 415 is too long:     [_, _] = elvis_style:max_function_length(ElvisConfig, FileFail, RuleConfig5),.","created_at":"2015-08-31T18:17:25Z","updated_at":"2015-08-31T18:17:25Z","html_url":"https://github.com/inaka/elvis/pull/265#discussion_r38341505","pull_request_url":"https://api.github.com/repos/inaka/elvis/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/inaka/elvis/pulls/comments/38341505"},"html":{"href":"https://github.com/inaka/elvis/pull/265#discussion_r38341505"},"pull_request":{"href":"https://api.github.com/repos/inaka/elvis/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/inaka/elvis/pulls/265","id":43792707,"html_url":"https://github.com/inaka/elvis/pull/265","diff_url":"https://github.com/inaka/elvis/pull/265.diff","patch_url":"https://github.com/inaka/elvis/pull/265.patch","issue_url":"https://api.github.com/repos/inaka/elvis/issues/265","number":265,"state":"open","locked":false,"title":"[Closes #263] Options for max function length","user":{"login":"jfacorro","id":1522569,"avatar_url":"https://avatars.githubusercontent.com/u/1522569?v=3","gravatar_id":"","url":"https://api.github.com/users/jfacorro","html_url":"https://github.com/jfacorro","followers_url":"https://api.github.com/users/jfacorro/followers","following_url":"https://api.github.com/users/jfacorro/following{/other_user}","gists_url":"https://api.github.com/users/jfacorro/gists{/gist_id}","starred_url":"https://api.github.com/users/jfacorro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfacorro/subscriptions","organizations_url":"https://api.github.com/users/jfacorro/orgs","repos_url":"https://api.github.com/users/jfacorro/repos","events_url":"https://api.github.com/users/jfacorro/events{/privacy}","received_events_url":"https://api.github.com/users/jfacorro/received_events","type":"User","site_admin":false},"body":"#263 ","created_at":"2015-08-31T18:17:18Z","updated_at":"2015-08-31T18:17:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf33c18a72827cdb5ea7d0b8f7bc44320c1327d6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inaka/elvis/pulls/265/commits","review_comments_url":"https://api.github.com/repos/inaka/elvis/pulls/265/comments","review_comment_url":"https://api.github.com/repos/inaka/elvis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inaka/elvis/issues/265/comments","statuses_url":"https://api.github.com/repos/inaka/elvis/statuses/88b253739426d289126e9c537e9b0d8fa905871a","head":{"label":"inaka:jfacorro.263.max_function_length_opts","ref":"jfacorro.263.max_function_length_opts","sha":"88b253739426d289126e9c537e9b0d8fa905871a","user":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=3","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"repo":{"id":21137327,"name":"elvis","full_name":"inaka/elvis","owner":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=3","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inaka/elvis","description":"Erlang Style Reviewer","fork":false,"url":"https://api.github.com/repos/inaka/elvis","forks_url":"https://api.github.com/repos/inaka/elvis/forks","keys_url":"https://api.github.com/repos/inaka/elvis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inaka/elvis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inaka/elvis/teams","hooks_url":"https://api.github.com/repos/inaka/elvis/hooks","issue_events_url":"https://api.github.com/repos/inaka/elvis/issues/events{/number}","events_url":"https://api.github.com/repos/inaka/elvis/events","assignees_url":"https://api.github.com/repos/inaka/elvis/assignees{/user}","branches_url":"https://api.github.com/repos/inaka/elvis/branches{/branch}","tags_url":"https://api.github.com/repos/inaka/elvis/tags","blobs_url":"https://api.github.com/repos/inaka/elvis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inaka/elvis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inaka/elvis/git/refs{/sha}","trees_url":"https://api.github.com/repos/inaka/elvis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inaka/elvis/statuses/{sha}","languages_url":"https://api.github.com/repos/inaka/elvis/languages","stargazers_url":"https://api.github.com/repos/inaka/elvis/stargazers","contributors_url":"https://api.github.com/repos/inaka/elvis/contributors","subscribers_url":"https://api.github.com/repos/inaka/elvis/subscribers","subscription_url":"https://api.github.com/repos/inaka/elvis/subscription","commits_url":"https://api.github.com/repos/inaka/elvis/commits{/sha}","git_commits_url":"https://api.github.com/repos/inaka/elvis/git/commits{/sha}","comments_url":"https://api.github.com/repos/inaka/elvis/comments{/number}","issue_comment_url":"https://api.github.com/repos/inaka/elvis/issues/comments{/number}","contents_url":"https://api.github.com/repos/inaka/elvis/contents/{+path}","compare_url":"https://api.github.com/repos/inaka/elvis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inaka/elvis/merges","archive_url":"https://api.github.com/repos/inaka/elvis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inaka/elvis/downloads","issues_url":"https://api.github.com/repos/inaka/elvis/issues{/number}","pulls_url":"https://api.github.com/repos/inaka/elvis/pulls{/number}","milestones_url":"https://api.github.com/repos/inaka/elvis/milestones{/number}","notifications_url":"https://api.github.com/repos/inaka/elvis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inaka/elvis/labels{/name}","releases_url":"https://api.github.com/repos/inaka/elvis/releases{/id}","created_at":"2014-06-23T18:24:33Z","updated_at":"2015-08-27T17:02:08Z","pushed_at":"2015-08-31T18:17:18Z","git_url":"git://github.com/inaka/elvis.git","ssh_url":"git@github.com:inaka/elvis.git","clone_url":"https://github.com/inaka/elvis.git","svn_url":"https://github.com/inaka/elvis","homepage":"http://elvis.inakalabs.com","size":1761,"stargazers_count":134,"watchers_count":134,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":26,"forks":29,"open_issues":26,"watchers":134,"default_branch":"master"}},"base":{"label":"inaka:master","ref":"master","sha":"61a0798edbb183a972f8874668d4419acc6d2e3b","user":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=3","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"repo":{"id":21137327,"name":"elvis","full_name":"inaka/elvis","owner":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=3","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inaka/elvis","description":"Erlang Style Reviewer","fork":false,"url":"https://api.github.com/repos/inaka/elvis","forks_url":"https://api.github.com/repos/inaka/elvis/forks","keys_url":"https://api.github.com/repos/inaka/elvis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inaka/elvis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inaka/elvis/teams","hooks_url":"https://api.github.com/repos/inaka/elvis/hooks","issue_events_url":"https://api.github.com/repos/inaka/elvis/issues/events{/number}","events_url":"https://api.github.com/repos/inaka/elvis/events","assignees_url":"https://api.github.com/repos/inaka/elvis/assignees{/user}","branches_url":"https://api.github.com/repos/inaka/elvis/branches{/branch}","tags_url":"https://api.github.com/repos/inaka/elvis/tags","blobs_url":"https://api.github.com/repos/inaka/elvis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inaka/elvis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inaka/elvis/git/refs{/sha}","trees_url":"https://api.github.com/repos/inaka/elvis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inaka/elvis/statuses/{sha}","languages_url":"https://api.github.com/repos/inaka/elvis/languages","stargazers_url":"https://api.github.com/repos/inaka/elvis/stargazers","contributors_url":"https://api.github.com/repos/inaka/elvis/contributors","subscribers_url":"https://api.github.com/repos/inaka/elvis/subscribers","subscription_url":"https://api.github.com/repos/inaka/elvis/subscription","commits_url":"https://api.github.com/repos/inaka/elvis/commits{/sha}","git_commits_url":"https://api.github.com/repos/inaka/elvis/git/commits{/sha}","comments_url":"https://api.github.com/repos/inaka/elvis/comments{/number}","issue_comment_url":"https://api.github.com/repos/inaka/elvis/issues/comments{/number}","contents_url":"https://api.github.com/repos/inaka/elvis/contents/{+path}","compare_url":"https://api.github.com/repos/inaka/elvis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inaka/elvis/merges","archive_url":"https://api.github.com/repos/inaka/elvis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inaka/elvis/downloads","issues_url":"https://api.github.com/repos/inaka/elvis/issues{/number}","pulls_url":"https://api.github.com/repos/inaka/elvis/pulls{/number}","milestones_url":"https://api.github.com/repos/inaka/elvis/milestones{/number}","notifications_url":"https://api.github.com/repos/inaka/elvis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inaka/elvis/labels{/name}","releases_url":"https://api.github.com/repos/inaka/elvis/releases{/id}","created_at":"2014-06-23T18:24:33Z","updated_at":"2015-08-27T17:02:08Z","pushed_at":"2015-08-31T18:17:18Z","git_url":"git://github.com/inaka/elvis.git","ssh_url":"git@github.com:inaka/elvis.git","clone_url":"https://github.com/inaka/elvis.git","svn_url":"https://github.com/inaka/elvis","homepage":"http://elvis.inakalabs.com","size":1761,"stargazers_count":134,"watchers_count":134,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":26,"forks":29,"open_issues":26,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inaka/elvis/pulls/265"},"html":{"href":"https://github.com/inaka/elvis/pull/265"},"issue":{"href":"https://api.github.com/repos/inaka/elvis/issues/265"},"comments":{"href":"https://api.github.com/repos/inaka/elvis/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/inaka/elvis/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/inaka/elvis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inaka/elvis/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/inaka/elvis/statuses/88b253739426d289126e9c537e9b0d8fa905871a"}}}}