{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/39325494","id":39325494,"diff_hunk":"@@ -93,6 +109,10 @@ define(function (require) {\n     return err.stack;\n   }\n \n+  function infoAsObject(version, buildNum) {","path":"src/ui/public/notify/Notifier.js","position":34,"original_position":34,"commit_id":"3ec5587bc05d947b6db1396b75d3ce8fa8408fbc","original_commit_id":"3ec5587bc05d947b6db1396b75d3ce8fa8408fbc","user":{"login":"w33ble","id":404731,"avatar_url":"https://avatars.githubusercontent.com/u/404731?v=3","gravatar_id":"","url":"https://api.github.com/users/w33ble","html_url":"https://github.com/w33ble","followers_url":"https://api.github.com/users/w33ble/followers","following_url":"https://api.github.com/users/w33ble/following{/other_user}","gists_url":"https://api.github.com/users/w33ble/gists{/gist_id}","starred_url":"https://api.github.com/users/w33ble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w33ble/subscriptions","organizations_url":"https://api.github.com/users/w33ble/orgs","repos_url":"https://api.github.com/users/w33ble/repos","events_url":"https://api.github.com/users/w33ble/events{/privacy}","received_events_url":"https://api.github.com/users/w33ble/received_events","type":"User","site_admin":false},"body":"Is there a reason you have this defined as a helper, instead of just using `{ version, buildNum }` below?","created_at":"2015-09-11T22:38:43Z","updated_at":"2015-09-11T22:38:43Z","html_url":"https://github.com/elastic/kibana/pull/4914#discussion_r39325494","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/4914","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/39325494"},"html":{"href":"https://github.com/elastic/kibana/pull/4914#discussion_r39325494"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/4914"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/4914","id":44693761,"html_url":"https://github.com/elastic/kibana/pull/4914","diff_url":"https://github.com/elastic/kibana/pull/4914.diff","patch_url":"https://github.com/elastic/kibana/pull/4914.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/4914","number":4914,"state":"open","locked":false,"title":"Render version and build number in fatal errors","user":{"login":"epixa","id":53814,"avatar_url":"https://avatars.githubusercontent.com/u/53814?v=3","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},"body":"The version and build number are included in all notifications and are\r\nrendered to screen in the event of a fatal error.\r\n\r\n![screen shot 2015-09-10 at 1 16 54 pm](https://cloud.githubusercontent.com/assets/53814/9798937/3a696f5e-57d2-11e5-8b55-74f7a7d80bb8.png)\r\n\r\nVersion and build number will also be added to the notification objects\r\nthemselves in case we want to consume them programmatically or storing\r\nnotifications anywhere for future lookup.\r\n\r\nCloses #4899 ","created_at":"2015-09-10T17:08:53Z","updated_at":"2015-09-11T22:38:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d774c5eddc909e670d5983081ca2bfe7bca9f490","assignee":{"login":"w33ble","id":404731,"avatar_url":"https://avatars.githubusercontent.com/u/404731?v=3","gravatar_id":"","url":"https://api.github.com/users/w33ble","html_url":"https://github.com/w33ble","followers_url":"https://api.github.com/users/w33ble/followers","following_url":"https://api.github.com/users/w33ble/following{/other_user}","gists_url":"https://api.github.com/users/w33ble/gists{/gist_id}","starred_url":"https://api.github.com/users/w33ble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w33ble/subscriptions","organizations_url":"https://api.github.com/users/w33ble/orgs","repos_url":"https://api.github.com/users/w33ble/repos","events_url":"https://api.github.com/users/w33ble/events{/privacy}","received_events_url":"https://api.github.com/users/w33ble/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/4914/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/4914/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/4914/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/3ec5587bc05d947b6db1396b75d3ce8fa8408fbc","head":{"label":"epixa:4899-error-build","ref":"4899-error-build","sha":"3ec5587bc05d947b6db1396b75d3ce8fa8408fbc","user":{"login":"epixa","id":53814,"avatar_url":"https://avatars.githubusercontent.com/u/53814?v=3","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},"repo":{"id":42147349,"name":"kibana","full_name":"epixa/kibana","owner":{"login":"epixa","id":53814,"avatar_url":"https://avatars.githubusercontent.com/u/53814?v=3","gravatar_id":"","url":"https://api.github.com/users/epixa","html_url":"https://github.com/epixa","followers_url":"https://api.github.com/users/epixa/followers","following_url":"https://api.github.com/users/epixa/following{/other_user}","gists_url":"https://api.github.com/users/epixa/gists{/gist_id}","starred_url":"https://api.github.com/users/epixa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epixa/subscriptions","organizations_url":"https://api.github.com/users/epixa/orgs","repos_url":"https://api.github.com/users/epixa/repos","events_url":"https://api.github.com/users/epixa/events{/privacy}","received_events_url":"https://api.github.com/users/epixa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/epixa/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/epixa/kibana","forks_url":"https://api.github.com/repos/epixa/kibana/forks","keys_url":"https://api.github.com/repos/epixa/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epixa/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epixa/kibana/teams","hooks_url":"https://api.github.com/repos/epixa/kibana/hooks","issue_events_url":"https://api.github.com/repos/epixa/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/epixa/kibana/events","assignees_url":"https://api.github.com/repos/epixa/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/epixa/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/epixa/kibana/tags","blobs_url":"https://api.github.com/repos/epixa/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epixa/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epixa/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/epixa/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epixa/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/epixa/kibana/languages","stargazers_url":"https://api.github.com/repos/epixa/kibana/stargazers","contributors_url":"https://api.github.com/repos/epixa/kibana/contributors","subscribers_url":"https://api.github.com/repos/epixa/kibana/subscribers","subscription_url":"https://api.github.com/repos/epixa/kibana/subscription","commits_url":"https://api.github.com/repos/epixa/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/epixa/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/epixa/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/epixa/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/epixa/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/epixa/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epixa/kibana/merges","archive_url":"https://api.github.com/repos/epixa/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epixa/kibana/downloads","issues_url":"https://api.github.com/repos/epixa/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/epixa/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/epixa/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/epixa/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epixa/kibana/labels{/name}","releases_url":"https://api.github.com/repos/epixa/kibana/releases{/id}","created_at":"2015-09-09T00:54:59Z","updated_at":"2015-09-09T00:55:02Z","pushed_at":"2015-09-11T22:25:21Z","git_url":"git://github.com/epixa/kibana.git","ssh_url":"git@github.com:epixa/kibana.git","clone_url":"https://github.com/epixa/kibana.git","svn_url":"https://github.com/epixa/kibana","homepage":"https://www.elastic.co/products/kibana","size":62782,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"327f5898a79564123651f71fe71fb1a17477f977","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":"Kibana","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","created_at":"2013-01-26T04:00:59Z","updated_at":"2015-09-11T18:53:14Z","pushed_at":"2015-09-11T22:26:52Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":90136,"stargazers_count":4096,"watchers_count":4096,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1509,"mirror_url":null,"open_issues_count":640,"forks":1509,"open_issues":640,"watchers":4096,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/4914"},"html":{"href":"https://github.com/elastic/kibana/pull/4914"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/4914"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/4914/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/4914/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/4914/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/3ec5587bc05d947b6db1396b75d3ce8fa8408fbc"}}}}