{"action":"created","comment":{"url":"https://api.github.com/repos/yetu/oauth2-provider/pulls/comments/30794080","id":30794080,"diff_hunk":"@@ -37,15 +37,23 @@ var FormValidator = function(root) {\n \n   this.addInputValidation = function(inputId, validator) {\n     var onChange = function (input) {\n+      var inputValidationError = root.getElementById(input.id + 'ValidationError');\n       if (validator.isValid(input.value)) {\n+        inputValidationError.classList.add('display-none');\n         input.classList.add('valid');\n       } else {\n+        if(input.value.length>0){\n+          inputValidationError.classList.remove('display-none');\n+        }\n         input.classList.remove('valid');\n+\n       }\n     };\n     var input = document.getElementById(inputId);\n     input.addEventListener('change', onChange.bind(this, input));","path":"app/assets/javascripts/form-validator.js","position":17,"original_position":17,"commit_id":"1c20661d09b2eb65c0c6e91c83d3701943fe5215","original_commit_id":"e94dd0eb233d9c867719b123c9caaf90033c50b7","user":{"login":"ElliDy","id":3762504,"avatar_url":"https://avatars.githubusercontent.com/u/3762504?v=3","gravatar_id":"","url":"https://api.github.com/users/ElliDy","html_url":"https://github.com/ElliDy","followers_url":"https://api.github.com/users/ElliDy/followers","following_url":"https://api.github.com/users/ElliDy/following{/other_user}","gists_url":"https://api.github.com/users/ElliDy/gists{/gist_id}","starred_url":"https://api.github.com/users/ElliDy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElliDy/subscriptions","organizations_url":"https://api.github.com/users/ElliDy/orgs","repos_url":"https://api.github.com/users/ElliDy/repos","events_url":"https://api.github.com/users/ElliDy/events{/privacy}","received_events_url":"https://api.github.com/users/ElliDy/received_events","type":"User","site_admin":false},"body":"Probably for both as it is used. ;) What I do not like about target and so is, that you have to care about browser compatibilities. And so it is much clearer I find :)","created_at":"2015-05-21T11:44:45Z","updated_at":"2015-05-21T11:44:45Z","html_url":"https://github.com/yetu/oauth2-provider/pull/21#discussion_r30794080","pull_request_url":"https://api.github.com/repos/yetu/oauth2-provider/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/yetu/oauth2-provider/pulls/comments/30794080"},"html":{"href":"https://github.com/yetu/oauth2-provider/pull/21#discussion_r30794080"},"pull_request":{"href":"https://api.github.com/repos/yetu/oauth2-provider/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/yetu/oauth2-provider/pulls/21","id":35811708,"html_url":"https://github.com/yetu/oauth2-provider/pull/21","diff_url":"https://github.com/yetu/oauth2-provider/pull/21.diff","patch_url":"https://github.com/yetu/oauth2-provider/pull/21.patch","issue_url":"https://api.github.com/repos/yetu/oauth2-provider/issues/21","number":21,"state":"open","locked":false,"title":"Feature/final design","user":{"login":"ElliDy","id":3762504,"avatar_url":"https://avatars.githubusercontent.com/u/3762504?v=3","gravatar_id":"","url":"https://api.github.com/users/ElliDy","html_url":"https://github.com/ElliDy","followers_url":"https://api.github.com/users/ElliDy/followers","following_url":"https://api.github.com/users/ElliDy/following{/other_user}","gists_url":"https://api.github.com/users/ElliDy/gists{/gist_id}","starred_url":"https://api.github.com/users/ElliDy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElliDy/subscriptions","organizations_url":"https://api.github.com/users/ElliDy/orgs","repos_url":"https://api.github.com/users/ElliDy/repos","events_url":"https://api.github.com/users/ElliDy/events{/privacy}","received_events_url":"https://api.github.com/users/ElliDy/received_events","type":"User","site_admin":false},"body":"- improve design on all pages for registration to get final design\r\n- fix issue on frontend password validation (use passwordLengthValidator and remove passwordValidator)\r\n- add feedback text for two errors on frontend validation: invalid email and password do not match\r\n","created_at":"2015-05-20T09:12:53Z","updated_at":"2015-05-21T11:44:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaaceb7c4a1c871676287d08aa210837cd7c1bff","assignee":{"login":"DaQuirm","id":669784,"avatar_url":"https://avatars.githubusercontent.com/u/669784?v=3","gravatar_id":"","url":"https://api.github.com/users/DaQuirm","html_url":"https://github.com/DaQuirm","followers_url":"https://api.github.com/users/DaQuirm/followers","following_url":"https://api.github.com/users/DaQuirm/following{/other_user}","gists_url":"https://api.github.com/users/DaQuirm/gists{/gist_id}","starred_url":"https://api.github.com/users/DaQuirm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaQuirm/subscriptions","organizations_url":"https://api.github.com/users/DaQuirm/orgs","repos_url":"https://api.github.com/users/DaQuirm/repos","events_url":"https://api.github.com/users/DaQuirm/events{/privacy}","received_events_url":"https://api.github.com/users/DaQuirm/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/yetu/oauth2-provider/pulls/21/commits","review_comments_url":"https://api.github.com/repos/yetu/oauth2-provider/pulls/21/comments","review_comment_url":"https://api.github.com/repos/yetu/oauth2-provider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yetu/oauth2-provider/issues/21/comments","statuses_url":"https://api.github.com/repos/yetu/oauth2-provider/statuses/1c20661d09b2eb65c0c6e91c83d3701943fe5215","head":{"label":"yetu:feature/final-design","ref":"feature/final-design","sha":"1c20661d09b2eb65c0c6e91c83d3701943fe5215","user":{"login":"yetu","id":2630913,"avatar_url":"https://avatars.githubusercontent.com/u/2630913?v=3","gravatar_id":"","url":"https://api.github.com/users/yetu","html_url":"https://github.com/yetu","followers_url":"https://api.github.com/users/yetu/followers","following_url":"https://api.github.com/users/yetu/following{/other_user}","gists_url":"https://api.github.com/users/yetu/gists{/gist_id}","starred_url":"https://api.github.com/users/yetu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yetu/subscriptions","organizations_url":"https://api.github.com/users/yetu/orgs","repos_url":"https://api.github.com/users/yetu/repos","events_url":"https://api.github.com/users/yetu/events{/privacy}","received_events_url":"https://api.github.com/users/yetu/received_events","type":"Organization","site_admin":false},"repo":{"id":31723357,"name":"oauth2-provider","full_name":"yetu/oauth2-provider","owner":{"login":"yetu","id":2630913,"avatar_url":"https://avatars.githubusercontent.com/u/2630913?v=3","gravatar_id":"","url":"https://api.github.com/users/yetu","html_url":"https://github.com/yetu","followers_url":"https://api.github.com/users/yetu/followers","following_url":"https://api.github.com/users/yetu/following{/other_user}","gists_url":"https://api.github.com/users/yetu/gists{/gist_id}","starred_url":"https://api.github.com/users/yetu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yetu/subscriptions","organizations_url":"https://api.github.com/users/yetu/orgs","repos_url":"https://api.github.com/users/yetu/repos","events_url":"https://api.github.com/users/yetu/events{/privacy}","received_events_url":"https://api.github.com/users/yetu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yetu/oauth2-provider","description":"yetu's User Authentication and OAuth2 Authorization Provider ","fork":false,"url":"https://api.github.com/repos/yetu/oauth2-provider","forks_url":"https://api.github.com/repos/yetu/oauth2-provider/forks","keys_url":"https://api.github.com/repos/yetu/oauth2-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yetu/oauth2-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yetu/oauth2-provider/teams","hooks_url":"https://api.github.com/repos/yetu/oauth2-provider/hooks","issue_events_url":"https://api.github.com/repos/yetu/oauth2-provider/issues/events{/number}","events_url":"https://api.github.com/repos/yetu/oauth2-provider/events","assignees_url":"https://api.github.com/repos/yetu/oauth2-provider/assignees{/user}","branches_url":"https://api.github.com/repos/yetu/oauth2-provider/branches{/branch}","tags_url":"https://api.github.com/repos/yetu/oauth2-provider/tags","blobs_url":"https://api.github.com/repos/yetu/oauth2-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yetu/oauth2-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yetu/oauth2-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/yetu/oauth2-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yetu/oauth2-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/yetu/oauth2-provider/languages","stargazers_url":"https://api.github.com/repos/yetu/oauth2-provider/stargazers","contributors_url":"https://api.github.com/repos/yetu/oauth2-provider/contributors","subscribers_url":"https://api.github.com/repos/yetu/oauth2-provider/subscribers","subscription_url":"https://api.github.com/repos/yetu/oauth2-provider/subscription","commits_url":"https://api.github.com/repos/yetu/oauth2-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/yetu/oauth2-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/yetu/oauth2-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/yetu/oauth2-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/yetu/oauth2-provider/contents/{+path}","compare_url":"https://api.github.com/repos/yetu/oauth2-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yetu/oauth2-provider/merges","archive_url":"https://api.github.com/repos/yetu/oauth2-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yetu/oauth2-provider/downloads","issues_url":"https://api.github.com/repos/yetu/oauth2-provider/issues{/number}","pulls_url":"https://api.github.com/repos/yetu/oauth2-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/yetu/oauth2-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/yetu/oauth2-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yetu/oauth2-provider/labels{/name}","releases_url":"https://api.github.com/repos/yetu/oauth2-provider/releases{/id}","created_at":"2015-03-05T16:24:58Z","updated_at":"2015-04-28T15:15:12Z","pushed_at":"2015-05-21T11:42:48Z","git_url":"git://github.com/yetu/oauth2-provider.git","ssh_url":"git@github.com:yetu/oauth2-provider.git","clone_url":"https://github.com/yetu/oauth2-provider.git","svn_url":"https://github.com/yetu/oauth2-provider","homepage":"","size":3580,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"yetu:master","ref":"master","sha":"cb17c94091297cc27b102c6631b9be295adeacd2","user":{"login":"yetu","id":2630913,"avatar_url":"https://avatars.githubusercontent.com/u/2630913?v=3","gravatar_id":"","url":"https://api.github.com/users/yetu","html_url":"https://github.com/yetu","followers_url":"https://api.github.com/users/yetu/followers","following_url":"https://api.github.com/users/yetu/following{/other_user}","gists_url":"https://api.github.com/users/yetu/gists{/gist_id}","starred_url":"https://api.github.com/users/yetu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yetu/subscriptions","organizations_url":"https://api.github.com/users/yetu/orgs","repos_url":"https://api.github.com/users/yetu/repos","events_url":"https://api.github.com/users/yetu/events{/privacy}","received_events_url":"https://api.github.com/users/yetu/received_events","type":"Organization","site_admin":false},"repo":{"id":31723357,"name":"oauth2-provider","full_name":"yetu/oauth2-provider","owner":{"login":"yetu","id":2630913,"avatar_url":"https://avatars.githubusercontent.com/u/2630913?v=3","gravatar_id":"","url":"https://api.github.com/users/yetu","html_url":"https://github.com/yetu","followers_url":"https://api.github.com/users/yetu/followers","following_url":"https://api.github.com/users/yetu/following{/other_user}","gists_url":"https://api.github.com/users/yetu/gists{/gist_id}","starred_url":"https://api.github.com/users/yetu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yetu/subscriptions","organizations_url":"https://api.github.com/users/yetu/orgs","repos_url":"https://api.github.com/users/yetu/repos","events_url":"https://api.github.com/users/yetu/events{/privacy}","received_events_url":"https://api.github.com/users/yetu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yetu/oauth2-provider","description":"yetu's User Authentication and OAuth2 Authorization Provider ","fork":false,"url":"https://api.github.com/repos/yetu/oauth2-provider","forks_url":"https://api.github.com/repos/yetu/oauth2-provider/forks","keys_url":"https://api.github.com/repos/yetu/oauth2-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yetu/oauth2-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yetu/oauth2-provider/teams","hooks_url":"https://api.github.com/repos/yetu/oauth2-provider/hooks","issue_events_url":"https://api.github.com/repos/yetu/oauth2-provider/issues/events{/number}","events_url":"https://api.github.com/repos/yetu/oauth2-provider/events","assignees_url":"https://api.github.com/repos/yetu/oauth2-provider/assignees{/user}","branches_url":"https://api.github.com/repos/yetu/oauth2-provider/branches{/branch}","tags_url":"https://api.github.com/repos/yetu/oauth2-provider/tags","blobs_url":"https://api.github.com/repos/yetu/oauth2-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yetu/oauth2-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yetu/oauth2-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/yetu/oauth2-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yetu/oauth2-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/yetu/oauth2-provider/languages","stargazers_url":"https://api.github.com/repos/yetu/oauth2-provider/stargazers","contributors_url":"https://api.github.com/repos/yetu/oauth2-provider/contributors","subscribers_url":"https://api.github.com/repos/yetu/oauth2-provider/subscribers","subscription_url":"https://api.github.com/repos/yetu/oauth2-provider/subscription","commits_url":"https://api.github.com/repos/yetu/oauth2-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/yetu/oauth2-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/yetu/oauth2-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/yetu/oauth2-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/yetu/oauth2-provider/contents/{+path}","compare_url":"https://api.github.com/repos/yetu/oauth2-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yetu/oauth2-provider/merges","archive_url":"https://api.github.com/repos/yetu/oauth2-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yetu/oauth2-provider/downloads","issues_url":"https://api.github.com/repos/yetu/oauth2-provider/issues{/number}","pulls_url":"https://api.github.com/repos/yetu/oauth2-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/yetu/oauth2-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/yetu/oauth2-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yetu/oauth2-provider/labels{/name}","releases_url":"https://api.github.com/repos/yetu/oauth2-provider/releases{/id}","created_at":"2015-03-05T16:24:58Z","updated_at":"2015-04-28T15:15:12Z","pushed_at":"2015-05-21T11:42:48Z","git_url":"git://github.com/yetu/oauth2-provider.git","ssh_url":"git@github.com:yetu/oauth2-provider.git","clone_url":"https://github.com/yetu/oauth2-provider.git","svn_url":"https://github.com/yetu/oauth2-provider","homepage":"","size":3580,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yetu/oauth2-provider/pulls/21"},"html":{"href":"https://github.com/yetu/oauth2-provider/pull/21"},"issue":{"href":"https://api.github.com/repos/yetu/oauth2-provider/issues/21"},"comments":{"href":"https://api.github.com/repos/yetu/oauth2-provider/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/yetu/oauth2-provider/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/yetu/oauth2-provider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yetu/oauth2-provider/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/yetu/oauth2-provider/statuses/1c20661d09b2eb65c0c6e91c83d3701943fe5215"}}}}