{"action":"created","issue":{"url":"https://api.github.com/repos/ether/etherpad-lite/issues/2302","labels_url":"https://api.github.com/repos/ether/etherpad-lite/issues/2302/labels{/name}","comments_url":"https://api.github.com/repos/ether/etherpad-lite/issues/2302/comments","events_url":"https://api.github.com/repos/ether/etherpad-lite/issues/2302/events","html_url":"https://github.com/ether/etherpad-lite/pull/2302","id":48170612,"number":2302,"title":"Add check for special url characters to createPad API function","user":{"login":"Gared","id":913630,"avatar_url":"https://avatars.githubusercontent.com/u/913630?v=3","gravatar_id":"","url":"https://api.github.com/users/Gared","html_url":"https://github.com/Gared","followers_url":"https://api.github.com/users/Gared/followers","following_url":"https://api.github.com/users/Gared/following{/other_user}","gists_url":"https://api.github.com/users/Gared/gists{/gist_id}","starred_url":"https://api.github.com/users/Gared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gared/subscriptions","organizations_url":"https://api.github.com/users/Gared/orgs","repos_url":"https://api.github.com/users/Gared/repos","events_url":"https://api.github.com/users/Gared/events{/privacy}","received_events_url":"https://api.github.com/users/Gared/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ether/etherpad-lite/labels/Waiting%20on%20Testing","name":"Waiting on Testing","color":"FE9400"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-11-08T16:34:55Z","updated_at":"2015-03-31T22:23:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ether/etherpad-lite/pulls/2302","html_url":"https://github.com/ether/etherpad-lite/pull/2302","diff_url":"https://github.com/ether/etherpad-lite/pull/2302.diff","patch_url":"https://github.com/ether/etherpad-lite/pull/2302.patch"},"body":"This will add a check to forbid special url characters (like /, ?, & and #) on the createPad API function.\r\nThis is only a small improvement, because it doesn't fix the whole bug reported in #2287\r\nCharacters like ':' are sanitized by the function padManager.sanitizePadId in APIHandler.js line 414. We should move this function inside the createPad method so we could give back an error if the sanitizedPadId is not equal with the original padId. Is there any reason why every API call with a padId uses this function?"},"comment":{"url":"https://api.github.com/repos/ether/etherpad-lite/issues/comments/88270536","html_url":"https://github.com/ether/etherpad-lite/pull/2302#issuecomment-88270536","issue_url":"https://api.github.com/repos/ether/etherpad-lite/issues/2302","id":88270536,"user":{"login":"JohnMcLear","id":220864,"avatar_url":"https://avatars.githubusercontent.com/u/220864?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnMcLear","html_url":"https://github.com/JohnMcLear","followers_url":"https://api.github.com/users/JohnMcLear/followers","following_url":"https://api.github.com/users/JohnMcLear/following{/other_user}","gists_url":"https://api.github.com/users/JohnMcLear/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnMcLear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnMcLear/subscriptions","organizations_url":"https://api.github.com/users/JohnMcLear/orgs","repos_url":"https://api.github.com/users/JohnMcLear/repos","events_url":"https://api.github.com/users/JohnMcLear/events{/privacy}","received_events_url":"https://api.github.com/users/JohnMcLear/received_events","type":"User","site_admin":false},"created_at":"2015-03-31T22:23:45Z","updated_at":"2015-03-31T22:23:45Z","body":"Bump @marcelklehr "}}