{"action":"created","comment":{"url":"https://api.github.com/repos/meejah/txtorcon/pulls/comments/34416727","id":34416727,"diff_hunk":"@@ -118,6 +121,46 @@ def test_with_arg(self):\n         self.send(\"250 OK\")\n         yield d\n \n+        # Now test that Stem's RelayDescriptor class is used\n+        self.protocol.use_stem = True\n+        d = info.desc.name('moria1')\n+        self.send(\"\"\"250-desc/name/moria1=\n+router moria1 128.31.0.34 9101 0 9131\n+platform Tor 0.2.5.0-alpha-dev on Linux\n+protocols Link 1 2 Circuit 1\n+published 2013-07-05 23:48:52\n+fingerprint 9695 DFC3 5FFE B861 329B 9F1A B04C 4639 7020 CE31\n+uptime 1818933\n+bandwidth 512000 62914560 1307929\n+extra-info-digest 17D0142F6EBCDF60160EB1794FA6C9717D581F8C\n+caches-extra-info\n+onion-key\n+-----BEGIN RSA PUBLIC KEY-----\n+MIGJAoGBALzd4bhz1usB7wpoaAvP+BBOnNIk7mByAKV6zvyQ0p1M09oEmxPMc3qD\n+AAm276oJNf0eq6KWC6YprzPWFsXEIdXSqA6RWXCII1JG/jOoy6nt478BkB8TS9I9\n+1MJW27ppRaqnLiTmBmM+qzrsgJGwf+onAgUKKH2GxlVgahqz8x6xAgMBAAE=\n+-----END RSA PUBLIC KEY-----\n+signing-key\n+-----BEGIN RSA PUBLIC KEY-----\n+MIGJAoGBALtJ9uD7cD7iHjqNA3AgsX9prES5QN+yFQyr2uOkxzhvunnaf6SNhzWW\n+bkfylnMrRm/qCz/czcjZO6N6EKHcXmypehvP566B7gAQ9vDsb+l7VZVWgXvzNc2s\n+tl3P7qpC08rgyJh1GqmtQTCesIDqkEyWxwToympCt09ZQRq+fIttAgMBAAE=\n+-----END RSA PUBLIC KEY-----\n+hidden-service-dir\n+contact 1024D/28988BF5 arma mit edu\n+ntor-onion-key 9ZVjNkf/iLEnD685SpC5kcDytQ7u5ViiI9JOftdbE0k=\n+reject *:*\n+router-signature\n+-----BEGIN SIGNATURE-----\n+Y8Tj2e7mPbFJbguulkPEBVYzyO57p4btpWEXvRMD6vxIh/eyn25pehg5dUVBtZlL\n+iO3EUE0AEYah2W9gdz8t+i3Dtr0zgqLS841GC/TyDKCm+MKmN8d098qnwK0NGF9q\n+01NZPuSqXM1b6hnl2espFzL7XL8XEGRU+aeg+f/ukw4=\n+-----END SIGNATURE-----\n+.\"\"\")\n+        self.send(\"250 OK\")\n+        descriptor_info = yield d\n+        self.assertEqual(type(descriptor_info).__name__, 'RelayDescriptor')\n+\n ","path":"test/test_torinfo.py","position":61,"original_position":61,"commit_id":"9303fc0f4660ea6af3fe0ec5f8aca460d00c32fd","original_commit_id":"9303fc0f4660ea6af3fe0ec5f8aca460d00c32fd","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"body":"Should usually use isinstance instead of comparing types","created_at":"2015-07-11T22:08:57Z","updated_at":"2015-07-11T22:08:57Z","html_url":"https://github.com/meejah/txtorcon/pull/121#discussion_r34416727","pull_request_url":"https://api.github.com/repos/meejah/txtorcon/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/meejah/txtorcon/pulls/comments/34416727"},"html":{"href":"https://github.com/meejah/txtorcon/pull/121#discussion_r34416727"},"pull_request":{"href":"https://api.github.com/repos/meejah/txtorcon/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/meejah/txtorcon/pulls/121","id":38757230,"html_url":"https://github.com/meejah/txtorcon/pull/121","diff_url":"https://github.com/meejah/txtorcon/pull/121.diff","patch_url":"https://github.com/meejah/txtorcon/pull/121.patch","issue_url":"https://api.github.com/repos/meejah/txtorcon/issues/121","number":121,"state":"open","locked":false,"title":"Implemented _get_descriptor() method","user":{"login":"sammyshj","id":4390022,"avatar_url":"https://avatars.githubusercontent.com/u/4390022?v=3","gravatar_id":"","url":"https://api.github.com/users/sammyshj","html_url":"https://github.com/sammyshj","followers_url":"https://api.github.com/users/sammyshj/followers","following_url":"https://api.github.com/users/sammyshj/following{/other_user}","gists_url":"https://api.github.com/users/sammyshj/gists{/gist_id}","starred_url":"https://api.github.com/users/sammyshj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammyshj/subscriptions","organizations_url":"https://api.github.com/users/sammyshj/orgs","repos_url":"https://api.github.com/users/sammyshj/repos","events_url":"https://api.github.com/users/sammyshj/events{/privacy}","received_events_url":"https://api.github.com/users/sammyshj/received_events","type":"User","site_admin":false},"body":"Implemented _get_descriptor() method\r\nThe parameters for the method are, `nickname`, `fingerprint`. These are the relay's nickname/fingerprint for which we want the descriptor information.\r\nReturns the descriptor information. If use_stem is set to True, a `stem.descriptor.server_descriptor.RelayDescriptor` object is returned with the descriptor information.","created_at":"2015-06-29T09:50:14Z","updated_at":"2015-07-11T22:08:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1baecf2f868abdd15a718e795090198c56711916","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/meejah/txtorcon/pulls/121/commits","review_comments_url":"https://api.github.com/repos/meejah/txtorcon/pulls/121/comments","review_comment_url":"https://api.github.com/repos/meejah/txtorcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meejah/txtorcon/issues/121/comments","statuses_url":"https://api.github.com/repos/meejah/txtorcon/statuses/9303fc0f4660ea6af3fe0ec5f8aca460d00c32fd","head":{"label":"sammyshj:optional-stem","ref":"optional-stem","sha":"9303fc0f4660ea6af3fe0ec5f8aca460d00c32fd","user":{"login":"sammyshj","id":4390022,"avatar_url":"https://avatars.githubusercontent.com/u/4390022?v=3","gravatar_id":"","url":"https://api.github.com/users/sammyshj","html_url":"https://github.com/sammyshj","followers_url":"https://api.github.com/users/sammyshj/followers","following_url":"https://api.github.com/users/sammyshj/following{/other_user}","gists_url":"https://api.github.com/users/sammyshj/gists{/gist_id}","starred_url":"https://api.github.com/users/sammyshj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammyshj/subscriptions","organizations_url":"https://api.github.com/users/sammyshj/orgs","repos_url":"https://api.github.com/users/sammyshj/repos","events_url":"https://api.github.com/users/sammyshj/events{/privacy}","received_events_url":"https://api.github.com/users/sammyshj/received_events","type":"User","site_admin":false},"repo":{"id":28791666,"name":"txtorcon","full_name":"sammyshj/txtorcon","owner":{"login":"sammyshj","id":4390022,"avatar_url":"https://avatars.githubusercontent.com/u/4390022?v=3","gravatar_id":"","url":"https://api.github.com/users/sammyshj","html_url":"https://github.com/sammyshj","followers_url":"https://api.github.com/users/sammyshj/followers","following_url":"https://api.github.com/users/sammyshj/following{/other_user}","gists_url":"https://api.github.com/users/sammyshj/gists{/gist_id}","starred_url":"https://api.github.com/users/sammyshj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammyshj/subscriptions","organizations_url":"https://api.github.com/users/sammyshj/orgs","repos_url":"https://api.github.com/users/sammyshj/repos","events_url":"https://api.github.com/users/sammyshj/events{/privacy}","received_events_url":"https://api.github.com/users/sammyshj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sammyshj/txtorcon","description":"Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.","fork":true,"url":"https://api.github.com/repos/sammyshj/txtorcon","forks_url":"https://api.github.com/repos/sammyshj/txtorcon/forks","keys_url":"https://api.github.com/repos/sammyshj/txtorcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sammyshj/txtorcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sammyshj/txtorcon/teams","hooks_url":"https://api.github.com/repos/sammyshj/txtorcon/hooks","issue_events_url":"https://api.github.com/repos/sammyshj/txtorcon/issues/events{/number}","events_url":"https://api.github.com/repos/sammyshj/txtorcon/events","assignees_url":"https://api.github.com/repos/sammyshj/txtorcon/assignees{/user}","branches_url":"https://api.github.com/repos/sammyshj/txtorcon/branches{/branch}","tags_url":"https://api.github.com/repos/sammyshj/txtorcon/tags","blobs_url":"https://api.github.com/repos/sammyshj/txtorcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sammyshj/txtorcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sammyshj/txtorcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/sammyshj/txtorcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sammyshj/txtorcon/statuses/{sha}","languages_url":"https://api.github.com/repos/sammyshj/txtorcon/languages","stargazers_url":"https://api.github.com/repos/sammyshj/txtorcon/stargazers","contributors_url":"https://api.github.com/repos/sammyshj/txtorcon/contributors","subscribers_url":"https://api.github.com/repos/sammyshj/txtorcon/subscribers","subscription_url":"https://api.github.com/repos/sammyshj/txtorcon/subscription","commits_url":"https://api.github.com/repos/sammyshj/txtorcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/sammyshj/txtorcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/sammyshj/txtorcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/sammyshj/txtorcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/sammyshj/txtorcon/contents/{+path}","compare_url":"https://api.github.com/repos/sammyshj/txtorcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sammyshj/txtorcon/merges","archive_url":"https://api.github.com/repos/sammyshj/txtorcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sammyshj/txtorcon/downloads","issues_url":"https://api.github.com/repos/sammyshj/txtorcon/issues{/number}","pulls_url":"https://api.github.com/repos/sammyshj/txtorcon/pulls{/number}","milestones_url":"https://api.github.com/repos/sammyshj/txtorcon/milestones{/number}","notifications_url":"https://api.github.com/repos/sammyshj/txtorcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sammyshj/txtorcon/labels{/name}","releases_url":"https://api.github.com/repos/sammyshj/txtorcon/releases{/id}","created_at":"2015-01-05T01:10:57Z","updated_at":"2015-04-02T08:21:22Z","pushed_at":"2015-07-11T03:13:41Z","git_url":"git://github.com/sammyshj/txtorcon.git","ssh_url":"git@github.com:sammyshj/txtorcon.git","clone_url":"https://github.com/sammyshj/txtorcon.git","svn_url":"https://github.com/sammyshj/txtorcon","homepage":"http://timaq4ygg2iegci7.onion/","size":1828,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"meejah:optional-stem","ref":"optional-stem","sha":"3230961e553a9e0419c304ed9c87f1c258d61fb8","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"repo":{"id":3852351,"name":"txtorcon","full_name":"meejah/txtorcon","owner":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meejah/txtorcon","description":"Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.","fork":false,"url":"https://api.github.com/repos/meejah/txtorcon","forks_url":"https://api.github.com/repos/meejah/txtorcon/forks","keys_url":"https://api.github.com/repos/meejah/txtorcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meejah/txtorcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meejah/txtorcon/teams","hooks_url":"https://api.github.com/repos/meejah/txtorcon/hooks","issue_events_url":"https://api.github.com/repos/meejah/txtorcon/issues/events{/number}","events_url":"https://api.github.com/repos/meejah/txtorcon/events","assignees_url":"https://api.github.com/repos/meejah/txtorcon/assignees{/user}","branches_url":"https://api.github.com/repos/meejah/txtorcon/branches{/branch}","tags_url":"https://api.github.com/repos/meejah/txtorcon/tags","blobs_url":"https://api.github.com/repos/meejah/txtorcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meejah/txtorcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meejah/txtorcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/meejah/txtorcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meejah/txtorcon/statuses/{sha}","languages_url":"https://api.github.com/repos/meejah/txtorcon/languages","stargazers_url":"https://api.github.com/repos/meejah/txtorcon/stargazers","contributors_url":"https://api.github.com/repos/meejah/txtorcon/contributors","subscribers_url":"https://api.github.com/repos/meejah/txtorcon/subscribers","subscription_url":"https://api.github.com/repos/meejah/txtorcon/subscription","commits_url":"https://api.github.com/repos/meejah/txtorcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/meejah/txtorcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/meejah/txtorcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/meejah/txtorcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/meejah/txtorcon/contents/{+path}","compare_url":"https://api.github.com/repos/meejah/txtorcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meejah/txtorcon/merges","archive_url":"https://api.github.com/repos/meejah/txtorcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meejah/txtorcon/downloads","issues_url":"https://api.github.com/repos/meejah/txtorcon/issues{/number}","pulls_url":"https://api.github.com/repos/meejah/txtorcon/pulls{/number}","milestones_url":"https://api.github.com/repos/meejah/txtorcon/milestones{/number}","notifications_url":"https://api.github.com/repos/meejah/txtorcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meejah/txtorcon/labels{/name}","releases_url":"https://api.github.com/repos/meejah/txtorcon/releases{/id}","created_at":"2012-03-28T06:51:27Z","updated_at":"2015-07-07T01:52:01Z","pushed_at":"2015-07-11T03:13:41Z","git_url":"git://github.com/meejah/txtorcon.git","ssh_url":"git@github.com:meejah/txtorcon.git","clone_url":"https://github.com/meejah/txtorcon.git","svn_url":"https://github.com/meejah/txtorcon","homepage":"http://timaq4ygg2iegci7.onion/","size":2711,"stargazers_count":85,"watchers_count":85,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":19,"forks":24,"open_issues":19,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meejah/txtorcon/pulls/121"},"html":{"href":"https://github.com/meejah/txtorcon/pull/121"},"issue":{"href":"https://api.github.com/repos/meejah/txtorcon/issues/121"},"comments":{"href":"https://api.github.com/repos/meejah/txtorcon/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/meejah/txtorcon/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/meejah/txtorcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meejah/txtorcon/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/meejah/txtorcon/statuses/9303fc0f4660ea6af3fe0ec5f8aca460d00c32fd"}}}}