{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/23803727","id":23803727,"diff_hunk":"@@ -2507,26 +2334,35 @@ private template hasRawAliasing(T...)\n     enum hasRawAliasing = Impl!(RepresentationTypeTuple!T);\n }\n \n+///\n unittest\n {\n     // simple types\n     static assert(!hasRawAliasing!int);\n     static assert( hasRawAliasing!(char*));\n-\n     // references aren't raw pointers\n     static assert(!hasRawAliasing!Object);\n-    static assert(!hasRawAliasing!int);\n-\n-    struct S1 { int  z; }\n-    struct S2 { int* z; }\n+    // built-in arrays do contain raw pointers\n+    static assert( hasRawAliasing!(int[]));\n+    // aggregate of simple types\n+    struct S1 { int a; double b; }\n     static assert(!hasRawAliasing!S1);\n-    static assert( hasRawAliasing!S2);\n+    // indirect aggregation\n+    struct S2 { S1 a; double b; }\n+    static assert(!hasRawAliasing!S2);\n+}\n \n-    struct S3 { int a; int*   z; int c; }\n-    struct S4 { int a; int    z; int c; }\n+unittest\n+{\n+    // struct with a pointer member\n+    struct S3 { int a; double * b; }\n+    static assert( hasRawAliasing!S3);\n+    // struct with an indirect pointer member\n+    struct S4 { S3 a; double b; }\n+    static assert( hasRawAliasing!S4);\n     struct S5 { int a; Object z; int c; }\n     static assert( hasRawAliasing!S3);\n-    static assert(!hasRawAliasing!S4);\n+    static assert( hasRawAliasing!S4);","path":"std/traits.d","position":710,"original_position":710,"commit_id":"919c4ecd7b468af26cf637a47a4e509b5eb89a32","original_commit_id":"919c4ecd7b468af26cf637a47a4e509b5eb89a32","user":{"login":"quickfur","id":405446,"avatar_url":"https://avatars.githubusercontent.com/u/405446?v=3","gravatar_id":"","url":"https://api.github.com/users/quickfur","html_url":"https://github.com/quickfur","followers_url":"https://api.github.com/users/quickfur/followers","following_url":"https://api.github.com/users/quickfur/following{/other_user}","gists_url":"https://api.github.com/users/quickfur/gists{/gist_id}","starred_url":"https://api.github.com/users/quickfur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quickfur/subscriptions","organizations_url":"https://api.github.com/users/quickfur/orgs","repos_url":"https://api.github.com/users/quickfur/repos","events_url":"https://api.github.com/users/quickfur/events{/privacy}","received_events_url":"https://api.github.com/users/quickfur/received_events","type":"User","site_admin":false},"body":"Nice catch!","created_at":"2015-01-29T21:22:49Z","updated_at":"2015-01-29T21:22:49Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/2929#discussion_r23803727","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2929","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/23803727"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2929#discussion_r23803727"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2929"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2929","id":28314398,"html_url":"https://github.com/D-Programming-Language/phobos/pull/2929","diff_url":"https://github.com/D-Programming-Language/phobos/pull/2929.diff","patch_url":"https://github.com/D-Programming-Language/phobos/pull/2929.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2929","number":2929,"state":"open","locked":false,"title":"std.traits documentation update","user":{"login":"burner","id":13327,"avatar_url":"https://avatars.githubusercontent.com/u/13327?v=3","gravatar_id":"","url":"https://api.github.com/users/burner","html_url":"https://github.com/burner","followers_url":"https://api.github.com/users/burner/followers","following_url":"https://api.github.com/users/burner/following{/other_user}","gists_url":"https://api.github.com/users/burner/gists{/gist_id}","starred_url":"https://api.github.com/users/burner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burner/subscriptions","organizations_url":"https://api.github.com/users/burner/orgs","repos_url":"https://api.github.com/users/burner/repos","events_url":"https://api.github.com/users/burner/events{/privacy}","received_events_url":"https://api.github.com/users/burner/received_events","type":"User","site_admin":false},"body":"* moved nearly all examples from comments to unittests\r\n** some few had error\r\n* marked existing unittest as examples\r\n** splitted some in the process as they where to long\r\n* ditto for one pair of templates with the same name\r\n* deleted unused code from 2008","created_at":"2015-01-29T21:03:29Z","updated_at":"2015-01-29T21:22:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fae03f5aadc4aabcbc2ae0b691857781ed95718","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2929/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2929/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2929/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/919c4ecd7b468af26cf637a47a4e509b5eb89a32","head":{"label":"burner:traits_documentation_update","ref":"traits_documentation_update","sha":"919c4ecd7b468af26cf637a47a4e509b5eb89a32","user":{"login":"burner","id":13327,"avatar_url":"https://avatars.githubusercontent.com/u/13327?v=3","gravatar_id":"","url":"https://api.github.com/users/burner","html_url":"https://github.com/burner","followers_url":"https://api.github.com/users/burner/followers","following_url":"https://api.github.com/users/burner/following{/other_user}","gists_url":"https://api.github.com/users/burner/gists{/gist_id}","starred_url":"https://api.github.com/users/burner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burner/subscriptions","organizations_url":"https://api.github.com/users/burner/orgs","repos_url":"https://api.github.com/users/burner/repos","events_url":"https://api.github.com/users/burner/events{/privacy}","received_events_url":"https://api.github.com/users/burner/received_events","type":"User","site_admin":false},"repo":{"id":7882025,"name":"phobos","full_name":"burner/phobos","owner":{"login":"burner","id":13327,"avatar_url":"https://avatars.githubusercontent.com/u/13327?v=3","gravatar_id":"","url":"https://api.github.com/users/burner","html_url":"https://github.com/burner","followers_url":"https://api.github.com/users/burner/followers","following_url":"https://api.github.com/users/burner/following{/other_user}","gists_url":"https://api.github.com/users/burner/gists{/gist_id}","starred_url":"https://api.github.com/users/burner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burner/subscriptions","organizations_url":"https://api.github.com/users/burner/orgs","repos_url":"https://api.github.com/users/burner/repos","events_url":"https://api.github.com/users/burner/events{/privacy}","received_events_url":"https://api.github.com/users/burner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/burner/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/burner/phobos","forks_url":"https://api.github.com/repos/burner/phobos/forks","keys_url":"https://api.github.com/repos/burner/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burner/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burner/phobos/teams","hooks_url":"https://api.github.com/repos/burner/phobos/hooks","issue_events_url":"https://api.github.com/repos/burner/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/burner/phobos/events","assignees_url":"https://api.github.com/repos/burner/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/burner/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/burner/phobos/tags","blobs_url":"https://api.github.com/repos/burner/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burner/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burner/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/burner/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burner/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/burner/phobos/languages","stargazers_url":"https://api.github.com/repos/burner/phobos/stargazers","contributors_url":"https://api.github.com/repos/burner/phobos/contributors","subscribers_url":"https://api.github.com/repos/burner/phobos/subscribers","subscription_url":"https://api.github.com/repos/burner/phobos/subscription","commits_url":"https://api.github.com/repos/burner/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/burner/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/burner/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/burner/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/burner/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/burner/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burner/phobos/merges","archive_url":"https://api.github.com/repos/burner/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burner/phobos/downloads","issues_url":"https://api.github.com/repos/burner/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/burner/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/burner/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/burner/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burner/phobos/labels{/name}","releases_url":"https://api.github.com/repos/burner/phobos/releases{/id}","created_at":"2013-01-29T00:26:08Z","updated_at":"2014-08-13T09:47:42Z","pushed_at":"2015-01-29T21:14:42Z","git_url":"git://github.com/burner/phobos.git","ssh_url":"git@github.com:burner/phobos.git","clone_url":"https://github.com/burner/phobos.git","svn_url":"https://github.com/burner/phobos","homepage":"dlang.org/phobos","size":39578,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"dfbd50636cd680b7e34da2284f18f955e25e4af8","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"D-Programming-Language/phobos","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/phobos","forks_url":"https://api.github.com/repos/D-Programming-Language/phobos/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/phobos/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/phobos/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/phobos/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/phobos/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/phobos/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/phobos/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/phobos/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/phobos/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/phobos/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/phobos/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/phobos/releases{/id}","created_at":"2011-01-15T07:00:06Z","updated_at":"2015-01-29T19:27:31Z","pushed_at":"2015-01-29T19:27:30Z","git_url":"git://github.com/D-Programming-Language/phobos.git","ssh_url":"git@github.com:D-Programming-Language/phobos.git","clone_url":"https://github.com/D-Programming-Language/phobos.git","svn_url":"https://github.com/D-Programming-Language/phobos","homepage":"dlang.org/phobos","size":65319,"stargazers_count":559,"watchers_count":559,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":371,"mirror_url":null,"open_issues_count":36,"forks":371,"open_issues":36,"watchers":559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2929"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/2929"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2929"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/issues/2929/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2929/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/2929/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/statuses/919c4ecd7b468af26cf637a47a4e509b5eb89a32"}}}}