{"action":"created","issue":{"url":"https://api.github.com/repos/openseadragon/svg-overlay/issues/9","labels_url":"https://api.github.com/repos/openseadragon/svg-overlay/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/openseadragon/svg-overlay/issues/9/comments","events_url":"https://api.github.com/repos/openseadragon/svg-overlay/issues/9/events","html_url":"https://github.com/openseadragon/svg-overlay/issues/9","id":104515541,"number":9,"title":"Overlay off when OSD viewport margins set?","user":{"login":"friarpat","id":12615936,"avatar_url":"https://avatars.githubusercontent.com/u/12615936?v=3","gravatar_id":"","url":"https://api.github.com/users/friarpat","html_url":"https://github.com/friarpat","followers_url":"https://api.github.com/users/friarpat/followers","following_url":"https://api.github.com/users/friarpat/following{/other_user}","gists_url":"https://api.github.com/users/friarpat/gists{/gist_id}","starred_url":"https://api.github.com/users/friarpat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friarpat/subscriptions","organizations_url":"https://api.github.com/users/friarpat/orgs","repos_url":"https://api.github.com/users/friarpat/repos","events_url":"https://api.github.com/users/friarpat/events{/privacy}","received_events_url":"https://api.github.com/users/friarpat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-02T16:02:47Z","updated_at":"2015-09-02T16:09:56Z","closed_at":null,"body":"Not certain if this applies to svg-overlay or OpenSeaDragon.\r\n\r\nI'm using svg-overlay to provide a border around the currently hovered image.   All was working well, but I noticed the border was slightly hidden on the left of images (and on the right of images) when I hit the home button on OSD.  I set the viewportMargins option on the OSD viewer to have a left and right margin of 2.   Border now shows properly in the X direction, but the Y is too \"low\".   In Firebug, I can adjust the y parameter of the  \"g transform=\"translate(x, y) scale(blah) element to raise the border to the right location.  I can also take the other route of reducing the Y of the rectangle that is a child of the \"g\" element.  The outline has the correct width/height - it's just misplaced in the Y direction.\r\n\r\n I see there is a getBoundsWithMargins for the OSD viewport, but not for the tiledImage.  I'm using the tiledImage.getBounds call to get the size of the border along with the x/y to get the top/left of the rectangle.  \r\n\r\nDo I need to do something with the svg-overlay to fix this, or do I need to do something on the OSD side to account for the margins?   There is probably some calculation I can perform to get the correct Y coordinate when using margins - but I'm not seeing it.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/openseadragon/svg-overlay/issues/comments/137146887","html_url":"https://github.com/openseadragon/svg-overlay/issues/9#issuecomment-137146887","issue_url":"https://api.github.com/repos/openseadragon/svg-overlay/issues/9","id":137146887,"user":{"login":"friarpat","id":12615936,"avatar_url":"https://avatars.githubusercontent.com/u/12615936?v=3","gravatar_id":"","url":"https://api.github.com/users/friarpat","html_url":"https://github.com/friarpat","followers_url":"https://api.github.com/users/friarpat/followers","following_url":"https://api.github.com/users/friarpat/following{/other_user}","gists_url":"https://api.github.com/users/friarpat/gists{/gist_id}","starred_url":"https://api.github.com/users/friarpat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friarpat/subscriptions","organizations_url":"https://api.github.com/users/friarpat/orgs","repos_url":"https://api.github.com/users/friarpat/repos","events_url":"https://api.github.com/users/friarpat/events{/privacy}","received_events_url":"https://api.github.com/users/friarpat/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T16:09:56Z","updated_at":"2015-09-02T16:09:56Z","body":"My bad - I should have looked at the right side of things when I Home view and left/right margins defined.  On the right side, the overlay is off in both the x and y directions...left is off just in the Y direction (most likely because X is 0)"}}