{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/45540486","id":45540486,"diff_hunk":"@@ -98,7 +98,10 @@ class QExpr(Expr):\n \n     @property\n     def free_symbols(self):\n-        return set([self])\n+        fsyms = []","path":"sympy/physics/quantum/qexpr.py","position":5,"original_position":5,"commit_id":"47e5b38c3e9daf8915b4433ef2c1f3cd43369f57","original_commit_id":"47e5b38c3e9daf8915b4433ef2c1f3cd43369f57","user":{"login":"zanzibar7","id":2191670,"avatar_url":"https://avatars.githubusercontent.com/u/2191670?v=3","gravatar_id":"","url":"https://api.github.com/users/zanzibar7","html_url":"https://github.com/zanzibar7","followers_url":"https://api.github.com/users/zanzibar7/followers","following_url":"https://api.github.com/users/zanzibar7/following{/other_user}","gists_url":"https://api.github.com/users/zanzibar7/gists{/gist_id}","starred_url":"https://api.github.com/users/zanzibar7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanzibar7/subscriptions","organizations_url":"https://api.github.com/users/zanzibar7/orgs","repos_url":"https://api.github.com/users/zanzibar7/repos","events_url":"https://api.github.com/users/zanzibar7/events{/privacy}","received_events_url":"https://api.github.com/users/zanzibar7/received_events","type":"User","site_admin":false},"body":"These changes were needed for test_spins to pass without errors.  `canonical_variables` in `Basic` makes use of the `.name` property for all free variables.  However, QExpr creates compound 'free' variables that \r\nhave no simple names, and thus are not canonized.  `canonical_variables` are needed for hashing\r\nsums or integrals.  I don't know enough about the quantum files to generate a good solution to this problem.  I hope somebody can help out.","created_at":"2015-11-21T03:02:38Z","updated_at":"2015-11-21T03:02:38Z","html_url":"https://github.com/sympy/sympy/pull/10164#discussion_r45540486","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/10164","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/45540486"},"html":{"href":"https://github.com/sympy/sympy/pull/10164#discussion_r45540486"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10164"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/10164","id":51431624,"html_url":"https://github.com/sympy/sympy/pull/10164","diff_url":"https://github.com/sympy/sympy/pull/10164.diff","patch_url":"https://github.com/sympy/sympy/pull/10164.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/10164","number":10164,"state":"open","locked":false,"title":"Hash sums, integrals, and other expressions with limits","user":{"login":"zanzibar7","id":2191670,"avatar_url":"https://avatars.githubusercontent.com/u/2191670?v=3","gravatar_id":"","url":"https://api.github.com/users/zanzibar7","html_url":"https://github.com/zanzibar7","followers_url":"https://api.github.com/users/zanzibar7/followers","following_url":"https://api.github.com/users/zanzibar7/following{/other_user}","gists_url":"https://api.github.com/users/zanzibar7/gists{/gist_id}","starred_url":"https://api.github.com/users/zanzibar7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanzibar7/subscriptions","organizations_url":"https://api.github.com/users/zanzibar7/orgs","repos_url":"https://api.github.com/users/zanzibar7/repos","events_url":"https://api.github.com/users/zanzibar7/events{/privacy}","received_events_url":"https://api.github.com/users/zanzibar7/received_events","type":"User","site_admin":false},"body":"An attempt at addressing issues #10153 and #5539 .  Also includes some better handling of Sum factoring\r\nHowever, there were some problems with the quantum mechanics files because of  QExpr.","created_at":"2015-11-21T02:55:43Z","updated_at":"2015-11-21T03:02:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1ef8b6dcdc0a2b43307f54747dbfed1815cc437","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/10164/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/10164/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/10164/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/47e5b38c3e9daf8915b4433ef2c1f3cd43369f57","head":{"label":"zanzibar7:hash_factor_Sums","ref":"hash_factor_Sums","sha":"47e5b38c3e9daf8915b4433ef2c1f3cd43369f57","user":{"login":"zanzibar7","id":2191670,"avatar_url":"https://avatars.githubusercontent.com/u/2191670?v=3","gravatar_id":"","url":"https://api.github.com/users/zanzibar7","html_url":"https://github.com/zanzibar7","followers_url":"https://api.github.com/users/zanzibar7/followers","following_url":"https://api.github.com/users/zanzibar7/following{/other_user}","gists_url":"https://api.github.com/users/zanzibar7/gists{/gist_id}","starred_url":"https://api.github.com/users/zanzibar7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanzibar7/subscriptions","organizations_url":"https://api.github.com/users/zanzibar7/orgs","repos_url":"https://api.github.com/users/zanzibar7/repos","events_url":"https://api.github.com/users/zanzibar7/events{/privacy}","received_events_url":"https://api.github.com/users/zanzibar7/received_events","type":"User","site_admin":false},"repo":{"id":5499697,"name":"sympy","full_name":"zanzibar7/sympy","owner":{"login":"zanzibar7","id":2191670,"avatar_url":"https://avatars.githubusercontent.com/u/2191670?v=3","gravatar_id":"","url":"https://api.github.com/users/zanzibar7","html_url":"https://github.com/zanzibar7","followers_url":"https://api.github.com/users/zanzibar7/followers","following_url":"https://api.github.com/users/zanzibar7/following{/other_user}","gists_url":"https://api.github.com/users/zanzibar7/gists{/gist_id}","starred_url":"https://api.github.com/users/zanzibar7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanzibar7/subscriptions","organizations_url":"https://api.github.com/users/zanzibar7/orgs","repos_url":"https://api.github.com/users/zanzibar7/repos","events_url":"https://api.github.com/users/zanzibar7/events{/privacy}","received_events_url":"https://api.github.com/users/zanzibar7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zanzibar7/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/zanzibar7/sympy","forks_url":"https://api.github.com/repos/zanzibar7/sympy/forks","keys_url":"https://api.github.com/repos/zanzibar7/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zanzibar7/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zanzibar7/sympy/teams","hooks_url":"https://api.github.com/repos/zanzibar7/sympy/hooks","issue_events_url":"https://api.github.com/repos/zanzibar7/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/zanzibar7/sympy/events","assignees_url":"https://api.github.com/repos/zanzibar7/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/zanzibar7/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/zanzibar7/sympy/tags","blobs_url":"https://api.github.com/repos/zanzibar7/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zanzibar7/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zanzibar7/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/zanzibar7/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zanzibar7/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/zanzibar7/sympy/languages","stargazers_url":"https://api.github.com/repos/zanzibar7/sympy/stargazers","contributors_url":"https://api.github.com/repos/zanzibar7/sympy/contributors","subscribers_url":"https://api.github.com/repos/zanzibar7/sympy/subscribers","subscription_url":"https://api.github.com/repos/zanzibar7/sympy/subscription","commits_url":"https://api.github.com/repos/zanzibar7/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/zanzibar7/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/zanzibar7/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/zanzibar7/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/zanzibar7/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/zanzibar7/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zanzibar7/sympy/merges","archive_url":"https://api.github.com/repos/zanzibar7/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zanzibar7/sympy/downloads","issues_url":"https://api.github.com/repos/zanzibar7/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/zanzibar7/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/zanzibar7/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/zanzibar7/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zanzibar7/sympy/labels{/name}","releases_url":"https://api.github.com/repos/zanzibar7/sympy/releases{/id}","created_at":"2012-08-21T19:14:21Z","updated_at":"2015-04-05T16:01:16Z","pushed_at":"2015-11-21T02:52:40Z","git_url":"git://github.com/zanzibar7/sympy.git","ssh_url":"git@github.com:zanzibar7/sympy.git","clone_url":"https://github.com/zanzibar7/sympy.git","svn_url":"https://github.com/zanzibar7/sympy","homepage":"http://sympy.org/","size":72765,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"7cec98fc6b2f2dd032e4d3d5aa99dbd3eda504fb","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2015-11-19T23:33:10Z","pushed_at":"2015-11-21T02:55:44Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":101726,"stargazers_count":2455,"watchers_count":2455,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1208,"mirror_url":null,"open_issues_count":2063,"forks":1208,"open_issues":2063,"watchers":2455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10164"},"html":{"href":"https://github.com/sympy/sympy/pull/10164"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/10164"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/10164/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10164/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/10164/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/47e5b38c3e9daf8915b4433ef2c1f3cd43369f57"}}}}