{"action":"created","comment":{"url":"https://api.github.com/repos/cea-sec/miasm/pulls/comments/25137106","id":25137106,"diff_hunk":"@@ -1191,10 +1191,11 @@ def get_ir(self, instr):\n             if args[-1].op == 'rrx':\n                 args[-1] = ExprCompose(\n                     [(args[-1].args[0][1:], 0, 31), (cf, 31, 32)])\n-            elif (args[-1].op in ['<<', '>>', '<<a', 'a>>', '<<<', '>>>'] and\n-                  isinstance(args[-1].args[-1], ExprId)):\n-                args[-1].args = args[-1].args[:-1] + (\n-                    args[-1].args[-1][:8].zeroExtend(32),)\n+            elif args[-1].op in ['<<', '>>', '<<a', 'a>>', '<<<', '>>>']:\n+                if isinstance(args[-1].args[-1], ExprId):","path":"miasm2/arch/arm/sem.py","position":9,"original_position":9,"commit_id":"287109263e24e924e7ec551b1443d53e7d60da87","original_commit_id":"287109263e24e924e7ec551b1443d53e7d60da87","user":{"login":"serpilliere","id":9433661,"avatar_url":"https://avatars.githubusercontent.com/u/9433661?v=3","gravatar_id":"","url":"https://api.github.com/users/serpilliere","html_url":"https://github.com/serpilliere","followers_url":"https://api.github.com/users/serpilliere/followers","following_url":"https://api.github.com/users/serpilliere/following{/other_user}","gists_url":"https://api.github.com/users/serpilliere/gists{/gist_id}","starred_url":"https://api.github.com/users/serpilliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serpilliere/subscriptions","organizations_url":"https://api.github.com/users/serpilliere/orgs","repos_url":"https://api.github.com/users/serpilliere/repos","events_url":"https://api.github.com/users/serpilliere/events{/privacy}","received_events_url":"https://api.github.com/users/serpilliere/received_events","type":"User","site_admin":false},"body":"When I corrected the code, it took me some time to read the test, which is a bit long. So I decided to split it in 2 sub if.","created_at":"2015-02-22T21:50:18Z","updated_at":"2015-02-22T21:50:18Z","html_url":"https://github.com/cea-sec/miasm/pull/83#discussion_r25137106","pull_request_url":"https://api.github.com/repos/cea-sec/miasm/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/comments/25137106"},"html":{"href":"https://github.com/cea-sec/miasm/pull/83#discussion_r25137106"},"pull_request":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/cea-sec/miasm/pulls/83","id":29763370,"html_url":"https://github.com/cea-sec/miasm/pull/83","diff_url":"https://github.com/cea-sec/miasm/pull/83.diff","patch_url":"https://github.com/cea-sec/miasm/pull/83.patch","issue_url":"https://api.github.com/repos/cea-sec/miasm/issues/83","number":83,"state":"open","locked":false,"title":"Expr immutable","user":{"login":"serpilliere","id":9433661,"avatar_url":"https://avatars.githubusercontent.com/u/9433661?v=3","gravatar_id":"","url":"https://api.github.com/users/serpilliere","html_url":"https://github.com/serpilliere","followers_url":"https://api.github.com/users/serpilliere/followers","following_url":"https://api.github.com/users/serpilliere/following{/other_user}","gists_url":"https://api.github.com/users/serpilliere/gists{/gist_id}","starred_url":"https://api.github.com/users/serpilliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serpilliere/subscriptions","organizations_url":"https://api.github.com/users/serpilliere/orgs","repos_url":"https://api.github.com/users/serpilliere/repos","events_url":"https://api.github.com/users/serpilliere/events{/privacy}","received_events_url":"https://api.github.com/users/serpilliere/received_events","type":"User","site_admin":false},"body":"Make expression immutable.\r\nThis may avoid bugs on the hash cache computation, and be a start point to correct hash collision.","created_at":"2015-02-22T00:55:49Z","updated_at":"2015-02-22T21:50:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"705f5d02edb4f74f19a7f69f9e68234af3e91537","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cea-sec/miasm/pulls/83/commits","review_comments_url":"https://api.github.com/repos/cea-sec/miasm/pulls/83/comments","review_comment_url":"https://api.github.com/repos/cea-sec/miasm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cea-sec/miasm/issues/83/comments","statuses_url":"https://api.github.com/repos/cea-sec/miasm/statuses/287109263e24e924e7ec551b1443d53e7d60da87","head":{"label":"serpilliere:expr_immutable","ref":"expr_immutable","sha":"287109263e24e924e7ec551b1443d53e7d60da87","user":{"login":"serpilliere","id":9433661,"avatar_url":"https://avatars.githubusercontent.com/u/9433661?v=3","gravatar_id":"","url":"https://api.github.com/users/serpilliere","html_url":"https://github.com/serpilliere","followers_url":"https://api.github.com/users/serpilliere/followers","following_url":"https://api.github.com/users/serpilliere/following{/other_user}","gists_url":"https://api.github.com/users/serpilliere/gists{/gist_id}","starred_url":"https://api.github.com/users/serpilliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serpilliere/subscriptions","organizations_url":"https://api.github.com/users/serpilliere/orgs","repos_url":"https://api.github.com/users/serpilliere/repos","events_url":"https://api.github.com/users/serpilliere/events{/privacy}","received_events_url":"https://api.github.com/users/serpilliere/received_events","type":"User","site_admin":false},"repo":{"id":27075008,"name":"miasm","full_name":"serpilliere/miasm","owner":{"login":"serpilliere","id":9433661,"avatar_url":"https://avatars.githubusercontent.com/u/9433661?v=3","gravatar_id":"","url":"https://api.github.com/users/serpilliere","html_url":"https://github.com/serpilliere","followers_url":"https://api.github.com/users/serpilliere/followers","following_url":"https://api.github.com/users/serpilliere/following{/other_user}","gists_url":"https://api.github.com/users/serpilliere/gists{/gist_id}","starred_url":"https://api.github.com/users/serpilliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serpilliere/subscriptions","organizations_url":"https://api.github.com/users/serpilliere/orgs","repos_url":"https://api.github.com/users/serpilliere/repos","events_url":"https://api.github.com/users/serpilliere/events{/privacy}","received_events_url":"https://api.github.com/users/serpilliere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serpilliere/miasm","description":"Reverse engineering framework in Python","fork":true,"url":"https://api.github.com/repos/serpilliere/miasm","forks_url":"https://api.github.com/repos/serpilliere/miasm/forks","keys_url":"https://api.github.com/repos/serpilliere/miasm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serpilliere/miasm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serpilliere/miasm/teams","hooks_url":"https://api.github.com/repos/serpilliere/miasm/hooks","issue_events_url":"https://api.github.com/repos/serpilliere/miasm/issues/events{/number}","events_url":"https://api.github.com/repos/serpilliere/miasm/events","assignees_url":"https://api.github.com/repos/serpilliere/miasm/assignees{/user}","branches_url":"https://api.github.com/repos/serpilliere/miasm/branches{/branch}","tags_url":"https://api.github.com/repos/serpilliere/miasm/tags","blobs_url":"https://api.github.com/repos/serpilliere/miasm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serpilliere/miasm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serpilliere/miasm/git/refs{/sha}","trees_url":"https://api.github.com/repos/serpilliere/miasm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serpilliere/miasm/statuses/{sha}","languages_url":"https://api.github.com/repos/serpilliere/miasm/languages","stargazers_url":"https://api.github.com/repos/serpilliere/miasm/stargazers","contributors_url":"https://api.github.com/repos/serpilliere/miasm/contributors","subscribers_url":"https://api.github.com/repos/serpilliere/miasm/subscribers","subscription_url":"https://api.github.com/repos/serpilliere/miasm/subscription","commits_url":"https://api.github.com/repos/serpilliere/miasm/commits{/sha}","git_commits_url":"https://api.github.com/repos/serpilliere/miasm/git/commits{/sha}","comments_url":"https://api.github.com/repos/serpilliere/miasm/comments{/number}","issue_comment_url":"https://api.github.com/repos/serpilliere/miasm/issues/comments{/number}","contents_url":"https://api.github.com/repos/serpilliere/miasm/contents/{+path}","compare_url":"https://api.github.com/repos/serpilliere/miasm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serpilliere/miasm/merges","archive_url":"https://api.github.com/repos/serpilliere/miasm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serpilliere/miasm/downloads","issues_url":"https://api.github.com/repos/serpilliere/miasm/issues{/number}","pulls_url":"https://api.github.com/repos/serpilliere/miasm/pulls{/number}","milestones_url":"https://api.github.com/repos/serpilliere/miasm/milestones{/number}","notifications_url":"https://api.github.com/repos/serpilliere/miasm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serpilliere/miasm/labels{/name}","releases_url":"https://api.github.com/repos/serpilliere/miasm/releases{/id}","created_at":"2014-11-24T12:31:26Z","updated_at":"2015-02-20T12:57:22Z","pushed_at":"2015-02-22T00:51:51Z","git_url":"git://github.com/serpilliere/miasm.git","ssh_url":"git@github.com:serpilliere/miasm.git","clone_url":"https://github.com/serpilliere/miasm.git","svn_url":"https://github.com/serpilliere/miasm","homepage":null,"size":10118,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"cea-sec:master","ref":"master","sha":"855bc7be4f06a0ea7eb4c8a6f009b21703272a30","user":{"login":"cea-sec","id":5071925,"avatar_url":"https://avatars.githubusercontent.com/u/5071925?v=3","gravatar_id":"","url":"https://api.github.com/users/cea-sec","html_url":"https://github.com/cea-sec","followers_url":"https://api.github.com/users/cea-sec/followers","following_url":"https://api.github.com/users/cea-sec/following{/other_user}","gists_url":"https://api.github.com/users/cea-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/cea-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cea-sec/subscriptions","organizations_url":"https://api.github.com/users/cea-sec/orgs","repos_url":"https://api.github.com/users/cea-sec/repos","events_url":"https://api.github.com/users/cea-sec/events{/privacy}","received_events_url":"https://api.github.com/users/cea-sec/received_events","type":"Organization","site_admin":false},"repo":{"id":25875083,"name":"miasm","full_name":"cea-sec/miasm","owner":{"login":"cea-sec","id":5071925,"avatar_url":"https://avatars.githubusercontent.com/u/5071925?v=3","gravatar_id":"","url":"https://api.github.com/users/cea-sec","html_url":"https://github.com/cea-sec","followers_url":"https://api.github.com/users/cea-sec/followers","following_url":"https://api.github.com/users/cea-sec/following{/other_user}","gists_url":"https://api.github.com/users/cea-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/cea-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cea-sec/subscriptions","organizations_url":"https://api.github.com/users/cea-sec/orgs","repos_url":"https://api.github.com/users/cea-sec/repos","events_url":"https://api.github.com/users/cea-sec/events{/privacy}","received_events_url":"https://api.github.com/users/cea-sec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cea-sec/miasm","description":"Reverse engineering framework in Python","fork":false,"url":"https://api.github.com/repos/cea-sec/miasm","forks_url":"https://api.github.com/repos/cea-sec/miasm/forks","keys_url":"https://api.github.com/repos/cea-sec/miasm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cea-sec/miasm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cea-sec/miasm/teams","hooks_url":"https://api.github.com/repos/cea-sec/miasm/hooks","issue_events_url":"https://api.github.com/repos/cea-sec/miasm/issues/events{/number}","events_url":"https://api.github.com/repos/cea-sec/miasm/events","assignees_url":"https://api.github.com/repos/cea-sec/miasm/assignees{/user}","branches_url":"https://api.github.com/repos/cea-sec/miasm/branches{/branch}","tags_url":"https://api.github.com/repos/cea-sec/miasm/tags","blobs_url":"https://api.github.com/repos/cea-sec/miasm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cea-sec/miasm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cea-sec/miasm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cea-sec/miasm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cea-sec/miasm/statuses/{sha}","languages_url":"https://api.github.com/repos/cea-sec/miasm/languages","stargazers_url":"https://api.github.com/repos/cea-sec/miasm/stargazers","contributors_url":"https://api.github.com/repos/cea-sec/miasm/contributors","subscribers_url":"https://api.github.com/repos/cea-sec/miasm/subscribers","subscription_url":"https://api.github.com/repos/cea-sec/miasm/subscription","commits_url":"https://api.github.com/repos/cea-sec/miasm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cea-sec/miasm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cea-sec/miasm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cea-sec/miasm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cea-sec/miasm/contents/{+path}","compare_url":"https://api.github.com/repos/cea-sec/miasm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cea-sec/miasm/merges","archive_url":"https://api.github.com/repos/cea-sec/miasm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cea-sec/miasm/downloads","issues_url":"https://api.github.com/repos/cea-sec/miasm/issues{/number}","pulls_url":"https://api.github.com/repos/cea-sec/miasm/pulls{/number}","milestones_url":"https://api.github.com/repos/cea-sec/miasm/milestones{/number}","notifications_url":"https://api.github.com/repos/cea-sec/miasm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cea-sec/miasm/labels{/name}","releases_url":"https://api.github.com/repos/cea-sec/miasm/releases{/id}","created_at":"2014-10-28T15:05:47Z","updated_at":"2015-02-21T14:23:53Z","pushed_at":"2015-02-21T14:23:52Z","git_url":"git://github.com/cea-sec/miasm.git","ssh_url":"git@github.com:cea-sec/miasm.git","clone_url":"https://github.com/cea-sec/miasm.git","svn_url":"https://github.com/cea-sec/miasm","homepage":null,"size":11176,"stargazers_count":313,"watchers_count":313,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":9,"forks":33,"open_issues":9,"watchers":313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/83"},"html":{"href":"https://github.com/cea-sec/miasm/pull/83"},"issue":{"href":"https://api.github.com/repos/cea-sec/miasm/issues/83"},"comments":{"href":"https://api.github.com/repos/cea-sec/miasm/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cea-sec/miasm/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/cea-sec/miasm/statuses/287109263e24e924e7ec551b1443d53e7d60da87"}}}}