{"action":"opened","number":634,"pull_request":{"url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/634","id":49155002,"html_url":"https://github.com/riptano/cassandra-dtest/pull/634","diff_url":"https://github.com/riptano/cassandra-dtest/pull/634.diff","patch_url":"https://github.com/riptano/cassandra-dtest/pull/634.patch","issue_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/634","number":634,"state":"open","locked":false,"title":"Print error with new lines","user":{"login":"mambocab","id":3753769,"avatar_url":"https://avatars.githubusercontent.com/u/3753769?v=3","gravatar_id":"","url":"https://api.github.com/users/mambocab","html_url":"https://github.com/mambocab","followers_url":"https://api.github.com/users/mambocab/followers","following_url":"https://api.github.com/users/mambocab/following{/other_user}","gists_url":"https://api.github.com/users/mambocab/gists{/gist_id}","starred_url":"https://api.github.com/users/mambocab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mambocab/subscriptions","organizations_url":"https://api.github.com/users/mambocab/orgs","repos_url":"https://api.github.com/users/mambocab/repos","events_url":"https://api.github.com/users/mambocab/events{/privacy}","received_events_url":"https://api.github.com/users/mambocab/received_events","type":"User","site_admin":false},"body":"@ptnapoleon can you review? We disucssed this privately.\r\n\r\nThis change prints the log errors split by newlines rather than spaces. Doesn't actually make a huge difference unless you want to do some post-processing. Before (results truncated):\r\n\r\n```\r\nAssertionError: Unexpected error in node1 node log: ['ERROR [main] 2015-10-29 10:53:49,321 LogTransaction.java:436 - Failed to remove unfinished transaction leftovers for txn [/tmp/dtest-_iDCHG/test/node1/data/system/local-7ad54392bcdd35a684174e047860b377/ma_txn_compaction_dac891a0-7e4c-11e5-9df1-6d10b7106813.log]  java.lang.NullPointerException: null \\tat org.apache.cassandra.db.lifecycle.LogRecord.getExistingFiles(LogRecord.java:243) ~[main/:na] \\tat org.apache.cassandra.db.lifecycle.LogRecord.getExistingFiles(LogRecord.java:237) ~[main/:na] \\tat org.apache.cassandra.db.lifecycle.LogFile.deleteRecordFiles(LogFile.java:308) ~[main/:na] \\tat java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) ~[na:1.8.0_60] \\tat java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) ~[na:1.8.0_60] \\tat java.util.Iterator.forEachRemaining(Iterator.java:116) ~[na:1.8.0_60] \\tat java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) ~[na:1.8.0_60] \\tat java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481) ~[na:1.8.0_60] \\tat java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) ~[na:1.8.0_60] \\tat java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) ~[na:1.8.0_60] \\tat java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) ~[na:1.8.0_60] \\tat java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[na:1.8.0_60] \\tat java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) ~[na:1.8.0_60] \\tat org.apache.cassandra.db.lifecycle.LogFile.deleteFilesForRecordsOfType(LogFile.java:302) ~[main/:na] \\tat org.apache.cassandra.db.lifecycle.LogFile.removeUnfinishedLeftovers(LogFile.java:95) ~[main/:na] \\tat org.apache.cassandra.db.lifecycle.LogTransaction$LogFilesByName.removeUnfinishedLeftovers(LogTransaction.java:434) ~[main/:na] \\tat java.util.HashMap.forEach(HashMap.java:1280) ~[na:1.8.0_60] \\tat org.apache.cassandra.db.lifecycle.LogTransaction$LogFilesByName.removeUnfinishedLeftovers(LogTransaction.java:424) ~[main/:na] \\tat org.apache.cassandra.db.lifecycle.LogTransaction.removeUnfinishedLeftovers(LogTransaction.java:398) ~[main/:na] \\tat org.apache.cassandra.db.\r\n```\r\n\r\nAnd after:\r\n\r\n```\r\nAssertionError: Unexpected error in node1 node log: ['ERROR [main] 2015-10-29 10:42:13,596 LogTransaction.java:436 - Failed to remove unfinished transaction leftovers for txn [/tmp/dtest-3prmik/test/node1/data/system/local-7ad54392bcdd35a684174e047860b377/ma_txn_compaction_3c1a6d40-7e4b-11e5-98ea-6d10b7106813.log] \\njava.lang.NullPointerException: null\\n\\tat org.apache.cassandra.db.lifecycle.LogRecord.getExistingFiles(LogRecord.java:243) ~[main/:na]\\n\\tat org.apache.cassandra.db.lifecycle.LogRecord.getExistingFiles(LogRecord.java:237) ~[main/:na]\\n\\tat org.apache.cassandra.db.lifecycle.LogFile.deleteRecordFiles(LogFile.java:308) ~[main/:na]\\n\\tat java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) ~[na:1.8.0_60]\\n\\tat java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) ~[na:1.8.0_60]\\n\\tat java.util.Iterator.forEachRemaining(Iterator.java:116) ~[na:1.8.0_60]\\n\\tat java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) ~[na:1.8.0_60]\\n\\tat java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481) ~[na:1.8.0_60]\\n\\tat java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) ~[na:1.8.0_60]\\n\\tat java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) ~[na:1.8.0_60]\\n\\tat \r\n```\r\n\r\nYou get the idea -- basically you see a lot of '\\n\\t' instead of ' \\t'. It's a little better.\r\n\r\nI've also included a couple little style changes for linter errors I got locally. Changing `if self.allow_log_errors == False:` to `if not self.allow_log_errors:` is a semantic change, but I don't see anywhere in the codebase that would be affected:\r\n\r\n```\r\n$ ag allow_log_errors\r\nsstable_generation_loading_test.py\r\n15:        self.allow_log_errors = True\r\n\r\npaging_test.py\r\n1523:        self.allow_log_errors = True\r\n\r\nbootstrap_test.py\r\n33:        self.allow_log_errors = True\r\n\r\ncommitlog_test.py\r\n25:        self.allow_log_errors = True\r\n\r\ndtest.py\r\n174:        self.allow_log_errors = False\r\n545:                if not self.allow_log_errors:\r\n\r\nconcurrent_schema_changes_test.py\r\n28:        self.allow_log_errors = True\r\n\r\npushed_notifications_test.py\r\n273:        self.allow_log_errors = True\r\n\r\nreplace_address_test.py\r\n34:        self.allow_log_errors = True\r\n\r\nupgrade_tests/paging_test.py\r\n1688:        self.allow_log_errors = True\r\n```\r\n\r\nIn the other style change (`except Exception as e:` -> `except Exception:`) the variable created was never used, so this shouldn't affect behavior.","created_at":"2015-10-29T15:26:44Z","updated_at":"2015-10-29T15:26:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/634/commits","review_comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/634/comments","review_comment_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/634/comments","statuses_url":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/a113ad580f8dbe75a5e24e2cfc98b8e5ce4bd149","head":{"label":"mambocab:print-error-with-new-lines","ref":"print-error-with-new-lines","sha":"a113ad580f8dbe75a5e24e2cfc98b8e5ce4bd149","user":{"login":"mambocab","id":3753769,"avatar_url":"https://avatars.githubusercontent.com/u/3753769?v=3","gravatar_id":"","url":"https://api.github.com/users/mambocab","html_url":"https://github.com/mambocab","followers_url":"https://api.github.com/users/mambocab/followers","following_url":"https://api.github.com/users/mambocab/following{/other_user}","gists_url":"https://api.github.com/users/mambocab/gists{/gist_id}","starred_url":"https://api.github.com/users/mambocab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mambocab/subscriptions","organizations_url":"https://api.github.com/users/mambocab/orgs","repos_url":"https://api.github.com/users/mambocab/repos","events_url":"https://api.github.com/users/mambocab/events{/privacy}","received_events_url":"https://api.github.com/users/mambocab/received_events","type":"User","site_admin":false},"repo":{"id":31236640,"name":"cassandra-dtest","full_name":"mambocab/cassandra-dtest","owner":{"login":"mambocab","id":3753769,"avatar_url":"https://avatars.githubusercontent.com/u/3753769?v=3","gravatar_id":"","url":"https://api.github.com/users/mambocab","html_url":"https://github.com/mambocab","followers_url":"https://api.github.com/users/mambocab/followers","following_url":"https://api.github.com/users/mambocab/following{/other_user}","gists_url":"https://api.github.com/users/mambocab/gists{/gist_id}","starred_url":"https://api.github.com/users/mambocab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mambocab/subscriptions","organizations_url":"https://api.github.com/users/mambocab/orgs","repos_url":"https://api.github.com/users/mambocab/repos","events_url":"https://api.github.com/users/mambocab/events{/privacy}","received_events_url":"https://api.github.com/users/mambocab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mambocab/cassandra-dtest","description":"Cassandra Distributed Tests","fork":true,"url":"https://api.github.com/repos/mambocab/cassandra-dtest","forks_url":"https://api.github.com/repos/mambocab/cassandra-dtest/forks","keys_url":"https://api.github.com/repos/mambocab/cassandra-dtest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mambocab/cassandra-dtest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mambocab/cassandra-dtest/teams","hooks_url":"https://api.github.com/repos/mambocab/cassandra-dtest/hooks","issue_events_url":"https://api.github.com/repos/mambocab/cassandra-dtest/issues/events{/number}","events_url":"https://api.github.com/repos/mambocab/cassandra-dtest/events","assignees_url":"https://api.github.com/repos/mambocab/cassandra-dtest/assignees{/user}","branches_url":"https://api.github.com/repos/mambocab/cassandra-dtest/branches{/branch}","tags_url":"https://api.github.com/repos/mambocab/cassandra-dtest/tags","blobs_url":"https://api.github.com/repos/mambocab/cassandra-dtest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mambocab/cassandra-dtest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mambocab/cassandra-dtest/git/refs{/sha}","trees_url":"https://api.github.com/repos/mambocab/cassandra-dtest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mambocab/cassandra-dtest/statuses/{sha}","languages_url":"https://api.github.com/repos/mambocab/cassandra-dtest/languages","stargazers_url":"https://api.github.com/repos/mambocab/cassandra-dtest/stargazers","contributors_url":"https://api.github.com/repos/mambocab/cassandra-dtest/contributors","subscribers_url":"https://api.github.com/repos/mambocab/cassandra-dtest/subscribers","subscription_url":"https://api.github.com/repos/mambocab/cassandra-dtest/subscription","commits_url":"https://api.github.com/repos/mambocab/cassandra-dtest/commits{/sha}","git_commits_url":"https://api.github.com/repos/mambocab/cassandra-dtest/git/commits{/sha}","comments_url":"https://api.github.com/repos/mambocab/cassandra-dtest/comments{/number}","issue_comment_url":"https://api.github.com/repos/mambocab/cassandra-dtest/issues/comments{/number}","contents_url":"https://api.github.com/repos/mambocab/cassandra-dtest/contents/{+path}","compare_url":"https://api.github.com/repos/mambocab/cassandra-dtest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mambocab/cassandra-dtest/merges","archive_url":"https://api.github.com/repos/mambocab/cassandra-dtest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mambocab/cassandra-dtest/downloads","issues_url":"https://api.github.com/repos/mambocab/cassandra-dtest/issues{/number}","pulls_url":"https://api.github.com/repos/mambocab/cassandra-dtest/pulls{/number}","milestones_url":"https://api.github.com/repos/mambocab/cassandra-dtest/milestones{/number}","notifications_url":"https://api.github.com/repos/mambocab/cassandra-dtest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mambocab/cassandra-dtest/labels{/name}","releases_url":"https://api.github.com/repos/mambocab/cassandra-dtest/releases{/id}","created_at":"2015-02-23T23:58:43Z","updated_at":"2015-03-20T18:05:58Z","pushed_at":"2015-10-29T15:16:45Z","git_url":"git://github.com/mambocab/cassandra-dtest.git","ssh_url":"git@github.com:mambocab/cassandra-dtest.git","clone_url":"https://github.com/mambocab/cassandra-dtest.git","svn_url":"https://github.com/mambocab/cassandra-dtest","homepage":"","size":13572,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"riptano:master","ref":"master","sha":"1cf35ef3188872294a5e7dac93f2372f1f134421","user":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"repo":{"id":2674774,"name":"cassandra-dtest","full_name":"riptano/cassandra-dtest","owner":{"login":"riptano","id":275430,"avatar_url":"https://avatars.githubusercontent.com/u/275430?v=3","gravatar_id":"","url":"https://api.github.com/users/riptano","html_url":"https://github.com/riptano","followers_url":"https://api.github.com/users/riptano/followers","following_url":"https://api.github.com/users/riptano/following{/other_user}","gists_url":"https://api.github.com/users/riptano/gists{/gist_id}","starred_url":"https://api.github.com/users/riptano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riptano/subscriptions","organizations_url":"https://api.github.com/users/riptano/orgs","repos_url":"https://api.github.com/users/riptano/repos","events_url":"https://api.github.com/users/riptano/events{/privacy}","received_events_url":"https://api.github.com/users/riptano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riptano/cassandra-dtest","description":"Cassandra Distributed Tests","fork":false,"url":"https://api.github.com/repos/riptano/cassandra-dtest","forks_url":"https://api.github.com/repos/riptano/cassandra-dtest/forks","keys_url":"https://api.github.com/repos/riptano/cassandra-dtest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riptano/cassandra-dtest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riptano/cassandra-dtest/teams","hooks_url":"https://api.github.com/repos/riptano/cassandra-dtest/hooks","issue_events_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/events{/number}","events_url":"https://api.github.com/repos/riptano/cassandra-dtest/events","assignees_url":"https://api.github.com/repos/riptano/cassandra-dtest/assignees{/user}","branches_url":"https://api.github.com/repos/riptano/cassandra-dtest/branches{/branch}","tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/tags","blobs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/refs{/sha}","trees_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/{sha}","languages_url":"https://api.github.com/repos/riptano/cassandra-dtest/languages","stargazers_url":"https://api.github.com/repos/riptano/cassandra-dtest/stargazers","contributors_url":"https://api.github.com/repos/riptano/cassandra-dtest/contributors","subscribers_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscribers","subscription_url":"https://api.github.com/repos/riptano/cassandra-dtest/subscription","commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/commits{/sha}","git_commits_url":"https://api.github.com/repos/riptano/cassandra-dtest/git/commits{/sha}","comments_url":"https://api.github.com/repos/riptano/cassandra-dtest/comments{/number}","issue_comment_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues/comments{/number}","contents_url":"https://api.github.com/repos/riptano/cassandra-dtest/contents/{+path}","compare_url":"https://api.github.com/repos/riptano/cassandra-dtest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riptano/cassandra-dtest/merges","archive_url":"https://api.github.com/repos/riptano/cassandra-dtest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riptano/cassandra-dtest/downloads","issues_url":"https://api.github.com/repos/riptano/cassandra-dtest/issues{/number}","pulls_url":"https://api.github.com/repos/riptano/cassandra-dtest/pulls{/number}","milestones_url":"https://api.github.com/repos/riptano/cassandra-dtest/milestones{/number}","notifications_url":"https://api.github.com/repos/riptano/cassandra-dtest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riptano/cassandra-dtest/labels{/name}","releases_url":"https://api.github.com/repos/riptano/cassandra-dtest/releases{/id}","created_at":"2011-10-30T11:15:44Z","updated_at":"2015-10-17T13:13:04Z","pushed_at":"2015-10-29T15:02:47Z","git_url":"git://github.com/riptano/cassandra-dtest.git","ssh_url":"git@github.com:riptano/cassandra-dtest.git","clone_url":"https://github.com/riptano/cassandra-dtest.git","svn_url":"https://github.com/riptano/cassandra-dtest","homepage":"","size":19003,"stargazers_count":66,"watchers_count":66,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":55,"forks":46,"open_issues":55,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/634"},"html":{"href":"https://github.com/riptano/cassandra-dtest/pull/634"},"issue":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/issues/634"},"comments":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/issues/634/comments"},"review_comments":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/634/comments"},"review_comment":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/pulls/634/commits"},"statuses":{"href":"https://api.github.com/repos/riptano/cassandra-dtest/statuses/a113ad580f8dbe75a5e24e2cfc98b8e5ce4bd149"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":3,"deletions":3,"changed_files":1}}