{"action":"created","issue":{"url":"https://api.github.com/repos/feathersjs/feathers/issues/102","labels_url":"https://api.github.com/repos/feathersjs/feathers/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/feathersjs/feathers/issues/102/comments","events_url":"https://api.github.com/repos/feathersjs/feathers/issues/102/events","html_url":"https://github.com/feathersjs/feathers/pull/102","id":53880372,"number":102,"title":"Dynamic services","user":{"login":"marshallswain","id":128857,"avatar_url":"https://avatars.githubusercontent.com/u/128857?v=3","gravatar_id":"","url":"https://api.github.com/users/marshallswain","html_url":"https://github.com/marshallswain","followers_url":"https://api.github.com/users/marshallswain/followers","following_url":"https://api.github.com/users/marshallswain/following{/other_user}","gists_url":"https://api.github.com/users/marshallswain/gists{/gist_id}","starred_url":"https://api.github.com/users/marshallswain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshallswain/subscriptions","organizations_url":"https://api.github.com/users/marshallswain/orgs","repos_url":"https://api.github.com/users/marshallswain/repos","events_url":"https://api.github.com/users/marshallswain/events{/privacy}","received_events_url":"https://api.github.com/users/marshallswain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-09T15:41:26Z","updated_at":"2015-01-09T20:01:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/feathersjs/feathers/pulls/102","html_url":"https://github.com/feathersjs/feathers/pull/102","diff_url":"https://github.com/feathersjs/feathers/pull/102.diff","patch_url":"https://github.com/feathersjs/feathers/pull/102.patch"},"body":"Creates the ability to add services at runtime.  This is going to take a bit more effort to test out properly, but I wanted to get it out   in the wild to get some feedback on it while I'm in the process of further testing.  Maybe you'll see something that I haven't noticed, yet.  I'll report back what I find."},"comment":{"url":"https://api.github.com/repos/feathersjs/feathers/issues/comments/69390259","html_url":"https://github.com/feathersjs/feathers/pull/102#issuecomment-69390259","issue_url":"https://api.github.com/repos/feathersjs/feathers/issues/102","id":69390259,"user":{"login":"marshallswain","id":128857,"avatar_url":"https://avatars.githubusercontent.com/u/128857?v=3","gravatar_id":"","url":"https://api.github.com/users/marshallswain","html_url":"https://github.com/marshallswain","followers_url":"https://api.github.com/users/marshallswain/followers","following_url":"https://api.github.com/users/marshallswain/following{/other_user}","gists_url":"https://api.github.com/users/marshallswain/gists{/gist_id}","starred_url":"https://api.github.com/users/marshallswain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshallswain/subscriptions","organizations_url":"https://api.github.com/users/marshallswain/orgs","repos_url":"https://api.github.com/users/marshallswain/repos","events_url":"https://api.github.com/users/marshallswain/events{/privacy}","received_events_url":"https://api.github.com/users/marshallswain/received_events","type":"User","site_admin":false},"created_at":"2015-01-09T20:01:50Z","updated_at":"2015-01-09T20:01:50Z","body":"OK.  It looks like that test is failing because when you clone Uberproto it breaks the prototype \"link\" so that isPrototypeOf no longer works.  \r\n```js\r\n\r\nvar _ = require('lodash');\r\n\r\n// Clone Uberproto\r\nvar Proto = _.clone(require('uberproto'));\r\nvar dummyService = {\r\n  create: function (data, params, callback) {\r\n    callback(null, data);\r\n  }\r\n};\r\n\r\ndummyService = Proto.extend(dummyService);\r\nconsole.log(Proto.isPrototypeOf(dummyService)); // true\r\n\r\n// Clone again and compare\r\nvar Proto = _.clone(require('uberproto'));\r\nconsole.log(Proto.isPrototypeOf(dummyService)); // false\r\n\r\n```\r\nThat test won't work after cloning Uberproto."}}