{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/25426","labels_url":"https://api.github.com/repos/saltstack/salt/issues/25426/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/25426/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/25426/events","html_url":"https://github.com/saltstack/salt/pull/25426","id":95047875,"number":25426,"title":"bugfix: trailing \"...done\" in rabbitmq output (backport from 'develop' to 2015.5)","user":{"login":"jquast","id":972584,"avatar_url":"https://avatars.githubusercontent.com/u/972584?v=3","gravatar_id":"","url":"https://api.github.com/users/jquast","html_url":"https://github.com/jquast","followers_url":"https://api.github.com/users/jquast/followers","following_url":"https://api.github.com/users/jquast/following{/other_user}","gists_url":"https://api.github.com/users/jquast/gists{/gist_id}","starred_url":"https://api.github.com/users/jquast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquast/subscriptions","organizations_url":"https://api.github.com/users/jquast/orgs","repos_url":"https://api.github.com/users/jquast/repos","events_url":"https://api.github.com/users/jquast/events{/privacy}","received_events_url":"https://api.github.com/users/jquast/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Execution%20Module","name":"Execution Module","color":"006b75"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Minor%20Change","name":"Minor Change","color":"bfe5bf"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Platform","name":"Platform","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-14T21:37:46Z","updated_at":"2015-07-15T14:48:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/25426","html_url":"https://github.com/saltstack/salt/pull/25426","diff_url":"https://github.com/saltstack/salt/pull/25426.diff","patch_url":"https://github.com/saltstack/salt/pull/25426.patch"},"body":"Problem\r\n-----------\r\n\r\nSome versions of rabbitmq (v3.4.1) does not output any final\r\n\"...done\" line in output of listings, but the given salt code\r\nunconditionally removed the final line of output, which may\r\noften result in inconsistent behavior of dependent state\r\nfunctions, where the final line has a value that is significant.\r\n\r\nSolution\r\n-----------\r\n\r\nThis bugfix changes this output manipulation to be conditional,\r\nmatching only lines of ``\"Listing ...\"`` as the first, and\r\n``\"...done\"`` as the last.\r\n\r\nDetails\r\n---------\r\n\r\nIn my environment::\r\n\r\n    [rabbitmq@db01 ~]$ rabbitmqctl list_vhosts\r\n    Listing vhosts ...\r\n    /\r\n\r\nThis causes issues in, for example, a vhost is attempted to\r\nbe created for '/' that already exists, if that vhost happens\r\nto be the last one listed in command output, it is thought\r\nnon-existent, resulting in state failure::\r\n\r\n    Failure: rabbitmq_vhost_|-rabbitmq-vhost_|-/_|-present: Creating vhost \"/\" ...\r\n    Error: vhost_already_exists: /"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/121639260","html_url":"https://github.com/saltstack/salt/pull/25426#issuecomment-121639260","issue_url":"https://api.github.com/repos/saltstack/salt/issues/25426","id":121639260,"user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T14:48:00Z","updated_at":"2015-07-15T14:48:00Z","body":"Most excellent! Thanks also for the detailed explanation. That makes it so much easier to review pull requests. :] I really appreciate it."}}