{"action":"created","issue":{"url":"https://api.github.com/repos/adazzle/react-data-grid/issues/118","labels_url":"https://api.github.com/repos/adazzle/react-data-grid/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/adazzle/react-data-grid/issues/118/comments","events_url":"https://api.github.com/repos/adazzle/react-data-grid/issues/118/events","html_url":"https://github.com/adazzle/react-data-grid/pull/118","id":119318109,"number":118,"title":"[fixed] Canvas cdu method to not make extra call to setScrollLeft in always truth condition","user":{"login":"ptkach","id":3469726,"avatar_url":"https://avatars.githubusercontent.com/u/3469726?v=3","gravatar_id":"","url":"https://api.github.com/users/ptkach","html_url":"https://github.com/ptkach","followers_url":"https://api.github.com/users/ptkach/followers","following_url":"https://api.github.com/users/ptkach/following{/other_user}","gists_url":"https://api.github.com/users/ptkach/gists{/gist_id}","starred_url":"https://api.github.com/users/ptkach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptkach/subscriptions","organizations_url":"https://api.github.com/users/ptkach/orgs","repos_url":"https://api.github.com/users/ptkach/repos","events_url":"https://api.github.com/users/ptkach/events{/privacy}","received_events_url":"https://api.github.com/users/ptkach/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-28T21:12:57Z","updated_at":"2015-12-03T16:43:26Z","closed_at":"2015-12-03T16:43:26Z","pull_request":{"url":"https://api.github.com/repos/adazzle/react-data-grid/pulls/118","html_url":"https://github.com/adazzle/react-data-grid/pull/118","diff_url":"https://github.com/adazzle/react-data-grid/pull/118.diff","patch_url":"https://github.com/adazzle/react-data-grid/pull/118.patch"},"body":"if (this._scroll !== {start: 0, end: 0}) is always true and it causes extra call to setScrollLeft which iterates through the columns. And when there're huge amount of columns it hits the performance. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/adazzle/react-data-grid/issues/comments/161710553","html_url":"https://github.com/adazzle/react-data-grid/pull/118#issuecomment-161710553","issue_url":"https://api.github.com/repos/adazzle/react-data-grid/issues/118","id":161710553,"user":{"login":"bakesteve","id":605712,"avatar_url":"https://avatars.githubusercontent.com/u/605712?v=3","gravatar_id":"","url":"https://api.github.com/users/bakesteve","html_url":"https://github.com/bakesteve","followers_url":"https://api.github.com/users/bakesteve/followers","following_url":"https://api.github.com/users/bakesteve/following{/other_user}","gists_url":"https://api.github.com/users/bakesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/bakesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakesteve/subscriptions","organizations_url":"https://api.github.com/users/bakesteve/orgs","repos_url":"https://api.github.com/users/bakesteve/repos","events_url":"https://api.github.com/users/bakesteve/events{/privacy}","received_events_url":"https://api.github.com/users/bakesteve/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T16:43:26Z","updated_at":"2015-12-03T16:43:26Z","body":"rather than removing this check, we need to change this to `if (this._scroll !== { scrollTop: 0, scrollLeft: 0 }` so we'll make that change\r\nthanks for reporting the bug though. I'll update here when the fix is up"}}