{"action":"created","issue":{"url":"https://api.github.com/repos/ubuntu/ubuntu-make/issues/154","labels_url":"https://api.github.com/repos/ubuntu/ubuntu-make/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/ubuntu/ubuntu-make/issues/154/comments","events_url":"https://api.github.com/repos/ubuntu/ubuntu-make/issues/154/events","html_url":"https://github.com/ubuntu/ubuntu-make/pull/154","id":109232198,"number":154,"title":"Install dir","user":{"login":"oijazsh","id":13085633,"avatar_url":"https://avatars.githubusercontent.com/u/13085633?v=3","gravatar_id":"","url":"https://api.github.com/users/oijazsh","html_url":"https://github.com/oijazsh","followers_url":"https://api.github.com/users/oijazsh/followers","following_url":"https://api.github.com/users/oijazsh/following{/other_user}","gists_url":"https://api.github.com/users/oijazsh/gists{/gist_id}","starred_url":"https://api.github.com/users/oijazsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oijazsh/subscriptions","organizations_url":"https://api.github.com/users/oijazsh/orgs","repos_url":"https://api.github.com/users/oijazsh/repos","events_url":"https://api.github.com/users/oijazsh/events{/privacy}","received_events_url":"https://api.github.com/users/oijazsh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-01T05:31:20Z","updated_at":"2015-10-10T18:45:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ubuntu/ubuntu-make/pulls/154","html_url":"https://github.com/ubuntu/ubuntu-make/pull/154","diff_url":"https://github.com/ubuntu/ubuntu-make/pull/154.diff","patch_url":"https://github.com/ubuntu/ubuntu-make/pull/154.patch"},"body":"This PR changes default install directory to $XDG_DATA_HOME/umake (#81). All paths used in tests have been changed to ~/.local/share/umake and a separate test has been added to confirm installation with $XDG_DATA_HOME set - similar to the existing test custom install path. \r\n\r\nFor the new test, I could not think of a more elegant way to set an environment variable in a running container so I simply used /bin/bash -c \"export $XDG_DATA_HOME && /bin/umake\"'. This required changing the run_in_umake_dir script to not strip the quotations - and then make changes accordingly.\r\n\r\nI should mention that I have not been able to rerun all of the large tests due a rather slow Internet connection."},"comment":{"url":"https://api.github.com/repos/ubuntu/ubuntu-make/issues/comments/147115610","html_url":"https://github.com/ubuntu/ubuntu-make/pull/154#issuecomment-147115610","issue_url":"https://api.github.com/repos/ubuntu/ubuntu-make/issues/154","id":147115610,"user":{"login":"oijazsh","id":13085633,"avatar_url":"https://avatars.githubusercontent.com/u/13085633?v=3","gravatar_id":"","url":"https://api.github.com/users/oijazsh","html_url":"https://github.com/oijazsh","followers_url":"https://api.github.com/users/oijazsh/followers","following_url":"https://api.github.com/users/oijazsh/following{/other_user}","gists_url":"https://api.github.com/users/oijazsh/gists{/gist_id}","starred_url":"https://api.github.com/users/oijazsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oijazsh/subscriptions","organizations_url":"https://api.github.com/users/oijazsh/orgs","repos_url":"https://api.github.com/users/oijazsh/repos","events_url":"https://api.github.com/users/oijazsh/events{/privacy}","received_events_url":"https://api.github.com/users/oijazsh/received_events","type":"User","site_admin":false},"created_at":"2015-10-10T18:45:57Z","updated_at":"2015-10-10T18:45:57Z","body":"I've rebased on the latest master branch and run the pep8, small and medium tests. I went with your approach for setting the environment variables. The large tests still need to be run so it'll be grand if you could setup a jenkins job. :smiley: "}}