{"action":"created","issue":{"url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/17","labels_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/17/comments","events_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/17/events","html_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/17","id":94436866,"number":17,"title":"MediaRanker","user":{"login":"wangg131","id":10188898,"avatar_url":"https://avatars.githubusercontent.com/u/10188898?v=3","gravatar_id":"","url":"https://api.github.com/users/wangg131","html_url":"https://github.com/wangg131","followers_url":"https://api.github.com/users/wangg131/followers","following_url":"https://api.github.com/users/wangg131/following{/other_user}","gists_url":"https://api.github.com/users/wangg131/gists{/gist_id}","starred_url":"https://api.github.com/users/wangg131/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangg131/subscriptions","organizations_url":"https://api.github.com/users/wangg131/orgs","repos_url":"https://api.github.com/users/wangg131/repos","events_url":"https://api.github.com/users/wangg131/events{/privacy}","received_events_url":"https://api.github.com/users/wangg131/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mhotan","id":2236795,"avatar_url":"https://avatars.githubusercontent.com/u/2236795?v=3","gravatar_id":"","url":"https://api.github.com/users/mhotan","html_url":"https://github.com/mhotan","followers_url":"https://api.github.com/users/mhotan/followers","following_url":"https://api.github.com/users/mhotan/following{/other_user}","gists_url":"https://api.github.com/users/mhotan/gists{/gist_id}","starred_url":"https://api.github.com/users/mhotan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhotan/subscriptions","organizations_url":"https://api.github.com/users/mhotan/orgs","repos_url":"https://api.github.com/users/mhotan/repos","events_url":"https://api.github.com/users/mhotan/events{/privacy}","received_events_url":"https://api.github.com/users/mhotan/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-07-11T04:57:03Z","updated_at":"2015-07-31T04:04:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/pulls/17","html_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/17","diff_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/17.diff","patch_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/17.patch"},"body":"I enjoyed this project a lot. If there was more time, I would have DRYed up the code by having just one form for new, edit, show, and index shared amongst each of the 3 models, possibly with polymorphic paths. Will also have to look into `shared examples` for RSPECs. \r\n \r\nI replicated the original website pretty well, but there are a few minor spacing issues that I am going to fix this weekend. One thing is that on each of the mediums' show pages, the DELETE button seems to be out of order despite it being in order on each of their view pages. I can't figure out why this bizarre behavior is happening... If someone could explain what is going on, that would be awesome.\r\n\r\nBootstrap is awesome! Can't wait to do more with it along with JS.\r\n\r\nAside from using shared examples to dry up common RSPEC code amongst the 3 models, it would be cool to get feedback on opportunities to improve the structure of the code in my controller and model RSPEC files.\r\n\r\nLooking forward to your suggestions! Thanks"},"comment":{"url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/comments/126561176","html_url":"https://github.com/Ada-Developers-Academy/C3Projects--MediaRanker/pull/17#issuecomment-126561176","issue_url":"https://api.github.com/repos/Ada-Developers-Academy/C3Projects--MediaRanker/issues/17","id":126561176,"user":{"login":"mhotan","id":2236795,"avatar_url":"https://avatars.githubusercontent.com/u/2236795?v=3","gravatar_id":"","url":"https://api.github.com/users/mhotan","html_url":"https://github.com/mhotan","followers_url":"https://api.github.com/users/mhotan/followers","following_url":"https://api.github.com/users/mhotan/following{/other_user}","gists_url":"https://api.github.com/users/mhotan/gists{/gist_id}","starred_url":"https://api.github.com/users/mhotan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhotan/subscriptions","organizations_url":"https://api.github.com/users/mhotan/orgs","repos_url":"https://api.github.com/users/mhotan/repos","events_url":"https://api.github.com/users/mhotan/events{/privacy}","received_events_url":"https://api.github.com/users/mhotan/received_events","type":"User","site_admin":false},"created_at":"2015-07-31T04:04:27Z","updated_at":"2015-07-31T04:04:27Z","body":"Overrall good work.  Very clean easy to read code.  The only thing I saw is a little overduplication of code in a few places.  Try your best to maintain DRY principles.  I have found that reviewing your initial pass of working (passing) test code to do explicit refactoring is helpful.  Attempt to identify each file and see if there is any way you can refactor code for re use in other places.  Good job and I am sorry I am not better at rails... :-|"}}