{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/36375588","id":36375588,"diff_hunk":"@@ -1487,19 +1487,32 @@ func ValidateResourceRequirements(requirements *api.ResourceRequirements) errs.V\n \tallErrs := errs.ValidationErrorList{}\n \tfor resourceName, quantity := range requirements.Limits {\n \t\t// Validate resource name.\n-\t\terrs := validateResourceName(resourceName.String(), fmt.Sprintf(\"resources.limits[%s]\", resourceName))\n+\t\tallErrs = append(allErrs, validateResourceName(resourceName.String(), fmt.Sprintf(\"resources.limits[%s]\", resourceName))...)","path":"pkg/api/validation/validation.go","position":5,"original_position":5,"commit_id":"2b414de78b186fd71d4ff4470ad1ac99ef5a5a64","original_commit_id":"7f7637aeb748486fb1a2e3ca3ed9d1e741d59e83","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"body":":-(. Consistency is more important than correctness. I'll make a note of this elsewhere.","created_at":"2015-08-06T01:58:28Z","updated_at":"2015-08-06T01:58:28Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12035#discussion_r36375588","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12035","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/36375588"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12035#discussion_r36375588"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12035"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12035","id":41275144,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12035","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12035.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12035.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12035","number":12035,"state":"open","locked":false,"title":"Add support for request","user":{"login":"AnanyaKumar","id":1862850,"avatar_url":"https://avatars.githubusercontent.com/u/1862850?v=3","gravatar_id":"","url":"https://api.github.com/users/AnanyaKumar","html_url":"https://github.com/AnanyaKumar","followers_url":"https://api.github.com/users/AnanyaKumar/followers","following_url":"https://api.github.com/users/AnanyaKumar/following{/other_user}","gists_url":"https://api.github.com/users/AnanyaKumar/gists{/gist_id}","starred_url":"https://api.github.com/users/AnanyaKumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnanyaKumar/subscriptions","organizations_url":"https://api.github.com/users/AnanyaKumar/orgs","repos_url":"https://api.github.com/users/AnanyaKumar/repos","events_url":"https://api.github.com/users/AnanyaKumar/events{/privacy}","received_events_url":"https://api.github.com/users/AnanyaKumar/received_events","type":"User","site_admin":false},"body":"@vishh @vmarmol @dchen1107","created_at":"2015-07-30T19:57:08Z","updated_at":"2015-08-06T01:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06218549dbf1098636ae5eae97ca65e98c6b78be","assignee":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12035/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12035/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12035/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/2b414de78b186fd71d4ff4470ad1ac99ef5a5a64","head":{"label":"AnanyaKumar:requests","ref":"requests","sha":"2b414de78b186fd71d4ff4470ad1ac99ef5a5a64","user":{"login":"AnanyaKumar","id":1862850,"avatar_url":"https://avatars.githubusercontent.com/u/1862850?v=3","gravatar_id":"","url":"https://api.github.com/users/AnanyaKumar","html_url":"https://github.com/AnanyaKumar","followers_url":"https://api.github.com/users/AnanyaKumar/followers","following_url":"https://api.github.com/users/AnanyaKumar/following{/other_user}","gists_url":"https://api.github.com/users/AnanyaKumar/gists{/gist_id}","starred_url":"https://api.github.com/users/AnanyaKumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnanyaKumar/subscriptions","organizations_url":"https://api.github.com/users/AnanyaKumar/orgs","repos_url":"https://api.github.com/users/AnanyaKumar/repos","events_url":"https://api.github.com/users/AnanyaKumar/events{/privacy}","received_events_url":"https://api.github.com/users/AnanyaKumar/received_events","type":"User","site_admin":false},"repo":{"id":37498217,"name":"kubernetes","full_name":"AnanyaKumar/kubernetes","owner":{"login":"AnanyaKumar","id":1862850,"avatar_url":"https://avatars.githubusercontent.com/u/1862850?v=3","gravatar_id":"","url":"https://api.github.com/users/AnanyaKumar","html_url":"https://github.com/AnanyaKumar","followers_url":"https://api.github.com/users/AnanyaKumar/followers","following_url":"https://api.github.com/users/AnanyaKumar/following{/other_user}","gists_url":"https://api.github.com/users/AnanyaKumar/gists{/gist_id}","starred_url":"https://api.github.com/users/AnanyaKumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnanyaKumar/subscriptions","organizations_url":"https://api.github.com/users/AnanyaKumar/orgs","repos_url":"https://api.github.com/users/AnanyaKumar/repos","events_url":"https://api.github.com/users/AnanyaKumar/events{/privacy}","received_events_url":"https://api.github.com/users/AnanyaKumar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnanyaKumar/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/AnanyaKumar/kubernetes","forks_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/forks","keys_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/teams","hooks_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/events","assignees_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/tags","blobs_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/languages","stargazers_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/subscription","commits_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/merges","archive_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/downloads","issues_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/AnanyaKumar/kubernetes/releases{/id}","created_at":"2015-06-16T00:14:24Z","updated_at":"2015-06-16T00:14:30Z","pushed_at":"2015-08-06T01:49:03Z","git_url":"git://github.com/AnanyaKumar/kubernetes.git","ssh_url":"git@github.com:AnanyaKumar/kubernetes.git","clone_url":"https://github.com/AnanyaKumar/kubernetes.git","svn_url":"https://github.com/AnanyaKumar/kubernetes","homepage":null,"size":95269,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"9a3fb3cb1f6156c1b889a2bbc1eb10d0dd6ff0fa","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-06T01:43:20Z","pushed_at":"2015-08-06T01:49:04Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":332284,"stargazers_count":9546,"watchers_count":9546,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2251,"mirror_url":null,"open_issues_count":1722,"forks":2251,"open_issues":1722,"watchers":9546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12035"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12035"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12035"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12035/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12035/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12035/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/2b414de78b186fd71d4ff4470ad1ac99ef5a5a64"}}}}