{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/41280556","id":41280556,"diff_hunk":"@@ -725,7 +716,7 @@ public void join(IntPair rec1, Record rec2, Collector<Record> out) throws Except\n \t\t}\n \t}\n \t\n-\tstatic final class IntPairRecordPairComparator extends TypePairComparator<IntPair, Record>\n+\tstatic final class IntPairRecordPairComparator extends TypePairComparator<IntPair, Tuple2<Integer, String>>","path":"flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/NonReusingHashMatchIteratorITCase.java","position":608,"original_position":608,"commit_id":"1e1de5f34c7964af70d7d84e7731e8bbe478d270","original_commit_id":"1e1de5f34c7964af70d7d84e7731e8bbe478d270","user":{"login":"fhueske","id":2388347,"avatar_url":"https://avatars.githubusercontent.com/u/2388347?v=3","gravatar_id":"","url":"https://api.github.com/users/fhueske","html_url":"https://github.com/fhueske","followers_url":"https://api.github.com/users/fhueske/followers","following_url":"https://api.github.com/users/fhueske/following{/other_user}","gists_url":"https://api.github.com/users/fhueske/gists{/gist_id}","starred_url":"https://api.github.com/users/fhueske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhueske/subscriptions","organizations_url":"https://api.github.com/users/fhueske/orgs","repos_url":"https://api.github.com/users/fhueske/repos","events_url":"https://api.github.com/users/fhueske/events{/privacy}","received_events_url":"https://api.github.com/users/fhueske/received_events","type":"User","site_admin":false},"body":"IntPairTuplePairComparator","created_at":"2015-10-06T15:36:32Z","updated_at":"2015-10-06T15:36:32Z","html_url":"https://github.com/apache/flink/pull/1160#discussion_r41280556","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/1160","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/41280556"},"html":{"href":"https://github.com/apache/flink/pull/1160#discussion_r41280556"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/1160"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/1160","id":45578358,"html_url":"https://github.com/apache/flink/pull/1160","diff_url":"https://github.com/apache/flink/pull/1160.diff","patch_url":"https://github.com/apache/flink/pull/1160.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/1160","number":1160,"state":"open","locked":false,"title":"[FLINK-2479] Refactor runtime.operators.* tests","user":{"login":"zentol","id":5725237,"avatar_url":"https://avatars.githubusercontent.com/u/5725237?v=3","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"body":"This PR refactors most runtime.operators tests to use the TupleGenerator introduced in FLINK-2105.\r\n\r\nThe changes made can generally be summed up as replacing usages of Records with Tuple2\\<Integer, String\\> and adjusting serializers/comparators accordingly. I've added a few static helper methods to the TestData class to simplify comparator/serializer(factory) creation.\r\n\r\nOne oddball change is the introduction of a separate IntPairComparator whose hash() implementation uses the underlying IntComparators hash() method, to be in line with the TupleComparators implementation.","created_at":"2015-09-21T17:49:39Z","updated_at":"2015-10-06T15:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"babce9d4e331c8f5b48447a6e95584215bcbe706","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/1160/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/1160/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/1160/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/1e1de5f34c7964af70d7d84e7731e8bbe478d270","head":{"label":"zentol:2479_testdata_pr","ref":"2479_testdata_pr","sha":"1e1de5f34c7964af70d7d84e7731e8bbe478d270","user":{"login":"zentol","id":5725237,"avatar_url":"https://avatars.githubusercontent.com/u/5725237?v=3","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"repo":{"id":20647396,"name":"flink","full_name":"zentol/flink","owner":{"login":"zentol","id":5725237,"avatar_url":"https://avatars.githubusercontent.com/u/5725237?v=3","gravatar_id":"","url":"https://api.github.com/users/zentol","html_url":"https://github.com/zentol","followers_url":"https://api.github.com/users/zentol/followers","following_url":"https://api.github.com/users/zentol/following{/other_user}","gists_url":"https://api.github.com/users/zentol/gists{/gist_id}","starred_url":"https://api.github.com/users/zentol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentol/subscriptions","organizations_url":"https://api.github.com/users/zentol/orgs","repos_url":"https://api.github.com/users/zentol/repos","events_url":"https://api.github.com/users/zentol/events{/privacy}","received_events_url":"https://api.github.com/users/zentol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zentol/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/zentol/flink","forks_url":"https://api.github.com/repos/zentol/flink/forks","keys_url":"https://api.github.com/repos/zentol/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zentol/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zentol/flink/teams","hooks_url":"https://api.github.com/repos/zentol/flink/hooks","issue_events_url":"https://api.github.com/repos/zentol/flink/issues/events{/number}","events_url":"https://api.github.com/repos/zentol/flink/events","assignees_url":"https://api.github.com/repos/zentol/flink/assignees{/user}","branches_url":"https://api.github.com/repos/zentol/flink/branches{/branch}","tags_url":"https://api.github.com/repos/zentol/flink/tags","blobs_url":"https://api.github.com/repos/zentol/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zentol/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zentol/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/zentol/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zentol/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/zentol/flink/languages","stargazers_url":"https://api.github.com/repos/zentol/flink/stargazers","contributors_url":"https://api.github.com/repos/zentol/flink/contributors","subscribers_url":"https://api.github.com/repos/zentol/flink/subscribers","subscription_url":"https://api.github.com/repos/zentol/flink/subscription","commits_url":"https://api.github.com/repos/zentol/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/zentol/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/zentol/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/zentol/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/zentol/flink/contents/{+path}","compare_url":"https://api.github.com/repos/zentol/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zentol/flink/merges","archive_url":"https://api.github.com/repos/zentol/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zentol/flink/downloads","issues_url":"https://api.github.com/repos/zentol/flink/issues{/number}","pulls_url":"https://api.github.com/repos/zentol/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/zentol/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/zentol/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zentol/flink/labels{/name}","releases_url":"https://api.github.com/repos/zentol/flink/releases{/id}","created_at":"2014-06-09T13:27:33Z","updated_at":"2015-07-31T11:31:03Z","pushed_at":"2015-09-30T14:19:59Z","git_url":"git://github.com/zentol/flink.git","ssh_url":"git@github.com:zentol/flink.git","clone_url":"https://github.com/zentol/flink.git","svn_url":"https://github.com/zentol/flink","homepage":null,"size":64005,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b9663c40754f522648f33dd7f56f2a47232c3836","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","created_at":"2014-06-07T07:00:10Z","updated_at":"2015-10-05T15:49:25Z","pushed_at":"2015-10-06T15:21:58Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":2589605,"stargazers_count":657,"watchers_count":657,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":447,"mirror_url":"git://git.apache.org/incubator-flink.git","open_issues_count":73,"forks":447,"open_issues":73,"watchers":657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/1160"},"html":{"href":"https://github.com/apache/flink/pull/1160"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/1160"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/1160/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/1160/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/1160/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/1e1de5f34c7964af70d7d84e7731e8bbe478d270"}}}}