{"action":"opened","number":219,"pull_request":{"url":"https://api.github.com/repos/opencomputeproject/onie/pulls/219","id":38937174,"html_url":"https://github.com/opencomputeproject/onie/pull/219","diff_url":"https://github.com/opencomputeproject/onie/pull/219.diff","patch_url":"https://github.com/opencomputeproject/onie/pull/219.patch","issue_url":"https://api.github.com/repos/opencomputeproject/onie/issues/219","number":219,"state":"open","locked":false,"title":"image discovery waterfall: add well known server name","user":{"login":"cbrune","id":344659,"avatar_url":"https://avatars.githubusercontent.com/u/344659?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrune","html_url":"https://github.com/cbrune","followers_url":"https://api.github.com/users/cbrune/followers","following_url":"https://api.github.com/users/cbrune/following{/other_user}","gists_url":"https://api.github.com/users/cbrune/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrune/subscriptions","organizations_url":"https://api.github.com/users/cbrune/orgs","repos_url":"https://api.github.com/users/cbrune/repos","events_url":"https://api.github.com/users/cbrune/events{/privacy}","received_events_url":"https://api.github.com/users/cbrune/received_events","type":"User","site_admin":false},"body":"This patch adds a \"well known\" hostname to the list of servers used\r\nduring the image discovery waterfall process.  The default ONIE server\r\nname is \"onie-server\".\r\n\r\nThis server name is added to the list of servers used during the HTTP\r\nwaterfall and TFTP waterfall.\r\n\r\nFixes #203\r\n\r\nQuoting the issue:\r\n\r\n  This gives flexibility in deployments where the users have control\r\n  over the DNS server, but not over the DHCP server.\r\n\r\n  For example a user could set their laptop to the host name\r\n  \"onie-server\" when making a DHCP request -- as is common in simple\r\n  lab environments and home routers, the host name \"onie-server\" will\r\n  be added to the local DNS domain. Then the user can start up a\r\n  simple python based ONIE server on the laptop and ONIE will find the\r\n  image via the host name \"onie-server\".\r\n\r\nTesting Done:\r\n\r\nTested both the HTTP and TFTP waterfalls using the fsl_p2020rdbpca\r\n(powerpc) reference platform.\r\n\r\n1. The demo OS installer image was placed at the root of an HTTP\r\nserver, whose hostname was \"onie-server\", using one of the default OS\r\ninstaller image names.  The HTTP image discovery process correctly\r\nlocated, downloaded and installed the image.\r\n\r\n2. The demo OS installer image was placed at the root of an TFTP\r\nserver, whose hostname was \"onie-server\", using one of the default OS\r\ninstaller image names.  The TFTP image discovery process correctly\r\nlocated, downloaded and installed the image.\r\n\r\nSigned-off-by: Curt Brune <curt@cumulusnetworks.com>","created_at":"2015-07-01T00:04:12Z","updated_at":"2015-07-01T00:04:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/219/commits","review_comments_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/219/comments","review_comment_url":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencomputeproject/onie/issues/219/comments","statuses_url":"https://api.github.com/repos/opencomputeproject/onie/statuses/6ca45558dfde35555c985bab76d21f5ebea40ef2","head":{"label":"cbrune:hostname-waterfall","ref":"hostname-waterfall","sha":"6ca45558dfde35555c985bab76d21f5ebea40ef2","user":{"login":"cbrune","id":344659,"avatar_url":"https://avatars.githubusercontent.com/u/344659?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrune","html_url":"https://github.com/cbrune","followers_url":"https://api.github.com/users/cbrune/followers","following_url":"https://api.github.com/users/cbrune/following{/other_user}","gists_url":"https://api.github.com/users/cbrune/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrune/subscriptions","organizations_url":"https://api.github.com/users/cbrune/orgs","repos_url":"https://api.github.com/users/cbrune/repos","events_url":"https://api.github.com/users/cbrune/events{/privacy}","received_events_url":"https://api.github.com/users/cbrune/received_events","type":"User","site_admin":false},"repo":{"id":22216675,"name":"onie","full_name":"cbrune/onie","owner":{"login":"cbrune","id":344659,"avatar_url":"https://avatars.githubusercontent.com/u/344659?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrune","html_url":"https://github.com/cbrune","followers_url":"https://api.github.com/users/cbrune/followers","following_url":"https://api.github.com/users/cbrune/following{/other_user}","gists_url":"https://api.github.com/users/cbrune/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrune/subscriptions","organizations_url":"https://api.github.com/users/cbrune/orgs","repos_url":"https://api.github.com/users/cbrune/repos","events_url":"https://api.github.com/users/cbrune/events{/privacy}","received_events_url":"https://api.github.com/users/cbrune/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbrune/onie","description":"This is the code repository for ONIE.","fork":true,"url":"https://api.github.com/repos/cbrune/onie","forks_url":"https://api.github.com/repos/cbrune/onie/forks","keys_url":"https://api.github.com/repos/cbrune/onie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbrune/onie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbrune/onie/teams","hooks_url":"https://api.github.com/repos/cbrune/onie/hooks","issue_events_url":"https://api.github.com/repos/cbrune/onie/issues/events{/number}","events_url":"https://api.github.com/repos/cbrune/onie/events","assignees_url":"https://api.github.com/repos/cbrune/onie/assignees{/user}","branches_url":"https://api.github.com/repos/cbrune/onie/branches{/branch}","tags_url":"https://api.github.com/repos/cbrune/onie/tags","blobs_url":"https://api.github.com/repos/cbrune/onie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbrune/onie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbrune/onie/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbrune/onie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbrune/onie/statuses/{sha}","languages_url":"https://api.github.com/repos/cbrune/onie/languages","stargazers_url":"https://api.github.com/repos/cbrune/onie/stargazers","contributors_url":"https://api.github.com/repos/cbrune/onie/contributors","subscribers_url":"https://api.github.com/repos/cbrune/onie/subscribers","subscription_url":"https://api.github.com/repos/cbrune/onie/subscription","commits_url":"https://api.github.com/repos/cbrune/onie/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbrune/onie/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbrune/onie/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbrune/onie/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbrune/onie/contents/{+path}","compare_url":"https://api.github.com/repos/cbrune/onie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbrune/onie/merges","archive_url":"https://api.github.com/repos/cbrune/onie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbrune/onie/downloads","issues_url":"https://api.github.com/repos/cbrune/onie/issues{/number}","pulls_url":"https://api.github.com/repos/cbrune/onie/pulls{/number}","milestones_url":"https://api.github.com/repos/cbrune/onie/milestones{/number}","notifications_url":"https://api.github.com/repos/cbrune/onie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbrune/onie/labels{/name}","releases_url":"https://api.github.com/repos/cbrune/onie/releases{/id}","created_at":"2014-07-24T14:45:13Z","updated_at":"2015-03-27T17:07:36Z","pushed_at":"2015-07-01T00:03:47Z","git_url":"git://github.com/cbrune/onie.git","ssh_url":"git@github.com:cbrune/onie.git","clone_url":"https://github.com/cbrune/onie.git","svn_url":"https://github.com/cbrune/onie","homepage":null,"size":92791,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"opencomputeproject:master","ref":"master","sha":"79992b6fe5734ebaad03999622e84a423d6205fa","user":{"login":"opencomputeproject","id":4722382,"avatar_url":"https://avatars.githubusercontent.com/u/4722382?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"User","site_admin":false},"repo":{"id":21219871,"name":"onie","full_name":"opencomputeproject/onie","owner":{"login":"opencomputeproject","id":4722382,"avatar_url":"https://avatars.githubusercontent.com/u/4722382?v=3","gravatar_id":"","url":"https://api.github.com/users/opencomputeproject","html_url":"https://github.com/opencomputeproject","followers_url":"https://api.github.com/users/opencomputeproject/followers","following_url":"https://api.github.com/users/opencomputeproject/following{/other_user}","gists_url":"https://api.github.com/users/opencomputeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/opencomputeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencomputeproject/subscriptions","organizations_url":"https://api.github.com/users/opencomputeproject/orgs","repos_url":"https://api.github.com/users/opencomputeproject/repos","events_url":"https://api.github.com/users/opencomputeproject/events{/privacy}","received_events_url":"https://api.github.com/users/opencomputeproject/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/opencomputeproject/onie","description":"This is the code repository for ONIE.","fork":false,"url":"https://api.github.com/repos/opencomputeproject/onie","forks_url":"https://api.github.com/repos/opencomputeproject/onie/forks","keys_url":"https://api.github.com/repos/opencomputeproject/onie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencomputeproject/onie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencomputeproject/onie/teams","hooks_url":"https://api.github.com/repos/opencomputeproject/onie/hooks","issue_events_url":"https://api.github.com/repos/opencomputeproject/onie/issues/events{/number}","events_url":"https://api.github.com/repos/opencomputeproject/onie/events","assignees_url":"https://api.github.com/repos/opencomputeproject/onie/assignees{/user}","branches_url":"https://api.github.com/repos/opencomputeproject/onie/branches{/branch}","tags_url":"https://api.github.com/repos/opencomputeproject/onie/tags","blobs_url":"https://api.github.com/repos/opencomputeproject/onie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencomputeproject/onie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencomputeproject/onie/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencomputeproject/onie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencomputeproject/onie/statuses/{sha}","languages_url":"https://api.github.com/repos/opencomputeproject/onie/languages","stargazers_url":"https://api.github.com/repos/opencomputeproject/onie/stargazers","contributors_url":"https://api.github.com/repos/opencomputeproject/onie/contributors","subscribers_url":"https://api.github.com/repos/opencomputeproject/onie/subscribers","subscription_url":"https://api.github.com/repos/opencomputeproject/onie/subscription","commits_url":"https://api.github.com/repos/opencomputeproject/onie/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencomputeproject/onie/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencomputeproject/onie/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencomputeproject/onie/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencomputeproject/onie/contents/{+path}","compare_url":"https://api.github.com/repos/opencomputeproject/onie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencomputeproject/onie/merges","archive_url":"https://api.github.com/repos/opencomputeproject/onie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencomputeproject/onie/downloads","issues_url":"https://api.github.com/repos/opencomputeproject/onie/issues{/number}","pulls_url":"https://api.github.com/repos/opencomputeproject/onie/pulls{/number}","milestones_url":"https://api.github.com/repos/opencomputeproject/onie/milestones{/number}","notifications_url":"https://api.github.com/repos/opencomputeproject/onie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencomputeproject/onie/labels{/name}","releases_url":"https://api.github.com/repos/opencomputeproject/onie/releases{/id}","created_at":"2014-06-25T21:52:35Z","updated_at":"2015-06-29T22:42:07Z","pushed_at":"2015-06-30T23:03:14Z","git_url":"git://github.com/opencomputeproject/onie.git","ssh_url":"git@github.com:opencomputeproject/onie.git","clone_url":"https://github.com/opencomputeproject/onie.git","svn_url":"https://github.com/opencomputeproject/onie","homepage":null,"size":95555,"stargazers_count":62,"watchers_count":62,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":19,"forks":48,"open_issues":19,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/219"},"html":{"href":"https://github.com/opencomputeproject/onie/pull/219"},"issue":{"href":"https://api.github.com/repos/opencomputeproject/onie/issues/219"},"comments":{"href":"https://api.github.com/repos/opencomputeproject/onie/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencomputeproject/onie/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/opencomputeproject/onie/statuses/6ca45558dfde35555c985bab76d21f5ebea40ef2"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":4,"changed_files":2}}