{"action":"created","issue":{"url":"https://api.github.com/repos/square/p2/issues/228","labels_url":"https://api.github.com/repos/square/p2/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/square/p2/issues/228/comments","events_url":"https://api.github.com/repos/square/p2/issues/228/events","html_url":"https://github.com/square/p2/pull/228","id":102868566,"number":228,"title":"Fix buggy unit test","user":{"login":"bwester","id":1501338,"avatar_url":"https://avatars.githubusercontent.com/u/1501338?v=3","gravatar_id":"","url":"https://api.github.com/users/bwester","html_url":"https://github.com/bwester","followers_url":"https://api.github.com/users/bwester/followers","following_url":"https://api.github.com/users/bwester/following{/other_user}","gists_url":"https://api.github.com/users/bwester/gists{/gist_id}","starred_url":"https://api.github.com/users/bwester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwester/subscriptions","organizations_url":"https://api.github.com/users/bwester/orgs","repos_url":"https://api.github.com/users/bwester/repos","events_url":"https://api.github.com/users/bwester/events{/privacy}","received_events_url":"https://api.github.com/users/bwester/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-24T19:05:01Z","updated_at":"2015-08-24T19:08:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/228","html_url":"https://github.com/square/p2/pull/228","diff_url":"https://github.com/square/p2/pull/228.diff","patch_url":"https://github.com/square/p2/pull/228.patch"},"body":"The unit tests for the \"stream\" package failed with output:\r\n\r\n    --- FAIL: TestUnsubscribeIndependence-2 (0.00s)\r\n            publisher_test.go:251: sub2 got unexpected sequence: []\r\n\r\nThe unit test created a StringValuePublisher, subscribed to it. A value was\r\nsent to the publisher, and afterwards the subscription was canceled. It was\r\nexpected that \"[]\" would not be received because the send of the value would\r\nblock until the subscriber had received at least the initial value.\r\n\r\nAfter taking a second look at the synchronization, that behavior wasn't\r\naccurate. Even if it was, the test was flaky because it depended on the\r\nimplementation details of the publisher rather than its high-level behavioral\r\ncontract. The only truly buggy behavior is if the subscription receives a value\r\nthat was published after the subscription was canceled."},"comment":{"url":"https://api.github.com/repos/square/p2/issues/comments/134343393","html_url":"https://github.com/square/p2/pull/228#issuecomment-134343393","issue_url":"https://api.github.com/repos/square/p2/issues/228","id":134343393,"user":{"login":"mpuncel","id":1444855,"avatar_url":"https://avatars.githubusercontent.com/u/1444855?v=3","gravatar_id":"","url":"https://api.github.com/users/mpuncel","html_url":"https://github.com/mpuncel","followers_url":"https://api.github.com/users/mpuncel/followers","following_url":"https://api.github.com/users/mpuncel/following{/other_user}","gists_url":"https://api.github.com/users/mpuncel/gists{/gist_id}","starred_url":"https://api.github.com/users/mpuncel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpuncel/subscriptions","organizations_url":"https://api.github.com/users/mpuncel/orgs","repos_url":"https://api.github.com/users/mpuncel/repos","events_url":"https://api.github.com/users/mpuncel/events{/privacy}","received_events_url":"https://api.github.com/users/mpuncel/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T19:08:30Z","updated_at":"2015-08-24T19:08:30Z","body":":+1: "}}