{"action":"closed","number":452,"pull_request":{"url":"https://api.github.com/repos/acl2/acl2/pulls/452","id":39921052,"html_url":"https://github.com/acl2/acl2/pull/452","diff_url":"https://github.com/acl2/acl2/pull/452.diff","patch_url":"https://github.com/acl2/acl2/pull/452.patch","issue_url":"https://api.github.com/repos/acl2/acl2/issues/452","number":452,"state":"closed","locked":false,"title":"Certify defsort/remove-dups in ACL2(r)","user":{"login":"nadezhin","id":1213537,"avatar_url":"https://avatars.githubusercontent.com/u/1213537?v=3","gravatar_id":"","url":"https://api.github.com/users/nadezhin","html_url":"https://github.com/nadezhin","followers_url":"https://api.github.com/users/nadezhin/followers","following_url":"https://api.github.com/users/nadezhin/following{/other_user}","gists_url":"https://api.github.com/users/nadezhin/gists{/gist_id}","starred_url":"https://api.github.com/users/nadezhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadezhin/subscriptions","organizations_url":"https://api.github.com/users/nadezhin/orgs","repos_url":"https://api.github.com/users/nadezhin/repos","events_url":"https://api.github.com/users/nadezhin/events{/privacy}","received_events_url":"https://api.github.com/users/nadezhin/received_events","type":"User","site_admin":false},"body":"The book `defsort/remove-dups` was marked as `non-acl2r` though its topic is far from reals.\r\nThe reason is definition of function `remove-adjacent-duplicates`. It is defined in the system ACL2 book `induct.lisp` in ACL2(r) mode with slightly different signature. This conflict prevents ACL2(r) to certify this book.\r\n\r\nDifference is in treating lists that are not true lists. The version in `defstort/remove-dups` ensures that output list is `true-listp` even when input list is not `true-listp`. The version in `induct.lisp` passes endp atom from input list to output list.\r\n\r\nI suggest to change definition in `induct.lisp` so that it matched the definition in the community book.\r\nI request to verify that it is safe.","created_at":"2015-07-14T14:25:49Z","updated_at":"2015-07-14T17:21:06Z","closed_at":"2015-07-14T17:21:06Z","merged_at":null,"merge_commit_sha":"cf3ab8ef4d210086dd99b38d30bf477a695ba4e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/acl2/acl2/pulls/452/commits","review_comments_url":"https://api.github.com/repos/acl2/acl2/pulls/452/comments","review_comment_url":"https://api.github.com/repos/acl2/acl2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acl2/acl2/issues/452/comments","statuses_url":"https://api.github.com/repos/acl2/acl2/statuses/ffe48e57a88865cb7f3e827b951cc72f3d7d47b5","head":{"label":"nadezhin:remove-adjacent-duplicates","ref":"remove-adjacent-duplicates","sha":"ffe48e57a88865cb7f3e827b951cc72f3d7d47b5","user":{"login":"nadezhin","id":1213537,"avatar_url":"https://avatars.githubusercontent.com/u/1213537?v=3","gravatar_id":"","url":"https://api.github.com/users/nadezhin","html_url":"https://github.com/nadezhin","followers_url":"https://api.github.com/users/nadezhin/followers","following_url":"https://api.github.com/users/nadezhin/following{/other_user}","gists_url":"https://api.github.com/users/nadezhin/gists{/gist_id}","starred_url":"https://api.github.com/users/nadezhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadezhin/subscriptions","organizations_url":"https://api.github.com/users/nadezhin/orgs","repos_url":"https://api.github.com/users/nadezhin/repos","events_url":"https://api.github.com/users/nadezhin/events{/privacy}","received_events_url":"https://api.github.com/users/nadezhin/received_events","type":"User","site_admin":false},"repo":{"id":28403764,"name":"acl2","full_name":"nadezhin/acl2","owner":{"login":"nadezhin","id":1213537,"avatar_url":"https://avatars.githubusercontent.com/u/1213537?v=3","gravatar_id":"","url":"https://api.github.com/users/nadezhin","html_url":"https://github.com/nadezhin","followers_url":"https://api.github.com/users/nadezhin/followers","following_url":"https://api.github.com/users/nadezhin/following{/other_user}","gists_url":"https://api.github.com/users/nadezhin/gists{/gist_id}","starred_url":"https://api.github.com/users/nadezhin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadezhin/subscriptions","organizations_url":"https://api.github.com/users/nadezhin/orgs","repos_url":"https://api.github.com/users/nadezhin/repos","events_url":"https://api.github.com/users/nadezhin/events{/privacy}","received_events_url":"https://api.github.com/users/nadezhin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nadezhin/acl2","description":"ACL2 System and Books as Maintained by the Community","fork":true,"url":"https://api.github.com/repos/nadezhin/acl2","forks_url":"https://api.github.com/repos/nadezhin/acl2/forks","keys_url":"https://api.github.com/repos/nadezhin/acl2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nadezhin/acl2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nadezhin/acl2/teams","hooks_url":"https://api.github.com/repos/nadezhin/acl2/hooks","issue_events_url":"https://api.github.com/repos/nadezhin/acl2/issues/events{/number}","events_url":"https://api.github.com/repos/nadezhin/acl2/events","assignees_url":"https://api.github.com/repos/nadezhin/acl2/assignees{/user}","branches_url":"https://api.github.com/repos/nadezhin/acl2/branches{/branch}","tags_url":"https://api.github.com/repos/nadezhin/acl2/tags","blobs_url":"https://api.github.com/repos/nadezhin/acl2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nadezhin/acl2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nadezhin/acl2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nadezhin/acl2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nadezhin/acl2/statuses/{sha}","languages_url":"https://api.github.com/repos/nadezhin/acl2/languages","stargazers_url":"https://api.github.com/repos/nadezhin/acl2/stargazers","contributors_url":"https://api.github.com/repos/nadezhin/acl2/contributors","subscribers_url":"https://api.github.com/repos/nadezhin/acl2/subscribers","subscription_url":"https://api.github.com/repos/nadezhin/acl2/subscription","commits_url":"https://api.github.com/repos/nadezhin/acl2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nadezhin/acl2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nadezhin/acl2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nadezhin/acl2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nadezhin/acl2/contents/{+path}","compare_url":"https://api.github.com/repos/nadezhin/acl2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nadezhin/acl2/merges","archive_url":"https://api.github.com/repos/nadezhin/acl2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nadezhin/acl2/downloads","issues_url":"https://api.github.com/repos/nadezhin/acl2/issues{/number}","pulls_url":"https://api.github.com/repos/nadezhin/acl2/pulls{/number}","milestones_url":"https://api.github.com/repos/nadezhin/acl2/milestones{/number}","notifications_url":"https://api.github.com/repos/nadezhin/acl2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nadezhin/acl2/labels{/name}","releases_url":"https://api.github.com/repos/nadezhin/acl2/releases{/id}","created_at":"2014-12-23T15:02:10Z","updated_at":"2015-04-24T12:05:37Z","pushed_at":"2015-07-14T14:12:22Z","git_url":"git://github.com/nadezhin/acl2.git","ssh_url":"git@github.com:nadezhin/acl2.git","clone_url":"https://github.com/nadezhin/acl2.git","svn_url":"https://github.com/nadezhin/acl2","homepage":"","size":157525,"stargazers_count":0,"watchers_count":0,"language":"Common Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"acl2:master","ref":"master","sha":"9bb72282dbe45b22618dbf74146188c61829c74b","user":{"login":"acl2","id":5464462,"avatar_url":"https://avatars.githubusercontent.com/u/5464462?v=3","gravatar_id":"","url":"https://api.github.com/users/acl2","html_url":"https://github.com/acl2","followers_url":"https://api.github.com/users/acl2/followers","following_url":"https://api.github.com/users/acl2/following{/other_user}","gists_url":"https://api.github.com/users/acl2/gists{/gist_id}","starred_url":"https://api.github.com/users/acl2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acl2/subscriptions","organizations_url":"https://api.github.com/users/acl2/orgs","repos_url":"https://api.github.com/users/acl2/repos","events_url":"https://api.github.com/users/acl2/events{/privacy}","received_events_url":"https://api.github.com/users/acl2/received_events","type":"Organization","site_admin":false},"repo":{"id":23556724,"name":"acl2","full_name":"acl2/acl2","owner":{"login":"acl2","id":5464462,"avatar_url":"https://avatars.githubusercontent.com/u/5464462?v=3","gravatar_id":"","url":"https://api.github.com/users/acl2","html_url":"https://github.com/acl2","followers_url":"https://api.github.com/users/acl2/followers","following_url":"https://api.github.com/users/acl2/following{/other_user}","gists_url":"https://api.github.com/users/acl2/gists{/gist_id}","starred_url":"https://api.github.com/users/acl2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acl2/subscriptions","organizations_url":"https://api.github.com/users/acl2/orgs","repos_url":"https://api.github.com/users/acl2/repos","events_url":"https://api.github.com/users/acl2/events{/privacy}","received_events_url":"https://api.github.com/users/acl2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acl2/acl2","description":"ACL2 System and Books as Maintained by the Community","fork":false,"url":"https://api.github.com/repos/acl2/acl2","forks_url":"https://api.github.com/repos/acl2/acl2/forks","keys_url":"https://api.github.com/repos/acl2/acl2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acl2/acl2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acl2/acl2/teams","hooks_url":"https://api.github.com/repos/acl2/acl2/hooks","issue_events_url":"https://api.github.com/repos/acl2/acl2/issues/events{/number}","events_url":"https://api.github.com/repos/acl2/acl2/events","assignees_url":"https://api.github.com/repos/acl2/acl2/assignees{/user}","branches_url":"https://api.github.com/repos/acl2/acl2/branches{/branch}","tags_url":"https://api.github.com/repos/acl2/acl2/tags","blobs_url":"https://api.github.com/repos/acl2/acl2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acl2/acl2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acl2/acl2/git/refs{/sha}","trees_url":"https://api.github.com/repos/acl2/acl2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acl2/acl2/statuses/{sha}","languages_url":"https://api.github.com/repos/acl2/acl2/languages","stargazers_url":"https://api.github.com/repos/acl2/acl2/stargazers","contributors_url":"https://api.github.com/repos/acl2/acl2/contributors","subscribers_url":"https://api.github.com/repos/acl2/acl2/subscribers","subscription_url":"https://api.github.com/repos/acl2/acl2/subscription","commits_url":"https://api.github.com/repos/acl2/acl2/commits{/sha}","git_commits_url":"https://api.github.com/repos/acl2/acl2/git/commits{/sha}","comments_url":"https://api.github.com/repos/acl2/acl2/comments{/number}","issue_comment_url":"https://api.github.com/repos/acl2/acl2/issues/comments{/number}","contents_url":"https://api.github.com/repos/acl2/acl2/contents/{+path}","compare_url":"https://api.github.com/repos/acl2/acl2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acl2/acl2/merges","archive_url":"https://api.github.com/repos/acl2/acl2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acl2/acl2/downloads","issues_url":"https://api.github.com/repos/acl2/acl2/issues{/number}","pulls_url":"https://api.github.com/repos/acl2/acl2/pulls{/number}","milestones_url":"https://api.github.com/repos/acl2/acl2/milestones{/number}","notifications_url":"https://api.github.com/repos/acl2/acl2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acl2/acl2/labels{/name}","releases_url":"https://api.github.com/repos/acl2/acl2/releases{/id}","created_at":"2014-09-01T21:51:04Z","updated_at":"2015-07-03T23:39:55Z","pushed_at":"2015-07-14T14:57:10Z","git_url":"git://github.com/acl2/acl2.git","ssh_url":"git@github.com:acl2/acl2.git","clone_url":"https://github.com/acl2/acl2.git","svn_url":"https://github.com/acl2/acl2","homepage":"http://www.cs.utexas.edu/users/moore/acl2","size":182288,"stargazers_count":21,"watchers_count":21,"language":"Common Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":81,"forks":17,"open_issues":81,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acl2/acl2/pulls/452"},"html":{"href":"https://github.com/acl2/acl2/pull/452"},"issue":{"href":"https://api.github.com/repos/acl2/acl2/issues/452"},"comments":{"href":"https://api.github.com/repos/acl2/acl2/issues/452/comments"},"review_comments":{"href":"https://api.github.com/repos/acl2/acl2/pulls/452/comments"},"review_comment":{"href":"https://api.github.com/repos/acl2/acl2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acl2/acl2/pulls/452/commits"},"statuses":{"href":"https://api.github.com/repos/acl2/acl2/statuses/ffe48e57a88865cb7f3e827b951cc72f3d7d47b5"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":10,"deletions":7,"changed_files":2}}