{"action":"created","comment":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/47119781","id":47119781,"diff_hunk":"@@ -1054,6 +1054,44 @@ static void __ep_destruct(void *obj)\n \n \tGNIX_TRACE(FI_LOG_EP_CTRL, \"\\n\");\n \n+\t/*\n+\t * complete any outstanding fab reqs\n+\t * on this EP\n+\t */\n+\twhile (atomic_get(&ep->active_fab_reqs) != 0) {\n+\t\tret = _gnix_nic_progress(ep->nic);\n+\t\tif (ret != GNI_RC_SUCCESS)\n+\t\t\tGNIX_WARN(FI_LOG_EP_CTRL,\n+\t\t\t\t\"_gnix_nic_progress returned %s\\n\",\n+\t\t\t\t  fi_strerror(-ret));\n+\t}","path":"prov/gni/src/gnix_ep.c","position":14,"original_position":14,"commit_id":"2943fa334087dc38b9dc34ffe02a1277c327bd3e","original_commit_id":"2943fa334087dc38b9dc34ffe02a1277c327bd3e","user":{"login":"sungeunchoi","id":4294511,"avatar_url":"https://avatars.githubusercontent.com/u/4294511?v=3","gravatar_id":"","url":"https://api.github.com/users/sungeunchoi","html_url":"https://github.com/sungeunchoi","followers_url":"https://api.github.com/users/sungeunchoi/followers","following_url":"https://api.github.com/users/sungeunchoi/following{/other_user}","gists_url":"https://api.github.com/users/sungeunchoi/gists{/gist_id}","starred_url":"https://api.github.com/users/sungeunchoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sungeunchoi/subscriptions","organizations_url":"https://api.github.com/users/sungeunchoi/orgs","repos_url":"https://api.github.com/users/sungeunchoi/repos","events_url":"https://api.github.com/users/sungeunchoi/events{/privacy}","received_events_url":"https://api.github.com/users/sungeunchoi/received_events","type":"User","site_admin":false},"body":"Is it possible that this could be an infinite loop?  If so we might we want to eventually time out here in some fashion (either time or number of tries).","created_at":"2015-12-09T17:05:05Z","updated_at":"2015-12-09T17:05:05Z","html_url":"https://github.com/ofi-cray/libfabric-cray/pull/563#discussion_r47119781","pull_request_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/563","_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/47119781"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/563#discussion_r47119781"},"pull_request":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/563"}}},"pull_request":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/563","id":53063217,"html_url":"https://github.com/ofi-cray/libfabric-cray/pull/563","diff_url":"https://github.com/ofi-cray/libfabric-cray/pull/563.diff","patch_url":"https://github.com/ofi-cray/libfabric-cray/pull/563.patch","issue_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/563","number":563,"state":"open","locked":false,"title":"prov/gni: improve EP shutdown process","user":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"body":"The active fab reqs associated with an ep (those not\r\non the freelist) actually do need to be tracked to\r\nproperly shutdown the endpoint upon ```fi_close``` of the\r\nfid.\r\n\r\nAlso, make sure that GNI internally has completed\r\nall outgoing transactions - GNI SMSG, etc. by\r\ncalling GNI_EpUnbind in the _gnix_vc_destroy method.\r\n\r\n@ztiffany \r\n@sungeunchoi \r\n\r\nSigned-off-by: Howard Pritchard <howardp@lanl.gov>","created_at":"2015-12-09T01:03:33Z","updated_at":"2015-12-09T17:05:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"155ab6d2606296be888a2f1cf513b88c2c3d6c57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/563/commits","review_comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/563/comments","review_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/563/comments","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/2943fa334087dc38b9dc34ffe02a1277c327bd3e","head":{"label":"hppritcha:topic/ep_fab_req_cnt","ref":"topic/ep_fab_req_cnt","sha":"2943fa334087dc38b9dc34ffe02a1277c327bd3e","user":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"repo":{"id":29201359,"name":"libfabric","full_name":"hppritcha/libfabric","owner":{"login":"hppritcha","id":7818666,"avatar_url":"https://avatars.githubusercontent.com/u/7818666?v=3","gravatar_id":"","url":"https://api.github.com/users/hppritcha","html_url":"https://github.com/hppritcha","followers_url":"https://api.github.com/users/hppritcha/followers","following_url":"https://api.github.com/users/hppritcha/following{/other_user}","gists_url":"https://api.github.com/users/hppritcha/gists{/gist_id}","starred_url":"https://api.github.com/users/hppritcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hppritcha/subscriptions","organizations_url":"https://api.github.com/users/hppritcha/orgs","repos_url":"https://api.github.com/users/hppritcha/repos","events_url":"https://api.github.com/users/hppritcha/events{/privacy}","received_events_url":"https://api.github.com/users/hppritcha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hppritcha/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/hppritcha/libfabric","forks_url":"https://api.github.com/repos/hppritcha/libfabric/forks","keys_url":"https://api.github.com/repos/hppritcha/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hppritcha/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hppritcha/libfabric/teams","hooks_url":"https://api.github.com/repos/hppritcha/libfabric/hooks","issue_events_url":"https://api.github.com/repos/hppritcha/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/hppritcha/libfabric/events","assignees_url":"https://api.github.com/repos/hppritcha/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/hppritcha/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/hppritcha/libfabric/tags","blobs_url":"https://api.github.com/repos/hppritcha/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hppritcha/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hppritcha/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/hppritcha/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hppritcha/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/hppritcha/libfabric/languages","stargazers_url":"https://api.github.com/repos/hppritcha/libfabric/stargazers","contributors_url":"https://api.github.com/repos/hppritcha/libfabric/contributors","subscribers_url":"https://api.github.com/repos/hppritcha/libfabric/subscribers","subscription_url":"https://api.github.com/repos/hppritcha/libfabric/subscription","commits_url":"https://api.github.com/repos/hppritcha/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/hppritcha/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/hppritcha/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/hppritcha/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/hppritcha/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/hppritcha/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hppritcha/libfabric/merges","archive_url":"https://api.github.com/repos/hppritcha/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hppritcha/libfabric/downloads","issues_url":"https://api.github.com/repos/hppritcha/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/hppritcha/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/hppritcha/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/hppritcha/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hppritcha/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/hppritcha/libfabric/releases{/id}","created_at":"2015-01-13T17:14:54Z","updated_at":"2015-04-30T20:43:53Z","pushed_at":"2015-12-09T15:28:39Z","git_url":"git://github.com/hppritcha/libfabric.git","ssh_url":"git@github.com:hppritcha/libfabric.git","clone_url":"https://github.com/hppritcha/libfabric.git","svn_url":"https://github.com/hppritcha/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":9952,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofi-cray:master","ref":"master","sha":"44e8fab7d3068d3ce1113742f0bc9a98bf525003","user":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"repo":{"id":29607348,"name":"libfabric-cray","full_name":"ofi-cray/libfabric-cray","owner":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofi-cray/libfabric-cray","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/ofi-cray/libfabric-cray","forks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/forks","keys_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/teams","hooks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/hooks","issue_events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/events{/number}","events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/events","assignees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/assignees{/user}","branches_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/branches{/branch}","tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/tags","blobs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/{sha}","languages_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/languages","stargazers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/stargazers","contributors_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contributors","subscribers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscribers","subscription_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscription","commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contents/{+path}","compare_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/merges","archive_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/downloads","issues_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues{/number}","pulls_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls{/number}","milestones_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/milestones{/number}","notifications_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/labels{/name}","releases_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/releases{/id}","created_at":"2015-01-21T19:30:52Z","updated_at":"2015-11-17T22:47:02Z","pushed_at":"2015-12-09T01:03:33Z","git_url":"git://github.com/ofi-cray/libfabric-cray.git","ssh_url":"git@github.com:ofi-cray/libfabric-cray.git","clone_url":"https://github.com/ofi-cray/libfabric-cray.git","svn_url":"https://github.com/ofi-cray/libfabric-cray","homepage":"http://ofiwg.github.io/libfabric/","size":11910,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":58,"forks":6,"open_issues":58,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/563"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/563"},"issue":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/563"},"comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/2943fa334087dc38b9dc34ffe02a1277c327bd3e"}}}}