{"action":"created","comment":{"url":"https://api.github.com/repos/groupops/auction_ui/pulls/comments/44425909","id":44425909,"diff_hunk":"@@ -0,0 +1,27 @@\n+package com.epam.training.auction.service;\n+\n+import com.epam.training.auction.common.UserTransferObject;\n+import com.epam.training.auction.common.UsersService;\n+import org.apache.log4j.Logger;\n+import org.springframework.beans.factory.annotation.Autowired;\n+import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;\n+import org.springframework.stereotype.Service;\n+\n+@Service\n+public final class RegistrationServiceImpl implements RegistrationService {\n+    private static final Logger LOG = Logger.getLogger(RegistrationServiceImpl.class);\n+    @Autowired\n+    private BCryptPasswordEncoder passwordEncoder;\n+\n+    @Autowired\n+    private UsersService usersService;\n+","path":"src/main/java/com/epam/training/auction/service/RegistrationServiceImpl.java","position":null,"original_position":18,"commit_id":"92f58201b040769134ceb73a3342ddcbfc1599c9","original_commit_id":"2a4d0c2cc878c715742164b188846053e997bb84","user":{"login":"GUSb","id":7485617,"avatar_url":"https://avatars.githubusercontent.com/u/7485617?v=3","gravatar_id":"","url":"https://api.github.com/users/GUSb","html_url":"https://github.com/GUSb","followers_url":"https://api.github.com/users/GUSb/followers","following_url":"https://api.github.com/users/GUSb/following{/other_user}","gists_url":"https://api.github.com/users/GUSb/gists{/gist_id}","starred_url":"https://api.github.com/users/GUSb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GUSb/subscriptions","organizations_url":"https://api.github.com/users/GUSb/orgs","repos_url":"https://api.github.com/users/GUSb/repos","events_url":"https://api.github.com/users/GUSb/events{/privacy}","received_events_url":"https://api.github.com/users/GUSb/received_events","type":"User","site_admin":false},"body":"And in this case its better to sue DI through constructor","created_at":"2015-11-10T16:13:48Z","updated_at":"2015-11-10T16:13:48Z","html_url":"https://github.com/groupops/auction_ui/pull/5#discussion_r44425909","pull_request_url":"https://api.github.com/repos/groupops/auction_ui/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/groupops/auction_ui/pulls/comments/44425909"},"html":{"href":"https://github.com/groupops/auction_ui/pull/5#discussion_r44425909"},"pull_request":{"href":"https://api.github.com/repos/groupops/auction_ui/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/groupops/auction_ui/pulls/5","id":50270551,"html_url":"https://github.com/groupops/auction_ui/pull/5","diff_url":"https://github.com/groupops/auction_ui/pull/5.diff","patch_url":"https://github.com/groupops/auction_ui/pull/5.patch","issue_url":"https://api.github.com/repos/groupops/auction_ui/issues/5","number":5,"state":"open","locked":false,"title":"refactoring & integration","user":{"login":"outsidereal","id":2109878,"avatar_url":"https://avatars.githubusercontent.com/u/2109878?v=3","gravatar_id":"","url":"https://api.github.com/users/outsidereal","html_url":"https://github.com/outsidereal","followers_url":"https://api.github.com/users/outsidereal/followers","following_url":"https://api.github.com/users/outsidereal/following{/other_user}","gists_url":"https://api.github.com/users/outsidereal/gists{/gist_id}","starred_url":"https://api.github.com/users/outsidereal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outsidereal/subscriptions","organizations_url":"https://api.github.com/users/outsidereal/orgs","repos_url":"https://api.github.com/users/outsidereal/repos","events_url":"https://api.github.com/users/outsidereal/events{/privacy}","received_events_url":"https://api.github.com/users/outsidereal/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-10T15:51:57Z","updated_at":"2015-11-10T16:13:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8a17864206960d6b373a3f19ed9c172706c6b5c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/groupops/auction_ui/pulls/5/commits","review_comments_url":"https://api.github.com/repos/groupops/auction_ui/pulls/5/comments","review_comment_url":"https://api.github.com/repos/groupops/auction_ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/groupops/auction_ui/issues/5/comments","statuses_url":"https://api.github.com/repos/groupops/auction_ui/statuses/92f58201b040769134ceb73a3342ddcbfc1599c9","head":{"label":"groupops:ulanovych_integration","ref":"ulanovych_integration","sha":"92f58201b040769134ceb73a3342ddcbfc1599c9","user":{"login":"groupops","id":14926897,"avatar_url":"https://avatars.githubusercontent.com/u/14926897?v=3","gravatar_id":"","url":"https://api.github.com/users/groupops","html_url":"https://github.com/groupops","followers_url":"https://api.github.com/users/groupops/followers","following_url":"https://api.github.com/users/groupops/following{/other_user}","gists_url":"https://api.github.com/users/groupops/gists{/gist_id}","starred_url":"https://api.github.com/users/groupops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupops/subscriptions","organizations_url":"https://api.github.com/users/groupops/orgs","repos_url":"https://api.github.com/users/groupops/repos","events_url":"https://api.github.com/users/groupops/events{/privacy}","received_events_url":"https://api.github.com/users/groupops/received_events","type":"Organization","site_admin":false},"repo":{"id":44974036,"name":"auction_ui","full_name":"groupops/auction_ui","owner":{"login":"groupops","id":14926897,"avatar_url":"https://avatars.githubusercontent.com/u/14926897?v=3","gravatar_id":"","url":"https://api.github.com/users/groupops","html_url":"https://github.com/groupops","followers_url":"https://api.github.com/users/groupops/followers","following_url":"https://api.github.com/users/groupops/following{/other_user}","gists_url":"https://api.github.com/users/groupops/gists{/gist_id}","starred_url":"https://api.github.com/users/groupops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupops/subscriptions","organizations_url":"https://api.github.com/users/groupops/orgs","repos_url":"https://api.github.com/users/groupops/repos","events_url":"https://api.github.com/users/groupops/events{/privacy}","received_events_url":"https://api.github.com/users/groupops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/groupops/auction_ui","description":"Auction House: Front-end part, web based application","fork":false,"url":"https://api.github.com/repos/groupops/auction_ui","forks_url":"https://api.github.com/repos/groupops/auction_ui/forks","keys_url":"https://api.github.com/repos/groupops/auction_ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groupops/auction_ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groupops/auction_ui/teams","hooks_url":"https://api.github.com/repos/groupops/auction_ui/hooks","issue_events_url":"https://api.github.com/repos/groupops/auction_ui/issues/events{/number}","events_url":"https://api.github.com/repos/groupops/auction_ui/events","assignees_url":"https://api.github.com/repos/groupops/auction_ui/assignees{/user}","branches_url":"https://api.github.com/repos/groupops/auction_ui/branches{/branch}","tags_url":"https://api.github.com/repos/groupops/auction_ui/tags","blobs_url":"https://api.github.com/repos/groupops/auction_ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groupops/auction_ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groupops/auction_ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/groupops/auction_ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groupops/auction_ui/statuses/{sha}","languages_url":"https://api.github.com/repos/groupops/auction_ui/languages","stargazers_url":"https://api.github.com/repos/groupops/auction_ui/stargazers","contributors_url":"https://api.github.com/repos/groupops/auction_ui/contributors","subscribers_url":"https://api.github.com/repos/groupops/auction_ui/subscribers","subscription_url":"https://api.github.com/repos/groupops/auction_ui/subscription","commits_url":"https://api.github.com/repos/groupops/auction_ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/groupops/auction_ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/groupops/auction_ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/groupops/auction_ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/groupops/auction_ui/contents/{+path}","compare_url":"https://api.github.com/repos/groupops/auction_ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groupops/auction_ui/merges","archive_url":"https://api.github.com/repos/groupops/auction_ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groupops/auction_ui/downloads","issues_url":"https://api.github.com/repos/groupops/auction_ui/issues{/number}","pulls_url":"https://api.github.com/repos/groupops/auction_ui/pulls{/number}","milestones_url":"https://api.github.com/repos/groupops/auction_ui/milestones{/number}","notifications_url":"https://api.github.com/repos/groupops/auction_ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groupops/auction_ui/labels{/name}","releases_url":"https://api.github.com/repos/groupops/auction_ui/releases{/id}","created_at":"2015-10-26T14:33:37Z","updated_at":"2015-10-26T15:25:04Z","pushed_at":"2015-11-10T16:13:04Z","git_url":"git://github.com/groupops/auction_ui.git","ssh_url":"git@github.com:groupops/auction_ui.git","clone_url":"https://github.com/groupops/auction_ui.git","svn_url":"https://github.com/groupops/auction_ui","homepage":null,"size":320,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"groupops:master","ref":"master","sha":"19fa057948ce540a1527ad6f783bb40f5eae080e","user":{"login":"groupops","id":14926897,"avatar_url":"https://avatars.githubusercontent.com/u/14926897?v=3","gravatar_id":"","url":"https://api.github.com/users/groupops","html_url":"https://github.com/groupops","followers_url":"https://api.github.com/users/groupops/followers","following_url":"https://api.github.com/users/groupops/following{/other_user}","gists_url":"https://api.github.com/users/groupops/gists{/gist_id}","starred_url":"https://api.github.com/users/groupops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupops/subscriptions","organizations_url":"https://api.github.com/users/groupops/orgs","repos_url":"https://api.github.com/users/groupops/repos","events_url":"https://api.github.com/users/groupops/events{/privacy}","received_events_url":"https://api.github.com/users/groupops/received_events","type":"Organization","site_admin":false},"repo":{"id":44974036,"name":"auction_ui","full_name":"groupops/auction_ui","owner":{"login":"groupops","id":14926897,"avatar_url":"https://avatars.githubusercontent.com/u/14926897?v=3","gravatar_id":"","url":"https://api.github.com/users/groupops","html_url":"https://github.com/groupops","followers_url":"https://api.github.com/users/groupops/followers","following_url":"https://api.github.com/users/groupops/following{/other_user}","gists_url":"https://api.github.com/users/groupops/gists{/gist_id}","starred_url":"https://api.github.com/users/groupops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupops/subscriptions","organizations_url":"https://api.github.com/users/groupops/orgs","repos_url":"https://api.github.com/users/groupops/repos","events_url":"https://api.github.com/users/groupops/events{/privacy}","received_events_url":"https://api.github.com/users/groupops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/groupops/auction_ui","description":"Auction House: Front-end part, web based application","fork":false,"url":"https://api.github.com/repos/groupops/auction_ui","forks_url":"https://api.github.com/repos/groupops/auction_ui/forks","keys_url":"https://api.github.com/repos/groupops/auction_ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groupops/auction_ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groupops/auction_ui/teams","hooks_url":"https://api.github.com/repos/groupops/auction_ui/hooks","issue_events_url":"https://api.github.com/repos/groupops/auction_ui/issues/events{/number}","events_url":"https://api.github.com/repos/groupops/auction_ui/events","assignees_url":"https://api.github.com/repos/groupops/auction_ui/assignees{/user}","branches_url":"https://api.github.com/repos/groupops/auction_ui/branches{/branch}","tags_url":"https://api.github.com/repos/groupops/auction_ui/tags","blobs_url":"https://api.github.com/repos/groupops/auction_ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groupops/auction_ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groupops/auction_ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/groupops/auction_ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groupops/auction_ui/statuses/{sha}","languages_url":"https://api.github.com/repos/groupops/auction_ui/languages","stargazers_url":"https://api.github.com/repos/groupops/auction_ui/stargazers","contributors_url":"https://api.github.com/repos/groupops/auction_ui/contributors","subscribers_url":"https://api.github.com/repos/groupops/auction_ui/subscribers","subscription_url":"https://api.github.com/repos/groupops/auction_ui/subscription","commits_url":"https://api.github.com/repos/groupops/auction_ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/groupops/auction_ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/groupops/auction_ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/groupops/auction_ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/groupops/auction_ui/contents/{+path}","compare_url":"https://api.github.com/repos/groupops/auction_ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groupops/auction_ui/merges","archive_url":"https://api.github.com/repos/groupops/auction_ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groupops/auction_ui/downloads","issues_url":"https://api.github.com/repos/groupops/auction_ui/issues{/number}","pulls_url":"https://api.github.com/repos/groupops/auction_ui/pulls{/number}","milestones_url":"https://api.github.com/repos/groupops/auction_ui/milestones{/number}","notifications_url":"https://api.github.com/repos/groupops/auction_ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groupops/auction_ui/labels{/name}","releases_url":"https://api.github.com/repos/groupops/auction_ui/releases{/id}","created_at":"2015-10-26T14:33:37Z","updated_at":"2015-10-26T15:25:04Z","pushed_at":"2015-11-10T16:13:04Z","git_url":"git://github.com/groupops/auction_ui.git","ssh_url":"git@github.com:groupops/auction_ui.git","clone_url":"https://github.com/groupops/auction_ui.git","svn_url":"https://github.com/groupops/auction_ui","homepage":null,"size":320,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/groupops/auction_ui/pulls/5"},"html":{"href":"https://github.com/groupops/auction_ui/pull/5"},"issue":{"href":"https://api.github.com/repos/groupops/auction_ui/issues/5"},"comments":{"href":"https://api.github.com/repos/groupops/auction_ui/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/groupops/auction_ui/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/groupops/auction_ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/groupops/auction_ui/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/groupops/auction_ui/statuses/92f58201b040769134ceb73a3342ddcbfc1599c9"}}}}