{"push_id":819972082,"size":18,"distinct_size":3,"ref":"refs/heads/bg/lldp-rh1142898","head":"7ca8b619f0a936417246440764865ca0844579ee","before":"f9d29368f405bb08a99555bcd5e795d716e11941","commits":[{"sha":"687b6515980c08cdbb9734bd112a594166c4d6dd","author":{"email":"0517d8eb29a209176891315f89a61ea11bcc756e@redhat.com","name":"Jiří Klimeš"},"message":"libnm/vlan: default to vlan.flags=REORDER_HDR for new connections (rh #1250225)\n\nThe kernel defaults REORDER_HDR to 1 when creating a new VLAN, but\nNetworkManager's VLAN flags property defaulted to 0. Thus REORDER_HDR was not\nset for NM-created VLANs with default values.\n\nWe want to match the kernel default, so we change the default value for the\nvlan.flags property. However, we do not want to change the flags for existing\nconnections if the property is missing in connection files. Thus we have to\nupdate plugins for that. We also make sure that vlan.flags is always written\nby 'keyfile' when the value is default. That way new connections have flags\nproperty explicitly written and it will be loaded as expected.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1250225","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/687b6515980c08cdbb9734bd112a594166c4d6dd"},{"sha":"e8257af0d9324c2b9b59fa37c7283931c10defe1","author":{"email":"0517d8eb29a209176891315f89a61ea11bcc756e@redhat.com","name":"Jiří Klimeš"},"message":"ifcfg-rh: allow svTrueValue() to accept \"0\" and \"1\" values\n\nSome initscripts variables can use \"0\" or \"1\" instead of more common\n\"yes\", \"no\", for example REORDER_HDR.\n\nAnd we also write REORDER_HDR=0|1 in writer.c, so we did not read REODER_HDR\ncorrectly.\n\nFixes: ccea4425048cce8aef5a295c7d09daa6b66f596f","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/e8257af0d9324c2b9b59fa37c7283931c10defe1"},{"sha":"ee3c6d57a45ed855186ce4e208af4d855c495e9e","author":{"email":"0517d8eb29a209176891315f89a61ea11bcc756e@redhat.com","name":"Jiří Klimeš"},"message":"ifcfg-rh: write REORDER_HDR as more common \"yes\", \"no\"\n\ninitscripts just search for negative values \"no\" or \"0\"\n(/etc/sysconfig/network-scripts/ifup)\n\nRelated: ccea4425048cce8aef5a295c7d09daa6b66f596f","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/ee3c6d57a45ed855186ce4e208af4d855c495e9e"},{"sha":"76726b99221a1f9cc86061e75843b136a119f32e","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"dhcp-manager: fix memory leak in DHCP listener\n\nFixes: 7f6e39ec6ecc8c417603b39e6cc557bf79e593cf","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/76726b99221a1f9cc86061e75843b136a119f32e"},{"sha":"3abe1bb21a58bd943d065ce95886980e081ae48c","author":{"email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk","name":"Lubomir Rintel"},"message":"device: don't complain about repeated schedules of the same activation stage\n\nCan easily happend with a storm of DHCP responses or RAs before the idle\nhandler has a chance to run.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1269520","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/3abe1bb21a58bd943d065ce95886980e081ae48c"},{"sha":"e73e55c6ec703731a9d6c821cae33e4a4fd0721b","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device: update hw_addr_len before emitting signal in nm_device_update_hw_address()","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/e73e55c6ec703731a9d6c821cae33e4a4fd0721b"},{"sha":"d4d2e65eb7fee4486e386e62a2f9d405c320e1f0","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"macros: add NM_SET_OUT() macro","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/d4d2e65eb7fee4486e386e62a2f9d405c320e1f0"},{"sha":"78ca961c0fd0e5b563e33306299bd1058fa2e289","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device: refactor scheduling the activation source\n\nEvery activation-source handler first cleared the current\nactivation-source (activation_source_clear()) and later\nreturned FALSE/G_SOURCE_REMOVE.\n\nDo not directly attach the handlers to g_idle_add().\nInstead wrap the actual handler. This wrapper\n  - always clears the activation source first\n  - always returns G_SOURCE_REMOVE\n  - does trace logging about invoking the handler\n\nThis also avoids a possibility for a bug where the handler returns\nG_SOURCE_REMOVE, without also clearing activation_source_clear().","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/78ca961c0fd0e5b563e33306299bd1058fa2e289"},{"sha":"823ce8bf7338980c94fc9c694d133cbc1fd40aac","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device: rename nm_device_activate_*() functions\n\nThe function name is logged, so change them to be more suitable:\n\n  - drop the \"nm_device_\" prefix. It is redundant in the logging,\n    and usually our static functions don't have an nm-prefix.\n  - have all functions now start with \"activate_stagex_\". The\n    stage number corresponds to what we are currently logging\n    during activation:\n       \"Activation: Stage 1 of 5 (Device Prepare)...\"\n    No other functions start with a \"activate_stagex_\" prefix,\n    so it's easy to grep.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/823ce8bf7338980c94fc9c694d133cbc1fd40aac"},{"sha":"b343956d40fb53d3b4ff7002f8c84ff039dfff50","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device/logging: refactor logging for activation-stage\n\nInstead of adding explicit logging lines while scheduling and processing\nthe activation-stages, only log them in activation_source_schedule()\nand activation_source_handle_cb().\n\nEffectively, lines like:\n\n  \"Activation: Stage 1 of 5 (Device Prepare) started...\"\n\nare now:\n\n  \"activation-stage: invoke activate_stage1_device_prepare,2 (id x)\"","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/b343956d40fb53d3b4ff7002f8c84ff039dfff50"},{"sha":"061028961a31e048aa7cf0d43ef071f52f7b2441","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device: refactor setting firewall zone during activation-stage2\n\nschedule_stage3() used to set the firewall before really\nscheduling the stage3. In that case, fw_change_zone_cb() would\nthen directly call:\n  activation_source_schedule (self, activate_stage3_ip_config_start, AF_INET);\n\nThis was different from all other places. Usually, only the\nnm_device_schedule_*() functions would directly call to\nactivation_source_schedule().\n\nChange this, to behave similar as when we wait for master-ready\nwhile scheduling stage2. As such, it is more idiomatic, and\nit would still work correctly even if there were multiple conditions\nthat would block scheduling-stage3.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/061028961a31e048aa7cf0d43ef071f52f7b2441"},{"sha":"16522ec7f5b046661d1be49510d6cc9dea8cbe55","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"core: merge branch 'th/device-schedule-activation-bgo756129'\n\nhttps://bugzilla.gnome.org/show_bug.cgi?id=756129","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/16522ec7f5b046661d1be49510d6cc9dea8cbe55"},{"sha":"a8af3fae578e885cc6dda89eb490fe39bd7f32a0","author":{"email":"c9b9bbc6e9b0bc7e9cec5af1551c7b98adb9530c@v3.sk","name":"Lubomir Rintel"},"message":"dhcp-systemd: sd_dhcp_lease_load() returns no lease or error on ENOENT\n\nIf the lease file doesn't exist sd_dhcp_lease_load() still indicates\nsuccess while not returning any lease, resulting in an assertion fail\nwhen we try to generate an IP4Config:\n\n  #0  g_logv (log_domain=0x7f309b45dba0 \"NetworkManager\", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7ffc815c38e0) at gmessages.c:1046\n  #1  0x00007f3097d4fa3f in g_log (log_domain=log_domain@entry=0x7f309b45dba0 \"NetworkManager\", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7f3097dbd73d \"%s: assertion '%s' failed\")\n      at gmessages.c:1079\n  #2  0x00007f3097d4fa79 in g_return_if_fail_warning (log_domain=log_domain@entry=0x7f309b45dba0 \"NetworkManager\", pretty_function=pretty_function@entry=0x7f309b456b30 <__FUNCTION__.31435> \"lease_to_ip4_config\",\n      expression=expression@entry=0x7f309b456417 \"lease != NULL\") at gmessages.c:1088\n  #3  0x00007f309b35454a in lease_to_ip4_config (lease=0x0, options=options@entry=0x0, default_priority=default_priority@entry=100, log_lease=log_lease@entry=0, error=0x0) at dhcp-manager/nm-dhcp-systemd.c:230\n  #4  0x00007f309b3546a0 in nm_dhcp_systemd_get_lease_ip_configs (iface=<optimized out>, uuid=<optimized out>, ipv6=<optimized out>, default_route_metric=100) at dhcp-manager/nm-dhcp-systemd.c:397\n  #5  0x00007f309b35ed4a in find_ip4_lease_config (ext_ip4_config=0x7f309cbe8640, connection=0x7f309cb98250, self=0x7f309cbfb7b0) at devices/nm-device.c:7215\n  #6  capture_lease_config (ext_ip6_config=0x0, out_ip6_config=0x0, out_ip4_config=0x7f309cbfb5d0, ext_ip4_config=0x7f309cbe8640, self=0x7f309cbfb7b0) at devices/nm-device.c:7289\n  #7  update_ip4_config (self=self@entry=0x7f309cbfb7b0, initial=initial@entry=1) at devices/nm-device.c:7323\n  #8  0x00007f309b3608be in nm_device_capture_initial_config (self=self@entry=0x7f309cbfb7b0) at devices/nm-device.c:7428\n  #9  0x00007f309b3dbaad in get_existing_connection (out_generated=<synthetic pointer>, device=0x7f309cbfb7b0, manager=0x7f309cb7f150) at nm-manager.c:1550\n  #10 recheck_assume_connection (device=device@entry=0x7f309cbfb7b0, user_data=user_data@entry=0x7f309cb7f150) at nm-manager.c:1689\n  #11 0x00007f309b3dc62d in add_device (self=0x7f309cb7f150, device=0x7f309cbfb7b0, try_assume=1) at nm-manager.c:1875\n  #12 0x00007f309b3dcd10 in platform_link_added (self=self@entry=0x7f309cb7f150, ifindex=<optimized out>, plink=plink@entry=0x7f309cbcff40) at nm-manager.c:1984\n  #13 0x00007f309b3df7d4 in platform_query_devices (self=0x7f309cb7f150) at nm-manager.c:2056\n  #14 nm_manager_start (self=0x7f309cb7f150) at nm-manager.c:4220\n  #15 0x00007f309b341f2c in main (argc=1, argv=0x7ffc815c3f68) at main.c:494","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/a8af3fae578e885cc6dda89eb490fe39bd7f32a0"},{"sha":"68b3790ad36e4a140c43e96335e2be60ac935d76","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"libnm: explicitly cast enum type for g_object_set()\n\nFixes: 687b6515980c08cdbb9734bd112a594166c4d6dd","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/68b3790ad36e4a140c43e96335e2be60ac935d76"},{"sha":"90fb64024c5086601e6a1501a890890bc9b16499","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"merge: merge branch 'systemd' into master","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/90fb64024c5086601e6a1501a890890bc9b16499"},{"sha":"eb14da98f8fe97f538f7ee730ca70075a59dbc90","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"libnm,cli: add 'lldp' property to NMSettingConnection\n\nAdd the 'lldp' property to NMSettingConnection, which specifies\nwhether the reception and parsing of LLDP frames to discover neighbor\ndevices should be enabled.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/eb14da98f8fe97f538f7ee730ca70075a59dbc90"},{"sha":"49a01e70b27b8424911d35d60ebb82b80a87640f","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"device: export list of LLDP neighbors through D-Bus\n\nThis adds a LldpNeighbors property to the Device D-Bus interface\ncarrying information about devices discovered through LLDP. The\nproperty is an array of hashes and each hash describes the values of\nLLDP TLVs for a specific neighbor.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/49a01e70b27b8424911d35d60ebb82b80a87640f"},{"sha":"7ca8b619f0a936417246440764865ca0844579ee","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"libnm: add LLDP support\n\nAdd functions to libnm for retrieving a list of LLDP neighbors and\naccessor functions to get their attributes.","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/7ca8b619f0a936417246440764865ca0844579ee"}]}