{"action":"opened","number":29312,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/29312","id":52296894,"html_url":"https://github.com/saltstack/salt/pull/29312","diff_url":"https://github.com/saltstack/salt/pull/29312.diff","patch_url":"https://github.com/saltstack/salt/pull/29312.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/29312","number":29312,"state":"open","locked":false,"title":"Catch ValueError on timeout on non-existing key","user":{"login":"sjmh","id":12321,"avatar_url":"https://avatars.githubusercontent.com/u/12321?v=3","gravatar_id":"","url":"https://api.github.com/users/sjmh","html_url":"https://github.com/sjmh","followers_url":"https://api.github.com/users/sjmh/followers","following_url":"https://api.github.com/users/sjmh/following{/other_user}","gists_url":"https://api.github.com/users/sjmh/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmh/subscriptions","organizations_url":"https://api.github.com/users/sjmh/orgs","repos_url":"https://api.github.com/users/sjmh/repos","events_url":"https://api.github.com/users/sjmh/events{/privacy}","received_events_url":"https://api.github.com/users/sjmh/received_events","type":"User","site_admin":false},"body":"The etcd watch function tries to read a key when it reaches the timeout\r\nin order to obtain details about the key.\r\n\r\nOn python 2.6, when it tries to re-read the key, it throws a ValueError,\r\nsince python-etcd doesn't officially support python 2.6.  The watch\r\nfunction wasn't catching this ValueError, so it was returning the\r\nexception, rather than a blank dict.","created_at":"2015-12-01T18:34:39Z","updated_at":"2015-12-01T18:34:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/29312/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/29312/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/29312/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/cef6eff7c85cad53eb089ba58f52a916196b5742","head":{"label":"sjmh:fix/etcd_watch_valerr","ref":"fix/etcd_watch_valerr","sha":"cef6eff7c85cad53eb089ba58f52a916196b5742","user":{"login":"sjmh","id":12321,"avatar_url":"https://avatars.githubusercontent.com/u/12321?v=3","gravatar_id":"","url":"https://api.github.com/users/sjmh","html_url":"https://github.com/sjmh","followers_url":"https://api.github.com/users/sjmh/followers","following_url":"https://api.github.com/users/sjmh/following{/other_user}","gists_url":"https://api.github.com/users/sjmh/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmh/subscriptions","organizations_url":"https://api.github.com/users/sjmh/orgs","repos_url":"https://api.github.com/users/sjmh/repos","events_url":"https://api.github.com/users/sjmh/events{/privacy}","received_events_url":"https://api.github.com/users/sjmh/received_events","type":"User","site_admin":false},"repo":{"id":38702861,"name":"salt","full_name":"sjmh/salt","owner":{"login":"sjmh","id":12321,"avatar_url":"https://avatars.githubusercontent.com/u/12321?v=3","gravatar_id":"","url":"https://api.github.com/users/sjmh","html_url":"https://github.com/sjmh","followers_url":"https://api.github.com/users/sjmh/followers","following_url":"https://api.github.com/users/sjmh/following{/other_user}","gists_url":"https://api.github.com/users/sjmh/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmh/subscriptions","organizations_url":"https://api.github.com/users/sjmh/orgs","repos_url":"https://api.github.com/users/sjmh/repos","events_url":"https://api.github.com/users/sjmh/events{/privacy}","received_events_url":"https://api.github.com/users/sjmh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjmh/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/sjmh/salt","forks_url":"https://api.github.com/repos/sjmh/salt/forks","keys_url":"https://api.github.com/repos/sjmh/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjmh/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjmh/salt/teams","hooks_url":"https://api.github.com/repos/sjmh/salt/hooks","issue_events_url":"https://api.github.com/repos/sjmh/salt/issues/events{/number}","events_url":"https://api.github.com/repos/sjmh/salt/events","assignees_url":"https://api.github.com/repos/sjmh/salt/assignees{/user}","branches_url":"https://api.github.com/repos/sjmh/salt/branches{/branch}","tags_url":"https://api.github.com/repos/sjmh/salt/tags","blobs_url":"https://api.github.com/repos/sjmh/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjmh/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjmh/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjmh/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjmh/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/sjmh/salt/languages","stargazers_url":"https://api.github.com/repos/sjmh/salt/stargazers","contributors_url":"https://api.github.com/repos/sjmh/salt/contributors","subscribers_url":"https://api.github.com/repos/sjmh/salt/subscribers","subscription_url":"https://api.github.com/repos/sjmh/salt/subscription","commits_url":"https://api.github.com/repos/sjmh/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjmh/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjmh/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjmh/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjmh/salt/contents/{+path}","compare_url":"https://api.github.com/repos/sjmh/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjmh/salt/merges","archive_url":"https://api.github.com/repos/sjmh/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjmh/salt/downloads","issues_url":"https://api.github.com/repos/sjmh/salt/issues{/number}","pulls_url":"https://api.github.com/repos/sjmh/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/sjmh/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/sjmh/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjmh/salt/labels{/name}","releases_url":"https://api.github.com/repos/sjmh/salt/releases{/id}","created_at":"2015-07-07T17:14:13Z","updated_at":"2015-07-07T17:14:23Z","pushed_at":"2015-12-01T18:33:33Z","git_url":"git://github.com/sjmh/salt.git","ssh_url":"git@github.com:sjmh/salt.git","clone_url":"https://github.com/sjmh/salt.git","svn_url":"https://github.com/sjmh/salt","homepage":"saltstack.com","size":129101,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"a890307cc0157eefd2e9ee8b30c0e3dea4dfb949","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2015-12-01T18:32:14Z","pushed_at":"2015-12-01T18:28:08Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":143128,"stargazers_count":5943,"watchers_count":5943,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2565,"mirror_url":null,"open_issues_count":3198,"forks":2565,"open_issues":3198,"watchers":5943,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/29312"},"html":{"href":"https://github.com/saltstack/salt/pull/29312"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/29312"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/29312/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/29312/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/29312/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/cef6eff7c85cad53eb089ba58f52a916196b5742"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":0,"changed_files":2}}