{"action":"opened","issue":{"url":"https://api.github.com/repos/proteusthemes/WAI-ARIA-Walker_Nav_Menu/issues/1","labels_url":"https://api.github.com/repos/proteusthemes/WAI-ARIA-Walker_Nav_Menu/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/proteusthemes/WAI-ARIA-Walker_Nav_Menu/issues/1/comments","events_url":"https://api.github.com/repos/proteusthemes/WAI-ARIA-Walker_Nav_Menu/issues/1/events","html_url":"https://github.com/proteusthemes/WAI-ARIA-Walker_Nav_Menu/issues/1","id":110463009,"number":1,"title":"Use of role=menuitem and switching aria-haspopup to <a> rather than <li>?","user":{"login":"NateWr","id":2306629,"avatar_url":"https://avatars.githubusercontent.com/u/2306629?v=3","gravatar_id":"","url":"https://api.github.com/users/NateWr","html_url":"https://github.com/NateWr","followers_url":"https://api.github.com/users/NateWr/followers","following_url":"https://api.github.com/users/NateWr/following{/other_user}","gists_url":"https://api.github.com/users/NateWr/gists{/gist_id}","starred_url":"https://api.github.com/users/NateWr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateWr/subscriptions","organizations_url":"https://api.github.com/users/NateWr/orgs","repos_url":"https://api.github.com/users/NateWr/repos","events_url":"https://api.github.com/users/NateWr/events{/privacy}","received_events_url":"https://api.github.com/users/NateWr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-10-08T14:25:03Z","updated_at":"2015-10-08T14:25:03Z","closed_at":null,"body":"Hi primoz, been playing around with this a bit today. This aria stuff can be a real headache.\r\n\r\nI'm looking at [this SO post](http://stackoverflow.com/a/12279190/1723499) which includes a helpful breakdown of each element. I've noticed a few things and I thought I'd bring them up to see what you thought. I assume you've dug pretty far into this stuff.\r\n\r\n1. From what I gather, the link of each menu item should have a `role=menuitem`. Does that seem right to you?\r\n\r\n2. I'm wondering if the `aria-haspopup` and `aria-expanded` attributes are supposed to be on the `<a>` element, rather than the `<li>` element. I think the current situation is technically ok, but it results in a situation whereby keyboard navigation focuses on both the `<li>` and the `<a>` for each item, so you have to tab twice past each one. My thinking is that it would work like this instead:\r\n\r\n```\r\n<ul role=\"menu\">\r\n  <li>\r\n    <a id=\"menu-item-123\" role=\"menuitem\" aria-haspopup=\"true\" aria-owns=\"sub-menu-123\">\r\n      Page Link\r\n    </a>\r\n    <ul id=\"sub-menu-123\" role=\"menu\">\r\n      <li>\r\n        <a role=\"menuitem\" aria-describedby=\"menu-item-123\">\r\n          Subpage Link\r\n        </a>\r\n      </li>\r\n    </ul>\r\n  </li>\r\n</ul>\r\n```\r\n\r\n3. If I work on this, are you interested in implementing [keyboard controls](http://www.w3.org/WAI/GL/wiki/Using_ARIA_menus#Success_Criteria_2.1.1_Keyboard)?"}}