{"action":"closed","number":1194,"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1194","id":29426603,"html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1194","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1194.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1194.patch","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1194","number":1194,"state":"closed","locked":false,"title":"Fix EZP-24027: Tree selectionRoot string assignment","user":{"login":"VincentCATILLON","id":8419208,"avatar_url":"https://avatars.githubusercontent.com/u/8419208?v=3","gravatar_id":"","url":"https://api.github.com/users/VincentCATILLON","html_url":"https://github.com/VincentCATILLON","followers_url":"https://api.github.com/users/VincentCATILLON/followers","following_url":"https://api.github.com/users/VincentCATILLON/following{/other_user}","gists_url":"https://api.github.com/users/VincentCATILLON/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentCATILLON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentCATILLON/subscriptions","organizations_url":"https://api.github.com/users/VincentCATILLON/orgs","repos_url":"https://api.github.com/users/VincentCATILLON/repos","events_url":"https://api.github.com/users/VincentCATILLON/events{/privacy}","received_events_url":"https://api.github.com/users/VincentCATILLON/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.ez.no/browse/EZP-24027\r\n\r\nIn the Relation Converter, method toFieldDefinition(), you use a string assignment in case of \"$storageDef->dataInt2\" equals 0.\r\nBut, it's an integer variable, so it makes an error.\r\nI changed it for a ternary condition without string.","created_at":"2015-02-17T09:04:59Z","updated_at":"2015-02-19T14:32:01Z","closed_at":"2015-02-19T14:32:01Z","merged_at":null,"merge_commit_sha":"c8af7ecdd0a8a4f3f844b81f539210456a82314b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1194/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1194/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1194/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/7362d82b23df19d49cff873d34f3695be89f8bce","head":{"label":"VincentCATILLON:VincentCATILLON-patch-1","ref":"VincentCATILLON-patch-1","sha":"7362d82b23df19d49cff873d34f3695be89f8bce","user":{"login":"VincentCATILLON","id":8419208,"avatar_url":"https://avatars.githubusercontent.com/u/8419208?v=3","gravatar_id":"","url":"https://api.github.com/users/VincentCATILLON","html_url":"https://github.com/VincentCATILLON","followers_url":"https://api.github.com/users/VincentCATILLON/followers","following_url":"https://api.github.com/users/VincentCATILLON/following{/other_user}","gists_url":"https://api.github.com/users/VincentCATILLON/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentCATILLON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentCATILLON/subscriptions","organizations_url":"https://api.github.com/users/VincentCATILLON/orgs","repos_url":"https://api.github.com/users/VincentCATILLON/repos","events_url":"https://api.github.com/users/VincentCATILLON/events{/privacy}","received_events_url":"https://api.github.com/users/VincentCATILLON/received_events","type":"User","site_admin":false},"repo":{"id":30873790,"name":"ezpublish-kernel","full_name":"VincentCATILLON/ezpublish-kernel","owner":{"login":"VincentCATILLON","id":8419208,"avatar_url":"https://avatars.githubusercontent.com/u/8419208?v=3","gravatar_id":"","url":"https://api.github.com/users/VincentCATILLON","html_url":"https://github.com/VincentCATILLON","followers_url":"https://api.github.com/users/VincentCATILLON/followers","following_url":"https://api.github.com/users/VincentCATILLON/following{/other_user}","gists_url":"https://api.github.com/users/VincentCATILLON/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentCATILLON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentCATILLON/subscriptions","organizations_url":"https://api.github.com/users/VincentCATILLON/orgs","repos_url":"https://api.github.com/users/VincentCATILLON/repos","events_url":"https://api.github.com/users/VincentCATILLON/events{/privacy}","received_events_url":"https://api.github.com/users/VincentCATILLON/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VincentCATILLON/ezpublish-kernel","description":"eZ Publish 5 kernel","fork":true,"url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel","forks_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/issues/comments/{number}","contents_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/VincentCATILLON/ezpublish-kernel/releases{/id}","created_at":"2015-02-16T15:16:52Z","updated_at":"2015-02-16T15:17:01Z","pushed_at":"2015-02-17T09:01:04Z","git_url":"git://github.com/VincentCATILLON/ezpublish-kernel.git","ssh_url":"git@github.com:VincentCATILLON/ezpublish-kernel.git","clone_url":"https://github.com/VincentCATILLON/ezpublish-kernel.git","svn_url":"https://github.com/VincentCATILLON/ezpublish-kernel","homepage":"http://ez.no","size":56430,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"526bc355149e5b95d4f0eb661a3ab503c0398546","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":1663890,"name":"ezpublish-kernel","full_name":"ezsystems/ezpublish-kernel","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezpublish-kernel","description":"eZ Publish 5 kernel","fork":false,"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","forks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/releases{/id}","created_at":"2011-04-26T08:54:24Z","updated_at":"2015-02-19T11:28:30Z","pushed_at":"2015-02-19T11:27:40Z","git_url":"git://github.com/ezsystems/ezpublish-kernel.git","ssh_url":"git@github.com:ezsystems/ezpublish-kernel.git","clone_url":"https://github.com/ezsystems/ezpublish-kernel.git","svn_url":"https://github.com/ezsystems/ezpublish-kernel","homepage":"http://ez.no","size":56430,"stargazers_count":95,"watchers_count":95,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":36,"forks":110,"open_issues":36,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1194"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1194"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1194"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1194/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1194/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1194/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/7362d82b23df19d49cff873d34f3695be89f8bce"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":2,"deletions":3,"changed_files":1}}