{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/45801313","id":45801313,"diff_hunk":"@@ -141,8 +141,8 @@\n @subduedText: #bbbbbb;\n @subduedTextHover: darken(@subduedText, 15%);\n @subduedTitle: #989998;\n-@closeText: #e5e5e5;\n-@closeTextHover: darken(@closeText, 10%);\n+@closeText: @gray-200;\n+@closeTextHover: @gray-800;","path":"src/styles/vars.less","position":7,"original_position":7,"commit_id":"62446e5289a18e1fc5217d94ea07c9b2dacf8ab2","original_commit_id":"62446e5289a18e1fc5217d94ea07c9b2dacf8ab2","user":{"login":"glynnis","id":1529366,"avatar_url":"https://avatars.githubusercontent.com/u/1529366?v=3","gravatar_id":"","url":"https://api.github.com/users/glynnis","html_url":"https://github.com/glynnis","followers_url":"https://api.github.com/users/glynnis/followers","following_url":"https://api.github.com/users/glynnis/following{/other_user}","gists_url":"https://api.github.com/users/glynnis/gists{/gist_id}","starred_url":"https://api.github.com/users/glynnis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glynnis/subscriptions","organizations_url":"https://api.github.com/users/glynnis/orgs","repos_url":"https://api.github.com/users/glynnis/repos","events_url":"https://api.github.com/users/glynnis/events{/privacy}","received_events_url":"https://api.github.com/users/glynnis/received_events","type":"User","site_admin":false},"body":"I'd replace them. There's also the option of making them component specific by changing the variable name to `@rxModal-close-text`, but I'm guessing the variable isn't referred to so often that keeping something in `vars.less` adds much value.","created_at":"2015-11-24T22:02:05Z","updated_at":"2015-11-24T22:02:05Z","html_url":"https://github.com/rackerlabs/encore-ui/pull/1428#discussion_r45801313","pull_request_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1428","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/45801313"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/1428#discussion_r45801313"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1428"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1428","id":51722940,"html_url":"https://github.com/rackerlabs/encore-ui/pull/1428","diff_url":"https://github.com/rackerlabs/encore-ui/pull/1428.diff","patch_url":"https://github.com/rackerlabs/encore-ui/pull/1428.patch","issue_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1428","number":1428,"state":"open","locked":false,"title":"style(modals): FRMW-332 Updating Modals to Color 2.0","user":{"login":"ssalinas24","id":14296817,"avatar_url":"https://avatars.githubusercontent.com/u/14296817?v=3","gravatar_id":"","url":"https://api.github.com/users/ssalinas24","html_url":"https://github.com/ssalinas24","followers_url":"https://api.github.com/users/ssalinas24/followers","following_url":"https://api.github.com/users/ssalinas24/following{/other_user}","gists_url":"https://api.github.com/users/ssalinas24/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalinas24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalinas24/subscriptions","organizations_url":"https://api.github.com/users/ssalinas24/orgs","repos_url":"https://api.github.com/users/ssalinas24/repos","events_url":"https://api.github.com/users/ssalinas24/events{/privacy}","received_events_url":"https://api.github.com/users/ssalinas24/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.rax.io/browse/FRMW-332\r\n\r\n- [ ] Dev LGTM\r\n- [ ] Dev LGTM\r\n- [ ] Design LGTM\r\n\r\nNOTE: Keep in mind that the current rxNotify PR will take care of the notification colors.\r\n\r\n## BEFORE\r\n![01_before](https://cloud.githubusercontent.com/assets/14296817/11381806/c3b88e80-92c3-11e5-952b-87d6a10d8dca.png)\r\n\r\n## AFTER\r\n![02_after](https://cloud.githubusercontent.com/assets/14296817/11381805/c3b8032a-92c3-11e5-8644-4e696b1cd59f.png)\r\n","created_at":"2015-11-24T21:56:45Z","updated_at":"2015-11-24T22:02:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66600bf49a23ee803f8064a902b346631a9df247","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1428/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1428/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1428/comments","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/62446e5289a18e1fc5217d94ea07c9b2dacf8ab2","head":{"label":"rackerlabs:FRMW-332-Modals","ref":"FRMW-332-Modals","sha":"62446e5289a18e1fc5217d94ea07c9b2dacf8ab2","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","created_at":"2013-07-15T20:06:52Z","updated_at":"2015-09-10T15:50:43Z","pushed_at":"2015-11-24T21:56:46Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":29195,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":5,"forks":46,"open_issues":5,"watchers":37,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"fb48ea6291f7140a0fb4cd181a8d0a38870e3645","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","created_at":"2013-07-15T20:06:52Z","updated_at":"2015-09-10T15:50:43Z","pushed_at":"2015-11-24T21:56:46Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":29195,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":5,"forks":46,"open_issues":5,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1428"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/1428"},"issue":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1428"},"comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1428/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1428/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1428/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/62446e5289a18e1fc5217d94ea07c9b2dacf8ab2"}}}}