{"action":"created","issue":{"url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/79","labels_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/79/comments","events_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/79/events","html_url":"https://github.com/jeff-regier/Celeste.jl/pull/79","id":113140206,"number":79,"title":"Active sources and make trust region the default","user":{"login":"rgiordan","id":4494910,"avatar_url":"https://avatars.githubusercontent.com/u/4494910?v=3","gravatar_id":"","url":"https://api.github.com/users/rgiordan","html_url":"https://github.com/rgiordan","followers_url":"https://api.github.com/users/rgiordan/followers","following_url":"https://api.github.com/users/rgiordan/following{/other_user}","gists_url":"https://api.github.com/users/rgiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/rgiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgiordan/subscriptions","organizations_url":"https://api.github.com/users/rgiordan/orgs","repos_url":"https://api.github.com/users/rgiordan/repos","events_url":"https://api.github.com/users/rgiordan/events{/privacy}","received_events_url":"https://api.github.com/users/rgiordan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-24T06:08:03Z","updated_at":"2015-10-24T18:46:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jeff-regier/Celeste.jl/pulls/79","html_url":"https://github.com/jeff-regier/Celeste.jl/pull/79","diff_url":"https://github.com/jeff-regier/Celeste.jl/pull/79.diff","patch_url":"https://github.com/jeff-regier/Celeste.jl/pull/79.patch"},"body":"I add \"active sources\" to the ModelParams object to control which tiles get computed in the ElboDeriv.  I add an objid field to the ModelParams as well -- we'll need it eventually to match up results across different frames.  This allowed me to replace my last commit's special Hessian function and make the more efficient behavior the default.\r\n\r\nI also made Newton TR the default optimization and moved most of the tests over to using it.  A couple tests still require solving optimization problems on a couple parameters that start at spots of semi-negative curvature, which my TR implementation can't handle.  For now, for the purpose of these two tests (and possible similar debugging tasks), I left BFGS in as an option with ```optimize_f_bfgs```."},"comment":{"url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/comments/150840415","html_url":"https://github.com/jeff-regier/Celeste.jl/pull/79#issuecomment-150840415","issue_url":"https://api.github.com/repos/jeff-regier/Celeste.jl/issues/79","id":150840415,"user":{"login":"jeff-regier","id":8953355,"avatar_url":"https://avatars.githubusercontent.com/u/8953355?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-regier","html_url":"https://github.com/jeff-regier","followers_url":"https://api.github.com/users/jeff-regier/followers","following_url":"https://api.github.com/users/jeff-regier/following{/other_user}","gists_url":"https://api.github.com/users/jeff-regier/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-regier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-regier/subscriptions","organizations_url":"https://api.github.com/users/jeff-regier/orgs","repos_url":"https://api.github.com/users/jeff-regier/repos","events_url":"https://api.github.com/users/jeff-regier/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-regier/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T18:46:25Z","updated_at":"2015-10-24T18:46:25Z","body":"What about tiles that don't receive photons from any source? Do they still get factored into the elbo, even though they never contain any active sources?"}}