{"action":"created","issue":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/777","labels_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/777/labels{/name}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/777/comments","events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/777/events","html_url":"https://github.com/letsencrypt/letsencrypt/pull/777","id":106725309,"number":777,"title":"Make 'auth' and 'run' use the same code (fixes #771)","user":{"login":"jdkasten","id":1581662,"avatar_url":"https://avatars.githubusercontent.com/u/1581662?v=3","gravatar_id":"","url":"https://api.github.com/users/jdkasten","html_url":"https://github.com/jdkasten","followers_url":"https://api.github.com/users/jdkasten/followers","following_url":"https://api.github.com/users/jdkasten/following{/other_user}","gists_url":"https://api.github.com/users/jdkasten/gists{/gist_id}","starred_url":"https://api.github.com/users/jdkasten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdkasten/subscriptions","organizations_url":"https://api.github.com/users/jdkasten/orgs","repos_url":"https://api.github.com/users/jdkasten/repos","events_url":"https://api.github.com/users/jdkasten/events{/privacy}","received_events_url":"https://api.github.com/users/jdkasten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"schoen","id":1750103,"avatar_url":"https://avatars.githubusercontent.com/u/1750103?v=3","gravatar_id":"","url":"https://api.github.com/users/schoen","html_url":"https://github.com/schoen","followers_url":"https://api.github.com/users/schoen/followers","following_url":"https://api.github.com/users/schoen/following{/other_user}","gists_url":"https://api.github.com/users/schoen/gists{/gist_id}","starred_url":"https://api.github.com/users/schoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schoen/subscriptions","organizations_url":"https://api.github.com/users/schoen/orgs","repos_url":"https://api.github.com/users/schoen/repos","events_url":"https://api.github.com/users/schoen/events{/privacy}","received_events_url":"https://api.github.com/users/schoen/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-09-16T08:34:26Z","updated_at":"2015-09-26T21:04:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/777","html_url":"https://github.com/letsencrypt/letsencrypt/pull/777","diff_url":"https://github.com/letsencrypt/letsencrypt/pull/777.diff","patch_url":"https://github.com/letsencrypt/letsencrypt/pull/777.patch"},"body":"This is a refactoring of the renew lineage under the run command.  This extends it to also work with auth.\r\n\r\nI believe I tested all of the common cases through integration testing.\r\n\r\n(These functions could really use unittests, but I didn't investigate the exact proper renewer behavior in order to guarantee correctness.  @schoen might want to do this later as he is most familiar with the renewer code and wrote the functionality originally)\r\n\r\nIf you are interested in testing this out... I might recommend checking out the cert_manager branch (which is already merged with this branch).  It makes viewing/modifying the structure of the certificates much easier.  With cert_manager, it is possible to run ```venv/bin/letsencrypt revoke``` which gives you menu with all of the certificates and their layout."},"comment":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/comments/143495648","html_url":"https://github.com/letsencrypt/letsencrypt/pull/777#issuecomment-143495648","issue_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/777","id":143495648,"user":{"login":"jdkasten","id":1581662,"avatar_url":"https://avatars.githubusercontent.com/u/1581662?v=3","gravatar_id":"","url":"https://api.github.com/users/jdkasten","html_url":"https://github.com/jdkasten","followers_url":"https://api.github.com/users/jdkasten/followers","following_url":"https://api.github.com/users/jdkasten/following{/other_user}","gists_url":"https://api.github.com/users/jdkasten/gists{/gist_id}","starred_url":"https://api.github.com/users/jdkasten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdkasten/subscriptions","organizations_url":"https://api.github.com/users/jdkasten/orgs","repos_url":"https://api.github.com/users/jdkasten/repos","events_url":"https://api.github.com/users/jdkasten/events{/privacy}","received_events_url":"https://api.github.com/users/jdkasten/received_events","type":"User","site_admin":false},"created_at":"2015-09-26T21:04:06Z","updated_at":"2015-09-26T21:04:06Z","body":"@kuba,  I am not terribly pleased with the code.  I feel like the interfaces could be improved and the certificate detection/user prompts should probably be moved elsewhere.  Probably display_ops??\r\n\r\nThat being said, this cleanup effort / correction was kind of thrust upon me and I am really (really) short on time/sleep right now.\r\n\r\nI do believe that this is a strict improvement over the existing code.  It is just a refactor of run to make auth perform similarly.  Code moved to a few functions.\r\n\r\nI would appreciate feedback in order to get this bug fixed quickly.  I do think that some of the functions/APIs could use some more work (again thoughts/ideas are appreciated)"}}