{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/33297453","id":33297453,"diff_hunk":"@@ -132,6 +168,13 @@ LogField::LogField(const char *name, const char *symbol, Type type, MarshalFunc\n \n   m_time_field = (strcmp(m_symbol, \"cqts\") == 0 || strcmp(m_symbol, \"cqth\") == 0 || strcmp(m_symbol, \"cqtq\") == 0 ||\n                   strcmp(m_symbol, \"cqtn\") == 0 || strcmp(m_symbol, \"cqtd\") == 0 || strcmp(m_symbol, \"cqtt\") == 0);\n+\n+  if (m_milestone_map.empty()) {","path":"proxy/logging/LogField.cc","position":57,"original_position":57,"commit_id":"6bc2db02d4d36ebdec62d8a91c1b60ea7df03b5f","original_commit_id":"6bc2db02d4d36ebdec62d8a91c1b60ea7df03b5f","user":{"login":"SolidWallOfCode","id":1545753,"avatar_url":"https://avatars.githubusercontent.com/u/1545753?v=3","gravatar_id":"","url":"https://api.github.com/users/SolidWallOfCode","html_url":"https://github.com/SolidWallOfCode","followers_url":"https://api.github.com/users/SolidWallOfCode/followers","following_url":"https://api.github.com/users/SolidWallOfCode/following{/other_user}","gists_url":"https://api.github.com/users/SolidWallOfCode/gists{/gist_id}","starred_url":"https://api.github.com/users/SolidWallOfCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolidWallOfCode/subscriptions","organizations_url":"https://api.github.com/users/SolidWallOfCode/orgs","repos_url":"https://api.github.com/users/SolidWallOfCode/repos","events_url":"https://api.github.com/users/SolidWallOfCode/events{/privacy}","received_events_url":"https://api.github.com/users/SolidWallOfCode/received_events","type":"User","site_admin":false},"body":"This should really be in a local function or method, since it's used multiple times.","created_at":"2015-06-25T19:54:54Z","updated_at":"2015-06-25T19:54:54Z","html_url":"https://github.com/apache/trafficserver/pull/229#discussion_r33297453","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/229","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/33297453"},"html":{"href":"https://github.com/apache/trafficserver/pull/229#discussion_r33297453"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/229","id":37950601,"html_url":"https://github.com/apache/trafficserver/pull/229","diff_url":"https://github.com/apache/trafficserver/pull/229.diff","patch_url":"https://github.com/apache/trafficserver/pull/229.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/229","number":229,"state":"open","locked":false,"title":"TS-2150: Add Milestone log tags","user":{"login":"fpesce","id":4336228,"avatar_url":"https://avatars.githubusercontent.com/u/4336228?v=3","gravatar_id":"","url":"https://api.github.com/users/fpesce","html_url":"https://github.com/fpesce","followers_url":"https://api.github.com/users/fpesce/followers","following_url":"https://api.github.com/users/fpesce/following{/other_user}","gists_url":"https://api.github.com/users/fpesce/gists{/gist_id}","starred_url":"https://api.github.com/users/fpesce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpesce/subscriptions","organizations_url":"https://api.github.com/users/fpesce/orgs","repos_url":"https://api.github.com/users/fpesce/repos","events_url":"https://api.github.com/users/fpesce/events{/privacy}","received_events_url":"https://api.github.com/users/fpesce/received_events","type":"User","site_admin":false},"body":"- Add Milestone log tags\r\n- Add Milestone diff log tags","created_at":"2015-06-17T21:45:34Z","updated_at":"2015-06-25T19:54:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9a8be11f06857eac8acfc862d6e5e2d7367100f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/229/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/229/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/229/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/6bc2db02d4d36ebdec62d8a91c1b60ea7df03b5f","head":{"label":"fpesce:TS-2150","ref":"TS-2150","sha":"6bc2db02d4d36ebdec62d8a91c1b60ea7df03b5f","user":{"login":"fpesce","id":4336228,"avatar_url":"https://avatars.githubusercontent.com/u/4336228?v=3","gravatar_id":"","url":"https://api.github.com/users/fpesce","html_url":"https://github.com/fpesce","followers_url":"https://api.github.com/users/fpesce/followers","following_url":"https://api.github.com/users/fpesce/following{/other_user}","gists_url":"https://api.github.com/users/fpesce/gists{/gist_id}","starred_url":"https://api.github.com/users/fpesce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpesce/subscriptions","organizations_url":"https://api.github.com/users/fpesce/orgs","repos_url":"https://api.github.com/users/fpesce/repos","events_url":"https://api.github.com/users/fpesce/events{/privacy}","received_events_url":"https://api.github.com/users/fpesce/received_events","type":"User","site_admin":false},"repo":{"id":37220266,"name":"trafficserver","full_name":"fpesce/trafficserver","owner":{"login":"fpesce","id":4336228,"avatar_url":"https://avatars.githubusercontent.com/u/4336228?v=3","gravatar_id":"","url":"https://api.github.com/users/fpesce","html_url":"https://github.com/fpesce","followers_url":"https://api.github.com/users/fpesce/followers","following_url":"https://api.github.com/users/fpesce/following{/other_user}","gists_url":"https://api.github.com/users/fpesce/gists{/gist_id}","starred_url":"https://api.github.com/users/fpesce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpesce/subscriptions","organizations_url":"https://api.github.com/users/fpesce/orgs","repos_url":"https://api.github.com/users/fpesce/repos","events_url":"https://api.github.com/users/fpesce/events{/privacy}","received_events_url":"https://api.github.com/users/fpesce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fpesce/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/fpesce/trafficserver","forks_url":"https://api.github.com/repos/fpesce/trafficserver/forks","keys_url":"https://api.github.com/repos/fpesce/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fpesce/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fpesce/trafficserver/teams","hooks_url":"https://api.github.com/repos/fpesce/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/fpesce/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/fpesce/trafficserver/events","assignees_url":"https://api.github.com/repos/fpesce/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/fpesce/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/fpesce/trafficserver/tags","blobs_url":"https://api.github.com/repos/fpesce/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fpesce/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fpesce/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/fpesce/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fpesce/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/fpesce/trafficserver/languages","stargazers_url":"https://api.github.com/repos/fpesce/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/fpesce/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/fpesce/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/fpesce/trafficserver/subscription","commits_url":"https://api.github.com/repos/fpesce/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/fpesce/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/fpesce/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/fpesce/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/fpesce/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/fpesce/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fpesce/trafficserver/merges","archive_url":"https://api.github.com/repos/fpesce/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fpesce/trafficserver/downloads","issues_url":"https://api.github.com/repos/fpesce/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/fpesce/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/fpesce/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/fpesce/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fpesce/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/fpesce/trafficserver/releases{/id}","created_at":"2015-06-10T20:16:43Z","updated_at":"2015-06-10T20:16:50Z","pushed_at":"2015-06-24T21:15:45Z","git_url":"git://github.com/fpesce/trafficserver.git","ssh_url":"git@github.com:fpesce/trafficserver.git","clone_url":"https://github.com/fpesce/trafficserver.git","svn_url":"https://github.com/fpesce/trafficserver","homepage":null,"size":45066,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"32d7f42fd31b96e48fb6e4475cac46c5451513e6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","created_at":"2009-10-31T08:00:10Z","updated_at":"2015-06-18T08:28:18Z","pushed_at":"2015-06-25T18:29:57Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":69472,"stargazers_count":291,"watchers_count":291,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":200,"mirror_url":"git://git.apache.org/trafficserver.git","open_issues_count":19,"forks":200,"open_issues":19,"watchers":291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/229"},"html":{"href":"https://github.com/apache/trafficserver/pull/229"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/229"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/6bc2db02d4d36ebdec62d8a91c1b60ea7df03b5f"}}}}