{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/3990","labels_url":"https://api.github.com/repos/nodejs/node/issues/3990/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/3990/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/3990/events","html_url":"https://github.com/nodejs/node/pull/3990","id":118475408,"number":3990,"title":"test: fix test-domain-exit-dispose-again","user":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/domain","name":"domain","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/land-on-v5.x","name":"land-on-v5.x","color":"fad8c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v4.x","name":"lts-watch-v4.x","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-11-23T21:23:48Z","updated_at":"2015-11-27T02:09:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/3990","html_url":"https://github.com/nodejs/node/pull/3990","diff_url":"https://github.com/nodejs/node/pull/3990.diff","patch_url":"https://github.com/nodejs/node/pull/3990.patch"},"body":"test-domain-exit-dispose-again had been written for node v0.10.x, and\r\nwas using the fact that callbacks scheduled with `process.nextTick`\r\nwouldn't run if the domain attached to it was disposed.\r\n\r\nThis is not longer the case, and as a result the test would not catch\r\nany regression: it would always pass.\r\n\r\nThis change rewrites that test to check that the current domain is\r\ncleared properly when processing the rest of the timers list if a\r\ntimer's callback throws an error. This makes the test fail without the\r\noriginal fix, and pass with the original fix, as expected."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/160023077","html_url":"https://github.com/nodejs/node/pull/3990#issuecomment-160023077","issue_url":"https://api.github.com/repos/nodejs/node/issues/3990","id":160023077,"user":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"created_at":"2015-11-27T02:09:32Z","updated_at":"2015-11-27T02:09:32Z","body":"All tests pass, [except for tests on pi1-raspbian-wheezy that seem to not even run](https://ci.nodejs.org/job/node-test-binary-arm/148/). I don't think these failures are due to this PR, so I will merge it asap."}}