{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/olympia/issues/429","labels_url":"https://api.github.com/repos/mozilla/olympia/issues/429/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/olympia/issues/429/comments","events_url":"https://api.github.com/repos/mozilla/olympia/issues/429/events","html_url":"https://github.com/mozilla/olympia/pull/429","id":55093960,"number":429,"title":"Bug 1037288 - Map files in Jetpack JPM add-ons to their previous paths w...","user":{"login":"kmaglione","id":125842,"avatar_url":"https://avatars.githubusercontent.com/u/125842?v=3","gravatar_id":"","url":"https://api.github.com/users/kmaglione","html_url":"https://github.com/kmaglione","followers_url":"https://api.github.com/users/kmaglione/followers","following_url":"https://api.github.com/users/kmaglione/following{/other_user}","gists_url":"https://api.github.com/users/kmaglione/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaglione/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaglione/subscriptions","organizations_url":"https://api.github.com/users/kmaglione/orgs","repos_url":"https://api.github.com/users/kmaglione/repos","events_url":"https://api.github.com/users/kmaglione/events{/privacy}","received_events_url":"https://api.github.com/users/kmaglione/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-21T23:37:28Z","updated_at":"2015-01-23T11:00:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/olympia/pulls/429","html_url":"https://github.com/mozilla/olympia/pull/429","diff_url":"https://github.com/mozilla/olympia/pull/429.diff","patch_url":"https://github.com/mozilla/olympia/pull/429.patch"},"body":"...hen converting from CFX."},"comment":{"url":"https://api.github.com/repos/mozilla/olympia/issues/comments/71178076","html_url":"https://github.com/mozilla/olympia/pull/429#issuecomment-71178076","issue_url":"https://api.github.com/repos/mozilla/olympia/issues/429","id":71178076,"user":{"login":"magopian","id":167767,"avatar_url":"https://avatars.githubusercontent.com/u/167767?v=3","gravatar_id":"","url":"https://api.github.com/users/magopian","html_url":"https://github.com/magopian","followers_url":"https://api.github.com/users/magopian/followers","following_url":"https://api.github.com/users/magopian/following{/other_user}","gists_url":"https://api.github.com/users/magopian/gists{/gist_id}","starred_url":"https://api.github.com/users/magopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magopian/subscriptions","organizations_url":"https://api.github.com/users/magopian/orgs","repos_url":"https://api.github.com/users/magopian/repos","events_url":"https://api.github.com/users/magopian/events{/privacy}","received_events_url":"https://api.github.com/users/magopian/received_events","type":"User","site_admin":false},"created_at":"2015-01-23T11:00:23Z","updated_at":"2015-01-23T11:00:23Z","body":"Had a first look at this PR, and I like the 'property-fication' of `files`.\r\n\r\nI don't like the code in `_remap_filenames` though: it's really difficult to grok (and thus review) without having at least one clear example of what it's trying to achieve. As a result, some (most?) of my comments in the review on that method may be way off, or plain wrong.\r\n\r\nCould you please give a detailed example of remapping? That might help me understand this code.\r\n\r\nIn general, code that is easy to review (and thus easy to maintain) is:\r\n1/ clear (either because it's simple, not compound, either because it's well documented via examples and comments)\r\n2/ as concise as possible: not horrible one-liners, but \"occam's razor\" like: the least amount of code needed to achieve its goal.\r\n3/ pythonic: respects the zen of python, is idiomatic\r\n\r\nThere's several other criteria (robust, tested, least surprising...), but I believe those three above to be the most important.\r\n\r\nI understand there's a lot of work put in this PR, but we have to keep in mind that merged code has to be maintained, debugged, investigated, understood... by others.\r\n\r\nPlease let me know if I can help, on my end, to make this PR better."}}