{"action":"created","issue":{"url":"https://api.github.com/repos/chef/chef/issues/3109","labels_url":"https://api.github.com/repos/chef/chef/issues/3109/labels{/name}","comments_url":"https://api.github.com/repos/chef/chef/issues/3109/comments","events_url":"https://api.github.com/repos/chef/chef/issues/3109/events","html_url":"https://github.com/chef/chef/pull/3109","id":62878074,"number":3109,"title":"Fix openbsd package provider","user":{"login":"jdmundrawala","id":27443,"avatar_url":"https://avatars.githubusercontent.com/u/27443?v=3","gravatar_id":"","url":"https://api.github.com/users/jdmundrawala","html_url":"https://github.com/jdmundrawala","followers_url":"https://api.github.com/users/jdmundrawala/followers","following_url":"https://api.github.com/users/jdmundrawala/following{/other_user}","gists_url":"https://api.github.com/users/jdmundrawala/gists{/gist_id}","starred_url":"https://api.github.com/users/jdmundrawala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdmundrawala/subscriptions","organizations_url":"https://api.github.com/users/jdmundrawala/orgs","repos_url":"https://api.github.com/users/jdmundrawala/repos","events_url":"https://api.github.com/users/jdmundrawala/events{/privacy}","received_events_url":"https://api.github.com/users/jdmundrawala/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/chef/chef/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/chef/chef/labels/Signed%20CLA","name":"Signed CLA","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-19T05:14:15Z","updated_at":"2015-03-19T19:17:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/3109","html_url":"https://github.com/chef/chef/pull/3109","diff_url":"https://github.com/chef/chef/pull/3109.diff","patch_url":"https://github.com/chef/chef/pull/3109.patch"},"body":"This provider was broken in just the right ways when  it was merged that it sort of worked. There were references to methods that didn't exist that just happened not to get called ever.\r\n\r\nSince we just released this, and it does not work as is, I'm going to change a few things:\r\n- I've simplified the candidate_version search...I didn't quite understand what the original was wanting to do\r\n\r\n- This package provider had a weird usage for source (completely inconsistent with the rest of our package providers), and it was not happy with @jaymzh's patch https://github.com/jaymzh/chef/commit/1f380f9f180f39581f2e124061af1ee927a23e0c. I've decided to explicitly make `source` unsupported for this provider\r\n\r\n- It now correctly deals with multiple valid candidates by failing the run instead of picking one\r\n\r\nFixes https://github.com/chef/chef/issues/3096\r\n\r\ncc @chef/client-core "},"comment":{"url":"https://api.github.com/repos/chef/chef/issues/comments/83724855","html_url":"https://github.com/chef/chef/pull/3109#issuecomment-83724855","issue_url":"https://api.github.com/repos/chef/chef/issues/3109","id":83724855,"user":{"login":"danielsdeleo","id":37162,"avatar_url":"https://avatars.githubusercontent.com/u/37162?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsdeleo","html_url":"https://github.com/danielsdeleo","followers_url":"https://api.github.com/users/danielsdeleo/followers","following_url":"https://api.github.com/users/danielsdeleo/following{/other_user}","gists_url":"https://api.github.com/users/danielsdeleo/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsdeleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsdeleo/subscriptions","organizations_url":"https://api.github.com/users/danielsdeleo/orgs","repos_url":"https://api.github.com/users/danielsdeleo/repos","events_url":"https://api.github.com/users/danielsdeleo/events{/privacy}","received_events_url":"https://api.github.com/users/danielsdeleo/received_events","type":"User","site_admin":false},"created_at":"2015-03-19T19:17:19Z","updated_at":"2015-03-19T19:17:19Z","body":"Summary of internal chat discussion: I'm borderline :-1: without some regression tests. There are valid reasons why we can't make the tests as good as we really want to, but a handful of unit tests would go a long way to preventing future regression and documenting the edge cases we've learned we will encounter in the real world."}}