{"action":"created","comment":{"url":"https://api.github.com/repos/sitn/crdppf_core/pulls/comments/24753029","id":24753029,"diff_hunk":"@@ -70,17 +70,84 @@ var setInfoControl = function setInfoControl(){\n         box: false,\n         hover: false,\n         single: false,\n-        maxFeatures: 1,\n+        maxFeatures: 4,\n         clickTolerance: 15\n     });\n-    \n-    // define actions on feature selection\n-    control.events.register(\"featureselected\", this, function(e) {\n+        \n+    Crdppf.PropertySelection = function(features, labels) {\n+        \n+        if (store) {\n+            store.removeAll();\n+        }\n+        \n+        if (features.length > 1) {\n+            var properties = []\n+            for (var i = 0; i < features.length; i++){\n+                properties[i] = [i,\n+                features[i].data.typimm+': '+features[i].data.nummai+' '+features[i].data.cadastre,\n+                features[i].data.idemai,\n+                features[i].data.source\n+                ]\n+            }\n+\n+            var store = new Ext.data.ArrayStore({\n+                fields: ['index','displaytxt','idemai','idemai'],\n+                data : properties \n+            });\n+            \n+            var combo = new Ext.form.ComboBox({\n+                store: store,\n+                displayField: 'displaytxt',\n+                valueField: 'index',\n+                typeAhead: true,\n+                mode: 'local',\n+                triggerAction: 'all',\n+                emptyText: labels.choosePropertyMsg,\n+                selectOnFocus:true,\n+                listeners: {\n+                    select: function(combo, record, index) {\n+                        // the index of the selected feature is returned and used to highlight the geom\n+                        property = features[index];\n+                        Crdppf.featureSelection(property);\n+                        Ext.getCmp('propertySelectionWindow').hide();\n+                    }\n+                }\n+            });\n+\n+            if (Ext.getCmp('propertySelectionWindow')) {","path":"crdppf/static/js/Crdppf/map.js","position":61,"original_position":61,"commit_id":"c6769328765b2d657e88d806b72f15b0d308367b","original_commit_id":"c6769328765b2d657e88d806b72f15b0d308367b","user":{"login":"voisardf","id":4629369,"avatar_url":"https://avatars.githubusercontent.com/u/4629369?v=3","gravatar_id":"","url":"https://api.github.com/users/voisardf","html_url":"https://github.com/voisardf","followers_url":"https://api.github.com/users/voisardf/followers","following_url":"https://api.github.com/users/voisardf/following{/other_user}","gists_url":"https://api.github.com/users/voisardf/gists{/gist_id}","starred_url":"https://api.github.com/users/voisardf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voisardf/subscriptions","organizations_url":"https://api.github.com/users/voisardf/orgs","repos_url":"https://api.github.com/users/voisardf/repos","events_url":"https://api.github.com/users/voisardf/events{/privacy}","received_events_url":"https://api.github.com/users/voisardf/received_events","type":"User","site_admin":false},"body":"cheers.","created_at":"2015-02-16T14:23:58Z","updated_at":"2015-02-16T14:23:58Z","html_url":"https://github.com/sitn/crdppf_core/pull/34#discussion_r24753029","pull_request_url":"https://api.github.com/repos/sitn/crdppf_core/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/sitn/crdppf_core/pulls/comments/24753029"},"html":{"href":"https://github.com/sitn/crdppf_core/pull/34#discussion_r24753029"},"pull_request":{"href":"https://api.github.com/repos/sitn/crdppf_core/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/sitn/crdppf_core/pulls/34","id":29258052,"html_url":"https://github.com/sitn/crdppf_core/pull/34","diff_url":"https://github.com/sitn/crdppf_core/pull/34.diff","patch_url":"https://github.com/sitn/crdppf_core/pull/34.patch","issue_url":"https://api.github.com/repos/sitn/crdppf_core/issues/34","number":34,"state":"open","locked":false,"title":"Legalfiltering","user":{"login":"voisardf","id":4629369,"avatar_url":"https://avatars.githubusercontent.com/u/4629369?v=3","gravatar_id":"","url":"https://api.github.com/users/voisardf","html_url":"https://github.com/voisardf","followers_url":"https://api.github.com/users/voisardf/followers","following_url":"https://api.github.com/users/voisardf/following{/other_user}","gists_url":"https://api.github.com/users/voisardf/gists{/gist_id}","starred_url":"https://api.github.com/users/voisardf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voisardf/subscriptions","organizations_url":"https://api.github.com/users/voisardf/orgs","repos_url":"https://api.github.com/users/voisardf/repos","events_url":"https://api.github.com/users/voisardf/events{/privacy}","received_events_url":"https://api.github.com/users/voisardf/received_events","type":"User","site_admin":false},"body":"@kalbermattenm: Banzai! let's give it a go ;) thanks for your review","created_at":"2015-02-13T11:36:19Z","updated_at":"2015-02-16T14:23:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d395d9111385ed7f8211cc254819b59dbb60f48a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sitn/crdppf_core/pulls/34/commits","review_comments_url":"https://api.github.com/repos/sitn/crdppf_core/pulls/34/comments","review_comment_url":"https://api.github.com/repos/sitn/crdppf_core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sitn/crdppf_core/issues/34/comments","statuses_url":"https://api.github.com/repos/sitn/crdppf_core/statuses/c6769328765b2d657e88d806b72f15b0d308367b","head":{"label":"voisardf:legalfiltering","ref":"legalfiltering","sha":"c6769328765b2d657e88d806b72f15b0d308367b","user":{"login":"voisardf","id":4629369,"avatar_url":"https://avatars.githubusercontent.com/u/4629369?v=3","gravatar_id":"","url":"https://api.github.com/users/voisardf","html_url":"https://github.com/voisardf","followers_url":"https://api.github.com/users/voisardf/followers","following_url":"https://api.github.com/users/voisardf/following{/other_user}","gists_url":"https://api.github.com/users/voisardf/gists{/gist_id}","starred_url":"https://api.github.com/users/voisardf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voisardf/subscriptions","organizations_url":"https://api.github.com/users/voisardf/orgs","repos_url":"https://api.github.com/users/voisardf/repos","events_url":"https://api.github.com/users/voisardf/events{/privacy}","received_events_url":"https://api.github.com/users/voisardf/received_events","type":"User","site_admin":false},"repo":{"id":21819875,"name":"crdppf_core","full_name":"voisardf/crdppf_core","owner":{"login":"voisardf","id":4629369,"avatar_url":"https://avatars.githubusercontent.com/u/4629369?v=3","gravatar_id":"","url":"https://api.github.com/users/voisardf","html_url":"https://github.com/voisardf","followers_url":"https://api.github.com/users/voisardf/followers","following_url":"https://api.github.com/users/voisardf/following{/other_user}","gists_url":"https://api.github.com/users/voisardf/gists{/gist_id}","starred_url":"https://api.github.com/users/voisardf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voisardf/subscriptions","organizations_url":"https://api.github.com/users/voisardf/orgs","repos_url":"https://api.github.com/users/voisardf/repos","events_url":"https://api.github.com/users/voisardf/events{/privacy}","received_events_url":"https://api.github.com/users/voisardf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/voisardf/crdppf_core","description":"Core / generic parts of the CRDPPF project","fork":true,"url":"https://api.github.com/repos/voisardf/crdppf_core","forks_url":"https://api.github.com/repos/voisardf/crdppf_core/forks","keys_url":"https://api.github.com/repos/voisardf/crdppf_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voisardf/crdppf_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voisardf/crdppf_core/teams","hooks_url":"https://api.github.com/repos/voisardf/crdppf_core/hooks","issue_events_url":"https://api.github.com/repos/voisardf/crdppf_core/issues/events{/number}","events_url":"https://api.github.com/repos/voisardf/crdppf_core/events","assignees_url":"https://api.github.com/repos/voisardf/crdppf_core/assignees{/user}","branches_url":"https://api.github.com/repos/voisardf/crdppf_core/branches{/branch}","tags_url":"https://api.github.com/repos/voisardf/crdppf_core/tags","blobs_url":"https://api.github.com/repos/voisardf/crdppf_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voisardf/crdppf_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voisardf/crdppf_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/voisardf/crdppf_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voisardf/crdppf_core/statuses/{sha}","languages_url":"https://api.github.com/repos/voisardf/crdppf_core/languages","stargazers_url":"https://api.github.com/repos/voisardf/crdppf_core/stargazers","contributors_url":"https://api.github.com/repos/voisardf/crdppf_core/contributors","subscribers_url":"https://api.github.com/repos/voisardf/crdppf_core/subscribers","subscription_url":"https://api.github.com/repos/voisardf/crdppf_core/subscription","commits_url":"https://api.github.com/repos/voisardf/crdppf_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/voisardf/crdppf_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/voisardf/crdppf_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/voisardf/crdppf_core/issues/comments/{number}","contents_url":"https://api.github.com/repos/voisardf/crdppf_core/contents/{+path}","compare_url":"https://api.github.com/repos/voisardf/crdppf_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voisardf/crdppf_core/merges","archive_url":"https://api.github.com/repos/voisardf/crdppf_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voisardf/crdppf_core/downloads","issues_url":"https://api.github.com/repos/voisardf/crdppf_core/issues{/number}","pulls_url":"https://api.github.com/repos/voisardf/crdppf_core/pulls{/number}","milestones_url":"https://api.github.com/repos/voisardf/crdppf_core/milestones{/number}","notifications_url":"https://api.github.com/repos/voisardf/crdppf_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voisardf/crdppf_core/labels{/name}","releases_url":"https://api.github.com/repos/voisardf/crdppf_core/releases{/id}","created_at":"2014-07-14T13:10:26Z","updated_at":"2014-07-14T13:23:12Z","pushed_at":"2015-02-13T11:28:09Z","git_url":"git://github.com/voisardf/crdppf_core.git","ssh_url":"git@github.com:voisardf/crdppf_core.git","clone_url":"https://github.com/voisardf/crdppf_core.git","svn_url":"https://github.com/voisardf/crdppf_core","homepage":null,"size":20262,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sitn:master","ref":"master","sha":"cdb0749f9a6421e86041637c4bf659b187fd5129","user":{"login":"sitn","id":4532493,"avatar_url":"https://avatars.githubusercontent.com/u/4532493?v=3","gravatar_id":"","url":"https://api.github.com/users/sitn","html_url":"https://github.com/sitn","followers_url":"https://api.github.com/users/sitn/followers","following_url":"https://api.github.com/users/sitn/following{/other_user}","gists_url":"https://api.github.com/users/sitn/gists{/gist_id}","starred_url":"https://api.github.com/users/sitn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitn/subscriptions","organizations_url":"https://api.github.com/users/sitn/orgs","repos_url":"https://api.github.com/users/sitn/repos","events_url":"https://api.github.com/users/sitn/events{/privacy}","received_events_url":"https://api.github.com/users/sitn/received_events","type":"Organization","site_admin":false},"repo":{"id":21165948,"name":"crdppf_core","full_name":"sitn/crdppf_core","owner":{"login":"sitn","id":4532493,"avatar_url":"https://avatars.githubusercontent.com/u/4532493?v=3","gravatar_id":"","url":"https://api.github.com/users/sitn","html_url":"https://github.com/sitn","followers_url":"https://api.github.com/users/sitn/followers","following_url":"https://api.github.com/users/sitn/following{/other_user}","gists_url":"https://api.github.com/users/sitn/gists{/gist_id}","starred_url":"https://api.github.com/users/sitn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitn/subscriptions","organizations_url":"https://api.github.com/users/sitn/orgs","repos_url":"https://api.github.com/users/sitn/repos","events_url":"https://api.github.com/users/sitn/events{/privacy}","received_events_url":"https://api.github.com/users/sitn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sitn/crdppf_core","description":"Core / generic parts of the CRDPPF project","fork":false,"url":"https://api.github.com/repos/sitn/crdppf_core","forks_url":"https://api.github.com/repos/sitn/crdppf_core/forks","keys_url":"https://api.github.com/repos/sitn/crdppf_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sitn/crdppf_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sitn/crdppf_core/teams","hooks_url":"https://api.github.com/repos/sitn/crdppf_core/hooks","issue_events_url":"https://api.github.com/repos/sitn/crdppf_core/issues/events{/number}","events_url":"https://api.github.com/repos/sitn/crdppf_core/events","assignees_url":"https://api.github.com/repos/sitn/crdppf_core/assignees{/user}","branches_url":"https://api.github.com/repos/sitn/crdppf_core/branches{/branch}","tags_url":"https://api.github.com/repos/sitn/crdppf_core/tags","blobs_url":"https://api.github.com/repos/sitn/crdppf_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sitn/crdppf_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sitn/crdppf_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/sitn/crdppf_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sitn/crdppf_core/statuses/{sha}","languages_url":"https://api.github.com/repos/sitn/crdppf_core/languages","stargazers_url":"https://api.github.com/repos/sitn/crdppf_core/stargazers","contributors_url":"https://api.github.com/repos/sitn/crdppf_core/contributors","subscribers_url":"https://api.github.com/repos/sitn/crdppf_core/subscribers","subscription_url":"https://api.github.com/repos/sitn/crdppf_core/subscription","commits_url":"https://api.github.com/repos/sitn/crdppf_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/sitn/crdppf_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/sitn/crdppf_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/sitn/crdppf_core/issues/comments/{number}","contents_url":"https://api.github.com/repos/sitn/crdppf_core/contents/{+path}","compare_url":"https://api.github.com/repos/sitn/crdppf_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sitn/crdppf_core/merges","archive_url":"https://api.github.com/repos/sitn/crdppf_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sitn/crdppf_core/downloads","issues_url":"https://api.github.com/repos/sitn/crdppf_core/issues{/number}","pulls_url":"https://api.github.com/repos/sitn/crdppf_core/pulls{/number}","milestones_url":"https://api.github.com/repos/sitn/crdppf_core/milestones{/number}","notifications_url":"https://api.github.com/repos/sitn/crdppf_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sitn/crdppf_core/labels{/name}","releases_url":"https://api.github.com/repos/sitn/crdppf_core/releases{/id}","created_at":"2014-06-24T13:41:58Z","updated_at":"2015-02-05T08:40:15Z","pushed_at":"2015-02-05T08:40:10Z","git_url":"git://github.com/sitn/crdppf_core.git","ssh_url":"git@github.com:sitn/crdppf_core.git","clone_url":"https://github.com/sitn/crdppf_core.git","svn_url":"https://github.com/sitn/crdppf_core","homepage":null,"size":83896,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sitn/crdppf_core/pulls/34"},"html":{"href":"https://github.com/sitn/crdppf_core/pull/34"},"issue":{"href":"https://api.github.com/repos/sitn/crdppf_core/issues/34"},"comments":{"href":"https://api.github.com/repos/sitn/crdppf_core/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/sitn/crdppf_core/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/sitn/crdppf_core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sitn/crdppf_core/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/sitn/crdppf_core/statuses/c6769328765b2d657e88d806b72f15b0d308367b"}}}}