{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/40502005","id":40502005,"diff_hunk":"@@ -311,7 +311,7 @@ private void AddGroupCommunicationOperators()\n             try\n             {\n                 TangFactory.GetTang()\n-                    .NewInjector(mapInputPipelineDataConverterConfig)\n+                    .NewInjector(mapOutputPipelineDataConverterConfig)\n                     .GetInstance<IPipelineDataConverter<TMapOutput>>();","path":"lang/cs/Org.Apache.REEF.IMRU/OnREEF/Driver/IMRUDriver.cs","position":6,"original_position":6,"commit_id":"18bbe183ba460a56d9ba0aa23726cd76c0476215","original_commit_id":"18bbe183ba460a56d9ba0aa23726cd76c0476215","user":{"login":"jwang98052","id":5666504,"avatar_url":"https://avatars.githubusercontent.com/u/5666504?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang98052","html_url":"https://github.com/jwang98052","followers_url":"https://api.github.com/users/jwang98052/followers","following_url":"https://api.github.com/users/jwang98052/following{/other_user}","gists_url":"https://api.github.com/users/jwang98052/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang98052/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang98052/subscriptions","organizations_url":"https://api.github.com/users/jwang98052/orgs","repos_url":"https://api.github.com/users/jwang98052/repos","events_url":"https://api.github.com/users/jwang98052/events{/privacy}","received_events_url":"https://api.github.com/users/jwang98052/received_events","type":"User","site_admin":false},"body":"Would it matter if a wrong configuration is given? When you put wrong one, it didn't impact any test case. Is it because test case doesn't cover this scenario or because a wrong configuration also works? ","created_at":"2015-09-27T06:22:41Z","updated_at":"2015-09-27T06:22:41Z","html_url":"https://github.com/apache/incubator-reef/pull/526#discussion_r40502005","pull_request_url":"https://api.github.com/repos/apache/incubator-reef/pulls/526","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/40502005"},"html":{"href":"https://github.com/apache/incubator-reef/pull/526#discussion_r40502005"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/526"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/526","id":46075477,"html_url":"https://github.com/apache/incubator-reef/pull/526","diff_url":"https://github.com/apache/incubator-reef/pull/526.diff","patch_url":"https://github.com/apache/incubator-reef/pull/526.patch","issue_url":"https://api.github.com/repos/apache/incubator-reef/issues/526","number":526,"state":"open","locked":false,"title":"[REEF-787] IMRUDriver is not setting TMapOutput Pipeline converter in…","user":{"login":"dkm2110","id":151031,"avatar_url":"https://avatars.githubusercontent.com/u/151031?v=3","gravatar_id":"","url":"https://api.github.com/users/dkm2110","html_url":"https://github.com/dkm2110","followers_url":"https://api.github.com/users/dkm2110/followers","following_url":"https://api.github.com/users/dkm2110/following{/other_user}","gists_url":"https://api.github.com/users/dkm2110/gists{/gist_id}","starred_url":"https://api.github.com/users/dkm2110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkm2110/subscriptions","organizations_url":"https://api.github.com/users/dkm2110/orgs","repos_url":"https://api.github.com/users/dkm2110/repos","events_url":"https://api.github.com/users/dkm2110/events{/privacy}","received_events_url":"https://api.github.com/users/dkm2110/received_events","type":"User","site_admin":false},"body":"… right fashion\r\n\r\nThis addressed the issue by\r\n* Correcting the typo. MapOutputPipelineDataConverter is now injected instead of MapInputPipelineDataConverter in try except statement in driver.\r\n\r\nJIRA:\r\n[REEF-787](https://issues.apache.org/jira/browse/REEF-787)","created_at":"2015-09-26T04:53:41Z","updated_at":"2015-09-27T06:22:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f2fb284d854220f49845df3adfee3fdc7aae960","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-reef/pulls/526/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-reef/pulls/526/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-reef/issues/526/comments","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/18bbe183ba460a56d9ba0aa23726cd76c0476215","head":{"label":"Microsoft-CISL:REEF-787","ref":"REEF-787","sha":"18bbe183ba460a56d9ba0aa23726cd76c0476215","user":{"login":"Microsoft-CISL","id":2067733,"avatar_url":"https://avatars.githubusercontent.com/u/2067733?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft-CISL","html_url":"https://github.com/Microsoft-CISL","followers_url":"https://api.github.com/users/Microsoft-CISL/followers","following_url":"https://api.github.com/users/Microsoft-CISL/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft-CISL/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft-CISL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft-CISL/subscriptions","organizations_url":"https://api.github.com/users/Microsoft-CISL/orgs","repos_url":"https://api.github.com/users/Microsoft-CISL/repos","events_url":"https://api.github.com/users/Microsoft-CISL/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft-CISL/received_events","type":"Organization","site_admin":false},"repo":{"id":30330372,"name":"incubator-reef","full_name":"Microsoft-CISL/incubator-reef","owner":{"login":"Microsoft-CISL","id":2067733,"avatar_url":"https://avatars.githubusercontent.com/u/2067733?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft-CISL","html_url":"https://github.com/Microsoft-CISL","followers_url":"https://api.github.com/users/Microsoft-CISL/followers","following_url":"https://api.github.com/users/Microsoft-CISL/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft-CISL/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft-CISL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft-CISL/subscriptions","organizations_url":"https://api.github.com/users/Microsoft-CISL/orgs","repos_url":"https://api.github.com/users/Microsoft-CISL/repos","events_url":"https://api.github.com/users/Microsoft-CISL/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft-CISL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft-CISL/incubator-reef","description":"Mirror of Apache REEF (Incubating) for Pull Request staging","fork":true,"url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef","forks_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/forks","keys_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/teams","hooks_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/events","assignees_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/tags","blobs_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/subscription","commits_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/merges","archive_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/downloads","issues_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft-CISL/incubator-reef/releases{/id}","created_at":"2015-02-05T01:06:12Z","updated_at":"2015-05-22T13:19:37Z","pushed_at":"2015-09-26T04:52:24Z","git_url":"git://github.com/Microsoft-CISL/incubator-reef.git","ssh_url":"git@github.com:Microsoft-CISL/incubator-reef.git","clone_url":"https://github.com/Microsoft-CISL/incubator-reef.git","svn_url":"https://github.com/Microsoft-CISL/incubator-reef","homepage":"","size":32671,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7f2d6ff74f86e1b73d4cd93152bbe62277261dda","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"incubator-reef","full_name":"apache/incubator-reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-reef","forks_url":"https://api.github.com/repos/apache/incubator-reef/forks","keys_url":"https://api.github.com/repos/apache/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-reef/teams","hooks_url":"https://api.github.com/repos/apache/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-reef/events","assignees_url":"https://api.github.com/repos/apache/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-reef/tags","blobs_url":"https://api.github.com/repos/apache/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-reef/subscription","commits_url":"https://api.github.com/repos/apache/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-reef/merges","archive_url":"https://api.github.com/repos/apache/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-reef/downloads","issues_url":"https://api.github.com/repos/apache/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-reef/releases{/id}","created_at":"2014-10-23T07:00:10Z","updated_at":"2015-09-14T06:39:15Z","pushed_at":"2015-09-26T04:53:41Z","git_url":"git://github.com/apache/incubator-reef.git","ssh_url":"git@github.com:apache/incubator-reef.git","clone_url":"https://github.com/apache/incubator-reef.git","svn_url":"https://github.com/apache/incubator-reef","homepage":null,"size":45125,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":"git://git.apache.org/incubator-reef.git","open_issues_count":8,"forks":36,"open_issues":8,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/526"},"html":{"href":"https://github.com/apache/incubator-reef/pull/526"},"issue":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/526"},"comments":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/526/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/526/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/526/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-reef/statuses/18bbe183ba460a56d9ba0aa23726cd76c0476215"}}}}