{"action":"created","issue":{"url":"https://api.github.com/repos/garethr/garethr-docker/issues/342","labels_url":"https://api.github.com/repos/garethr/garethr-docker/issues/342/labels{/name}","comments_url":"https://api.github.com/repos/garethr/garethr-docker/issues/342/comments","events_url":"https://api.github.com/repos/garethr/garethr-docker/issues/342/events","html_url":"https://github.com/garethr/garethr-docker/pull/342","id":104951608,"number":342,"title":"Docker storage settings update","user":{"login":"coreone","id":739341,"avatar_url":"https://avatars.githubusercontent.com/u/739341?v=3","gravatar_id":"","url":"https://api.github.com/users/coreone","html_url":"https://github.com/coreone","followers_url":"https://api.github.com/users/coreone/followers","following_url":"https://api.github.com/users/coreone/following{/other_user}","gists_url":"https://api.github.com/users/coreone/gists{/gist_id}","starred_url":"https://api.github.com/users/coreone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreone/subscriptions","organizations_url":"https://api.github.com/users/coreone/orgs","repos_url":"https://api.github.com/users/coreone/repos","events_url":"https://api.github.com/users/coreone/events{/privacy}","received_events_url":"https://api.github.com/users/coreone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-04T19:09:56Z","updated_at":"2015-10-09T19:40:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/garethr/garethr-docker/pulls/342","html_url":"https://github.com/garethr/garethr-docker/pull/342","diff_url":"https://github.com/garethr/garethr-docker/pull/342.diff","patch_url":"https://github.com/garethr/garethr-docker/pull/342.patch"},"body":"There are several storage options that have been added to Docker that are not included in this module:\r\n\r\n* dm.thinpooldev\r\n* dm.use_deferred_removal\r\n* dm.blkdiscard\r\n* dm.override_udev_sync_check\r\n\r\nAdditionally, CentOS/RHEL 7 have added this `docker-storage-setup` service if you use non-loopback devices for docker storage, so I also added the `/etc/sysconfig/docker-storage-setup` config template and its associated parameters."},"comment":{"url":"https://api.github.com/repos/garethr/garethr-docker/issues/comments/146969911","html_url":"https://github.com/garethr/garethr-docker/pull/342#issuecomment-146969911","issue_url":"https://api.github.com/repos/garethr/garethr-docker/issues/342","id":146969911,"user":{"login":"coreone","id":739341,"avatar_url":"https://avatars.githubusercontent.com/u/739341?v=3","gravatar_id":"","url":"https://api.github.com/users/coreone","html_url":"https://github.com/coreone","followers_url":"https://api.github.com/users/coreone/followers","following_url":"https://api.github.com/users/coreone/following{/other_user}","gists_url":"https://api.github.com/users/coreone/gists{/gist_id}","starred_url":"https://api.github.com/users/coreone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreone/subscriptions","organizations_url":"https://api.github.com/users/coreone/orgs","repos_url":"https://api.github.com/users/coreone/repos","events_url":"https://api.github.com/users/coreone/events{/privacy}","received_events_url":"https://api.github.com/users/coreone/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T19:40:55Z","updated_at":"2015-10-09T19:40:55Z","body":"I believe this now conflicts with #346 since I had to fix a similar bug where all the config files were not being enforced before a run was scheduled, so docker would be half-configured, started, configured some more, then restart, which would break all the storage.  When #346 or a similar bug fix is added, I will revert that one change to run.pp to make this PR happy again."}}