{"action":"created","comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/37005772","id":37005772,"diff_hunk":"@@ -0,0 +1,59 @@\n+'use strict';\n+\n+var settings = require( './settings.js' );\n+\n+var defaultSuites = {\n+  // Set default browser suites to test.\n+  // These values are passed to the `multiCapabilities` property\n+  // of the protractor config object.\n+  // See https://docs.saucelabs.com/reference/platforms-configurator/\n+  // for configuration values for version and platform.\n+\n+  // Essential browsers for running locally.\n+  essential: [\n+    {\n+      specs:       [ settings.specsBasePath + '*.js' ],\n+      browserName: 'chrome',\n+      version:     '',\n+      platform:    'WINDOWS',\n+      maxDuration: 10800\n+    }\n+  ],\n+\n+  // Legacy browsers to run in the cloud.\n+  legacy: [\n+    {\n+      specs:       [ settings.specsBasePath + '*.js' ],\n+      browserName: 'internet explorer',\n+      version:     '8.0',\n+      platform:    'XP',\n+      maxDuration: 10800\n+    }\n+  ],\n+\n+  // Modern browsers to run in the cloud.\n+  modern: [\n+    {\n+      specs:       [ settings.specsBasePath + '*.js' ],\n+      browserName: 'firefox',\n+      version:     '',\n+      platform:    'WINDOWS 10',\n+      maxDuration: 10800\n+    },\n+    {\n+      specs:       [ settings.specsBasePath + '*.js' ],\n+      browserName: 'internet explorer',\n+      version:     '',\n+      platform:    'WINDOWS 10',\n+      maxDuration: 10800\n+    }\n+  ]\n+};\n+\n+// Run all browsers together.\n+defaultSuites.full = defaultSuites.essential.concat(","path":"test/browser_tests/default-suites.js","position":54,"original_position":54,"commit_id":"7825f9ad0a48eba12762cf4343013926c0c6f9b2","original_commit_id":"7b4c4017823b2e14849bff3c72e732ab00cab555","user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"body":"Mentioned in chat, but for completeness https://github.com/cfpb/cfgov-refresh/pull/859/files#diff-bde509149b84f69921b6afc2471eceafR89 ... also adjusted in https://github.com/cfpb/cfgov-refresh/commit/7825f9ad0a48eba12762cf4343013926c0c6f9b2","created_at":"2015-08-13T18:08:05Z","updated_at":"2015-08-13T18:08:05Z","html_url":"https://github.com/cfpb/cfgov-refresh/pull/859#discussion_r37005772","pull_request_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/859","_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments/37005772"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/859#discussion_r37005772"},"pull_request":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/859"}}},"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/859","id":41900690,"html_url":"https://github.com/cfpb/cfgov-refresh/pull/859","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/859.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/859.patch","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/859","number":859,"state":"open","locked":false,"title":"DF-2320 - Sauce Labs for legacy browsers, updated test flow","user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"body":"Creates browser test suites for essentials, legacy, and modern browsers and sets it up so only essentials runs locally and full suite runs on Sauce.\r\n\r\n## Additions\r\n\r\n- Added `gulp test:unit` and `gulp test:acceptance` tasks for test stages.\r\n\r\n## Changes\r\n\r\n- Added copying of `.env_SAMPLE` to `.env` part of `setup.sh`.\r\n- Moved console output messages to the end of the `setup.sh` `init` method.\r\n- Organized `.env_SAMPLE` and made `.env` executable on its own.\r\n- Added `HTTP_HOST`, `HTTP_PORT`, `SELENIUM_URL`, `SAUCE_USERNAME`,\r\n  `SAUCE_ACCESS_KEY`, `SAUCE_SELENIUM_URL`, `USE_SAUCE`, and `VIRTUAL_ENV`\r\n  constants to `.env_SAMPLE`.\r\n- Moved aggregate `gulp lint` task to bottom of file to avoid duplicate\r\n  lint task entries in `gulp --tasks`.\r\n- Renamed `gulp lint:src` to `gulp lint:js` to future-proof type of linting.\r\n- Renamed `gulp test:macro` to `gulp test:unit:macro`.\r\n- Renamed `gulp test:processor` to `gulp test:unit:processor`.\r\n- Renamed `gulp test:browser` to `gulp test:acceptance:browser`.\r\n- Edited `INSTALL.md` to accommodate changes in `.env_SAMPLE`.\r\n- Edited Protractor configuration to include browser groups,\r\n  which by default only run the essentials locally, but the full suite\r\n  (including legacy browsers) on Sauce Labs when Sauce credentials are present.\r\n- Updates test instructions to use the gulp test subtasks.\r\n- Updated Travis CI settings to use `setup.sh`.\r\n\r\n## Testing\r\n\r\n- Follow instructions in `TEST.md`.\r\n\r\n## Review\r\n\r\n- @KimberlyMunoz \r\n- @sebworks \r\n- @dpford \r\n\r\n## Screenshots\r\n\r\n![screen shot 2015-08-07 at 10 59 23 am](https://cloud.githubusercontent.com/assets/704760/9138701/67b56084-3cf3-11e5-844b-26a47bcbe878.png)\r\n\r\n\r\n## Todos\r\n\r\n- Pass-through Protractor command-line flags to `gulp test:acceptance:browser`, in particular the `specs=` flag.\r\n- Sauce Labs tests will sometimes time out. I've set the timeout to the max amount, so not sure what to do about that. But the tests can always be run locally. (EDIT: protractor timeout guidance https://angular.github.io/protractor/#/timeouts)","created_at":"2015-08-07T15:00:53Z","updated_at":"2015-08-13T18:08:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5f6b8e44d9ec598b81221f656c5a75381e67730","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/859/commits","review_comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/859/comments","review_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/859/comments","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/7825f9ad0a48eba12762cf4343013926c0c6f9b2","head":{"label":"cfpb:protractor-on-sauce","ref":"protractor-on-sauce","sha":"7825f9ad0a48eba12762cf4343013926c0c6f9b2","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"In-progress redesign of the consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","created_at":"2014-04-16T19:22:03Z","updated_at":"2015-07-16T17:30:22Z","pushed_at":"2015-08-13T18:07:31Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"","size":95413,"stargazers_count":9,"watchers_count":9,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":94,"forks":17,"open_issues":94,"watchers":9,"default_branch":"flapjack"}},"base":{"label":"cfpb:flapjack","ref":"flapjack","sha":"f8710f995bc8bed1e941fde47025c675bb9135cb","user":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"repo":{"id":18852566,"name":"cfgov-refresh","full_name":"cfpb/cfgov-refresh","owner":{"login":"cfpb","id":1071563,"avatar_url":"https://avatars.githubusercontent.com/u/1071563?v=3","gravatar_id":"","url":"https://api.github.com/users/cfpb","html_url":"https://github.com/cfpb","followers_url":"https://api.github.com/users/cfpb/followers","following_url":"https://api.github.com/users/cfpb/following{/other_user}","gists_url":"https://api.github.com/users/cfpb/gists{/gist_id}","starred_url":"https://api.github.com/users/cfpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfpb/subscriptions","organizations_url":"https://api.github.com/users/cfpb/orgs","repos_url":"https://api.github.com/users/cfpb/repos","events_url":"https://api.github.com/users/cfpb/events{/privacy}","received_events_url":"https://api.github.com/users/cfpb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfpb/cfgov-refresh","description":"In-progress redesign of the consumerfinance.gov website.","fork":false,"url":"https://api.github.com/repos/cfpb/cfgov-refresh","forks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/forks","keys_url":"https://api.github.com/repos/cfpb/cfgov-refresh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfpb/cfgov-refresh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfpb/cfgov-refresh/teams","hooks_url":"https://api.github.com/repos/cfpb/cfgov-refresh/hooks","issue_events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/events{/number}","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/events","assignees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/assignees{/user}","branches_url":"https://api.github.com/repos/cfpb/cfgov-refresh/branches{/branch}","tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/tags","blobs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/{sha}","languages_url":"https://api.github.com/repos/cfpb/cfgov-refresh/languages","stargazers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/stargazers","contributors_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contributors","subscribers_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscribers","subscription_url":"https://api.github.com/repos/cfpb/cfgov-refresh/subscription","commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfpb/cfgov-refresh/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfpb/cfgov-refresh/contents/{+path}","compare_url":"https://api.github.com/repos/cfpb/cfgov-refresh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfpb/cfgov-refresh/merges","archive_url":"https://api.github.com/repos/cfpb/cfgov-refresh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfpb/cfgov-refresh/downloads","issues_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues{/number}","pulls_url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls{/number}","milestones_url":"https://api.github.com/repos/cfpb/cfgov-refresh/milestones{/number}","notifications_url":"https://api.github.com/repos/cfpb/cfgov-refresh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels{/name}","releases_url":"https://api.github.com/repos/cfpb/cfgov-refresh/releases{/id}","created_at":"2014-04-16T19:22:03Z","updated_at":"2015-07-16T17:30:22Z","pushed_at":"2015-08-13T18:07:31Z","git_url":"git://github.com/cfpb/cfgov-refresh.git","ssh_url":"git@github.com:cfpb/cfgov-refresh.git","clone_url":"https://github.com/cfpb/cfgov-refresh.git","svn_url":"https://github.com/cfpb/cfgov-refresh","homepage":"","size":95413,"stargazers_count":9,"watchers_count":9,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":94,"forks":17,"open_issues":94,"watchers":9,"default_branch":"flapjack"}},"_links":{"self":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/859"},"html":{"href":"https://github.com/cfpb/cfgov-refresh/pull/859"},"issue":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/859"},"comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/859/comments"},"review_comments":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/859/comments"},"review_comment":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/859/commits"},"statuses":{"href":"https://api.github.com/repos/cfpb/cfgov-refresh/statuses/7825f9ad0a48eba12762cf4343013926c0c6f9b2"}}}}