{"action":"created","issue":{"url":"https://api.github.com/repos/busterjs/buster/issues/449","labels_url":"https://api.github.com/repos/busterjs/buster/issues/449/labels{/name}","comments_url":"https://api.github.com/repos/busterjs/buster/issues/449/comments","events_url":"https://api.github.com/repos/busterjs/buster/issues/449/events","html_url":"https://github.com/busterjs/buster/issues/449","id":55980401,"number":449,"title":"buster-ci should not allow additional browsers to be attached at the end of the process.","user":{"login":"GCheung55","id":46033,"avatar_url":"https://avatars.githubusercontent.com/u/46033?v=3","gravatar_id":"","url":"https://api.github.com/users/GCheung55","html_url":"https://github.com/GCheung55","followers_url":"https://api.github.com/users/GCheung55/followers","following_url":"https://api.github.com/users/GCheung55/following{/other_user}","gists_url":"https://api.github.com/users/GCheung55/gists{/gist_id}","starred_url":"https://api.github.com/users/GCheung55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GCheung55/subscriptions","organizations_url":"https://api.github.com/users/GCheung55/orgs","repos_url":"https://api.github.com/users/GCheung55/repos","events_url":"https://api.github.com/users/GCheung55/events{/privacy}","received_events_url":"https://api.github.com/users/GCheung55/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/busterjs/buster/labels/Bug","name":"Bug","color":"e10c02"}],"state":"open","locked":false,"assignee":{"login":"dwittner","id":2492217,"avatar_url":"https://avatars.githubusercontent.com/u/2492217?v=3","gravatar_id":"","url":"https://api.github.com/users/dwittner","html_url":"https://github.com/dwittner","followers_url":"https://api.github.com/users/dwittner/followers","following_url":"https://api.github.com/users/dwittner/following{/other_user}","gists_url":"https://api.github.com/users/dwittner/gists{/gist_id}","starred_url":"https://api.github.com/users/dwittner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwittner/subscriptions","organizations_url":"https://api.github.com/users/dwittner/orgs","repos_url":"https://api.github.com/users/dwittner/repos","events_url":"https://api.github.com/users/dwittner/events{/privacy}","received_events_url":"https://api.github.com/users/dwittner/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/busterjs/buster/milestones/1","html_url":"https://github.com/busterjs/buster/milestones/1.0%20release","labels_url":"https://api.github.com/repos/busterjs/buster/milestones/1/labels","id":63335,"number":1,"title":"1.0 release","description":"","creator":{"login":"augustl","id":375,"avatar_url":"https://avatars.githubusercontent.com/u/375?v=3","gravatar_id":"","url":"https://api.github.com/users/augustl","html_url":"https://github.com/augustl","followers_url":"https://api.github.com/users/augustl/followers","following_url":"https://api.github.com/users/augustl/following{/other_user}","gists_url":"https://api.github.com/users/augustl/gists{/gist_id}","starred_url":"https://api.github.com/users/augustl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/augustl/subscriptions","organizations_url":"https://api.github.com/users/augustl/orgs","repos_url":"https://api.github.com/users/augustl/repos","events_url":"https://api.github.com/users/augustl/events{/privacy}","received_events_url":"https://api.github.com/users/augustl/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":126,"state":"open","created_at":"2011-12-07T21:34:11Z","updated_at":"2015-07-14T07:03:46Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2015-01-30T00:53:09Z","updated_at":"2015-08-21T23:47:29Z","closed_at":null,"body":"Somehow, additional browsers are being attached at the end of the test runs. Browsers should only attach at the beginning and prevented when close to the end of the process.\r\n\r\n```bash\r\n     [exec] validateBrowserConfig\r\n     [exec] capture browsers\r\n     [exec] [\"1\"]\r\n     [exec] sendMessage: {\r\n     [exec]   browsers: { Phantom: { id: 1 } },\r\n     [exec]   command: \"start\",\r\n     [exec]   url: \"http://localhost:1313/capture\"\r\n     [exec] }\r\n     [exec] received command: {\r\n     [exec]   browsers: { Phantom: { id: 1 } },\r\n     [exec]   command: \"start\",\r\n     [exec]   url: \"http://localhost:1313/capture\"\r\n     [exec] }\r\n     [exec] start browser Phantom\r\n     [exec] slave ready: { slaveId: \"1\" }\r\n     [exec] []\r\n     [exec] All browsers are ready.\r\n     [exec] run tests\r\n     [exec] slave ready: { slaveId: \"fbf293ab-c4ca-4133-80ab-58a5a12f6c55\" }\r\n     [exec] []\r\n     [exec] All browsers are ready.\r\n     [exec] close browsers\r\n     [exec] [\"1\"]\r\n     [exec] slave disconnected gracefully: { slaveId: \"b8ddbe66-fac6-42ed-8255-c17a5c9ae959\" }\r\n     [exec] []\r\n     [exec] All browsers are closed.\r\n     [exec] All done.\r\n     [exec] sendMessage: { browsers: { Phantom: { id: 1 } }, command: \"stop\" }\r\n```"},"comment":{"url":"https://api.github.com/repos/busterjs/buster/issues/comments/133591853","html_url":"https://github.com/busterjs/buster/issues/449#issuecomment-133591853","issue_url":"https://api.github.com/repos/busterjs/buster/issues/449","id":133591853,"user":{"login":"GCheung55","id":46033,"avatar_url":"https://avatars.githubusercontent.com/u/46033?v=3","gravatar_id":"","url":"https://api.github.com/users/GCheung55","html_url":"https://github.com/GCheung55","followers_url":"https://api.github.com/users/GCheung55/followers","following_url":"https://api.github.com/users/GCheung55/following{/other_user}","gists_url":"https://api.github.com/users/GCheung55/gists{/gist_id}","starred_url":"https://api.github.com/users/GCheung55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GCheung55/subscriptions","organizations_url":"https://api.github.com/users/GCheung55/orgs","repos_url":"https://api.github.com/users/GCheung55/repos","events_url":"https://api.github.com/users/GCheung55/events{/privacy}","received_events_url":"https://api.github.com/users/GCheung55/received_events","type":"User","site_admin":false},"created_at":"2015-08-21T23:47:29Z","updated_at":"2015-08-21T23:47:29Z","body":"> I am not convinced yet, that the cause of your problems has something to do with blocking synchronous tasks. First of all i wonder why a browser gets a new session id after reconnecting. I will clarify that first and then investigate your problem further.\r\n\r\nI think this can be easily reproduced with `buster-server` with the following steps:\r\n\r\n1. Spin up `buster-server` and capture a browser.\r\n2. Once the browser is captured, take note of the slave ID in the URL and kill `buster-server`.\r\n3. Spin up `buster-server` again and take a look at the captured browser's URL and compare the slave ID.\r\n\r\nWhat happens here is that once the `buster-server` is killed the first time, the captured browser will attempt to reconnect with the server via `faye`. Once the `buster-server` is available again, a new slave ID is assigned and the page is refreshed. @augustl might have some insight in this area?"}}