{"action":"closed","number":12645,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12645","id":42345290,"html_url":"https://github.com/kubernetes/kubernetes/pull/12645","diff_url":"https://github.com/kubernetes/kubernetes/pull/12645.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/12645.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12645","number":12645,"state":"closed","locked":false,"title":"to add tests for RC selector overlapping and fix few comments","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"body":"\r\n\r\nGoal of this PR is to try to solve some issues in kubectl/stop code\r\n\r\nThese issues have been spotted during the refresh of https://github.com/kubernetes/kubernetes/pull/7053.\r\n\r\nCode comments  [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/stop.go#L118) here [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/stop.go#L131) and [here] (https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/replication/replication_controller.go#L207) have been modified since the current ones looks incorrect\r\n\r\n\r\nThe test [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/stop_test.go#L29) is not testing the labels.Selectors (there's no labels.Selector at all in the ReplicationController) and few tests have been added\r\n\r\n@smarterclayton @bgrant0607 @lavalamp @pmorie \r\nThanks to have a look and let me know\r\n\r\n@EricMountain-1A as discussed","created_at":"2015-08-13T12:38:25Z","updated_at":"2015-08-25T14:07:50Z","closed_at":"2015-08-25T14:07:50Z","merged_at":"2015-08-25T14:07:50Z","merge_commit_sha":"95e226c513363b822a107611c4830cad267709b1","assignee":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12645/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12645/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12645/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8e4d74988aecc8dd053b59d6bf82128627341386","head":{"label":"sdminonne:labels_selector_overlaps","ref":"labels_selector_overlaps","sha":"8e4d74988aecc8dd053b59d6bf82128627341386","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"repo":{"id":27047169,"name":"kubernetes","full_name":"sdminonne/kubernetes","owner":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdminonne/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/sdminonne/kubernetes","forks_url":"https://api.github.com/repos/sdminonne/kubernetes/forks","keys_url":"https://api.github.com/repos/sdminonne/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdminonne/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdminonne/kubernetes/teams","hooks_url":"https://api.github.com/repos/sdminonne/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/sdminonne/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/sdminonne/kubernetes/events","assignees_url":"https://api.github.com/repos/sdminonne/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/sdminonne/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/sdminonne/kubernetes/tags","blobs_url":"https://api.github.com/repos/sdminonne/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdminonne/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdminonne/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdminonne/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdminonne/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/sdminonne/kubernetes/languages","stargazers_url":"https://api.github.com/repos/sdminonne/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/sdminonne/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/sdminonne/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/sdminonne/kubernetes/subscription","commits_url":"https://api.github.com/repos/sdminonne/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdminonne/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdminonne/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdminonne/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdminonne/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/sdminonne/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdminonne/kubernetes/merges","archive_url":"https://api.github.com/repos/sdminonne/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdminonne/kubernetes/downloads","issues_url":"https://api.github.com/repos/sdminonne/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/sdminonne/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/sdminonne/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/sdminonne/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdminonne/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/sdminonne/kubernetes/releases{/id}","created_at":"2014-11-23T20:52:45Z","updated_at":"2015-05-06T22:08:25Z","pushed_at":"2015-08-25T13:17:24Z","git_url":"git://github.com/sdminonne/kubernetes.git","ssh_url":"git@github.com:sdminonne/kubernetes.git","clone_url":"https://github.com/sdminonne/kubernetes.git","svn_url":"https://github.com/sdminonne/kubernetes","homepage":null,"size":102155,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4d10def14f8cb9f6909d0fd914bf9cba5f38f2c1","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-25T13:55:01Z","pushed_at":"2015-08-25T14:07:50Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":361282,"stargazers_count":9880,"watchers_count":9880,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2388,"mirror_url":null,"open_issues_count":1773,"forks":2388,"open_issues":1773,"watchers":9880,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12645"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/12645"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/12645"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/12645/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12645/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12645/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8e4d74988aecc8dd053b59d6bf82128627341386"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gmarek","id":1703842,"avatar_url":"https://avatars.githubusercontent.com/u/1703842?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},"comments":16,"review_comments":13,"commits":1,"additions":245,"deletions":35,"changed_files":3}}