{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/comments/35834276","id":35834276,"diff_hunk":"@@ -192,9 +192,20 @@ public boolean setOwnership(DeviceIdentifier deviceId, String ownershipType)\n     }\n \n     @Override\n-    public boolean updateDeviceInfo(Device device) throws DeviceManagementException {\n+    public boolean updateDeviceInfo(DeviceIdentifier deviceIdentifier, Device device) throws DeviceManagementException {\n         boolean status;\n-        MobileDevice mobileDevice = MobileDeviceManagementUtil.convertToMobileDevice(device);\n+\t\tDevice deviceDB = this.getDevice(deviceIdentifier);","path":"components/device-mgt/org.wso2.carbon.device.mgt.mobile.impl/src/main/java/org/wso2/carbon/device/mgt/mobile/impl/android/AndroidDeviceManager.java","position":8,"original_position":8,"commit_id":"679cc35265b079e2ba57c0d8c52c71422c910351","original_commit_id":"679cc35265b079e2ba57c0d8c52c71422c910351","user":{"login":"milanperera","id":11870191,"avatar_url":"https://avatars.githubusercontent.com/u/11870191?v=3","gravatar_id":"","url":"https://api.github.com/users/milanperera","html_url":"https://github.com/milanperera","followers_url":"https://api.github.com/users/milanperera/followers","following_url":"https://api.github.com/users/milanperera/following{/other_user}","gists_url":"https://api.github.com/users/milanperera/gists{/gist_id}","starred_url":"https://api.github.com/users/milanperera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milanperera/subscriptions","organizations_url":"https://api.github.com/users/milanperera/orgs","repos_url":"https://api.github.com/users/milanperera/repos","events_url":"https://api.github.com/users/milanperera/events{/privacy}","received_events_url":"https://api.github.com/users/milanperera/received_events","type":"User","site_admin":false},"body":"The reason to DB appended in this variable because there is a variable which already has the name \"device\" (in the method parameter). However I have changed the name in order to make it meaningful in PR[https://github.com/wso2/carbon-device-mgt-plugins/pull/7]","created_at":"2015-07-30T02:54:40Z","updated_at":"2015-07-30T02:54:40Z","html_url":"https://github.com/wso2/carbon-device-mgt-plugins/pull/6#discussion_r35834276","pull_request_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/comments/35834276"},"html":{"href":"https://github.com/wso2/carbon-device-mgt-plugins/pull/6#discussion_r35834276"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/6","id":35723749,"html_url":"https://github.com/wso2/carbon-device-mgt-plugins/pull/6","diff_url":"https://github.com/wso2/carbon-device-mgt-plugins/pull/6.diff","patch_url":"https://github.com/wso2/carbon-device-mgt-plugins/pull/6.patch","issue_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/issues/6","number":6,"state":"closed","locked":false,"title":"Refactored to support device info function","user":{"login":"milanperera","id":11870191,"avatar_url":"https://avatars.githubusercontent.com/u/11870191?v=3","gravatar_id":"","url":"https://api.github.com/users/milanperera","html_url":"https://github.com/milanperera","followers_url":"https://api.github.com/users/milanperera/followers","following_url":"https://api.github.com/users/milanperera/following{/other_user}","gists_url":"https://api.github.com/users/milanperera/gists{/gist_id}","starred_url":"https://api.github.com/users/milanperera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milanperera/subscriptions","organizations_url":"https://api.github.com/users/milanperera/orgs","repos_url":"https://api.github.com/users/milanperera/repos","events_url":"https://api.github.com/users/milanperera/events{/privacy}","received_events_url":"https://api.github.com/users/milanperera/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-19T12:17:04Z","updated_at":"2015-07-30T02:54:40Z","closed_at":"2015-05-19T12:53:40Z","merged_at":"2015-05-19T12:53:40Z","merge_commit_sha":"d6dd333e62d782aad8d2b110932d330be0d31923","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/6/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/6/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/issues/6/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/statuses/679cc35265b079e2ba57c0d8c52c71422c910351","head":{"label":"milanperera:master","ref":"master","sha":"679cc35265b079e2ba57c0d8c52c71422c910351","user":{"login":"milanperera","id":11870191,"avatar_url":"https://avatars.githubusercontent.com/u/11870191?v=3","gravatar_id":"","url":"https://api.github.com/users/milanperera","html_url":"https://github.com/milanperera","followers_url":"https://api.github.com/users/milanperera/followers","following_url":"https://api.github.com/users/milanperera/following{/other_user}","gists_url":"https://api.github.com/users/milanperera/gists{/gist_id}","starred_url":"https://api.github.com/users/milanperera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milanperera/subscriptions","organizations_url":"https://api.github.com/users/milanperera/orgs","repos_url":"https://api.github.com/users/milanperera/repos","events_url":"https://api.github.com/users/milanperera/events{/privacy}","received_events_url":"https://api.github.com/users/milanperera/received_events","type":"User","site_admin":false},"repo":{"id":34839367,"name":"carbon-device-mgt-plugins","full_name":"milanperera/carbon-device-mgt-plugins","owner":{"login":"milanperera","id":11870191,"avatar_url":"https://avatars.githubusercontent.com/u/11870191?v=3","gravatar_id":"","url":"https://api.github.com/users/milanperera","html_url":"https://github.com/milanperera","followers_url":"https://api.github.com/users/milanperera/followers","following_url":"https://api.github.com/users/milanperera/following{/other_user}","gists_url":"https://api.github.com/users/milanperera/gists{/gist_id}","starred_url":"https://api.github.com/users/milanperera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milanperera/subscriptions","organizations_url":"https://api.github.com/users/milanperera/orgs","repos_url":"https://api.github.com/users/milanperera/repos","events_url":"https://api.github.com/users/milanperera/events{/privacy}","received_events_url":"https://api.github.com/users/milanperera/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milanperera/carbon-device-mgt-plugins","description":"","fork":true,"url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins","forks_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/forks","keys_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/teams","hooks_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/hooks","issue_events_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/events","assignees_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/tags","blobs_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/languages","stargazers_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/stargazers","contributors_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/contributors","subscribers_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/subscribers","subscription_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/subscription","commits_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/merges","archive_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/downloads","issues_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/labels{/name}","releases_url":"https://api.github.com/repos/milanperera/carbon-device-mgt-plugins/releases{/id}","created_at":"2015-04-30T06:59:48Z","updated_at":"2015-04-30T08:28:14Z","pushed_at":"2015-07-28T14:08:26Z","git_url":"git://github.com/milanperera/carbon-device-mgt-plugins.git","ssh_url":"git@github.com:milanperera/carbon-device-mgt-plugins.git","clone_url":"https://github.com/milanperera/carbon-device-mgt-plugins.git","svn_url":"https://github.com/milanperera/carbon-device-mgt-plugins","homepage":null,"size":8822,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"c0783fa83c99f84796503bf3302935f8432f7395","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":30521516,"name":"carbon-device-mgt-plugins","full_name":"wso2/carbon-device-mgt-plugins","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-device-mgt-plugins","description":"","fork":false,"url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins","forks_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/forks","keys_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/events","assignees_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/merges","archive_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/releases{/id}","created_at":"2015-02-09T06:12:40Z","updated_at":"2015-05-06T05:59:59Z","pushed_at":"2015-07-28T15:08:40Z","git_url":"git://github.com/wso2/carbon-device-mgt-plugins.git","ssh_url":"git@github.com:wso2/carbon-device-mgt-plugins.git","clone_url":"https://github.com/wso2/carbon-device-mgt-plugins.git","svn_url":"https://github.com/wso2/carbon-device-mgt-plugins","homepage":null,"size":9110,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/6"},"html":{"href":"https://github.com/wso2/carbon-device-mgt-plugins/pull/6"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/issues/6"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-device-mgt-plugins/statuses/679cc35265b079e2ba57c0d8c52c71422c910351"}}}}