{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments/38255686","id":38255686,"diff_hunk":"@@ -17,7 +17,8 @@\n 'use strict';\n \n var OpaqueSpan = require('./lib/opaque-span.js');\n-var Logger = require('./lib/logger.js');\n+var CloudCommon = require('@google/cloud-diagnostics-common');\n+var Logger = CloudCommon.logger;","path":"index.js","position":6,"original_position":6,"commit_id":"b9d5516a1390b1f109565a75c939b66f65459772","original_commit_id":"b9d5516a1390b1f109565a75c939b66f65459772","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"body":"ditto. This should be `var Logger = common.Logger;` as the latter is actually a class, so it should exported from that module as such.","created_at":"2015-08-29T00:11:36Z","updated_at":"2015-08-29T00:11:36Z","html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/41#discussion_r38255686","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments/38255686"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/41#discussion_r38255686"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/41","id":43682028,"html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/41","diff_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/41.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/41.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/41","number":41,"state":"open","locked":false,"title":"Removed common trace/debug functionality","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"body":"Functionality moved into https://www.npmjs.com/package/@google/cloud-diagnostics-common","created_at":"2015-08-28T23:35:02Z","updated_at":"2015-08-29T00:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67f6fff2e5b239c8391f9448e1f2a37a31e21682","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/41/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/41/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/41/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/b9d5516a1390b1f109565a75c939b66f65459772","head":{"label":"matthewloring:common-refactor","ref":"common-refactor","sha":"b9d5516a1390b1f109565a75c939b66f65459772","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"repo":{"id":41391013,"name":"cloud-trace-nodejs","full_name":"matthewloring/cloud-trace-nodejs","owner":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewloring/cloud-trace-nodejs","description":"Experimental Node.js support for Google Cloud Trace","fork":true,"url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs","forks_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/forks","keys_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/teams","hooks_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/hooks","issue_events_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/events","assignees_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/tags","blobs_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/languages","stargazers_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/stargazers","contributors_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/contributors","subscribers_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/subscribers","subscription_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/subscription","commits_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/merges","archive_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/downloads","issues_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/matthewloring/cloud-trace-nodejs/releases{/id}","created_at":"2015-08-25T22:25:15Z","updated_at":"2015-08-25T22:25:15Z","pushed_at":"2015-08-28T23:33:43Z","git_url":"git://github.com/matthewloring/cloud-trace-nodejs.git","ssh_url":"git@github.com:matthewloring/cloud-trace-nodejs.git","clone_url":"https://github.com/matthewloring/cloud-trace-nodejs.git","svn_url":"https://github.com/matthewloring/cloud-trace-nodejs","homepage":"https://cloud.google.com/cloud-trace/","size":182,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"ac427957199f91156aa7e00ccf98decf1c10241c","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":41170869,"name":"cloud-trace-nodejs","full_name":"GoogleCloudPlatform/cloud-trace-nodejs","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs","description":"Experimental Node.js support for Google Cloud Trace","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/releases{/id}","created_at":"2015-08-21T18:23:09Z","updated_at":"2015-08-27T13:05:30Z","pushed_at":"2015-08-28T23:35:02Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-trace-nodejs.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-trace-nodejs.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs","homepage":"https://cloud.google.com/cloud-trace/","size":282,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":18,"forks":2,"open_issues":18,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/41"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/41"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/41"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/b9d5516a1390b1f109565a75c939b66f65459772"}}}}