{"action":"created","issue":{"url":"https://api.github.com/repos/ThemeBoy/SportsPress/issues/125","labels_url":"https://api.github.com/repos/ThemeBoy/SportsPress/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/ThemeBoy/SportsPress/issues/125/comments","events_url":"https://api.github.com/repos/ThemeBoy/SportsPress/issues/125/events","html_url":"https://github.com/ThemeBoy/SportsPress/pull/125","id":64635065,"number":125,"title":"Filter teams by competition and season when creating an event.","user":{"login":"MounirHamani","id":11670385,"avatar_url":"https://avatars.githubusercontent.com/u/11670385?v=3","gravatar_id":"","url":"https://api.github.com/users/MounirHamani","html_url":"https://github.com/MounirHamani","followers_url":"https://api.github.com/users/MounirHamani/followers","following_url":"https://api.github.com/users/MounirHamani/following{/other_user}","gists_url":"https://api.github.com/users/MounirHamani/gists{/gist_id}","starred_url":"https://api.github.com/users/MounirHamani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MounirHamani/subscriptions","organizations_url":"https://api.github.com/users/MounirHamani/orgs","repos_url":"https://api.github.com/users/MounirHamani/repos","events_url":"https://api.github.com/users/MounirHamani/events{/privacy}","received_events_url":"https://api.github.com/users/MounirHamani/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-26T21:11:17Z","updated_at":"2015-03-27T07:04:49Z","closed_at":"2015-03-27T06:51:50Z","pull_request":{"url":"https://api.github.com/repos/ThemeBoy/SportsPress/pulls/125","html_url":"https://github.com/ThemeBoy/SportsPress/pull/125","diff_url":"https://github.com/ThemeBoy/SportsPress/pull/125.diff","patch_url":"https://github.com/ThemeBoy/SportsPress/pull/125.patch"},"body":"Hi ThemeBoy,\r\n\r\nSince yesterday, I have been testing out your Wonderful SportsPress plugin and it's just breathtaking in the sense that every time I told myself \"aha, it lacks this feature\", I found some minutes later that it did implement it and in a better way than I expected.\r\n\r\nThe only thing that I noticed (I think you just missed it by testing with a small set of 3 or 4 teams) is that when you have multiple divisons and competitions or different teams across seasons, you end up with a long list of teams.\r\n\r\nSo to make it more user friendly while creating an event, it will be good to filter the list of teams when one has selected the competition and the season.\r\nThe way it works with my fix is that you first create the event by setting the competition (league) and/or season and optionally the date ...etc... after what you save the event. Then, if you click on the teams dropdown, it will be a filtered subset of your teams list according to the competition (league) and season you have chosen before saving.\r\nIf you decide to edit the the competitoon (league) or season, you will need to save again in order to have an updated filtered list.\r\n\r\nIf you have chosen a competition for example, then saved, then chosen a team from that competion and saved, then edited to a different competion to which your chosen team doesn't belong, then the team field will be reset to 'None' and you will have the ability to choose from the updated filtered list.\r\n\r\nSportsPress is literally the best plugin I have ever seen. It has 99% of what it needs to have except from the little suggestion I made above.\r\n\r\nCordially, Mounir."},"comment":{"url":"https://api.github.com/repos/ThemeBoy/SportsPress/issues/comments/86849346","html_url":"https://github.com/ThemeBoy/SportsPress/pull/125#issuecomment-86849346","issue_url":"https://api.github.com/repos/ThemeBoy/SportsPress/issues/125","id":86849346,"user":{"login":"ThemeBoy","id":483203,"avatar_url":"https://avatars.githubusercontent.com/u/483203?v=3","gravatar_id":"","url":"https://api.github.com/users/ThemeBoy","html_url":"https://github.com/ThemeBoy","followers_url":"https://api.github.com/users/ThemeBoy/followers","following_url":"https://api.github.com/users/ThemeBoy/following{/other_user}","gists_url":"https://api.github.com/users/ThemeBoy/gists{/gist_id}","starred_url":"https://api.github.com/users/ThemeBoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThemeBoy/subscriptions","organizations_url":"https://api.github.com/users/ThemeBoy/orgs","repos_url":"https://api.github.com/users/ThemeBoy/repos","events_url":"https://api.github.com/users/ThemeBoy/events{/privacy}","received_events_url":"https://api.github.com/users/ThemeBoy/received_events","type":"User","site_admin":false},"created_at":"2015-03-27T07:04:49Z","updated_at":"2015-03-27T07:04:49Z","body":"Hi @MounirHamani, I'm glad you're enjoying the plugin!\r\n\r\nThanks for your contribution. I've merged your changes and some additional optimization to make teams in events filter by competition and season :)"}}