{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/38674587","id":38674587,"diff_hunk":"@@ -152,6 +152,28 @@ private void EmitLoopExpression(Expression expr)\n         private void EmitSwitchExpression(Expression expr, CompilationFlags flags)\n         {\n             SwitchExpression node = (SwitchExpression)expr;\n+            \n+            if (node.Cases.Count == 0)\n+            {","path":"src/System.Linq.Expressions/src/System/Linq/Expressions/Compiler/LambdaCompiler.Statements.cs","position":6,"original_position":6,"commit_id":"b4aecfe26bd528806f0fd1f1fc6ac5b57e292f35","original_commit_id":"b4aecfe26bd528806f0fd1f1fc6ac5b57e292f35","user":{"login":"JonHanna","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/JonHanna","html_url":"https://github.com/JonHanna","followers_url":"https://api.github.com/users/JonHanna/followers","following_url":"https://api.github.com/users/JonHanna/following{/other_user}","gists_url":"https://api.github.com/users/JonHanna/gists{/gist_id}","starred_url":"https://api.github.com/users/JonHanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonHanna/subscriptions","organizations_url":"https://api.github.com/users/JonHanna/orgs","repos_url":"https://api.github.com/users/JonHanna/repos","events_url":"https://api.github.com/users/JonHanna/events{/privacy}","received_events_url":"https://api.github.com/users/JonHanna/received_events","type":"User","site_admin":false},"body":"I would have thought on first blush that this was a matter of changing LightCompiler.cs at line 2937 and StackSpiller.Generated.cs (generated by what?) at line 189 to branch on `.CanReduce`. And that seems to be the case with StackSpiller anyway, but I'm not a all clear on how to test LightCompiler.cs, which makes me obviously much less confident with this than once I was.","created_at":"2015-09-03T17:48:20Z","updated_at":"2015-09-03T17:48:20Z","html_url":"https://github.com/dotnet/corefx/pull/3041#discussion_r38674587","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/3041","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/38674587"},"html":{"href":"https://github.com/dotnet/corefx/pull/3041#discussion_r38674587"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3041"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/3041","id":43860530,"html_url":"https://github.com/dotnet/corefx/pull/3041","diff_url":"https://github.com/dotnet/corefx/pull/3041.diff","patch_url":"https://github.com/dotnet/corefx/pull/3041.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/3041","number":3041,"state":"open","locked":false,"title":"Allow a SwitchExpression to have no Cases.","user":{"login":"JonHanna","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/JonHanna","html_url":"https://github.com/JonHanna","followers_url":"https://api.github.com/users/JonHanna/followers","following_url":"https://api.github.com/users/JonHanna/following{/other_user}","gists_url":"https://api.github.com/users/JonHanna/gists{/gist_id}","starred_url":"https://api.github.com/users/JonHanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonHanna/subscriptions","organizations_url":"https://api.github.com/users/JonHanna/orgs","repos_url":"https://api.github.com/users/JonHanna/repos","events_url":"https://api.github.com/users/JonHanna/events{/privacy}","received_events_url":"https://api.github.com/users/JonHanna/received_events","type":"User","site_admin":false},"body":"Fixes #1877\r\n\r\nIf type of is not specified, it will be that of default body, or\r\nnull if there is no default body.\r\n\r\nIf there is no default body, and the type is specified, it must be void.\r\n\r\nOn emitting, the result is the same as if the default body was emitted.","created_at":"2015-09-01T10:35:58Z","updated_at":"2015-09-03T17:48:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bce1bd1edeaf4610b08b15f8c03b638c8da4a1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/3041/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/3041/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/3041/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/b4aecfe26bd528806f0fd1f1fc6ac5b57e292f35","head":{"label":"JonHanna:switch_expression_without_cases","ref":"switch_expression_without_cases","sha":"b4aecfe26bd528806f0fd1f1fc6ac5b57e292f35","user":{"login":"JonHanna","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/JonHanna","html_url":"https://github.com/JonHanna","followers_url":"https://api.github.com/users/JonHanna/followers","following_url":"https://api.github.com/users/JonHanna/following{/other_user}","gists_url":"https://api.github.com/users/JonHanna/gists{/gist_id}","starred_url":"https://api.github.com/users/JonHanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonHanna/subscriptions","organizations_url":"https://api.github.com/users/JonHanna/orgs","repos_url":"https://api.github.com/users/JonHanna/repos","events_url":"https://api.github.com/users/JonHanna/events{/privacy}","received_events_url":"https://api.github.com/users/JonHanna/received_events","type":"User","site_admin":false},"repo":{"id":38018243,"name":"corefx","full_name":"JonHanna/corefx","owner":{"login":"JonHanna","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/JonHanna","html_url":"https://github.com/JonHanna","followers_url":"https://api.github.com/users/JonHanna/followers","following_url":"https://api.github.com/users/JonHanna/following{/other_user}","gists_url":"https://api.github.com/users/JonHanna/gists{/gist_id}","starred_url":"https://api.github.com/users/JonHanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonHanna/subscriptions","organizations_url":"https://api.github.com/users/JonHanna/orgs","repos_url":"https://api.github.com/users/JonHanna/repos","events_url":"https://api.github.com/users/JonHanna/events{/privacy}","received_events_url":"https://api.github.com/users/JonHanna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonHanna/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/JonHanna/corefx","forks_url":"https://api.github.com/repos/JonHanna/corefx/forks","keys_url":"https://api.github.com/repos/JonHanna/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonHanna/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonHanna/corefx/teams","hooks_url":"https://api.github.com/repos/JonHanna/corefx/hooks","issue_events_url":"https://api.github.com/repos/JonHanna/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/JonHanna/corefx/events","assignees_url":"https://api.github.com/repos/JonHanna/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/JonHanna/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/JonHanna/corefx/tags","blobs_url":"https://api.github.com/repos/JonHanna/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonHanna/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonHanna/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonHanna/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonHanna/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/JonHanna/corefx/languages","stargazers_url":"https://api.github.com/repos/JonHanna/corefx/stargazers","contributors_url":"https://api.github.com/repos/JonHanna/corefx/contributors","subscribers_url":"https://api.github.com/repos/JonHanna/corefx/subscribers","subscription_url":"https://api.github.com/repos/JonHanna/corefx/subscription","commits_url":"https://api.github.com/repos/JonHanna/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonHanna/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonHanna/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonHanna/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonHanna/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/JonHanna/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonHanna/corefx/merges","archive_url":"https://api.github.com/repos/JonHanna/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonHanna/corefx/downloads","issues_url":"https://api.github.com/repos/JonHanna/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/JonHanna/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/JonHanna/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/JonHanna/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonHanna/corefx/labels{/name}","releases_url":"https://api.github.com/repos/JonHanna/corefx/releases{/id}","created_at":"2015-06-25T00:19:13Z","updated_at":"2015-06-25T00:19:32Z","pushed_at":"2015-09-03T14:05:19Z","git_url":"git://github.com/JonHanna/corefx.git","ssh_url":"git@github.com:JonHanna/corefx.git","clone_url":"https://github.com/JonHanna/corefx.git","svn_url":"https://github.com/JonHanna/corefx","homepage":"http://dotnet.github.io/core/","size":30617,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"fde14635af4038231e28f6caa908404f8ff039ec","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-09-03T11:51:01Z","pushed_at":"2015-09-03T17:11:49Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":66052,"stargazers_count":8275,"watchers_count":8275,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1765,"mirror_url":null,"open_issues_count":574,"forks":1765,"open_issues":574,"watchers":8275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3041"},"html":{"href":"https://github.com/dotnet/corefx/pull/3041"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3041"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/3041/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3041/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/3041/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/b4aecfe26bd528806f0fd1f1fc6ac5b57e292f35"}}}}