{"action":"opened","number":146,"pull_request":{"url":"https://api.github.com/repos/jeff-collins/ment.io/pulls/146","id":52750206,"html_url":"https://github.com/jeff-collins/ment.io/pull/146","diff_url":"https://github.com/jeff-collins/ment.io/pull/146.diff","patch_url":"https://github.com/jeff-collins/ment.io/pull/146.patch","issue_url":"https://api.github.com/repos/jeff-collins/ment.io/issues/146","number":146,"state":"open","locked":false,"title":"Added check to see if the element has fixed position and use fixed po…","user":{"login":"sras","id":6322381,"avatar_url":"https://avatars.githubusercontent.com/u/6322381?v=3","gravatar_id":"","url":"https://api.github.com/users/sras","html_url":"https://github.com/sras","followers_url":"https://api.github.com/users/sras/followers","following_url":"https://api.github.com/users/sras/following{/other_user}","gists_url":"https://api.github.com/users/sras/gists{/gist_id}","starred_url":"https://api.github.com/users/sras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sras/subscriptions","organizations_url":"https://api.github.com/users/sras/orgs","repos_url":"https://api.github.com/users/sras/repos","events_url":"https://api.github.com/users/sras/events{/privacy}","received_events_url":"https://api.github.com/users/sras/received_events","type":"User","site_admin":false},"body":"When the editable element is inside a element which is fixed, the menu appears either at the top or at a point above where it should ideally appear. This apparently is due to the fact that the cursor position calculation code returns a position relative to the top of the window (the target  being fixed positioned), but when that position is applied to the absolutely positioned menu item, it ends up being positioned by that amount from the top of the page (as opposed to the window top), which results in the error.\r\n\r\nIt was fixed by seeing if the target element is fixed or inside a fixed parent, and if so, giving fixed position to the menu drop down. ","created_at":"2015-12-05T08:17:23Z","updated_at":"2015-12-05T08:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jeff-collins/ment.io/pulls/146/commits","review_comments_url":"https://api.github.com/repos/jeff-collins/ment.io/pulls/146/comments","review_comment_url":"https://api.github.com/repos/jeff-collins/ment.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jeff-collins/ment.io/issues/146/comments","statuses_url":"https://api.github.com/repos/jeff-collins/ment.io/statuses/d0a10bb069fd71e015ed1cebae445bf1c1196d21","head":{"label":"sras:bugfix/fixedPositionError","ref":"bugfix/fixedPositionError","sha":"d0a10bb069fd71e015ed1cebae445bf1c1196d21","user":{"login":"sras","id":6322381,"avatar_url":"https://avatars.githubusercontent.com/u/6322381?v=3","gravatar_id":"","url":"https://api.github.com/users/sras","html_url":"https://github.com/sras","followers_url":"https://api.github.com/users/sras/followers","following_url":"https://api.github.com/users/sras/following{/other_user}","gists_url":"https://api.github.com/users/sras/gists{/gist_id}","starred_url":"https://api.github.com/users/sras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sras/subscriptions","organizations_url":"https://api.github.com/users/sras/orgs","repos_url":"https://api.github.com/users/sras/repos","events_url":"https://api.github.com/users/sras/events{/privacy}","received_events_url":"https://api.github.com/users/sras/received_events","type":"User","site_admin":false},"repo":{"id":47437348,"name":"ment.io","full_name":"sras/ment.io","owner":{"login":"sras","id":6322381,"avatar_url":"https://avatars.githubusercontent.com/u/6322381?v=3","gravatar_id":"","url":"https://api.github.com/users/sras","html_url":"https://github.com/sras","followers_url":"https://api.github.com/users/sras/followers","following_url":"https://api.github.com/users/sras/following{/other_user}","gists_url":"https://api.github.com/users/sras/gists{/gist_id}","starred_url":"https://api.github.com/users/sras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sras/subscriptions","organizations_url":"https://api.github.com/users/sras/orgs","repos_url":"https://api.github.com/users/sras/repos","events_url":"https://api.github.com/users/sras/events{/privacy}","received_events_url":"https://api.github.com/users/sras/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sras/ment.io","description":"Mentions and Macros for Angular","fork":true,"url":"https://api.github.com/repos/sras/ment.io","forks_url":"https://api.github.com/repos/sras/ment.io/forks","keys_url":"https://api.github.com/repos/sras/ment.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sras/ment.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sras/ment.io/teams","hooks_url":"https://api.github.com/repos/sras/ment.io/hooks","issue_events_url":"https://api.github.com/repos/sras/ment.io/issues/events{/number}","events_url":"https://api.github.com/repos/sras/ment.io/events","assignees_url":"https://api.github.com/repos/sras/ment.io/assignees{/user}","branches_url":"https://api.github.com/repos/sras/ment.io/branches{/branch}","tags_url":"https://api.github.com/repos/sras/ment.io/tags","blobs_url":"https://api.github.com/repos/sras/ment.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sras/ment.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sras/ment.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/sras/ment.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sras/ment.io/statuses/{sha}","languages_url":"https://api.github.com/repos/sras/ment.io/languages","stargazers_url":"https://api.github.com/repos/sras/ment.io/stargazers","contributors_url":"https://api.github.com/repos/sras/ment.io/contributors","subscribers_url":"https://api.github.com/repos/sras/ment.io/subscribers","subscription_url":"https://api.github.com/repos/sras/ment.io/subscription","commits_url":"https://api.github.com/repos/sras/ment.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/sras/ment.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/sras/ment.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/sras/ment.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/sras/ment.io/contents/{+path}","compare_url":"https://api.github.com/repos/sras/ment.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sras/ment.io/merges","archive_url":"https://api.github.com/repos/sras/ment.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sras/ment.io/downloads","issues_url":"https://api.github.com/repos/sras/ment.io/issues{/number}","pulls_url":"https://api.github.com/repos/sras/ment.io/pulls{/number}","milestones_url":"https://api.github.com/repos/sras/ment.io/milestones{/number}","notifications_url":"https://api.github.com/repos/sras/ment.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sras/ment.io/labels{/name}","releases_url":"https://api.github.com/repos/sras/ment.io/releases{/id}","created_at":"2015-12-05T01:34:31Z","updated_at":"2015-12-05T01:34:31Z","pushed_at":"2015-12-05T08:11:01Z","git_url":"git://github.com/sras/ment.io.git","ssh_url":"git@github.com:sras/ment.io.git","clone_url":"https://github.com/sras/ment.io.git","svn_url":"https://github.com/sras/ment.io","homepage":"http://jeff-collins.github.io/ment.io","size":377,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jeff-collins:master","ref":"master","sha":"ad2a0a98cee5f7779a78c62e9f9f4f8105bfa759","user":{"login":"jeff-collins","id":3493285,"avatar_url":"https://avatars.githubusercontent.com/u/3493285?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-collins","html_url":"https://github.com/jeff-collins","followers_url":"https://api.github.com/users/jeff-collins/followers","following_url":"https://api.github.com/users/jeff-collins/following{/other_user}","gists_url":"https://api.github.com/users/jeff-collins/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-collins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-collins/subscriptions","organizations_url":"https://api.github.com/users/jeff-collins/orgs","repos_url":"https://api.github.com/users/jeff-collins/repos","events_url":"https://api.github.com/users/jeff-collins/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-collins/received_events","type":"User","site_admin":false},"repo":{"id":20909511,"name":"ment.io","full_name":"jeff-collins/ment.io","owner":{"login":"jeff-collins","id":3493285,"avatar_url":"https://avatars.githubusercontent.com/u/3493285?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-collins","html_url":"https://github.com/jeff-collins","followers_url":"https://api.github.com/users/jeff-collins/followers","following_url":"https://api.github.com/users/jeff-collins/following{/other_user}","gists_url":"https://api.github.com/users/jeff-collins/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-collins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-collins/subscriptions","organizations_url":"https://api.github.com/users/jeff-collins/orgs","repos_url":"https://api.github.com/users/jeff-collins/repos","events_url":"https://api.github.com/users/jeff-collins/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-collins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeff-collins/ment.io","description":"Mentions and Macros for Angular","fork":false,"url":"https://api.github.com/repos/jeff-collins/ment.io","forks_url":"https://api.github.com/repos/jeff-collins/ment.io/forks","keys_url":"https://api.github.com/repos/jeff-collins/ment.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeff-collins/ment.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeff-collins/ment.io/teams","hooks_url":"https://api.github.com/repos/jeff-collins/ment.io/hooks","issue_events_url":"https://api.github.com/repos/jeff-collins/ment.io/issues/events{/number}","events_url":"https://api.github.com/repos/jeff-collins/ment.io/events","assignees_url":"https://api.github.com/repos/jeff-collins/ment.io/assignees{/user}","branches_url":"https://api.github.com/repos/jeff-collins/ment.io/branches{/branch}","tags_url":"https://api.github.com/repos/jeff-collins/ment.io/tags","blobs_url":"https://api.github.com/repos/jeff-collins/ment.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeff-collins/ment.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeff-collins/ment.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeff-collins/ment.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeff-collins/ment.io/statuses/{sha}","languages_url":"https://api.github.com/repos/jeff-collins/ment.io/languages","stargazers_url":"https://api.github.com/repos/jeff-collins/ment.io/stargazers","contributors_url":"https://api.github.com/repos/jeff-collins/ment.io/contributors","subscribers_url":"https://api.github.com/repos/jeff-collins/ment.io/subscribers","subscription_url":"https://api.github.com/repos/jeff-collins/ment.io/subscription","commits_url":"https://api.github.com/repos/jeff-collins/ment.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeff-collins/ment.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeff-collins/ment.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeff-collins/ment.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeff-collins/ment.io/contents/{+path}","compare_url":"https://api.github.com/repos/jeff-collins/ment.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeff-collins/ment.io/merges","archive_url":"https://api.github.com/repos/jeff-collins/ment.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeff-collins/ment.io/downloads","issues_url":"https://api.github.com/repos/jeff-collins/ment.io/issues{/number}","pulls_url":"https://api.github.com/repos/jeff-collins/ment.io/pulls{/number}","milestones_url":"https://api.github.com/repos/jeff-collins/ment.io/milestones{/number}","notifications_url":"https://api.github.com/repos/jeff-collins/ment.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeff-collins/ment.io/labels{/name}","releases_url":"https://api.github.com/repos/jeff-collins/ment.io/releases{/id}","created_at":"2014-06-17T03:54:17Z","updated_at":"2015-12-01T15:20:52Z","pushed_at":"2015-12-05T02:11:42Z","git_url":"git://github.com/jeff-collins/ment.io.git","ssh_url":"git@github.com:jeff-collins/ment.io.git","clone_url":"https://github.com/jeff-collins/ment.io.git","svn_url":"https://github.com/jeff-collins/ment.io","homepage":"http://jeff-collins.github.io/ment.io","size":1387,"stargazers_count":966,"watchers_count":966,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":119,"mirror_url":null,"open_issues_count":71,"forks":119,"open_issues":71,"watchers":966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jeff-collins/ment.io/pulls/146"},"html":{"href":"https://github.com/jeff-collins/ment.io/pull/146"},"issue":{"href":"https://api.github.com/repos/jeff-collins/ment.io/issues/146"},"comments":{"href":"https://api.github.com/repos/jeff-collins/ment.io/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/jeff-collins/ment.io/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/jeff-collins/ment.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jeff-collins/ment.io/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/jeff-collins/ment.io/statuses/d0a10bb069fd71e015ed1cebae445bf1c1196d21"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":41,"deletions":11,"changed_files":3}}