{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/AndreasStiegler/universal/pulls/2","id":45412264,"html_url":"https://github.com/AndreasStiegler/universal/pull/2","diff_url":"https://github.com/AndreasStiegler/universal/pull/2.diff","patch_url":"https://github.com/AndreasStiegler/universal/pull/2.patch","issue_url":"https://api.github.com/repos/AndreasStiegler/universal/issues/2","number":2,"state":"closed","locked":false,"title":"Merged with latest master - Also introduced directive in config to disable dispatcher so the tests all pass again","user":{"login":"kaspermarkus","id":167427,"avatar_url":"https://avatars.githubusercontent.com/u/167427?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspermarkus","html_url":"https://github.com/kaspermarkus","followers_url":"https://api.github.com/users/kaspermarkus/followers","following_url":"https://api.github.com/users/kaspermarkus/following{/other_user}","gists_url":"https://api.github.com/users/kaspermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspermarkus/subscriptions","organizations_url":"https://api.github.com/users/kaspermarkus/orgs","repos_url":"https://api.github.com/users/kaspermarkus/repos","events_url":"https://api.github.com/users/kaspermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/kaspermarkus/received_events","type":"User","site_admin":false},"body":"Hey Andy,\r\nSo here's what was supposed to be a minor pull request but grew into a monster... So what I did:\r\n\r\n1) Merged your code with the latest master (this is the reason for all the files changed and the giant size of this pull request)\r\n2) Resolved the conflicts from the merge -- just a couple of function signatures / parameter names\r\n3) Noticed that most of the tests were failing, due to being assigned the statistical matchmaker. I've fixed this by adding a flag to the two main configuration files that are used by the tests - the flag is called: matchMakerDispatcherDisabled and takes a boolean value. If they're not specified the dispatcher is used (ie. by default) - as said I've added them to the development configs used by the tests, so these now pass again.\r\n\r\nSo 99.5% of this pull request is just updating to latest master. The last 0.5% is in this commit https://github.com/kaspermarkus/universal/commit/531651b2d005084320e436c428238a4bab2e4b1c which for some reason contains both your changes and mine -- but it should be pretty clear which parts I did (ie. modify 2 config files, and add \r\n``\r\n        if (that.options.matchMakerDispatcherDisabled) {\r\n            return \"flat\"\r\n        }\r\n``\r\nin the selectMatchMaker function","created_at":"2015-09-18T14:27:44Z","updated_at":"2015-09-30T11:58:29Z","closed_at":"2015-09-30T11:58:29Z","merged_at":"2015-09-30T11:58:29Z","merge_commit_sha":"00bed866c81a4cadf2b13bebf7ac229f20521915","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AndreasStiegler/universal/pulls/2/commits","review_comments_url":"https://api.github.com/repos/AndreasStiegler/universal/pulls/2/comments","review_comment_url":"https://api.github.com/repos/AndreasStiegler/universal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AndreasStiegler/universal/issues/2/comments","statuses_url":"https://api.github.com/repos/AndreasStiegler/universal/statuses/531651b2d005084320e436c428238a4bab2e4b1c","head":{"label":"kaspermarkus:GPII-1110","ref":"GPII-1110","sha":"531651b2d005084320e436c428238a4bab2e4b1c","user":{"login":"kaspermarkus","id":167427,"avatar_url":"https://avatars.githubusercontent.com/u/167427?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspermarkus","html_url":"https://github.com/kaspermarkus","followers_url":"https://api.github.com/users/kaspermarkus/followers","following_url":"https://api.github.com/users/kaspermarkus/following{/other_user}","gists_url":"https://api.github.com/users/kaspermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspermarkus/subscriptions","organizations_url":"https://api.github.com/users/kaspermarkus/orgs","repos_url":"https://api.github.com/users/kaspermarkus/repos","events_url":"https://api.github.com/users/kaspermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/kaspermarkus/received_events","type":"User","site_admin":false},"repo":{"id":3630398,"name":"universal","full_name":"kaspermarkus/universal","owner":{"login":"kaspermarkus","id":167427,"avatar_url":"https://avatars.githubusercontent.com/u/167427?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspermarkus","html_url":"https://github.com/kaspermarkus","followers_url":"https://api.github.com/users/kaspermarkus/followers","following_url":"https://api.github.com/users/kaspermarkus/following{/other_user}","gists_url":"https://api.github.com/users/kaspermarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspermarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspermarkus/subscriptions","organizations_url":"https://api.github.com/users/kaspermarkus/orgs","repos_url":"https://api.github.com/users/kaspermarkus/repos","events_url":"https://api.github.com/users/kaspermarkus/events{/privacy}","received_events_url":"https://api.github.com/users/kaspermarkus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaspermarkus/universal","description":"Cross platform, core components of the GPII personalization infrastructure","fork":true,"url":"https://api.github.com/repos/kaspermarkus/universal","forks_url":"https://api.github.com/repos/kaspermarkus/universal/forks","keys_url":"https://api.github.com/repos/kaspermarkus/universal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaspermarkus/universal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaspermarkus/universal/teams","hooks_url":"https://api.github.com/repos/kaspermarkus/universal/hooks","issue_events_url":"https://api.github.com/repos/kaspermarkus/universal/issues/events{/number}","events_url":"https://api.github.com/repos/kaspermarkus/universal/events","assignees_url":"https://api.github.com/repos/kaspermarkus/universal/assignees{/user}","branches_url":"https://api.github.com/repos/kaspermarkus/universal/branches{/branch}","tags_url":"https://api.github.com/repos/kaspermarkus/universal/tags","blobs_url":"https://api.github.com/repos/kaspermarkus/universal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaspermarkus/universal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaspermarkus/universal/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaspermarkus/universal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaspermarkus/universal/statuses/{sha}","languages_url":"https://api.github.com/repos/kaspermarkus/universal/languages","stargazers_url":"https://api.github.com/repos/kaspermarkus/universal/stargazers","contributors_url":"https://api.github.com/repos/kaspermarkus/universal/contributors","subscribers_url":"https://api.github.com/repos/kaspermarkus/universal/subscribers","subscription_url":"https://api.github.com/repos/kaspermarkus/universal/subscription","commits_url":"https://api.github.com/repos/kaspermarkus/universal/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaspermarkus/universal/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaspermarkus/universal/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaspermarkus/universal/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaspermarkus/universal/contents/{+path}","compare_url":"https://api.github.com/repos/kaspermarkus/universal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaspermarkus/universal/merges","archive_url":"https://api.github.com/repos/kaspermarkus/universal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaspermarkus/universal/downloads","issues_url":"https://api.github.com/repos/kaspermarkus/universal/issues{/number}","pulls_url":"https://api.github.com/repos/kaspermarkus/universal/pulls{/number}","milestones_url":"https://api.github.com/repos/kaspermarkus/universal/milestones{/number}","notifications_url":"https://api.github.com/repos/kaspermarkus/universal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaspermarkus/universal/labels{/name}","releases_url":"https://api.github.com/repos/kaspermarkus/universal/releases{/id}","created_at":"2012-03-05T19:15:52Z","updated_at":"2015-04-15T09:45:40Z","pushed_at":"2015-09-30T10:41:27Z","git_url":"git://github.com/kaspermarkus/universal.git","ssh_url":"git@github.com:kaspermarkus/universal.git","clone_url":"https://github.com/kaspermarkus/universal.git","svn_url":"https://github.com/kaspermarkus/universal","homepage":"gpii.net","size":6425,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"AndreasStiegler:master","ref":"master","sha":"e6e937efdfb846d1998e26b4855c03faf8410071","user":{"login":"AndreasStiegler","id":6213023,"avatar_url":"https://avatars.githubusercontent.com/u/6213023?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasStiegler","html_url":"https://github.com/AndreasStiegler","followers_url":"https://api.github.com/users/AndreasStiegler/followers","following_url":"https://api.github.com/users/AndreasStiegler/following{/other_user}","gists_url":"https://api.github.com/users/AndreasStiegler/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasStiegler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasStiegler/subscriptions","organizations_url":"https://api.github.com/users/AndreasStiegler/orgs","repos_url":"https://api.github.com/users/AndreasStiegler/repos","events_url":"https://api.github.com/users/AndreasStiegler/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasStiegler/received_events","type":"User","site_admin":false},"repo":{"id":27770040,"name":"universal","full_name":"AndreasStiegler/universal","owner":{"login":"AndreasStiegler","id":6213023,"avatar_url":"https://avatars.githubusercontent.com/u/6213023?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasStiegler","html_url":"https://github.com/AndreasStiegler","followers_url":"https://api.github.com/users/AndreasStiegler/followers","following_url":"https://api.github.com/users/AndreasStiegler/following{/other_user}","gists_url":"https://api.github.com/users/AndreasStiegler/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasStiegler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasStiegler/subscriptions","organizations_url":"https://api.github.com/users/AndreasStiegler/orgs","repos_url":"https://api.github.com/users/AndreasStiegler/repos","events_url":"https://api.github.com/users/AndreasStiegler/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasStiegler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndreasStiegler/universal","description":"Cross platform, core components of the GPII personalization infrastructure","fork":true,"url":"https://api.github.com/repos/AndreasStiegler/universal","forks_url":"https://api.github.com/repos/AndreasStiegler/universal/forks","keys_url":"https://api.github.com/repos/AndreasStiegler/universal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndreasStiegler/universal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndreasStiegler/universal/teams","hooks_url":"https://api.github.com/repos/AndreasStiegler/universal/hooks","issue_events_url":"https://api.github.com/repos/AndreasStiegler/universal/issues/events{/number}","events_url":"https://api.github.com/repos/AndreasStiegler/universal/events","assignees_url":"https://api.github.com/repos/AndreasStiegler/universal/assignees{/user}","branches_url":"https://api.github.com/repos/AndreasStiegler/universal/branches{/branch}","tags_url":"https://api.github.com/repos/AndreasStiegler/universal/tags","blobs_url":"https://api.github.com/repos/AndreasStiegler/universal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndreasStiegler/universal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndreasStiegler/universal/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndreasStiegler/universal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndreasStiegler/universal/statuses/{sha}","languages_url":"https://api.github.com/repos/AndreasStiegler/universal/languages","stargazers_url":"https://api.github.com/repos/AndreasStiegler/universal/stargazers","contributors_url":"https://api.github.com/repos/AndreasStiegler/universal/contributors","subscribers_url":"https://api.github.com/repos/AndreasStiegler/universal/subscribers","subscription_url":"https://api.github.com/repos/AndreasStiegler/universal/subscription","commits_url":"https://api.github.com/repos/AndreasStiegler/universal/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndreasStiegler/universal/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndreasStiegler/universal/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndreasStiegler/universal/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndreasStiegler/universal/contents/{+path}","compare_url":"https://api.github.com/repos/AndreasStiegler/universal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndreasStiegler/universal/merges","archive_url":"https://api.github.com/repos/AndreasStiegler/universal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndreasStiegler/universal/downloads","issues_url":"https://api.github.com/repos/AndreasStiegler/universal/issues{/number}","pulls_url":"https://api.github.com/repos/AndreasStiegler/universal/pulls{/number}","milestones_url":"https://api.github.com/repos/AndreasStiegler/universal/milestones{/number}","notifications_url":"https://api.github.com/repos/AndreasStiegler/universal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndreasStiegler/universal/labels{/name}","releases_url":"https://api.github.com/repos/AndreasStiegler/universal/releases{/id}","created_at":"2014-12-09T14:22:23Z","updated_at":"2014-12-10T13:46:19Z","pushed_at":"2015-09-30T11:58:30Z","git_url":"git://github.com/AndreasStiegler/universal.git","ssh_url":"git@github.com:AndreasStiegler/universal.git","clone_url":"https://github.com/AndreasStiegler/universal.git","svn_url":"https://github.com/AndreasStiegler/universal","homepage":"gpii.net","size":3344,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AndreasStiegler/universal/pulls/2"},"html":{"href":"https://github.com/AndreasStiegler/universal/pull/2"},"issue":{"href":"https://api.github.com/repos/AndreasStiegler/universal/issues/2"},"comments":{"href":"https://api.github.com/repos/AndreasStiegler/universal/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/AndreasStiegler/universal/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/AndreasStiegler/universal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AndreasStiegler/universal/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/AndreasStiegler/universal/statuses/531651b2d005084320e436c428238a4bab2e4b1c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"AndreasStiegler","id":6213023,"avatar_url":"https://avatars.githubusercontent.com/u/6213023?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasStiegler","html_url":"https://github.com/AndreasStiegler","followers_url":"https://api.github.com/users/AndreasStiegler/followers","following_url":"https://api.github.com/users/AndreasStiegler/following{/other_user}","gists_url":"https://api.github.com/users/AndreasStiegler/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasStiegler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasStiegler/subscriptions","organizations_url":"https://api.github.com/users/AndreasStiegler/orgs","repos_url":"https://api.github.com/users/AndreasStiegler/repos","events_url":"https://api.github.com/users/AndreasStiegler/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasStiegler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":556,"additions":26269,"deletions":2910,"changed_files":385}}