{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/41093348","id":41093348,"diff_hunk":"@@ -83,6 +84,37 @@ class PadSettingCheckBox : public PadSetting\n \tControllerEmu::ControlGroup::Setting* const setting;\n };\n \n+class InputEventFilter : public wxEventFilter\n+{\n+public:\n+\tInputEventFilter()\n+\t{\n+\t\twxEvtHandler::AddFilter(this);\n+\t}\n+\n+\t~InputEventFilter()\n+\t{\n+\t\twxEvtHandler::RemoveFilter(this);\n+\t}\n+\n+\tint FilterEvent(wxEvent& event) override;\n+\n+\tvoid BlockEvents(bool block) { m_block = block; }\n+\n+private:\n+\tstatic bool ShouldCatchEventType(wxEventType type)\n+\t{\n+\t\t// Can't use a switch... \"expression must have a constant value\"","path":"Source/Core/DolphinWX/InputConfigDiag.h","position":32,"original_position":32,"commit_id":"92003fa2b6c9870bfe1ec89a44c5dfcd0123583f","original_commit_id":"92003fa2b6c9870bfe1ec89a44c5dfcd0123583f","user":{"login":"shuffle2","id":113063,"avatar_url":"https://avatars.githubusercontent.com/u/113063?v=3","gravatar_id":"","url":"https://api.github.com/users/shuffle2","html_url":"https://github.com/shuffle2","followers_url":"https://api.github.com/users/shuffle2/followers","following_url":"https://api.github.com/users/shuffle2/following{/other_user}","gists_url":"https://api.github.com/users/shuffle2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuffle2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuffle2/subscriptions","organizations_url":"https://api.github.com/users/shuffle2/orgs","repos_url":"https://api.github.com/users/shuffle2/repos","events_url":"https://api.github.com/users/shuffle2/events{/privacy}","received_events_url":"https://api.github.com/users/shuffle2/received_events","type":"User","site_admin":false},"body":"This comment suggests you've tried to do something strange, and it didn't work. Doesn't need a comment.","created_at":"2015-10-04T01:12:04Z","updated_at":"2015-10-04T01:12:04Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/3068#discussion_r41093348","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3068","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/41093348"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3068#discussion_r41093348"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3068"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3068","id":45488177,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3068","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3068.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3068.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3068","number":3068,"state":"open","locked":false,"title":"Block WX input when detecting controls","user":{"login":"mickdermack","id":888970,"avatar_url":"https://avatars.githubusercontent.com/u/888970?v=3","gravatar_id":"","url":"https://api.github.com/users/mickdermack","html_url":"https://github.com/mickdermack","followers_url":"https://api.github.com/users/mickdermack/followers","following_url":"https://api.github.com/users/mickdermack/following{/other_user}","gists_url":"https://api.github.com/users/mickdermack/gists{/gist_id}","starred_url":"https://api.github.com/users/mickdermack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickdermack/subscriptions","organizations_url":"https://api.github.com/users/mickdermack/orgs","repos_url":"https://api.github.com/users/mickdermack/repos","events_url":"https://api.github.com/users/mickdermack/events{/privacy}","received_events_url":"https://api.github.com/users/mickdermack/received_events","type":"User","site_admin":false},"body":"This, to some extent, prevents operating the WX GUI when detecting controls, so binding Escape doesn't close the window, Space doesn't press the current button again, etc.","created_at":"2015-09-20T02:05:04Z","updated_at":"2015-10-04T01:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce600306a75a3be335600de9265f5c712bbc140e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3068/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3068/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3068/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/92003fa2b6c9870bfe1ec89a44c5dfcd0123583f","head":{"label":"mickdermack:pr-block-input","ref":"pr-block-input","sha":"92003fa2b6c9870bfe1ec89a44c5dfcd0123583f","user":{"login":"mickdermack","id":888970,"avatar_url":"https://avatars.githubusercontent.com/u/888970?v=3","gravatar_id":"","url":"https://api.github.com/users/mickdermack","html_url":"https://github.com/mickdermack","followers_url":"https://api.github.com/users/mickdermack/followers","following_url":"https://api.github.com/users/mickdermack/following{/other_user}","gists_url":"https://api.github.com/users/mickdermack/gists{/gist_id}","starred_url":"https://api.github.com/users/mickdermack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickdermack/subscriptions","organizations_url":"https://api.github.com/users/mickdermack/orgs","repos_url":"https://api.github.com/users/mickdermack/repos","events_url":"https://api.github.com/users/mickdermack/events{/privacy}","received_events_url":"https://api.github.com/users/mickdermack/received_events","type":"User","site_admin":false},"repo":{"id":31479492,"name":"dolphin","full_name":"mickdermack/dolphin","owner":{"login":"mickdermack","id":888970,"avatar_url":"https://avatars.githubusercontent.com/u/888970?v=3","gravatar_id":"","url":"https://api.github.com/users/mickdermack","html_url":"https://github.com/mickdermack","followers_url":"https://api.github.com/users/mickdermack/followers","following_url":"https://api.github.com/users/mickdermack/following{/other_user}","gists_url":"https://api.github.com/users/mickdermack/gists{/gist_id}","starred_url":"https://api.github.com/users/mickdermack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickdermack/subscriptions","organizations_url":"https://api.github.com/users/mickdermack/orgs","repos_url":"https://api.github.com/users/mickdermack/repos","events_url":"https://api.github.com/users/mickdermack/events{/privacy}","received_events_url":"https://api.github.com/users/mickdermack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mickdermack/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/mickdermack/dolphin","forks_url":"https://api.github.com/repos/mickdermack/dolphin/forks","keys_url":"https://api.github.com/repos/mickdermack/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mickdermack/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mickdermack/dolphin/teams","hooks_url":"https://api.github.com/repos/mickdermack/dolphin/hooks","issue_events_url":"https://api.github.com/repos/mickdermack/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/mickdermack/dolphin/events","assignees_url":"https://api.github.com/repos/mickdermack/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/mickdermack/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/mickdermack/dolphin/tags","blobs_url":"https://api.github.com/repos/mickdermack/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mickdermack/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mickdermack/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mickdermack/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mickdermack/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/mickdermack/dolphin/languages","stargazers_url":"https://api.github.com/repos/mickdermack/dolphin/stargazers","contributors_url":"https://api.github.com/repos/mickdermack/dolphin/contributors","subscribers_url":"https://api.github.com/repos/mickdermack/dolphin/subscribers","subscription_url":"https://api.github.com/repos/mickdermack/dolphin/subscription","commits_url":"https://api.github.com/repos/mickdermack/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mickdermack/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mickdermack/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mickdermack/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mickdermack/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/mickdermack/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mickdermack/dolphin/merges","archive_url":"https://api.github.com/repos/mickdermack/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mickdermack/dolphin/downloads","issues_url":"https://api.github.com/repos/mickdermack/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/mickdermack/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/mickdermack/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/mickdermack/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mickdermack/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/mickdermack/dolphin/releases{/id}","created_at":"2015-02-28T22:48:12Z","updated_at":"2015-04-03T16:43:51Z","pushed_at":"2015-09-20T02:25:45Z","git_url":"git://github.com/mickdermack/dolphin.git","ssh_url":"git@github.com:mickdermack/dolphin.git","clone_url":"https://github.com/mickdermack/dolphin.git","svn_url":"https://github.com/mickdermack/dolphin","homepage":"https://dolphin-emu.org/","size":224967,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"63c373c843a6f1b0e5e0cd3a8cd6f7649cfdac7e","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-10-03T22:27:40Z","pushed_at":"2015-10-04T01:10:24Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":310933,"stargazers_count":1692,"watchers_count":1692,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":524,"mirror_url":null,"open_issues_count":78,"forks":524,"open_issues":78,"watchers":1692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3068"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3068"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3068"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3068/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3068/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3068/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/92003fa2b6c9870bfe1ec89a44c5dfcd0123583f"}}}}