{"action":"created","comment":{"url":"https://api.github.com/repos/vr-components/vr-markup/pulls/comments/38044992","id":38044992,"diff_hunk":"@@ -0,0 +1,63 @@\n+/* globals define */\n+(function(define){'use strict';define(function(require,exports,module){\n+\n+  document.registerElement(\n+    'vr-video',\n+    {\n+      prototype: Object.create(\n+        VRObject.prototype, {\n+          init: {\n+            value: function() {\n+              var material = this.getMaterial();\n+              var geometry = this.getGeometry();\n+              this.object3D = new THREE.Mesh(geometry, material);\n+              this.load();\n+            }\n+          },\n+\n+          update: {\n+            value: function() {\n+              var material = this.getMaterial();\n+              var geometry = this.getGeometry();\n+              this.object3D = new THREE.Mesh(geometry, material);\n+              this.object3D.material = material;\n+            }\n+          },\n+\n+          getGeometry: {\n+            value: function() {\n+              var width = parseFloat(this.getAttribute('width')) || 50;\n+              var height = parseFloat(this.getAttribute('height')) || 50;\n+              return new THREE.PlaneGeometry(width, height, 1, 1);\n+            }\n+          },\n+\n+          getMaterial: {\n+            value: function() {\n+              var video = document.createElement('video');\n+              video.crossOrigin = 'anonymous';\n+              video.src = this.getAttribute('src');;\n+              video.autoplay = this.hasAttribute('autoplay');\n+              video.loop = this.hasAttribute('loop');","path":"components/vr-video.js","position":41,"original_position":41,"commit_id":"0f2acdcd5017f63c6bf54a29e7f69792341e52c1","original_commit_id":"0f2acdcd5017f63c6bf54a29e7f69792341e52c1","user":{"login":"nickdesaulniers","id":1823839,"avatar_url":"https://avatars.githubusercontent.com/u/1823839?v=3","gravatar_id":"","url":"https://api.github.com/users/nickdesaulniers","html_url":"https://github.com/nickdesaulniers","followers_url":"https://api.github.com/users/nickdesaulniers/followers","following_url":"https://api.github.com/users/nickdesaulniers/following{/other_user}","gists_url":"https://api.github.com/users/nickdesaulniers/gists{/gist_id}","starred_url":"https://api.github.com/users/nickdesaulniers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickdesaulniers/subscriptions","organizations_url":"https://api.github.com/users/nickdesaulniers/orgs","repos_url":"https://api.github.com/users/nickdesaulniers/repos","events_url":"https://api.github.com/users/nickdesaulniers/events{/privacy}","received_events_url":"https://api.github.com/users/nickdesaulniers/received_events","type":"User","site_admin":false},"body":"for binary attributes, it might be better to check hasAttribute *and* that getAttribute is not explicitly `false`","created_at":"2015-08-26T22:50:47Z","updated_at":"2015-08-26T22:50:47Z","html_url":"https://github.com/vr-components/vr-markup/pull/17#discussion_r38044992","pull_request_url":"https://api.github.com/repos/vr-components/vr-markup/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/vr-components/vr-markup/pulls/comments/38044992"},"html":{"href":"https://github.com/vr-components/vr-markup/pull/17#discussion_r38044992"},"pull_request":{"href":"https://api.github.com/repos/vr-components/vr-markup/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/vr-components/vr-markup/pulls/17","id":43461084,"html_url":"https://github.com/vr-components/vr-markup/pull/17","diff_url":"https://github.com/vr-components/vr-markup/pull/17.diff","patch_url":"https://github.com/vr-components/vr-markup/pull/17.patch","issue_url":"https://api.github.com/repos/vr-components/vr-markup/issues/17","number":17,"state":"open","locked":false,"title":"add video component fixes #13","user":{"login":"nickdesaulniers","id":1823839,"avatar_url":"https://avatars.githubusercontent.com/u/1823839?v=3","gravatar_id":"","url":"https://api.github.com/users/nickdesaulniers","html_url":"https://github.com/nickdesaulniers","followers_url":"https://api.github.com/users/nickdesaulniers/followers","following_url":"https://api.github.com/users/nickdesaulniers/following{/other_user}","gists_url":"https://api.github.com/users/nickdesaulniers/gists{/gist_id}","starred_url":"https://api.github.com/users/nickdesaulniers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickdesaulniers/subscriptions","organizations_url":"https://api.github.com/users/nickdesaulniers/orgs","repos_url":"https://api.github.com/users/nickdesaulniers/repos","events_url":"https://api.github.com/users/nickdesaulniers/events{/privacy}","received_events_url":"https://api.github.com/users/nickdesaulniers/received_events","type":"User","site_admin":false},"body":"review? @dmarcos ","created_at":"2015-08-26T22:44:19Z","updated_at":"2015-08-26T22:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa7bfaa771618820627d0ba78386507e846f58c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vr-components/vr-markup/pulls/17/commits","review_comments_url":"https://api.github.com/repos/vr-components/vr-markup/pulls/17/comments","review_comment_url":"https://api.github.com/repos/vr-components/vr-markup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vr-components/vr-markup/issues/17/comments","statuses_url":"https://api.github.com/repos/vr-components/vr-markup/statuses/0f2acdcd5017f63c6bf54a29e7f69792341e52c1","head":{"label":"nickdesaulniers:videoComponent","ref":"videoComponent","sha":"0f2acdcd5017f63c6bf54a29e7f69792341e52c1","user":{"login":"nickdesaulniers","id":1823839,"avatar_url":"https://avatars.githubusercontent.com/u/1823839?v=3","gravatar_id":"","url":"https://api.github.com/users/nickdesaulniers","html_url":"https://github.com/nickdesaulniers","followers_url":"https://api.github.com/users/nickdesaulniers/followers","following_url":"https://api.github.com/users/nickdesaulniers/following{/other_user}","gists_url":"https://api.github.com/users/nickdesaulniers/gists{/gist_id}","starred_url":"https://api.github.com/users/nickdesaulniers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickdesaulniers/subscriptions","organizations_url":"https://api.github.com/users/nickdesaulniers/orgs","repos_url":"https://api.github.com/users/nickdesaulniers/repos","events_url":"https://api.github.com/users/nickdesaulniers/events{/privacy}","received_events_url":"https://api.github.com/users/nickdesaulniers/received_events","type":"User","site_admin":false},"repo":{"id":41451642,"name":"vr-markup","full_name":"nickdesaulniers/vr-markup","owner":{"login":"nickdesaulniers","id":1823839,"avatar_url":"https://avatars.githubusercontent.com/u/1823839?v=3","gravatar_id":"","url":"https://api.github.com/users/nickdesaulniers","html_url":"https://github.com/nickdesaulniers","followers_url":"https://api.github.com/users/nickdesaulniers/followers","following_url":"https://api.github.com/users/nickdesaulniers/following{/other_user}","gists_url":"https://api.github.com/users/nickdesaulniers/gists{/gist_id}","starred_url":"https://api.github.com/users/nickdesaulniers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickdesaulniers/subscriptions","organizations_url":"https://api.github.com/users/nickdesaulniers/orgs","repos_url":"https://api.github.com/users/nickdesaulniers/repos","events_url":"https://api.github.com/users/nickdesaulniers/events{/privacy}","received_events_url":"https://api.github.com/users/nickdesaulniers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickdesaulniers/vr-markup","description":"Markup to construct 3d scenes in declarative fashion","fork":true,"url":"https://api.github.com/repos/nickdesaulniers/vr-markup","forks_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/forks","keys_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/teams","hooks_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/hooks","issue_events_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/issues/events{/number}","events_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/events","assignees_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/assignees{/user}","branches_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/branches{/branch}","tags_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/tags","blobs_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/statuses/{sha}","languages_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/languages","stargazers_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/stargazers","contributors_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/contributors","subscribers_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/subscribers","subscription_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/subscription","commits_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/contents/{+path}","compare_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/merges","archive_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/downloads","issues_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/issues{/number}","pulls_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/pulls{/number}","milestones_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/milestones{/number}","notifications_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/labels{/name}","releases_url":"https://api.github.com/repos/nickdesaulniers/vr-markup/releases{/id}","created_at":"2015-08-26T21:50:32Z","updated_at":"2015-08-26T21:50:33Z","pushed_at":"2015-08-26T22:43:55Z","git_url":"git://github.com/nickdesaulniers/vr-markup.git","ssh_url":"git@github.com:nickdesaulniers/vr-markup.git","clone_url":"https://github.com/nickdesaulniers/vr-markup.git","svn_url":"https://github.com/nickdesaulniers/vr-markup","homepage":null,"size":24633,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vr-components:master","ref":"master","sha":"731f35e88d0128005f26f22398ba82f9882191a1","user":{"login":"vr-components","id":8933716,"avatar_url":"https://avatars.githubusercontent.com/u/8933716?v=3","gravatar_id":"","url":"https://api.github.com/users/vr-components","html_url":"https://github.com/vr-components","followers_url":"https://api.github.com/users/vr-components/followers","following_url":"https://api.github.com/users/vr-components/following{/other_user}","gists_url":"https://api.github.com/users/vr-components/gists{/gist_id}","starred_url":"https://api.github.com/users/vr-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vr-components/subscriptions","organizations_url":"https://api.github.com/users/vr-components/orgs","repos_url":"https://api.github.com/users/vr-components/repos","events_url":"https://api.github.com/users/vr-components/events{/privacy}","received_events_url":"https://api.github.com/users/vr-components/received_events","type":"Organization","site_admin":false},"repo":{"id":41116814,"name":"vr-markup","full_name":"vr-components/vr-markup","owner":{"login":"vr-components","id":8933716,"avatar_url":"https://avatars.githubusercontent.com/u/8933716?v=3","gravatar_id":"","url":"https://api.github.com/users/vr-components","html_url":"https://github.com/vr-components","followers_url":"https://api.github.com/users/vr-components/followers","following_url":"https://api.github.com/users/vr-components/following{/other_user}","gists_url":"https://api.github.com/users/vr-components/gists{/gist_id}","starred_url":"https://api.github.com/users/vr-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vr-components/subscriptions","organizations_url":"https://api.github.com/users/vr-components/orgs","repos_url":"https://api.github.com/users/vr-components/repos","events_url":"https://api.github.com/users/vr-components/events{/privacy}","received_events_url":"https://api.github.com/users/vr-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vr-components/vr-markup","description":"Markup to construct 3d scenes in declarative fashion","fork":false,"url":"https://api.github.com/repos/vr-components/vr-markup","forks_url":"https://api.github.com/repos/vr-components/vr-markup/forks","keys_url":"https://api.github.com/repos/vr-components/vr-markup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vr-components/vr-markup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vr-components/vr-markup/teams","hooks_url":"https://api.github.com/repos/vr-components/vr-markup/hooks","issue_events_url":"https://api.github.com/repos/vr-components/vr-markup/issues/events{/number}","events_url":"https://api.github.com/repos/vr-components/vr-markup/events","assignees_url":"https://api.github.com/repos/vr-components/vr-markup/assignees{/user}","branches_url":"https://api.github.com/repos/vr-components/vr-markup/branches{/branch}","tags_url":"https://api.github.com/repos/vr-components/vr-markup/tags","blobs_url":"https://api.github.com/repos/vr-components/vr-markup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vr-components/vr-markup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vr-components/vr-markup/git/refs{/sha}","trees_url":"https://api.github.com/repos/vr-components/vr-markup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vr-components/vr-markup/statuses/{sha}","languages_url":"https://api.github.com/repos/vr-components/vr-markup/languages","stargazers_url":"https://api.github.com/repos/vr-components/vr-markup/stargazers","contributors_url":"https://api.github.com/repos/vr-components/vr-markup/contributors","subscribers_url":"https://api.github.com/repos/vr-components/vr-markup/subscribers","subscription_url":"https://api.github.com/repos/vr-components/vr-markup/subscription","commits_url":"https://api.github.com/repos/vr-components/vr-markup/commits{/sha}","git_commits_url":"https://api.github.com/repos/vr-components/vr-markup/git/commits{/sha}","comments_url":"https://api.github.com/repos/vr-components/vr-markup/comments{/number}","issue_comment_url":"https://api.github.com/repos/vr-components/vr-markup/issues/comments{/number}","contents_url":"https://api.github.com/repos/vr-components/vr-markup/contents/{+path}","compare_url":"https://api.github.com/repos/vr-components/vr-markup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vr-components/vr-markup/merges","archive_url":"https://api.github.com/repos/vr-components/vr-markup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vr-components/vr-markup/downloads","issues_url":"https://api.github.com/repos/vr-components/vr-markup/issues{/number}","pulls_url":"https://api.github.com/repos/vr-components/vr-markup/pulls{/number}","milestones_url":"https://api.github.com/repos/vr-components/vr-markup/milestones{/number}","notifications_url":"https://api.github.com/repos/vr-components/vr-markup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vr-components/vr-markup/labels{/name}","releases_url":"https://api.github.com/repos/vr-components/vr-markup/releases{/id}","created_at":"2015-08-20T20:14:13Z","updated_at":"2015-08-25T20:05:31Z","pushed_at":"2015-08-26T22:44:21Z","git_url":"git://github.com/vr-components/vr-markup.git","ssh_url":"git@github.com:vr-components/vr-markup.git","clone_url":"https://github.com/vr-components/vr-markup.git","svn_url":"https://github.com/vr-components/vr-markup","homepage":null,"size":24633,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":18,"forks":2,"open_issues":18,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vr-components/vr-markup/pulls/17"},"html":{"href":"https://github.com/vr-components/vr-markup/pull/17"},"issue":{"href":"https://api.github.com/repos/vr-components/vr-markup/issues/17"},"comments":{"href":"https://api.github.com/repos/vr-components/vr-markup/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/vr-components/vr-markup/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/vr-components/vr-markup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vr-components/vr-markup/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/vr-components/vr-markup/statuses/0f2acdcd5017f63c6bf54a29e7f69792341e52c1"}}}}