{"action":"created","comment":{"url":"https://api.github.com/repos/bcoe/nyc/pulls/comments/46240509","id":46240509,"diff_hunk":"@@ -65,6 +64,24 @@ NYC.prototype._createInstrumenter = function () {\n   })\n }\n \n+NYC.prototype._prepExcludePatterns = function (excludes) {\n+  var directories = []\n+  excludes = _.map(excludes, function (exclude) {\n+    // Remove leading \"current folder\" prefix","path":"index.js","position":29,"original_position":29,"commit_id":"37fe5cc4332a205368fdad8cf3598aec0bc916df","original_commit_id":"37fe5cc4332a205368fdad8cf3598aec0bc916df","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"body":"Why is this needed? Pretty sure `glob` handles this fine.","created_at":"2015-12-01T05:01:31Z","updated_at":"2015-12-01T05:01:31Z","html_url":"https://github.com/bcoe/nyc/pull/60#discussion_r46240509","pull_request_url":"https://api.github.com/repos/bcoe/nyc/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/bcoe/nyc/pulls/comments/46240509"},"html":{"href":"https://github.com/bcoe/nyc/pull/60#discussion_r46240509"},"pull_request":{"href":"https://api.github.com/repos/bcoe/nyc/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/bcoe/nyc/pulls/60","id":52072422,"html_url":"https://github.com/bcoe/nyc/pull/60","diff_url":"https://github.com/bcoe/nyc/pull/60.diff","patch_url":"https://github.com/bcoe/nyc/pull/60.patch","issue_url":"https://api.github.com/repos/bcoe/nyc/issues/60","number":60,"state":"open","locked":false,"title":"Exclusion improvements","user":{"login":"Lalem001","id":1933700,"avatar_url":"https://avatars.githubusercontent.com/u/1933700?v=3","gravatar_id":"","url":"https://api.github.com/users/Lalem001","html_url":"https://github.com/Lalem001","followers_url":"https://api.github.com/users/Lalem001/followers","following_url":"https://api.github.com/users/Lalem001/following{/other_user}","gists_url":"https://api.github.com/users/Lalem001/gists{/gist_id}","starred_url":"https://api.github.com/users/Lalem001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lalem001/subscriptions","organizations_url":"https://api.github.com/users/Lalem001/orgs","repos_url":"https://api.github.com/users/Lalem001/repos","events_url":"https://api.github.com/users/Lalem001/events{/privacy}","received_events_url":"https://api.github.com/users/Lalem001/received_events","type":"User","site_admin":false},"body":"An attempt at improving file exclusion.\r\n\r\nThe biggest improvement appears when using the `--all` flag.\r\n\r\nChanges:\r\n- Always exclude `node_modules`\r\n- Exclude using glob/minimatch patterns instead of RegExp (breaking change)\r\n- addAllFiles now excludes during glob.sync, significantly improving performance\r\n\r\nResolves:\r\n- #56: Exclude now uses glob patterns via minimatch\r\n\r\nComplicates:\r\n- #50: node_modules are now always excluded\r\n\r\nFeel free to question my changes/decisions. I am open to compromise if necessary.","created_at":"2015-11-29T22:09:25Z","updated_at":"2015-12-01T05:01:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcbacf08d393d49505145fec8598eca129613b68","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bcoe/nyc/pulls/60/commits","review_comments_url":"https://api.github.com/repos/bcoe/nyc/pulls/60/comments","review_comment_url":"https://api.github.com/repos/bcoe/nyc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bcoe/nyc/issues/60/comments","statuses_url":"https://api.github.com/repos/bcoe/nyc/statuses/37fe5cc4332a205368fdad8cf3598aec0bc916df","head":{"label":"Lalem001:improve-exclude","ref":"improve-exclude","sha":"37fe5cc4332a205368fdad8cf3598aec0bc916df","user":{"login":"Lalem001","id":1933700,"avatar_url":"https://avatars.githubusercontent.com/u/1933700?v=3","gravatar_id":"","url":"https://api.github.com/users/Lalem001","html_url":"https://github.com/Lalem001","followers_url":"https://api.github.com/users/Lalem001/followers","following_url":"https://api.github.com/users/Lalem001/following{/other_user}","gists_url":"https://api.github.com/users/Lalem001/gists{/gist_id}","starred_url":"https://api.github.com/users/Lalem001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lalem001/subscriptions","organizations_url":"https://api.github.com/users/Lalem001/orgs","repos_url":"https://api.github.com/users/Lalem001/repos","events_url":"https://api.github.com/users/Lalem001/events{/privacy}","received_events_url":"https://api.github.com/users/Lalem001/received_events","type":"User","site_admin":false},"repo":{"id":46992643,"name":"nyc","full_name":"Lalem001/nyc","owner":{"login":"Lalem001","id":1933700,"avatar_url":"https://avatars.githubusercontent.com/u/1933700?v=3","gravatar_id":"","url":"https://api.github.com/users/Lalem001","html_url":"https://github.com/Lalem001","followers_url":"https://api.github.com/users/Lalem001/followers","following_url":"https://api.github.com/users/Lalem001/following{/other_user}","gists_url":"https://api.github.com/users/Lalem001/gists{/gist_id}","starred_url":"https://api.github.com/users/Lalem001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lalem001/subscriptions","organizations_url":"https://api.github.com/users/Lalem001/orgs","repos_url":"https://api.github.com/users/Lalem001/repos","events_url":"https://api.github.com/users/Lalem001/events{/privacy}","received_events_url":"https://api.github.com/users/Lalem001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lalem001/nyc","description":"a code coverage tool that works well with subprocesses.","fork":true,"url":"https://api.github.com/repos/Lalem001/nyc","forks_url":"https://api.github.com/repos/Lalem001/nyc/forks","keys_url":"https://api.github.com/repos/Lalem001/nyc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lalem001/nyc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lalem001/nyc/teams","hooks_url":"https://api.github.com/repos/Lalem001/nyc/hooks","issue_events_url":"https://api.github.com/repos/Lalem001/nyc/issues/events{/number}","events_url":"https://api.github.com/repos/Lalem001/nyc/events","assignees_url":"https://api.github.com/repos/Lalem001/nyc/assignees{/user}","branches_url":"https://api.github.com/repos/Lalem001/nyc/branches{/branch}","tags_url":"https://api.github.com/repos/Lalem001/nyc/tags","blobs_url":"https://api.github.com/repos/Lalem001/nyc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lalem001/nyc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lalem001/nyc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lalem001/nyc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lalem001/nyc/statuses/{sha}","languages_url":"https://api.github.com/repos/Lalem001/nyc/languages","stargazers_url":"https://api.github.com/repos/Lalem001/nyc/stargazers","contributors_url":"https://api.github.com/repos/Lalem001/nyc/contributors","subscribers_url":"https://api.github.com/repos/Lalem001/nyc/subscribers","subscription_url":"https://api.github.com/repos/Lalem001/nyc/subscription","commits_url":"https://api.github.com/repos/Lalem001/nyc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lalem001/nyc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lalem001/nyc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lalem001/nyc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lalem001/nyc/contents/{+path}","compare_url":"https://api.github.com/repos/Lalem001/nyc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lalem001/nyc/merges","archive_url":"https://api.github.com/repos/Lalem001/nyc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lalem001/nyc/downloads","issues_url":"https://api.github.com/repos/Lalem001/nyc/issues{/number}","pulls_url":"https://api.github.com/repos/Lalem001/nyc/pulls{/number}","milestones_url":"https://api.github.com/repos/Lalem001/nyc/milestones{/number}","notifications_url":"https://api.github.com/repos/Lalem001/nyc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lalem001/nyc/labels{/name}","releases_url":"https://api.github.com/repos/Lalem001/nyc/releases{/id}","created_at":"2015-11-27T17:39:47Z","updated_at":"2015-11-27T17:39:48Z","pushed_at":"2015-11-30T18:20:35Z","git_url":"git://github.com/Lalem001/nyc.git","ssh_url":"git@github.com:Lalem001/nyc.git","clone_url":"https://github.com/Lalem001/nyc.git","svn_url":"https://github.com/Lalem001/nyc","homepage":"","size":311,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bcoe:master","ref":"master","sha":"efacafa5e51ae4a4aa6ba83fb764de20aa6651d1","user":{"login":"bcoe","id":194609,"avatar_url":"https://avatars.githubusercontent.com/u/194609?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"repo":{"id":35312458,"name":"nyc","full_name":"bcoe/nyc","owner":{"login":"bcoe","id":194609,"avatar_url":"https://avatars.githubusercontent.com/u/194609?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcoe/nyc","description":"a code coverage tool that works well with subprocesses.","fork":false,"url":"https://api.github.com/repos/bcoe/nyc","forks_url":"https://api.github.com/repos/bcoe/nyc/forks","keys_url":"https://api.github.com/repos/bcoe/nyc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcoe/nyc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcoe/nyc/teams","hooks_url":"https://api.github.com/repos/bcoe/nyc/hooks","issue_events_url":"https://api.github.com/repos/bcoe/nyc/issues/events{/number}","events_url":"https://api.github.com/repos/bcoe/nyc/events","assignees_url":"https://api.github.com/repos/bcoe/nyc/assignees{/user}","branches_url":"https://api.github.com/repos/bcoe/nyc/branches{/branch}","tags_url":"https://api.github.com/repos/bcoe/nyc/tags","blobs_url":"https://api.github.com/repos/bcoe/nyc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcoe/nyc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcoe/nyc/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcoe/nyc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcoe/nyc/statuses/{sha}","languages_url":"https://api.github.com/repos/bcoe/nyc/languages","stargazers_url":"https://api.github.com/repos/bcoe/nyc/stargazers","contributors_url":"https://api.github.com/repos/bcoe/nyc/contributors","subscribers_url":"https://api.github.com/repos/bcoe/nyc/subscribers","subscription_url":"https://api.github.com/repos/bcoe/nyc/subscription","commits_url":"https://api.github.com/repos/bcoe/nyc/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcoe/nyc/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcoe/nyc/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcoe/nyc/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcoe/nyc/contents/{+path}","compare_url":"https://api.github.com/repos/bcoe/nyc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcoe/nyc/merges","archive_url":"https://api.github.com/repos/bcoe/nyc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcoe/nyc/downloads","issues_url":"https://api.github.com/repos/bcoe/nyc/issues{/number}","pulls_url":"https://api.github.com/repos/bcoe/nyc/pulls{/number}","milestones_url":"https://api.github.com/repos/bcoe/nyc/milestones{/number}","notifications_url":"https://api.github.com/repos/bcoe/nyc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcoe/nyc/labels{/name}","releases_url":"https://api.github.com/repos/bcoe/nyc/releases{/id}","created_at":"2015-05-09T02:55:45Z","updated_at":"2015-12-01T00:33:07Z","pushed_at":"2015-12-01T04:25:36Z","git_url":"git://github.com/bcoe/nyc.git","ssh_url":"git@github.com:bcoe/nyc.git","clone_url":"https://github.com/bcoe/nyc.git","svn_url":"https://github.com/bcoe/nyc","homepage":"","size":339,"stargazers_count":128,"watchers_count":128,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":13,"forks":12,"open_issues":13,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bcoe/nyc/pulls/60"},"html":{"href":"https://github.com/bcoe/nyc/pull/60"},"issue":{"href":"https://api.github.com/repos/bcoe/nyc/issues/60"},"comments":{"href":"https://api.github.com/repos/bcoe/nyc/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/bcoe/nyc/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/bcoe/nyc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bcoe/nyc/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/bcoe/nyc/statuses/37fe5cc4332a205368fdad8cf3598aec0bc916df"}}}}