{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6693","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6693/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6693/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6693/events","html_url":"https://github.com/bitcoin/bitcoin/pull/6693","id":107138603,"number":6693,"title":"Set Windows TCP buffers to 64KB to match OSX and Unix","user":{"login":"ptschip","id":12862928,"avatar_url":"https://avatars.githubusercontent.com/u/12862928?v=3","gravatar_id":"","url":"https://api.github.com/users/ptschip","html_url":"https://github.com/ptschip","followers_url":"https://api.github.com/users/ptschip/followers","following_url":"https://api.github.com/users/ptschip/following{/other_user}","gists_url":"https://api.github.com/users/ptschip/gists{/gist_id}","starred_url":"https://api.github.com/users/ptschip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptschip/subscriptions","organizations_url":"https://api.github.com/users/ptschip/orgs","repos_url":"https://api.github.com/users/ptschip/repos","events_url":"https://api.github.com/users/ptschip/events{/privacy}","received_events_url":"https://api.github.com/users/ptschip/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/P2P","name":"P2P","color":"006b75"},{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Windows","name":"Windows","color":"880000"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":33,"created_at":"2015-09-18T05:51:38Z","updated_at":"2015-10-14T00:57:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6693","html_url":"https://github.com/bitcoin/bitcoin/pull/6693","diff_url":"https://github.com/bitcoin/bitcoin/pull/6693.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6693.patch"},"body":"After making the changes I ran the wallet.py test (which is where the problem manifested the most often) 100 times without fail on Native Windows.  It was a simple problem of the Windows default buffer size being too small and causing buffer overflow's on occasion when syncing large amounts of data."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/147894623","html_url":"https://github.com/bitcoin/bitcoin/pull/6693#issuecomment-147894623","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6693","id":147894623,"user":{"login":"ptschip","id":12862928,"avatar_url":"https://avatars.githubusercontent.com/u/12862928?v=3","gravatar_id":"","url":"https://api.github.com/users/ptschip","html_url":"https://github.com/ptschip","followers_url":"https://api.github.com/users/ptschip/followers","following_url":"https://api.github.com/users/ptschip/following{/other_user}","gists_url":"https://api.github.com/users/ptschip/gists{/gist_id}","starred_url":"https://api.github.com/users/ptschip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptschip/subscriptions","organizations_url":"https://api.github.com/users/ptschip/orgs","repos_url":"https://api.github.com/users/ptschip/repos","events_url":"https://api.github.com/users/ptschip/events{/privacy}","received_events_url":"https://api.github.com/users/ptschip/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T00:57:01Z","updated_at":"2015-10-14T00:57:01Z","body":"@theuni Cory,  I got around to testing your \"net-lock-hacking\" code and the results are pretty good.\r\n\r\nTested again on a Windows 7 with a wireless high speed connection (not over the internet)...syncing a 600MB blockchain, 3 tests each and average taken.\r\n\r\nCurrent Master Build with 8KB tcp send buffer, 8KB receive buffer:   236 seconds to sync\r\nCory's net lock code with 8KB tcp send buffer and 8KB receive buffer:  194 seconds to sync.\r\n\r\nAlmost an 18% improvement.  Even so, we're still only using about 1/3 of the network bandwidth...there's clearly more improvement possible to increase throughput.  Judging from the logs there is a about 50 seconds of just verifying blocks, not sure much can be done about that, but there should be another 40 or 50 seconds to save somewhere to get bandwidth utilization up to 60 or 70%.\r\n\r\nAnyway, I thought you'd like to know the results...great stuff.\r\n\r\nI'm still looking at the buffersizes and going to run some tests tomorrow.  After your code changes and the low latency of my network I'm not seeing much difference in terms of tcp buffer sizes helping performance. I'm going try test form a  separate internet connection to see what happens when there's more latency on the wire. \r\n\r\n"}}