{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/memberlist/pulls/comments/26597765","id":26597765,"diff_hunk":"@@ -215,10 +215,14 @@ func (m *Memberlist) probeNode(node *nodeState) {\n \n \t// Setup an ack handler\n \tackCh := make(chan bool, m.config.IndirectChecks+1)\n-\tm.setAckChannel(ping.SeqNo, ackCh, m.config.ProbeInterval)\n+\tsent := time.Now()\n+\tm.setAckChannel(ping.SeqNo, ackCh, func(payload []byte) {","path":"state.go","position":15,"original_position":15,"commit_id":"2719185b24fc7e1e67243a16d974b5505f1381cf","original_commit_id":"2719185b24fc7e1e67243a16d974b5505f1381cf","user":{"login":"armon","id":592032,"avatar_url":"https://avatars.githubusercontent.com/u/592032?v=3","gravatar_id":"","url":"https://api.github.com/users/armon","html_url":"https://github.com/armon","followers_url":"https://api.github.com/users/armon/followers","following_url":"https://api.github.com/users/armon/following{/other_user}","gists_url":"https://api.github.com/users/armon/gists{/gist_id}","starred_url":"https://api.github.com/users/armon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armon/subscriptions","organizations_url":"https://api.github.com/users/armon/orgs","repos_url":"https://api.github.com/users/armon/repos","events_url":"https://api.github.com/users/armon/events{/privacy}","received_events_url":"https://api.github.com/users/armon/received_events","type":"User","site_admin":false},"body":"This is a bit dirty and works around the indented use of an ack channel. Lets add a new type `ackResponse` that includes the `Payload` and `Complete` bool, and change the type of the channel to `ackResponse` instead of bool. This way we aren't overloading by injecting a second handler.","created_at":"2015-03-17T17:53:39Z","updated_at":"2015-03-17T17:53:39Z","html_url":"https://github.com/hashicorp/memberlist/pull/33#discussion_r26597765","pull_request_url":"https://api.github.com/repos/hashicorp/memberlist/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/comments/26597765"},"html":{"href":"https://github.com/hashicorp/memberlist/pull/33#discussion_r26597765"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/memberlist/pulls/33","id":31309839,"html_url":"https://github.com/hashicorp/memberlist/pull/33","diff_url":"https://github.com/hashicorp/memberlist/pull/33.diff","patch_url":"https://github.com/hashicorp/memberlist/pull/33.patch","issue_url":"https://api.github.com/repos/hashicorp/memberlist/issues/33","number":33,"state":"open","locked":false,"title":"Change RTTDelegate to PingDelegate","user":{"login":"derekchiang","id":1535686,"avatar_url":"https://avatars.githubusercontent.com/u/1535686?v=3","gravatar_id":"","url":"https://api.github.com/users/derekchiang","html_url":"https://github.com/derekchiang","followers_url":"https://api.github.com/users/derekchiang/followers","following_url":"https://api.github.com/users/derekchiang/following{/other_user}","gists_url":"https://api.github.com/users/derekchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/derekchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekchiang/subscriptions","organizations_url":"https://api.github.com/users/derekchiang/orgs","repos_url":"https://api.github.com/users/derekchiang/repos","events_url":"https://api.github.com/users/derekchiang/events{/privacy}","received_events_url":"https://api.github.com/users/derekchiang/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-17T06:13:32Z","updated_at":"2015-03-17T17:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f81b62e1bc8b6dcf663b12cfecf35ffdf12c8bb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/memberlist/pulls/33/commits","review_comments_url":"https://api.github.com/repos/hashicorp/memberlist/pulls/33/comments","review_comment_url":"https://api.github.com/repos/hashicorp/memberlist/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/memberlist/issues/33/comments","statuses_url":"https://api.github.com/repos/hashicorp/memberlist/statuses/2719185b24fc7e1e67243a16d974b5505f1381cf","head":{"label":"derekchiang:modify-ping-message","ref":"modify-ping-message","sha":"2719185b24fc7e1e67243a16d974b5505f1381cf","user":{"login":"derekchiang","id":1535686,"avatar_url":"https://avatars.githubusercontent.com/u/1535686?v=3","gravatar_id":"","url":"https://api.github.com/users/derekchiang","html_url":"https://github.com/derekchiang","followers_url":"https://api.github.com/users/derekchiang/followers","following_url":"https://api.github.com/users/derekchiang/following{/other_user}","gists_url":"https://api.github.com/users/derekchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/derekchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekchiang/subscriptions","organizations_url":"https://api.github.com/users/derekchiang/orgs","repos_url":"https://api.github.com/users/derekchiang/repos","events_url":"https://api.github.com/users/derekchiang/events{/privacy}","received_events_url":"https://api.github.com/users/derekchiang/received_events","type":"User","site_admin":false},"repo":{"id":32047139,"name":"memberlist","full_name":"derekchiang/memberlist","owner":{"login":"derekchiang","id":1535686,"avatar_url":"https://avatars.githubusercontent.com/u/1535686?v=3","gravatar_id":"","url":"https://api.github.com/users/derekchiang","html_url":"https://github.com/derekchiang","followers_url":"https://api.github.com/users/derekchiang/followers","following_url":"https://api.github.com/users/derekchiang/following{/other_user}","gists_url":"https://api.github.com/users/derekchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/derekchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekchiang/subscriptions","organizations_url":"https://api.github.com/users/derekchiang/orgs","repos_url":"https://api.github.com/users/derekchiang/repos","events_url":"https://api.github.com/users/derekchiang/events{/privacy}","received_events_url":"https://api.github.com/users/derekchiang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derekchiang/memberlist","description":"Golang package for gossip based membership and failure detection","fork":true,"url":"https://api.github.com/repos/derekchiang/memberlist","forks_url":"https://api.github.com/repos/derekchiang/memberlist/forks","keys_url":"https://api.github.com/repos/derekchiang/memberlist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekchiang/memberlist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekchiang/memberlist/teams","hooks_url":"https://api.github.com/repos/derekchiang/memberlist/hooks","issue_events_url":"https://api.github.com/repos/derekchiang/memberlist/issues/events{/number}","events_url":"https://api.github.com/repos/derekchiang/memberlist/events","assignees_url":"https://api.github.com/repos/derekchiang/memberlist/assignees{/user}","branches_url":"https://api.github.com/repos/derekchiang/memberlist/branches{/branch}","tags_url":"https://api.github.com/repos/derekchiang/memberlist/tags","blobs_url":"https://api.github.com/repos/derekchiang/memberlist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekchiang/memberlist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekchiang/memberlist/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekchiang/memberlist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekchiang/memberlist/statuses/{sha}","languages_url":"https://api.github.com/repos/derekchiang/memberlist/languages","stargazers_url":"https://api.github.com/repos/derekchiang/memberlist/stargazers","contributors_url":"https://api.github.com/repos/derekchiang/memberlist/contributors","subscribers_url":"https://api.github.com/repos/derekchiang/memberlist/subscribers","subscription_url":"https://api.github.com/repos/derekchiang/memberlist/subscription","commits_url":"https://api.github.com/repos/derekchiang/memberlist/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekchiang/memberlist/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekchiang/memberlist/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekchiang/memberlist/issues/comments{/number}","contents_url":"https://api.github.com/repos/derekchiang/memberlist/contents/{+path}","compare_url":"https://api.github.com/repos/derekchiang/memberlist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekchiang/memberlist/merges","archive_url":"https://api.github.com/repos/derekchiang/memberlist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekchiang/memberlist/downloads","issues_url":"https://api.github.com/repos/derekchiang/memberlist/issues{/number}","pulls_url":"https://api.github.com/repos/derekchiang/memberlist/pulls{/number}","milestones_url":"https://api.github.com/repos/derekchiang/memberlist/milestones{/number}","notifications_url":"https://api.github.com/repos/derekchiang/memberlist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekchiang/memberlist/labels{/name}","releases_url":"https://api.github.com/repos/derekchiang/memberlist/releases{/id}","created_at":"2015-03-11T23:43:51Z","updated_at":"2015-03-17T06:12:40Z","pushed_at":"2015-03-17T06:13:10Z","git_url":"git://github.com/derekchiang/memberlist.git","ssh_url":"git@github.com:derekchiang/memberlist.git","clone_url":"https://github.com/derekchiang/memberlist.git","svn_url":"https://github.com/derekchiang/memberlist","homepage":null,"size":645,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"b35334350c3a1477a2b3d451c2200abaa0703f00","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":12712630,"name":"memberlist","full_name":"hashicorp/memberlist","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/memberlist","description":"Golang package for gossip based membership and failure detection","fork":false,"url":"https://api.github.com/repos/hashicorp/memberlist","forks_url":"https://api.github.com/repos/hashicorp/memberlist/forks","keys_url":"https://api.github.com/repos/hashicorp/memberlist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/memberlist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/memberlist/teams","hooks_url":"https://api.github.com/repos/hashicorp/memberlist/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/memberlist/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/memberlist/events","assignees_url":"https://api.github.com/repos/hashicorp/memberlist/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/memberlist/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/memberlist/tags","blobs_url":"https://api.github.com/repos/hashicorp/memberlist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/memberlist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/memberlist/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/memberlist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/memberlist/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/memberlist/languages","stargazers_url":"https://api.github.com/repos/hashicorp/memberlist/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/memberlist/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/memberlist/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/memberlist/subscription","commits_url":"https://api.github.com/repos/hashicorp/memberlist/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/memberlist/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/memberlist/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/memberlist/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/memberlist/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/memberlist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/memberlist/merges","archive_url":"https://api.github.com/repos/hashicorp/memberlist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/memberlist/downloads","issues_url":"https://api.github.com/repos/hashicorp/memberlist/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/memberlist/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/memberlist/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/memberlist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/memberlist/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/memberlist/releases{/id}","created_at":"2013-09-09T20:59:27Z","updated_at":"2015-03-16T22:17:22Z","pushed_at":"2015-03-12T20:58:04Z","git_url":"git://github.com/hashicorp/memberlist.git","ssh_url":"git@github.com:hashicorp/memberlist.git","clone_url":"https://github.com/hashicorp/memberlist.git","svn_url":"https://github.com/hashicorp/memberlist","homepage":null,"size":1673,"stargazers_count":209,"watchers_count":209,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":5,"forks":39,"open_issues":5,"watchers":209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/33"},"html":{"href":"https://github.com/hashicorp/memberlist/pull/33"},"issue":{"href":"https://api.github.com/repos/hashicorp/memberlist/issues/33"},"comments":{"href":"https://api.github.com/repos/hashicorp/memberlist/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/memberlist/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/memberlist/statuses/2719185b24fc7e1e67243a16d974b5505f1381cf"}}}}