{"action":"created","issue":{"url":"https://api.github.com/repos/philc/vimium/issues/1653","labels_url":"https://api.github.com/repos/philc/vimium/issues/1653/labels{/name}","comments_url":"https://api.github.com/repos/philc/vimium/issues/1653/comments","events_url":"https://api.github.com/repos/philc/vimium/issues/1653/events","html_url":"https://github.com/philc/vimium/pull/1653","id":75308066,"number":1653,"title":"use shadowDOM for hightlightedFrame only if style is not null","user":{"login":"gdh1995","id":5547703,"avatar_url":"https://avatars.githubusercontent.com/u/5547703?v=3","gravatar_id":"","url":"https://api.github.com/users/gdh1995","html_url":"https://github.com/gdh1995","followers_url":"https://api.github.com/users/gdh1995/followers","following_url":"https://api.github.com/users/gdh1995/following{/other_user}","gists_url":"https://api.github.com/users/gdh1995/gists{/gist_id}","starred_url":"https://api.github.com/users/gdh1995/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdh1995/subscriptions","organizations_url":"https://api.github.com/users/gdh1995/orgs","repos_url":"https://api.github.com/users/gdh1995/repos","events_url":"https://api.github.com/users/gdh1995/events{/privacy}","received_events_url":"https://api.github.com/users/gdh1995/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-11T18:06:30Z","updated_at":"2015-05-11T19:04:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/philc/vimium/pulls/1653","html_url":"https://github.com/philc/vimium/pull/1653","diff_url":"https://github.com/philc/vimium/pull/1653.diff","patch_url":"https://github.com/philc/vimium/pull/1653.patch"},"body":"In a XML document, `_frameEl` should not be in a shadow DOM node, and must have an id.\r\n\r\nOtherwise there will be no selector matched to it, and nothing will show.\r\n\r\nPlease see #1634."},"comment":{"url":"https://api.github.com/repos/philc/vimium/issues/comments/101018361","html_url":"https://github.com/philc/vimium/pull/1653#issuecomment-101018361","issue_url":"https://api.github.com/repos/philc/vimium/issues/1653","id":101018361,"user":{"login":"mrmr1993","id":1847343,"avatar_url":"https://avatars.githubusercontent.com/u/1847343?v=3","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"created_at":"2015-05-11T19:04:21Z","updated_at":"2015-05-11T19:04:21Z","body":"> Um, I think, it should be strong as long as there is it.\r\n\r\nI'm not comfortable setting `id` on elements we create, since `id` is supposed to be unique in the document, and we can't make that guarantee for all pages. But it's ultimately not my decision, and I'm possibly being paranoid.\r\n\r\n> I've seen only one\r\n\r\nThere are no frames on that page. Why would we be concerned about the highlighted border displaying correctly there when it serves no useful purpose?"}}