{"action":"closed","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/4005","labels_url":"https://api.github.com/repos/openshift/origin/issues/4005/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/4005/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/4005/events","html_url":"https://github.com/openshift/origin/issues/4005","id":99189518,"number":4005,"title":"Move extended tests groups into Go packages","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openshift/origin/labels/area/tests","name":"area/tests","color":"006b75"},{"url":"https://api.github.com/repos/openshift/origin/labels/component/internal-tools","name":"component/internal-tools","color":"0052cc"},{"url":"https://api.github.com/repos/openshift/origin/labels/kind/enhancement","name":"kind/enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/openshift/origin/labels/priority/P2","name":"priority/P2","color":"fbca04"}],"state":"closed","locked":false,"assignee":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-08-05T12:06:31Z","updated_at":"2015-08-31T09:20:41Z","closed_at":"2015-08-31T09:20:41Z","body":"Currently our schema for extended tests groups is following:\r\n\r\n```\r\n./default_mysql_test.go\r\n./default_builds_test.go\r\n```\r\n\r\nIt means that all extended tests are part of the 'extended' Go package. This might get complex when we start adding more extended tests and the package will grow. \r\nWe might want to move those tests into logically Go packages that reflect the groups. So the current schema should be:\r\n\r\n```\r\n./images/mysql_test.go\r\n./builds/sti_environment_test.go\r\n```\r\n\r\nThere are some problems with this approach:\r\n\r\n* Ginko doesn't like this pattern as you have to import the package if you want to have one single test runner (and this is hard because _test.go file are not imported by default) or you have to create test runner for each package.\r\n* For some reason, this setup makes the test compilation much slower\r\n* The runner shell script has to be updated (or more smart about selecting groups you want to run).\r\n* Perhaps we can get rid of \"build tags\" we currently use with this new approach (but that will mean that you must build all tests and then select those you want to run with Ginko)"}}