{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/alekseenkoss77/smsru/pulls/5","id":27343199,"html_url":"https://github.com/alekseenkoss77/smsru/pull/5","diff_url":"https://github.com/alekseenkoss77/smsru/pull/5.diff","patch_url":"https://github.com/alekseenkoss77/smsru/pull/5.patch","issue_url":"https://api.github.com/repos/alekseenkoss77/smsru/issues/5","number":5,"state":"closed","locked":false,"title":"Update api.rb, to use keyword arguments","user":{"login":"jh9aea","id":3061197,"avatar_url":"https://avatars.githubusercontent.com/u/3061197?v=3","gravatar_id":"","url":"https://api.github.com/users/jh9aea","html_url":"https://github.com/jh9aea","followers_url":"https://api.github.com/users/jh9aea/followers","following_url":"https://api.github.com/users/jh9aea/following{/other_user}","gists_url":"https://api.github.com/users/jh9aea/gists{/gist_id}","starred_url":"https://api.github.com/users/jh9aea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jh9aea/subscriptions","organizations_url":"https://api.github.com/users/jh9aea/orgs","repos_url":"https://api.github.com/users/jh9aea/repos","events_url":"https://api.github.com/users/jh9aea/events{/privacy}","received_events_url":"https://api.github.com/users/jh9aea/received_events","type":"User","site_admin":false},"body":"Мне кажется будет удобнее использовать в этих функциях именованные параметры.\r\n```\r\ndef Smsru::API.send_sms(to, text, api_id: Smsru.configuration.api_id, from: Smsru.configuration.from, test: Smsru.configuration.test)\r\nend\r\n```\r\nДопустим я хочу отправить  смс от другого отправителя, с тем же api_id, было бы очень удобно:\r\n```\r\nSmsru::API.send_sms(\"#{phone}\", \"#{mes}\", from: \"#{another_from}\")\r\n```","created_at":"2015-01-14T11:27:59Z","updated_at":"2015-01-14T11:45:33Z","closed_at":"2015-01-14T11:45:33Z","merged_at":null,"merge_commit_sha":"c07b69dc87974c114d8a5adcccbfe57bf6f0bcb6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alekseenkoss77/smsru/pulls/5/commits","review_comments_url":"https://api.github.com/repos/alekseenkoss77/smsru/pulls/5/comments","review_comment_url":"https://api.github.com/repos/alekseenkoss77/smsru/pulls/comments/{number}","comments_url":"https://api.github.com/repos/alekseenkoss77/smsru/issues/5/comments","statuses_url":"https://api.github.com/repos/alekseenkoss77/smsru/statuses/379c324d3c1c022901d0a89924f1ab1def9b9faa","head":{"label":"jh9aea:master","ref":"master","sha":"379c324d3c1c022901d0a89924f1ab1def9b9faa","user":{"login":"jh9aea","id":3061197,"avatar_url":"https://avatars.githubusercontent.com/u/3061197?v=3","gravatar_id":"","url":"https://api.github.com/users/jh9aea","html_url":"https://github.com/jh9aea","followers_url":"https://api.github.com/users/jh9aea/followers","following_url":"https://api.github.com/users/jh9aea/following{/other_user}","gists_url":"https://api.github.com/users/jh9aea/gists{/gist_id}","starred_url":"https://api.github.com/users/jh9aea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jh9aea/subscriptions","organizations_url":"https://api.github.com/users/jh9aea/orgs","repos_url":"https://api.github.com/users/jh9aea/repos","events_url":"https://api.github.com/users/jh9aea/events{/privacy}","received_events_url":"https://api.github.com/users/jh9aea/received_events","type":"User","site_admin":false},"repo":{"id":29241059,"name":"smsru","full_name":"jh9aea/smsru","owner":{"login":"jh9aea","id":3061197,"avatar_url":"https://avatars.githubusercontent.com/u/3061197?v=3","gravatar_id":"","url":"https://api.github.com/users/jh9aea","html_url":"https://github.com/jh9aea","followers_url":"https://api.github.com/users/jh9aea/followers","following_url":"https://api.github.com/users/jh9aea/following{/other_user}","gists_url":"https://api.github.com/users/jh9aea/gists{/gist_id}","starred_url":"https://api.github.com/users/jh9aea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jh9aea/subscriptions","organizations_url":"https://api.github.com/users/jh9aea/orgs","repos_url":"https://api.github.com/users/jh9aea/repos","events_url":"https://api.github.com/users/jh9aea/events{/privacy}","received_events_url":"https://api.github.com/users/jh9aea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jh9aea/smsru","description":"","fork":true,"url":"https://api.github.com/repos/jh9aea/smsru","forks_url":"https://api.github.com/repos/jh9aea/smsru/forks","keys_url":"https://api.github.com/repos/jh9aea/smsru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jh9aea/smsru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jh9aea/smsru/teams","hooks_url":"https://api.github.com/repos/jh9aea/smsru/hooks","issue_events_url":"https://api.github.com/repos/jh9aea/smsru/issues/events{/number}","events_url":"https://api.github.com/repos/jh9aea/smsru/events","assignees_url":"https://api.github.com/repos/jh9aea/smsru/assignees{/user}","branches_url":"https://api.github.com/repos/jh9aea/smsru/branches{/branch}","tags_url":"https://api.github.com/repos/jh9aea/smsru/tags","blobs_url":"https://api.github.com/repos/jh9aea/smsru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jh9aea/smsru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jh9aea/smsru/git/refs{/sha}","trees_url":"https://api.github.com/repos/jh9aea/smsru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jh9aea/smsru/statuses/{sha}","languages_url":"https://api.github.com/repos/jh9aea/smsru/languages","stargazers_url":"https://api.github.com/repos/jh9aea/smsru/stargazers","contributors_url":"https://api.github.com/repos/jh9aea/smsru/contributors","subscribers_url":"https://api.github.com/repos/jh9aea/smsru/subscribers","subscription_url":"https://api.github.com/repos/jh9aea/smsru/subscription","commits_url":"https://api.github.com/repos/jh9aea/smsru/commits{/sha}","git_commits_url":"https://api.github.com/repos/jh9aea/smsru/git/commits{/sha}","comments_url":"https://api.github.com/repos/jh9aea/smsru/comments{/number}","issue_comment_url":"https://api.github.com/repos/jh9aea/smsru/issues/comments/{number}","contents_url":"https://api.github.com/repos/jh9aea/smsru/contents/{+path}","compare_url":"https://api.github.com/repos/jh9aea/smsru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jh9aea/smsru/merges","archive_url":"https://api.github.com/repos/jh9aea/smsru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jh9aea/smsru/downloads","issues_url":"https://api.github.com/repos/jh9aea/smsru/issues{/number}","pulls_url":"https://api.github.com/repos/jh9aea/smsru/pulls{/number}","milestones_url":"https://api.github.com/repos/jh9aea/smsru/milestones{/number}","notifications_url":"https://api.github.com/repos/jh9aea/smsru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jh9aea/smsru/labels{/name}","releases_url":"https://api.github.com/repos/jh9aea/smsru/releases{/id}","created_at":"2015-01-14T11:24:52Z","updated_at":"2015-01-14T11:26:10Z","pushed_at":"2015-01-14T11:26:10Z","git_url":"git://github.com/jh9aea/smsru.git","ssh_url":"git@github.com:jh9aea/smsru.git","clone_url":"https://github.com/jh9aea/smsru.git","svn_url":"https://github.com/jh9aea/smsru","homepage":null,"size":159,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alekseenkoss77:master","ref":"master","sha":"e314b83b5c0e0493ca974b751d2f2abdce774137","user":{"login":"alekseenkoss77","id":2551688,"avatar_url":"https://avatars.githubusercontent.com/u/2551688?v=3","gravatar_id":"","url":"https://api.github.com/users/alekseenkoss77","html_url":"https://github.com/alekseenkoss77","followers_url":"https://api.github.com/users/alekseenkoss77/followers","following_url":"https://api.github.com/users/alekseenkoss77/following{/other_user}","gists_url":"https://api.github.com/users/alekseenkoss77/gists{/gist_id}","starred_url":"https://api.github.com/users/alekseenkoss77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alekseenkoss77/subscriptions","organizations_url":"https://api.github.com/users/alekseenkoss77/orgs","repos_url":"https://api.github.com/users/alekseenkoss77/repos","events_url":"https://api.github.com/users/alekseenkoss77/events{/privacy}","received_events_url":"https://api.github.com/users/alekseenkoss77/received_events","type":"User","site_admin":false},"repo":{"id":9399407,"name":"smsru","full_name":"alekseenkoss77/smsru","owner":{"login":"alekseenkoss77","id":2551688,"avatar_url":"https://avatars.githubusercontent.com/u/2551688?v=3","gravatar_id":"","url":"https://api.github.com/users/alekseenkoss77","html_url":"https://github.com/alekseenkoss77","followers_url":"https://api.github.com/users/alekseenkoss77/followers","following_url":"https://api.github.com/users/alekseenkoss77/following{/other_user}","gists_url":"https://api.github.com/users/alekseenkoss77/gists{/gist_id}","starred_url":"https://api.github.com/users/alekseenkoss77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alekseenkoss77/subscriptions","organizations_url":"https://api.github.com/users/alekseenkoss77/orgs","repos_url":"https://api.github.com/users/alekseenkoss77/repos","events_url":"https://api.github.com/users/alekseenkoss77/events{/privacy}","received_events_url":"https://api.github.com/users/alekseenkoss77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alekseenkoss77/smsru","description":"","fork":false,"url":"https://api.github.com/repos/alekseenkoss77/smsru","forks_url":"https://api.github.com/repos/alekseenkoss77/smsru/forks","keys_url":"https://api.github.com/repos/alekseenkoss77/smsru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alekseenkoss77/smsru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alekseenkoss77/smsru/teams","hooks_url":"https://api.github.com/repos/alekseenkoss77/smsru/hooks","issue_events_url":"https://api.github.com/repos/alekseenkoss77/smsru/issues/events{/number}","events_url":"https://api.github.com/repos/alekseenkoss77/smsru/events","assignees_url":"https://api.github.com/repos/alekseenkoss77/smsru/assignees{/user}","branches_url":"https://api.github.com/repos/alekseenkoss77/smsru/branches{/branch}","tags_url":"https://api.github.com/repos/alekseenkoss77/smsru/tags","blobs_url":"https://api.github.com/repos/alekseenkoss77/smsru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alekseenkoss77/smsru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alekseenkoss77/smsru/git/refs{/sha}","trees_url":"https://api.github.com/repos/alekseenkoss77/smsru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alekseenkoss77/smsru/statuses/{sha}","languages_url":"https://api.github.com/repos/alekseenkoss77/smsru/languages","stargazers_url":"https://api.github.com/repos/alekseenkoss77/smsru/stargazers","contributors_url":"https://api.github.com/repos/alekseenkoss77/smsru/contributors","subscribers_url":"https://api.github.com/repos/alekseenkoss77/smsru/subscribers","subscription_url":"https://api.github.com/repos/alekseenkoss77/smsru/subscription","commits_url":"https://api.github.com/repos/alekseenkoss77/smsru/commits{/sha}","git_commits_url":"https://api.github.com/repos/alekseenkoss77/smsru/git/commits{/sha}","comments_url":"https://api.github.com/repos/alekseenkoss77/smsru/comments{/number}","issue_comment_url":"https://api.github.com/repos/alekseenkoss77/smsru/issues/comments/{number}","contents_url":"https://api.github.com/repos/alekseenkoss77/smsru/contents/{+path}","compare_url":"https://api.github.com/repos/alekseenkoss77/smsru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alekseenkoss77/smsru/merges","archive_url":"https://api.github.com/repos/alekseenkoss77/smsru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alekseenkoss77/smsru/downloads","issues_url":"https://api.github.com/repos/alekseenkoss77/smsru/issues{/number}","pulls_url":"https://api.github.com/repos/alekseenkoss77/smsru/pulls{/number}","milestones_url":"https://api.github.com/repos/alekseenkoss77/smsru/milestones{/number}","notifications_url":"https://api.github.com/repos/alekseenkoss77/smsru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alekseenkoss77/smsru/labels{/name}","releases_url":"https://api.github.com/repos/alekseenkoss77/smsru/releases{/id}","created_at":"2013-04-12T17:08:08Z","updated_at":"2015-01-14T11:00:03Z","pushed_at":"2014-12-18T07:43:00Z","git_url":"git://github.com/alekseenkoss77/smsru.git","ssh_url":"git@github.com:alekseenkoss77/smsru.git","clone_url":"https://github.com/alekseenkoss77/smsru.git","svn_url":"https://github.com/alekseenkoss77/smsru","homepage":null,"size":277,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alekseenkoss77/smsru/pulls/5"},"html":{"href":"https://github.com/alekseenkoss77/smsru/pull/5"},"issue":{"href":"https://api.github.com/repos/alekseenkoss77/smsru/issues/5"},"comments":{"href":"https://api.github.com/repos/alekseenkoss77/smsru/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/alekseenkoss77/smsru/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/alekseenkoss77/smsru/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/alekseenkoss77/smsru/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/alekseenkoss77/smsru/statuses/379c324d3c1c022901d0a89924f1ab1def9b9faa"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}