{"action":"created","issue":{"url":"https://api.github.com/repos/nanoc/nanoc/issues/687","labels_url":"https://api.github.com/repos/nanoc/nanoc/issues/687/labels{/name}","comments_url":"https://api.github.com/repos/nanoc/nanoc/issues/687/comments","events_url":"https://api.github.com/repos/nanoc/nanoc/issues/687/events","html_url":"https://github.com/nanoc/nanoc/pull/687","id":99035928,"number":687,"title":"Make base_url optional in #tags_for","user":{"login":"croath","id":1398729,"avatar_url":"https://avatars.githubusercontent.com/u/1398729?v=3","gravatar_id":"","url":"https://api.github.com/users/croath","html_url":"https://github.com/croath","followers_url":"https://api.github.com/users/croath/followers","following_url":"https://api.github.com/users/croath/following{/other_user}","gists_url":"https://api.github.com/users/croath/gists{/gist_id}","starred_url":"https://api.github.com/users/croath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croath/subscriptions","organizations_url":"https://api.github.com/users/croath/orgs","repos_url":"https://api.github.com/users/croath/repos","events_url":"https://api.github.com/users/croath/events{/privacy}","received_events_url":"https://api.github.com/users/croath/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-04T18:51:59Z","updated_at":"2015-08-05T09:56:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nanoc/nanoc/pulls/687","html_url":"https://github.com/nanoc/nanoc/pull/687","diff_url":"https://github.com/nanoc/nanoc/pull/687.diff","patch_url":"https://github.com/nanoc/nanoc/pull/687.patch"},"body":"While using version 4.0.2rc2, one error occurred after `Tagging` helper and `tags_for` method were added into my code, which told me a KeyError around key `base_url`.\r\n\r\nI checked the source in release-4.0.x and found that `base_url` must be provided or there will be an error here. It's never been listed in the document or the official tutorial.\r\n\r\nIn my mind it's not so important that users MUST have a link to a tag, at least there should be a default tag link url.\r\n\r\nThank you so much for your review."},"comment":{"url":"https://api.github.com/repos/nanoc/nanoc/issues/comments/127942005","html_url":"https://github.com/nanoc/nanoc/pull/687#issuecomment-127942005","issue_url":"https://api.github.com/repos/nanoc/nanoc/issues/687","id":127942005,"user":{"login":"ddfreyne","id":6269,"avatar_url":"https://avatars.githubusercontent.com/u/6269?v=3","gravatar_id":"","url":"https://api.github.com/users/ddfreyne","html_url":"https://github.com/ddfreyne","followers_url":"https://api.github.com/users/ddfreyne/followers","following_url":"https://api.github.com/users/ddfreyne/following{/other_user}","gists_url":"https://api.github.com/users/ddfreyne/gists{/gist_id}","starred_url":"https://api.github.com/users/ddfreyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddfreyne/subscriptions","organizations_url":"https://api.github.com/users/ddfreyne/orgs","repos_url":"https://api.github.com/users/ddfreyne/repos","events_url":"https://api.github.com/users/ddfreyne/events{/privacy}","received_events_url":"https://api.github.com/users/ddfreyne/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T09:56:03Z","updated_at":"2015-08-05T09:56:03Z","body":"This looks good! Could you make sure to update the tests too?"}}