{"action":"closed","number":12478,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12478","id":42024735,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12478","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12478.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12478.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12478","number":12478,"state":"closed","locked":false,"title":"Use pflags for net.IP and net.IPNet instead of custom flag types","user":{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},"body":"Instead of doing it ourselves use the pflags version.  Makes our code smaller, cleaner, more readable, less casting etc.","created_at":"2015-08-10T14:19:29Z","updated_at":"2015-08-10T18:55:55Z","closed_at":"2015-08-10T18:55:54Z","merged_at":"2015-08-10T18:55:54Z","merge_commit_sha":"1ec99da20a8e708a9ad4322ff1c97d87e24ad2c2","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12478/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12478/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12478/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/f3282ff4d2735f1a1f228bfedd47c24e4a8abbf6","head":{"label":"eparis:use-pflag-network","ref":"use-pflag-network","sha":"f3282ff4d2735f1a1f228bfedd47c24e4a8abbf6","user":{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},"repo":{"id":21580815,"name":"kubernetes","full_name":"eparis/kubernetes","owner":{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eparis/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/eparis/kubernetes","forks_url":"https://api.github.com/repos/eparis/kubernetes/forks","keys_url":"https://api.github.com/repos/eparis/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eparis/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eparis/kubernetes/teams","hooks_url":"https://api.github.com/repos/eparis/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/eparis/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/eparis/kubernetes/events","assignees_url":"https://api.github.com/repos/eparis/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/eparis/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/eparis/kubernetes/tags","blobs_url":"https://api.github.com/repos/eparis/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eparis/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eparis/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/eparis/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eparis/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/eparis/kubernetes/languages","stargazers_url":"https://api.github.com/repos/eparis/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/eparis/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/eparis/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/eparis/kubernetes/subscription","commits_url":"https://api.github.com/repos/eparis/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/eparis/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/eparis/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/eparis/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/eparis/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/eparis/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eparis/kubernetes/merges","archive_url":"https://api.github.com/repos/eparis/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eparis/kubernetes/downloads","issues_url":"https://api.github.com/repos/eparis/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/eparis/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/eparis/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/eparis/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eparis/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/eparis/kubernetes/releases{/id}","created_at":"2014-07-07T17:57:31Z","updated_at":"2015-05-11T19:55:26Z","pushed_at":"2015-08-10T18:36:33Z","git_url":"git://github.com/eparis/kubernetes.git","ssh_url":"git@github.com:eparis/kubernetes.git","clone_url":"https://github.com/eparis/kubernetes.git","svn_url":"https://github.com/eparis/kubernetes","homepage":null,"size":97820,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"65bff3d187f53ae6c3ba4c07aa44d86965683bed","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-10T17:20:55Z","pushed_at":"2015-08-10T18:55:54Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":340662,"stargazers_count":9610,"watchers_count":9610,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2282,"mirror_url":null,"open_issues_count":1734,"forks":2282,"open_issues":1734,"watchers":9610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12478"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12478"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12478"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12478/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12478/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12478/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/f3282ff4d2735f1a1f228bfedd47c24e4a8abbf6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars.githubusercontent.com/u/7085343?v=3","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":2,"additions":60,"deletions":231,"changed_files":9}}