{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/kscale/issues/17","labels_url":"https://api.github.com/repos/coreos/kscale/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/coreos/kscale/issues/17/comments","events_url":"https://api.github.com/repos/coreos/kscale/issues/17/events","html_url":"https://github.com/coreos/kscale/pull/17","id":120930678,"number":17,"title":"minor refactor & remove wait group to see actual rates","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-08T04:58:13Z","updated_at":"2015-12-08T17:48:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/kscale/pulls/17","html_url":"https://github.com/coreos/kscale/pull/17","diff_url":"https://github.com/coreos/kscale/pull/17.diff","patch_url":"https://github.com/coreos/kscale/pull/17.patch"},"body":"Previously, makePods() would wait until all CreatePods request sent. When result showed up the first time, there are already many pods scheduled:\r\n```\r\n=== RUN   TestScheduling1000Nodes10KPods\r\n0s rate: 170 total: 170\r\n1s rate: 4 total: 184\r\n```\r\n\r\nAfter removing the wait group, \r\n```\r\n=== RUN   TestScheduling1000Nodes10KPods\r\n0s rate: 0 total: 0\r\n1s rate: 5 total: 5\r\n2s rate: 12 total: 17\r\n```\r\n\r\nWe don't need to wait group either because the loop checks all pods are scheduled and it's kinda like a wait group itself.\r\n\r\nAt the mean time, some minor fixes. :)"},"comment":{"url":"https://api.github.com/repos/coreos/kscale/issues/comments/162959011","html_url":"https://github.com/coreos/kscale/pull/17#issuecomment-162959011","issue_url":"https://api.github.com/repos/coreos/kscale/issues/17","id":162959011,"user":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"created_at":"2015-12-08T17:48:02Z","updated_at":"2015-12-08T17:48:02Z","body":"LGTM"}}