{"action":"opened","number":101,"pull_request":{"url":"https://api.github.com/repos/coop182/jquery.dfp.js/pulls/101","id":36733184,"html_url":"https://github.com/coop182/jquery.dfp.js/pull/101","diff_url":"https://github.com/coop182/jquery.dfp.js/pull/101.diff","patch_url":"https://github.com/coop182/jquery.dfp.js/pull/101.patch","issue_url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/101","number":101,"state":"open","locked":false,"title":"use the right $ as UMD Module","user":{"login":"BowlingX","id":215671,"avatar_url":"https://avatars.githubusercontent.com/u/215671?v=3","gravatar_id":"","url":"https://api.github.com/users/BowlingX","html_url":"https://github.com/BowlingX","followers_url":"https://api.github.com/users/BowlingX/followers","following_url":"https://api.github.com/users/BowlingX/following{/other_user}","gists_url":"https://api.github.com/users/BowlingX/gists{/gist_id}","starred_url":"https://api.github.com/users/BowlingX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BowlingX/subscriptions","organizations_url":"https://api.github.com/users/BowlingX/orgs","repos_url":"https://api.github.com/users/BowlingX/repos","events_url":"https://api.github.com/users/BowlingX/events{/privacy}","received_events_url":"https://api.github.com/users/BowlingX/received_events","type":"User","site_admin":false},"body":"Hey :)\r\nthank you first for this plugin, it makes things a lot easier while dealing with DFP :).\r\nI changed the way the module loads, because the current UMD implementation is not correct.\r\n\r\n```\r\n(function($, window, undefined)(window.jQuery....)\r\n````\r\n\r\nThe $ shadows the underlying implementation and so a global $ is always used by the plugin (which is not available when loaded with a module loader). I changed it in a way that if a module loader is in scope all dependencies will be resolved first and then delegated to your implementation.\r\n\r\nBest\r\nDavid","created_at":"2015-06-02T14:18:10Z","updated_at":"2015-06-02T14:18:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coop182/jquery.dfp.js/pulls/101/commits","review_comments_url":"https://api.github.com/repos/coop182/jquery.dfp.js/pulls/101/comments","review_comment_url":"https://api.github.com/repos/coop182/jquery.dfp.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/101/comments","statuses_url":"https://api.github.com/repos/coop182/jquery.dfp.js/statuses/e5c78c7e14aa9bd5646abcf52e7900375bd5679e","head":{"label":"BowlingX:master","ref":"master","sha":"e5c78c7e14aa9bd5646abcf52e7900375bd5679e","user":{"login":"BowlingX","id":215671,"avatar_url":"https://avatars.githubusercontent.com/u/215671?v=3","gravatar_id":"","url":"https://api.github.com/users/BowlingX","html_url":"https://github.com/BowlingX","followers_url":"https://api.github.com/users/BowlingX/followers","following_url":"https://api.github.com/users/BowlingX/following{/other_user}","gists_url":"https://api.github.com/users/BowlingX/gists{/gist_id}","starred_url":"https://api.github.com/users/BowlingX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BowlingX/subscriptions","organizations_url":"https://api.github.com/users/BowlingX/orgs","repos_url":"https://api.github.com/users/BowlingX/repos","events_url":"https://api.github.com/users/BowlingX/events{/privacy}","received_events_url":"https://api.github.com/users/BowlingX/received_events","type":"User","site_admin":false},"repo":{"id":36736753,"name":"jquery.dfp.js","full_name":"BowlingX/jquery.dfp.js","owner":{"login":"BowlingX","id":215671,"avatar_url":"https://avatars.githubusercontent.com/u/215671?v=3","gravatar_id":"","url":"https://api.github.com/users/BowlingX","html_url":"https://github.com/BowlingX","followers_url":"https://api.github.com/users/BowlingX/followers","following_url":"https://api.github.com/users/BowlingX/following{/other_user}","gists_url":"https://api.github.com/users/BowlingX/gists{/gist_id}","starred_url":"https://api.github.com/users/BowlingX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BowlingX/subscriptions","organizations_url":"https://api.github.com/users/BowlingX/orgs","repos_url":"https://api.github.com/users/BowlingX/repos","events_url":"https://api.github.com/users/BowlingX/events{/privacy}","received_events_url":"https://api.github.com/users/BowlingX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BowlingX/jquery.dfp.js","description":"A jQuery implementation for Google DoubleClick for Publishers (DFP)","fork":true,"url":"https://api.github.com/repos/BowlingX/jquery.dfp.js","forks_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/forks","keys_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/teams","hooks_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/hooks","issue_events_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/issues/events{/number}","events_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/events","assignees_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/assignees{/user}","branches_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/branches{/branch}","tags_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/tags","blobs_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/statuses/{sha}","languages_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/languages","stargazers_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/stargazers","contributors_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/contributors","subscribers_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/subscribers","subscription_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/subscription","commits_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/contents/{+path}","compare_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/merges","archive_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/downloads","issues_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/issues{/number}","pulls_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/pulls{/number}","milestones_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/milestones{/number}","notifications_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/labels{/name}","releases_url":"https://api.github.com/repos/BowlingX/jquery.dfp.js/releases{/id}","created_at":"2015-06-02T13:54:50Z","updated_at":"2015-06-02T13:54:51Z","pushed_at":"2015-06-02T14:07:58Z","git_url":"git://github.com/BowlingX/jquery.dfp.js.git","ssh_url":"git@github.com:BowlingX/jquery.dfp.js.git","clone_url":"https://github.com/BowlingX/jquery.dfp.js.git","svn_url":"https://github.com/BowlingX/jquery.dfp.js","homepage":"","size":472,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coop182:master","ref":"master","sha":"653dc97f49cc0dca0fc08dfa6a77a7e41a1d87f8","user":{"login":"coop182","id":1443208,"avatar_url":"https://avatars.githubusercontent.com/u/1443208?v=3","gravatar_id":"","url":"https://api.github.com/users/coop182","html_url":"https://github.com/coop182","followers_url":"https://api.github.com/users/coop182/followers","following_url":"https://api.github.com/users/coop182/following{/other_user}","gists_url":"https://api.github.com/users/coop182/gists{/gist_id}","starred_url":"https://api.github.com/users/coop182/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coop182/subscriptions","organizations_url":"https://api.github.com/users/coop182/orgs","repos_url":"https://api.github.com/users/coop182/repos","events_url":"https://api.github.com/users/coop182/events{/privacy}","received_events_url":"https://api.github.com/users/coop182/received_events","type":"User","site_admin":false},"repo":{"id":4991519,"name":"jquery.dfp.js","full_name":"coop182/jquery.dfp.js","owner":{"login":"coop182","id":1443208,"avatar_url":"https://avatars.githubusercontent.com/u/1443208?v=3","gravatar_id":"","url":"https://api.github.com/users/coop182","html_url":"https://github.com/coop182","followers_url":"https://api.github.com/users/coop182/followers","following_url":"https://api.github.com/users/coop182/following{/other_user}","gists_url":"https://api.github.com/users/coop182/gists{/gist_id}","starred_url":"https://api.github.com/users/coop182/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coop182/subscriptions","organizations_url":"https://api.github.com/users/coop182/orgs","repos_url":"https://api.github.com/users/coop182/repos","events_url":"https://api.github.com/users/coop182/events{/privacy}","received_events_url":"https://api.github.com/users/coop182/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coop182/jquery.dfp.js","description":"A jQuery implementation for Google DoubleClick for Publishers (DFP)","fork":false,"url":"https://api.github.com/repos/coop182/jquery.dfp.js","forks_url":"https://api.github.com/repos/coop182/jquery.dfp.js/forks","keys_url":"https://api.github.com/repos/coop182/jquery.dfp.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coop182/jquery.dfp.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coop182/jquery.dfp.js/teams","hooks_url":"https://api.github.com/repos/coop182/jquery.dfp.js/hooks","issue_events_url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/events{/number}","events_url":"https://api.github.com/repos/coop182/jquery.dfp.js/events","assignees_url":"https://api.github.com/repos/coop182/jquery.dfp.js/assignees{/user}","branches_url":"https://api.github.com/repos/coop182/jquery.dfp.js/branches{/branch}","tags_url":"https://api.github.com/repos/coop182/jquery.dfp.js/tags","blobs_url":"https://api.github.com/repos/coop182/jquery.dfp.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coop182/jquery.dfp.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coop182/jquery.dfp.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/coop182/jquery.dfp.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coop182/jquery.dfp.js/statuses/{sha}","languages_url":"https://api.github.com/repos/coop182/jquery.dfp.js/languages","stargazers_url":"https://api.github.com/repos/coop182/jquery.dfp.js/stargazers","contributors_url":"https://api.github.com/repos/coop182/jquery.dfp.js/contributors","subscribers_url":"https://api.github.com/repos/coop182/jquery.dfp.js/subscribers","subscription_url":"https://api.github.com/repos/coop182/jquery.dfp.js/subscription","commits_url":"https://api.github.com/repos/coop182/jquery.dfp.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/coop182/jquery.dfp.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/coop182/jquery.dfp.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/coop182/jquery.dfp.js/contents/{+path}","compare_url":"https://api.github.com/repos/coop182/jquery.dfp.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coop182/jquery.dfp.js/merges","archive_url":"https://api.github.com/repos/coop182/jquery.dfp.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coop182/jquery.dfp.js/downloads","issues_url":"https://api.github.com/repos/coop182/jquery.dfp.js/issues{/number}","pulls_url":"https://api.github.com/repos/coop182/jquery.dfp.js/pulls{/number}","milestones_url":"https://api.github.com/repos/coop182/jquery.dfp.js/milestones{/number}","notifications_url":"https://api.github.com/repos/coop182/jquery.dfp.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coop182/jquery.dfp.js/labels{/name}","releases_url":"https://api.github.com/repos/coop182/jquery.dfp.js/releases{/id}","created_at":"2012-07-11T16:09:48Z","updated_at":"2015-06-02T10:45:46Z","pushed_at":"2015-06-02T14:18:10Z","git_url":"git://github.com/coop182/jquery.dfp.js.git","ssh_url":"git@github.com:coop182/jquery.dfp.js.git","clone_url":"https://github.com/coop182/jquery.dfp.js.git","svn_url":"https://github.com/coop182/jquery.dfp.js","homepage":"","size":984,"stargazers_count":167,"watchers_count":167,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":54,"mirror_url":null,"open_issues_count":5,"forks":54,"open_issues":5,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coop182/jquery.dfp.js/pulls/101"},"html":{"href":"https://github.com/coop182/jquery.dfp.js/pull/101"},"issue":{"href":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/101"},"comments":{"href":"https://api.github.com/repos/coop182/jquery.dfp.js/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/coop182/jquery.dfp.js/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/coop182/jquery.dfp.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coop182/jquery.dfp.js/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/coop182/jquery.dfp.js/statuses/e5c78c7e14aa9bd5646abcf52e7900375bd5679e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":395,"deletions":396,"changed_files":1}}