{"action":"closed","number":2157,"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/2157","id":39719160,"html_url":"https://github.com/nodejs/io.js/pull/2157","diff_url":"https://github.com/nodejs/io.js/pull/2157.diff","patch_url":"https://github.com/nodejs/io.js/pull/2157.patch","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/2157","number":2157,"state":"closed","locked":false,"title":"node: remove bad fn call and check","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"These two lines exist because of a screw up on my part while combining\r\nMakeCallback() and MakeDomainCallback().\r\n\r\nThe reason it never broke core tests is because any paths it would have\r\nbroken were rerouted to AsyncWrap::MakeCallback(). The only case that\r\nnode::MakeCallback() handles anymore is setImmediate().\r\n\r\nFix: a1da024 \"node, async-wrap: remove MakeDomainCallback\"\r\n\r\nR=@bnoordhuis?\r\n\r\nCI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/145/","created_at":"2015-07-10T20:01:09Z","updated_at":"2015-07-27T17:41:52Z","closed_at":"2015-07-27T17:41:52Z","merged_at":null,"merge_commit_sha":"c7788be273ee01d3b32c30c9a3e91aa893657a0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/io.js/pulls/2157/commits","review_comments_url":"https://api.github.com/repos/nodejs/io.js/pulls/2157/comments","review_comment_url":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/2157/comments","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/e02e296bd58fb156dbd7fa61919bbb3584a5aee1","head":{"label":"trevnorris:small-tick-fix","ref":"small-tick-fix","sha":"e02e296bd58fb156dbd7fa61919bbb3584a5aee1","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"repo":{"id":29560577,"name":"io.js","full_name":"trevnorris/io.js","owner":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trevnorris/io.js","description":"A spork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/trevnorris/io.js","forks_url":"https://api.github.com/repos/trevnorris/io.js/forks","keys_url":"https://api.github.com/repos/trevnorris/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trevnorris/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trevnorris/io.js/teams","hooks_url":"https://api.github.com/repos/trevnorris/io.js/hooks","issue_events_url":"https://api.github.com/repos/trevnorris/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/trevnorris/io.js/events","assignees_url":"https://api.github.com/repos/trevnorris/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/trevnorris/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/trevnorris/io.js/tags","blobs_url":"https://api.github.com/repos/trevnorris/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trevnorris/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trevnorris/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/trevnorris/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trevnorris/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/trevnorris/io.js/languages","stargazers_url":"https://api.github.com/repos/trevnorris/io.js/stargazers","contributors_url":"https://api.github.com/repos/trevnorris/io.js/contributors","subscribers_url":"https://api.github.com/repos/trevnorris/io.js/subscribers","subscription_url":"https://api.github.com/repos/trevnorris/io.js/subscription","commits_url":"https://api.github.com/repos/trevnorris/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/trevnorris/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/trevnorris/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/trevnorris/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/trevnorris/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/trevnorris/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trevnorris/io.js/merges","archive_url":"https://api.github.com/repos/trevnorris/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trevnorris/io.js/downloads","issues_url":"https://api.github.com/repos/trevnorris/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/trevnorris/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/trevnorris/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/trevnorris/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trevnorris/io.js/labels{/name}","releases_url":"https://api.github.com/repos/trevnorris/io.js/releases{/id}","created_at":"2015-01-20T23:22:42Z","updated_at":"2015-05-08T19:24:32Z","pushed_at":"2015-07-22T19:09:57Z","git_url":"git://github.com/trevnorris/io.js.git","ssh_url":"git@github.com:trevnorris/io.js.git","clone_url":"https://github.com/trevnorris/io.js.git","svn_url":"https://github.com/trevnorris/io.js","homepage":"https://iojs.org","size":138094,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v1.x"}},"base":{"label":"nodejs:master","ref":"master","sha":"eb35968de7a040d737f3280e9fed0b6edf566b2b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"nodejs/io.js","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/io.js","description":"Future Node.js releases will be based on io.js","fork":false,"url":"https://api.github.com/repos/nodejs/io.js","forks_url":"https://api.github.com/repos/nodejs/io.js/forks","keys_url":"https://api.github.com/repos/nodejs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/io.js/teams","hooks_url":"https://api.github.com/repos/nodejs/io.js/hooks","issue_events_url":"https://api.github.com/repos/nodejs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/io.js/events","assignees_url":"https://api.github.com/repos/nodejs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/io.js/tags","blobs_url":"https://api.github.com/repos/nodejs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/io.js/languages","stargazers_url":"https://api.github.com/repos/nodejs/io.js/stargazers","contributors_url":"https://api.github.com/repos/nodejs/io.js/contributors","subscribers_url":"https://api.github.com/repos/nodejs/io.js/subscribers","subscription_url":"https://api.github.com/repos/nodejs/io.js/subscription","commits_url":"https://api.github.com/repos/nodejs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/io.js/merges","archive_url":"https://api.github.com/repos/nodejs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/io.js/downloads","issues_url":"https://api.github.com/repos/nodejs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-07-27T15:02:10Z","pushed_at":"2015-07-27T17:41:36Z","git_url":"git://github.com/nodejs/io.js.git","ssh_url":"git@github.com:nodejs/io.js.git","clone_url":"https://github.com/nodejs/io.js.git","svn_url":"https://github.com/nodejs/io.js","homepage":"https://iojs.org","size":190874,"stargazers_count":12923,"watchers_count":12923,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1036,"mirror_url":null,"open_issues_count":286,"forks":1036,"open_issues":286,"watchers":12923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2157"},"html":{"href":"https://github.com/nodejs/io.js/pull/2157"},"issue":{"href":"https://api.github.com/repos/nodejs/io.js/issues/2157"},"comments":{"href":"https://api.github.com/repos/nodejs/io.js/issues/2157/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2157/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2157/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/io.js/statuses/e02e296bd58fb156dbd7fa61919bbb3584a5aee1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":0,"deletions":2,"changed_files":1}}