{"action":"created","issue":{"url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/122","labels_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/122/comments","events_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/122/events","html_url":"https://github.com/DigitalPebble/storm-crawler/pull/122","id":69141727,"number":122,"title":"Replace HTTP protocol implementation","user":{"login":"jnioche","id":218319,"avatar_url":"https://avatars.githubusercontent.com/u/218319?v=3","gravatar_id":"","url":"https://api.github.com/users/jnioche","html_url":"https://github.com/jnioche","followers_url":"https://api.github.com/users/jnioche/followers","following_url":"https://api.github.com/users/jnioche/following{/other_user}","gists_url":"https://api.github.com/users/jnioche/gists{/gist_id}","starred_url":"https://api.github.com/users/jnioche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnioche/subscriptions","organizations_url":"https://api.github.com/users/jnioche/orgs","repos_url":"https://api.github.com/users/jnioche/repos","events_url":"https://api.github.com/users/jnioche/events{/privacy}","received_events_url":"https://api.github.com/users/jnioche/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-17T13:42:37Z","updated_at":"2015-04-22T10:41:18Z","closed_at":"2015-04-22T10:41:13Z","pull_request":{"url":"https://api.github.com/repos/DigitalPebble/storm-crawler/pulls/122","html_url":"https://github.com/DigitalPebble/storm-crawler/pull/122","diff_url":"https://github.com/DigitalPebble/storm-crawler/pull/122.diff","patch_url":"https://github.com/DigitalPebble/storm-crawler/pull/122.patch"},"body":"Removes the existing code for the http protocol handling which came from Nutch and uses the httpclient library instead.  \r\n\r\nThe amount of code is greatly reduced as a result and we should have a more robust processing by leveraging an external library instead of rolling our own low level code. I have seen better results on https compared to the existing version.\r\n\r\nThe only missing features at this stage are \\:\r\n* store.ip.address\r\n* maxContent\r\n* acceptLanguage\r\n* accept\r\n* http.store.responsetime\r\n\r\nThese are relatively minor and could be added afterwards\r\n\r\nFixes #23 \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/comments/95129889","html_url":"https://github.com/DigitalPebble/storm-crawler/pull/122#issuecomment-95129889","issue_url":"https://api.github.com/repos/DigitalPebble/storm-crawler/issues/122","id":95129889,"user":{"login":"jnioche","id":218319,"avatar_url":"https://avatars.githubusercontent.com/u/218319?v=3","gravatar_id":"","url":"https://api.github.com/users/jnioche","html_url":"https://github.com/jnioche","followers_url":"https://api.github.com/users/jnioche/followers","following_url":"https://api.github.com/users/jnioche/following{/other_user}","gists_url":"https://api.github.com/users/jnioche/gists{/gist_id}","starred_url":"https://api.github.com/users/jnioche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnioche/subscriptions","organizations_url":"https://api.github.com/users/jnioche/orgs","repos_url":"https://api.github.com/users/jnioche/repos","events_url":"https://api.github.com/users/jnioche/events{/privacy}","received_events_url":"https://api.github.com/users/jnioche/received_events","type":"User","site_admin":false},"created_at":"2015-04-22T10:41:18Z","updated_at":"2015-04-22T10:41:18Z","body":"you are right about the client. silly me!\r\n\r\nsquashed commits\r\n\r\nthanks for reviewing it"}}