{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments/26385877","id":26385877,"diff_hunk":"@@ -2,45 +2,55 @@\n  * mobile Fixed Toolbar unit tests\n  */\n (function($){\n-\tmodule('jquery.mobile.toolbar.js');\n+\tmodule( \"jquery.mobile.toolbar.js\" );\n \n-\ttest( \"Fixed Header Structural Classes are applied correctly\", function(){\n+\ttest( \"Fixed Header Structural Classes are applied correctly\", function( assert ){\n \t\t//footer\n-\t\tok( !$('#classes-test-a').hasClass('ui-header-fixed'), 'An ordinary header should not have fixed classes');\n-\t\tok( $('#classes-test-b').hasClass('ui-header-fixed'), 'An header with data-position=fixed should have ui-header-fixed class');\n-\t\tok( $('#classes-test-c').hasClass('ui-header-fullscreen'), 'An header with data-position=fixed and data-fullscreen should have ui-header-fullscreen class');\n+\t\tassert.lacksClasses( $( \"#classes-test-a\" ), \"ui-toolbar-header-fixed\", \n+\t\t\t\"An ordinary header should not have fixed classes\" );\n+\t\tassert.hasClasses( $( \"#classes-test-b\" ), \"ui-toolbar-header-fixed\", \n+\t\t\t\"A header with data-position=fixed should have ui-toolbar-header-fixed class\" );\n+\t\tassert.hasClasses( $( \"#classes-test-c\" ), \"ui-toolbar-header-fullscreen\",\n+\t\t\t\"A header with =fixed and data-fullscreen gets ui-toolbar-header-fullscreen class\" );\n \n \t\t//footer\n-\t\tok( !$('#classes-test-d').hasClass('ui-footer-fixed'), 'An ordinary footer should not have fixed classes');\n-\t\tok( $('#classes-test-e').hasClass('ui-footer-fixed'), 'A footer with data-position=fixed should have ui-footer-fixed class\"');\n-\t\tok( $('#classes-test-f').hasClass('ui-footer-fullscreen'), 'A footer with data-position=fixed and data-fullscreen should have ui-footer-fullscreen class');\n+\t\tassert.lacksClasses( $( \"#classes-test-d\" ), \"ui-toolbar-footer-fixed\", \n+\t\t\t\"An ordinary footer should not have fixed classes\");\n+\t\tassert.hasClasses( $( \"#classes-test-e\" ), \"ui-toolbar-footer-fixed\", \n+\t\t\t\"A footer with data-position=fixed should have ui-toolbar-footer-fixed class\" );\n+\t\tassert.hasClasses( $( \"#classes-test-f\" ), \"ui-toolbar-footer-fullscreen\", \n+\t\t\t\"A footer with =fixed and data-fullscreen gets ui-toolbar-footer-fullscreen class\" );\n \n \t\t//parent\n-\t\tok( $('#classes-test-b').closest( \".ui-page\" ).hasClass( \"ui-page-header-fixed\" ), \"Parent page of a fixed header has class ui-page-header-fixed\" );\n-\t\tok( $('#classes-test-e').closest( \".ui-page\" ).hasClass( \"ui-page-footer-fixed\" ), \"Parent page of a fixed footer has class ui-page-header-fixed\" );\n+\t\tassert.hasClasses( $( \"#classes-test-b\" ).closest( \".ui-page\" ),\n+\t\t\t\"ui-page-header-fixed\", \n+\t\t\t\"Parent page of a fixed header has class ui-page-header-fixed\" );\n+\t\tassert.hasClasses( $( \"#classes-test-e\" ).closest( \".ui-page\" ),\n+\t\t\t\"ui-page-footer-fixed\", \n+\t\t\t\"Parent page of a fixed footer has class ui-page-header-fixed\" );\n \t});\n \n \ttest( \"User zooming is disabled when the header is visible and disablePageZoom is true\", function(){\n \t\t$.mobile.zoom.enable();\n \t\tvar defaultZoom = $.mobile.toolbar.prototype.options.disablePageZoom;\n-\t\t$( \".ui-page-active .ui-header-fixed\" ).toolbar(\"option\", \"disablePageZoom\", true );\n+\t\t$( \".ui-page-active .ui-toolbar-header-fixed\" ).toolbar(\"option\", \"disablePageZoom\", true );\n \n \t\t$( \".ui-page-active\" ).trigger( \"pagebeforeshow\" );\n \t\tok( !$.mobile.zoom.enabled, \"Viewport scaling is disabled before page show.\" );\n-\t\t$( \".ui-page-active .ui-header-fixed\" ).toolbar(\"option\", \"disablePageZoom\", defaultZoom );\n+\t\t$( \".ui-page-active .ui-toolbar-header-fixed\" ).toolbar(\"option\", \"disablePageZoom\", defaultZoom );\n \t\t$.mobile.zoom.enable();\n \t});\n \n \ttest( \"Meta viewport content is restored to previous state, and zooming renabled, after pagebeforehide\", function(){\n \t\t$.mobile.zoom.enable( true );\n \t\tvar defaultZoom = $.mobile.toolbar.prototype.options.disablePageZoom;\n-\t\t$( \".ui-page-active .ui-header-fixed\" ).toolbar(\"option\", \"disablePageZoom\", true );\n+\t\t$( \".ui-page-active .ui-toolbar-header-fixed\" ).toolbar(\"option\", \"disablePageZoom\", true );","path":"tests/unit/fixed-toolbar/fixedToolbar.js","position":59,"original_position":59,"commit_id":"0f4fe720b16f2bae85d93e11089680ec1b1ab936","original_commit_id":"0f4fe720b16f2bae85d93e11089680ec1b1ab936","user":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=3","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"body":"spacing","created_at":"2015-03-13T13:42:22Z","updated_at":"2015-03-13T13:42:22Z","html_url":"https://github.com/jquery/jquery-mobile/pull/7970#discussion_r26385877","pull_request_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7970","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments/26385877"},"html":{"href":"https://github.com/jquery/jquery-mobile/pull/7970#discussion_r26385877"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7970"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7970","id":29649038,"html_url":"https://github.com/jquery/jquery-mobile/pull/7970","diff_url":"https://github.com/jquery/jquery-mobile/pull/7970.diff","patch_url":"https://github.com/jquery/jquery-mobile/pull/7970.patch","issue_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/7970","number":7970,"state":"open","locked":false,"title":"Toolbar: Implement classes option","user":{"login":"cgack","id":688148,"avatar_url":"https://avatars.githubusercontent.com/u/688148?v=3","gravatar_id":"","url":"https://api.github.com/users/cgack","html_url":"https://github.com/cgack","followers_url":"https://api.github.com/users/cgack/followers","following_url":"https://api.github.com/users/cgack/following{/other_user}","gists_url":"https://api.github.com/users/cgack/gists{/gist_id}","starred_url":"https://api.github.com/users/cgack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgack/subscriptions","organizations_url":"https://api.github.com/users/cgack/orgs","repos_url":"https://api.github.com/users/cgack/repos","events_url":"https://api.github.com/users/cgack/events{/privacy}","received_events_url":"https://api.github.com/users/cgack/received_events","type":"User","site_admin":false},"body":"Fixes gh-7687","created_at":"2015-02-19T21:08:41Z","updated_at":"2015-03-13T13:42:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9785fc110ebd44fa49af06b5626f0d35fdada64","assignee":{"login":"cgack","id":688148,"avatar_url":"https://avatars.githubusercontent.com/u/688148?v=3","gravatar_id":"","url":"https://api.github.com/users/cgack","html_url":"https://github.com/cgack","followers_url":"https://api.github.com/users/cgack/followers","following_url":"https://api.github.com/users/cgack/following{/other_user}","gists_url":"https://api.github.com/users/cgack/gists{/gist_id}","starred_url":"https://api.github.com/users/cgack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgack/subscriptions","organizations_url":"https://api.github.com/users/cgack/orgs","repos_url":"https://api.github.com/users/cgack/repos","events_url":"https://api.github.com/users/cgack/events{/privacy}","received_events_url":"https://api.github.com/users/cgack/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/jquery/jquery-mobile/milestones/24","html_url":"https://github.com/jquery/jquery-mobile/milestones/1.5.0","labels_url":"https://api.github.com/repos/jquery/jquery-mobile/milestones/24/labels","id":265123,"number":24,"title":"1.5.0","description":"","creator":{"login":"jaspermdegroot","id":1296793,"avatar_url":"https://avatars.githubusercontent.com/u/1296793?v=3","gravatar_id":"","url":"https://api.github.com/users/jaspermdegroot","html_url":"https://github.com/jaspermdegroot","followers_url":"https://api.github.com/users/jaspermdegroot/followers","following_url":"https://api.github.com/users/jaspermdegroot/following{/other_user}","gists_url":"https://api.github.com/users/jaspermdegroot/gists{/gist_id}","starred_url":"https://api.github.com/users/jaspermdegroot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaspermdegroot/subscriptions","organizations_url":"https://api.github.com/users/jaspermdegroot/orgs","repos_url":"https://api.github.com/users/jaspermdegroot/repos","events_url":"https://api.github.com/users/jaspermdegroot/events{/privacy}","received_events_url":"https://api.github.com/users/jaspermdegroot/received_events","type":"User","site_admin":false},"open_issues":152,"closed_issues":107,"state":"open","created_at":"2013-02-12T09:05:39Z","updated_at":"2015-03-12T19:13:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7970/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7970/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/7970/comments","statuses_url":"https://api.github.com/repos/jquery/jquery-mobile/statuses/0f4fe720b16f2bae85d93e11089680ec1b1ab936","head":{"label":"cgack:7687-toolbar-implement-classes","ref":"7687-toolbar-implement-classes","sha":"0f4fe720b16f2bae85d93e11089680ec1b1ab936","user":{"login":"cgack","id":688148,"avatar_url":"https://avatars.githubusercontent.com/u/688148?v=3","gravatar_id":"","url":"https://api.github.com/users/cgack","html_url":"https://github.com/cgack","followers_url":"https://api.github.com/users/cgack/followers","following_url":"https://api.github.com/users/cgack/following{/other_user}","gists_url":"https://api.github.com/users/cgack/gists{/gist_id}","starred_url":"https://api.github.com/users/cgack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgack/subscriptions","organizations_url":"https://api.github.com/users/cgack/orgs","repos_url":"https://api.github.com/users/cgack/repos","events_url":"https://api.github.com/users/cgack/events{/privacy}","received_events_url":"https://api.github.com/users/cgack/received_events","type":"User","site_admin":false},"repo":{"id":3147847,"name":"jquery-mobile","full_name":"cgack/jquery-mobile","owner":{"login":"cgack","id":688148,"avatar_url":"https://avatars.githubusercontent.com/u/688148?v=3","gravatar_id":"","url":"https://api.github.com/users/cgack","html_url":"https://github.com/cgack","followers_url":"https://api.github.com/users/cgack/followers","following_url":"https://api.github.com/users/cgack/following{/other_user}","gists_url":"https://api.github.com/users/cgack/gists{/gist_id}","starred_url":"https://api.github.com/users/cgack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgack/subscriptions","organizations_url":"https://api.github.com/users/cgack/orgs","repos_url":"https://api.github.com/users/cgack/repos","events_url":"https://api.github.com/users/cgack/events{/privacy}","received_events_url":"https://api.github.com/users/cgack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgack/jquery-mobile","description":"jQuery Mobile Framework","fork":true,"url":"https://api.github.com/repos/cgack/jquery-mobile","forks_url":"https://api.github.com/repos/cgack/jquery-mobile/forks","keys_url":"https://api.github.com/repos/cgack/jquery-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgack/jquery-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgack/jquery-mobile/teams","hooks_url":"https://api.github.com/repos/cgack/jquery-mobile/hooks","issue_events_url":"https://api.github.com/repos/cgack/jquery-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/cgack/jquery-mobile/events","assignees_url":"https://api.github.com/repos/cgack/jquery-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/cgack/jquery-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/cgack/jquery-mobile/tags","blobs_url":"https://api.github.com/repos/cgack/jquery-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgack/jquery-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgack/jquery-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgack/jquery-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgack/jquery-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/cgack/jquery-mobile/languages","stargazers_url":"https://api.github.com/repos/cgack/jquery-mobile/stargazers","contributors_url":"https://api.github.com/repos/cgack/jquery-mobile/contributors","subscribers_url":"https://api.github.com/repos/cgack/jquery-mobile/subscribers","subscription_url":"https://api.github.com/repos/cgack/jquery-mobile/subscription","commits_url":"https://api.github.com/repos/cgack/jquery-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgack/jquery-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgack/jquery-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgack/jquery-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgack/jquery-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/cgack/jquery-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgack/jquery-mobile/merges","archive_url":"https://api.github.com/repos/cgack/jquery-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgack/jquery-mobile/downloads","issues_url":"https://api.github.com/repos/cgack/jquery-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/cgack/jquery-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/cgack/jquery-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/cgack/jquery-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgack/jquery-mobile/labels{/name}","releases_url":"https://api.github.com/repos/cgack/jquery-mobile/releases{/id}","created_at":"2012-01-10T19:22:19Z","updated_at":"2015-01-14T13:46:50Z","pushed_at":"2015-03-12T17:31:52Z","git_url":"git://github.com/cgack/jquery-mobile.git","ssh_url":"git@github.com:cgack/jquery-mobile.git","clone_url":"https://github.com/cgack/jquery-mobile.git","svn_url":"https://github.com/cgack/jquery-mobile","homepage":"http://jquerymobile.com/","size":131151,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"jquery:ui-1-12","ref":"ui-1-12","sha":"597cd5cb26b436cdd380437d1aa61b890b430013","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":907410,"name":"jquery-mobile","full_name":"jquery/jquery-mobile","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery-mobile","description":"jQuery Mobile Framework","fork":false,"url":"https://api.github.com/repos/jquery/jquery-mobile","forks_url":"https://api.github.com/repos/jquery/jquery-mobile/forks","keys_url":"https://api.github.com/repos/jquery/jquery-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery-mobile/teams","hooks_url":"https://api.github.com/repos/jquery/jquery-mobile/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery-mobile/events","assignees_url":"https://api.github.com/repos/jquery/jquery-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery-mobile/tags","blobs_url":"https://api.github.com/repos/jquery/jquery-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery-mobile/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery-mobile/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery-mobile/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery-mobile/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery-mobile/subscription","commits_url":"https://api.github.com/repos/jquery/jquery-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery-mobile/merges","archive_url":"https://api.github.com/repos/jquery/jquery-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery-mobile/downloads","issues_url":"https://api.github.com/repos/jquery/jquery-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery-mobile/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery-mobile/releases{/id}","created_at":"2010-09-13T15:02:22Z","updated_at":"2015-03-13T11:56:06Z","pushed_at":"2015-03-12T19:13:17Z","git_url":"git://github.com/jquery/jquery-mobile.git","ssh_url":"git@github.com:jquery/jquery-mobile.git","clone_url":"https://github.com/jquery/jquery-mobile.git","svn_url":"https://github.com/jquery/jquery-mobile","homepage":"http://jquerymobile.com/","size":180763,"stargazers_count":9432,"watchers_count":9432,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2503,"mirror_url":null,"open_issues_count":320,"forks":2503,"open_issues":320,"watchers":9432,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7970"},"html":{"href":"https://github.com/jquery/jquery-mobile/pull/7970"},"issue":{"href":"https://api.github.com/repos/jquery/jquery-mobile/issues/7970"},"comments":{"href":"https://api.github.com/repos/jquery/jquery-mobile/issues/7970/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7970/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery-mobile/pulls/7970/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery-mobile/statuses/0f4fe720b16f2bae85d93e11089680ec1b1ab936"}}}}