{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/keflavich/macvim-skim/pulls/9","id":52043461,"html_url":"https://github.com/keflavich/macvim-skim/pull/9","diff_url":"https://github.com/keflavich/macvim-skim/pull/9.diff","patch_url":"https://github.com/keflavich/macvim-skim/pull/9.patch","issue_url":"https://api.github.com/repos/keflavich/macvim-skim/issues/9","number":9,"state":"closed","locked":false,"title":"Switched to buffer and localleader","user":{"login":"tbelaire","id":427239,"avatar_url":"https://avatars.githubusercontent.com/u/427239?v=3","gravatar_id":"","url":"https://api.github.com/users/tbelaire","html_url":"https://github.com/tbelaire","followers_url":"https://api.github.com/users/tbelaire/followers","following_url":"https://api.github.com/users/tbelaire/following{/other_user}","gists_url":"https://api.github.com/users/tbelaire/gists{/gist_id}","starred_url":"https://api.github.com/users/tbelaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbelaire/subscriptions","organizations_url":"https://api.github.com/users/tbelaire/orgs","repos_url":"https://api.github.com/users/tbelaire/repos","events_url":"https://api.github.com/users/tbelaire/events{/privacy}","received_events_url":"https://api.github.com/users/tbelaire/received_events","type":"User","site_admin":false},"body":"I switched to using nnoremap,\r\nand only defining the commands for the current buffer.\r\n\r\nSince ftplugins are only run once you know that the filetype\r\nis tex, go ahead an define the mappings unconditionally,\r\nbut use `<buffer>` so that they only get loaded for the current (tex)\r\nbuffer, not all open buffers.\r\n\r\nAlso, this is a filetype specific command, so it makes sense\r\nto use `<localleader>` (which I have mapped to `,` anyways),\r\nso now people who remap local leader are happy too.\r\n\r\nAlso, I split the commands up by line, that should\r\nmake it easier to see what's going on.  It also\r\nhighlights some of the redundancy, perhaps there should\r\nbe a function defined?\r\n\r\nThis branch also includes the exists check I fixed earlier, since I couldn't load the plugin at all with that constantly crashing.  Maybe resolve that pull request first.","created_at":"2015-11-28T16:21:49Z","updated_at":"2015-11-28T16:24:14Z","closed_at":"2015-11-28T16:24:13Z","merged_at":null,"merge_commit_sha":"6b436a644dedae0c632b3c151c7ebd9bfcebb958","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/keflavich/macvim-skim/pulls/9/commits","review_comments_url":"https://api.github.com/repos/keflavich/macvim-skim/pulls/9/comments","review_comment_url":"https://api.github.com/repos/keflavich/macvim-skim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keflavich/macvim-skim/issues/9/comments","statuses_url":"https://api.github.com/repos/keflavich/macvim-skim/statuses/2f5173a6f92d671167546abc5970922627a813ac","head":{"label":"tbelaire:master","ref":"master","sha":"2f5173a6f92d671167546abc5970922627a813ac","user":{"login":"tbelaire","id":427239,"avatar_url":"https://avatars.githubusercontent.com/u/427239?v=3","gravatar_id":"","url":"https://api.github.com/users/tbelaire","html_url":"https://github.com/tbelaire","followers_url":"https://api.github.com/users/tbelaire/followers","following_url":"https://api.github.com/users/tbelaire/following{/other_user}","gists_url":"https://api.github.com/users/tbelaire/gists{/gist_id}","starred_url":"https://api.github.com/users/tbelaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbelaire/subscriptions","organizations_url":"https://api.github.com/users/tbelaire/orgs","repos_url":"https://api.github.com/users/tbelaire/repos","events_url":"https://api.github.com/users/tbelaire/events{/privacy}","received_events_url":"https://api.github.com/users/tbelaire/received_events","type":"User","site_admin":false},"repo":{"id":47027501,"name":"macvim-skim","full_name":"tbelaire/macvim-skim","owner":{"login":"tbelaire","id":427239,"avatar_url":"https://avatars.githubusercontent.com/u/427239?v=3","gravatar_id":"","url":"https://api.github.com/users/tbelaire","html_url":"https://github.com/tbelaire","followers_url":"https://api.github.com/users/tbelaire/followers","following_url":"https://api.github.com/users/tbelaire/following{/other_user}","gists_url":"https://api.github.com/users/tbelaire/gists{/gist_id}","starred_url":"https://api.github.com/users/tbelaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbelaire/subscriptions","organizations_url":"https://api.github.com/users/tbelaire/orgs","repos_url":"https://api.github.com/users/tbelaire/repos","events_url":"https://api.github.com/users/tbelaire/events{/privacy}","received_events_url":"https://api.github.com/users/tbelaire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbelaire/macvim-skim","description":"Interlink macvim & skim for an integrated LaTeX DE","fork":true,"url":"https://api.github.com/repos/tbelaire/macvim-skim","forks_url":"https://api.github.com/repos/tbelaire/macvim-skim/forks","keys_url":"https://api.github.com/repos/tbelaire/macvim-skim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbelaire/macvim-skim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbelaire/macvim-skim/teams","hooks_url":"https://api.github.com/repos/tbelaire/macvim-skim/hooks","issue_events_url":"https://api.github.com/repos/tbelaire/macvim-skim/issues/events{/number}","events_url":"https://api.github.com/repos/tbelaire/macvim-skim/events","assignees_url":"https://api.github.com/repos/tbelaire/macvim-skim/assignees{/user}","branches_url":"https://api.github.com/repos/tbelaire/macvim-skim/branches{/branch}","tags_url":"https://api.github.com/repos/tbelaire/macvim-skim/tags","blobs_url":"https://api.github.com/repos/tbelaire/macvim-skim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbelaire/macvim-skim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbelaire/macvim-skim/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbelaire/macvim-skim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbelaire/macvim-skim/statuses/{sha}","languages_url":"https://api.github.com/repos/tbelaire/macvim-skim/languages","stargazers_url":"https://api.github.com/repos/tbelaire/macvim-skim/stargazers","contributors_url":"https://api.github.com/repos/tbelaire/macvim-skim/contributors","subscribers_url":"https://api.github.com/repos/tbelaire/macvim-skim/subscribers","subscription_url":"https://api.github.com/repos/tbelaire/macvim-skim/subscription","commits_url":"https://api.github.com/repos/tbelaire/macvim-skim/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbelaire/macvim-skim/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbelaire/macvim-skim/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbelaire/macvim-skim/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbelaire/macvim-skim/contents/{+path}","compare_url":"https://api.github.com/repos/tbelaire/macvim-skim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbelaire/macvim-skim/merges","archive_url":"https://api.github.com/repos/tbelaire/macvim-skim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbelaire/macvim-skim/downloads","issues_url":"https://api.github.com/repos/tbelaire/macvim-skim/issues{/number}","pulls_url":"https://api.github.com/repos/tbelaire/macvim-skim/pulls{/number}","milestones_url":"https://api.github.com/repos/tbelaire/macvim-skim/milestones{/number}","notifications_url":"https://api.github.com/repos/tbelaire/macvim-skim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbelaire/macvim-skim/labels{/name}","releases_url":"https://api.github.com/repos/tbelaire/macvim-skim/releases{/id}","created_at":"2015-11-28T14:56:52Z","updated_at":"2015-11-28T14:56:53Z","pushed_at":"2015-11-28T16:22:34Z","git_url":"git://github.com/tbelaire/macvim-skim.git","ssh_url":"git@github.com:tbelaire/macvim-skim.git","clone_url":"https://github.com/tbelaire/macvim-skim.git","svn_url":"https://github.com/tbelaire/macvim-skim","homepage":null,"size":210,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keflavich:master","ref":"master","sha":"00540a8e21e7e70e4c1679e0b4f38ec25c79cb2d","user":{"login":"keflavich","id":143715,"avatar_url":"https://avatars.githubusercontent.com/u/143715?v=3","gravatar_id":"","url":"https://api.github.com/users/keflavich","html_url":"https://github.com/keflavich","followers_url":"https://api.github.com/users/keflavich/followers","following_url":"https://api.github.com/users/keflavich/following{/other_user}","gists_url":"https://api.github.com/users/keflavich/gists{/gist_id}","starred_url":"https://api.github.com/users/keflavich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keflavich/subscriptions","organizations_url":"https://api.github.com/users/keflavich/orgs","repos_url":"https://api.github.com/users/keflavich/repos","events_url":"https://api.github.com/users/keflavich/events{/privacy}","received_events_url":"https://api.github.com/users/keflavich/received_events","type":"User","site_admin":false},"repo":{"id":7723937,"name":"macvim-skim","full_name":"keflavich/macvim-skim","owner":{"login":"keflavich","id":143715,"avatar_url":"https://avatars.githubusercontent.com/u/143715?v=3","gravatar_id":"","url":"https://api.github.com/users/keflavich","html_url":"https://github.com/keflavich","followers_url":"https://api.github.com/users/keflavich/followers","following_url":"https://api.github.com/users/keflavich/following{/other_user}","gists_url":"https://api.github.com/users/keflavich/gists{/gist_id}","starred_url":"https://api.github.com/users/keflavich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keflavich/subscriptions","organizations_url":"https://api.github.com/users/keflavich/orgs","repos_url":"https://api.github.com/users/keflavich/repos","events_url":"https://api.github.com/users/keflavich/events{/privacy}","received_events_url":"https://api.github.com/users/keflavich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keflavich/macvim-skim","description":"Interlink macvim & skim for an integrated LaTeX DE","fork":false,"url":"https://api.github.com/repos/keflavich/macvim-skim","forks_url":"https://api.github.com/repos/keflavich/macvim-skim/forks","keys_url":"https://api.github.com/repos/keflavich/macvim-skim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keflavich/macvim-skim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keflavich/macvim-skim/teams","hooks_url":"https://api.github.com/repos/keflavich/macvim-skim/hooks","issue_events_url":"https://api.github.com/repos/keflavich/macvim-skim/issues/events{/number}","events_url":"https://api.github.com/repos/keflavich/macvim-skim/events","assignees_url":"https://api.github.com/repos/keflavich/macvim-skim/assignees{/user}","branches_url":"https://api.github.com/repos/keflavich/macvim-skim/branches{/branch}","tags_url":"https://api.github.com/repos/keflavich/macvim-skim/tags","blobs_url":"https://api.github.com/repos/keflavich/macvim-skim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keflavich/macvim-skim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keflavich/macvim-skim/git/refs{/sha}","trees_url":"https://api.github.com/repos/keflavich/macvim-skim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keflavich/macvim-skim/statuses/{sha}","languages_url":"https://api.github.com/repos/keflavich/macvim-skim/languages","stargazers_url":"https://api.github.com/repos/keflavich/macvim-skim/stargazers","contributors_url":"https://api.github.com/repos/keflavich/macvim-skim/contributors","subscribers_url":"https://api.github.com/repos/keflavich/macvim-skim/subscribers","subscription_url":"https://api.github.com/repos/keflavich/macvim-skim/subscription","commits_url":"https://api.github.com/repos/keflavich/macvim-skim/commits{/sha}","git_commits_url":"https://api.github.com/repos/keflavich/macvim-skim/git/commits{/sha}","comments_url":"https://api.github.com/repos/keflavich/macvim-skim/comments{/number}","issue_comment_url":"https://api.github.com/repos/keflavich/macvim-skim/issues/comments{/number}","contents_url":"https://api.github.com/repos/keflavich/macvim-skim/contents/{+path}","compare_url":"https://api.github.com/repos/keflavich/macvim-skim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keflavich/macvim-skim/merges","archive_url":"https://api.github.com/repos/keflavich/macvim-skim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keflavich/macvim-skim/downloads","issues_url":"https://api.github.com/repos/keflavich/macvim-skim/issues{/number}","pulls_url":"https://api.github.com/repos/keflavich/macvim-skim/pulls{/number}","milestones_url":"https://api.github.com/repos/keflavich/macvim-skim/milestones{/number}","notifications_url":"https://api.github.com/repos/keflavich/macvim-skim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keflavich/macvim-skim/labels{/name}","releases_url":"https://api.github.com/repos/keflavich/macvim-skim/releases{/id}","created_at":"2013-01-21T00:26:12Z","updated_at":"2015-06-23T05:45:28Z","pushed_at":"2015-11-28T16:21:49Z","git_url":"git://github.com/keflavich/macvim-skim.git","ssh_url":"git@github.com:keflavich/macvim-skim.git","clone_url":"https://github.com/keflavich/macvim-skim.git","svn_url":"https://github.com/keflavich/macvim-skim","homepage":null,"size":357,"stargazers_count":9,"watchers_count":9,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keflavich/macvim-skim/pulls/9"},"html":{"href":"https://github.com/keflavich/macvim-skim/pull/9"},"issue":{"href":"https://api.github.com/repos/keflavich/macvim-skim/issues/9"},"comments":{"href":"https://api.github.com/repos/keflavich/macvim-skim/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/keflavich/macvim-skim/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/keflavich/macvim-skim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keflavich/macvim-skim/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/keflavich/macvim-skim/statuses/2f5173a6f92d671167546abc5970922627a813ac"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":37,"deletions":7,"changed_files":1}}