{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid-api/pulls/comments/26680194","id":26680194,"diff_hunk":"@@ -0,0 +1,46 @@\n+/*\n+ * Copyright 2015 Metamarkets Group, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package io.druid.segment.loading;\n+\n+import com.fasterxml.jackson.annotation.JsonTypeInfo;\n+\n+import java.io.File;\n+\n+/**\n+ * A means of pulling segment files into a destination directory\n+ */\n+@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, property = \"type\")\n+public interface LoadSpec","path":"src/main/java/io/druid/segment/loading/LoadSpec.java","position":27,"original_position":27,"commit_id":"1e2d8069911f61930f094603f9057c2bae8843c0","original_commit_id":"1e2d8069911f61930f094603f9057c2bae8843c0","user":{"login":"fjy","id":428325,"avatar_url":"https://avatars.githubusercontent.com/u/428325?v=3","gravatar_id":"","url":"https://api.github.com/users/fjy","html_url":"https://github.com/fjy","followers_url":"https://api.github.com/users/fjy/followers","following_url":"https://api.github.com/users/fjy/following{/other_user}","gists_url":"https://api.github.com/users/fjy/gists{/gist_id}","starred_url":"https://api.github.com/users/fjy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjy/subscriptions","organizations_url":"https://api.github.com/users/fjy/orgs","repos_url":"https://api.github.com/users/fjy/repos","events_url":"https://api.github.com/users/fjy/events{/privacy}","received_events_url":"https://api.github.com/users/fjy/received_events","type":"User","site_admin":false},"body":"are there any jsonsubtypes here for serde?","created_at":"2015-03-18T16:29:47Z","updated_at":"2015-03-18T16:29:47Z","html_url":"https://github.com/druid-io/druid-api/pull/37#discussion_r26680194","pull_request_url":"https://api.github.com/repos/druid-io/druid-api/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/comments/26680194"},"html":{"href":"https://github.com/druid-io/druid-api/pull/37#discussion_r26680194"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid-api/pulls/37","id":29491895,"html_url":"https://github.com/druid-io/druid-api/pull/37","diff_url":"https://github.com/druid-io/druid-api/pull/37.diff","patch_url":"https://github.com/druid-io/druid-api/pull/37.patch","issue_url":"https://api.github.com/repos/druid-io/druid-api/issues/37","number":37,"state":"open","locked":false,"title":"Add URI Handlers and LoadSpec","user":{"login":"drcrallen","id":8213081,"avatar_url":"https://avatars.githubusercontent.com/u/8213081?v=3","gravatar_id":"","url":"https://api.github.com/users/drcrallen","html_url":"https://github.com/drcrallen","followers_url":"https://api.github.com/users/drcrallen/followers","following_url":"https://api.github.com/users/drcrallen/following{/other_user}","gists_url":"https://api.github.com/users/drcrallen/gists{/gist_id}","starred_url":"https://api.github.com/users/drcrallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcrallen/subscriptions","organizations_url":"https://api.github.com/users/drcrallen/orgs","repos_url":"https://api.github.com/users/drcrallen/repos","events_url":"https://api.github.com/users/drcrallen/events{/privacy}","received_events_url":"https://api.github.com/users/drcrallen/received_events","type":"User","site_admin":false},"body":"This adds more generic methods of fetching data segments by passing in a URI instead of a more complex data object. I also have a patch incoming to Druid that implements this update.\r\n\r\nAlso adds a `LoadSpec` to help solidify the loading of segment data.","created_at":"2015-02-18T00:35:52Z","updated_at":"2015-03-18T16:29:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2beb09fee19234467a21d5a9e8f43b1e3a8051d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/druid-api/pulls/37/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid-api/pulls/37/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid-api/issues/37/comments","statuses_url":"https://api.github.com/repos/druid-io/druid-api/statuses/1e2d8069911f61930f094603f9057c2bae8843c0","head":{"label":"drcrallen:dataSegmentURIHandlers","ref":"dataSegmentURIHandlers","sha":"1e2d8069911f61930f094603f9057c2bae8843c0","user":{"login":"drcrallen","id":8213081,"avatar_url":"https://avatars.githubusercontent.com/u/8213081?v=3","gravatar_id":"","url":"https://api.github.com/users/drcrallen","html_url":"https://github.com/drcrallen","followers_url":"https://api.github.com/users/drcrallen/followers","following_url":"https://api.github.com/users/drcrallen/following{/other_user}","gists_url":"https://api.github.com/users/drcrallen/gists{/gist_id}","starred_url":"https://api.github.com/users/drcrallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcrallen/subscriptions","organizations_url":"https://api.github.com/users/drcrallen/orgs","repos_url":"https://api.github.com/users/drcrallen/repos","events_url":"https://api.github.com/users/drcrallen/events{/privacy}","received_events_url":"https://api.github.com/users/drcrallen/received_events","type":"User","site_admin":false},"repo":{"id":28974818,"name":"druid-api","full_name":"drcrallen/druid-api","owner":{"login":"drcrallen","id":8213081,"avatar_url":"https://avatars.githubusercontent.com/u/8213081?v=3","gravatar_id":"","url":"https://api.github.com/users/drcrallen","html_url":"https://github.com/drcrallen","followers_url":"https://api.github.com/users/drcrallen/followers","following_url":"https://api.github.com/users/drcrallen/following{/other_user}","gists_url":"https://api.github.com/users/drcrallen/gists{/gist_id}","starred_url":"https://api.github.com/users/drcrallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcrallen/subscriptions","organizations_url":"https://api.github.com/users/drcrallen/orgs","repos_url":"https://api.github.com/users/drcrallen/repos","events_url":"https://api.github.com/users/drcrallen/events{/privacy}","received_events_url":"https://api.github.com/users/drcrallen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drcrallen/druid-api","description":"A repository for the Druid API.  This is a separate library that defines the APIs for Druid extensibility ","fork":true,"url":"https://api.github.com/repos/drcrallen/druid-api","forks_url":"https://api.github.com/repos/drcrallen/druid-api/forks","keys_url":"https://api.github.com/repos/drcrallen/druid-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drcrallen/druid-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drcrallen/druid-api/teams","hooks_url":"https://api.github.com/repos/drcrallen/druid-api/hooks","issue_events_url":"https://api.github.com/repos/drcrallen/druid-api/issues/events{/number}","events_url":"https://api.github.com/repos/drcrallen/druid-api/events","assignees_url":"https://api.github.com/repos/drcrallen/druid-api/assignees{/user}","branches_url":"https://api.github.com/repos/drcrallen/druid-api/branches{/branch}","tags_url":"https://api.github.com/repos/drcrallen/druid-api/tags","blobs_url":"https://api.github.com/repos/drcrallen/druid-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drcrallen/druid-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drcrallen/druid-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/drcrallen/druid-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drcrallen/druid-api/statuses/{sha}","languages_url":"https://api.github.com/repos/drcrallen/druid-api/languages","stargazers_url":"https://api.github.com/repos/drcrallen/druid-api/stargazers","contributors_url":"https://api.github.com/repos/drcrallen/druid-api/contributors","subscribers_url":"https://api.github.com/repos/drcrallen/druid-api/subscribers","subscription_url":"https://api.github.com/repos/drcrallen/druid-api/subscription","commits_url":"https://api.github.com/repos/drcrallen/druid-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/drcrallen/druid-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/drcrallen/druid-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/drcrallen/druid-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/drcrallen/druid-api/contents/{+path}","compare_url":"https://api.github.com/repos/drcrallen/druid-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drcrallen/druid-api/merges","archive_url":"https://api.github.com/repos/drcrallen/druid-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drcrallen/druid-api/downloads","issues_url":"https://api.github.com/repos/drcrallen/druid-api/issues{/number}","pulls_url":"https://api.github.com/repos/drcrallen/druid-api/pulls{/number}","milestones_url":"https://api.github.com/repos/drcrallen/druid-api/milestones{/number}","notifications_url":"https://api.github.com/repos/drcrallen/druid-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drcrallen/druid-api/labels{/name}","releases_url":"https://api.github.com/repos/drcrallen/druid-api/releases{/id}","created_at":"2015-01-08T16:31:19Z","updated_at":"2015-01-08T16:31:19Z","pushed_at":"2015-03-16T19:34:38Z","git_url":"git://github.com/drcrallen/druid-api.git","ssh_url":"git@github.com:drcrallen/druid-api.git","clone_url":"https://github.com/drcrallen/druid-api.git","svn_url":"https://github.com/drcrallen/druid-api","homepage":null,"size":395,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"7a63e601955f80826b6bfdb02631b8b641e8ee0b","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":12418525,"name":"druid-api","full_name":"druid-io/druid-api","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid-api","description":"A repository for the Druid API.  This is a separate library that defines the APIs for Druid extensibility ","fork":false,"url":"https://api.github.com/repos/druid-io/druid-api","forks_url":"https://api.github.com/repos/druid-io/druid-api/forks","keys_url":"https://api.github.com/repos/druid-io/druid-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid-api/teams","hooks_url":"https://api.github.com/repos/druid-io/druid-api/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid-api/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid-api/events","assignees_url":"https://api.github.com/repos/druid-io/druid-api/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid-api/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid-api/tags","blobs_url":"https://api.github.com/repos/druid-io/druid-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid-api/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid-api/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid-api/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid-api/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid-api/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid-api/subscription","commits_url":"https://api.github.com/repos/druid-io/druid-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid-api/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid-api/merges","archive_url":"https://api.github.com/repos/druid-io/druid-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid-api/downloads","issues_url":"https://api.github.com/repos/druid-io/druid-api/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid-api/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid-api/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid-api/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid-api/releases{/id}","created_at":"2013-08-27T21:58:45Z","updated_at":"2015-03-05T22:22:17Z","pushed_at":"2015-03-05T22:22:17Z","git_url":"git://github.com/druid-io/druid-api.git","ssh_url":"git@github.com:druid-io/druid-api.git","clone_url":"https://github.com/druid-io/druid-api.git","svn_url":"https://github.com/druid-io/druid-api","homepage":null,"size":1680,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":5,"forks":17,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/37"},"html":{"href":"https://github.com/druid-io/druid-api/pull/37"},"issue":{"href":"https://api.github.com/repos/druid-io/druid-api/issues/37"},"comments":{"href":"https://api.github.com/repos/druid-io/druid-api/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid-api/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid-api/statuses/1e2d8069911f61930f094603f9057c2bae8843c0"}}}}