{"action":"created","issue":{"url":"https://api.github.com/repos/jquery/api.jqueryui.com/issues/257","labels_url":"https://api.github.com/repos/jquery/api.jqueryui.com/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/jquery/api.jqueryui.com/issues/257/comments","events_url":"https://api.github.com/repos/jquery/api.jqueryui.com/issues/257/events","html_url":"https://github.com/jquery/api.jqueryui.com/pull/257","id":63028142,"number":257,"title":"All: Document classes option [WIP]","user":{"login":"jzaefferer","id":52585,"avatar_url":"https://avatars.githubusercontent.com/u/52585?v=3","gravatar_id":"","url":"https://api.github.com/users/jzaefferer","html_url":"https://github.com/jzaefferer","followers_url":"https://api.github.com/users/jzaefferer/followers","following_url":"https://api.github.com/users/jzaefferer/following{/other_user}","gists_url":"https://api.github.com/users/jzaefferer/gists{/gist_id}","starred_url":"https://api.github.com/users/jzaefferer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzaefferer/subscriptions","organizations_url":"https://api.github.com/users/jzaefferer/orgs","repos_url":"https://api.github.com/users/jzaefferer/repos","events_url":"https://api.github.com/users/jzaefferer/events{/privacy}","received_events_url":"https://api.github.com/users/jzaefferer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jquery/api.jqueryui.com/labels/CLA:%20Valid","name":"CLA: Valid","color":"007700"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-03-19T16:19:25Z","updated_at":"2015-04-15T21:04:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jquery/api.jqueryui.com/pulls/257","html_url":"https://github.com/jquery/api.jqueryui.com/pull/257","diff_url":"https://github.com/jquery/api.jqueryui.com/pull/257.diff","patch_url":"https://github.com/jquery/api.jqueryui.com/pull/257.patch"},"body":"This document the default `classes` option and the `_addClass` method on `$.Widget`, and the `classes` option on accordion and draggable. There's a bunch of issues that need to be addressed. I'm including screenshots here to make previewing easier.\r\n\r\n### `classes` option on $.Widget:\r\n\r\n![...](http://bassistance.de/i/fc4b6f.png)\r\n\r\nOkay, but not very useful. Looking for suggestions how to improve this.\r\n\r\n### `_addClass` method:\r\n\r\n![...](http://bassistance.de/i/4494a6.png)\r\n\r\n* Apparently `<method>` only supports a single `<example>` element, so the three descriptions are all mashed together, same for the code snippets. I think having multiple examples here is important enough to justify a change to grunt-jquery-content.\r\n* Multiple descriptions are rather bad, like \"The element to add the classes to\". Looking for suggestions for improving these.\r\n* I could make the reference to the `classes` option a link, but since that references this method, we end up with circular references without adding any value. Ignore?\r\n\r\n### Accordion `classes` option:\r\n\r\n![...](http://bassistance.de/i/ef918b.png)\r\n\r\n* The `Default` has to be specified as an attribute, so it can't be formatted properly, so it looks really bad. Only alternative I can think of is to put the default into the `<desc>` element.\r\n* Is the description okay? If not, suggestions for improving it?\r\n* I've used a value of `null` for the example. I'm not sure if that is a good idea. See below for what I've used for draggable.\r\n\r\n### Draggable `classes` option:\r\n\r\n![...](http://bassistance.de/i/b806f2.png)\r\n\r\n* The default value isn't quite as bad as for accordion, but still wraps over multiple lines.\r\n* Same description as for accordion - can/should we somehow share that?\r\n* In the example I'm pretending to add an extra class to the \"draggable-handle\". Is that good enough?\r\n\r\n---\r\n\r\nOnce these issues are addressed, I can add the docs for `_removeClass`, `_toggleClass` and the remaining widgets."},"comment":{"url":"https://api.github.com/repos/jquery/api.jqueryui.com/issues/comments/93568873","html_url":"https://github.com/jquery/api.jqueryui.com/pull/257#issuecomment-93568873","issue_url":"https://api.github.com/repos/jquery/api.jqueryui.com/issues/257","id":93568873,"user":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=3","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"created_at":"2015-04-15T21:04:08Z","updated_at":"2015-04-15T21:04:08Z","body":"I just finished reviewing again as well and everything looks good to me. "}}