{"action":"created","issue":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/712","labels_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/712/labels{/name}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/712/comments","events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/712/events","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/712","id":91360414,"number":712,"title":"minor fixes","user":{"login":"martinpopel","id":724617,"avatar_url":"https://avatars.githubusercontent.com/u/724617?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpopel","html_url":"https://github.com/martinpopel","followers_url":"https://api.github.com/users/martinpopel/followers","following_url":"https://api.github.com/users/martinpopel/following{/other_user}","gists_url":"https://api.github.com/users/martinpopel/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpopel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpopel/subscriptions","organizations_url":"https://api.github.com/users/martinpopel/orgs","repos_url":"https://api.github.com/users/martinpopel/repos","events_url":"https://api.github.com/users/martinpopel/events{/privacy}","received_events_url":"https://api.github.com/users/martinpopel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-26T20:56:13Z","updated_at":"2015-06-27T00:52:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/712","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/712","diff_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/712.diff","patch_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/712.patch"},"body":"* print a newline after each fatal error\r\n* fix compile-time warnings\r\n* fix an edge case of one-char dictionary filenames (`--dictionary n:f`)"},"comment":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/comments/115927565","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/712#issuecomment-115927565","issue_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/712","id":115927565,"user":{"login":"JohnLangford","id":79590,"avatar_url":"https://avatars.githubusercontent.com/u/79590?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"created_at":"2015-06-27T00:52:27Z","updated_at":"2015-06-27T00:52:27Z","body":"I did the change to parse_args.cc and added the <<endl to main.cc by \nhand.  I believe (?) the order of arguments in the constructor doesn't \nseem to matter so long as it agrees with the order of the declaration, \nas it does in the master branch.\n\nI'm feeling cautious about github at the moment---some sort of skew \nmight(?) be happening with tests.\n\n-John\n\nOn 06/26/2015 07:23 PM, Markus Cozowicz wrote:\n> I merged upstream and added that missing attributes. My appveyor build \n> runs through: \n> https://ci.appveyor.com/project/eisber/vowpal-wabbit/build/1.0.102\n>\n> I’m waiting for the appveyor build on the PR to finish.\n>\n> From: John [mailto:notifications@github.com]\n> Sent: Friday, June 26, 2015 7:04 PM\n> To: JohnLangford/vowpal_wabbit\n> Cc: Markus Cozowicz\n> Subject: Re: [vowpal_wabbit] minor fixes (#712)\n>\n> Appveyor appears to be failing for the master, unclear why. It looks\n> like it's failing somewhere in the test cases that Markus setup.\n>\n> The reorder warning was something that I thought (?) I fixed earlier\n> today. I just checked, and indeed it seems that I have no such warning\n> locally. Anyways, getting rid of warnings on all platforms is desirable.\n>\n> Adding the newline later does seem reasonable.\n>\n> -John\n>\n> On 06/26/2015 06:22 PM, Martin Popel wrote:\n> >\n> > @eisber <https://github.com/eisber> I have no idea why AppVeynor\n> > fails. I just wanted to fix the distracting warning\n> > https://travis-ci.org/JohnLangford/vowpal_wabbit/builds/68346697#L1037\n> >\n> > —\n> > Reply to this email directly or view it on GitHub\n> > \n> <https://github.com/JohnLangford/vowpal_wabbit/pull/712#issuecomment-115907839>.\n> >\n>\n>\n>\n> —\n> Reply to this email directly or view it on \n> GitHub<https://github.com/JohnLangford/vowpal_wabbit/pull/712#issuecomment-115913047>.\n>\n> —\n> Reply to this email directly or view it on GitHub \n> <https://github.com/JohnLangford/vowpal_wabbit/pull/712#issuecomment-115916186>.\n>\n\n"}}