{"action":"closed","issue":{"url":"https://api.github.com/repos/CaseCommonsDevOps/cc_cookbook_template/issues/1","labels_url":"https://api.github.com/repos/CaseCommonsDevOps/cc_cookbook_template/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/CaseCommonsDevOps/cc_cookbook_template/issues/1/comments","events_url":"https://api.github.com/repos/CaseCommonsDevOps/cc_cookbook_template/issues/1/events","html_url":"https://github.com/CaseCommonsDevOps/cc_cookbook_template/issues/1","id":18068629,"number":1,"title":"Quick Review","user":{"login":"sethvargo","id":408570,"avatar_url":"https://avatars.githubusercontent.com/u/408570?v=3","gravatar_id":"","url":"https://api.github.com/users/sethvargo","html_url":"https://github.com/sethvargo","followers_url":"https://api.github.com/users/sethvargo/followers","following_url":"https://api.github.com/users/sethvargo/following{/other_user}","gists_url":"https://api.github.com/users/sethvargo/gists{/gist_id}","starred_url":"https://api.github.com/users/sethvargo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethvargo/subscriptions","organizations_url":"https://api.github.com/users/sethvargo/orgs","repos_url":"https://api.github.com/users/sethvargo/repos","events_url":"https://api.github.com/users/sethvargo/events{/privacy}","received_events_url":"https://api.github.com/users/sethvargo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"pemacc","id":4181368,"avatar_url":"https://avatars.githubusercontent.com/u/4181368?v=3","gravatar_id":"","url":"https://api.github.com/users/pemacc","html_url":"https://github.com/pemacc","followers_url":"https://api.github.com/users/pemacc/followers","following_url":"https://api.github.com/users/pemacc/following{/other_user}","gists_url":"https://api.github.com/users/pemacc/gists{/gist_id}","starred_url":"https://api.github.com/users/pemacc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pemacc/subscriptions","organizations_url":"https://api.github.com/users/pemacc/orgs","repos_url":"https://api.github.com/users/pemacc/repos","events_url":"https://api.github.com/users/pemacc/events{/privacy}","received_events_url":"https://api.github.com/users/pemacc/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2013-08-14T18:33:01Z","updated_at":"2015-01-12T17:51:03Z","closed_at":"2015-01-12T17:51:03Z","body":"Hey guys and gals,\r\n\r\nAlex asked me to do a quick review of this. I figured a GitHub issue was the best place :smile:\r\n\r\n- [x] When creating `Gemfile`s and `Berksfile`s, you should always apply at least a pessimistic lock. This will ensure your CI doesn't \"just break\" after a new version of a development tool is released. Ideally you want to slowly implement that new release in your organization.\r\n\r\n  ```ruby\r\n  gem 'berkshelf', '~> 2.0'\r\n  gem 'foodcritic', '~> 2.2'\r\n  ```\r\n\r\n- [x] Typo in README: `metadat.rb`\r\n- [ ] Docs on [Semantic Versioning](http://semver.org)\r\n- [x] Docs for running strainer (`bundle exec strainer test`)\r\n- [ ] Travis CI support (may be out of scope, but...)\r\n\r\n  ```yaml\r\n  # .travis.yml\r\n  rvm:\r\n    - 1.9.3\r\n    - 2.0.0\r\n  script: bundle exec strainer test --without kitchen\r\n  ```\r\n\r\n- [x] Use bundler Gemfile group blocks:\r\n\r\n  ```ruby\r\n  group :integration do\r\n    gem 'test-kitchen', '~> 1.0.0.beta'\r\n    gem 'kitchen-vagrant', '~> 0.11'\r\n  end\r\n  ```\r\n\r\n- [x] `metadata` should always be declared first in your `Berksfile`:\r\n\r\n  ```ruby\r\n  site :opscode\r\n  metadata\r\n\r\n  # other stuff\r\n  ```\r\n\r\n- [x] There seem to be conflicting testing tools in here. I see Minitest Chef Handler skeleton code, but that's not necessary if you're using Test Kitchen. I'm also not sure what ServerSpec is testing, given Test Kitchen and ChefSpec."}}