{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/5585","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5585/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5585/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5585/events","html_url":"https://github.com/mozilla/pdf.js/pull/5585","id":52872002,"number":5585,"title":"Annotation border styles","user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/4-annotations","name":"4-annotations","color":"DDDDDD"}],"state":"open","locked":false,"assignee":{"login":"brendandahl","id":942640,"avatar_url":"https://avatars.githubusercontent.com/u/942640?v=3","gravatar_id":"","url":"https://api.github.com/users/brendandahl","html_url":"https://github.com/brendandahl","followers_url":"https://api.github.com/users/brendandahl/followers","following_url":"https://api.github.com/users/brendandahl/following{/other_user}","gists_url":"https://api.github.com/users/brendandahl/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandahl/subscriptions","organizations_url":"https://api.github.com/users/brendandahl/orgs","repos_url":"https://api.github.com/users/brendandahl/repos","events_url":"https://api.github.com/users/brendandahl/events{/privacy}","received_events_url":"https://api.github.com/users/brendandahl/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2014-12-25T20:42:28Z","updated_at":"2015-06-17T20:00:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/5585","html_url":"https://github.com/mozilla/pdf.js/pull/5585","diff_url":"https://github.com/mozilla/pdf.js/pull/5585.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/5585.patch"},"body":"This PR implements annotation border styles according to the official PDF specification at https://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/pdf_reference_1-7.pdf, section 8.4.3.\r\n\r\nMost of the code is rewriting the old code, but there are some minor additions in order to adhere better to the specification. These are:\r\n\r\n- Support for horizontal and vertical corner radii (just a few lines of code)\r\n- Support for dashed and underline border styles (two lines of code in `annotation_helper.js`); this improves all ArXiv PDFs such as http://www.cs.columbia.edu/~djhsu/papers/ilovetoconbandits-arxiv.pdf (dashed border on the left) and fixes #5694 (underline at the top)\r\n\r\nUnimplemented border styles have been indicated using `warn()` so it is clear that these are missing (and there are barely used in PDFs on the web). I have added documentation and unit/regression tests to increase testability of the annotation layer and to avoid regressions."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/112928930","html_url":"https://github.com/mozilla/pdf.js/pull/5585#issuecomment-112928930","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/5585","id":112928930,"user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"created_at":"2015-06-17T20:00:10Z","updated_at":"2015-06-17T20:00:10Z","body":"/botio-linux preview"}}