{"action":"created","issue":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/11576","labels_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/11576/labels{/name}","comments_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/11576/comments","events_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/11576/events","html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/11576","id":111456710,"number":11576,"title":"index.php readability - HTML instead of php echo","user":{"login":"ryanfmurphy","id":115755,"avatar_url":"https://avatars.githubusercontent.com/u/115755?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanfmurphy","html_url":"https://github.com/ryanfmurphy","followers_url":"https://api.github.com/users/ryanfmurphy/followers","following_url":"https://api.github.com/users/ryanfmurphy/following{/other_user}","gists_url":"https://api.github.com/users/ryanfmurphy/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanfmurphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanfmurphy/subscriptions","organizations_url":"https://api.github.com/users/ryanfmurphy/orgs","repos_url":"https://api.github.com/users/ryanfmurphy/repos","events_url":"https://api.github.com/users/ryanfmurphy/events{/privacy}","received_events_url":"https://api.github.com/users/ryanfmurphy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-10-14T18:06:53Z","updated_at":"2015-10-15T13:22:20Z","closed_at":"2015-10-15T03:35:38Z","pull_request":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/pulls/11576","html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/11576","diff_url":"https://github.com/phpmyadmin/phpmyadmin/pull/11576.diff","patch_url":"https://github.com/phpmyadmin/phpmyadmin/pull/11576.patch"},"body":"Hey PhpMyAdmin devs!\r\n\r\nI make some changes to the index.php file that (I feel) makes the code much more readable.  Mostly just taking the HTML out of the echo statements so you can have syntax highlighting and easier-to-see indentation.\r\n\r\nNo worries if this is too big a change to merge, just learning the process and would love to help!\r\n\r\nBest,\r\nRyan"},"comment":{"url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/comments/148384302","html_url":"https://github.com/phpmyadmin/phpmyadmin/pull/11576#issuecomment-148384302","issue_url":"https://api.github.com/repos/phpmyadmin/phpmyadmin/issues/11576","id":148384302,"user":{"login":"ryanfmurphy","id":115755,"avatar_url":"https://avatars.githubusercontent.com/u/115755?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanfmurphy","html_url":"https://github.com/ryanfmurphy","followers_url":"https://api.github.com/users/ryanfmurphy/followers","following_url":"https://api.github.com/users/ryanfmurphy/following{/other_user}","gists_url":"https://api.github.com/users/ryanfmurphy/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanfmurphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanfmurphy/subscriptions","organizations_url":"https://api.github.com/users/ryanfmurphy/orgs","repos_url":"https://api.github.com/users/ryanfmurphy/repos","events_url":"https://api.github.com/users/ryanfmurphy/events{/privacy}","received_events_url":"https://api.github.com/users/ryanfmurphy/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T13:22:20Z","updated_at":"2015-10-15T13:22:20Z","body":"@zixtor - I totally agree that templates is the way to go -- but isn't this exactly how you migrate towards templates?  Your index file is fill of echoing HTML tags - if you take them out of the echo statements and into PHP's built-in templating system (which is what my patch does), then it becomes much easier to isolate all the data / non-templating functionality away from the presentational HTML stuff.\r\n\r\nThis is how I've always made that migration anyways, would be interested to hear how you guys are doing the migration if not in this way."}}