{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/33473859","id":33473859,"diff_hunk":"@@ -382,11 +382,14 @@ public void callAfterStoreListeners(Collection<DelayedEntry> entries) {\n         }\n         // retry occurred.\n         if (k > 0) {\n-            final String msg = String.format(\"Store operation failed and retries %s\",\n-                    result ? \"succeeded.\" : \"failed too.\");\n-            logger.warning(msg, throwable);\n             if (!result) {\n-                return task.failureList();\n+                // List of entries which can not be stored for this round. We will readd these entries\n+                // in front of the relevant partition-write-behind-queues and will indefinitely retry to\n+                // store them.\n+                List failureList = task.failureList();\n+                logger.severe(\"Number of entries which could not be stored is = [\" + failureList.size() + \"]\"\n+                        + \", Hazelcast will indefinitely retry to store them\", exception);","path":"hazelcast/src/main/java/com/hazelcast/map/impl/mapstore/writebehind/DefaultWriteBehindProcessor.java","position":31,"original_position":31,"commit_id":"5099653f1ca90f99fa7dad56b57d020967cde636","original_commit_id":"5099653f1ca90f99fa7dad56b57d020967cde636","user":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"body":"Do we need to add the word 'indefinitely' to the logging?","created_at":"2015-06-29T15:12:03Z","updated_at":"2015-06-29T15:12:03Z","html_url":"https://github.com/hazelcast/hazelcast/pull/5620#discussion_r33473859","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5620","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/33473859"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/5620#discussion_r33473859"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5620"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5620","id":38758118,"html_url":"https://github.com/hazelcast/hazelcast/pull/5620","diff_url":"https://github.com/hazelcast/hazelcast/pull/5620.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/5620.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/5620","number":5620,"state":"open","locked":false,"title":"Fixed out of memory handling in write-behind process","user":{"login":"ahmetmircik","id":2960360,"avatar_url":"https://avatars.githubusercontent.com/u/2960360?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetmircik","html_url":"https://github.com/ahmetmircik","followers_url":"https://api.github.com/users/ahmetmircik/followers","following_url":"https://api.github.com/users/ahmetmircik/following{/other_user}","gists_url":"https://api.github.com/users/ahmetmircik/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetmircik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetmircik/subscriptions","organizations_url":"https://api.github.com/users/ahmetmircik/orgs","repos_url":"https://api.github.com/users/ahmetmircik/repos","events_url":"https://api.github.com/users/ahmetmircik/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetmircik/received_events","type":"User","site_admin":false},"body":"Now it does not swallow OutOfMemoryError. Plus, changed log level of store failure from warning to error.\r\n\r\n","created_at":"2015-06-29T10:01:31Z","updated_at":"2015-06-29T15:12:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf33f969ef7a685b1c44b846874b5618c5ab5827","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.6","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61/labels","id":982584,"number":61,"title":"3.6","description":"","creator":{"login":"enesakar","id":234086,"avatar_url":"https://avatars.githubusercontent.com/u/234086?v=3","gravatar_id":"","url":"https://api.github.com/users/enesakar","html_url":"https://github.com/enesakar","followers_url":"https://api.github.com/users/enesakar/followers","following_url":"https://api.github.com/users/enesakar/following{/other_user}","gists_url":"https://api.github.com/users/enesakar/gists{/gist_id}","starred_url":"https://api.github.com/users/enesakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enesakar/subscriptions","organizations_url":"https://api.github.com/users/enesakar/orgs","repos_url":"https://api.github.com/users/enesakar/repos","events_url":"https://api.github.com/users/enesakar/events{/privacy}","received_events_url":"https://api.github.com/users/enesakar/received_events","type":"User","site_admin":false},"open_issues":123,"closed_issues":46,"state":"open","created_at":"2015-02-17T09:27:09Z","updated_at":"2015-06-29T14:31:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5620/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5620/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/5620/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/5099653f1ca90f99fa7dad56b57d020967cde636","head":{"label":"ahmetmircik:fix/3.6/OOMWriteBehind","ref":"fix/3.6/OOMWriteBehind","sha":"5099653f1ca90f99fa7dad56b57d020967cde636","user":{"login":"ahmetmircik","id":2960360,"avatar_url":"https://avatars.githubusercontent.com/u/2960360?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetmircik","html_url":"https://github.com/ahmetmircik","followers_url":"https://api.github.com/users/ahmetmircik/followers","following_url":"https://api.github.com/users/ahmetmircik/following{/other_user}","gists_url":"https://api.github.com/users/ahmetmircik/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetmircik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetmircik/subscriptions","organizations_url":"https://api.github.com/users/ahmetmircik/orgs","repos_url":"https://api.github.com/users/ahmetmircik/repos","events_url":"https://api.github.com/users/ahmetmircik/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetmircik/received_events","type":"User","site_admin":false},"repo":{"id":13222351,"name":"hazelcast","full_name":"ahmetmircik/hazelcast","owner":{"login":"ahmetmircik","id":2960360,"avatar_url":"https://avatars.githubusercontent.com/u/2960360?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetmircik","html_url":"https://github.com/ahmetmircik","followers_url":"https://api.github.com/users/ahmetmircik/followers","following_url":"https://api.github.com/users/ahmetmircik/following{/other_user}","gists_url":"https://api.github.com/users/ahmetmircik/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetmircik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetmircik/subscriptions","organizations_url":"https://api.github.com/users/ahmetmircik/orgs","repos_url":"https://api.github.com/users/ahmetmircik/repos","events_url":"https://api.github.com/users/ahmetmircik/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetmircik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmetmircik/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/ahmetmircik/hazelcast","forks_url":"https://api.github.com/repos/ahmetmircik/hazelcast/forks","keys_url":"https://api.github.com/repos/ahmetmircik/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmetmircik/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmetmircik/hazelcast/teams","hooks_url":"https://api.github.com/repos/ahmetmircik/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/ahmetmircik/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/ahmetmircik/hazelcast/events","assignees_url":"https://api.github.com/repos/ahmetmircik/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/ahmetmircik/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/ahmetmircik/hazelcast/tags","blobs_url":"https://api.github.com/repos/ahmetmircik/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmetmircik/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmetmircik/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmetmircik/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmetmircik/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmetmircik/hazelcast/languages","stargazers_url":"https://api.github.com/repos/ahmetmircik/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/ahmetmircik/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/ahmetmircik/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/ahmetmircik/hazelcast/subscription","commits_url":"https://api.github.com/repos/ahmetmircik/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmetmircik/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmetmircik/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmetmircik/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmetmircik/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/ahmetmircik/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmetmircik/hazelcast/merges","archive_url":"https://api.github.com/repos/ahmetmircik/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmetmircik/hazelcast/downloads","issues_url":"https://api.github.com/repos/ahmetmircik/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/ahmetmircik/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmetmircik/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmetmircik/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmetmircik/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/ahmetmircik/hazelcast/releases{/id}","created_at":"2013-09-30T17:48:20Z","updated_at":"2014-06-23T18:01:37Z","pushed_at":"2015-06-29T10:19:46Z","git_url":"git://github.com/ahmetmircik/hazelcast.git","ssh_url":"git@github.com:ahmetmircik/hazelcast.git","clone_url":"https://github.com/ahmetmircik/hazelcast.git","svn_url":"https://github.com/ahmetmircik/hazelcast","homepage":"www.hazelcast.com","size":75016,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"7d702d28962638500f485c1cbae69d3bc5a3481b","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-06-29T00:00:36Z","pushed_at":"2015-06-29T14:41:15Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":142754,"stargazers_count":1165,"watchers_count":1165,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":559,"mirror_url":null,"open_issues_count":454,"forks":559,"open_issues":454,"watchers":1165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5620"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/5620"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/5620"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/5620/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5620/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5620/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/5099653f1ca90f99fa7dad56b57d020967cde636"}}}}