{"action":"created","comment":{"url":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/comments/30023570","id":30023570,"diff_hunk":"@@ -89,6 +89,7 @@ module.exports = function(grunt) {\n \t\tconnect: {\n \t\t\tserver: {\n \t\t\t\toptions: {\n+\t\t\t\t\thostname: '0.0.0.0',","path":"Gruntfile.js","position":4,"original_position":4,"commit_id":"fafa1785139e7f33af040fcdcea10975bca19a57","original_commit_id":"fafa1785139e7f33af040fcdcea10975bca19a57","user":{"login":"cvn","id":774864,"avatar_url":"https://avatars.githubusercontent.com/u/774864?v=3","gravatar_id":"","url":"https://api.github.com/users/cvn","html_url":"https://github.com/cvn","followers_url":"https://api.github.com/users/cvn/followers","following_url":"https://api.github.com/users/cvn/following{/other_user}","gists_url":"https://api.github.com/users/cvn/gists{/gist_id}","starred_url":"https://api.github.com/users/cvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvn/subscriptions","organizations_url":"https://api.github.com/users/cvn/orgs","repos_url":"https://api.github.com/users/cvn/repos","events_url":"https://api.github.com/users/cvn/events{/privacy}","received_events_url":"https://api.github.com/users/cvn/received_events","type":"User","site_admin":false},"body":"Was there a reason why you needed to set this explicitly? According to [this ticket](https://github.com/gruntjs/grunt-contrib-connect/issues/60), 0.0.0.0 is already the default hostname since v0.7. I'd rather not set it if we don't need to.","created_at":"2015-05-11T09:20:27Z","updated_at":"2015-05-11T09:20:27Z","html_url":"https://github.com/cvn/angular-shims-placeholder/pull/23#discussion_r30023570","pull_request_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/comments/30023570"},"html":{"href":"https://github.com/cvn/angular-shims-placeholder/pull/23#discussion_r30023570"},"pull_request":{"href":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/23","id":34903133,"html_url":"https://github.com/cvn/angular-shims-placeholder/pull/23","diff_url":"https://github.com/cvn/angular-shims-placeholder/pull/23.diff","patch_url":"https://github.com/cvn/angular-shims-placeholder/pull/23.patch","issue_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/issues/23","number":23,"state":"open","locked":false,"title":"Added support for IE7","user":{"login":"danielcrisp","id":1104814,"avatar_url":"https://avatars.githubusercontent.com/u/1104814?v=3","gravatar_id":"","url":"https://api.github.com/users/danielcrisp","html_url":"https://github.com/danielcrisp","followers_url":"https://api.github.com/users/danielcrisp/followers","following_url":"https://api.github.com/users/danielcrisp/following{/other_user}","gists_url":"https://api.github.com/users/danielcrisp/gists{/gist_id}","starred_url":"https://api.github.com/users/danielcrisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielcrisp/subscriptions","organizations_url":"https://api.github.com/users/danielcrisp/orgs","repos_url":"https://api.github.com/users/danielcrisp/repos","events_url":"https://api.github.com/users/danielcrisp/events{/privacy}","received_events_url":"https://api.github.com/users/danielcrisp/received_events","type":"User","site_admin":false},"body":"There are a number of changes, most are for the demo page and a couple are for the directive itself.\r\n\r\nI'll explain them here, so you can understand what I've done.\r\n\r\n### Demo\r\nThe last version of Angular that works properly in IE7 is v1.0.8 so if IE7 is detected (using conditional comments) the demo page will use 1.0.8 from the CDN. If you're using the bower version you might end up with a later version that doesn't work (not sure how to get around this).\r\n\r\n**index.html**\r\n - I changed the app binding set up as described here: https://code.angularjs.org/1.0.8/docs/guide/ie\r\n - I changed the `console` test to `window.console`\r\n - I added the Angular CSS classes as they're not included with 1.0.8, e.g. `.ng-hide`\r\n - I added a monkey patch for ngAnimate because it isn't supported by 1.0.8\r\n - I added a polyfill for `querySelectorAll` so that your `fillElements`, `disableElements` methods work\r\n\r\n**bower.json**\r\n - Changed the angular versions\r\n\r\n**Gruntfile.js**\r\n - Specified a `hostname` in the connect options so I could test over my local network with IE7\r\n\r\n### Directive\r\nThe changes in the directive were actually pretty minimal.\r\n\r\n**lib/angular-placeholder.js**\r\n - Added a test for Angular v1.2+ as it requires a higher priority, previous versions require 0\r\n - Changed `$document.on` to `$document.bind` (which is supported by all versions)\r\n - Split a `clone.val().attr()` to two lines because I was getting an error on one element, not sure why!\r\n","created_at":"2015-05-07T10:42:53Z","updated_at":"2015-05-11T09:20:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d08da700ecf168e7cd6f4b2f28aacddbb4aad8ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/23/commits","review_comments_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/23/comments","review_comment_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/issues/23/comments","statuses_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/statuses/fafa1785139e7f33af040fcdcea10975bca19a57","head":{"label":"danielcrisp:master","ref":"master","sha":"fafa1785139e7f33af040fcdcea10975bca19a57","user":{"login":"danielcrisp","id":1104814,"avatar_url":"https://avatars.githubusercontent.com/u/1104814?v=3","gravatar_id":"","url":"https://api.github.com/users/danielcrisp","html_url":"https://github.com/danielcrisp","followers_url":"https://api.github.com/users/danielcrisp/followers","following_url":"https://api.github.com/users/danielcrisp/following{/other_user}","gists_url":"https://api.github.com/users/danielcrisp/gists{/gist_id}","starred_url":"https://api.github.com/users/danielcrisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielcrisp/subscriptions","organizations_url":"https://api.github.com/users/danielcrisp/orgs","repos_url":"https://api.github.com/users/danielcrisp/repos","events_url":"https://api.github.com/users/danielcrisp/events{/privacy}","received_events_url":"https://api.github.com/users/danielcrisp/received_events","type":"User","site_admin":false},"repo":{"id":35209464,"name":"angular-shims-placeholder","full_name":"danielcrisp/angular-shims-placeholder","owner":{"login":"danielcrisp","id":1104814,"avatar_url":"https://avatars.githubusercontent.com/u/1104814?v=3","gravatar_id":"","url":"https://api.github.com/users/danielcrisp","html_url":"https://github.com/danielcrisp","followers_url":"https://api.github.com/users/danielcrisp/followers","following_url":"https://api.github.com/users/danielcrisp/following{/other_user}","gists_url":"https://api.github.com/users/danielcrisp/gists{/gist_id}","starred_url":"https://api.github.com/users/danielcrisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielcrisp/subscriptions","organizations_url":"https://api.github.com/users/danielcrisp/orgs","repos_url":"https://api.github.com/users/danielcrisp/repos","events_url":"https://api.github.com/users/danielcrisp/events{/privacy}","received_events_url":"https://api.github.com/users/danielcrisp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielcrisp/angular-shims-placeholder","description":"Angular directive to emulate the placeholder attribute on text and password input fields for old browsers, such as IE9, IE8, and below. Also works on textareas and html5 input types.","fork":true,"url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder","forks_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/forks","keys_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/teams","hooks_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/hooks","issue_events_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/issues/events{/number}","events_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/events","assignees_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/assignees{/user}","branches_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/branches{/branch}","tags_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/tags","blobs_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/statuses/{sha}","languages_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/languages","stargazers_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/stargazers","contributors_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/contributors","subscribers_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/subscribers","subscription_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/subscription","commits_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/contents/{+path}","compare_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/merges","archive_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/downloads","issues_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/issues{/number}","pulls_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/pulls{/number}","milestones_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/milestones{/number}","notifications_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/labels{/name}","releases_url":"https://api.github.com/repos/danielcrisp/angular-shims-placeholder/releases{/id}","created_at":"2015-05-07T08:55:10Z","updated_at":"2015-05-07T10:27:13Z","pushed_at":"2015-05-07T10:27:13Z","git_url":"git://github.com/danielcrisp/angular-shims-placeholder.git","ssh_url":"git@github.com:danielcrisp/angular-shims-placeholder.git","clone_url":"https://github.com/danielcrisp/angular-shims-placeholder.git","svn_url":"https://github.com/danielcrisp/angular-shims-placeholder","homepage":"","size":344,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cvn:master","ref":"master","sha":"136b01a61d919a39e2447eaa6d13bc71b323c8f2","user":{"login":"cvn","id":774864,"avatar_url":"https://avatars.githubusercontent.com/u/774864?v=3","gravatar_id":"","url":"https://api.github.com/users/cvn","html_url":"https://github.com/cvn","followers_url":"https://api.github.com/users/cvn/followers","following_url":"https://api.github.com/users/cvn/following{/other_user}","gists_url":"https://api.github.com/users/cvn/gists{/gist_id}","starred_url":"https://api.github.com/users/cvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvn/subscriptions","organizations_url":"https://api.github.com/users/cvn/orgs","repos_url":"https://api.github.com/users/cvn/repos","events_url":"https://api.github.com/users/cvn/events{/privacy}","received_events_url":"https://api.github.com/users/cvn/received_events","type":"User","site_admin":false},"repo":{"id":13536204,"name":"angular-shims-placeholder","full_name":"cvn/angular-shims-placeholder","owner":{"login":"cvn","id":774864,"avatar_url":"https://avatars.githubusercontent.com/u/774864?v=3","gravatar_id":"","url":"https://api.github.com/users/cvn","html_url":"https://github.com/cvn","followers_url":"https://api.github.com/users/cvn/followers","following_url":"https://api.github.com/users/cvn/following{/other_user}","gists_url":"https://api.github.com/users/cvn/gists{/gist_id}","starred_url":"https://api.github.com/users/cvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvn/subscriptions","organizations_url":"https://api.github.com/users/cvn/orgs","repos_url":"https://api.github.com/users/cvn/repos","events_url":"https://api.github.com/users/cvn/events{/privacy}","received_events_url":"https://api.github.com/users/cvn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cvn/angular-shims-placeholder","description":"Angular directive to emulate the placeholder attribute on text and password input fields for old browsers, such as IE9, IE8, and below. Also works on textareas and html5 input types.","fork":false,"url":"https://api.github.com/repos/cvn/angular-shims-placeholder","forks_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/forks","keys_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/teams","hooks_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/hooks","issue_events_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/issues/events{/number}","events_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/events","assignees_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/assignees{/user}","branches_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/branches{/branch}","tags_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/tags","blobs_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/git/refs{/sha}","trees_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/statuses/{sha}","languages_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/languages","stargazers_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/stargazers","contributors_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/contributors","subscribers_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/subscribers","subscription_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/subscription","commits_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/commits{/sha}","git_commits_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/git/commits{/sha}","comments_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/comments{/number}","issue_comment_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/issues/comments{/number}","contents_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/contents/{+path}","compare_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/merges","archive_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/downloads","issues_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/issues{/number}","pulls_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls{/number}","milestones_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/milestones{/number}","notifications_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/labels{/name}","releases_url":"https://api.github.com/repos/cvn/angular-shims-placeholder/releases{/id}","created_at":"2013-10-13T08:29:20Z","updated_at":"2015-04-27T14:48:13Z","pushed_at":"2015-05-11T09:01:39Z","git_url":"git://github.com/cvn/angular-shims-placeholder.git","ssh_url":"git@github.com:cvn/angular-shims-placeholder.git","clone_url":"https://github.com/cvn/angular-shims-placeholder.git","svn_url":"https://github.com/cvn/angular-shims-placeholder","homepage":"","size":666,"stargazers_count":37,"watchers_count":37,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"open_issues_count":3,"forks":25,"open_issues":3,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/23"},"html":{"href":"https://github.com/cvn/angular-shims-placeholder/pull/23"},"issue":{"href":"https://api.github.com/repos/cvn/angular-shims-placeholder/issues/23"},"comments":{"href":"https://api.github.com/repos/cvn/angular-shims-placeholder/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cvn/angular-shims-placeholder/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/cvn/angular-shims-placeholder/statuses/fafa1785139e7f33af040fcdcea10975bca19a57"}}}}