{"action":"created","issue":{"url":"https://api.github.com/repos/milkypostman/melpa/issues/3358","labels_url":"https://api.github.com/repos/milkypostman/melpa/issues/3358/labels{/name}","comments_url":"https://api.github.com/repos/milkypostman/melpa/issues/3358/comments","events_url":"https://api.github.com/repos/milkypostman/melpa/issues/3358/events","html_url":"https://github.com/milkypostman/melpa/pull/3358","id":120603003,"number":3358,"title":"Add fxrd-mode recipe","user":{"login":"msherry","id":134751,"avatar_url":"https://avatars.githubusercontent.com/u/134751?v=3","gravatar_id":"","url":"https://api.github.com/users/msherry","html_url":"https://github.com/msherry","followers_url":"https://api.github.com/users/msherry/followers","following_url":"https://api.github.com/users/msherry/following{/other_user}","gists_url":"https://api.github.com/users/msherry/gists{/gist_id}","starred_url":"https://api.github.com/users/msherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msherry/subscriptions","organizations_url":"https://api.github.com/users/msherry/orgs","repos_url":"https://api.github.com/users/msherry/repos","events_url":"https://api.github.com/users/msherry/events{/privacy}","received_events_url":"https://api.github.com/users/msherry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-06T02:33:33Z","updated_at":"2015-12-09T18:23:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/milkypostman/melpa/pulls/3358","html_url":"https://github.com/milkypostman/melpa/pull/3358","diff_url":"https://github.com/milkypostman/melpa/pull/3358.diff","patch_url":"https://github.com/milkypostman/melpa/pull/3358.patch"},"body":"This package allows for editing/validation of fixed width record files, such as NACHA or TSO6 files, commonly used for financial transactions.\r\n\r\nfxrd-mode can be found at https://github.com/msherry/fxrd-mode -- I am the author."},"comment":{"url":"https://api.github.com/repos/milkypostman/melpa/issues/comments/163348547","html_url":"https://github.com/milkypostman/melpa/pull/3358#issuecomment-163348547","issue_url":"https://api.github.com/repos/milkypostman/melpa/issues/3358","id":163348547,"user":{"login":"purcell","id":5636,"avatar_url":"https://avatars.githubusercontent.com/u/5636?v=3","gravatar_id":"","url":"https://api.github.com/users/purcell","html_url":"https://github.com/purcell","followers_url":"https://api.github.com/users/purcell/followers","following_url":"https://api.github.com/users/purcell/following{/other_user}","gists_url":"https://api.github.com/users/purcell/gists{/gist_id}","starred_url":"https://api.github.com/users/purcell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purcell/subscriptions","organizations_url":"https://api.github.com/users/purcell/orgs","repos_url":"https://api.github.com/users/purcell/repos","events_url":"https://api.github.com/users/purcell/events{/privacy}","received_events_url":"https://api.github.com/users/purcell/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T18:23:03Z","updated_at":"2015-12-09T18:23:03Z","body":"I'm actually okay with this, but there are 2 things we should fix: firstly, don't check an `autoloads` file into your repo, because `package.el` will generate this for you, and MELPA will try to bundle `*.el`. Just make sure the necessary `;;;###autoload` cookies are in the source code. Secondly, `:files (:defaults (\"fxrd-modes\" \"fxrd-modes/*el\"))` in the recipe would be better written as `:files (:defaults \"fxrd-modes\")`, which is equivalent. Perhaps you could amend the commit accordingly, and ideally squash the two recipe commits together and force-push them to update the PR?"}}