{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/45449240","id":45449240,"diff_hunk":"@@ -719,7 +719,7 @@ def validate_one_for_role(proposal, role)\n   def validate_at_least_n_for_role(proposal, role, n)\n     elements = proposal[\"deployment\"][@bc_name][\"elements\"]\n \n-    if not elements.has_key?(role) or elements[role].length < n\n+    if not elements.key?(role) or elements[role].length < n","path":"crowbar_framework/app/models/service_object.rb","position":77,"original_position":77,"commit_id":"09bdf494b08fdd09346d50c60cbe4df5e4955795","original_commit_id":"09bdf494b08fdd09346d50c60cbe4df5e4955795","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Style/AndOr: Use `||` instead of `or`. (https://github.com/bbatsov/ruby-style-guide#no-and-or-or)<br>Style/Not: Use `!` instead of `not`. (https://github.com/bbatsov/ruby-style-guide#bang-not-not)","created_at":"2015-11-20T09:23:14Z","updated_at":"2015-11-20T09:23:14Z","html_url":"https://github.com/crowbar/crowbar-core/pull/134#discussion_r45449240","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/45449240"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/134#discussion_r45449240"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/134","id":51333706,"html_url":"https://github.com/crowbar/crowbar-core/pull/134","diff_url":"https://github.com/crowbar/crowbar-core/pull/134.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/134.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/134","number":134,"state":"open","locked":false,"title":"Avoid HoundCI bitching about has_key?","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"body":"According to our now master of style, Hash#has_key? is deprecated in\r\nfavor of Hash#key?.  (https://github.com/bbatsov/ruby-style-guide#hash-key)","created_at":"2015-11-20T09:22:59Z","updated_at":"2015-11-20T09:23:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7036c6243866784853742a01426c71375bfaee3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/134/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/134/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/134/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/09bdf494b08fdd09346d50c60cbe4df5e4955795","head":{"label":"dirkmueller:houndci_bitching","ref":"houndci_bitching","sha":"09bdf494b08fdd09346d50c60cbe4df5e4955795","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"repo":{"id":41291679,"name":"crowbar-core","full_name":"dirkmueller/crowbar-core","owner":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dirkmueller/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/dirkmueller/crowbar-core","forks_url":"https://api.github.com/repos/dirkmueller/crowbar-core/forks","keys_url":"https://api.github.com/repos/dirkmueller/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dirkmueller/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dirkmueller/crowbar-core/teams","hooks_url":"https://api.github.com/repos/dirkmueller/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/dirkmueller/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/dirkmueller/crowbar-core/events","assignees_url":"https://api.github.com/repos/dirkmueller/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/dirkmueller/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/dirkmueller/crowbar-core/tags","blobs_url":"https://api.github.com/repos/dirkmueller/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dirkmueller/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dirkmueller/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dirkmueller/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dirkmueller/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dirkmueller/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/dirkmueller/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/dirkmueller/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/dirkmueller/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/dirkmueller/crowbar-core/subscription","commits_url":"https://api.github.com/repos/dirkmueller/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dirkmueller/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dirkmueller/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dirkmueller/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dirkmueller/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/dirkmueller/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dirkmueller/crowbar-core/merges","archive_url":"https://api.github.com/repos/dirkmueller/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dirkmueller/crowbar-core/downloads","issues_url":"https://api.github.com/repos/dirkmueller/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/dirkmueller/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dirkmueller/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dirkmueller/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dirkmueller/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/dirkmueller/crowbar-core/releases{/id}","created_at":"2015-08-24T08:33:40Z","updated_at":"2015-08-24T08:33:42Z","pushed_at":"2015-11-20T09:22:44Z","git_url":"git://github.com/dirkmueller/crowbar-core.git","ssh_url":"git@github.com:dirkmueller/crowbar-core.git","clone_url":"https://github.com/dirkmueller/crowbar-core.git","svn_url":"https://github.com/dirkmueller/crowbar-core","homepage":null,"size":103628,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"00120ff3ae1a7815328832d14fa7303a75669e0a","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","created_at":"2015-07-13T09:31:28Z","updated_at":"2015-10-25T22:11:24Z","pushed_at":"2015-11-20T09:22:59Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":118460,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":20,"forks":21,"open_issues":20,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/134"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/134"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/134"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/09bdf494b08fdd09346d50c60cbe4df5e4955795"}}}}