{"action":"created","issue":{"url":"https://api.github.com/repos/LibreCAD/LibreCAD/issues/577","labels_url":"https://api.github.com/repos/LibreCAD/LibreCAD/issues/577/labels{/name}","comments_url":"https://api.github.com/repos/LibreCAD/LibreCAD/issues/577/comments","events_url":"https://api.github.com/repos/LibreCAD/LibreCAD/issues/577/events","html_url":"https://github.com/LibreCAD/LibreCAD/pull/577","id":107907809,"number":577,"title":"Fixed bug in hatch dialog box","user":{"login":"Rupicapra-rupicapra","id":11034946,"avatar_url":"https://avatars.githubusercontent.com/u/11034946?v=3","gravatar_id":"","url":"https://api.github.com/users/Rupicapra-rupicapra","html_url":"https://github.com/Rupicapra-rupicapra","followers_url":"https://api.github.com/users/Rupicapra-rupicapra/followers","following_url":"https://api.github.com/users/Rupicapra-rupicapra/following{/other_user}","gists_url":"https://api.github.com/users/Rupicapra-rupicapra/gists{/gist_id}","starred_url":"https://api.github.com/users/Rupicapra-rupicapra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rupicapra-rupicapra/subscriptions","organizations_url":"https://api.github.com/users/Rupicapra-rupicapra/orgs","repos_url":"https://api.github.com/users/Rupicapra-rupicapra/repos","events_url":"https://api.github.com/users/Rupicapra-rupicapra/events{/privacy}","received_events_url":"https://api.github.com/users/Rupicapra-rupicapra/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-23T12:20:06Z","updated_at":"2015-09-24T06:26:19Z","closed_at":"2015-09-23T17:33:06Z","pull_request":{"url":"https://api.github.com/repos/LibreCAD/LibreCAD/pulls/577","html_url":"https://github.com/LibreCAD/LibreCAD/pull/577","diff_url":"https://github.com/LibreCAD/LibreCAD/pull/577.diff","patch_url":"https://github.com/LibreCAD/LibreCAD/pull/577.patch"},"body":"Bug introduced by commit 776c8ae4dbd86ae658202a2174895ce340b0b1dd (`git bisect` information)\r\nChanging from `if(hatch==nullptr)` to `if(hatch)` caused the hatch\r\ndialog box not to show when called.\r\nIt seems that this change fixed it... Will see.\r\n\r\nBecause I reverted a change which happened few times ago, I prefer asking : why was this line changed ? Does it have a goal in particular, that I would have broken by reverting ?"},"comment":{"url":"https://api.github.com/repos/LibreCAD/LibreCAD/issues/comments/142825492","html_url":"https://github.com/LibreCAD/LibreCAD/pull/577#issuecomment-142825492","issue_url":"https://api.github.com/repos/LibreCAD/LibreCAD/issues/577","id":142825492,"user":{"login":"Rupicapra-rupicapra","id":11034946,"avatar_url":"https://avatars.githubusercontent.com/u/11034946?v=3","gravatar_id":"","url":"https://api.github.com/users/Rupicapra-rupicapra","html_url":"https://github.com/Rupicapra-rupicapra","followers_url":"https://api.github.com/users/Rupicapra-rupicapra/followers","following_url":"https://api.github.com/users/Rupicapra-rupicapra/following{/other_user}","gists_url":"https://api.github.com/users/Rupicapra-rupicapra/gists{/gist_id}","starred_url":"https://api.github.com/users/Rupicapra-rupicapra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rupicapra-rupicapra/subscriptions","organizations_url":"https://api.github.com/users/Rupicapra-rupicapra/orgs","repos_url":"https://api.github.com/users/Rupicapra-rupicapra/repos","events_url":"https://api.github.com/users/Rupicapra-rupicapra/events{/privacy}","received_events_url":"https://api.github.com/users/Rupicapra-rupicapra/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T06:26:19Z","updated_at":"2015-09-24T06:26:19Z","body":"You're welcome.\r\nThat may happen. Maybe you wanted to replace `if(hatch==nullptr)` by `if(!hatch)` like you did for text tool on [line 1758](https://github.com/LibreCAD/LibreCAD/commit/776c8ae4dbd86ae658202a2174895ce340b0b1dd#diff-bccd21648950850b5d8f3ae3eebe4e3fR1758) but forgot the `!` (text tool is OK with this change). I'll try to change to `if(!hatch)`, and if it's OK I'll include it in a further PR.\r\n"}}