{"action":"created","issue":{"url":"https://api.github.com/repos/trungdq88/insurance-card/issues/344","labels_url":"https://api.github.com/repos/trungdq88/insurance-card/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/trungdq88/insurance-card/issues/344/comments","events_url":"https://api.github.com/repos/trungdq88/insurance-card/issues/344/events","html_url":"https://github.com/trungdq88/insurance-card/issues/344","id":95483304,"number":344,"title":"Implement các business rule vào code có sẵn.","user":{"login":"trungdq88","id":4214509,"avatar_url":"https://avatars.githubusercontent.com/u/4214509?v=3","gravatar_id":"","url":"https://api.github.com/users/trungdq88","html_url":"https://github.com/trungdq88","followers_url":"https://api.github.com/users/trungdq88/followers","following_url":"https://api.github.com/users/trungdq88/following{/other_user}","gists_url":"https://api.github.com/users/trungdq88/gists{/gist_id}","starred_url":"https://api.github.com/users/trungdq88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trungdq88/subscriptions","organizations_url":"https://api.github.com/users/trungdq88/orgs","repos_url":"https://api.github.com/users/trungdq88/repos","events_url":"https://api.github.com/users/trungdq88/events{/privacy}","received_events_url":"https://api.github.com/users/trungdq88/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/trungdq88/insurance-card/labels/task","name":"task","color":"009866"},{"url":"https://api.github.com/repos/trungdq88/insurance-card/labels/web%20app","name":"web app","color":"8e2aeb"}],"state":"open","locked":false,"assignee":{"login":"phucnguyen60749","id":12363394,"avatar_url":"https://avatars.githubusercontent.com/u/12363394?v=3","gravatar_id":"","url":"https://api.github.com/users/phucnguyen60749","html_url":"https://github.com/phucnguyen60749","followers_url":"https://api.github.com/users/phucnguyen60749/followers","following_url":"https://api.github.com/users/phucnguyen60749/following{/other_user}","gists_url":"https://api.github.com/users/phucnguyen60749/gists{/gist_id}","starred_url":"https://api.github.com/users/phucnguyen60749/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phucnguyen60749/subscriptions","organizations_url":"https://api.github.com/users/phucnguyen60749/orgs","repos_url":"https://api.github.com/users/phucnguyen60749/repos","events_url":"https://api.github.com/users/phucnguyen60749/events{/privacy}","received_events_url":"https://api.github.com/users/phucnguyen60749/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/trungdq88/insurance-card/milestones/14","html_url":"https://github.com/trungdq88/insurance-card/milestones/Week%209.2:%20Implement%20branch%20master.","labels_url":"https://api.github.com/repos/trungdq88/insurance-card/milestones/14/labels","id":1212487,"number":14,"title":"Week 9.2: Implement branch master.","description":"","creator":{"login":"trungdq88","id":4214509,"avatar_url":"https://avatars.githubusercontent.com/u/4214509?v=3","gravatar_id":"","url":"https://api.github.com/users/trungdq88","html_url":"https://github.com/trungdq88","followers_url":"https://api.github.com/users/trungdq88/followers","following_url":"https://api.github.com/users/trungdq88/following{/other_user}","gists_url":"https://api.github.com/users/trungdq88/gists{/gist_id}","starred_url":"https://api.github.com/users/trungdq88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trungdq88/subscriptions","organizations_url":"https://api.github.com/users/trungdq88/orgs","repos_url":"https://api.github.com/users/trungdq88/repos","events_url":"https://api.github.com/users/trungdq88/events{/privacy}","received_events_url":"https://api.github.com/users/trungdq88/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":15,"state":"open","created_at":"2015-07-17T08:05:03Z","updated_at":"2015-07-19T17:05:17Z","due_on":"2015-07-18T17:00:00Z","closed_at":null},"comments":29,"created_at":"2015-07-16T17:21:17Z","updated_at":"2015-07-19T17:30:37Z","closed_at":null,"body":"### Vấn đề\r\nHiện tại một số đoạn code chưa sử dụng các giá trị từ business rule (do trước đây không tồn tại business rule). Cần implement cho đầy đủ.\r\n\r\nEm cần mọi người kiểm tra hết **tất cả các giá trị của business rule** sau đó **liệt kê các chức năng có dùng tới các giá trị đó**, sau cùng là implement cho chỗ đó.\r\n\r\n### Ví dụ một chỗ mới phát hiện:\r\n> Thời hạn mặc định là 24 tháng\r\n> <img width=\"512\" alt=\"screenshot 2015-07-17 00 15 54\" src=\"https://cloud.githubusercontent.com/assets/4214509/8730100/27574ac4-2c19-11e5-910c-0945e1c29a1d.png\">\r\n> Chỗ này vẫn hiện 1 năm\r\n> <img width=\"278\" alt=\"screenshot 2015-07-17 00 12 09\" src=\"https://cloud.githubusercontent.com/assets/4214509/8730108/343ca130-2c19-11e5-992d-8eaa57ccbe3a.png\">\r\n> Ở đây cũng vậy.\r\n> <img width=\"342\" alt=\"screenshot 2015-07-17 00 11 05\" src=\"https://cloud.githubusercontent.com/assets/4214509/8730116/3c1ac814-2c19-11e5-989f-4e7a8a787418.png\">\r\n> Lúc tạo hợp đồng mới thì thời hạn cũng chỉ có 1 năm\r\n> <img width=\"406\" alt=\"screenshot 2015-07-17 00 13 15\" src=\"https://cloud.githubusercontent.com/assets/4214509/8730141/53a4ce12-2c19-11e5-8cb8-e418fda5d1f7.png\">\r\n> Ở trang tạo hợp đồng mới của staff, giá trị cũng hiển thị có 1 năm\r\n> <img width=\"601\" alt=\"screenshot 2015-07-17 00 18 48\" src=\"https://cloud.githubusercontent.com/assets/4214509/8730162/78ba411e-2c19-11e5-8b80-3cf00399d863.png\">\r\n> Tương tự, trang tạo hợp đồng mới của customer:\r\n> <img width=\"467\" alt=\"screenshot 2015-07-17 00 19 46\" src=\"https://cloud.githubusercontent.com/assets/4214509/8730188/99366454-2c19-11e5-9ace-97fb55b09f96.png\">\r\n\r\nĐó là chỉ có giá trị **Thời hạn mặc định của hợp đồng**, chúng ta cần phải kiểm tra cả những giá trị khác. Ví dụ trong Scheduler em còn thấy sử dụng biến từ Constants (các giá trị thời hạn thông báo HĐ sắp hết hạn lần 1/lần 2/lần 3)...\r\n\r\n## Cách thực hiện:\r\nEm sẽ liệt kê các rule kèm theo các chỗ cần sửa ở comment đầu tiên của issue này, mọi người sẽ bổ sung bằng cách edit comment của em. Sau khi đầy đủ thì sẽ bắt đầu implement, em sẽ assign cho một người hoặc chia thành các phần để làm (tính sau)."},"comment":{"url":"https://api.github.com/repos/trungdq88/insurance-card/issues/comments/122687400","html_url":"https://github.com/trungdq88/insurance-card/issues/344#issuecomment-122687400","issue_url":"https://api.github.com/repos/trungdq88/insurance-card/issues/344","id":122687400,"user":{"login":"trungdq88","id":4214509,"avatar_url":"https://avatars.githubusercontent.com/u/4214509?v=3","gravatar_id":"","url":"https://api.github.com/users/trungdq88","html_url":"https://github.com/trungdq88","followers_url":"https://api.github.com/users/trungdq88/followers","following_url":"https://api.github.com/users/trungdq88/following{/other_user}","gists_url":"https://api.github.com/users/trungdq88/gists{/gist_id}","starred_url":"https://api.github.com/users/trungdq88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trungdq88/subscriptions","organizations_url":"https://api.github.com/users/trungdq88/orgs","repos_url":"https://api.github.com/users/trungdq88/repos","events_url":"https://api.github.com/users/trungdq88/events{/privacy}","received_events_url":"https://api.github.com/users/trungdq88/received_events","type":"User","site_admin":false},"created_at":"2015-07-19T17:30:37Z","updated_at":"2015-07-19T17:30:37Z","body":"Vậy bây giờ mình biểu quyết cho chỗ này. Ý kiến mọi người thế nào?\r\nTheo em thì để cho customer chọn thoải mái là ok."}}