{"action":"created","issue":{"url":"https://api.github.com/repos/EHVAG/demoinfo/issues/42","labels_url":"https://api.github.com/repos/EHVAG/demoinfo/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/EHVAG/demoinfo/issues/42/comments","events_url":"https://api.github.com/repos/EHVAG/demoinfo/issues/42/events","html_url":"https://github.com/EHVAG/demoinfo/pull/42","id":59790912,"number":42,"title":"Added ItemBuy Event","user":{"login":"gocke","id":444009,"avatar_url":"https://avatars.githubusercontent.com/u/444009?v=3","gravatar_id":"","url":"https://api.github.com/users/gocke","html_url":"https://github.com/gocke","followers_url":"https://api.github.com/users/gocke/followers","following_url":"https://api.github.com/users/gocke/following{/other_user}","gists_url":"https://api.github.com/users/gocke/gists{/gist_id}","starred_url":"https://api.github.com/users/gocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gocke/subscriptions","organizations_url":"https://api.github.com/users/gocke/orgs","repos_url":"https://api.github.com/users/gocke/repos","events_url":"https://api.github.com/users/gocke/events{/privacy}","received_events_url":"https://api.github.com/users/gocke/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-04T12:25:08Z","updated_at":"2015-03-04T16:32:43Z","closed_at":"2015-03-04T16:32:43Z","pull_request":{"url":"https://api.github.com/repos/EHVAG/demoinfo/pulls/42","html_url":"https://github.com/EHVAG/demoinfo/pull/42","diff_url":"https://github.com/EHVAG/demoinfo/pull/42.diff","patch_url":"https://github.com/EHVAG/demoinfo/pull/42.patch"},"body":"Added ItemBuy Event and ItemBuyEventArgs, also improved Copy method on Player and added Copy method on Equipment"},"comment":{"url":"https://api.github.com/repos/EHVAG/demoinfo/issues/comments/77192011","html_url":"https://github.com/EHVAG/demoinfo/pull/42#issuecomment-77192011","issue_url":"https://api.github.com/repos/EHVAG/demoinfo/issues/42","id":77192011,"user":{"login":"moritzuehling","id":7847742,"avatar_url":"https://avatars.githubusercontent.com/u/7847742?v=3","gravatar_id":"","url":"https://api.github.com/users/moritzuehling","html_url":"https://github.com/moritzuehling","followers_url":"https://api.github.com/users/moritzuehling/followers","following_url":"https://api.github.com/users/moritzuehling/following{/other_user}","gists_url":"https://api.github.com/users/moritzuehling/gists{/gist_id}","starred_url":"https://api.github.com/users/moritzuehling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moritzuehling/subscriptions","organizations_url":"https://api.github.com/users/moritzuehling/orgs","repos_url":"https://api.github.com/users/moritzuehling/repos","events_url":"https://api.github.com/users/moritzuehling/events{/privacy}","received_events_url":"https://api.github.com/users/moritzuehling/received_events","type":"User","site_admin":false},"created_at":"2015-03-04T16:32:42Z","updated_at":"2015-03-04T16:32:42Z","body":"I see multiple problems in with this in the current form: \r\n\r\n* Tabs vs. Spaces - You use spaces, we use tabs. \r\n* You copy the whole player for item buy, \r\n* [This](https://github.com/gocke/demoinfo-public/commit/5371ed18599e6e10a7424fa2420261c852d03286#diff-0c430b729ca99e2179e586aaeeb9e077R515) seems to be very unnecessary - you just need to look at the raw weapon with the same ID. \r\n* You could break early [here](https://github.com/gocke/demoinfo-public/commit/5371ed18599e6e10a7424fa2420261c852d03286#diff-0c430b729ca99e2179e586aaeeb9e077R517). \r\n* Wouldn't this also raise ItemBuy on a weapon-pickup?\r\n* Copying stuff on every tick seems slow as hell - you don't need to hold the whole player state for example. Also, you're using a Dictionary which is slow, which could be improved. \r\n* The whole copy thing is bad and I probably should remove it - it still doesn't - for example - copy the [Additional informations](https://github.com/gocke/demoinfo-public/blob/5371ed18599e6e10a7424fa2420261c852d03286/DemoInfo/Player.cs#L72). \r\n\r\nAll in all, I can't merge it in the current form, you need to change some things, sorry. The idea is good, the way you did just needs improving. \r\n\r\n@main--  would kill me if I merged this. I'll add this feature in demoinfo2 for sure, but until now I was very busy with university, since I had (and partially have) some assignments to do, some tests to write, and so on...) - sorry for working on this so little recently! "}}