{"action":"closed","number":377,"pull_request":{"url":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls/377","id":42681260,"html_url":"https://github.com/rockabox/rbx_ui_components/pull/377","diff_url":"https://github.com/rockabox/rbx_ui_components/pull/377.diff","patch_url":"https://github.com/rockabox/rbx_ui_components/pull/377.patch","issue_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/377","number":377,"state":"closed","locked":false,"title":"Move form width bounding rules","user":{"login":"ohskylab","id":41568,"avatar_url":"https://avatars.githubusercontent.com/u/41568?v=3","gravatar_id":"","url":"https://api.github.com/users/ohskylab","html_url":"https://github.com/ohskylab","followers_url":"https://api.github.com/users/ohskylab/followers","following_url":"https://api.github.com/users/ohskylab/following{/other_user}","gists_url":"https://api.github.com/users/ohskylab/gists{/gist_id}","starred_url":"https://api.github.com/users/ohskylab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohskylab/subscriptions","organizations_url":"https://api.github.com/users/ohskylab/orgs","repos_url":"https://api.github.com/users/ohskylab/repos","events_url":"https://api.github.com/users/ohskylab/events{/privacy}","received_events_url":"https://api.github.com/users/ohskylab/received_events","type":"User","site_admin":false},"body":"TP: https://rockabox.tpondemand.com/entity/10717\r\n\r\nFrom `rb-generic-form` to `rb-fieldset`.\r\n\r\nSetting upper bounds on form widths should ideally be done on a wrapper around the entire form, but this can't be done properly as forms have been split into two parts (the form itself and actions) and vary in use of other wrapper components.\r\n\r\nMoving the bounding to fieldset-level is the least intrusive, next-best option.","created_at":"2015-08-18T10:06:37Z","updated_at":"2015-08-18T11:18:12Z","closed_at":"2015-08-18T11:18:12Z","merged_at":"2015-08-18T11:18:12Z","merge_commit_sha":"19eb5d481171cdaac59f9b1f309d4ed2f89c2f94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls/377/commits","review_comments_url":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls/377/comments","review_comment_url":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/377/comments","statuses_url":"https://api.github.com/repos/rockabox/rbx_ui_components/statuses/02e7cfe1d4150dee58891dc16e32f4261e9536a8","head":{"label":"rockabox:paul/move-form-bounding-to-fieldset","ref":"paul/move-form-bounding-to-fieldset","sha":"02e7cfe1d4150dee58891dc16e32f4261e9536a8","user":{"login":"rockabox","id":245290,"avatar_url":"https://avatars.githubusercontent.com/u/245290?v=3","gravatar_id":"","url":"https://api.github.com/users/rockabox","html_url":"https://github.com/rockabox","followers_url":"https://api.github.com/users/rockabox/followers","following_url":"https://api.github.com/users/rockabox/following{/other_user}","gists_url":"https://api.github.com/users/rockabox/gists{/gist_id}","starred_url":"https://api.github.com/users/rockabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockabox/subscriptions","organizations_url":"https://api.github.com/users/rockabox/orgs","repos_url":"https://api.github.com/users/rockabox/repos","events_url":"https://api.github.com/users/rockabox/events{/privacy}","received_events_url":"https://api.github.com/users/rockabox/received_events","type":"Organization","site_admin":false},"repo":{"id":30237405,"name":"rbx_ui_components","full_name":"rockabox/rbx_ui_components","owner":{"login":"rockabox","id":245290,"avatar_url":"https://avatars.githubusercontent.com/u/245290?v=3","gravatar_id":"","url":"https://api.github.com/users/rockabox","html_url":"https://github.com/rockabox","followers_url":"https://api.github.com/users/rockabox/followers","following_url":"https://api.github.com/users/rockabox/following{/other_user}","gists_url":"https://api.github.com/users/rockabox/gists{/gist_id}","starred_url":"https://api.github.com/users/rockabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockabox/subscriptions","organizations_url":"https://api.github.com/users/rockabox/orgs","repos_url":"https://api.github.com/users/rockabox/repos","events_url":"https://api.github.com/users/rockabox/events{/privacy}","received_events_url":"https://api.github.com/users/rockabox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rockabox/rbx_ui_components","description":"","fork":false,"url":"https://api.github.com/repos/rockabox/rbx_ui_components","forks_url":"https://api.github.com/repos/rockabox/rbx_ui_components/forks","keys_url":"https://api.github.com/repos/rockabox/rbx_ui_components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rockabox/rbx_ui_components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rockabox/rbx_ui_components/teams","hooks_url":"https://api.github.com/repos/rockabox/rbx_ui_components/hooks","issue_events_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/events{/number}","events_url":"https://api.github.com/repos/rockabox/rbx_ui_components/events","assignees_url":"https://api.github.com/repos/rockabox/rbx_ui_components/assignees{/user}","branches_url":"https://api.github.com/repos/rockabox/rbx_ui_components/branches{/branch}","tags_url":"https://api.github.com/repos/rockabox/rbx_ui_components/tags","blobs_url":"https://api.github.com/repos/rockabox/rbx_ui_components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rockabox/rbx_ui_components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rockabox/rbx_ui_components/git/refs{/sha}","trees_url":"https://api.github.com/repos/rockabox/rbx_ui_components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rockabox/rbx_ui_components/statuses/{sha}","languages_url":"https://api.github.com/repos/rockabox/rbx_ui_components/languages","stargazers_url":"https://api.github.com/repos/rockabox/rbx_ui_components/stargazers","contributors_url":"https://api.github.com/repos/rockabox/rbx_ui_components/contributors","subscribers_url":"https://api.github.com/repos/rockabox/rbx_ui_components/subscribers","subscription_url":"https://api.github.com/repos/rockabox/rbx_ui_components/subscription","commits_url":"https://api.github.com/repos/rockabox/rbx_ui_components/commits{/sha}","git_commits_url":"https://api.github.com/repos/rockabox/rbx_ui_components/git/commits{/sha}","comments_url":"https://api.github.com/repos/rockabox/rbx_ui_components/comments{/number}","issue_comment_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/comments{/number}","contents_url":"https://api.github.com/repos/rockabox/rbx_ui_components/contents/{+path}","compare_url":"https://api.github.com/repos/rockabox/rbx_ui_components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rockabox/rbx_ui_components/merges","archive_url":"https://api.github.com/repos/rockabox/rbx_ui_components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rockabox/rbx_ui_components/downloads","issues_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues{/number}","pulls_url":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls{/number}","milestones_url":"https://api.github.com/repos/rockabox/rbx_ui_components/milestones{/number}","notifications_url":"https://api.github.com/repos/rockabox/rbx_ui_components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rockabox/rbx_ui_components/labels{/name}","releases_url":"https://api.github.com/repos/rockabox/rbx_ui_components/releases{/id}","created_at":"2015-02-03T10:27:21Z","updated_at":"2015-08-03T10:06:01Z","pushed_at":"2015-08-18T11:18:12Z","git_url":"git://github.com/rockabox/rbx_ui_components.git","ssh_url":"git@github.com:rockabox/rbx_ui_components.git","clone_url":"https://github.com/rockabox/rbx_ui_components.git","svn_url":"https://github.com/rockabox/rbx_ui_components","homepage":null,"size":5284,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"rockabox:master","ref":"master","sha":"f351b064d859032483db4f610c6ba33ca6e47406","user":{"login":"rockabox","id":245290,"avatar_url":"https://avatars.githubusercontent.com/u/245290?v=3","gravatar_id":"","url":"https://api.github.com/users/rockabox","html_url":"https://github.com/rockabox","followers_url":"https://api.github.com/users/rockabox/followers","following_url":"https://api.github.com/users/rockabox/following{/other_user}","gists_url":"https://api.github.com/users/rockabox/gists{/gist_id}","starred_url":"https://api.github.com/users/rockabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockabox/subscriptions","organizations_url":"https://api.github.com/users/rockabox/orgs","repos_url":"https://api.github.com/users/rockabox/repos","events_url":"https://api.github.com/users/rockabox/events{/privacy}","received_events_url":"https://api.github.com/users/rockabox/received_events","type":"Organization","site_admin":false},"repo":{"id":30237405,"name":"rbx_ui_components","full_name":"rockabox/rbx_ui_components","owner":{"login":"rockabox","id":245290,"avatar_url":"https://avatars.githubusercontent.com/u/245290?v=3","gravatar_id":"","url":"https://api.github.com/users/rockabox","html_url":"https://github.com/rockabox","followers_url":"https://api.github.com/users/rockabox/followers","following_url":"https://api.github.com/users/rockabox/following{/other_user}","gists_url":"https://api.github.com/users/rockabox/gists{/gist_id}","starred_url":"https://api.github.com/users/rockabox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rockabox/subscriptions","organizations_url":"https://api.github.com/users/rockabox/orgs","repos_url":"https://api.github.com/users/rockabox/repos","events_url":"https://api.github.com/users/rockabox/events{/privacy}","received_events_url":"https://api.github.com/users/rockabox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rockabox/rbx_ui_components","description":"","fork":false,"url":"https://api.github.com/repos/rockabox/rbx_ui_components","forks_url":"https://api.github.com/repos/rockabox/rbx_ui_components/forks","keys_url":"https://api.github.com/repos/rockabox/rbx_ui_components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rockabox/rbx_ui_components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rockabox/rbx_ui_components/teams","hooks_url":"https://api.github.com/repos/rockabox/rbx_ui_components/hooks","issue_events_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/events{/number}","events_url":"https://api.github.com/repos/rockabox/rbx_ui_components/events","assignees_url":"https://api.github.com/repos/rockabox/rbx_ui_components/assignees{/user}","branches_url":"https://api.github.com/repos/rockabox/rbx_ui_components/branches{/branch}","tags_url":"https://api.github.com/repos/rockabox/rbx_ui_components/tags","blobs_url":"https://api.github.com/repos/rockabox/rbx_ui_components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rockabox/rbx_ui_components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rockabox/rbx_ui_components/git/refs{/sha}","trees_url":"https://api.github.com/repos/rockabox/rbx_ui_components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rockabox/rbx_ui_components/statuses/{sha}","languages_url":"https://api.github.com/repos/rockabox/rbx_ui_components/languages","stargazers_url":"https://api.github.com/repos/rockabox/rbx_ui_components/stargazers","contributors_url":"https://api.github.com/repos/rockabox/rbx_ui_components/contributors","subscribers_url":"https://api.github.com/repos/rockabox/rbx_ui_components/subscribers","subscription_url":"https://api.github.com/repos/rockabox/rbx_ui_components/subscription","commits_url":"https://api.github.com/repos/rockabox/rbx_ui_components/commits{/sha}","git_commits_url":"https://api.github.com/repos/rockabox/rbx_ui_components/git/commits{/sha}","comments_url":"https://api.github.com/repos/rockabox/rbx_ui_components/comments{/number}","issue_comment_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/comments{/number}","contents_url":"https://api.github.com/repos/rockabox/rbx_ui_components/contents/{+path}","compare_url":"https://api.github.com/repos/rockabox/rbx_ui_components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rockabox/rbx_ui_components/merges","archive_url":"https://api.github.com/repos/rockabox/rbx_ui_components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rockabox/rbx_ui_components/downloads","issues_url":"https://api.github.com/repos/rockabox/rbx_ui_components/issues{/number}","pulls_url":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls{/number}","milestones_url":"https://api.github.com/repos/rockabox/rbx_ui_components/milestones{/number}","notifications_url":"https://api.github.com/repos/rockabox/rbx_ui_components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rockabox/rbx_ui_components/labels{/name}","releases_url":"https://api.github.com/repos/rockabox/rbx_ui_components/releases{/id}","created_at":"2015-02-03T10:27:21Z","updated_at":"2015-08-03T10:06:01Z","pushed_at":"2015-08-18T11:18:12Z","git_url":"git://github.com/rockabox/rbx_ui_components.git","ssh_url":"git@github.com:rockabox/rbx_ui_components.git","clone_url":"https://github.com/rockabox/rbx_ui_components.git","svn_url":"https://github.com/rockabox/rbx_ui_components","homepage":null,"size":5284,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls/377"},"html":{"href":"https://github.com/rockabox/rbx_ui_components/pull/377"},"issue":{"href":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/377"},"comments":{"href":"https://api.github.com/repos/rockabox/rbx_ui_components/issues/377/comments"},"review_comments":{"href":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls/377/comments"},"review_comment":{"href":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rockabox/rbx_ui_components/pulls/377/commits"},"statuses":{"href":"https://api.github.com/repos/rockabox/rbx_ui_components/statuses/02e7cfe1d4150dee58891dc16e32f4261e9536a8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jaylett","id":80187,"avatar_url":"https://avatars.githubusercontent.com/u/80187?v=3","gravatar_id":"","url":"https://api.github.com/users/jaylett","html_url":"https://github.com/jaylett","followers_url":"https://api.github.com/users/jaylett/followers","following_url":"https://api.github.com/users/jaylett/following{/other_user}","gists_url":"https://api.github.com/users/jaylett/gists{/gist_id}","starred_url":"https://api.github.com/users/jaylett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaylett/subscriptions","organizations_url":"https://api.github.com/users/jaylett/orgs","repos_url":"https://api.github.com/users/jaylett/repos","events_url":"https://api.github.com/users/jaylett/events{/privacy}","received_events_url":"https://api.github.com/users/jaylett/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":9,"changed_files":2}}