{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/48213515","id":48213515,"diff_hunk":"@@ -20,6 +22,8 @@ class V8 < Formula\n   depends_on :macos => :lion\n \n   depends_on :python => :build # gyp doesn't run under 2.6 or lower\n+  depends_on \"pkg-config\" => :build\n+  depends_on \"icu4c\"","path":"Library/Formula/v8.rb","position":11,"original_position":11,"commit_id":"1ef2d5f6a2e240da7da3c159fa923a07d8aedead","original_commit_id":"5bf7cdb53609912d40a90d38ea188be9082454bd","user":{"login":"kynx","id":1320145,"avatar_url":"https://avatars.githubusercontent.com/u/1320145?v=3","gravatar_id":"","url":"https://api.github.com/users/kynx","html_url":"https://github.com/kynx","followers_url":"https://api.github.com/users/kynx/followers","following_url":"https://api.github.com/users/kynx/following{/other_user}","gists_url":"https://api.github.com/users/kynx/gists{/gist_id}","starred_url":"https://api.github.com/users/kynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kynx/subscriptions","organizations_url":"https://api.github.com/users/kynx/orgs","repos_url":"https://api.github.com/users/kynx/repos","events_url":"https://api.github.com/users/kynx/events{/privacy}","received_events_url":"https://api.github.com/users/kynx/received_events","type":"User","site_admin":false},"body":"Form what I read on chromium-packagers, most (all?) link `v8` statically, just so they have some control over API changes. Chromium on linux definitely links to system `icu` - that's where I'm nicking the gyp from :smile: \r\n\r\nI'm done for the day, but can look at making it optional tomorrow if you want.","created_at":"2015-12-22T01:34:18Z","updated_at":"2015-12-22T01:34:18Z","html_url":"https://github.com/Homebrew/homebrew/pull/47232#discussion_r48213515","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/47232","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/48213515"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/47232#discussion_r48213515"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/47232"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/47232","id":54272561,"html_url":"https://github.com/Homebrew/homebrew/pull/47232","diff_url":"https://github.com/Homebrew/homebrew/pull/47232.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/47232.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/47232","number":47232,"state":"open","locked":false,"title":"V8: add i18n support via system icu","user":{"login":"kynx","id":1320145,"avatar_url":"https://avatars.githubusercontent.com/u/1320145?v=3","gravatar_id":"","url":"https://api.github.com/users/kynx","html_url":"https://github.com/kynx","followers_url":"https://api.github.com/users/kynx/followers","following_url":"https://api.github.com/users/kynx/following{/other_user}","gists_url":"https://api.github.com/users/kynx/gists{/gist_id}","starred_url":"https://api.github.com/users/kynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kynx/subscriptions","organizations_url":"https://api.github.com/users/kynx/orgs","repos_url":"https://api.github.com/users/kynx/repos","events_url":"https://api.github.com/users/kynx/events{/privacy}","received_events_url":"https://api.github.com/users/kynx/received_events","type":"User","site_admin":false},"body":"This is a follow-on to #46479. Instead of patching the v8 source, this PR uses the \"unbundled\" icu.gyp used by the chromium project for building under linux, as suggested on [chromium-packagers](https://groups.google.com/a/chromium.org/forum/#!topic/chromium-packagers/pNpOJ0wh5c8).\r\n\r\nGrabbing the unbundled icu.gyp is a little awkward, since it comes down base64-encoded. I've followed the approach used in the android-sdk formula when it has to do something similar.\r\n\r\nHopefully this addresses the concerns with the original PR - but let me know @DomT4 !\r\n\r\n","created_at":"2015-12-21T16:05:45Z","updated_at":"2015-12-22T01:34:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c9af22c8d3f1f6325dd0c7a106eb3f9994eadca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/47232/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/47232/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/47232/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/1ef2d5f6a2e240da7da3c159fa923a07d8aedead","head":{"label":"kynx:v8-unbundle-icu","ref":"v8-unbundle-icu","sha":"1ef2d5f6a2e240da7da3c159fa923a07d8aedead","user":{"login":"kynx","id":1320145,"avatar_url":"https://avatars.githubusercontent.com/u/1320145?v=3","gravatar_id":"","url":"https://api.github.com/users/kynx","html_url":"https://github.com/kynx","followers_url":"https://api.github.com/users/kynx/followers","following_url":"https://api.github.com/users/kynx/following{/other_user}","gists_url":"https://api.github.com/users/kynx/gists{/gist_id}","starred_url":"https://api.github.com/users/kynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kynx/subscriptions","organizations_url":"https://api.github.com/users/kynx/orgs","repos_url":"https://api.github.com/users/kynx/repos","events_url":"https://api.github.com/users/kynx/events{/privacy}","received_events_url":"https://api.github.com/users/kynx/received_events","type":"User","site_admin":false},"repo":{"id":47074330,"name":"homebrew","full_name":"kynx/homebrew","owner":{"login":"kynx","id":1320145,"avatar_url":"https://avatars.githubusercontent.com/u/1320145?v=3","gravatar_id":"","url":"https://api.github.com/users/kynx","html_url":"https://github.com/kynx","followers_url":"https://api.github.com/users/kynx/followers","following_url":"https://api.github.com/users/kynx/following{/other_user}","gists_url":"https://api.github.com/users/kynx/gists{/gist_id}","starred_url":"https://api.github.com/users/kynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kynx/subscriptions","organizations_url":"https://api.github.com/users/kynx/orgs","repos_url":"https://api.github.com/users/kynx/repos","events_url":"https://api.github.com/users/kynx/events{/privacy}","received_events_url":"https://api.github.com/users/kynx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kynx/homebrew","description":":beer: The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/kynx/homebrew","forks_url":"https://api.github.com/repos/kynx/homebrew/forks","keys_url":"https://api.github.com/repos/kynx/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kynx/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kynx/homebrew/teams","hooks_url":"https://api.github.com/repos/kynx/homebrew/hooks","issue_events_url":"https://api.github.com/repos/kynx/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/kynx/homebrew/events","assignees_url":"https://api.github.com/repos/kynx/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/kynx/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/kynx/homebrew/tags","blobs_url":"https://api.github.com/repos/kynx/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kynx/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kynx/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/kynx/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kynx/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/kynx/homebrew/languages","stargazers_url":"https://api.github.com/repos/kynx/homebrew/stargazers","contributors_url":"https://api.github.com/repos/kynx/homebrew/contributors","subscribers_url":"https://api.github.com/repos/kynx/homebrew/subscribers","subscription_url":"https://api.github.com/repos/kynx/homebrew/subscription","commits_url":"https://api.github.com/repos/kynx/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/kynx/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/kynx/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/kynx/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/kynx/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/kynx/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kynx/homebrew/merges","archive_url":"https://api.github.com/repos/kynx/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kynx/homebrew/downloads","issues_url":"https://api.github.com/repos/kynx/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/kynx/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/kynx/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/kynx/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kynx/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/kynx/homebrew/releases{/id}","created_at":"2015-11-29T18:08:24Z","updated_at":"2015-11-29T18:08:53Z","pushed_at":"2015-12-22T01:23:54Z","git_url":"git://github.com/kynx/homebrew.git","ssh_url":"git@github.com:kynx/homebrew.git","clone_url":"https://github.com/kynx/homebrew.git","svn_url":"https://github.com/kynx/homebrew","homepage":"http://brew.sh","size":64395,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"2ae9b385ff174db4e1ac713f47a88c0e7034c516","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":":beer: The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2015-12-22T00:55:48Z","pushed_at":"2015-12-22T01:31:00Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1405787,"stargazers_count":28015,"watchers_count":28015,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":13875,"mirror_url":null,"open_issues_count":440,"forks":13875,"open_issues":440,"watchers":28015,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/47232"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/47232"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/47232"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/47232/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/47232/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/47232/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/1ef2d5f6a2e240da7da3c159fa923a07d8aedead"}}}}