{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/stan/issues/1243","labels_url":"https://api.github.com/repos/stan-dev/stan/issues/1243/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/stan/issues/1243/comments","events_url":"https://api.github.com/repos/stan-dev/stan/issues/1243/events","html_url":"https://github.com/stan-dev/stan/pull/1243","id":55538483,"number":1243,"title":"Adding a logistic model as a performance test.","user":{"login":"syclik","id":425751,"avatar_url":"https://avatars.githubusercontent.com/u/425751?v=3","gravatar_id":"","url":"https://api.github.com/users/syclik","html_url":"https://github.com/syclik","followers_url":"https://api.github.com/users/syclik/followers","following_url":"https://api.github.com/users/syclik/following{/other_user}","gists_url":"https://api.github.com/users/syclik/gists{/gist_id}","starred_url":"https://api.github.com/users/syclik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syclik/subscriptions","organizations_url":"https://api.github.com/users/syclik/orgs","repos_url":"https://api.github.com/users/syclik/repos","events_url":"https://api.github.com/users/syclik/events{/privacy}","received_events_url":"https://api.github.com/users/syclik/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/stan-dev/stan/milestones/12","labels_url":"https://api.github.com/repos/stan-dev/stan/milestones/12/labels","id":780121,"number":12,"title":"v2.6.0","description":"The next Stan version after v2.5.0.","creator":{"login":"syclik","id":425751,"avatar_url":"https://avatars.githubusercontent.com/u/425751?v=3","gravatar_id":"","url":"https://api.github.com/users/syclik","html_url":"https://github.com/syclik","followers_url":"https://api.github.com/users/syclik/followers","following_url":"https://api.github.com/users/syclik/following{/other_user}","gists_url":"https://api.github.com/users/syclik/gists{/gist_id}","starred_url":"https://api.github.com/users/syclik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syclik/subscriptions","organizations_url":"https://api.github.com/users/syclik/orgs","repos_url":"https://api.github.com/users/syclik/repos","events_url":"https://api.github.com/users/syclik/events{/privacy}","received_events_url":"https://api.github.com/users/syclik/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":202,"state":"open","created_at":"2014-09-05T18:29:38Z","updated_at":"2015-01-27T16:30:45Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-01-26T21:14:57Z","updated_at":"2015-01-27T18:07:31Z","closed_at":"2015-01-27T16:30:36Z","pull_request":{"url":"https://api.github.com/repos/stan-dev/stan/pulls/1243","html_url":"https://github.com/stan-dev/stan/pull/1243","diff_url":"https://github.com/stan-dev/stan/pull/1243.diff","patch_url":"https://github.com/stan-dev/stan/pull/1243.patch"},"body":"#### Summary:\r\n\r\nAdds a logistic model as a performance test.\r\n\r\n#### Intended Effect:\r\n\r\nJust adds a test to be used in benchmarking Stan's speed. It's not meant to catch everything.\r\n\r\n#### How to Verify:\r\n\r\nRun: \r\n`> ./runTests.py src/test/performance/logistic_test.cpp`\r\n\r\nThis will create a csv file in `test/performance/performance.csv` that records the model run 100 times, whether the numbers match the last tagged values, and whether all the values are the same.\r\n\r\n#### Side Effects:\r\n\r\nNone. This only touches tests.\r\n\r\n#### Documentation:\r\n\r\nNone.\r\n\r\n#### Reviewer Suggestions: \r\n\r\nAnyone. It should be merged soon so I can get Jenkins to display these numbers going forward."},"comment":{"url":"https://api.github.com/repos/stan-dev/stan/issues/comments/71696694","html_url":"https://github.com/stan-dev/stan/pull/1243#issuecomment-71696694","issue_url":"https://api.github.com/repos/stan-dev/stan/issues/1243","id":71696694,"user":{"login":"bob-carpenter","id":3383807,"avatar_url":"https://avatars.githubusercontent.com/u/3383807?v=3","gravatar_id":"","url":"https://api.github.com/users/bob-carpenter","html_url":"https://github.com/bob-carpenter","followers_url":"https://api.github.com/users/bob-carpenter/followers","following_url":"https://api.github.com/users/bob-carpenter/following{/other_user}","gists_url":"https://api.github.com/users/bob-carpenter/gists{/gist_id}","starred_url":"https://api.github.com/users/bob-carpenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bob-carpenter/subscriptions","organizations_url":"https://api.github.com/users/bob-carpenter/orgs","repos_url":"https://api.github.com/users/bob-carpenter/repos","events_url":"https://api.github.com/users/bob-carpenter/events{/privacy}","received_events_url":"https://api.github.com/users/bob-carpenter/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T18:07:31Z","updated_at":"2015-01-27T18:07:31Z","body":"I added some comments inline. \r\n\r\nMy biggest request, given that we're now testing all this,\r\nis that we have some spec for the output so we know what's\r\nexpected and what can be changed without breaking all the tests.\r\n\r\nWill this test break if we change RNG or seed?  I'm still very\r\nnervous about maintaining tests like this going forward\r\nthat just freeze existing behavior.  Checking the fit of the\r\nmodel is one thing, but testing we get to the same adaptation\r\nseems dangerous.\r\n\r\nDo you expect this test to be updated each release?  \r\nIt has comments that are 2.5.0 specific as \"last tagged \r\nrelease\".\r\n\r\nI was confused by parse_command_output.  Could you doc\r\nwhat the format is that it's parsing?  Is it just\r\na bunch of key=value pairs, one per line?  \r\n\r\n- Bob\r\n\r\n> On Jan 27, 2015, at 11:30 AM, Daniel Lee <notifications@github.com> wrote:\r\n> \r\n> I'm going to break protocol and merge this so I can start getting Jenkins to run this. Can someone take a look and let me know if it looks alright? If anything seems off, I'll patch it with a pull request later.\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.\r\n> "}}