{"action":"created","comment":{"url":"https://api.github.com/repos/siddontang/ledisdb/pulls/comments/39343872","id":39343872,"diff_hunk":"@@ -64,6 +64,8 @@ type client struct {\n \tcmd        string\n \targs       [][]byte\n \n+\tis_authed bool","path":"server/client.go","position":4,"original_position":4,"commit_id":"d48cb8c7739d385e92b25a82c8004fcc1c9fd823","original_commit_id":"d48cb8c7739d385e92b25a82c8004fcc1c9fd823","user":{"login":"siddontang","id":1080370,"avatar_url":"https://avatars.githubusercontent.com/u/1080370?v=3","gravatar_id":"","url":"https://api.github.com/users/siddontang","html_url":"https://github.com/siddontang","followers_url":"https://api.github.com/users/siddontang/followers","following_url":"https://api.github.com/users/siddontang/following{/other_user}","gists_url":"https://api.github.com/users/siddontang/gists{/gist_id}","starred_url":"https://api.github.com/users/siddontang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddontang/subscriptions","organizations_url":"https://api.github.com/users/siddontang/orgs","repos_url":"https://api.github.com/users/siddontang/repos","events_url":"https://api.github.com/users/siddontang/events{/privacy}","received_events_url":"https://api.github.com/users/siddontang/received_events","type":"User","site_admin":false},"body":"The variable format is_authed is not suggested in Go. we could use isAuthed or other camel format instead. :-)","created_at":"2015-09-13T02:49:11Z","updated_at":"2015-09-13T02:49:11Z","html_url":"https://github.com/siddontang/ledisdb/pull/183#discussion_r39343872","pull_request_url":"https://api.github.com/repos/siddontang/ledisdb/pulls/183","_links":{"self":{"href":"https://api.github.com/repos/siddontang/ledisdb/pulls/comments/39343872"},"html":{"href":"https://github.com/siddontang/ledisdb/pull/183#discussion_r39343872"},"pull_request":{"href":"https://api.github.com/repos/siddontang/ledisdb/pulls/183"}}},"pull_request":{"url":"https://api.github.com/repos/siddontang/ledisdb/pulls/183","id":44864357,"html_url":"https://github.com/siddontang/ledisdb/pull/183","diff_url":"https://github.com/siddontang/ledisdb/pull/183.diff","patch_url":"https://github.com/siddontang/ledisdb/pull/183.patch","issue_url":"https://api.github.com/repos/siddontang/ledisdb/issues/183","number":183,"state":"open","locked":false,"title":"Attempt at Auth :)","user":{"login":"ukd1","id":44345,"avatar_url":"https://avatars.githubusercontent.com/u/44345?v=3","gravatar_id":"","url":"https://api.github.com/users/ukd1","html_url":"https://github.com/ukd1","followers_url":"https://api.github.com/users/ukd1/followers","following_url":"https://api.github.com/users/ukd1/following{/other_user}","gists_url":"https://api.github.com/users/ukd1/gists{/gist_id}","starred_url":"https://api.github.com/users/ukd1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukd1/subscriptions","organizations_url":"https://api.github.com/users/ukd1/orgs","repos_url":"https://api.github.com/users/ukd1/repos","events_url":"https://api.github.com/users/ukd1/events{/privacy}","received_events_url":"https://api.github.com/users/ukd1/received_events","type":"User","site_admin":false},"body":"@siddontang this is my attempt at #182 :+1: ","created_at":"2015-09-13T00:48:16Z","updated_at":"2015-09-13T02:49:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb562b48f68b7c20f75169491060cdddef7c22ca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/siddontang/ledisdb/pulls/183/commits","review_comments_url":"https://api.github.com/repos/siddontang/ledisdb/pulls/183/comments","review_comment_url":"https://api.github.com/repos/siddontang/ledisdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/siddontang/ledisdb/issues/183/comments","statuses_url":"https://api.github.com/repos/siddontang/ledisdb/statuses/d48cb8c7739d385e92b25a82c8004fcc1c9fd823","head":{"label":"ukd1:auth-v1","ref":"auth-v1","sha":"d48cb8c7739d385e92b25a82c8004fcc1c9fd823","user":{"login":"ukd1","id":44345,"avatar_url":"https://avatars.githubusercontent.com/u/44345?v=3","gravatar_id":"","url":"https://api.github.com/users/ukd1","html_url":"https://github.com/ukd1","followers_url":"https://api.github.com/users/ukd1/followers","following_url":"https://api.github.com/users/ukd1/following{/other_user}","gists_url":"https://api.github.com/users/ukd1/gists{/gist_id}","starred_url":"https://api.github.com/users/ukd1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukd1/subscriptions","organizations_url":"https://api.github.com/users/ukd1/orgs","repos_url":"https://api.github.com/users/ukd1/repos","events_url":"https://api.github.com/users/ukd1/events{/privacy}","received_events_url":"https://api.github.com/users/ukd1/received_events","type":"User","site_admin":false},"repo":{"id":42338131,"name":"ledisdb","full_name":"ukd1/ledisdb","owner":{"login":"ukd1","id":44345,"avatar_url":"https://avatars.githubusercontent.com/u/44345?v=3","gravatar_id":"","url":"https://api.github.com/users/ukd1","html_url":"https://github.com/ukd1","followers_url":"https://api.github.com/users/ukd1/followers","following_url":"https://api.github.com/users/ukd1/following{/other_user}","gists_url":"https://api.github.com/users/ukd1/gists{/gist_id}","starred_url":"https://api.github.com/users/ukd1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukd1/subscriptions","organizations_url":"https://api.github.com/users/ukd1/orgs","repos_url":"https://api.github.com/users/ukd1/repos","events_url":"https://api.github.com/users/ukd1/events{/privacy}","received_events_url":"https://api.github.com/users/ukd1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ukd1/ledisdb","description":"a high performance NoSQL powered by Go","fork":true,"url":"https://api.github.com/repos/ukd1/ledisdb","forks_url":"https://api.github.com/repos/ukd1/ledisdb/forks","keys_url":"https://api.github.com/repos/ukd1/ledisdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ukd1/ledisdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ukd1/ledisdb/teams","hooks_url":"https://api.github.com/repos/ukd1/ledisdb/hooks","issue_events_url":"https://api.github.com/repos/ukd1/ledisdb/issues/events{/number}","events_url":"https://api.github.com/repos/ukd1/ledisdb/events","assignees_url":"https://api.github.com/repos/ukd1/ledisdb/assignees{/user}","branches_url":"https://api.github.com/repos/ukd1/ledisdb/branches{/branch}","tags_url":"https://api.github.com/repos/ukd1/ledisdb/tags","blobs_url":"https://api.github.com/repos/ukd1/ledisdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ukd1/ledisdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ukd1/ledisdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ukd1/ledisdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ukd1/ledisdb/statuses/{sha}","languages_url":"https://api.github.com/repos/ukd1/ledisdb/languages","stargazers_url":"https://api.github.com/repos/ukd1/ledisdb/stargazers","contributors_url":"https://api.github.com/repos/ukd1/ledisdb/contributors","subscribers_url":"https://api.github.com/repos/ukd1/ledisdb/subscribers","subscription_url":"https://api.github.com/repos/ukd1/ledisdb/subscription","commits_url":"https://api.github.com/repos/ukd1/ledisdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ukd1/ledisdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ukd1/ledisdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ukd1/ledisdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ukd1/ledisdb/contents/{+path}","compare_url":"https://api.github.com/repos/ukd1/ledisdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ukd1/ledisdb/merges","archive_url":"https://api.github.com/repos/ukd1/ledisdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ukd1/ledisdb/downloads","issues_url":"https://api.github.com/repos/ukd1/ledisdb/issues{/number}","pulls_url":"https://api.github.com/repos/ukd1/ledisdb/pulls{/number}","milestones_url":"https://api.github.com/repos/ukd1/ledisdb/milestones{/number}","notifications_url":"https://api.github.com/repos/ukd1/ledisdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ukd1/ledisdb/labels{/name}","releases_url":"https://api.github.com/repos/ukd1/ledisdb/releases{/id}","created_at":"2015-09-12T00:18:03Z","updated_at":"2015-09-12T00:18:04Z","pushed_at":"2015-09-13T02:35:14Z","git_url":"git://github.com/ukd1/ledisdb.git","ssh_url":"git@github.com:ukd1/ledisdb.git","clone_url":"https://github.com/ukd1/ledisdb.git","svn_url":"https://github.com/ukd1/ledisdb","homepage":"ledisdb.com","size":5613,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"siddontang:master","ref":"master","sha":"8f582ee5fb48cd22c8f89683b152a022ed03e2e6","user":{"login":"siddontang","id":1080370,"avatar_url":"https://avatars.githubusercontent.com/u/1080370?v=3","gravatar_id":"","url":"https://api.github.com/users/siddontang","html_url":"https://github.com/siddontang","followers_url":"https://api.github.com/users/siddontang/followers","following_url":"https://api.github.com/users/siddontang/following{/other_user}","gists_url":"https://api.github.com/users/siddontang/gists{/gist_id}","starred_url":"https://api.github.com/users/siddontang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddontang/subscriptions","organizations_url":"https://api.github.com/users/siddontang/orgs","repos_url":"https://api.github.com/users/siddontang/repos","events_url":"https://api.github.com/users/siddontang/events{/privacy}","received_events_url":"https://api.github.com/users/siddontang/received_events","type":"User","site_admin":false},"repo":{"id":19296225,"name":"ledisdb","full_name":"siddontang/ledisdb","owner":{"login":"siddontang","id":1080370,"avatar_url":"https://avatars.githubusercontent.com/u/1080370?v=3","gravatar_id":"","url":"https://api.github.com/users/siddontang","html_url":"https://github.com/siddontang","followers_url":"https://api.github.com/users/siddontang/followers","following_url":"https://api.github.com/users/siddontang/following{/other_user}","gists_url":"https://api.github.com/users/siddontang/gists{/gist_id}","starred_url":"https://api.github.com/users/siddontang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddontang/subscriptions","organizations_url":"https://api.github.com/users/siddontang/orgs","repos_url":"https://api.github.com/users/siddontang/repos","events_url":"https://api.github.com/users/siddontang/events{/privacy}","received_events_url":"https://api.github.com/users/siddontang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/siddontang/ledisdb","description":"a high performance NoSQL powered by Go","fork":false,"url":"https://api.github.com/repos/siddontang/ledisdb","forks_url":"https://api.github.com/repos/siddontang/ledisdb/forks","keys_url":"https://api.github.com/repos/siddontang/ledisdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siddontang/ledisdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siddontang/ledisdb/teams","hooks_url":"https://api.github.com/repos/siddontang/ledisdb/hooks","issue_events_url":"https://api.github.com/repos/siddontang/ledisdb/issues/events{/number}","events_url":"https://api.github.com/repos/siddontang/ledisdb/events","assignees_url":"https://api.github.com/repos/siddontang/ledisdb/assignees{/user}","branches_url":"https://api.github.com/repos/siddontang/ledisdb/branches{/branch}","tags_url":"https://api.github.com/repos/siddontang/ledisdb/tags","blobs_url":"https://api.github.com/repos/siddontang/ledisdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siddontang/ledisdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siddontang/ledisdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/siddontang/ledisdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siddontang/ledisdb/statuses/{sha}","languages_url":"https://api.github.com/repos/siddontang/ledisdb/languages","stargazers_url":"https://api.github.com/repos/siddontang/ledisdb/stargazers","contributors_url":"https://api.github.com/repos/siddontang/ledisdb/contributors","subscribers_url":"https://api.github.com/repos/siddontang/ledisdb/subscribers","subscription_url":"https://api.github.com/repos/siddontang/ledisdb/subscription","commits_url":"https://api.github.com/repos/siddontang/ledisdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/siddontang/ledisdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/siddontang/ledisdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/siddontang/ledisdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/siddontang/ledisdb/contents/{+path}","compare_url":"https://api.github.com/repos/siddontang/ledisdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siddontang/ledisdb/merges","archive_url":"https://api.github.com/repos/siddontang/ledisdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siddontang/ledisdb/downloads","issues_url":"https://api.github.com/repos/siddontang/ledisdb/issues{/number}","pulls_url":"https://api.github.com/repos/siddontang/ledisdb/pulls{/number}","milestones_url":"https://api.github.com/repos/siddontang/ledisdb/milestones{/number}","notifications_url":"https://api.github.com/repos/siddontang/ledisdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siddontang/ledisdb/labels{/name}","releases_url":"https://api.github.com/repos/siddontang/ledisdb/releases{/id}","created_at":"2014-04-30T00:43:09Z","updated_at":"2015-09-13T02:31:35Z","pushed_at":"2015-09-13T02:35:14Z","git_url":"git://github.com/siddontang/ledisdb.git","ssh_url":"git@github.com:siddontang/ledisdb.git","clone_url":"https://github.com/siddontang/ledisdb.git","svn_url":"https://github.com/siddontang/ledisdb","homepage":"ledisdb.com","size":5613,"stargazers_count":1320,"watchers_count":1320,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":139,"mirror_url":null,"open_issues_count":29,"forks":139,"open_issues":29,"watchers":1320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/siddontang/ledisdb/pulls/183"},"html":{"href":"https://github.com/siddontang/ledisdb/pull/183"},"issue":{"href":"https://api.github.com/repos/siddontang/ledisdb/issues/183"},"comments":{"href":"https://api.github.com/repos/siddontang/ledisdb/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/siddontang/ledisdb/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/siddontang/ledisdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/siddontang/ledisdb/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/siddontang/ledisdb/statuses/d48cb8c7739d385e92b25a82c8004fcc1c9fd823"}}}}