{"action":"created","comment":{"url":"https://api.github.com/repos/junkdog/artemis-odb/pulls/comments/39778543","id":39778543,"diff_hunk":"@@ -13,6 +13,15 @@\n \t<description>Debug agent, standard library but with more safety checks.</description>\n \t<url>https://github.com/junkdog/artemis-odb</url>\n \n+\t<dependencies>\n+\t\t<dependency>\n+\t\t\t<groupId>org.mockito</groupId>\n+\t\t\t<artifactId>mockito-all</artifactId>\n+\t\t\t<version>1.9.5</version>\n+\t\t\t<scope>test</scope>\n+\t\t</dependency>\n+\t</dependencies>\n+","path":"artemis-debug/pom.xml","position":12,"original_position":12,"commit_id":"eb5db3a92cd21a514ffcf2bf81b5bd2ad38dfd9c","original_commit_id":"eb5db3a92cd21a514ffcf2bf81b5bd2ad38dfd9c","user":{"login":"DaanVanYperen","id":6305602,"avatar_url":"https://avatars.githubusercontent.com/u/6305602?v=3","gravatar_id":"","url":"https://api.github.com/users/DaanVanYperen","html_url":"https://github.com/DaanVanYperen","followers_url":"https://api.github.com/users/DaanVanYperen/followers","following_url":"https://api.github.com/users/DaanVanYperen/following{/other_user}","gists_url":"https://api.github.com/users/DaanVanYperen/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanVanYperen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanVanYperen/subscriptions","organizations_url":"https://api.github.com/users/DaanVanYperen/orgs","repos_url":"https://api.github.com/users/DaanVanYperen/repos","events_url":"https://api.github.com/users/DaanVanYperen/events{/privacy}","received_events_url":"https://api.github.com/users/DaanVanYperen/received_events","type":"User","site_admin":false},"body":"I was too lazy to rewrite the test. D:","created_at":"2015-09-17T18:06:38Z","updated_at":"2015-09-17T18:06:38Z","html_url":"https://github.com/junkdog/artemis-odb/pull/361#discussion_r39778543","pull_request_url":"https://api.github.com/repos/junkdog/artemis-odb/pulls/361","_links":{"self":{"href":"https://api.github.com/repos/junkdog/artemis-odb/pulls/comments/39778543"},"html":{"href":"https://github.com/junkdog/artemis-odb/pull/361#discussion_r39778543"},"pull_request":{"href":"https://api.github.com/repos/junkdog/artemis-odb/pulls/361"}}},"pull_request":{"url":"https://api.github.com/repos/junkdog/artemis-odb/pulls/361","id":45309382,"html_url":"https://github.com/junkdog/artemis-odb/pull/361","diff_url":"https://github.com/junkdog/artemis-odb/pull/361.diff","patch_url":"https://github.com/junkdog/artemis-odb/pull/361.patch","issue_url":"https://api.github.com/repos/junkdog/artemis-odb/issues/361","number":361,"state":"open","locked":false,"title":"Port WorldConfigurationBuilder and Plugin API","user":{"login":"DaanVanYperen","id":6305602,"avatar_url":"https://avatars.githubusercontent.com/u/6305602?v=3","gravatar_id":"","url":"https://api.github.com/users/DaanVanYperen","html_url":"https://github.com/DaanVanYperen","followers_url":"https://api.github.com/users/DaanVanYperen/followers","following_url":"https://api.github.com/users/DaanVanYperen/following{/other_user}","gists_url":"https://api.github.com/users/DaanVanYperen/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanVanYperen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanVanYperen/subscriptions","organizations_url":"https://api.github.com/users/DaanVanYperen/orgs","repos_url":"https://api.github.com/users/DaanVanYperen/repos","events_url":"https://api.github.com/users/DaanVanYperen/events{/privacy}","received_events_url":"https://api.github.com/users/DaanVanYperen/received_events","type":"User","site_admin":false},"body":"Ports features incubated on contrib: WorldConfigurationBuilder and Plugin API.\r\n\r\n@junkdog There's room for improvement in the implementation of priority, perhaps flipping the order makes sense, perhaps we need to expand on the example priority levels.\r\n@gjroelofs Plugin API might be useful for DSL plugin, if configuration is required, or expect some pivots along the road that you want to blackbox for the user. It's pretty young API so feel free to PR as needed.\r\n\r\n## Configuration builder\r\n\r\n### Why\r\n\r\nConvenience var-arg addition of systems, managers. Supports [[plugins|Plugin]].\r\n\r\n### Usage\r\n\r\n```java\r\nWorldConfiguration config = new WorldConfigurationBuilder()\r\n   .with( new MyManagerA(), new MyManagerB()  ) \r\n   .with( new MySystemA(), new MySystemB(), new MySystemN()  )\r\n   .with( new MyPluginA(), new MyPluginB(), new MyPluginN()  )\r\n   .register( new MyDIResolver())\r\n   .build();\r\n```\r\n\r\n### Order\r\n\r\nOrder of addition is preserved, but can be overridden.<br/>\r\nThis is especially useful for writing [[plugins|Plugin]].\r\n\r\n```java\r\n  .with( WorldConfigurationBuilder.Priority.HIGH + 1, new MyPluginA())\r\n```\r\n\r\nArtemis-odb calls systems and managers from highest to lowest priority.<br/> \r\nDefault priority is `NORMAL`.\r\n\r\n## Plugin API\r\n\r\nPackages your artemis-odb extensions as a drop in plugin!\r\n\r\n### Why\r\n\r\n- Users can add your odb extension with a single line of code. \r\n- Allows other plugin developers to build upon your extension.\r\n- Avoids dependency clashes with other extensions.\r\n- Inject systems/managers before/after others.\r\n\r\n### How?\r\n\r\nImplement `ArtemisPlugin`. Register dependencies via `WorldConfigurationBuilder`.\r\n\r\n### Special note about Dependencies\r\n\r\nWhen adding plugin dependencies, use `WorldConfigurationBuilder#dependsOn` instead of `#wire`. `#DependsOn` ensures dependencies that already exist are not instanced twice. The game itself is not required to use `#DependsOn` as non plugin systems/managers will be instanced before any plugins.\r\n\r\nsee [[WorldConfigurationBuilder]] for all options.\r\n\r\n### Example\r\n\r\n```java\r\npublic class MyPlugin implements ArtemisPlugin {\r\n\r\n    @Override\r\n    public void setup(WorldConfigurationBuilder b) {\r\n\r\n        // hook plugins.\r\n        b.dependsOn(ExtendedComponentMapperPlugin.class);\r\n\r\n        // hook managers or systems.\r\n        b.dependsOn(TagManager.class, GroupManager.class);\r\n        b.dependsOn(MySystemA.class, MySystemB.class);\r\n\r\n        // Optionally Specify loading order.\r\n        b.with(WorldConfigurationBuilder.Priority.HIGH, new LoadFirstSystem());\r\n\r\n        // And your custom DI features!\r\n        b.register(new MyFieldResolver());\r\n    }\r\n}\r\n```\r\n\r\n### Using\r\n\r\n```java\r\n  WorldConfiguration myConfig = new WorldConfigurationBuilder()\r\n                .with(new TagManager())\r\n                .with(new MyGameSystemA(), new MyGameSystemB())\r\n                .with(new MyPlugin())\r\n                .build();\r\n```","created_at":"2015-09-17T16:06:51Z","updated_at":"2015-09-17T18:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac77848b6ced352060ab31319ac99ca22274efc7","assignee":{"login":"junkdog","id":804039,"avatar_url":"https://avatars.githubusercontent.com/u/804039?v=3","gravatar_id":"","url":"https://api.github.com/users/junkdog","html_url":"https://github.com/junkdog","followers_url":"https://api.github.com/users/junkdog/followers","following_url":"https://api.github.com/users/junkdog/following{/other_user}","gists_url":"https://api.github.com/users/junkdog/gists{/gist_id}","starred_url":"https://api.github.com/users/junkdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junkdog/subscriptions","organizations_url":"https://api.github.com/users/junkdog/orgs","repos_url":"https://api.github.com/users/junkdog/repos","events_url":"https://api.github.com/users/junkdog/events{/privacy}","received_events_url":"https://api.github.com/users/junkdog/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/junkdog/artemis-odb/milestones/9","html_url":"https://github.com/junkdog/artemis-odb/milestones/artemis-1.0.0","labels_url":"https://api.github.com/repos/junkdog/artemis-odb/milestones/9/labels","id":796135,"number":9,"title":"artemis-1.0.0","description":"","creator":{"login":"junkdog","id":804039,"avatar_url":"https://avatars.githubusercontent.com/u/804039?v=3","gravatar_id":"","url":"https://api.github.com/users/junkdog","html_url":"https://github.com/junkdog","followers_url":"https://api.github.com/users/junkdog/followers","following_url":"https://api.github.com/users/junkdog/following{/other_user}","gists_url":"https://api.github.com/users/junkdog/gists{/gist_id}","starred_url":"https://api.github.com/users/junkdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junkdog/subscriptions","organizations_url":"https://api.github.com/users/junkdog/orgs","repos_url":"https://api.github.com/users/junkdog/repos","events_url":"https://api.github.com/users/junkdog/events{/privacy}","received_events_url":"https://api.github.com/users/junkdog/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":14,"state":"open","created_at":"2014-09-19T18:38:28Z","updated_at":"2015-09-17T18:05:56Z","due_on":"2015-01-20T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/junkdog/artemis-odb/pulls/361/commits","review_comments_url":"https://api.github.com/repos/junkdog/artemis-odb/pulls/361/comments","review_comment_url":"https://api.github.com/repos/junkdog/artemis-odb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/junkdog/artemis-odb/issues/361/comments","statuses_url":"https://api.github.com/repos/junkdog/artemis-odb/statuses/eb5db3a92cd21a514ffcf2bf81b5bd2ad38dfd9c","head":{"label":"junkdog:feature-plugin-api","ref":"feature-plugin-api","sha":"eb5db3a92cd21a514ffcf2bf81b5bd2ad38dfd9c","user":{"login":"junkdog","id":804039,"avatar_url":"https://avatars.githubusercontent.com/u/804039?v=3","gravatar_id":"","url":"https://api.github.com/users/junkdog","html_url":"https://github.com/junkdog","followers_url":"https://api.github.com/users/junkdog/followers","following_url":"https://api.github.com/users/junkdog/following{/other_user}","gists_url":"https://api.github.com/users/junkdog/gists{/gist_id}","starred_url":"https://api.github.com/users/junkdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junkdog/subscriptions","organizations_url":"https://api.github.com/users/junkdog/orgs","repos_url":"https://api.github.com/users/junkdog/repos","events_url":"https://api.github.com/users/junkdog/events{/privacy}","received_events_url":"https://api.github.com/users/junkdog/received_events","type":"User","site_admin":false},"repo":{"id":6331476,"name":"artemis-odb","full_name":"junkdog/artemis-odb","owner":{"login":"junkdog","id":804039,"avatar_url":"https://avatars.githubusercontent.com/u/804039?v=3","gravatar_id":"","url":"https://api.github.com/users/junkdog","html_url":"https://github.com/junkdog","followers_url":"https://api.github.com/users/junkdog/followers","following_url":"https://api.github.com/users/junkdog/following{/other_user}","gists_url":"https://api.github.com/users/junkdog/gists{/gist_id}","starred_url":"https://api.github.com/users/junkdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junkdog/subscriptions","organizations_url":"https://api.github.com/users/junkdog/orgs","repos_url":"https://api.github.com/users/junkdog/repos","events_url":"https://api.github.com/users/junkdog/events{/privacy}","received_events_url":"https://api.github.com/users/junkdog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/junkdog/artemis-odb","description":"A continuation of the popular Artemis ECS framework","fork":false,"url":"https://api.github.com/repos/junkdog/artemis-odb","forks_url":"https://api.github.com/repos/junkdog/artemis-odb/forks","keys_url":"https://api.github.com/repos/junkdog/artemis-odb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junkdog/artemis-odb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junkdog/artemis-odb/teams","hooks_url":"https://api.github.com/repos/junkdog/artemis-odb/hooks","issue_events_url":"https://api.github.com/repos/junkdog/artemis-odb/issues/events{/number}","events_url":"https://api.github.com/repos/junkdog/artemis-odb/events","assignees_url":"https://api.github.com/repos/junkdog/artemis-odb/assignees{/user}","branches_url":"https://api.github.com/repos/junkdog/artemis-odb/branches{/branch}","tags_url":"https://api.github.com/repos/junkdog/artemis-odb/tags","blobs_url":"https://api.github.com/repos/junkdog/artemis-odb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junkdog/artemis-odb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junkdog/artemis-odb/git/refs{/sha}","trees_url":"https://api.github.com/repos/junkdog/artemis-odb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junkdog/artemis-odb/statuses/{sha}","languages_url":"https://api.github.com/repos/junkdog/artemis-odb/languages","stargazers_url":"https://api.github.com/repos/junkdog/artemis-odb/stargazers","contributors_url":"https://api.github.com/repos/junkdog/artemis-odb/contributors","subscribers_url":"https://api.github.com/repos/junkdog/artemis-odb/subscribers","subscription_url":"https://api.github.com/repos/junkdog/artemis-odb/subscription","commits_url":"https://api.github.com/repos/junkdog/artemis-odb/commits{/sha}","git_commits_url":"https://api.github.com/repos/junkdog/artemis-odb/git/commits{/sha}","comments_url":"https://api.github.com/repos/junkdog/artemis-odb/comments{/number}","issue_comment_url":"https://api.github.com/repos/junkdog/artemis-odb/issues/comments{/number}","contents_url":"https://api.github.com/repos/junkdog/artemis-odb/contents/{+path}","compare_url":"https://api.github.com/repos/junkdog/artemis-odb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junkdog/artemis-odb/merges","archive_url":"https://api.github.com/repos/junkdog/artemis-odb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junkdog/artemis-odb/downloads","issues_url":"https://api.github.com/repos/junkdog/artemis-odb/issues{/number}","pulls_url":"https://api.github.com/repos/junkdog/artemis-odb/pulls{/number}","milestones_url":"https://api.github.com/repos/junkdog/artemis-odb/milestones{/number}","notifications_url":"https://api.github.com/repos/junkdog/artemis-odb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junkdog/artemis-odb/labels{/name}","releases_url":"https://api.github.com/repos/junkdog/artemis-odb/releases{/id}","created_at":"2012-10-22T08:09:23Z","updated_at":"2015-09-16T17:37:53Z","pushed_at":"2015-09-17T18:04:52Z","git_url":"git://github.com/junkdog/artemis-odb.git","ssh_url":"git@github.com:junkdog/artemis-odb.git","clone_url":"https://github.com/junkdog/artemis-odb.git","svn_url":"https://github.com/junkdog/artemis-odb","homepage":"","size":5429,"stargazers_count":163,"watchers_count":163,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":19,"forks":29,"open_issues":19,"watchers":163,"default_branch":"master"}},"base":{"label":"junkdog:master","ref":"master","sha":"ae65de5bbe6d656a440057bf5265686875a7b1c2","user":{"login":"junkdog","id":804039,"avatar_url":"https://avatars.githubusercontent.com/u/804039?v=3","gravatar_id":"","url":"https://api.github.com/users/junkdog","html_url":"https://github.com/junkdog","followers_url":"https://api.github.com/users/junkdog/followers","following_url":"https://api.github.com/users/junkdog/following{/other_user}","gists_url":"https://api.github.com/users/junkdog/gists{/gist_id}","starred_url":"https://api.github.com/users/junkdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junkdog/subscriptions","organizations_url":"https://api.github.com/users/junkdog/orgs","repos_url":"https://api.github.com/users/junkdog/repos","events_url":"https://api.github.com/users/junkdog/events{/privacy}","received_events_url":"https://api.github.com/users/junkdog/received_events","type":"User","site_admin":false},"repo":{"id":6331476,"name":"artemis-odb","full_name":"junkdog/artemis-odb","owner":{"login":"junkdog","id":804039,"avatar_url":"https://avatars.githubusercontent.com/u/804039?v=3","gravatar_id":"","url":"https://api.github.com/users/junkdog","html_url":"https://github.com/junkdog","followers_url":"https://api.github.com/users/junkdog/followers","following_url":"https://api.github.com/users/junkdog/following{/other_user}","gists_url":"https://api.github.com/users/junkdog/gists{/gist_id}","starred_url":"https://api.github.com/users/junkdog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junkdog/subscriptions","organizations_url":"https://api.github.com/users/junkdog/orgs","repos_url":"https://api.github.com/users/junkdog/repos","events_url":"https://api.github.com/users/junkdog/events{/privacy}","received_events_url":"https://api.github.com/users/junkdog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/junkdog/artemis-odb","description":"A continuation of the popular Artemis ECS framework","fork":false,"url":"https://api.github.com/repos/junkdog/artemis-odb","forks_url":"https://api.github.com/repos/junkdog/artemis-odb/forks","keys_url":"https://api.github.com/repos/junkdog/artemis-odb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junkdog/artemis-odb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junkdog/artemis-odb/teams","hooks_url":"https://api.github.com/repos/junkdog/artemis-odb/hooks","issue_events_url":"https://api.github.com/repos/junkdog/artemis-odb/issues/events{/number}","events_url":"https://api.github.com/repos/junkdog/artemis-odb/events","assignees_url":"https://api.github.com/repos/junkdog/artemis-odb/assignees{/user}","branches_url":"https://api.github.com/repos/junkdog/artemis-odb/branches{/branch}","tags_url":"https://api.github.com/repos/junkdog/artemis-odb/tags","blobs_url":"https://api.github.com/repos/junkdog/artemis-odb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junkdog/artemis-odb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junkdog/artemis-odb/git/refs{/sha}","trees_url":"https://api.github.com/repos/junkdog/artemis-odb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junkdog/artemis-odb/statuses/{sha}","languages_url":"https://api.github.com/repos/junkdog/artemis-odb/languages","stargazers_url":"https://api.github.com/repos/junkdog/artemis-odb/stargazers","contributors_url":"https://api.github.com/repos/junkdog/artemis-odb/contributors","subscribers_url":"https://api.github.com/repos/junkdog/artemis-odb/subscribers","subscription_url":"https://api.github.com/repos/junkdog/artemis-odb/subscription","commits_url":"https://api.github.com/repos/junkdog/artemis-odb/commits{/sha}","git_commits_url":"https://api.github.com/repos/junkdog/artemis-odb/git/commits{/sha}","comments_url":"https://api.github.com/repos/junkdog/artemis-odb/comments{/number}","issue_comment_url":"https://api.github.com/repos/junkdog/artemis-odb/issues/comments{/number}","contents_url":"https://api.github.com/repos/junkdog/artemis-odb/contents/{+path}","compare_url":"https://api.github.com/repos/junkdog/artemis-odb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junkdog/artemis-odb/merges","archive_url":"https://api.github.com/repos/junkdog/artemis-odb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junkdog/artemis-odb/downloads","issues_url":"https://api.github.com/repos/junkdog/artemis-odb/issues{/number}","pulls_url":"https://api.github.com/repos/junkdog/artemis-odb/pulls{/number}","milestones_url":"https://api.github.com/repos/junkdog/artemis-odb/milestones{/number}","notifications_url":"https://api.github.com/repos/junkdog/artemis-odb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junkdog/artemis-odb/labels{/name}","releases_url":"https://api.github.com/repos/junkdog/artemis-odb/releases{/id}","created_at":"2012-10-22T08:09:23Z","updated_at":"2015-09-16T17:37:53Z","pushed_at":"2015-09-17T18:04:52Z","git_url":"git://github.com/junkdog/artemis-odb.git","ssh_url":"git@github.com:junkdog/artemis-odb.git","clone_url":"https://github.com/junkdog/artemis-odb.git","svn_url":"https://github.com/junkdog/artemis-odb","homepage":"","size":5429,"stargazers_count":163,"watchers_count":163,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":19,"forks":29,"open_issues":19,"watchers":163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junkdog/artemis-odb/pulls/361"},"html":{"href":"https://github.com/junkdog/artemis-odb/pull/361"},"issue":{"href":"https://api.github.com/repos/junkdog/artemis-odb/issues/361"},"comments":{"href":"https://api.github.com/repos/junkdog/artemis-odb/issues/361/comments"},"review_comments":{"href":"https://api.github.com/repos/junkdog/artemis-odb/pulls/361/comments"},"review_comment":{"href":"https://api.github.com/repos/junkdog/artemis-odb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/junkdog/artemis-odb/pulls/361/commits"},"statuses":{"href":"https://api.github.com/repos/junkdog/artemis-odb/statuses/eb5db3a92cd21a514ffcf2bf81b5bd2ad38dfd9c"}}}}