{"action":"created","issue":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/1701","labels_url":"https://api.github.com/repos/uProxy/uproxy/issues/1701/labels{/name}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/1701/comments","events_url":"https://api.github.com/repos/uProxy/uproxy/issues/1701/events","html_url":"https://github.com/uProxy/uproxy/pull/1701","id":92118264,"number":1701,"title":"Make icon look online on first install.","user":{"login":"lucyhe","id":8723127,"avatar_url":"https://avatars.githubusercontent.com/u/8723127?v=3","gravatar_id":"","url":"https://api.github.com/users/lucyhe","html_url":"https://github.com/lucyhe","followers_url":"https://api.github.com/users/lucyhe/followers","following_url":"https://api.github.com/users/lucyhe/following{/other_user}","gists_url":"https://api.github.com/users/lucyhe/gists{/gist_id}","starred_url":"https://api.github.com/users/lucyhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucyhe/subscriptions","organizations_url":"https://api.github.com/users/lucyhe/orgs","repos_url":"https://api.github.com/users/lucyhe/repos","events_url":"https://api.github.com/users/lucyhe/events{/privacy}","received_events_url":"https://api.github.com/users/lucyhe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-30T15:03:30Z","updated_at":"2015-07-06T14:03:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/1701","html_url":"https://github.com/uProxy/uproxy/pull/1701","diff_url":"https://github.com/uProxy/uproxy/pull/1701.diff","patch_url":"https://github.com/uProxy/uproxy/pull/1701.patch"},"body":"Fixes part of https://github.com/uProxy/uproxy/issues/1547\r\nRan grunt test/tested manually.\r\n\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/1701)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/comments/118865293","html_url":"https://github.com/uProxy/uproxy/pull/1701#issuecomment-118865293","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/1701","id":118865293,"user":{"login":"jpevarnek","id":902894,"avatar_url":"https://avatars.githubusercontent.com/u/902894?v=3","gravatar_id":"","url":"https://api.github.com/users/jpevarnek","html_url":"https://github.com/jpevarnek","followers_url":"https://api.github.com/users/jpevarnek/followers","following_url":"https://api.github.com/users/jpevarnek/following{/other_user}","gists_url":"https://api.github.com/users/jpevarnek/gists{/gist_id}","starred_url":"https://api.github.com/users/jpevarnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpevarnek/subscriptions","organizations_url":"https://api.github.com/users/jpevarnek/orgs","repos_url":"https://api.github.com/users/jpevarnek/repos","events_url":"https://api.github.com/users/jpevarnek/events{/privacy}","received_events_url":"https://api.github.com/users/jpevarnek/received_events","type":"User","site_admin":false},"created_at":"2015-07-06T14:03:38Z","updated_at":"2015-07-06T14:03:38Z","body":"Overall, this looks functional, but the design feels a bit off to me and I'd like to at least talk about that if you don't mind.\n\nWhat I'm seeing here looks like, semantically, \"the first time the app successfully connects to the extension, it should inform the extension that it is the first time it has successfully connected to the extension\".  That seems fine, and I think it will work, but it also seems like \"the first time the app successfully connects to the extension, the extension should notice\" would be simpler and *feel* less strange.\n\nAm I reading this correctly and can you explain why you went with this design?  Thanks!\n\n---\n\nReviewed 4 of 4 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.\n\n---\n\n<sup>**[src/chrome/app/scripts/main.core-env.ts, line 35 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/uproxy/1701#-JtYfDrzyhfExovWCOEy)** ([raw file](https://github.com/uproxy/uproxy/blob/30e848599d4f8103de87af4054c620696616d91f/src/chrome/app/scripts/main.core-env.ts#L35)):</sup>\nAssigning this under something that, as far as this module is concerned, seems to be just for OAuth usage seems a bit strange, is there somewhere else this could be placed?\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/uproxy/uproxy/1701)\n<!-- Sent from Reviewable.io -->\n"}}