{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/42985789","id":42985789,"diff_hunk":"@@ -0,0 +1,40 @@\n+import time\n+\n+from marionette_driver import expected, By, Wait\n+from gaiatest.apps.base import Base\n+from gaiatest.form_controls.header import GaiaHeader\n+from gaiatest.tests.functional.messages.test_sms_report import TestSmsReport","path":"tests/python/gaia-ui-tests/gaiatest/apps/messages/regions/report.py","position":6,"original_position":6,"commit_id":"9bc6f91c679342e194cf81cfc8fca0d5258d7da8","original_commit_id":"9bc6f91c679342e194cf81cfc8fca0d5258d7da8","user":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"body":"Side note about the responsibilities: A page class shouldn't be aware of which tests are using them. The usage diagram is the following:\r\n```\r\nTest -----> Page class -----> Marionette\r\n```\r\nThis mean that, marionette is used by the page class, but doesn't import any page class. Same thing between the page class and the test. This also means that the test doesn't use marionette directly, it's always done by the page class.","created_at":"2015-10-26T12:18:29Z","updated_at":"2015-10-26T12:18:29Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/32634#discussion_r42985789","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32634","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/42985789"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/32634#discussion_r42985789"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32634"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32634","id":48334153,"html_url":"https://github.com/mozilla-b2g/gaia/pull/32634","diff_url":"https://github.com/mozilla-b2g/gaia/pull/32634.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/32634.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32634","number":32634,"state":"open","locked":false,"title":"first version test_report","user":{"login":"isabelrios","id":1897507,"avatar_url":"https://avatars.githubusercontent.com/u/1897507?v=3","gravatar_id":"","url":"https://api.github.com/users/isabelrios","html_url":"https://github.com/isabelrios","followers_url":"https://api.github.com/users/isabelrios/followers","following_url":"https://api.github.com/users/isabelrios/following{/other_user}","gists_url":"https://api.github.com/users/isabelrios/gists{/gist_id}","starred_url":"https://api.github.com/users/isabelrios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isabelrios/subscriptions","organizations_url":"https://api.github.com/users/isabelrios/orgs","repos_url":"https://api.github.com/users/isabelrios/repos","events_url":"https://api.github.com/users/isabelrios/events{/privacy}","received_events_url":"https://api.github.com/users/isabelrios/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-21T13:55:20Z","updated_at":"2015-10-26T12:18:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b3f89971524e2e26d9b52ad517fc23f93336ade","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32634/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32634/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32634/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/9bc6f91c679342e194cf81cfc8fca0d5258d7da8","head":{"label":"isabelrios:test_report","ref":"test_report","sha":"9bc6f91c679342e194cf81cfc8fca0d5258d7da8","user":{"login":"isabelrios","id":1897507,"avatar_url":"https://avatars.githubusercontent.com/u/1897507?v=3","gravatar_id":"","url":"https://api.github.com/users/isabelrios","html_url":"https://github.com/isabelrios","followers_url":"https://api.github.com/users/isabelrios/followers","following_url":"https://api.github.com/users/isabelrios/following{/other_user}","gists_url":"https://api.github.com/users/isabelrios/gists{/gist_id}","starred_url":"https://api.github.com/users/isabelrios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isabelrios/subscriptions","organizations_url":"https://api.github.com/users/isabelrios/orgs","repos_url":"https://api.github.com/users/isabelrios/repos","events_url":"https://api.github.com/users/isabelrios/events{/privacy}","received_events_url":"https://api.github.com/users/isabelrios/received_events","type":"User","site_admin":false},"repo":{"id":44666974,"name":"gaia","full_name":"isabelrios/gaia","owner":{"login":"isabelrios","id":1897507,"avatar_url":"https://avatars.githubusercontent.com/u/1897507?v=3","gravatar_id":"","url":"https://api.github.com/users/isabelrios","html_url":"https://github.com/isabelrios","followers_url":"https://api.github.com/users/isabelrios/followers","following_url":"https://api.github.com/users/isabelrios/following{/other_user}","gists_url":"https://api.github.com/users/isabelrios/gists{/gist_id}","starred_url":"https://api.github.com/users/isabelrios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isabelrios/subscriptions","organizations_url":"https://api.github.com/users/isabelrios/orgs","repos_url":"https://api.github.com/users/isabelrios/repos","events_url":"https://api.github.com/users/isabelrios/events{/privacy}","received_events_url":"https://api.github.com/users/isabelrios/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isabelrios/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/isabelrios/gaia","forks_url":"https://api.github.com/repos/isabelrios/gaia/forks","keys_url":"https://api.github.com/repos/isabelrios/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isabelrios/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isabelrios/gaia/teams","hooks_url":"https://api.github.com/repos/isabelrios/gaia/hooks","issue_events_url":"https://api.github.com/repos/isabelrios/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/isabelrios/gaia/events","assignees_url":"https://api.github.com/repos/isabelrios/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/isabelrios/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/isabelrios/gaia/tags","blobs_url":"https://api.github.com/repos/isabelrios/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isabelrios/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isabelrios/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/isabelrios/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isabelrios/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/isabelrios/gaia/languages","stargazers_url":"https://api.github.com/repos/isabelrios/gaia/stargazers","contributors_url":"https://api.github.com/repos/isabelrios/gaia/contributors","subscribers_url":"https://api.github.com/repos/isabelrios/gaia/subscribers","subscription_url":"https://api.github.com/repos/isabelrios/gaia/subscription","commits_url":"https://api.github.com/repos/isabelrios/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/isabelrios/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/isabelrios/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/isabelrios/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/isabelrios/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/isabelrios/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isabelrios/gaia/merges","archive_url":"https://api.github.com/repos/isabelrios/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isabelrios/gaia/downloads","issues_url":"https://api.github.com/repos/isabelrios/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/isabelrios/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/isabelrios/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/isabelrios/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isabelrios/gaia/labels{/name}","releases_url":"https://api.github.com/repos/isabelrios/gaia/releases{/id}","created_at":"2015-10-21T09:47:55Z","updated_at":"2015-10-21T09:49:09Z","pushed_at":"2015-10-26T10:41:29Z","git_url":"git://github.com/isabelrios/gaia.git","ssh_url":"git@github.com:isabelrios/gaia.git","clone_url":"https://github.com/isabelrios/gaia.git","svn_url":"https://github.com/isabelrios/gaia","homepage":"https://wiki.mozilla.org/B2G","size":971850,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"cb336ee76181266721a833261b5a311e0180f3f8","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-10-26T01:49:34Z","pushed_at":"2015-10-26T12:00:41Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1674667,"stargazers_count":1992,"watchers_count":1992,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2494,"mirror_url":null,"open_issues_count":1259,"forks":2494,"open_issues":1259,"watchers":1992,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32634"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/32634"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32634"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/32634/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32634/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/32634/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/9bc6f91c679342e194cf81cfc8fca0d5258d7da8"}}}}