{"action":"created","issue":{"url":"https://api.github.com/repos/mezuro/prezento/issues/226","labels_url":"https://api.github.com/repos/mezuro/prezento/issues/226/labels{/name}","comments_url":"https://api.github.com/repos/mezuro/prezento/issues/226/comments","events_url":"https://api.github.com/repos/mezuro/prezento/issues/226/events","html_url":"https://github.com/mezuro/prezento/pull/226","id":86352500,"number":226,"title":"Fixed and refactored graphic for Metric Results","user":{"login":"danielkza","id":747342,"avatar_url":"https://avatars.githubusercontent.com/u/747342?v=3","gravatar_id":"","url":"https://api.github.com/users/danielkza","html_url":"https://github.com/danielkza","followers_url":"https://api.github.com/users/danielkza/followers","following_url":"https://api.github.com/users/danielkza/following{/other_user}","gists_url":"https://api.github.com/users/danielkza/gists{/gist_id}","starred_url":"https://api.github.com/users/danielkza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielkza/subscriptions","organizations_url":"https://api.github.com/users/danielkza/orgs","repos_url":"https://api.github.com/users/danielkza/repos","events_url":"https://api.github.com/users/danielkza/events{/privacy}","received_events_url":"https://api.github.com/users/danielkza/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-08T22:16:39Z","updated_at":"2015-06-09T11:51:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mezuro/prezento/pulls/226","html_url":"https://github.com/mezuro/prezento/pull/226","diff_url":"https://github.com/mezuro/prezento/pull/226.diff","patch_url":"https://github.com/mezuro/prezento/pull/226.patch"},"body":"The graphic for Metric results previously did not have a set size.\r\nChanged it so that it fills the whole space available, and made it\r\nresponsive to window resizing. That broke some particular cases of\r\nhistories with few changes and number of points that wasn't very small.\r\n\r\nTo make that work, refactored the graphic loading code so that instead\r\nof receiving the container ID on the controller, the ID is generated\r\nbased on the metric result ID and the metric name. Removed duplicate IDs\r\nas well, and replaced them by sub-selectors whenever possible. Made the\r\nModule.Graphic class receive the container as a DOM object too.\r\n\r\nIn addition, made the graphic display a single point instead of an\r\nunhelpful message."},"comment":{"url":"https://api.github.com/repos/mezuro/prezento/issues/comments/110330013","html_url":"https://github.com/mezuro/prezento/pull/226#issuecomment-110330013","issue_url":"https://api.github.com/repos/mezuro/prezento/issues/226","id":110330013,"user":{"login":"diegoamc","id":1068750,"avatar_url":"https://avatars.githubusercontent.com/u/1068750?v=3","gravatar_id":"","url":"https://api.github.com/users/diegoamc","html_url":"https://github.com/diegoamc","followers_url":"https://api.github.com/users/diegoamc/followers","following_url":"https://api.github.com/users/diegoamc/following{/other_user}","gists_url":"https://api.github.com/users/diegoamc/gists{/gist_id}","starred_url":"https://api.github.com/users/diegoamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegoamc/subscriptions","organizations_url":"https://api.github.com/users/diegoamc/orgs","repos_url":"https://api.github.com/users/diegoamc/repos","events_url":"https://api.github.com/users/diegoamc/events{/privacy}","received_events_url":"https://api.github.com/users/diegoamc/received_events","type":"User","site_admin":false},"created_at":"2015-06-09T11:51:48Z","updated_at":"2015-06-09T11:51:48Z","body":"I think you guys did a great job! Congratulations! :)\r\n\r\nRegarding some aspects of the code: \r\n\r\n* @danielkza, the cache should prevent it from reloading, right? Maybe it isn't working the way intended. Do you think it's worth testing?\r\n* I agree to extract `result_elm_id` to a helper method.\r\n\r\nAs the refactorings are linked with the bug fix, I'm afraid it is possible that we mess things up while trying to separate it into different PRs. If we feel the need to discuss this matters more, I think we can accept the PR and create issues with the labels `question` and `enhancement` about our reamaining doubts.\r\n"}}