{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/39749984","id":39749984,"diff_hunk":"@@ -81,6 +82,17 @@ func (precondition *ScalePrecondition) Validate(controller *api.ReplicationContr\n \treturn nil\n }\n \n+// ValidateJob ensures that the preconditions match.  Returns nil if they are valid, an error otherwise\n+func (precondition *ScalePrecondition) ValidateJob(job *experimental.Job) error {\n+\tif precondition.Size != -1 && *job.Spec.Parallelism != precondition.Size {","path":"pkg/kubectl/scale.go","position":25,"original_position":25,"commit_id":"f2fd8a7ce38c3c3600571b668233689731803d9c","original_commit_id":"f2fd8a7ce38c3c3600571b668233689731803d9c","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"Also if it's required internally internal should be int64","created_at":"2015-09-17T14:17:30Z","updated_at":"2015-09-17T14:17:30Z","html_url":"https://github.com/kubernetes/kubernetes/pull/14046#discussion_r39749984","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14046","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/39749984"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/14046#discussion_r39749984"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14046"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14046","id":45187145,"html_url":"https://github.com/kubernetes/kubernetes/pull/14046","diff_url":"https://github.com/kubernetes/kubernetes/pull/14046.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14046.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14046","number":14046,"state":"open","locked":false,"title":"Reaper and scaler for jobs","user":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":"@erictune this is the reaper and scaler part for jobs, I'm still working to increase tests in this PR.\r\nThis partially overlaps with #13259, at least the client part.","created_at":"2015-09-16T15:34:26Z","updated_at":"2015-09-17T14:17:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b5033f068a77338ad3d4ddc27fe18983e1c42d8","assignee":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14046/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14046/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14046/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f2fd8a7ce38c3c3600571b668233689731803d9c","head":{"label":"soltysh:job_controller_reaper_scaler","ref":"job_controller_reaper_scaler","sha":"f2fd8a7ce38c3c3600571b668233689731803d9c","user":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"repo":{"id":22375428,"name":"kubernetes","full_name":"soltysh/kubernetes","owner":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soltysh/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/soltysh/kubernetes","forks_url":"https://api.github.com/repos/soltysh/kubernetes/forks","keys_url":"https://api.github.com/repos/soltysh/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soltysh/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soltysh/kubernetes/teams","hooks_url":"https://api.github.com/repos/soltysh/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/soltysh/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/soltysh/kubernetes/events","assignees_url":"https://api.github.com/repos/soltysh/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/soltysh/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/soltysh/kubernetes/tags","blobs_url":"https://api.github.com/repos/soltysh/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soltysh/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soltysh/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/soltysh/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soltysh/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/soltysh/kubernetes/languages","stargazers_url":"https://api.github.com/repos/soltysh/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/soltysh/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/soltysh/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/soltysh/kubernetes/subscription","commits_url":"https://api.github.com/repos/soltysh/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/soltysh/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/soltysh/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/soltysh/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/soltysh/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/soltysh/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soltysh/kubernetes/merges","archive_url":"https://api.github.com/repos/soltysh/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soltysh/kubernetes/downloads","issues_url":"https://api.github.com/repos/soltysh/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/soltysh/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/soltysh/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/soltysh/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soltysh/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/soltysh/kubernetes/releases{/id}","created_at":"2014-07-29T09:56:32Z","updated_at":"2015-05-07T19:43:22Z","pushed_at":"2015-09-17T10:11:26Z","git_url":"git://github.com/soltysh/kubernetes.git","ssh_url":"git@github.com:soltysh/kubernetes.git","clone_url":"https://github.com/soltysh/kubernetes.git","svn_url":"https://github.com/soltysh/kubernetes","homepage":null,"size":106775,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"367e5571bf1fd8b73e2765c04509c21e1c8741bc","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-09-17T13:42:21Z","pushed_at":"2015-09-17T14:14:50Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":413613,"stargazers_count":10291,"watchers_count":10291,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2542,"mirror_url":null,"open_issues_count":1774,"forks":2542,"open_issues":1774,"watchers":10291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14046"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/14046"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/14046"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/14046/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14046/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14046/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f2fd8a7ce38c3c3600571b668233689731803d9c"}}}}