{"action":"created","comment":{"url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/comments/30436180","id":30436180,"diff_hunk":"@@ -7,8 +7,6 @@ namespace SpaceInvaders.Aliens.Strategies\n {\n     public class ShootRandomlyStrategy : IShootStrategy\n     {\n-        private readonly Random _rng = new Random();","path":"SpaceInvaders/Aliens/Strategies/ShootRandomlyStrategy.cs","position":4,"original_position":4,"commit_id":"a391ea1fb8a0d4cea2b50b186d50df11abf6422a","original_commit_id":"a391ea1fb8a0d4cea2b50b186d50df11abf6422a","user":{"login":"AttieG","id":1804025,"avatar_url":"https://avatars.githubusercontent.com/u/1804025?v=3","gravatar_id":"","url":"https://api.github.com/users/AttieG","html_url":"https://github.com/AttieG","followers_url":"https://api.github.com/users/AttieG/followers","following_url":"https://api.github.com/users/AttieG/following{/other_user}","gists_url":"https://api.github.com/users/AttieG/gists{/gist_id}","starred_url":"https://api.github.com/users/AttieG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttieG/subscriptions","organizations_url":"https://api.github.com/users/AttieG/orgs","repos_url":"https://api.github.com/users/AttieG/repos","events_url":"https://api.github.com/users/AttieG/events{/privacy}","received_events_url":"https://api.github.com/users/AttieG/received_events","type":"User","site_admin":false},"body":"@leppie, \r\nMaking this \"static\" would only fix the Aliens mirroring behavior.\r\nIt will not fix the Strategy selector. Which currently selects the same shooting strategy for both players.\r\nRefactoring to a single StaticRandom class solves both the mirroring and strategy selection. It also ensures both static Random classes do not have the same seed value.\r\n\r\n","created_at":"2015-05-15T19:01:31Z","updated_at":"2015-05-15T19:01:31Z","html_url":"https://github.com/EntelectChallenge/2015-SpaceInvaders-TestHarness/pull/19#discussion_r30436180","pull_request_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/comments/30436180"},"html":{"href":"https://github.com/EntelectChallenge/2015-SpaceInvaders-TestHarness/pull/19#discussion_r30436180"},"pull_request":{"href":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/19","id":35430266,"html_url":"https://github.com/EntelectChallenge/2015-SpaceInvaders-TestHarness/pull/19","diff_url":"https://github.com/EntelectChallenge/2015-SpaceInvaders-TestHarness/pull/19.diff","patch_url":"https://github.com/EntelectChallenge/2015-SpaceInvaders-TestHarness/pull/19.patch","issue_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/issues/19","number":19,"state":"open","locked":false,"title":"Corrects Alien shooting behavior","user":{"login":"AttieG","id":1804025,"avatar_url":"https://avatars.githubusercontent.com/u/1804025?v=3","gravatar_id":"","url":"https://api.github.com/users/AttieG","html_url":"https://github.com/AttieG","followers_url":"https://api.github.com/users/AttieG/followers","following_url":"https://api.github.com/users/AttieG/following{/other_user}","gists_url":"https://api.github.com/users/AttieG/gists{/gist_id}","starred_url":"https://api.github.com/users/AttieG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttieG/subscriptions","organizations_url":"https://api.github.com/users/AttieG/orgs","repos_url":"https://api.github.com/users/AttieG/repos","events_url":"https://api.github.com/users/AttieG/events{/privacy}","received_events_url":"https://api.github.com/users/AttieG/received_events","type":"User","site_admin":false},"body":"The current Alien behavior differs from the intended Alien behavior.\r\nAlien shooting behavior should be random, but instead aliens mirror each other.\r\n\r\nThe random class relies on the system clock for its seed value. Because both instances of Random are instantiated within 15ms they are seeded to the same value. The  \"random\" values generated therefor are not random, but the same for both objects.\r\n\r\nThe fix creates a single static instance of the Random class, which is only seeded once. All calls made from the static \"Next\" method, will be properly random. \r\n","created_at":"2015-05-14T15:13:34Z","updated_at":"2015-05-15T19:01:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aae711a26267a69633246fdb925eb29ff7b97ce8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/19/commits","review_comments_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/19/comments","review_comment_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/issues/19/comments","statuses_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/statuses/a391ea1fb8a0d4cea2b50b186d50df11abf6422a","head":{"label":"AttieG:Random_fix","ref":"Random_fix","sha":"a391ea1fb8a0d4cea2b50b186d50df11abf6422a","user":{"login":"AttieG","id":1804025,"avatar_url":"https://avatars.githubusercontent.com/u/1804025?v=3","gravatar_id":"","url":"https://api.github.com/users/AttieG","html_url":"https://github.com/AttieG","followers_url":"https://api.github.com/users/AttieG/followers","following_url":"https://api.github.com/users/AttieG/following{/other_user}","gists_url":"https://api.github.com/users/AttieG/gists{/gist_id}","starred_url":"https://api.github.com/users/AttieG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttieG/subscriptions","organizations_url":"https://api.github.com/users/AttieG/orgs","repos_url":"https://api.github.com/users/AttieG/repos","events_url":"https://api.github.com/users/AttieG/events{/privacy}","received_events_url":"https://api.github.com/users/AttieG/received_events","type":"User","site_admin":false},"repo":{"id":35616060,"name":"2015-SpaceInvaders-TestHarness","full_name":"AttieG/2015-SpaceInvaders-TestHarness","owner":{"login":"AttieG","id":1804025,"avatar_url":"https://avatars.githubusercontent.com/u/1804025?v=3","gravatar_id":"","url":"https://api.github.com/users/AttieG","html_url":"https://github.com/AttieG","followers_url":"https://api.github.com/users/AttieG/followers","following_url":"https://api.github.com/users/AttieG/following{/other_user}","gists_url":"https://api.github.com/users/AttieG/gists{/gist_id}","starred_url":"https://api.github.com/users/AttieG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AttieG/subscriptions","organizations_url":"https://api.github.com/users/AttieG/orgs","repos_url":"https://api.github.com/users/AttieG/repos","events_url":"https://api.github.com/users/AttieG/events{/privacy}","received_events_url":"https://api.github.com/users/AttieG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AttieG/2015-SpaceInvaders-TestHarness","description":"The test harness for the 2015 Entelect R100K challenge.","fork":true,"url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness","forks_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/forks","keys_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/teams","hooks_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/hooks","issue_events_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/issues/events{/number}","events_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/events","assignees_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/assignees{/user}","branches_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/branches{/branch}","tags_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/tags","blobs_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/git/refs{/sha}","trees_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/statuses/{sha}","languages_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/languages","stargazers_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/stargazers","contributors_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/contributors","subscribers_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/subscribers","subscription_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/subscription","commits_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/commits{/sha}","git_commits_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/git/commits{/sha}","comments_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/comments{/number}","issue_comment_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/issues/comments{/number}","contents_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/contents/{+path}","compare_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/merges","archive_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/downloads","issues_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/issues{/number}","pulls_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/pulls{/number}","milestones_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/milestones{/number}","notifications_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/labels{/name}","releases_url":"https://api.github.com/repos/AttieG/2015-SpaceInvaders-TestHarness/releases{/id}","created_at":"2015-05-14T14:33:32Z","updated_at":"2015-05-14T14:33:33Z","pushed_at":"2015-05-14T14:50:42Z","git_url":"git://github.com/AttieG/2015-SpaceInvaders-TestHarness.git","ssh_url":"git@github.com:AttieG/2015-SpaceInvaders-TestHarness.git","clone_url":"https://github.com/AttieG/2015-SpaceInvaders-TestHarness.git","svn_url":"https://github.com/AttieG/2015-SpaceInvaders-TestHarness","homepage":null,"size":335,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EntelectChallenge:master","ref":"master","sha":"780362551f73ca0d4aeb43f5756293dd6a49c895","user":{"login":"EntelectChallenge","id":7250875,"avatar_url":"https://avatars.githubusercontent.com/u/7250875?v=3","gravatar_id":"","url":"https://api.github.com/users/EntelectChallenge","html_url":"https://github.com/EntelectChallenge","followers_url":"https://api.github.com/users/EntelectChallenge/followers","following_url":"https://api.github.com/users/EntelectChallenge/following{/other_user}","gists_url":"https://api.github.com/users/EntelectChallenge/gists{/gist_id}","starred_url":"https://api.github.com/users/EntelectChallenge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EntelectChallenge/subscriptions","organizations_url":"https://api.github.com/users/EntelectChallenge/orgs","repos_url":"https://api.github.com/users/EntelectChallenge/repos","events_url":"https://api.github.com/users/EntelectChallenge/events{/privacy}","received_events_url":"https://api.github.com/users/EntelectChallenge/received_events","type":"User","site_admin":false},"repo":{"id":33656476,"name":"2015-SpaceInvaders-TestHarness","full_name":"EntelectChallenge/2015-SpaceInvaders-TestHarness","owner":{"login":"EntelectChallenge","id":7250875,"avatar_url":"https://avatars.githubusercontent.com/u/7250875?v=3","gravatar_id":"","url":"https://api.github.com/users/EntelectChallenge","html_url":"https://github.com/EntelectChallenge","followers_url":"https://api.github.com/users/EntelectChallenge/followers","following_url":"https://api.github.com/users/EntelectChallenge/following{/other_user}","gists_url":"https://api.github.com/users/EntelectChallenge/gists{/gist_id}","starred_url":"https://api.github.com/users/EntelectChallenge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EntelectChallenge/subscriptions","organizations_url":"https://api.github.com/users/EntelectChallenge/orgs","repos_url":"https://api.github.com/users/EntelectChallenge/repos","events_url":"https://api.github.com/users/EntelectChallenge/events{/privacy}","received_events_url":"https://api.github.com/users/EntelectChallenge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EntelectChallenge/2015-SpaceInvaders-TestHarness","description":"The test harness for the 2015 Entelect R100K challenge.","fork":false,"url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness","forks_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/forks","keys_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/teams","hooks_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/hooks","issue_events_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/issues/events{/number}","events_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/events","assignees_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/assignees{/user}","branches_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/branches{/branch}","tags_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/tags","blobs_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/git/refs{/sha}","trees_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/statuses/{sha}","languages_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/languages","stargazers_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/stargazers","contributors_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/contributors","subscribers_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/subscribers","subscription_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/subscription","commits_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/commits{/sha}","git_commits_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/git/commits{/sha}","comments_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/comments{/number}","issue_comment_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/issues/comments{/number}","contents_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/contents/{+path}","compare_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/merges","archive_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/downloads","issues_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/issues{/number}","pulls_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls{/number}","milestones_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/milestones{/number}","notifications_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/labels{/name}","releases_url":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/releases{/id}","created_at":"2015-04-09T08:05:48Z","updated_at":"2015-05-09T12:23:27Z","pushed_at":"2015-05-14T15:13:34Z","git_url":"git://github.com/EntelectChallenge/2015-SpaceInvaders-TestHarness.git","ssh_url":"git@github.com:EntelectChallenge/2015-SpaceInvaders-TestHarness.git","clone_url":"https://github.com/EntelectChallenge/2015-SpaceInvaders-TestHarness.git","svn_url":"https://github.com/EntelectChallenge/2015-SpaceInvaders-TestHarness","homepage":null,"size":335,"stargazers_count":7,"watchers_count":7,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/19"},"html":{"href":"https://github.com/EntelectChallenge/2015-SpaceInvaders-TestHarness/pull/19"},"issue":{"href":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/issues/19"},"comments":{"href":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/EntelectChallenge/2015-SpaceInvaders-TestHarness/statuses/a391ea1fb8a0d4cea2b50b186d50df11abf6422a"}}}}