{"action":"created","issue":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2824","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2824/labels{/name}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2824/comments","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2824/events","html_url":"https://github.com/FreeRDP/FreeRDP/pull/2824","id":99071260,"number":2824,"title":"Return FREERDP_ERROR_AUTHENTICATION_FAILED on an authentication failure","user":{"login":"bjcollins","id":1703702,"avatar_url":"https://avatars.githubusercontent.com/u/1703702?v=3","gravatar_id":"","url":"https://api.github.com/users/bjcollins","html_url":"https://github.com/bjcollins","followers_url":"https://api.github.com/users/bjcollins/followers","following_url":"https://api.github.com/users/bjcollins/following{/other_user}","gists_url":"https://api.github.com/users/bjcollins/gists{/gist_id}","starred_url":"https://api.github.com/users/bjcollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjcollins/subscriptions","organizations_url":"https://api.github.com/users/bjcollins/orgs","repos_url":"https://api.github.com/users/bjcollins/repos","events_url":"https://api.github.com/users/bjcollins/events{/privacy}","received_events_url":"https://api.github.com/users/bjcollins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-04T21:59:38Z","updated_at":"2015-08-28T23:08:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2824","html_url":"https://github.com/FreeRDP/FreeRDP/pull/2824","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/2824.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/2824.patch"},"body":"when using NLA with xfreerdp."},"comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments/135907866","html_url":"https://github.com/FreeRDP/FreeRDP/pull/2824#issuecomment-135907866","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2824","id":135907866,"user":{"login":"bjcollins","id":1703702,"avatar_url":"https://avatars.githubusercontent.com/u/1703702?v=3","gravatar_id":"","url":"https://api.github.com/users/bjcollins","html_url":"https://github.com/bjcollins","followers_url":"https://api.github.com/users/bjcollins/followers","following_url":"https://api.github.com/users/bjcollins/following{/other_user}","gists_url":"https://api.github.com/users/bjcollins/gists{/gist_id}","starred_url":"https://api.github.com/users/bjcollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjcollins/subscriptions","organizations_url":"https://api.github.com/users/bjcollins/orgs","repos_url":"https://api.github.com/users/bjcollins/repos","events_url":"https://api.github.com/users/bjcollins/events{/privacy}","received_events_url":"https://api.github.com/users/bjcollins/received_events","type":"User","site_admin":false},"created_at":"2015-08-28T23:08:21Z","updated_at":"2015-08-28T23:08:21Z","body":"@bmiklautz @akallabeth I think this patch could cut down, SetLastError can probably just be called a little deeper without passing the failure boolean up the call stack and I called the callback \"test_function\" which is not really a great name. Not sure about using ERROR_MUTUAL_AUTH_FAILED as I wanted the exit code to reflect that it was an NLA auth failure. Either way, I want to look at this again and try to rework this patch."}}