{"action":"created","comment":{"url":"https://api.github.com/repos/ReactKit/ReactKit/pulls/comments/26195498","id":26195498,"diff_hunk":"@@ -11,13 +11,13 @@ import Foundation\n public extension NSObject\n {\n     /// creates new KVO Signal (new value only)\n-    public func signal(#keyPath: String) -> Signal<AnyObject?>\n+    public func signal(#keyPath: String, nilValue: AnyObject? = nil) -> Signal<AnyObject?>\n     {\n         return Signal { [weak self] progress, fulfill, reject, configure in\n             \n             if let self_ = self {\n                 let observer = _KVOProxy(target: self_, keyPath: keyPath) { value, change, indexSet in\n-                    progress(value)\n+                    progress((value is NSNull) ? nilValue : value)","path":"ReactKit/Foundation/KVO.swift","position":12,"original_position":12,"commit_id":"c00e4cd5829a74dbc29e0cbf5dde0331ab6c6f28","original_commit_id":"c00e4cd5829a74dbc29e0cbf5dde0331ab6c6f28","user":{"login":"inamiy","id":138476,"avatar_url":"https://avatars.githubusercontent.com/u/138476?v=3","gravatar_id":"","url":"https://api.github.com/users/inamiy","html_url":"https://github.com/inamiy","followers_url":"https://api.github.com/users/inamiy/followers","following_url":"https://api.github.com/users/inamiy/following{/other_user}","gists_url":"https://api.github.com/users/inamiy/gists{/gist_id}","starred_url":"https://api.github.com/users/inamiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inamiy/subscriptions","organizations_url":"https://api.github.com/users/inamiy/orgs","repos_url":"https://api.github.com/users/inamiy/repos","events_url":"https://api.github.com/users/inamiy/events{/privacy}","received_events_url":"https://api.github.com/users/inamiy/received_events","type":"User","site_admin":false},"body":"`progress((value is NSNull) ? nil : value)` is enough?","created_at":"2015-03-11T08:41:56Z","updated_at":"2015-03-11T08:41:56Z","html_url":"https://github.com/ReactKit/ReactKit/pull/18#discussion_r26195498","pull_request_url":"https://api.github.com/repos/ReactKit/ReactKit/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/ReactKit/ReactKit/pulls/comments/26195498"},"html":{"href":"https://github.com/ReactKit/ReactKit/pull/18#discussion_r26195498"},"pull_request":{"href":"https://api.github.com/repos/ReactKit/ReactKit/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/ReactKit/ReactKit/pulls/18","id":30920940,"html_url":"https://github.com/ReactKit/ReactKit/pull/18","diff_url":"https://github.com/ReactKit/ReactKit/pull/18.diff","patch_url":"https://github.com/ReactKit/ReactKit/pull/18.patch","issue_url":"https://api.github.com/repos/ReactKit/ReactKit/issues/18","number":18,"state":"open","locked":false,"title":"KVO signals should allow nil value placeholder","user":{"login":"robertjpayne","id":214288,"avatar_url":"https://avatars.githubusercontent.com/u/214288?v=3","gravatar_id":"","url":"https://api.github.com/users/robertjpayne","html_url":"https://github.com/robertjpayne","followers_url":"https://api.github.com/users/robertjpayne/followers","following_url":"https://api.github.com/users/robertjpayne/following{/other_user}","gists_url":"https://api.github.com/users/robertjpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/robertjpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertjpayne/subscriptions","organizations_url":"https://api.github.com/users/robertjpayne/orgs","repos_url":"https://api.github.com/users/robertjpayne/repos","events_url":"https://api.github.com/users/robertjpayne/events{/privacy}","received_events_url":"https://api.github.com/users/robertjpayne/received_events","type":"User","site_admin":false},"body":"Because KVO emits NSNull values when the target value is nil we should allow the option to set a nil value placeholder.\r\n\r\nThis allows cleaner binding without having to monitor for NSNull and map it to nil or a default value.","created_at":"2015-03-11T07:37:21Z","updated_at":"2015-03-11T08:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdf761b0b44e92e203264c4cb3a34169aceaad6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactKit/ReactKit/pulls/18/commits","review_comments_url":"https://api.github.com/repos/ReactKit/ReactKit/pulls/18/comments","review_comment_url":"https://api.github.com/repos/ReactKit/ReactKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactKit/ReactKit/issues/18/comments","statuses_url":"https://api.github.com/repos/ReactKit/ReactKit/statuses/c00e4cd5829a74dbc29e0cbf5dde0331ab6c6f28","head":{"label":"robertjpayne:master","ref":"master","sha":"c00e4cd5829a74dbc29e0cbf5dde0331ab6c6f28","user":{"login":"robertjpayne","id":214288,"avatar_url":"https://avatars.githubusercontent.com/u/214288?v=3","gravatar_id":"","url":"https://api.github.com/users/robertjpayne","html_url":"https://github.com/robertjpayne","followers_url":"https://api.github.com/users/robertjpayne/followers","following_url":"https://api.github.com/users/robertjpayne/following{/other_user}","gists_url":"https://api.github.com/users/robertjpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/robertjpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertjpayne/subscriptions","organizations_url":"https://api.github.com/users/robertjpayne/orgs","repos_url":"https://api.github.com/users/robertjpayne/repos","events_url":"https://api.github.com/users/robertjpayne/events{/privacy}","received_events_url":"https://api.github.com/users/robertjpayne/received_events","type":"User","site_admin":false},"repo":{"id":31999547,"name":"ReactKit","full_name":"robertjpayne/ReactKit","owner":{"login":"robertjpayne","id":214288,"avatar_url":"https://avatars.githubusercontent.com/u/214288?v=3","gravatar_id":"","url":"https://api.github.com/users/robertjpayne","html_url":"https://github.com/robertjpayne","followers_url":"https://api.github.com/users/robertjpayne/followers","following_url":"https://api.github.com/users/robertjpayne/following{/other_user}","gists_url":"https://api.github.com/users/robertjpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/robertjpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertjpayne/subscriptions","organizations_url":"https://api.github.com/users/robertjpayne/orgs","repos_url":"https://api.github.com/users/robertjpayne/repos","events_url":"https://api.github.com/users/robertjpayne/events{/privacy}","received_events_url":"https://api.github.com/users/robertjpayne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertjpayne/ReactKit","description":"Swift Reactive Programming.","fork":true,"url":"https://api.github.com/repos/robertjpayne/ReactKit","forks_url":"https://api.github.com/repos/robertjpayne/ReactKit/forks","keys_url":"https://api.github.com/repos/robertjpayne/ReactKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertjpayne/ReactKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertjpayne/ReactKit/teams","hooks_url":"https://api.github.com/repos/robertjpayne/ReactKit/hooks","issue_events_url":"https://api.github.com/repos/robertjpayne/ReactKit/issues/events{/number}","events_url":"https://api.github.com/repos/robertjpayne/ReactKit/events","assignees_url":"https://api.github.com/repos/robertjpayne/ReactKit/assignees{/user}","branches_url":"https://api.github.com/repos/robertjpayne/ReactKit/branches{/branch}","tags_url":"https://api.github.com/repos/robertjpayne/ReactKit/tags","blobs_url":"https://api.github.com/repos/robertjpayne/ReactKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertjpayne/ReactKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertjpayne/ReactKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertjpayne/ReactKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertjpayne/ReactKit/statuses/{sha}","languages_url":"https://api.github.com/repos/robertjpayne/ReactKit/languages","stargazers_url":"https://api.github.com/repos/robertjpayne/ReactKit/stargazers","contributors_url":"https://api.github.com/repos/robertjpayne/ReactKit/contributors","subscribers_url":"https://api.github.com/repos/robertjpayne/ReactKit/subscribers","subscription_url":"https://api.github.com/repos/robertjpayne/ReactKit/subscription","commits_url":"https://api.github.com/repos/robertjpayne/ReactKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertjpayne/ReactKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertjpayne/ReactKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertjpayne/ReactKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/robertjpayne/ReactKit/contents/{+path}","compare_url":"https://api.github.com/repos/robertjpayne/ReactKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertjpayne/ReactKit/merges","archive_url":"https://api.github.com/repos/robertjpayne/ReactKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertjpayne/ReactKit/downloads","issues_url":"https://api.github.com/repos/robertjpayne/ReactKit/issues{/number}","pulls_url":"https://api.github.com/repos/robertjpayne/ReactKit/pulls{/number}","milestones_url":"https://api.github.com/repos/robertjpayne/ReactKit/milestones{/number}","notifications_url":"https://api.github.com/repos/robertjpayne/ReactKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertjpayne/ReactKit/labels{/name}","releases_url":"https://api.github.com/repos/robertjpayne/ReactKit/releases{/id}","created_at":"2015-03-11T05:11:53Z","updated_at":"2015-03-11T07:49:40Z","pushed_at":"2015-03-11T07:49:40Z","git_url":"git://github.com/robertjpayne/ReactKit.git","ssh_url":"git@github.com:robertjpayne/ReactKit.git","clone_url":"https://github.com/robertjpayne/ReactKit.git","svn_url":"https://github.com/robertjpayne/ReactKit","homepage":null,"size":939,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactKit:master","ref":"master","sha":"093340e110f5592eaac6edbe9c3ed70b0574c3df","user":{"login":"ReactKit","id":8986128,"avatar_url":"https://avatars.githubusercontent.com/u/8986128?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactKit","html_url":"https://github.com/ReactKit","followers_url":"https://api.github.com/users/ReactKit/followers","following_url":"https://api.github.com/users/ReactKit/following{/other_user}","gists_url":"https://api.github.com/users/ReactKit/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactKit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactKit/subscriptions","organizations_url":"https://api.github.com/users/ReactKit/orgs","repos_url":"https://api.github.com/users/ReactKit/repos","events_url":"https://api.github.com/users/ReactKit/events{/privacy}","received_events_url":"https://api.github.com/users/ReactKit/received_events","type":"Organization","site_admin":false},"repo":{"id":24597835,"name":"ReactKit","full_name":"ReactKit/ReactKit","owner":{"login":"ReactKit","id":8986128,"avatar_url":"https://avatars.githubusercontent.com/u/8986128?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactKit","html_url":"https://github.com/ReactKit","followers_url":"https://api.github.com/users/ReactKit/followers","following_url":"https://api.github.com/users/ReactKit/following{/other_user}","gists_url":"https://api.github.com/users/ReactKit/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactKit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactKit/subscriptions","organizations_url":"https://api.github.com/users/ReactKit/orgs","repos_url":"https://api.github.com/users/ReactKit/repos","events_url":"https://api.github.com/users/ReactKit/events{/privacy}","received_events_url":"https://api.github.com/users/ReactKit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactKit/ReactKit","description":"Swift Reactive Programming.","fork":false,"url":"https://api.github.com/repos/ReactKit/ReactKit","forks_url":"https://api.github.com/repos/ReactKit/ReactKit/forks","keys_url":"https://api.github.com/repos/ReactKit/ReactKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactKit/ReactKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactKit/ReactKit/teams","hooks_url":"https://api.github.com/repos/ReactKit/ReactKit/hooks","issue_events_url":"https://api.github.com/repos/ReactKit/ReactKit/issues/events{/number}","events_url":"https://api.github.com/repos/ReactKit/ReactKit/events","assignees_url":"https://api.github.com/repos/ReactKit/ReactKit/assignees{/user}","branches_url":"https://api.github.com/repos/ReactKit/ReactKit/branches{/branch}","tags_url":"https://api.github.com/repos/ReactKit/ReactKit/tags","blobs_url":"https://api.github.com/repos/ReactKit/ReactKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactKit/ReactKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactKit/ReactKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactKit/ReactKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactKit/ReactKit/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactKit/ReactKit/languages","stargazers_url":"https://api.github.com/repos/ReactKit/ReactKit/stargazers","contributors_url":"https://api.github.com/repos/ReactKit/ReactKit/contributors","subscribers_url":"https://api.github.com/repos/ReactKit/ReactKit/subscribers","subscription_url":"https://api.github.com/repos/ReactKit/ReactKit/subscription","commits_url":"https://api.github.com/repos/ReactKit/ReactKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactKit/ReactKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactKit/ReactKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactKit/ReactKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactKit/ReactKit/contents/{+path}","compare_url":"https://api.github.com/repos/ReactKit/ReactKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactKit/ReactKit/merges","archive_url":"https://api.github.com/repos/ReactKit/ReactKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactKit/ReactKit/downloads","issues_url":"https://api.github.com/repos/ReactKit/ReactKit/issues{/number}","pulls_url":"https://api.github.com/repos/ReactKit/ReactKit/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactKit/ReactKit/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactKit/ReactKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactKit/ReactKit/labels{/name}","releases_url":"https://api.github.com/repos/ReactKit/ReactKit/releases{/id}","created_at":"2014-09-29T14:09:19Z","updated_at":"2015-03-11T07:12:01Z","pushed_at":"2015-03-11T00:36:44Z","git_url":"git://github.com/ReactKit/ReactKit.git","ssh_url":"git@github.com:ReactKit/ReactKit.git","clone_url":"https://github.com/ReactKit/ReactKit.git","svn_url":"https://github.com/ReactKit/ReactKit","homepage":null,"size":939,"stargazers_count":592,"watchers_count":592,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":7,"forks":17,"open_issues":7,"watchers":592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactKit/ReactKit/pulls/18"},"html":{"href":"https://github.com/ReactKit/ReactKit/pull/18"},"issue":{"href":"https://api.github.com/repos/ReactKit/ReactKit/issues/18"},"comments":{"href":"https://api.github.com/repos/ReactKit/ReactKit/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactKit/ReactKit/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactKit/ReactKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactKit/ReactKit/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/ReactKit/ReactKit/statuses/c00e4cd5829a74dbc29e0cbf5dde0331ab6c6f28"}}}}