{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/5291","labels_url":"https://api.github.com/repos/openshift/origin/issues/5291/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/5291/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/5291/events","html_url":"https://github.com/openshift/origin/pull/5291","id":112625399,"number":5291,"title":"Add back a fix for libvirt that was accidentally removed","user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-21T16:11:45Z","updated_at":"2015-10-21T22:06:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/5291","html_url":"https://github.com/openshift/origin/pull/5291","diff_url":"https://github.com/openshift/origin/pull/5291.diff","patch_url":"https://github.com/openshift/origin/pull/5291.patch"},"body":"https://github.com/openshift/origin/pull/5175 removed the line\r\n\r\n    override.vm.synced_folder \".\", \"/vagrant\", type: 'nfs'\r\n\r\nfrom the libvirt section of Vagrantfile, presumably because it looked unnecessary, but it's actually needed due to a vagrant-libvirt bug (https://github.com/pradels/vagrant-libvirt/issues/419). (Without it, some machines will default to rsync instead, which will get stuck in an infinite loop because of a circular symlink in one of the packages under Godeps/.)\r\n\r\n@danmcp "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/150038442","html_url":"https://github.com/openshift/origin/pull/5291#issuecomment-150038442","issue_url":"https://api.github.com/repos/openshift/origin/issues/5291","id":150038442,"user":{"login":"danwinship","id":96040,"avatar_url":"https://avatars.githubusercontent.com/u/96040?v=3","gravatar_id":"","url":"https://api.github.com/users/danwinship","html_url":"https://github.com/danwinship","followers_url":"https://api.github.com/users/danwinship/followers","following_url":"https://api.github.com/users/danwinship/following{/other_user}","gists_url":"https://api.github.com/users/danwinship/gists{/gist_id}","starred_url":"https://api.github.com/users/danwinship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danwinship/subscriptions","organizations_url":"https://api.github.com/users/danwinship/orgs","repos_url":"https://api.github.com/users/danwinship/repos","events_url":"https://api.github.com/users/danwinship/events{/privacy}","received_events_url":"https://api.github.com/users/danwinship/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T22:06:39Z","updated_at":"2015-10-21T22:06:39Z","body":"> So I guess really what I want to do is to make vagrant_openshift_config['sync_folders_type'] default to 'nfs' when using libvirt.\r\n\r\nFrom reading the docs and googling, it appears that this is actually impossible; there's no way to set a global variable conditionally based on the provider, because Vagrant doesn't decide which provider it's going to use until after the Vagrantfile has been run. (All `config.vm.provider` blocks get run every time, just with a different `override` object passed to each one.)\r\n\r\nI pushed a slightly-revised version of my original branch; now it only overrides the synced_folder if dev_cluster is true. This leaves the non-dev_cluster case broken, but it was broken before too and no one ever noticed so apparently no one is using the non-dev_cluster case with libvirt.\r\n"}}