{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/dxr/pulls/comments/31334641","id":31334641,"diff_hunk":"@@ -0,0 +1,278 @@\n+        GNU GENERAL PUBLIC LICENSE","path":"dxr/hgext/GPL-LICENSE.txt","position":1,"original_position":1,"commit_id":"83ea2fdad95e94b1fd58ca0affc22537af515e7f","original_commit_id":"83ea2fdad95e94b1fd58ca0affc22537af515e7f","user":{"login":"erikrose","id":295816,"avatar_url":"https://avatars.githubusercontent.com/u/295816?v=3","gravatar_id":"","url":"https://api.github.com/users/erikrose","html_url":"https://github.com/erikrose","followers_url":"https://api.github.com/users/erikrose/followers","following_url":"https://api.github.com/users/erikrose/following{/other_user}","gists_url":"https://api.github.com/users/erikrose/gists{/gist_id}","starred_url":"https://api.github.com/users/erikrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikrose/subscriptions","organizations_url":"https://api.github.com/users/erikrose/orgs","repos_url":"https://api.github.com/users/erikrose/repos","events_url":"https://api.github.com/users/erikrose/events{/privacy}","received_events_url":"https://api.github.com/users/erikrose/received_events","type":"User","site_admin":false},"body":"We should also note in the top-level license that hgext is an exception and not under the GPL, so there can be no mistaking it.","created_at":"2015-05-29T15:25:00Z","updated_at":"2015-05-29T15:25:00Z","html_url":"https://github.com/mozilla/dxr/pull/419#discussion_r31334641","pull_request_url":"https://api.github.com/repos/mozilla/dxr/pulls/419","_links":{"self":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/comments/31334641"},"html":{"href":"https://github.com/mozilla/dxr/pull/419#discussion_r31334641"},"pull_request":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/419"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/dxr/pulls/419","id":36243752,"html_url":"https://github.com/mozilla/dxr/pull/419","diff_url":"https://github.com/mozilla/dxr/pull/419.diff","patch_url":"https://github.com/mozilla/dxr/pull/419.patch","issue_url":"https://api.github.com/repos/mozilla/dxr/issues/419","number":419,"state":"open","locked":false,"title":"Refactored VCS, run file skimmers on requests, permalinks","user":{"login":"pelmers","id":2406051,"avatar_url":"https://avatars.githubusercontent.com/u/2406051?v=3","gravatar_id":"","url":"https://api.github.com/users/pelmers","html_url":"https://github.com/pelmers","followers_url":"https://api.github.com/users/pelmers/followers","following_url":"https://api.github.com/users/pelmers/following{/other_user}","gists_url":"https://api.github.com/users/pelmers/gists{/gist_id}","starred_url":"https://api.github.com/users/pelmers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelmers/subscriptions","organizations_url":"https://api.github.com/users/pelmers/orgs","repos_url":"https://api.github.com/users/pelmers/repos","events_url":"https://api.github.com/users/pelmers/events{/privacy}","received_events_url":"https://api.github.com/users/pelmers/received_events","type":"User","site_admin":false},"body":"This work is still a bit rough around the edges, but I wanted to put this up to make it easier to review.\r\n\r\nRelated bugs:\r\n- https://bugzilla.mozilla.org/show_bug.cgi?id=962108\r\n- https://bugzilla.mozilla.org/show_bug.cgi?id=1166397\r\n\r\nSummary of changes:\r\n- Store line endings in ES, and store regions and refs separately. This lets us FileToSkim when files are requested, and merge refs and regions at this point. Increment the format version.\r\n- Add some tests for Git and Mercurial.\r\n- Add permalink button to nav bar along with '/rev' route.\r\n- Add dependence on [hglib](https://pypi.python.org/pypi/python-hglib/) to avoid [MercurialApi](http://mercurial.selenic.com/wiki/MercurialApi)\r\n- Other refactoring and minor fixes.\r\n\r\nStill needed:\r\n- ~~Tests for Perforce.~~ Too expensive.\r\n- ~~Put permalink generation in core.py.~~\r\n- ~~Move link building into vcs.py~~\r\n- ~~Construct some kind of VCS manager for each worker that caches path -> vcs mapping.~~\r\n- Update the docs. Which portions?\r\n- Better name than VCSTree ?\r\n","created_at":"2015-05-26T20:47:07Z","updated_at":"2015-05-29T15:25:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57619a5f7f2fb1665af8f822bbc129669a1bc70e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/dxr/pulls/419/commits","review_comments_url":"https://api.github.com/repos/mozilla/dxr/pulls/419/comments","review_comment_url":"https://api.github.com/repos/mozilla/dxr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/dxr/issues/419/comments","statuses_url":"https://api.github.com/repos/mozilla/dxr/statuses/83ea2fdad95e94b1fd58ca0affc22537af515e7f","head":{"label":"pelmers:es_permalinks_less_muck","ref":"es_permalinks_less_muck","sha":"83ea2fdad95e94b1fd58ca0affc22537af515e7f","user":{"login":"pelmers","id":2406051,"avatar_url":"https://avatars.githubusercontent.com/u/2406051?v=3","gravatar_id":"","url":"https://api.github.com/users/pelmers","html_url":"https://github.com/pelmers","followers_url":"https://api.github.com/users/pelmers/followers","following_url":"https://api.github.com/users/pelmers/following{/other_user}","gists_url":"https://api.github.com/users/pelmers/gists{/gist_id}","starred_url":"https://api.github.com/users/pelmers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelmers/subscriptions","organizations_url":"https://api.github.com/users/pelmers/orgs","repos_url":"https://api.github.com/users/pelmers/repos","events_url":"https://api.github.com/users/pelmers/events{/privacy}","received_events_url":"https://api.github.com/users/pelmers/received_events","type":"User","site_admin":false},"repo":{"id":15886083,"name":"dxr","full_name":"pelmers/dxr","owner":{"login":"pelmers","id":2406051,"avatar_url":"https://avatars.githubusercontent.com/u/2406051?v=3","gravatar_id":"","url":"https://api.github.com/users/pelmers","html_url":"https://github.com/pelmers","followers_url":"https://api.github.com/users/pelmers/followers","following_url":"https://api.github.com/users/pelmers/following{/other_user}","gists_url":"https://api.github.com/users/pelmers/gists{/gist_id}","starred_url":"https://api.github.com/users/pelmers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelmers/subscriptions","organizations_url":"https://api.github.com/users/pelmers/orgs","repos_url":"https://api.github.com/users/pelmers/repos","events_url":"https://api.github.com/users/pelmers/events{/privacy}","received_events_url":"https://api.github.com/users/pelmers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pelmers/dxr","description":"An intelligent source code browser","fork":true,"url":"https://api.github.com/repos/pelmers/dxr","forks_url":"https://api.github.com/repos/pelmers/dxr/forks","keys_url":"https://api.github.com/repos/pelmers/dxr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pelmers/dxr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pelmers/dxr/teams","hooks_url":"https://api.github.com/repos/pelmers/dxr/hooks","issue_events_url":"https://api.github.com/repos/pelmers/dxr/issues/events{/number}","events_url":"https://api.github.com/repos/pelmers/dxr/events","assignees_url":"https://api.github.com/repos/pelmers/dxr/assignees{/user}","branches_url":"https://api.github.com/repos/pelmers/dxr/branches{/branch}","tags_url":"https://api.github.com/repos/pelmers/dxr/tags","blobs_url":"https://api.github.com/repos/pelmers/dxr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pelmers/dxr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pelmers/dxr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pelmers/dxr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pelmers/dxr/statuses/{sha}","languages_url":"https://api.github.com/repos/pelmers/dxr/languages","stargazers_url":"https://api.github.com/repos/pelmers/dxr/stargazers","contributors_url":"https://api.github.com/repos/pelmers/dxr/contributors","subscribers_url":"https://api.github.com/repos/pelmers/dxr/subscribers","subscription_url":"https://api.github.com/repos/pelmers/dxr/subscription","commits_url":"https://api.github.com/repos/pelmers/dxr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pelmers/dxr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pelmers/dxr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pelmers/dxr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pelmers/dxr/contents/{+path}","compare_url":"https://api.github.com/repos/pelmers/dxr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pelmers/dxr/merges","archive_url":"https://api.github.com/repos/pelmers/dxr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pelmers/dxr/downloads","issues_url":"https://api.github.com/repos/pelmers/dxr/issues{/number}","pulls_url":"https://api.github.com/repos/pelmers/dxr/pulls{/number}","milestones_url":"https://api.github.com/repos/pelmers/dxr/milestones{/number}","notifications_url":"https://api.github.com/repos/pelmers/dxr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pelmers/dxr/labels{/name}","releases_url":"https://api.github.com/repos/pelmers/dxr/releases{/id}","created_at":"2014-01-13T23:50:59Z","updated_at":"2015-01-02T15:41:27Z","pushed_at":"2015-05-28T23:34:20Z","git_url":"git://github.com/pelmers/dxr.git","ssh_url":"git@github.com:pelmers/dxr.git","clone_url":"https://github.com/pelmers/dxr.git","svn_url":"https://github.com/pelmers/dxr","homepage":"","size":10567,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:es","ref":"es","sha":"d1398ea9d98a65cf035743f6a0215b2e1c27d878","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1795049,"name":"dxr","full_name":"mozilla/dxr","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/dxr","description":"An intelligent source code browser","fork":false,"url":"https://api.github.com/repos/mozilla/dxr","forks_url":"https://api.github.com/repos/mozilla/dxr/forks","keys_url":"https://api.github.com/repos/mozilla/dxr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/dxr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/dxr/teams","hooks_url":"https://api.github.com/repos/mozilla/dxr/hooks","issue_events_url":"https://api.github.com/repos/mozilla/dxr/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/dxr/events","assignees_url":"https://api.github.com/repos/mozilla/dxr/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/dxr/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/dxr/tags","blobs_url":"https://api.github.com/repos/mozilla/dxr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/dxr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/dxr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/dxr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/dxr/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/dxr/languages","stargazers_url":"https://api.github.com/repos/mozilla/dxr/stargazers","contributors_url":"https://api.github.com/repos/mozilla/dxr/contributors","subscribers_url":"https://api.github.com/repos/mozilla/dxr/subscribers","subscription_url":"https://api.github.com/repos/mozilla/dxr/subscription","commits_url":"https://api.github.com/repos/mozilla/dxr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/dxr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/dxr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/dxr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/dxr/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/dxr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/dxr/merges","archive_url":"https://api.github.com/repos/mozilla/dxr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/dxr/downloads","issues_url":"https://api.github.com/repos/mozilla/dxr/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/dxr/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/dxr/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/dxr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/dxr/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/dxr/releases{/id}","created_at":"2011-05-24T18:52:38Z","updated_at":"2015-05-28T21:33:41Z","pushed_at":"2015-05-28T23:34:21Z","git_url":"git://github.com/mozilla/dxr.git","ssh_url":"git@github.com:mozilla/dxr.git","clone_url":"https://github.com/mozilla/dxr.git","svn_url":"https://github.com/mozilla/dxr","homepage":"https://dxr.readthedocs.org/","size":14770,"stargazers_count":302,"watchers_count":302,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":28,"forks":124,"open_issues":28,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/419"},"html":{"href":"https://github.com/mozilla/dxr/pull/419"},"issue":{"href":"https://api.github.com/repos/mozilla/dxr/issues/419"},"comments":{"href":"https://api.github.com/repos/mozilla/dxr/issues/419/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/419/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/dxr/pulls/419/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/dxr/statuses/83ea2fdad95e94b1fd58ca0affc22537af515e7f"}}}}