{"action":"created","issue":{"url":"https://api.github.com/repos/fatlinesofcode/ngDraggable/issues/55","labels_url":"https://api.github.com/repos/fatlinesofcode/ngDraggable/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/fatlinesofcode/ngDraggable/issues/55/comments","events_url":"https://api.github.com/repos/fatlinesofcode/ngDraggable/issues/55/events","html_url":"https://github.com/fatlinesofcode/ngDraggable/pull/55","id":52672879,"number":55,"title":"Remove jQuery dependency","user":{"login":"sh3rndon","id":3084849,"avatar_url":"https://avatars.githubusercontent.com/u/3084849?v=3","gravatar_id":"","url":"https://api.github.com/users/sh3rndon","html_url":"https://github.com/sh3rndon","followers_url":"https://api.github.com/users/sh3rndon/followers","following_url":"https://api.github.com/users/sh3rndon/following{/other_user}","gists_url":"https://api.github.com/users/sh3rndon/gists{/gist_id}","starred_url":"https://api.github.com/users/sh3rndon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sh3rndon/subscriptions","organizations_url":"https://api.github.com/users/sh3rndon/orgs","repos_url":"https://api.github.com/users/sh3rndon/repos","events_url":"https://api.github.com/users/sh3rndon/events{/privacy}","received_events_url":"https://api.github.com/users/sh3rndon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2014-12-22T17:59:32Z","updated_at":"2015-01-09T20:17:54Z","closed_at":"2015-01-04T23:30:16Z","pull_request":{"url":"https://api.github.com/repos/fatlinesofcode/ngDraggable/pulls/55","html_url":"https://github.com/fatlinesofcode/ngDraggable/pull/55","diff_url":"https://github.com/fatlinesofcode/ngDraggable/pull/55.diff","patch_url":"https://github.com/fatlinesofcode/ngDraggable/pull/55.patch"},"body":"This is my first fork/pull, so I'm not sure I'm doing this right.\r\n\r\nI like this module, but have a jQuery-free app so replaced the jQuery code that was getting dom element dimensions and offset with a private function (_privoffset) in ngDrag and ngDrop directives. I don't like duplication of this function, but not sure of the cleanest way to DRY this up. My hope is that someone else will do it the right way.\r\n\r\nSummary of changes\r\n=====================\r\n- removed dependency on jQuery\r\n- inject $window and $document instead of creating local vars for them\r\n- prevent duplicate drop events when element has both ng-drag and ng-drop behavior\r\n- don't move the drag element in the initial press, wait till dragging starts\r\n- don't clobber margin of drag element when moving it"},"comment":{"url":"https://api.github.com/repos/fatlinesofcode/ngDraggable/issues/comments/69392444","html_url":"https://github.com/fatlinesofcode/ngDraggable/pull/55#issuecomment-69392444","issue_url":"https://api.github.com/repos/fatlinesofcode/ngDraggable/issues/55","id":69392444,"user":{"login":"arashsoft","id":6943739,"avatar_url":"https://avatars.githubusercontent.com/u/6943739?v=3","gravatar_id":"","url":"https://api.github.com/users/arashsoft","html_url":"https://github.com/arashsoft","followers_url":"https://api.github.com/users/arashsoft/followers","following_url":"https://api.github.com/users/arashsoft/following{/other_user}","gists_url":"https://api.github.com/users/arashsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/arashsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arashsoft/subscriptions","organizations_url":"https://api.github.com/users/arashsoft/orgs","repos_url":"https://api.github.com/users/arashsoft/repos","events_url":"https://api.github.com/users/arashsoft/events{/privacy}","received_events_url":"https://api.github.com/users/arashsoft/received_events","type":"User","site_admin":false},"created_at":"2015-01-09T20:17:54Z","updated_at":"2015-01-09T20:17:54Z","body":"I added .originalEvent and it works."}}