{"action":"opened","number":12,"pull_request":{"url":"https://api.github.com/repos/rangle/ngcourse-next/pulls/12","id":40501846,"html_url":"https://github.com/rangle/ngcourse-next/pull/12","diff_url":"https://github.com/rangle/ngcourse-next/pull/12.diff","patch_url":"https://github.com/rangle/ngcourse-next/pull/12.patch","issue_url":"https://api.github.com/repos/rangle/ngcourse-next/issues/12","number":12,"state":"open","locked":false,"title":"Fix task edit reload, minor cleanup","user":{"login":"igor-ka","id":12536242,"avatar_url":"https://avatars.githubusercontent.com/u/12536242?v=3","gravatar_id":"","url":"https://api.github.com/users/igor-ka","html_url":"https://github.com/igor-ka","followers_url":"https://api.github.com/users/igor-ka/followers","following_url":"https://api.github.com/users/igor-ka/following{/other_user}","gists_url":"https://api.github.com/users/igor-ka/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-ka/subscriptions","organizations_url":"https://api.github.com/users/igor-ka/orgs","repos_url":"https://api.github.com/users/igor-ka/repos","events_url":"https://api.github.com/users/igor-ka/events{/privacy}","received_events_url":"https://api.github.com/users/igor-ka/received_events","type":"User","site_admin":false},"body":"- Fix a bug on task edit route reload (shows empty form)\r\n- Use bindToController, instead of scope\r\n- Remove empty route from router service\r\n\r\nHey @winkerVSbecks here is another one. This is about task edit component display a blank form on page reload. The fix make this component not-dumb. However this component is used in routing and from my experience in black crows and working on this course, it seems that routed component fit better when they are smart.\r\n\r\nIn either case I have examples of dumb component in the repo anyway. \r\nAlso, there is some minor cleanup tagged along, bindToController is one of them. ","created_at":"2015-07-21T20:39:07Z","updated_at":"2015-07-21T20:39:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e713f715c289f8d04aebf75f4439b0f196a7293","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rangle/ngcourse-next/pulls/12/commits","review_comments_url":"https://api.github.com/repos/rangle/ngcourse-next/pulls/12/comments","review_comment_url":"https://api.github.com/repos/rangle/ngcourse-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rangle/ngcourse-next/issues/12/comments","statuses_url":"https://api.github.com/repos/rangle/ngcourse-next/statuses/793dd8fe843c7dc353e7045cb735be4fb36ad527","head":{"label":"igor-ka:fix-taskEditReload","ref":"fix-taskEditReload","sha":"793dd8fe843c7dc353e7045cb735be4fb36ad527","user":{"login":"igor-ka","id":12536242,"avatar_url":"https://avatars.githubusercontent.com/u/12536242?v=3","gravatar_id":"","url":"https://api.github.com/users/igor-ka","html_url":"https://github.com/igor-ka","followers_url":"https://api.github.com/users/igor-ka/followers","following_url":"https://api.github.com/users/igor-ka/following{/other_user}","gists_url":"https://api.github.com/users/igor-ka/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-ka/subscriptions","organizations_url":"https://api.github.com/users/igor-ka/orgs","repos_url":"https://api.github.com/users/igor-ka/repos","events_url":"https://api.github.com/users/igor-ka/events{/privacy}","received_events_url":"https://api.github.com/users/igor-ka/received_events","type":"User","site_admin":false},"repo":{"id":37665852,"name":"ngcourse-next","full_name":"igor-ka/ngcourse-next","owner":{"login":"igor-ka","id":12536242,"avatar_url":"https://avatars.githubusercontent.com/u/12536242?v=3","gravatar_id":"","url":"https://api.github.com/users/igor-ka","html_url":"https://github.com/igor-ka","followers_url":"https://api.github.com/users/igor-ka/followers","following_url":"https://api.github.com/users/igor-ka/following{/other_user}","gists_url":"https://api.github.com/users/igor-ka/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-ka/subscriptions","organizations_url":"https://api.github.com/users/igor-ka/orgs","repos_url":"https://api.github.com/users/igor-ka/repos","events_url":"https://api.github.com/users/igor-ka/events{/privacy}","received_events_url":"https://api.github.com/users/igor-ka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/igor-ka/ngcourse-next","description":"A course that teaches how to build Angular 1 applications the Angular 2 way.","fork":true,"url":"https://api.github.com/repos/igor-ka/ngcourse-next","forks_url":"https://api.github.com/repos/igor-ka/ngcourse-next/forks","keys_url":"https://api.github.com/repos/igor-ka/ngcourse-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igor-ka/ngcourse-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igor-ka/ngcourse-next/teams","hooks_url":"https://api.github.com/repos/igor-ka/ngcourse-next/hooks","issue_events_url":"https://api.github.com/repos/igor-ka/ngcourse-next/issues/events{/number}","events_url":"https://api.github.com/repos/igor-ka/ngcourse-next/events","assignees_url":"https://api.github.com/repos/igor-ka/ngcourse-next/assignees{/user}","branches_url":"https://api.github.com/repos/igor-ka/ngcourse-next/branches{/branch}","tags_url":"https://api.github.com/repos/igor-ka/ngcourse-next/tags","blobs_url":"https://api.github.com/repos/igor-ka/ngcourse-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igor-ka/ngcourse-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igor-ka/ngcourse-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/igor-ka/ngcourse-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igor-ka/ngcourse-next/statuses/{sha}","languages_url":"https://api.github.com/repos/igor-ka/ngcourse-next/languages","stargazers_url":"https://api.github.com/repos/igor-ka/ngcourse-next/stargazers","contributors_url":"https://api.github.com/repos/igor-ka/ngcourse-next/contributors","subscribers_url":"https://api.github.com/repos/igor-ka/ngcourse-next/subscribers","subscription_url":"https://api.github.com/repos/igor-ka/ngcourse-next/subscription","commits_url":"https://api.github.com/repos/igor-ka/ngcourse-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/igor-ka/ngcourse-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/igor-ka/ngcourse-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/igor-ka/ngcourse-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/igor-ka/ngcourse-next/contents/{+path}","compare_url":"https://api.github.com/repos/igor-ka/ngcourse-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igor-ka/ngcourse-next/merges","archive_url":"https://api.github.com/repos/igor-ka/ngcourse-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igor-ka/ngcourse-next/downloads","issues_url":"https://api.github.com/repos/igor-ka/ngcourse-next/issues{/number}","pulls_url":"https://api.github.com/repos/igor-ka/ngcourse-next/pulls{/number}","milestones_url":"https://api.github.com/repos/igor-ka/ngcourse-next/milestones{/number}","notifications_url":"https://api.github.com/repos/igor-ka/ngcourse-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igor-ka/ngcourse-next/labels{/name}","releases_url":"https://api.github.com/repos/igor-ka/ngcourse-next/releases{/id}","created_at":"2015-06-18T14:55:20Z","updated_at":"2015-07-13T18:52:23Z","pushed_at":"2015-07-21T20:36:06Z","git_url":"git://github.com/igor-ka/ngcourse-next.git","ssh_url":"git@github.com:igor-ka/ngcourse-next.git","clone_url":"https://github.com/igor-ka/ngcourse-next.git","svn_url":"https://github.com/igor-ka/ngcourse-next","homepage":null,"size":2872,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"rangle:master","ref":"master","sha":"656c6150c81525476027f700974a8443dd18dda2","user":{"login":"rangle","id":4304982,"avatar_url":"https://avatars.githubusercontent.com/u/4304982?v=3","gravatar_id":"","url":"https://api.github.com/users/rangle","html_url":"https://github.com/rangle","followers_url":"https://api.github.com/users/rangle/followers","following_url":"https://api.github.com/users/rangle/following{/other_user}","gists_url":"https://api.github.com/users/rangle/gists{/gist_id}","starred_url":"https://api.github.com/users/rangle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rangle/subscriptions","organizations_url":"https://api.github.com/users/rangle/orgs","repos_url":"https://api.github.com/users/rangle/repos","events_url":"https://api.github.com/users/rangle/events{/privacy}","received_events_url":"https://api.github.com/users/rangle/received_events","type":"Organization","site_admin":false},"repo":{"id":36198776,"name":"ngcourse-next","full_name":"rangle/ngcourse-next","owner":{"login":"rangle","id":4304982,"avatar_url":"https://avatars.githubusercontent.com/u/4304982?v=3","gravatar_id":"","url":"https://api.github.com/users/rangle","html_url":"https://github.com/rangle","followers_url":"https://api.github.com/users/rangle/followers","following_url":"https://api.github.com/users/rangle/following{/other_user}","gists_url":"https://api.github.com/users/rangle/gists{/gist_id}","starred_url":"https://api.github.com/users/rangle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rangle/subscriptions","organizations_url":"https://api.github.com/users/rangle/orgs","repos_url":"https://api.github.com/users/rangle/repos","events_url":"https://api.github.com/users/rangle/events{/privacy}","received_events_url":"https://api.github.com/users/rangle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rangle/ngcourse-next","description":"A course that teaches how to build Angular 1 applications the Angular 2 way.","fork":false,"url":"https://api.github.com/repos/rangle/ngcourse-next","forks_url":"https://api.github.com/repos/rangle/ngcourse-next/forks","keys_url":"https://api.github.com/repos/rangle/ngcourse-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rangle/ngcourse-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rangle/ngcourse-next/teams","hooks_url":"https://api.github.com/repos/rangle/ngcourse-next/hooks","issue_events_url":"https://api.github.com/repos/rangle/ngcourse-next/issues/events{/number}","events_url":"https://api.github.com/repos/rangle/ngcourse-next/events","assignees_url":"https://api.github.com/repos/rangle/ngcourse-next/assignees{/user}","branches_url":"https://api.github.com/repos/rangle/ngcourse-next/branches{/branch}","tags_url":"https://api.github.com/repos/rangle/ngcourse-next/tags","blobs_url":"https://api.github.com/repos/rangle/ngcourse-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rangle/ngcourse-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rangle/ngcourse-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/rangle/ngcourse-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rangle/ngcourse-next/statuses/{sha}","languages_url":"https://api.github.com/repos/rangle/ngcourse-next/languages","stargazers_url":"https://api.github.com/repos/rangle/ngcourse-next/stargazers","contributors_url":"https://api.github.com/repos/rangle/ngcourse-next/contributors","subscribers_url":"https://api.github.com/repos/rangle/ngcourse-next/subscribers","subscription_url":"https://api.github.com/repos/rangle/ngcourse-next/subscription","commits_url":"https://api.github.com/repos/rangle/ngcourse-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/rangle/ngcourse-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/rangle/ngcourse-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/rangle/ngcourse-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/rangle/ngcourse-next/contents/{+path}","compare_url":"https://api.github.com/repos/rangle/ngcourse-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rangle/ngcourse-next/merges","archive_url":"https://api.github.com/repos/rangle/ngcourse-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rangle/ngcourse-next/downloads","issues_url":"https://api.github.com/repos/rangle/ngcourse-next/issues{/number}","pulls_url":"https://api.github.com/repos/rangle/ngcourse-next/pulls{/number}","milestones_url":"https://api.github.com/repos/rangle/ngcourse-next/milestones{/number}","notifications_url":"https://api.github.com/repos/rangle/ngcourse-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rangle/ngcourse-next/labels{/name}","releases_url":"https://api.github.com/repos/rangle/ngcourse-next/releases{/id}","created_at":"2015-05-24T23:17:16Z","updated_at":"2015-07-19T04:12:49Z","pushed_at":"2015-07-21T20:39:08Z","git_url":"git://github.com/rangle/ngcourse-next.git","ssh_url":"git@github.com:rangle/ngcourse-next.git","clone_url":"https://github.com/rangle/ngcourse-next.git","svn_url":"https://github.com/rangle/ngcourse-next","homepage":null,"size":2859,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rangle/ngcourse-next/pulls/12"},"html":{"href":"https://github.com/rangle/ngcourse-next/pull/12"},"issue":{"href":"https://api.github.com/repos/rangle/ngcourse-next/issues/12"},"comments":{"href":"https://api.github.com/repos/rangle/ngcourse-next/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/rangle/ngcourse-next/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/rangle/ngcourse-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rangle/ngcourse-next/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/rangle/ngcourse-next/statuses/793dd8fe843c7dc353e7045cb735be4fb36ad527"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":8,"changed_files":4}}