{"action":"closed","number":517,"pull_request":{"url":"https://api.github.com/repos/uutils/coreutils/pulls/517","id":28170372,"html_url":"https://github.com/uutils/coreutils/pull/517","diff_url":"https://github.com/uutils/coreutils/pull/517.diff","patch_url":"https://github.com/uutils/coreutils/pull/517.patch","issue_url":"https://api.github.com/repos/uutils/coreutils/issues/517","number":517,"state":"closed","locked":false,"title":"od: fix --address-radix interpretation and minor cleanups","user":{"login":"keunwoo","id":773433,"avatar_url":"https://avatars.githubusercontent.com/u/773433?v=3","gravatar_id":"","url":"https://api.github.com/users/keunwoo","html_url":"https://github.com/keunwoo","followers_url":"https://api.github.com/users/keunwoo/followers","following_url":"https://api.github.com/users/keunwoo/following{/other_user}","gists_url":"https://api.github.com/users/keunwoo/gists{/gist_id}","starred_url":"https://api.github.com/users/keunwoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keunwoo/subscriptions","organizations_url":"https://api.github.com/users/keunwoo/orgs","repos_url":"https://api.github.com/users/keunwoo/repos","events_url":"https://api.github.com/users/keunwoo/events{/privacy}","received_events_url":"https://api.github.com/users/keunwoo/received_events","type":"User","site_admin":false},"body":"The initial draft written by @benhirsch24 misinterpreted the -A/--address-radix flag. This flag should control the printing of the file offsets (the leftmost field of the output), not the printing of the values in the output bytes. See the POSIX spec for od:\r\n\r\nhttp://pubs.opengroup.org/onlinepubs/9699919799/utilities/od.html\r\n\r\nYou can also verify this by running any standard od on any input whatsoever.\r\n\r\nThis PR implements an initial fix for this defect. A few preparatory cleanups I made related to fixing this bug are rolled into this PR as well.","created_at":"2015-01-28T05:59:08Z","updated_at":"2015-02-01T20:13:37Z","closed_at":"2015-02-01T20:13:37Z","merged_at":"2015-02-01T20:13:37Z","merge_commit_sha":"96177ec7691d34f54edcc8db27fa82c67b4a10ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uutils/coreutils/pulls/517/commits","review_comments_url":"https://api.github.com/repos/uutils/coreutils/pulls/517/comments","review_comment_url":"https://api.github.com/repos/uutils/coreutils/pulls/comments/{number}","comments_url":"https://api.github.com/repos/uutils/coreutils/issues/517/comments","statuses_url":"https://api.github.com/repos/uutils/coreutils/statuses/f6a07663e8ebe13b5703e24c9c127c2941e2c36c","head":{"label":"keunwoo:keunwoo-fix-address-radix-20150127","ref":"keunwoo-fix-address-radix-20150127","sha":"f6a07663e8ebe13b5703e24c9c127c2941e2c36c","user":{"login":"keunwoo","id":773433,"avatar_url":"https://avatars.githubusercontent.com/u/773433?v=3","gravatar_id":"","url":"https://api.github.com/users/keunwoo","html_url":"https://github.com/keunwoo","followers_url":"https://api.github.com/users/keunwoo/followers","following_url":"https://api.github.com/users/keunwoo/following{/other_user}","gists_url":"https://api.github.com/users/keunwoo/gists{/gist_id}","starred_url":"https://api.github.com/users/keunwoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keunwoo/subscriptions","organizations_url":"https://api.github.com/users/keunwoo/orgs","repos_url":"https://api.github.com/users/keunwoo/repos","events_url":"https://api.github.com/users/keunwoo/events{/privacy}","received_events_url":"https://api.github.com/users/keunwoo/received_events","type":"User","site_admin":false},"repo":{"id":29807200,"name":"coreutils","full_name":"keunwoo/coreutils","owner":{"login":"keunwoo","id":773433,"avatar_url":"https://avatars.githubusercontent.com/u/773433?v=3","gravatar_id":"","url":"https://api.github.com/users/keunwoo","html_url":"https://github.com/keunwoo","followers_url":"https://api.github.com/users/keunwoo/followers","following_url":"https://api.github.com/users/keunwoo/following{/other_user}","gists_url":"https://api.github.com/users/keunwoo/gists{/gist_id}","starred_url":"https://api.github.com/users/keunwoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keunwoo/subscriptions","organizations_url":"https://api.github.com/users/keunwoo/orgs","repos_url":"https://api.github.com/users/keunwoo/repos","events_url":"https://api.github.com/users/keunwoo/events{/privacy}","received_events_url":"https://api.github.com/users/keunwoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keunwoo/coreutils","description":"Cross-platform Rust rewrite of the GNU coreutils","fork":true,"url":"https://api.github.com/repos/keunwoo/coreutils","forks_url":"https://api.github.com/repos/keunwoo/coreutils/forks","keys_url":"https://api.github.com/repos/keunwoo/coreutils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keunwoo/coreutils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keunwoo/coreutils/teams","hooks_url":"https://api.github.com/repos/keunwoo/coreutils/hooks","issue_events_url":"https://api.github.com/repos/keunwoo/coreutils/issues/events{/number}","events_url":"https://api.github.com/repos/keunwoo/coreutils/events","assignees_url":"https://api.github.com/repos/keunwoo/coreutils/assignees{/user}","branches_url":"https://api.github.com/repos/keunwoo/coreutils/branches{/branch}","tags_url":"https://api.github.com/repos/keunwoo/coreutils/tags","blobs_url":"https://api.github.com/repos/keunwoo/coreutils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keunwoo/coreutils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keunwoo/coreutils/git/refs{/sha}","trees_url":"https://api.github.com/repos/keunwoo/coreutils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keunwoo/coreutils/statuses/{sha}","languages_url":"https://api.github.com/repos/keunwoo/coreutils/languages","stargazers_url":"https://api.github.com/repos/keunwoo/coreutils/stargazers","contributors_url":"https://api.github.com/repos/keunwoo/coreutils/contributors","subscribers_url":"https://api.github.com/repos/keunwoo/coreutils/subscribers","subscription_url":"https://api.github.com/repos/keunwoo/coreutils/subscription","commits_url":"https://api.github.com/repos/keunwoo/coreutils/commits{/sha}","git_commits_url":"https://api.github.com/repos/keunwoo/coreutils/git/commits{/sha}","comments_url":"https://api.github.com/repos/keunwoo/coreutils/comments{/number}","issue_comment_url":"https://api.github.com/repos/keunwoo/coreutils/issues/comments/{number}","contents_url":"https://api.github.com/repos/keunwoo/coreutils/contents/{+path}","compare_url":"https://api.github.com/repos/keunwoo/coreutils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keunwoo/coreutils/merges","archive_url":"https://api.github.com/repos/keunwoo/coreutils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keunwoo/coreutils/downloads","issues_url":"https://api.github.com/repos/keunwoo/coreutils/issues{/number}","pulls_url":"https://api.github.com/repos/keunwoo/coreutils/pulls{/number}","milestones_url":"https://api.github.com/repos/keunwoo/coreutils/milestones{/number}","notifications_url":"https://api.github.com/repos/keunwoo/coreutils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keunwoo/coreutils/labels{/name}","releases_url":"https://api.github.com/repos/keunwoo/coreutils/releases{/id}","created_at":"2015-01-25T07:57:21Z","updated_at":"2015-01-28T05:52:09Z","pushed_at":"2015-01-28T06:07:13Z","git_url":"git://github.com/keunwoo/coreutils.git","ssh_url":"git@github.com:keunwoo/coreutils.git","clone_url":"https://github.com/keunwoo/coreutils.git","svn_url":"https://github.com/keunwoo/coreutils","homepage":"","size":1715,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uutils:master","ref":"master","sha":"2f0d8c89c94ee4b6c1d911c48d6e56f002e2def7","user":{"login":"uutils","id":5148717,"avatar_url":"https://avatars.githubusercontent.com/u/5148717?v=3","gravatar_id":"","url":"https://api.github.com/users/uutils","html_url":"https://github.com/uutils","followers_url":"https://api.github.com/users/uutils/followers","following_url":"https://api.github.com/users/uutils/following{/other_user}","gists_url":"https://api.github.com/users/uutils/gists{/gist_id}","starred_url":"https://api.github.com/users/uutils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uutils/subscriptions","organizations_url":"https://api.github.com/users/uutils/orgs","repos_url":"https://api.github.com/users/uutils/repos","events_url":"https://api.github.com/users/uutils/events{/privacy}","received_events_url":"https://api.github.com/users/uutils/received_events","type":"Organization","site_admin":false},"repo":{"id":11847500,"name":"coreutils","full_name":"uutils/coreutils","owner":{"login":"uutils","id":5148717,"avatar_url":"https://avatars.githubusercontent.com/u/5148717?v=3","gravatar_id":"","url":"https://api.github.com/users/uutils","html_url":"https://github.com/uutils","followers_url":"https://api.github.com/users/uutils/followers","following_url":"https://api.github.com/users/uutils/following{/other_user}","gists_url":"https://api.github.com/users/uutils/gists{/gist_id}","starred_url":"https://api.github.com/users/uutils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uutils/subscriptions","organizations_url":"https://api.github.com/users/uutils/orgs","repos_url":"https://api.github.com/users/uutils/repos","events_url":"https://api.github.com/users/uutils/events{/privacy}","received_events_url":"https://api.github.com/users/uutils/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uutils/coreutils","description":"Cross-platform Rust rewrite of the GNU coreutils","fork":false,"url":"https://api.github.com/repos/uutils/coreutils","forks_url":"https://api.github.com/repos/uutils/coreutils/forks","keys_url":"https://api.github.com/repos/uutils/coreutils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uutils/coreutils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uutils/coreutils/teams","hooks_url":"https://api.github.com/repos/uutils/coreutils/hooks","issue_events_url":"https://api.github.com/repos/uutils/coreutils/issues/events{/number}","events_url":"https://api.github.com/repos/uutils/coreutils/events","assignees_url":"https://api.github.com/repos/uutils/coreutils/assignees{/user}","branches_url":"https://api.github.com/repos/uutils/coreutils/branches{/branch}","tags_url":"https://api.github.com/repos/uutils/coreutils/tags","blobs_url":"https://api.github.com/repos/uutils/coreutils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uutils/coreutils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uutils/coreutils/git/refs{/sha}","trees_url":"https://api.github.com/repos/uutils/coreutils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uutils/coreutils/statuses/{sha}","languages_url":"https://api.github.com/repos/uutils/coreutils/languages","stargazers_url":"https://api.github.com/repos/uutils/coreutils/stargazers","contributors_url":"https://api.github.com/repos/uutils/coreutils/contributors","subscribers_url":"https://api.github.com/repos/uutils/coreutils/subscribers","subscription_url":"https://api.github.com/repos/uutils/coreutils/subscription","commits_url":"https://api.github.com/repos/uutils/coreutils/commits{/sha}","git_commits_url":"https://api.github.com/repos/uutils/coreutils/git/commits{/sha}","comments_url":"https://api.github.com/repos/uutils/coreutils/comments{/number}","issue_comment_url":"https://api.github.com/repos/uutils/coreutils/issues/comments/{number}","contents_url":"https://api.github.com/repos/uutils/coreutils/contents/{+path}","compare_url":"https://api.github.com/repos/uutils/coreutils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uutils/coreutils/merges","archive_url":"https://api.github.com/repos/uutils/coreutils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uutils/coreutils/downloads","issues_url":"https://api.github.com/repos/uutils/coreutils/issues{/number}","pulls_url":"https://api.github.com/repos/uutils/coreutils/pulls{/number}","milestones_url":"https://api.github.com/repos/uutils/coreutils/milestones{/number}","notifications_url":"https://api.github.com/repos/uutils/coreutils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uutils/coreutils/labels{/name}","releases_url":"https://api.github.com/repos/uutils/coreutils/releases{/id}","created_at":"2013-08-02T16:22:56Z","updated_at":"2015-02-01T07:48:13Z","pushed_at":"2015-02-01T20:13:37Z","git_url":"git://github.com/uutils/coreutils.git","ssh_url":"git@github.com:uutils/coreutils.git","clone_url":"https://github.com/uutils/coreutils.git","svn_url":"https://github.com/uutils/coreutils","homepage":"","size":4241,"stargazers_count":1235,"watchers_count":1235,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":44,"forks":137,"open_issues":44,"watchers":1235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uutils/coreutils/pulls/517"},"html":{"href":"https://github.com/uutils/coreutils/pull/517"},"issue":{"href":"https://api.github.com/repos/uutils/coreutils/issues/517"},"comments":{"href":"https://api.github.com/repos/uutils/coreutils/issues/517/comments"},"review_comments":{"href":"https://api.github.com/repos/uutils/coreutils/pulls/517/comments"},"review_comment":{"href":"https://api.github.com/repos/uutils/coreutils/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/uutils/coreutils/pulls/517/commits"},"statuses":{"href":"https://api.github.com/repos/uutils/coreutils/statuses/f6a07663e8ebe13b5703e24c9c127c2941e2c36c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Arcterus","id":829813,"avatar_url":"https://avatars.githubusercontent.com/u/829813?v=3","gravatar_id":"","url":"https://api.github.com/users/Arcterus","html_url":"https://github.com/Arcterus","followers_url":"https://api.github.com/users/Arcterus/followers","following_url":"https://api.github.com/users/Arcterus/following{/other_user}","gists_url":"https://api.github.com/users/Arcterus/gists{/gist_id}","starred_url":"https://api.github.com/users/Arcterus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arcterus/subscriptions","organizations_url":"https://api.github.com/users/Arcterus/orgs","repos_url":"https://api.github.com/users/Arcterus/repos","events_url":"https://api.github.com/users/Arcterus/events{/privacy}","received_events_url":"https://api.github.com/users/Arcterus/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":48,"deletions":50,"changed_files":1}}