{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/44720917","id":44720917,"diff_hunk":"@@ -386,6 +492,8 @@ def eni_absent(\n     else:\n         if __opts__['test']:\n             ret['comment'] = 'ENI is set to be deleted.'\n+            if release_eip and 'allocationId' in r['result']:","path":"salt/states/boto_ec2.py","position":152,"original_position":152,"commit_id":"0f276a7c8ddec508007d59427692f96cbe4fce8b","original_commit_id":"0f276a7c8ddec508007d59427692f96cbe4fce8b","user":{"login":"lomeroe","id":8835244,"avatar_url":"https://avatars.githubusercontent.com/u/8835244?v=3","gravatar_id":"","url":"https://api.github.com/users/lomeroe","html_url":"https://github.com/lomeroe","followers_url":"https://api.github.com/users/lomeroe/followers","following_url":"https://api.github.com/users/lomeroe/following{/other_user}","gists_url":"https://api.github.com/users/lomeroe/gists{/gist_id}","starred_url":"https://api.github.com/users/lomeroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lomeroe/subscriptions","organizations_url":"https://api.github.com/users/lomeroe/orgs","repos_url":"https://api.github.com/users/lomeroe/repos","events_url":"https://api.github.com/users/lomeroe/events{/privacy}","received_events_url":"https://api.github.com/users/lomeroe/received_events","type":"User","site_admin":false},"body":"@ryan-lane wouldn't this be the only check needed for a test=True state run?  Or am I missing something?","created_at":"2015-11-12T21:57:43Z","updated_at":"2015-11-12T21:57:43Z","html_url":"https://github.com/saltstack/salt/pull/28841#discussion_r44720917","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/28841","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/44720917"},"html":{"href":"https://github.com/saltstack/salt/pull/28841#discussion_r44720917"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28841"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/28841","id":50565191,"html_url":"https://github.com/saltstack/salt/pull/28841","diff_url":"https://github.com/saltstack/salt/pull/28841.diff","patch_url":"https://github.com/saltstack/salt/pull/28841.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/28841","number":28841,"state":"open","locked":false,"title":"Boto ec2 eni updates","user":{"login":"lomeroe","id":8835244,"avatar_url":"https://avatars.githubusercontent.com/u/8835244?v=3","gravatar_id":"","url":"https://api.github.com/users/lomeroe","html_url":"https://github.com/lomeroe","followers_url":"https://api.github.com/users/lomeroe/followers","following_url":"https://api.github.com/users/lomeroe/following{/other_user}","gists_url":"https://api.github.com/users/lomeroe/gists{/gist_id}","starred_url":"https://api.github.com/users/lomeroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lomeroe/subscriptions","organizations_url":"https://api.github.com/users/lomeroe/orgs","repos_url":"https://api.github.com/users/lomeroe/repos","events_url":"https://api.github.com/users/lomeroe/events{/privacy}","received_events_url":"https://api.github.com/users/lomeroe/received_events","type":"User","site_admin":false},"body":"Modify associate_eip_address function in boto_ec2 module to allow associating an EIP to an ENI that is not yet attached to an instance (remove requirement for instance_id or instance_name to have a value)\r\n\r\nModify boto_ec2 state to allocate/associate an EIP to an ENI on eni_present\r\nModify boto_ec2 state to allow creation of DNS A records (similar to cname attribute in boto_elb)\r\nModify boto_ec2 state to allow release of EIP on eni_absent\r\n\r\n@ryan-lane : FYI","created_at":"2015-11-12T20:44:40Z","updated_at":"2015-11-12T21:57:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eb5efef1bb2635262cefa98acf52d5750041394","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/28841/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/28841/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/28841/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/0f276a7c8ddec508007d59427692f96cbe4fce8b","head":{"label":"lomeroe:boto_ec2-eni-updates","ref":"boto_ec2-eni-updates","sha":"0f276a7c8ddec508007d59427692f96cbe4fce8b","user":{"login":"lomeroe","id":8835244,"avatar_url":"https://avatars.githubusercontent.com/u/8835244?v=3","gravatar_id":"","url":"https://api.github.com/users/lomeroe","html_url":"https://github.com/lomeroe","followers_url":"https://api.github.com/users/lomeroe/followers","following_url":"https://api.github.com/users/lomeroe/following{/other_user}","gists_url":"https://api.github.com/users/lomeroe/gists{/gist_id}","starred_url":"https://api.github.com/users/lomeroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lomeroe/subscriptions","organizations_url":"https://api.github.com/users/lomeroe/orgs","repos_url":"https://api.github.com/users/lomeroe/repos","events_url":"https://api.github.com/users/lomeroe/events{/privacy}","received_events_url":"https://api.github.com/users/lomeroe/received_events","type":"User","site_admin":false},"repo":{"id":42666912,"name":"salt","full_name":"lomeroe/salt","owner":{"login":"lomeroe","id":8835244,"avatar_url":"https://avatars.githubusercontent.com/u/8835244?v=3","gravatar_id":"","url":"https://api.github.com/users/lomeroe","html_url":"https://github.com/lomeroe","followers_url":"https://api.github.com/users/lomeroe/followers","following_url":"https://api.github.com/users/lomeroe/following{/other_user}","gists_url":"https://api.github.com/users/lomeroe/gists{/gist_id}","starred_url":"https://api.github.com/users/lomeroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lomeroe/subscriptions","organizations_url":"https://api.github.com/users/lomeroe/orgs","repos_url":"https://api.github.com/users/lomeroe/repos","events_url":"https://api.github.com/users/lomeroe/events{/privacy}","received_events_url":"https://api.github.com/users/lomeroe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lomeroe/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/lomeroe/salt","forks_url":"https://api.github.com/repos/lomeroe/salt/forks","keys_url":"https://api.github.com/repos/lomeroe/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lomeroe/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lomeroe/salt/teams","hooks_url":"https://api.github.com/repos/lomeroe/salt/hooks","issue_events_url":"https://api.github.com/repos/lomeroe/salt/issues/events{/number}","events_url":"https://api.github.com/repos/lomeroe/salt/events","assignees_url":"https://api.github.com/repos/lomeroe/salt/assignees{/user}","branches_url":"https://api.github.com/repos/lomeroe/salt/branches{/branch}","tags_url":"https://api.github.com/repos/lomeroe/salt/tags","blobs_url":"https://api.github.com/repos/lomeroe/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lomeroe/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lomeroe/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/lomeroe/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lomeroe/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/lomeroe/salt/languages","stargazers_url":"https://api.github.com/repos/lomeroe/salt/stargazers","contributors_url":"https://api.github.com/repos/lomeroe/salt/contributors","subscribers_url":"https://api.github.com/repos/lomeroe/salt/subscribers","subscription_url":"https://api.github.com/repos/lomeroe/salt/subscription","commits_url":"https://api.github.com/repos/lomeroe/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/lomeroe/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/lomeroe/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/lomeroe/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/lomeroe/salt/contents/{+path}","compare_url":"https://api.github.com/repos/lomeroe/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lomeroe/salt/merges","archive_url":"https://api.github.com/repos/lomeroe/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lomeroe/salt/downloads","issues_url":"https://api.github.com/repos/lomeroe/salt/issues{/number}","pulls_url":"https://api.github.com/repos/lomeroe/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/lomeroe/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/lomeroe/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lomeroe/salt/labels{/name}","releases_url":"https://api.github.com/repos/lomeroe/salt/releases{/id}","created_at":"2015-09-17T16:13:36Z","updated_at":"2015-09-17T16:13:47Z","pushed_at":"2015-11-12T21:48:09Z","git_url":"git://github.com/lomeroe/salt.git","ssh_url":"git@github.com:lomeroe/salt.git","clone_url":"https://github.com/lomeroe/salt.git","svn_url":"https://github.com/lomeroe/salt","homepage":"saltstack.com","size":127587,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"af45a499a578e4ed089ab1699feef071c3f18895","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2015-11-12T21:10:17Z","pushed_at":"2015-11-12T21:51:01Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":259595,"stargazers_count":5873,"watchers_count":5873,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2523,"mirror_url":null,"open_issues_count":3122,"forks":2523,"open_issues":3122,"watchers":5873,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28841"},"html":{"href":"https://github.com/saltstack/salt/pull/28841"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/28841"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/28841/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28841/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/28841/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/0f276a7c8ddec508007d59427692f96cbe4fce8b"}}}}