{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/24011089","id":24011089,"diff_hunk":"@@ -116,6 +116,14 @@ class Tensor<0,dim,Number>\n   Tensor (const Tensor<0,dim,Number> &);\n \n   /**\n+   * Copy constructor from tensors with different underlying scalar\n+   * type. This obviously requires that the @p OtherNumber type is\n+   * convertible to @p Number.\n+   */\n+  template <typename OtherNumber>\n+  Tensor (const Tensor<0,dim,OtherNumber> &);\n+","path":"include/deal.II/base/tensor_base.h","position":18,"original_position":18,"commit_id":"78dd2443b7a8722ab1ee87ea7eafbc3c727436f4","original_commit_id":"78dd2443b7a8722ab1ee87ea7eafbc3c727436f4","user":{"login":"kronbichler","id":8276200,"avatar_url":"https://avatars.githubusercontent.com/u/8276200?v=3","gravatar_id":"","url":"https://api.github.com/users/kronbichler","html_url":"https://github.com/kronbichler","followers_url":"https://api.github.com/users/kronbichler/followers","following_url":"https://api.github.com/users/kronbichler/following{/other_user}","gists_url":"https://api.github.com/users/kronbichler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronbichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronbichler/subscriptions","organizations_url":"https://api.github.com/users/kronbichler/orgs","repos_url":"https://api.github.com/users/kronbichler/repos","events_url":"https://api.github.com/users/kronbichler/events{/privacy}","received_events_url":"https://api.github.com/users/kronbichler/received_events","type":"User","site_admin":false},"body":"Any reason not to make this constructor explicit as for Tensor<rank,dim>? Do we need to allow the conversion float -> Tensor<0,dim,float> -> Tensor<0,dim,double> this way?","created_at":"2015-02-03T15:31:07Z","updated_at":"2015-02-03T15:31:07Z","html_url":"https://github.com/dealii/dealii/pull/492#discussion_r24011089","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/492","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/24011089"},"html":{"href":"https://github.com/dealii/dealii/pull/492#discussion_r24011089"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/492"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/492","id":28560394,"html_url":"https://github.com/dealii/dealii/pull/492","diff_url":"https://github.com/dealii/dealii/pull/492.diff","patch_url":"https://github.com/dealii/dealii/pull/492.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/492","number":492,"state":"open","locked":false,"title":"Davydden tensor updates","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"This is an update to #491. It only adds the missing copy constructors to the specializations of class Tensor and updates the test.","created_at":"2015-02-03T15:23:06Z","updated_at":"2015-02-03T15:31:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebdd2ece10614841d6a3d9ffcd8a984895381d48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/492/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/492/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/492/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/78dd2443b7a8722ab1ee87ea7eafbc3c727436f4","head":{"label":"bangerth:davydden-tensor_updates","ref":"davydden-tensor_updates","sha":"78dd2443b7a8722ab1ee87ea7eafbc3c727436f4","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"repo":{"id":22048720,"name":"dealii","full_name":"bangerth/dealii","owner":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bangerth/dealii","description":"","fork":true,"url":"https://api.github.com/repos/bangerth/dealii","forks_url":"https://api.github.com/repos/bangerth/dealii/forks","keys_url":"https://api.github.com/repos/bangerth/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bangerth/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bangerth/dealii/teams","hooks_url":"https://api.github.com/repos/bangerth/dealii/hooks","issue_events_url":"https://api.github.com/repos/bangerth/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/bangerth/dealii/events","assignees_url":"https://api.github.com/repos/bangerth/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/bangerth/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/bangerth/dealii/tags","blobs_url":"https://api.github.com/repos/bangerth/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bangerth/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bangerth/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/bangerth/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bangerth/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/bangerth/dealii/languages","stargazers_url":"https://api.github.com/repos/bangerth/dealii/stargazers","contributors_url":"https://api.github.com/repos/bangerth/dealii/contributors","subscribers_url":"https://api.github.com/repos/bangerth/dealii/subscribers","subscription_url":"https://api.github.com/repos/bangerth/dealii/subscription","commits_url":"https://api.github.com/repos/bangerth/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/bangerth/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/bangerth/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/bangerth/dealii/issues/comments/{number}","contents_url":"https://api.github.com/repos/bangerth/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/bangerth/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bangerth/dealii/merges","archive_url":"https://api.github.com/repos/bangerth/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bangerth/dealii/downloads","issues_url":"https://api.github.com/repos/bangerth/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/bangerth/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/bangerth/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/bangerth/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bangerth/dealii/labels{/name}","releases_url":"https://api.github.com/repos/bangerth/dealii/releases{/id}","created_at":"2014-07-21T02:07:57Z","updated_at":"2015-02-03T13:45:38Z","pushed_at":"2015-02-03T15:22:10Z","git_url":"git://github.com/bangerth/dealii.git","ssh_url":"git@github.com:bangerth/dealii.git","clone_url":"https://github.com/bangerth/dealii.git","svn_url":"https://github.com/bangerth/dealii","homepage":null,"size":111352,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"c171eb65a40322c1ff5b0453fa46057d06335071","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments/{number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","created_at":"2014-07-17T14:00:26Z","updated_at":"2015-02-03T13:14:00Z","pushed_at":"2015-02-03T13:14:00Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":131719,"stargazers_count":43,"watchers_count":43,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":67,"forks":50,"open_issues":67,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/492"},"html":{"href":"https://github.com/dealii/dealii/pull/492"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/492"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/492/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/492/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/492/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/78dd2443b7a8722ab1ee87ea7eafbc3c727436f4"}}}}