{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/30967947","id":30967947,"diff_hunk":"@@ -319,4 +327,22 @@ public EmbeddedChannel contentEncoder() {\n             return contentEncoder;\n         }\n     }\n+\n+    private static final class RequestMetaData {","path":"codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java","position":62,"original_position":62,"commit_id":"4cefa3c9673b662738bbf3fa30f068a9686184e4","original_commit_id":"4cefa3c9673b662738bbf3fa30f068a9686184e4","user":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"body":"@naude-r Yes. To be precise, we will need to `CharSequence` constants. One for HEAD and the other for CONNECT, because we need to check the status code in case of CONNECT.","created_at":"2015-05-25T08:14:08Z","updated_at":"2015-05-25T08:14:08Z","html_url":"https://github.com/netty/netty/pull/3753#discussion_r30967947","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/3753","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/30967947"},"html":{"href":"https://github.com/netty/netty/pull/3753#discussion_r30967947"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/3753"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/3753","id":34888375,"html_url":"https://github.com/netty/netty/pull/3753","diff_url":"https://github.com/netty/netty/pull/3753.diff","patch_url":"https://github.com/netty/netty/pull/3753.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/3753","number":3753,"state":"open","locked":false,"title":"Support empty http responses when using compression","user":{"login":"naude-r","id":1931708,"avatar_url":"https://avatars.githubusercontent.com/u/1931708?v=3","gravatar_id":"","url":"https://api.github.com/users/naude-r","html_url":"https://github.com/naude-r","followers_url":"https://api.github.com/users/naude-r/followers","following_url":"https://api.github.com/users/naude-r/following{/other_user}","gists_url":"https://api.github.com/users/naude-r/gists{/gist_id}","starred_url":"https://api.github.com/users/naude-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naude-r/subscriptions","organizations_url":"https://api.github.com/users/naude-r/orgs","repos_url":"https://api.github.com/users/naude-r/repos","events_url":"https://api.github.com/users/naude-r/events{/privacy}","received_events_url":"https://api.github.com/users/naude-r/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nFound a bug in that netty would generate a 20 byte body when returing a response\r\nto an HTTP HEAD. the 20 bytes seems to be related to the compression footer.\r\n\r\nRFC2616, section 9.4 states that responses to an HTTP HEAD MUST not return a message\r\nbody in the response.\r\n\r\nNetty's own client implementation expected an empty response. The extra bytes lead to a\r\n2nd response with an error decoder result:\r\njava.lang.IllegalArgumentException: invalid version format: 14\r\n\r\nModifications:\r\n\r\nTrack the HTTP request method. When processing the response we determine if the response\r\nis passthru unnchanged. This decision now takes into account the request method and passthru\r\nresponses related to HTTP HEAD requests.\r\n\r\nResult:\r\n\r\nNetty's http client works and better RFC conformance.","created_at":"2015-05-07T07:07:19Z","updated_at":"2015-05-25T08:14:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79a6d5dfb649c9172ccb1c0a71fcb2e9d0d4a695","assignee":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/116","html_url":"https://github.com/netty/netty/milestones/4.0.29.Final","labels_url":"https://api.github.com/repos/netty/netty/milestones/116/labels","id":1091077,"number":116,"title":"4.0.29.Final","description":"","creator":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":65,"closed_issues":17,"state":"open","created_at":"2015-04-30T13:26:30Z","updated_at":"2015-05-25T08:11:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/netty/netty/pulls/3753/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/3753/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/3753/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/4cefa3c9673b662738bbf3fa30f068a9686184e4","head":{"label":"naude-r:netty3715","ref":"netty3715","sha":"4cefa3c9673b662738bbf3fa30f068a9686184e4","user":{"login":"naude-r","id":1931708,"avatar_url":"https://avatars.githubusercontent.com/u/1931708?v=3","gravatar_id":"","url":"https://api.github.com/users/naude-r","html_url":"https://github.com/naude-r","followers_url":"https://api.github.com/users/naude-r/followers","following_url":"https://api.github.com/users/naude-r/following{/other_user}","gists_url":"https://api.github.com/users/naude-r/gists{/gist_id}","starred_url":"https://api.github.com/users/naude-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naude-r/subscriptions","organizations_url":"https://api.github.com/users/naude-r/orgs","repos_url":"https://api.github.com/users/naude-r/repos","events_url":"https://api.github.com/users/naude-r/events{/privacy}","received_events_url":"https://api.github.com/users/naude-r/received_events","type":"User","site_admin":false},"repo":{"id":35203114,"name":"netty","full_name":"naude-r/netty","owner":{"login":"naude-r","id":1931708,"avatar_url":"https://avatars.githubusercontent.com/u/1931708?v=3","gravatar_id":"","url":"https://api.github.com/users/naude-r","html_url":"https://github.com/naude-r","followers_url":"https://api.github.com/users/naude-r/followers","following_url":"https://api.github.com/users/naude-r/following{/other_user}","gists_url":"https://api.github.com/users/naude-r/gists{/gist_id}","starred_url":"https://api.github.com/users/naude-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naude-r/subscriptions","organizations_url":"https://api.github.com/users/naude-r/orgs","repos_url":"https://api.github.com/users/naude-r/repos","events_url":"https://api.github.com/users/naude-r/events{/privacy}","received_events_url":"https://api.github.com/users/naude-r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/naude-r/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/naude-r/netty","forks_url":"https://api.github.com/repos/naude-r/netty/forks","keys_url":"https://api.github.com/repos/naude-r/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naude-r/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naude-r/netty/teams","hooks_url":"https://api.github.com/repos/naude-r/netty/hooks","issue_events_url":"https://api.github.com/repos/naude-r/netty/issues/events{/number}","events_url":"https://api.github.com/repos/naude-r/netty/events","assignees_url":"https://api.github.com/repos/naude-r/netty/assignees{/user}","branches_url":"https://api.github.com/repos/naude-r/netty/branches{/branch}","tags_url":"https://api.github.com/repos/naude-r/netty/tags","blobs_url":"https://api.github.com/repos/naude-r/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naude-r/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naude-r/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/naude-r/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naude-r/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/naude-r/netty/languages","stargazers_url":"https://api.github.com/repos/naude-r/netty/stargazers","contributors_url":"https://api.github.com/repos/naude-r/netty/contributors","subscribers_url":"https://api.github.com/repos/naude-r/netty/subscribers","subscription_url":"https://api.github.com/repos/naude-r/netty/subscription","commits_url":"https://api.github.com/repos/naude-r/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/naude-r/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/naude-r/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/naude-r/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/naude-r/netty/contents/{+path}","compare_url":"https://api.github.com/repos/naude-r/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naude-r/netty/merges","archive_url":"https://api.github.com/repos/naude-r/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naude-r/netty/downloads","issues_url":"https://api.github.com/repos/naude-r/netty/issues{/number}","pulls_url":"https://api.github.com/repos/naude-r/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/naude-r/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/naude-r/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naude-r/netty/labels{/name}","releases_url":"https://api.github.com/repos/naude-r/netty/releases{/id}","created_at":"2015-05-07T06:37:28Z","updated_at":"2015-05-07T06:37:35Z","pushed_at":"2015-05-22T11:57:21Z","git_url":"git://github.com/naude-r/netty.git","ssh_url":"git@github.com:naude-r/netty.git","clone_url":"https://github.com/naude-r/netty.git","svn_url":"https://github.com/naude-r/netty","homepage":"http://netty.io/","size":42230,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:master","ref":"master","sha":"210baee6bb13fdc7eb0e9f0b0cc1be72104dd1bb","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2015-05-25T06:34:15Z","pushed_at":"2015-05-22T20:24:24Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":129711,"stargazers_count":4664,"watchers_count":4664,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2294,"mirror_url":null,"open_issues_count":277,"forks":2294,"open_issues":277,"watchers":4664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/3753"},"html":{"href":"https://github.com/netty/netty/pull/3753"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/3753"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/3753/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/3753/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/3753/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/4cefa3c9673b662738bbf3fa30f068a9686184e4"}}}}