{"action":"created","comment":{"url":"https://api.github.com/repos/astroufsc/chimera/pulls/comments/29614697","id":29614697,"diff_hunk":"@@ -34,181 +33,214 @@\n from chimera.core.exceptions import ChimeraException\n from chimera.core.constants import SYSTEM_CONFIG_DIRECTORY\n \n-from chimera.util.enum import Enum\n+from chimera.util.tpl2 import TPL2, SocketError\n \n-from chimera.util.tpl2 import TPL2,SocketError\n \n class AstelcoException(ChimeraException):\n-\tpass\n+    pass\n+\n \n class AstelcoDomeException(ChimeraException):\n-\tpass\n+    pass\n+\n \n-class AstelcoDome (DomeBase):\n+class AstelcoDome(DomeBase):\n+    '''\n+    AstelcoDome interfaces chimera with TSI system to control dome.\n     '''\n-AstelcoDome interfaces chimera with TSI system to control dome. \n-'''\n \n-    __config__ = {\t'user'\t\t\t: 'admin',\n-\t\t\t\t\t'password'\t\t: 'admin',\n-\t\t\t\t\t'ahost'\t\t\t: 'localhost',\n-                    'aport'\t\t\t: \"65432\" }\n+    __config__ = {'user': 'admin',\n+                  'password': 'admin',\n+                  'ahost': 'localhost',\n+                  'aport': \"65432\"}\n+                  \"maxidletime\": 90.,\n+                  \"stabilization_time\": 5.}","path":"src/chimera/instruments/astelcodome.py","position":44,"original_position":44,"commit_id":"3c4692b878fadaa159dc1738d8a6d1c366b87b49","original_commit_id":"3c4692b878fadaa159dc1738d8a6d1c366b87b49","user":{"login":"wschoenell","id":1873811,"avatar_url":"https://avatars.githubusercontent.com/u/1873811?v=3","gravatar_id":"","url":"https://api.github.com/users/wschoenell","html_url":"https://github.com/wschoenell","followers_url":"https://api.github.com/users/wschoenell/followers","following_url":"https://api.github.com/users/wschoenell/following{/other_user}","gists_url":"https://api.github.com/users/wschoenell/gists{/gist_id}","starred_url":"https://api.github.com/users/wschoenell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wschoenell/subscriptions","organizations_url":"https://api.github.com/users/wschoenell/orgs","repos_url":"https://api.github.com/users/wschoenell/repos","events_url":"https://api.github.com/users/wschoenell/events{/privacy}","received_events_url":"https://api.github.com/users/wschoenell/received_events","type":"User","site_admin":false},"body":"This config statement is wrong. You finish the dict, but put 2 lines more.","created_at":"2015-05-04T19:27:52Z","updated_at":"2015-05-04T19:27:52Z","html_url":"https://github.com/astroufsc/chimera/pull/52#discussion_r29614697","pull_request_url":"https://api.github.com/repos/astroufsc/chimera/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/astroufsc/chimera/pulls/comments/29614697"},"html":{"href":"https://github.com/astroufsc/chimera/pull/52#discussion_r29614697"},"pull_request":{"href":"https://api.github.com/repos/astroufsc/chimera/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/astroufsc/chimera/pulls/52","id":34662328,"html_url":"https://github.com/astroufsc/chimera/pull/52","diff_url":"https://github.com/astroufsc/chimera/pull/52.diff","patch_url":"https://github.com/astroufsc/chimera/pull/52.patch","issue_url":"https://api.github.com/repos/astroufsc/chimera/issues/52","number":52,"state":"open","locked":false,"title":"Minor improvements on AstelcoDome. ","user":{"login":"tribeiro","id":2581045,"avatar_url":"https://avatars.githubusercontent.com/u/2581045?v=3","gravatar_id":"","url":"https://api.github.com/users/tribeiro","html_url":"https://github.com/tribeiro","followers_url":"https://api.github.com/users/tribeiro/followers","following_url":"https://api.github.com/users/tribeiro/following{/other_user}","gists_url":"https://api.github.com/users/tribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/tribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribeiro/subscriptions","organizations_url":"https://api.github.com/users/tribeiro/orgs","repos_url":"https://api.github.com/users/tribeiro/repos","events_url":"https://api.github.com/users/tribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/tribeiro/received_events","type":"User","site_admin":false},"body":"Add move to azimuth, to move the dome when in stand mode. It also fixes indentation to comply with PEP8.","created_at":"2015-05-04T18:39:47Z","updated_at":"2015-05-04T19:27:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d234ade3e88984be6e326e2cb9bc9fd7beadd1e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/astroufsc/chimera/pulls/52/commits","review_comments_url":"https://api.github.com/repos/astroufsc/chimera/pulls/52/comments","review_comment_url":"https://api.github.com/repos/astroufsc/chimera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astroufsc/chimera/issues/52/comments","statuses_url":"https://api.github.com/repos/astroufsc/chimera/statuses/3c4692b878fadaa159dc1738d8a6d1c366b87b49","head":{"label":"tribeiro:AstelcoDomeRev","ref":"AstelcoDomeRev","sha":"3c4692b878fadaa159dc1738d8a6d1c366b87b49","user":{"login":"tribeiro","id":2581045,"avatar_url":"https://avatars.githubusercontent.com/u/2581045?v=3","gravatar_id":"","url":"https://api.github.com/users/tribeiro","html_url":"https://github.com/tribeiro","followers_url":"https://api.github.com/users/tribeiro/followers","following_url":"https://api.github.com/users/tribeiro/following{/other_user}","gists_url":"https://api.github.com/users/tribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/tribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribeiro/subscriptions","organizations_url":"https://api.github.com/users/tribeiro/orgs","repos_url":"https://api.github.com/users/tribeiro/repos","events_url":"https://api.github.com/users/tribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/tribeiro/received_events","type":"User","site_admin":false},"repo":{"id":19621619,"name":"chimera","full_name":"tribeiro/chimera","owner":{"login":"tribeiro","id":2581045,"avatar_url":"https://avatars.githubusercontent.com/u/2581045?v=3","gravatar_id":"","url":"https://api.github.com/users/tribeiro","html_url":"https://github.com/tribeiro","followers_url":"https://api.github.com/users/tribeiro/followers","following_url":"https://api.github.com/users/tribeiro/following{/other_user}","gists_url":"https://api.github.com/users/tribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/tribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribeiro/subscriptions","organizations_url":"https://api.github.com/users/tribeiro/orgs","repos_url":"https://api.github.com/users/tribeiro/repos","events_url":"https://api.github.com/users/tribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/tribeiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tribeiro/chimera","description":"Chimera - Observatory Automation System","fork":true,"url":"https://api.github.com/repos/tribeiro/chimera","forks_url":"https://api.github.com/repos/tribeiro/chimera/forks","keys_url":"https://api.github.com/repos/tribeiro/chimera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tribeiro/chimera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tribeiro/chimera/teams","hooks_url":"https://api.github.com/repos/tribeiro/chimera/hooks","issue_events_url":"https://api.github.com/repos/tribeiro/chimera/issues/events{/number}","events_url":"https://api.github.com/repos/tribeiro/chimera/events","assignees_url":"https://api.github.com/repos/tribeiro/chimera/assignees{/user}","branches_url":"https://api.github.com/repos/tribeiro/chimera/branches{/branch}","tags_url":"https://api.github.com/repos/tribeiro/chimera/tags","blobs_url":"https://api.github.com/repos/tribeiro/chimera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tribeiro/chimera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tribeiro/chimera/git/refs{/sha}","trees_url":"https://api.github.com/repos/tribeiro/chimera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tribeiro/chimera/statuses/{sha}","languages_url":"https://api.github.com/repos/tribeiro/chimera/languages","stargazers_url":"https://api.github.com/repos/tribeiro/chimera/stargazers","contributors_url":"https://api.github.com/repos/tribeiro/chimera/contributors","subscribers_url":"https://api.github.com/repos/tribeiro/chimera/subscribers","subscription_url":"https://api.github.com/repos/tribeiro/chimera/subscription","commits_url":"https://api.github.com/repos/tribeiro/chimera/commits{/sha}","git_commits_url":"https://api.github.com/repos/tribeiro/chimera/git/commits{/sha}","comments_url":"https://api.github.com/repos/tribeiro/chimera/comments{/number}","issue_comment_url":"https://api.github.com/repos/tribeiro/chimera/issues/comments{/number}","contents_url":"https://api.github.com/repos/tribeiro/chimera/contents/{+path}","compare_url":"https://api.github.com/repos/tribeiro/chimera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tribeiro/chimera/merges","archive_url":"https://api.github.com/repos/tribeiro/chimera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tribeiro/chimera/downloads","issues_url":"https://api.github.com/repos/tribeiro/chimera/issues{/number}","pulls_url":"https://api.github.com/repos/tribeiro/chimera/pulls{/number}","milestones_url":"https://api.github.com/repos/tribeiro/chimera/milestones{/number}","notifications_url":"https://api.github.com/repos/tribeiro/chimera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tribeiro/chimera/labels{/name}","releases_url":"https://api.github.com/repos/tribeiro/chimera/releases{/id}","created_at":"2014-05-09T18:43:31Z","updated_at":"2015-03-27T16:29:34Z","pushed_at":"2015-05-04T19:22:52Z","git_url":"git://github.com/tribeiro/chimera.git","ssh_url":"git@github.com:tribeiro/chimera.git","clone_url":"https://github.com/tribeiro/chimera.git","svn_url":"https://github.com/tribeiro/chimera","homepage":"http://chimera.sf.net/","size":38936,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astroufsc:master","ref":"master","sha":"df3f42458146a63af4809a9d971e3521e725bc1a","user":{"login":"astroufsc","id":1902304,"avatar_url":"https://avatars.githubusercontent.com/u/1902304?v=3","gravatar_id":"","url":"https://api.github.com/users/astroufsc","html_url":"https://github.com/astroufsc","followers_url":"https://api.github.com/users/astroufsc/followers","following_url":"https://api.github.com/users/astroufsc/following{/other_user}","gists_url":"https://api.github.com/users/astroufsc/gists{/gist_id}","starred_url":"https://api.github.com/users/astroufsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroufsc/subscriptions","organizations_url":"https://api.github.com/users/astroufsc/orgs","repos_url":"https://api.github.com/users/astroufsc/repos","events_url":"https://api.github.com/users/astroufsc/events{/privacy}","received_events_url":"https://api.github.com/users/astroufsc/received_events","type":"Organization","site_admin":false},"repo":{"id":4820416,"name":"chimera","full_name":"astroufsc/chimera","owner":{"login":"astroufsc","id":1902304,"avatar_url":"https://avatars.githubusercontent.com/u/1902304?v=3","gravatar_id":"","url":"https://api.github.com/users/astroufsc","html_url":"https://github.com/astroufsc","followers_url":"https://api.github.com/users/astroufsc/followers","following_url":"https://api.github.com/users/astroufsc/following{/other_user}","gists_url":"https://api.github.com/users/astroufsc/gists{/gist_id}","starred_url":"https://api.github.com/users/astroufsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroufsc/subscriptions","organizations_url":"https://api.github.com/users/astroufsc/orgs","repos_url":"https://api.github.com/users/astroufsc/repos","events_url":"https://api.github.com/users/astroufsc/events{/privacy}","received_events_url":"https://api.github.com/users/astroufsc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astroufsc/chimera","description":"Chimera - Observatory Automation System","fork":false,"url":"https://api.github.com/repos/astroufsc/chimera","forks_url":"https://api.github.com/repos/astroufsc/chimera/forks","keys_url":"https://api.github.com/repos/astroufsc/chimera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astroufsc/chimera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astroufsc/chimera/teams","hooks_url":"https://api.github.com/repos/astroufsc/chimera/hooks","issue_events_url":"https://api.github.com/repos/astroufsc/chimera/issues/events{/number}","events_url":"https://api.github.com/repos/astroufsc/chimera/events","assignees_url":"https://api.github.com/repos/astroufsc/chimera/assignees{/user}","branches_url":"https://api.github.com/repos/astroufsc/chimera/branches{/branch}","tags_url":"https://api.github.com/repos/astroufsc/chimera/tags","blobs_url":"https://api.github.com/repos/astroufsc/chimera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astroufsc/chimera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astroufsc/chimera/git/refs{/sha}","trees_url":"https://api.github.com/repos/astroufsc/chimera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astroufsc/chimera/statuses/{sha}","languages_url":"https://api.github.com/repos/astroufsc/chimera/languages","stargazers_url":"https://api.github.com/repos/astroufsc/chimera/stargazers","contributors_url":"https://api.github.com/repos/astroufsc/chimera/contributors","subscribers_url":"https://api.github.com/repos/astroufsc/chimera/subscribers","subscription_url":"https://api.github.com/repos/astroufsc/chimera/subscription","commits_url":"https://api.github.com/repos/astroufsc/chimera/commits{/sha}","git_commits_url":"https://api.github.com/repos/astroufsc/chimera/git/commits{/sha}","comments_url":"https://api.github.com/repos/astroufsc/chimera/comments{/number}","issue_comment_url":"https://api.github.com/repos/astroufsc/chimera/issues/comments{/number}","contents_url":"https://api.github.com/repos/astroufsc/chimera/contents/{+path}","compare_url":"https://api.github.com/repos/astroufsc/chimera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astroufsc/chimera/merges","archive_url":"https://api.github.com/repos/astroufsc/chimera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astroufsc/chimera/downloads","issues_url":"https://api.github.com/repos/astroufsc/chimera/issues{/number}","pulls_url":"https://api.github.com/repos/astroufsc/chimera/pulls{/number}","milestones_url":"https://api.github.com/repos/astroufsc/chimera/milestones{/number}","notifications_url":"https://api.github.com/repos/astroufsc/chimera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astroufsc/chimera/labels{/name}","releases_url":"https://api.github.com/repos/astroufsc/chimera/releases{/id}","created_at":"2012-06-28T12:42:15Z","updated_at":"2015-05-04T18:52:31Z","pushed_at":"2015-05-04T18:52:30Z","git_url":"git://github.com/astroufsc/chimera.git","ssh_url":"git@github.com:astroufsc/chimera.git","clone_url":"https://github.com/astroufsc/chimera.git","svn_url":"https://github.com/astroufsc/chimera","homepage":"http://chimera.sf.net/","size":59739,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":16,"forks":12,"open_issues":16,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astroufsc/chimera/pulls/52"},"html":{"href":"https://github.com/astroufsc/chimera/pull/52"},"issue":{"href":"https://api.github.com/repos/astroufsc/chimera/issues/52"},"comments":{"href":"https://api.github.com/repos/astroufsc/chimera/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/astroufsc/chimera/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/astroufsc/chimera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astroufsc/chimera/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/astroufsc/chimera/statuses/3c4692b878fadaa159dc1738d8a6d1c366b87b49"}}}}