{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/48365922","id":48365922,"diff_hunk":"@@ -1904,6 +1904,14 @@ def self.reconfigurable?(ids)\n     vms.all?(&:reconfigurable?)\n   end\n \n+  def self.tenant_id_clause(user_or_group)\n+    template_tenant_ids = MiqTemplate.accessible_tenant_ids(user_or_group, Rbac::TENANT_ACCESS_STRATEGY[\"MiqTemplate\"])\n+    vm_tenant_ids       = Vm.accessible_tenant_ids(user_or_group, Rbac::TENANT_ACCESS_STRATEGY[\"Vm\"])","path":"app/models/vm_or_template.rb","position":null,"original_position":6,"commit_id":"f563a43713e1177bb0f83e043d6515ea722edd2d","original_commit_id":"7c4bc4789604fa3c7dd3ee2b4a41ce946598ca3a","user":{"login":"gtanzillo","id":76593,"avatar_url":"https://avatars.githubusercontent.com/u/76593?v=3","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false},"body":"Thanks @Fryguy Just made that change.","created_at":"2015-12-23T17:54:25Z","updated_at":"2015-12-23T17:54:25Z","html_url":"https://github.com/ManageIQ/manageiq/pull/5898#discussion_r48365922","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5898","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/48365922"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5898#discussion_r48365922"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5898"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5898","id":54043391,"html_url":"https://github.com/ManageIQ/manageiq/pull/5898","diff_url":"https://github.com/ManageIQ/manageiq/pull/5898.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5898.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5898","number":5898,"state":"open","locked":false,"title":"Tenancy scoping for vms and templates","user":{"login":"gtanzillo","id":76593,"avatar_url":"https://avatars.githubusercontent.com/u/76593?v=3","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false},"body":"- Added logic to handle different scoping rules for vm and templates where both classes derive from the same base model, VmOrTemplate, and share the same table, vms.\r\n- Templates owned by the current tenant and all parent tenants (ancestors) should be accessible current tenant.\r\n- Vms owned by the current tenant and all child tenants (descendants) should be accessible from the current tenant.\r\n- There are places in the app that require RBAC searching on both classes at the same time, making this change necessary.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1292285","created_at":"2015-12-17T22:53:54Z","updated_at":"2015-12-23T17:54:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ad11b638859ae67b6633469984682522757879a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5898/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5898/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5898/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f563a43713e1177bb0f83e043d6515ea722edd2d","head":{"label":"gtanzillo:bz-1292285-tenant-accessibility","ref":"bz-1292285-tenant-accessibility","sha":"f563a43713e1177bb0f83e043d6515ea722edd2d","user":{"login":"gtanzillo","id":76593,"avatar_url":"https://avatars.githubusercontent.com/u/76593?v=3","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false},"repo":{"id":37150197,"name":"manageiq","full_name":"gtanzillo/manageiq","owner":{"login":"gtanzillo","id":76593,"avatar_url":"https://avatars.githubusercontent.com/u/76593?v=3","gravatar_id":"","url":"https://api.github.com/users/gtanzillo","html_url":"https://github.com/gtanzillo","followers_url":"https://api.github.com/users/gtanzillo/followers","following_url":"https://api.github.com/users/gtanzillo/following{/other_user}","gists_url":"https://api.github.com/users/gtanzillo/gists{/gist_id}","starred_url":"https://api.github.com/users/gtanzillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtanzillo/subscriptions","organizations_url":"https://api.github.com/users/gtanzillo/orgs","repos_url":"https://api.github.com/users/gtanzillo/repos","events_url":"https://api.github.com/users/gtanzillo/events{/privacy}","received_events_url":"https://api.github.com/users/gtanzillo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gtanzillo/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/gtanzillo/manageiq","forks_url":"https://api.github.com/repos/gtanzillo/manageiq/forks","keys_url":"https://api.github.com/repos/gtanzillo/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtanzillo/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtanzillo/manageiq/teams","hooks_url":"https://api.github.com/repos/gtanzillo/manageiq/hooks","issue_events_url":"https://api.github.com/repos/gtanzillo/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/gtanzillo/manageiq/events","assignees_url":"https://api.github.com/repos/gtanzillo/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/gtanzillo/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/gtanzillo/manageiq/tags","blobs_url":"https://api.github.com/repos/gtanzillo/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtanzillo/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtanzillo/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtanzillo/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtanzillo/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/gtanzillo/manageiq/languages","stargazers_url":"https://api.github.com/repos/gtanzillo/manageiq/stargazers","contributors_url":"https://api.github.com/repos/gtanzillo/manageiq/contributors","subscribers_url":"https://api.github.com/repos/gtanzillo/manageiq/subscribers","subscription_url":"https://api.github.com/repos/gtanzillo/manageiq/subscription","commits_url":"https://api.github.com/repos/gtanzillo/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtanzillo/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtanzillo/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtanzillo/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtanzillo/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/gtanzillo/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtanzillo/manageiq/merges","archive_url":"https://api.github.com/repos/gtanzillo/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtanzillo/manageiq/downloads","issues_url":"https://api.github.com/repos/gtanzillo/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/gtanzillo/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/gtanzillo/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/gtanzillo/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtanzillo/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/gtanzillo/manageiq/releases{/id}","created_at":"2015-06-09T18:24:07Z","updated_at":"2015-06-09T18:24:25Z","pushed_at":"2015-12-23T17:54:01Z","git_url":"git://github.com/gtanzillo/manageiq.git","ssh_url":"git@github.com:gtanzillo/manageiq.git","clone_url":"https://github.com/gtanzillo/manageiq.git","svn_url":"https://github.com/gtanzillo/manageiq","homepage":"manageiq.org","size":99560,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"1926d13c835b85cc1f98e572539bf1c447a627f0","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-12-22T13:43:45Z","pushed_at":"2015-12-23T17:54:02Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":134090,"stargazers_count":183,"watchers_count":183,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":197,"mirror_url":null,"open_issues_count":478,"forks":197,"open_issues":478,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5898"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5898"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5898"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5898/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5898/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5898/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/f563a43713e1177bb0f83e043d6515ea722edd2d"}}}}