{"action":"created","issue":{"url":"https://api.github.com/repos/inliniac/suricata/issues/1437","labels_url":"https://api.github.com/repos/inliniac/suricata/issues/1437/labels{/name}","comments_url":"https://api.github.com/repos/inliniac/suricata/issues/1437/comments","events_url":"https://api.github.com/repos/inliniac/suricata/issues/1437/events","html_url":"https://github.com/inliniac/suricata/pull/1437","id":69164500,"number":1437,"title":"Bug #1441: add timezone to timestamp in JSON logs","user":{"login":"gozzy","id":465526,"avatar_url":"https://avatars.githubusercontent.com/u/465526?v=3","gravatar_id":"","url":"https://api.github.com/users/gozzy","html_url":"https://github.com/gozzy","followers_url":"https://api.github.com/users/gozzy/followers","following_url":"https://api.github.com/users/gozzy/following{/other_user}","gists_url":"https://api.github.com/users/gozzy/gists{/gist_id}","starred_url":"https://api.github.com/users/gozzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gozzy/subscriptions","organizations_url":"https://api.github.com/users/gozzy/orgs","repos_url":"https://api.github.com/users/gozzy/repos","events_url":"https://api.github.com/users/gozzy/events{/privacy}","received_events_url":"https://api.github.com/users/gozzy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-17T15:47:28Z","updated_at":"2015-04-17T16:47:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/1437","html_url":"https://github.com/inliniac/suricata/pull/1437","diff_url":"https://github.com/inliniac/suricata/pull/1437.diff","patch_url":"https://github.com/inliniac/suricata/pull/1437.patch"},"body":"Fixed #1436 - now should work properly on FreeBSD too."},"comment":{"url":"https://api.github.com/repos/inliniac/suricata/issues/comments/94025104","html_url":"https://github.com/inliniac/suricata/pull/1437#issuecomment-94025104","issue_url":"https://api.github.com/repos/inliniac/suricata/issues/1437","id":94025104,"user":{"login":"gozzy","id":465526,"avatar_url":"https://avatars.githubusercontent.com/u/465526?v=3","gravatar_id":"","url":"https://api.github.com/users/gozzy","html_url":"https://github.com/gozzy","followers_url":"https://api.github.com/users/gozzy/followers","following_url":"https://api.github.com/users/gozzy/following{/other_user}","gists_url":"https://api.github.com/users/gozzy/gists{/gist_id}","starred_url":"https://api.github.com/users/gozzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gozzy/subscriptions","organizations_url":"https://api.github.com/users/gozzy/orgs","repos_url":"https://api.github.com/users/gozzy/repos","events_url":"https://api.github.com/users/gozzy/events{/privacy}","received_events_url":"https://api.github.com/users/gozzy/received_events","type":"User","site_admin":false},"created_at":"2015-04-17T16:47:48Z","updated_at":"2015-04-17T16:47:48Z","body":"@Maxtors, it seemed to me that this format conforms to ISO-8601. It's possible to make timestamp format configurable, but is there any reason for that? Databases support this format without any problems, and most of log servers/collectors should do the same (especially if they support RFC-5424 - 'new' syslog protocol).\r\n\r\n@alessandro-guido changing timezone while suricata is running will cause a mess :) Actually, this code can be moved to CreateIsoTimeString(), but in this case it'll be better to support tm_gmtoff. And if it's not found, use 'legacy' style like proposed one (via ifdefs). In this case it also may be useful to have this feature togglable."}}