{"action":"created","issue":{"url":"https://api.github.com/repos/nathanhammond/libphonenumber/issues/7","labels_url":"https://api.github.com/repos/nathanhammond/libphonenumber/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/nathanhammond/libphonenumber/issues/7/comments","events_url":"https://api.github.com/repos/nathanhammond/libphonenumber/issues/7/events","html_url":"https://github.com/nathanhammond/libphonenumber/pull/7","id":107706685,"number":7,"title":"added executable containing country data for Italy only","user":{"login":"marco-faustinelli","id":8156006,"avatar_url":"https://avatars.githubusercontent.com/u/8156006?v=3","gravatar_id":"","url":"https://api.github.com/users/marco-faustinelli","html_url":"https://github.com/marco-faustinelli","followers_url":"https://api.github.com/users/marco-faustinelli/followers","following_url":"https://api.github.com/users/marco-faustinelli/following{/other_user}","gists_url":"https://api.github.com/users/marco-faustinelli/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-faustinelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-faustinelli/subscriptions","organizations_url":"https://api.github.com/users/marco-faustinelli/orgs","repos_url":"https://api.github.com/users/marco-faustinelli/repos","events_url":"https://api.github.com/users/marco-faustinelli/events{/privacy}","received_events_url":"https://api.github.com/users/marco-faustinelli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-09-22T12:41:40Z","updated_at":"2015-10-14T10:34:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nathanhammond/libphonenumber/pulls/7","html_url":"https://github.com/nathanhammond/libphonenumber/pull/7","diff_url":"https://github.com/nathanhammond/libphonenumber/pull/7.diff","patch_url":"https://github.com/nathanhammond/libphonenumber/pull/7.patch"},"body":"This file contains @row 591 the sole country data for Italy. It is intentionally un-minified to allow visual inspection.\r\n\r\nThe size of its minified version is 19k, compared to 208k for the official minified dist version.\r\n\r\nThe file works correctly in processing Italian phone numbers (NB - I have used so far only the methods formatNational and isValidNumberForRegion). It is likely that it will crash in case of invocations related to absent countries.\r\n\r\nThe advantages in using such a smaller localized file inside a webpage are huge.\r\n\r\nI am obviously NOT proposing to put this file in your repo :-)\r\n\r\nThe real issue is now: given that this spike works, how to go about producing versions of national data for the various countries and how to get them included in the final localized executables?\r\n\r\nWilling to discuss alternatives here. I have also opened an issue in the i18n/libphonenumber repo to hear from the authors. See https://github.com/googlei18n/libphonenumber/issues/829"},"comment":{"url":"https://api.github.com/repos/nathanhammond/libphonenumber/issues/comments/148007985","html_url":"https://github.com/nathanhammond/libphonenumber/pull/7#issuecomment-148007985","issue_url":"https://api.github.com/repos/nathanhammond/libphonenumber/issues/7","id":148007985,"user":{"login":"marco-faustinelli","id":8156006,"avatar_url":"https://avatars.githubusercontent.com/u/8156006?v=3","gravatar_id":"","url":"https://api.github.com/users/marco-faustinelli","html_url":"https://github.com/marco-faustinelli","followers_url":"https://api.github.com/users/marco-faustinelli/followers","following_url":"https://api.github.com/users/marco-faustinelli/following{/other_user}","gists_url":"https://api.github.com/users/marco-faustinelli/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-faustinelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-faustinelli/subscriptions","organizations_url":"https://api.github.com/users/marco-faustinelli/orgs","repos_url":"https://api.github.com/users/marco-faustinelli/repos","events_url":"https://api.github.com/users/marco-faustinelli/events{/privacy}","received_events_url":"https://api.github.com/users/marco-faustinelli/received_events","type":"User","site_admin":false},"created_at":"2015-10-14T10:34:18Z","updated_at":"2015-10-14T10:34:18Z","body":"Let me know if you need clarifications or assistance in any form."}}