{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/28386968","id":28386968,"diff_hunk":"@@ -114,6 +118,9 @@ func (args NodeArgs) BuildSerializeableNodeConfig() (*configapi.NodeConfig, erro\n \t\tDNSIP:     dnsIP,\n \n \t\tMasterKubeConfig: admin.DefaultNodeKubeConfigFile(args.CertArgs.CertDir, args.NodeName),\n+\n+\t\tPodManifestPath:    args.PodManifestPath,\n+\t\tFileCheckFrequency: args.FileCheckFrequency,","path":"pkg/cmd/server/start/node_args.go","position":24,"original_position":24,"commit_id":"0f726da750abb2281b892803811150fde678e22d","original_commit_id":"0f726da750abb2281b892803811150fde678e22d","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"default to `\"\"` and `0`?","created_at":"2015-04-15T01:20:45Z","updated_at":"2015-04-15T01:20:45Z","html_url":"https://github.com/openshift/origin/pull/1741#discussion_r28386968","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/1741","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/28386968"},"html":{"href":"https://github.com/openshift/origin/pull/1741#discussion_r28386968"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/1741"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/1741","id":33306279,"html_url":"https://github.com/openshift/origin/pull/1741","diff_url":"https://github.com/openshift/origin/pull/1741.diff","patch_url":"https://github.com/openshift/origin/pull/1741.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/1741","number":1741,"state":"open","locked":false,"title":"Exposing the pod manifest file/dir option for the node in Origin","user":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=3","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"body":"@deads2k PTAL","created_at":"2015-04-14T22:26:00Z","updated_at":"2015-04-15T01:20:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a21db565cfd3ae38f55dd263e83e135826da52f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/1741/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/1741/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/1741/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/0f726da750abb2281b892803811150fde678e22d","head":{"label":"abhgupta:abhgupta-dev","ref":"abhgupta-dev","sha":"0f726da750abb2281b892803811150fde678e22d","user":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=3","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"repo":{"id":23977841,"name":"origin","full_name":"abhgupta/origin","owner":{"login":"abhgupta","id":1211613,"avatar_url":"https://avatars.githubusercontent.com/u/1211613?v=3","gravatar_id":"","url":"https://api.github.com/users/abhgupta","html_url":"https://github.com/abhgupta","followers_url":"https://api.github.com/users/abhgupta/followers","following_url":"https://api.github.com/users/abhgupta/following{/other_user}","gists_url":"https://api.github.com/users/abhgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/abhgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhgupta/subscriptions","organizations_url":"https://api.github.com/users/abhgupta/orgs","repos_url":"https://api.github.com/users/abhgupta/repos","events_url":"https://api.github.com/users/abhgupta/events{/privacy}","received_events_url":"https://api.github.com/users/abhgupta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhgupta/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/abhgupta/origin","forks_url":"https://api.github.com/repos/abhgupta/origin/forks","keys_url":"https://api.github.com/repos/abhgupta/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhgupta/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhgupta/origin/teams","hooks_url":"https://api.github.com/repos/abhgupta/origin/hooks","issue_events_url":"https://api.github.com/repos/abhgupta/origin/issues/events{/number}","events_url":"https://api.github.com/repos/abhgupta/origin/events","assignees_url":"https://api.github.com/repos/abhgupta/origin/assignees{/user}","branches_url":"https://api.github.com/repos/abhgupta/origin/branches{/branch}","tags_url":"https://api.github.com/repos/abhgupta/origin/tags","blobs_url":"https://api.github.com/repos/abhgupta/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhgupta/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhgupta/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhgupta/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhgupta/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/abhgupta/origin/languages","stargazers_url":"https://api.github.com/repos/abhgupta/origin/stargazers","contributors_url":"https://api.github.com/repos/abhgupta/origin/contributors","subscribers_url":"https://api.github.com/repos/abhgupta/origin/subscribers","subscription_url":"https://api.github.com/repos/abhgupta/origin/subscription","commits_url":"https://api.github.com/repos/abhgupta/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhgupta/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhgupta/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhgupta/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhgupta/origin/contents/{+path}","compare_url":"https://api.github.com/repos/abhgupta/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhgupta/origin/merges","archive_url":"https://api.github.com/repos/abhgupta/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhgupta/origin/downloads","issues_url":"https://api.github.com/repos/abhgupta/origin/issues{/number}","pulls_url":"https://api.github.com/repos/abhgupta/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/abhgupta/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/abhgupta/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhgupta/origin/labels{/name}","releases_url":"https://api.github.com/repos/abhgupta/origin/releases{/id}","created_at":"2014-09-12T21:38:33Z","updated_at":"2015-04-14T22:25:21Z","pushed_at":"2015-04-14T22:25:26Z","git_url":"git://github.com/abhgupta/origin.git","ssh_url":"git@github.com:abhgupta/origin.git","clone_url":"https://github.com/abhgupta/origin.git","svn_url":"https://github.com/abhgupta/origin","homepage":"https://openshift.github.io","size":74116,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"c954bdebbbe7263ec90e9365fbb25eb7fc54b21e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-04-14T19:44:11Z","pushed_at":"2015-04-14T23:33:03Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":114760,"stargazers_count":372,"watchers_count":372,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"open_issues_count":181,"forks":183,"open_issues":181,"watchers":372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/1741"},"html":{"href":"https://github.com/openshift/origin/pull/1741"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/1741"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/1741/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/1741/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/1741/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/0f726da750abb2281b892803811150fde678e22d"}}}}