{"action":"created","issue":{"url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/579","labels_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/579/labels{/name}","comments_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/579/comments","events_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/579/events","html_url":"https://github.com/PHPMailer/PHPMailer/pull/579","id":120864991,"number":579,"title":"Resolved Scope issues which resulted in GMail Auth failure","user":{"login":"sherryl4george","id":10671884,"avatar_url":"https://avatars.githubusercontent.com/u/10671884?v=3","gravatar_id":"","url":"https://api.github.com/users/sherryl4george","html_url":"https://github.com/sherryl4george","followers_url":"https://api.github.com/users/sherryl4george/followers","following_url":"https://api.github.com/users/sherryl4george/following{/other_user}","gists_url":"https://api.github.com/users/sherryl4george/gists{/gist_id}","starred_url":"https://api.github.com/users/sherryl4george/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherryl4george/subscriptions","organizations_url":"https://api.github.com/users/sherryl4george/orgs","repos_url":"https://api.github.com/users/sherryl4george/repos","events_url":"https://api.github.com/users/sherryl4george/events{/privacy}","received_events_url":"https://api.github.com/users/sherryl4george/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-12-07T20:52:01Z","updated_at":"2015-12-18T19:52:48Z","closed_at":"2015-12-07T21:10:24Z","pull_request":{"url":"https://api.github.com/repos/PHPMailer/PHPMailer/pulls/579","html_url":"https://github.com/PHPMailer/PHPMailer/pull/579","diff_url":"https://github.com/PHPMailer/PHPMailer/pull/579.diff","patch_url":"https://github.com/PHPMailer/PHPMailer/pull/579.patch"},"body":"This is to solve issue #568 . \r\n\r\nAs changes have been made to the OAuth Library for Google, the scope was set to default all times. This has been overridden now by writing a custom class into the _get_oauth_token.php_ file. Also changes have been made to _composer.json_."},"comment":{"url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/comments/165883603","html_url":"https://github.com/PHPMailer/PHPMailer/pull/579#issuecomment-165883603","issue_url":"https://api.github.com/repos/PHPMailer/PHPMailer/issues/579","id":165883603,"user":{"login":"sherryl4george","id":10671884,"avatar_url":"https://avatars.githubusercontent.com/u/10671884?v=3","gravatar_id":"","url":"https://api.github.com/users/sherryl4george","html_url":"https://github.com/sherryl4george","followers_url":"https://api.github.com/users/sherryl4george/followers","following_url":"https://api.github.com/users/sherryl4george/following{/other_user}","gists_url":"https://api.github.com/users/sherryl4george/gists{/gist_id}","starred_url":"https://api.github.com/users/sherryl4george/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherryl4george/subscriptions","organizations_url":"https://api.github.com/users/sherryl4george/orgs","repos_url":"https://api.github.com/users/sherryl4george/repos","events_url":"https://api.github.com/users/sherryl4george/events{/privacy}","received_events_url":"https://api.github.com/users/sherryl4george/received_events","type":"User","site_admin":false},"created_at":"2015-12-18T19:52:48Z","updated_at":"2015-12-18T19:52:48Z","body":"I was working on this using the branch 5.4. Below are my findings:\r\n1. Inorder to completely eliminate the use of _ClientProviders_ like Google, Yahoo for OAuth from composer, we have to create classes which does the functionality of those classes for us. These can be placed inside a seperate folder in _OAuthProvider_. The phpleauge/oauth-client will still be used as the base.\r\n2. While creating the OAuth instance, how can one distinguish between GMail, Yahoo, Microsoft or anyother.\r\n* There should be a new variable( say a integer for each service ) added to PHPMailerOAuth class which indicate the service provider being used. This has to be set by the user\r\n* Pass the OAuth instance of the service provider itself. It adds the overhead to the end user to create the instance. Not very advisable.\r\n*  According to the SMTP passed, the provider has to be figured out using some logic in the _getOAUTHInstance()_ method of _PHPMailerOAuth_ class. Incase of Microsoft, will we end up having more than one SMTP addresses.\r\n\r\nIn all above cases when a new provider is added, code changes are required into the _PHPMailerOAuth_ class.\r\nPlease share your views & suggest on this, so that we can go ahead."}}