{"action":"created","comment":{"url":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/comments/47783180","id":47783180,"diff_hunk":"@@ -161,33 +161,23 @@\n      *\n      * @description\n      *     Display a modal selection dialog.\n-     * @param {string} title\n-     *     The modal's title.\n-     * @param {string} text\n-     *     The modal's text.\n      * @param {array} options\n      *     The modal's selection options.\n-     * @param {string=} size\n-     *     The modal's size.\n-     * @param {string=Ok} closeTitle\n-     *     The label of the modal's confirm button.\n-     * @param {string=Cancel} dismissTitle\n-     *     The label of the modal's cancel button.\n      */\n-    function select(title, text, options, size, closeTitle, dismissTitle) {\n-      return open({ options: options }, function ($modalInstance, options) {\n+    function select(options) {","path":"source/components/ui/msm-modal/msm-modal.service.js","position":19,"original_position":19,"commit_id":"3509d15942c5364120d666a664d50c2b4014f886","original_commit_id":"3509d15942c5364120d666a664d50c2b4014f886","user":{"login":"fynnfeldpausch","id":1246913,"avatar_url":"https://avatars.githubusercontent.com/u/1246913?v=3","gravatar_id":"","url":"https://api.github.com/users/fynnfeldpausch","html_url":"https://github.com/fynnfeldpausch","followers_url":"https://api.github.com/users/fynnfeldpausch/followers","following_url":"https://api.github.com/users/fynnfeldpausch/following{/other_user}","gists_url":"https://api.github.com/users/fynnfeldpausch/gists{/gist_id}","starred_url":"https://api.github.com/users/fynnfeldpausch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fynnfeldpausch/subscriptions","organizations_url":"https://api.github.com/users/fynnfeldpausch/orgs","repos_url":"https://api.github.com/users/fynnfeldpausch/repos","events_url":"https://api.github.com/users/fynnfeldpausch/events{/privacy}","received_events_url":"https://api.github.com/users/fynnfeldpausch/received_events","type":"User","site_admin":false},"body":"What is the benefit of passing in an options object. It is now unclear which options exist for this API, esp. since the relevant documentation has been deleted... I think this is a degradation. Also. The API style now differs from the rest...","created_at":"2015-12-16T14:44:17Z","updated_at":"2015-12-16T14:44:17Z","html_url":"https://github.com/mindsmash/mindsmash-ui/pull/24#discussion_r47783180","pull_request_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/comments/47783180"},"html":{"href":"https://github.com/mindsmash/mindsmash-ui/pull/24#discussion_r47783180"},"pull_request":{"href":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/24","id":53839976,"html_url":"https://github.com/mindsmash/mindsmash-ui/pull/24","diff_url":"https://github.com/mindsmash/mindsmash-ui/pull/24.diff","patch_url":"https://github.com/mindsmash/mindsmash-ui/pull/24.patch","issue_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/issues/24","number":24,"state":"open","locked":false,"title":"Improved modal resolve","user":{"login":"CallToPower","id":20119,"avatar_url":"https://avatars.githubusercontent.com/u/20119?v=3","gravatar_id":"","url":"https://api.github.com/users/CallToPower","html_url":"https://github.com/CallToPower","followers_url":"https://api.github.com/users/CallToPower/followers","following_url":"https://api.github.com/users/CallToPower/following{/other_user}","gists_url":"https://api.github.com/users/CallToPower/gists{/gist_id}","starred_url":"https://api.github.com/users/CallToPower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CallToPower/subscriptions","organizations_url":"https://api.github.com/users/CallToPower/orgs","repos_url":"https://api.github.com/users/CallToPower/repos","events_url":"https://api.github.com/users/CallToPower/events{/privacy}","received_events_url":"https://api.github.com/users/CallToPower/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-16T13:19:49Z","updated_at":"2015-12-16T14:44:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5e816a2ffc9ecc6de82655a734b1c2f61c5b6ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/24/commits","review_comments_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/24/comments","review_comment_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/issues/24/comments","statuses_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/statuses/3509d15942c5364120d666a664d50c2b4014f886","head":{"label":"mindsmash:Modal-value-handling","ref":"Modal-value-handling","sha":"3509d15942c5364120d666a664d50c2b4014f886","user":{"login":"mindsmash","id":2800079,"avatar_url":"https://avatars.githubusercontent.com/u/2800079?v=3","gravatar_id":"","url":"https://api.github.com/users/mindsmash","html_url":"https://github.com/mindsmash","followers_url":"https://api.github.com/users/mindsmash/followers","following_url":"https://api.github.com/users/mindsmash/following{/other_user}","gists_url":"https://api.github.com/users/mindsmash/gists{/gist_id}","starred_url":"https://api.github.com/users/mindsmash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindsmash/subscriptions","organizations_url":"https://api.github.com/users/mindsmash/orgs","repos_url":"https://api.github.com/users/mindsmash/repos","events_url":"https://api.github.com/users/mindsmash/events{/privacy}","received_events_url":"https://api.github.com/users/mindsmash/received_events","type":"Organization","site_admin":false},"repo":{"id":46278055,"name":"mindsmash-ui","full_name":"mindsmash/mindsmash-ui","owner":{"login":"mindsmash","id":2800079,"avatar_url":"https://avatars.githubusercontent.com/u/2800079?v=3","gravatar_id":"","url":"https://api.github.com/users/mindsmash","html_url":"https://github.com/mindsmash","followers_url":"https://api.github.com/users/mindsmash/followers","following_url":"https://api.github.com/users/mindsmash/following{/other_user}","gists_url":"https://api.github.com/users/mindsmash/gists{/gist_id}","starred_url":"https://api.github.com/users/mindsmash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindsmash/subscriptions","organizations_url":"https://api.github.com/users/mindsmash/orgs","repos_url":"https://api.github.com/users/mindsmash/repos","events_url":"https://api.github.com/users/mindsmash/events{/privacy}","received_events_url":"https://api.github.com/users/mindsmash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mindsmash/mindsmash-ui","description":"UI kit for mindsmash applications.","fork":false,"url":"https://api.github.com/repos/mindsmash/mindsmash-ui","forks_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/forks","keys_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/teams","hooks_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/hooks","issue_events_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/events","assignees_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/tags","blobs_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/languages","stargazers_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/stargazers","contributors_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/contributors","subscribers_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/subscribers","subscription_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/subscription","commits_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/merges","archive_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/downloads","issues_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/labels{/name}","releases_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/releases{/id}","created_at":"2015-11-16T14:01:39Z","updated_at":"2015-11-21T12:50:24Z","pushed_at":"2015-12-16T13:43:30Z","git_url":"git://github.com/mindsmash/mindsmash-ui.git","ssh_url":"git@github.com:mindsmash/mindsmash-ui.git","clone_url":"https://github.com/mindsmash/mindsmash-ui.git","svn_url":"https://github.com/mindsmash/mindsmash-ui","homepage":"http://mindsmash.github.io/mindsmash-ui","size":506,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"mindsmash:master","ref":"master","sha":"060d775f071b672ce100a83960a75bc643414e81","user":{"login":"mindsmash","id":2800079,"avatar_url":"https://avatars.githubusercontent.com/u/2800079?v=3","gravatar_id":"","url":"https://api.github.com/users/mindsmash","html_url":"https://github.com/mindsmash","followers_url":"https://api.github.com/users/mindsmash/followers","following_url":"https://api.github.com/users/mindsmash/following{/other_user}","gists_url":"https://api.github.com/users/mindsmash/gists{/gist_id}","starred_url":"https://api.github.com/users/mindsmash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindsmash/subscriptions","organizations_url":"https://api.github.com/users/mindsmash/orgs","repos_url":"https://api.github.com/users/mindsmash/repos","events_url":"https://api.github.com/users/mindsmash/events{/privacy}","received_events_url":"https://api.github.com/users/mindsmash/received_events","type":"Organization","site_admin":false},"repo":{"id":46278055,"name":"mindsmash-ui","full_name":"mindsmash/mindsmash-ui","owner":{"login":"mindsmash","id":2800079,"avatar_url":"https://avatars.githubusercontent.com/u/2800079?v=3","gravatar_id":"","url":"https://api.github.com/users/mindsmash","html_url":"https://github.com/mindsmash","followers_url":"https://api.github.com/users/mindsmash/followers","following_url":"https://api.github.com/users/mindsmash/following{/other_user}","gists_url":"https://api.github.com/users/mindsmash/gists{/gist_id}","starred_url":"https://api.github.com/users/mindsmash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindsmash/subscriptions","organizations_url":"https://api.github.com/users/mindsmash/orgs","repos_url":"https://api.github.com/users/mindsmash/repos","events_url":"https://api.github.com/users/mindsmash/events{/privacy}","received_events_url":"https://api.github.com/users/mindsmash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mindsmash/mindsmash-ui","description":"UI kit for mindsmash applications.","fork":false,"url":"https://api.github.com/repos/mindsmash/mindsmash-ui","forks_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/forks","keys_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/teams","hooks_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/hooks","issue_events_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/events","assignees_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/tags","blobs_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/languages","stargazers_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/stargazers","contributors_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/contributors","subscribers_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/subscribers","subscription_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/subscription","commits_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/merges","archive_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/downloads","issues_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/labels{/name}","releases_url":"https://api.github.com/repos/mindsmash/mindsmash-ui/releases{/id}","created_at":"2015-11-16T14:01:39Z","updated_at":"2015-11-21T12:50:24Z","pushed_at":"2015-12-16T13:43:30Z","git_url":"git://github.com/mindsmash/mindsmash-ui.git","ssh_url":"git@github.com:mindsmash/mindsmash-ui.git","clone_url":"https://github.com/mindsmash/mindsmash-ui.git","svn_url":"https://github.com/mindsmash/mindsmash-ui","homepage":"http://mindsmash.github.io/mindsmash-ui","size":506,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/24"},"html":{"href":"https://github.com/mindsmash/mindsmash-ui/pull/24"},"issue":{"href":"https://api.github.com/repos/mindsmash/mindsmash-ui/issues/24"},"comments":{"href":"https://api.github.com/repos/mindsmash/mindsmash-ui/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mindsmash/mindsmash-ui/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/mindsmash/mindsmash-ui/statuses/3509d15942c5364120d666a664d50c2b4014f886"}}}}