{"action":"created","comment":{"url":"https://api.github.com/repos/rackt/react-router/pulls/comments/41765616","id":41765616,"diff_hunk":"@@ -48,7 +42,7 @@ function routeIsActive(pathname, activeRoutes, activeParams, indexOnly) {\n     return false\n \n   if (indexOnly)\n-    return activeRoutes.length > 1 && activeRoutes[activeRoutes.length - 2].indexRoute === route\n+    return activeRoutes.length > 1 && activeRoutes[activeRoutes.length - 1] === route.indexRoute","path":"modules/isActive.js","position":17,"original_position":17,"commit_id":"1b547aac53d70997050379a9238762cc43ef9b25","original_commit_id":"1b547aac53d70997050379a9238762cc43ef9b25","user":{"login":"tomatau","id":1243486,"avatar_url":"https://avatars.githubusercontent.com/u/1243486?v=3","gravatar_id":"","url":"https://api.github.com/users/tomatau","html_url":"https://github.com/tomatau","followers_url":"https://api.github.com/users/tomatau/followers","following_url":"https://api.github.com/users/tomatau/following{/other_user}","gists_url":"https://api.github.com/users/tomatau/gists{/gist_id}","starred_url":"https://api.github.com/users/tomatau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomatau/subscriptions","organizations_url":"https://api.github.com/users/tomatau/orgs","repos_url":"https://api.github.com/users/tomatau/repos","events_url":"https://api.github.com/users/tomatau/events{/privacy}","received_events_url":"https://api.github.com/users/tomatau/received_events","type":"User","site_admin":false},"body":"This is behaving inconsistently for me on a SSR.\r\nClient correctly sets activeRoutes and renders fine.\r\nServer doesn't agree... adding the history as one of the active routes.\r\n\r\nserver:\r\n```es6\r\nactiveRoutes =\r\n   [ { history: undefined, childRoutes: [Object] },\r\n     { path: '/',\r\n       component: [Function: App],\r\n       indexRoute: [Object],\r\n       childRoutes: [Object] },\r\n     { component: [Function: Home] } ]\r\n```\r\n\r\nAnd so the previous code worked, but not this update.\r\n\r\nhttps://github.com/rackt/react-router/issues/1810#issuecomment-147409066","created_at":"2015-10-12T15:03:39Z","updated_at":"2015-10-12T15:03:39Z","html_url":"https://github.com/rackt/react-router/pull/2113#discussion_r41765616","pull_request_url":"https://api.github.com/repos/rackt/react-router/pulls/2113","_links":{"self":{"href":"https://api.github.com/repos/rackt/react-router/pulls/comments/41765616"},"html":{"href":"https://github.com/rackt/react-router/pull/2113#discussion_r41765616"},"pull_request":{"href":"https://api.github.com/repos/rackt/react-router/pulls/2113"}}},"pull_request":{"url":"https://api.github.com/repos/rackt/react-router/pulls/2113","id":46199623,"html_url":"https://github.com/rackt/react-router/pull/2113","diff_url":"https://github.com/rackt/react-router/pull/2113.diff","patch_url":"https://github.com/rackt/react-router/pull/2113.patch","issue_url":"https://api.github.com/repos/rackt/react-router/issues/2113","number":2113,"state":"closed","locked":false,"title":"[fixed] IndexLink is active","user":{"login":"iNikNik","id":7679749,"avatar_url":"https://avatars.githubusercontent.com/u/7679749?v=3","gravatar_id":"","url":"https://api.github.com/users/iNikNik","html_url":"https://github.com/iNikNik","followers_url":"https://api.github.com/users/iNikNik/followers","following_url":"https://api.github.com/users/iNikNik/following{/other_user}","gists_url":"https://api.github.com/users/iNikNik/gists{/gist_id}","starred_url":"https://api.github.com/users/iNikNik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNikNik/subscriptions","organizations_url":"https://api.github.com/users/iNikNik/orgs","repos_url":"https://api.github.com/users/iNikNik/repos","events_url":"https://api.github.com/users/iNikNik/events{/privacy}","received_events_url":"https://api.github.com/users/iNikNik/received_events","type":"User","site_admin":false},"body":"IndexLink now being activated correctly. Need to test it with #2079 ","created_at":"2015-09-28T19:48:49Z","updated_at":"2015-10-12T15:03:39Z","closed_at":"2015-10-07T20:21:06Z","merged_at":null,"merge_commit_sha":"6caa140cabfa8f5e813758447743eb596dc9b6c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackt/react-router/pulls/2113/commits","review_comments_url":"https://api.github.com/repos/rackt/react-router/pulls/2113/comments","review_comment_url":"https://api.github.com/repos/rackt/react-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackt/react-router/issues/2113/comments","statuses_url":"https://api.github.com/repos/rackt/react-router/statuses/1b547aac53d70997050379a9238762cc43ef9b25","head":{"label":"iNikNik:fix-index-link-is-active","ref":"fix-index-link-is-active","sha":"1b547aac53d70997050379a9238762cc43ef9b25","user":{"login":"iNikNik","id":7679749,"avatar_url":"https://avatars.githubusercontent.com/u/7679749?v=3","gravatar_id":"","url":"https://api.github.com/users/iNikNik","html_url":"https://github.com/iNikNik","followers_url":"https://api.github.com/users/iNikNik/followers","following_url":"https://api.github.com/users/iNikNik/following{/other_user}","gists_url":"https://api.github.com/users/iNikNik/gists{/gist_id}","starred_url":"https://api.github.com/users/iNikNik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNikNik/subscriptions","organizations_url":"https://api.github.com/users/iNikNik/orgs","repos_url":"https://api.github.com/users/iNikNik/repos","events_url":"https://api.github.com/users/iNikNik/events{/privacy}","received_events_url":"https://api.github.com/users/iNikNik/received_events","type":"User","site_admin":false},"repo":{"id":43310145,"name":"react-router","full_name":"iNikNik/react-router","owner":{"login":"iNikNik","id":7679749,"avatar_url":"https://avatars.githubusercontent.com/u/7679749?v=3","gravatar_id":"","url":"https://api.github.com/users/iNikNik","html_url":"https://github.com/iNikNik","followers_url":"https://api.github.com/users/iNikNik/followers","following_url":"https://api.github.com/users/iNikNik/following{/other_user}","gists_url":"https://api.github.com/users/iNikNik/gists{/gist_id}","starred_url":"https://api.github.com/users/iNikNik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iNikNik/subscriptions","organizations_url":"https://api.github.com/users/iNikNik/orgs","repos_url":"https://api.github.com/users/iNikNik/repos","events_url":"https://api.github.com/users/iNikNik/events{/privacy}","received_events_url":"https://api.github.com/users/iNikNik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iNikNik/react-router","description":"A complete routing solution for React.js","fork":true,"url":"https://api.github.com/repos/iNikNik/react-router","forks_url":"https://api.github.com/repos/iNikNik/react-router/forks","keys_url":"https://api.github.com/repos/iNikNik/react-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iNikNik/react-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iNikNik/react-router/teams","hooks_url":"https://api.github.com/repos/iNikNik/react-router/hooks","issue_events_url":"https://api.github.com/repos/iNikNik/react-router/issues/events{/number}","events_url":"https://api.github.com/repos/iNikNik/react-router/events","assignees_url":"https://api.github.com/repos/iNikNik/react-router/assignees{/user}","branches_url":"https://api.github.com/repos/iNikNik/react-router/branches{/branch}","tags_url":"https://api.github.com/repos/iNikNik/react-router/tags","blobs_url":"https://api.github.com/repos/iNikNik/react-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iNikNik/react-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iNikNik/react-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/iNikNik/react-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iNikNik/react-router/statuses/{sha}","languages_url":"https://api.github.com/repos/iNikNik/react-router/languages","stargazers_url":"https://api.github.com/repos/iNikNik/react-router/stargazers","contributors_url":"https://api.github.com/repos/iNikNik/react-router/contributors","subscribers_url":"https://api.github.com/repos/iNikNik/react-router/subscribers","subscription_url":"https://api.github.com/repos/iNikNik/react-router/subscription","commits_url":"https://api.github.com/repos/iNikNik/react-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/iNikNik/react-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/iNikNik/react-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/iNikNik/react-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/iNikNik/react-router/contents/{+path}","compare_url":"https://api.github.com/repos/iNikNik/react-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iNikNik/react-router/merges","archive_url":"https://api.github.com/repos/iNikNik/react-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iNikNik/react-router/downloads","issues_url":"https://api.github.com/repos/iNikNik/react-router/issues{/number}","pulls_url":"https://api.github.com/repos/iNikNik/react-router/pulls{/number}","milestones_url":"https://api.github.com/repos/iNikNik/react-router/milestones{/number}","notifications_url":"https://api.github.com/repos/iNikNik/react-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iNikNik/react-router/labels{/name}","releases_url":"https://api.github.com/repos/iNikNik/react-router/releases{/id}","created_at":"2015-09-28T15:42:49Z","updated_at":"2015-09-28T15:42:50Z","pushed_at":"2015-10-07T20:53:10Z","git_url":"git://github.com/iNikNik/react-router.git","ssh_url":"git@github.com:iNikNik/react-router.git","clone_url":"https://github.com/iNikNik/react-router.git","svn_url":"https://github.com/iNikNik/react-router","homepage":"","size":4273,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.13.x"}},"base":{"label":"rackt:master","ref":"master","sha":"09eec8508373756a85c5b70e109ddb30f2e858c6","user":{"login":"rackt","id":8261421,"avatar_url":"https://avatars.githubusercontent.com/u/8261421?v=3","gravatar_id":"","url":"https://api.github.com/users/rackt","html_url":"https://github.com/rackt","followers_url":"https://api.github.com/users/rackt/followers","following_url":"https://api.github.com/users/rackt/following{/other_user}","gists_url":"https://api.github.com/users/rackt/gists{/gist_id}","starred_url":"https://api.github.com/users/rackt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackt/subscriptions","organizations_url":"https://api.github.com/users/rackt/orgs","repos_url":"https://api.github.com/users/rackt/repos","events_url":"https://api.github.com/users/rackt/events{/privacy}","received_events_url":"https://api.github.com/users/rackt/received_events","type":"Organization","site_admin":false},"repo":{"id":19872456,"name":"react-router","full_name":"rackt/react-router","owner":{"login":"rackt","id":8261421,"avatar_url":"https://avatars.githubusercontent.com/u/8261421?v=3","gravatar_id":"","url":"https://api.github.com/users/rackt","html_url":"https://github.com/rackt","followers_url":"https://api.github.com/users/rackt/followers","following_url":"https://api.github.com/users/rackt/following{/other_user}","gists_url":"https://api.github.com/users/rackt/gists{/gist_id}","starred_url":"https://api.github.com/users/rackt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackt/subscriptions","organizations_url":"https://api.github.com/users/rackt/orgs","repos_url":"https://api.github.com/users/rackt/repos","events_url":"https://api.github.com/users/rackt/events{/privacy}","received_events_url":"https://api.github.com/users/rackt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackt/react-router","description":"A complete routing solution for React.js","fork":false,"url":"https://api.github.com/repos/rackt/react-router","forks_url":"https://api.github.com/repos/rackt/react-router/forks","keys_url":"https://api.github.com/repos/rackt/react-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackt/react-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackt/react-router/teams","hooks_url":"https://api.github.com/repos/rackt/react-router/hooks","issue_events_url":"https://api.github.com/repos/rackt/react-router/issues/events{/number}","events_url":"https://api.github.com/repos/rackt/react-router/events","assignees_url":"https://api.github.com/repos/rackt/react-router/assignees{/user}","branches_url":"https://api.github.com/repos/rackt/react-router/branches{/branch}","tags_url":"https://api.github.com/repos/rackt/react-router/tags","blobs_url":"https://api.github.com/repos/rackt/react-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackt/react-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackt/react-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackt/react-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackt/react-router/statuses/{sha}","languages_url":"https://api.github.com/repos/rackt/react-router/languages","stargazers_url":"https://api.github.com/repos/rackt/react-router/stargazers","contributors_url":"https://api.github.com/repos/rackt/react-router/contributors","subscribers_url":"https://api.github.com/repos/rackt/react-router/subscribers","subscription_url":"https://api.github.com/repos/rackt/react-router/subscription","commits_url":"https://api.github.com/repos/rackt/react-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackt/react-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackt/react-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackt/react-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackt/react-router/contents/{+path}","compare_url":"https://api.github.com/repos/rackt/react-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackt/react-router/merges","archive_url":"https://api.github.com/repos/rackt/react-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackt/react-router/downloads","issues_url":"https://api.github.com/repos/rackt/react-router/issues{/number}","pulls_url":"https://api.github.com/repos/rackt/react-router/pulls{/number}","milestones_url":"https://api.github.com/repos/rackt/react-router/milestones{/number}","notifications_url":"https://api.github.com/repos/rackt/react-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackt/react-router/labels{/name}","releases_url":"https://api.github.com/repos/rackt/react-router/releases{/id}","created_at":"2014-05-16T22:22:51Z","updated_at":"2015-10-12T14:42:45Z","pushed_at":"2015-10-12T15:01:22Z","git_url":"git://github.com/rackt/react-router.git","ssh_url":"git@github.com:rackt/react-router.git","clone_url":"https://github.com/rackt/react-router.git","svn_url":"https://github.com/rackt/react-router","homepage":"","size":11614,"stargazers_count":7160,"watchers_count":7160,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1213,"mirror_url":null,"open_issues_count":27,"forks":1213,"open_issues":27,"watchers":7160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackt/react-router/pulls/2113"},"html":{"href":"https://github.com/rackt/react-router/pull/2113"},"issue":{"href":"https://api.github.com/repos/rackt/react-router/issues/2113"},"comments":{"href":"https://api.github.com/repos/rackt/react-router/issues/2113/comments"},"review_comments":{"href":"https://api.github.com/repos/rackt/react-router/pulls/2113/comments"},"review_comment":{"href":"https://api.github.com/repos/rackt/react-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackt/react-router/pulls/2113/commits"},"statuses":{"href":"https://api.github.com/repos/rackt/react-router/statuses/1b547aac53d70997050379a9238762cc43ef9b25"}}}}