{"action":"created","issue":{"url":"https://api.github.com/repos/holidayextras/holidayextras.github.com/issues/40","labels_url":"https://api.github.com/repos/holidayextras/holidayextras.github.com/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/holidayextras/holidayextras.github.com/issues/40/comments","events_url":"https://api.github.com/repos/holidayextras/holidayextras.github.com/issues/40/events","html_url":"https://github.com/holidayextras/holidayextras.github.com/pull/40","id":83140612,"number":40,"title":"NPM, Grunt, LESS, Uglify & Deferred Loading ","user":{"login":"dancork","id":1881054,"avatar_url":"https://avatars.githubusercontent.com/u/1881054?v=3","gravatar_id":"","url":"https://api.github.com/users/dancork","html_url":"https://github.com/dancork","followers_url":"https://api.github.com/users/dancork/followers","following_url":"https://api.github.com/users/dancork/following{/other_user}","gists_url":"https://api.github.com/users/dancork/gists{/gist_id}","starred_url":"https://api.github.com/users/dancork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dancork/subscriptions","organizations_url":"https://api.github.com/users/dancork/orgs","repos_url":"https://api.github.com/users/dancork/repos","events_url":"https://api.github.com/users/dancork/events{/privacy}","received_events_url":"https://api.github.com/users/dancork/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-31T17:24:47Z","updated_at":"2015-06-01T08:59:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/holidayextras/holidayextras.github.com/pulls/40","html_url":"https://github.com/holidayextras/holidayextras.github.com/pull/40","diff_url":"https://github.com/holidayextras/holidayextras.github.com/pull/40.diff","patch_url":"https://github.com/holidayextras/holidayextras.github.com/pull/40.patch"},"body":"## What does this PR do?\r\n- Adds NPM and grunt.\r\n- Converts CSS to LESS\r\n- Creates critical CSS and deferrs all other styles\r\n- Minify/Uglify CSS and JS\r\n\r\n## How to test\r\n- Checkout branch\r\n- `npm install`\r\n- Try the new grunt tasks - `grunt less`, `grunt uglify`, `grunt watch` and `grunt`\r\n- Run `jekyll serve --config _config.yml,_config_dev.yml`\r\n- Visit `http://localhost:4000/`\r\n- Make sure the styling matches `http://hungrygeek.holidayextras.co.uk/`\r\n\r\n\r\n## Give me a GIF\r\n![](http://i.giphy.com/EGZkj53VzM18Y.gif)\r\n\r\n## Review\r\n\r\n#### Quality checklist (for PR author to complete BEFORE code review):\r\n- [ ] I've updated documentation with any changes to procedures..\r\n- [ ] I am ready for this to be code reviewed, merged and tested.\r\n\r\n#### IP or Developer Review:\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve checked for coding anti-patterns.\r\n- [ ] +1 from me!\r\n\r\n#### Software Engineer, Software Architect or Developer review:\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve checked for coding anti-patterns.\r\n- [ ] +1 from me!"},"comment":{"url":"https://api.github.com/repos/holidayextras/holidayextras.github.com/issues/comments/107374163","html_url":"https://github.com/holidayextras/holidayextras.github.com/pull/40#issuecomment-107374163","issue_url":"https://api.github.com/repos/holidayextras/holidayextras.github.com/issues/40","id":107374163,"user":{"login":"Joezo","id":2870255,"avatar_url":"https://avatars.githubusercontent.com/u/2870255?v=3","gravatar_id":"","url":"https://api.github.com/users/Joezo","html_url":"https://github.com/Joezo","followers_url":"https://api.github.com/users/Joezo/followers","following_url":"https://api.github.com/users/Joezo/following{/other_user}","gists_url":"https://api.github.com/users/Joezo/gists{/gist_id}","starred_url":"https://api.github.com/users/Joezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joezo/subscriptions","organizations_url":"https://api.github.com/users/Joezo/orgs","repos_url":"https://api.github.com/users/Joezo/repos","events_url":"https://api.github.com/users/Joezo/events{/privacy}","received_events_url":"https://api.github.com/users/Joezo/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T08:59:24Z","updated_at":"2015-06-01T08:59:24Z","body":"I spoke with Dan this morning and i'm going to make a couple of changes to this PR. Mainly around using npm scripts rather than Grunt. He's on holiday this week :("}}