{"action":"created","comment":{"url":"https://api.github.com/repos/SFTtech/openage/pulls/comments/29419588","id":29419588,"diff_hunk":"@@ -84,6 +91,8 @@ class AttributeContainer {\n \t\ttype{t} {}\n \n \tattr_type type;\n+\n+\tvirtual AttributeContainer *copy() const = 0;","path":"cpp/unit/attribute.h","position":19,"original_position":19,"commit_id":"196a0b3825e4607318e0cf329be7aaf833f34c07","original_commit_id":"196a0b3825e4607318e0cf329be7aaf833f34c07","user":{"login":"mic-e","id":796624,"avatar_url":"https://avatars.githubusercontent.com/u/796624?v=3","gravatar_id":"","url":"https://api.github.com/users/mic-e","html_url":"https://github.com/mic-e","followers_url":"https://api.github.com/users/mic-e/followers","following_url":"https://api.github.com/users/mic-e/following{/other_user}","gists_url":"https://api.github.com/users/mic-e/gists{/gist_id}","starred_url":"https://api.github.com/users/mic-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mic-e/subscriptions","organizations_url":"https://api.github.com/users/mic-e/orgs","repos_url":"https://api.github.com/users/mic-e/repos","events_url":"https://api.github.com/users/mic-e/events{/privacy}","received_events_url":"https://api.github.com/users/mic-e/received_events","type":"User","site_admin":false},"body":"Why are we even using this complicated `AttributeContainer`/`attr_type` model instead of simply making attributes polymorphic?","created_at":"2015-04-30T10:50:16Z","updated_at":"2015-04-30T10:50:16Z","html_url":"https://github.com/SFTtech/openage/pull/268#discussion_r29419588","pull_request_url":"https://api.github.com/repos/SFTtech/openage/pulls/268","_links":{"self":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/comments/29419588"},"html":{"href":"https://github.com/SFTtech/openage/pull/268#discussion_r29419588"},"pull_request":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/SFTtech/openage/pulls/268","id":32310678,"html_url":"https://github.com/SFTtech/openage/pull/268","diff_url":"https://github.com/SFTtech/openage/pull/268.diff","patch_url":"https://github.com/SFTtech/openage/pull/268.patch","issue_url":"https://api.github.com/repos/SFTtech/openage/issues/268","number":268,"state":"open","locked":false,"title":"Auto-task idle units","user":{"login":"Jon0","id":3847361,"avatar_url":"https://avatars.githubusercontent.com/u/3847361?v=3","gravatar_id":"","url":"https://api.github.com/users/Jon0","html_url":"https://github.com/Jon0","followers_url":"https://api.github.com/users/Jon0/followers","following_url":"https://api.github.com/users/Jon0/following{/other_user}","gists_url":"https://api.github.com/users/Jon0/gists{/gist_id}","starred_url":"https://api.github.com/users/Jon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jon0/subscriptions","organizations_url":"https://api.github.com/users/Jon0/orgs","repos_url":"https://api.github.com/users/Jon0/repos","events_url":"https://api.github.com/users/Jon0/events{/privacy}","received_events_url":"https://api.github.com/users/Jon0/received_events","type":"User","site_admin":false},"body":"* Rename Producer to UnitType\r\n* Terrain objects are now actually cleaned up\r\n* Annex terrain object are cleaned up\r\n* Many more bug fixes\r\n* Idle units find nearby units to attack\r\n* Faster searching for dropsites\r\n* Buildings now placed as floating outlines \r\n* Floating buildings do not block units\r\n* The terrain objects can now only be constructed via units:\r\n```c++\r\nunit->make_location<SquareObject>(...)\r\n```\r\n\r\n","created_at":"2015-03-31T10:49:56Z","updated_at":"2015-04-30T10:50:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d14ef075a6a429879402249899c2431dfa969040","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SFTtech/openage/pulls/268/commits","review_comments_url":"https://api.github.com/repos/SFTtech/openage/pulls/268/comments","review_comment_url":"https://api.github.com/repos/SFTtech/openage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SFTtech/openage/issues/268/comments","statuses_url":"https://api.github.com/repos/SFTtech/openage/statuses/196a0b3825e4607318e0cf329be7aaf833f34c07","head":{"label":"Jon0:task_search","ref":"task_search","sha":"196a0b3825e4607318e0cf329be7aaf833f34c07","user":{"login":"Jon0","id":3847361,"avatar_url":"https://avatars.githubusercontent.com/u/3847361?v=3","gravatar_id":"","url":"https://api.github.com/users/Jon0","html_url":"https://github.com/Jon0","followers_url":"https://api.github.com/users/Jon0/followers","following_url":"https://api.github.com/users/Jon0/following{/other_user}","gists_url":"https://api.github.com/users/Jon0/gists{/gist_id}","starred_url":"https://api.github.com/users/Jon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jon0/subscriptions","organizations_url":"https://api.github.com/users/Jon0/orgs","repos_url":"https://api.github.com/users/Jon0/repos","events_url":"https://api.github.com/users/Jon0/events{/privacy}","received_events_url":"https://api.github.com/users/Jon0/received_events","type":"User","site_admin":false},"repo":{"id":25803186,"name":"openage","full_name":"Jon0/openage","owner":{"login":"Jon0","id":3847361,"avatar_url":"https://avatars.githubusercontent.com/u/3847361?v=3","gravatar_id":"","url":"https://api.github.com/users/Jon0","html_url":"https://github.com/Jon0","followers_url":"https://api.github.com/users/Jon0/followers","following_url":"https://api.github.com/users/Jon0/following{/other_user}","gists_url":"https://api.github.com/users/Jon0/gists{/gist_id}","starred_url":"https://api.github.com/users/Jon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jon0/subscriptions","organizations_url":"https://api.github.com/users/Jon0/orgs","repos_url":"https://api.github.com/users/Jon0/repos","events_url":"https://api.github.com/users/Jon0/events{/privacy}","received_events_url":"https://api.github.com/users/Jon0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jon0/openage","description":"Free (as in freedom) open source clone of the Age of Empires II engine.","fork":true,"url":"https://api.github.com/repos/Jon0/openage","forks_url":"https://api.github.com/repos/Jon0/openage/forks","keys_url":"https://api.github.com/repos/Jon0/openage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jon0/openage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jon0/openage/teams","hooks_url":"https://api.github.com/repos/Jon0/openage/hooks","issue_events_url":"https://api.github.com/repos/Jon0/openage/issues/events{/number}","events_url":"https://api.github.com/repos/Jon0/openage/events","assignees_url":"https://api.github.com/repos/Jon0/openage/assignees{/user}","branches_url":"https://api.github.com/repos/Jon0/openage/branches{/branch}","tags_url":"https://api.github.com/repos/Jon0/openage/tags","blobs_url":"https://api.github.com/repos/Jon0/openage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jon0/openage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jon0/openage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jon0/openage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jon0/openage/statuses/{sha}","languages_url":"https://api.github.com/repos/Jon0/openage/languages","stargazers_url":"https://api.github.com/repos/Jon0/openage/stargazers","contributors_url":"https://api.github.com/repos/Jon0/openage/contributors","subscribers_url":"https://api.github.com/repos/Jon0/openage/subscribers","subscription_url":"https://api.github.com/repos/Jon0/openage/subscription","commits_url":"https://api.github.com/repos/Jon0/openage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jon0/openage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jon0/openage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jon0/openage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jon0/openage/contents/{+path}","compare_url":"https://api.github.com/repos/Jon0/openage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jon0/openage/merges","archive_url":"https://api.github.com/repos/Jon0/openage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jon0/openage/downloads","issues_url":"https://api.github.com/repos/Jon0/openage/issues{/number}","pulls_url":"https://api.github.com/repos/Jon0/openage/pulls{/number}","milestones_url":"https://api.github.com/repos/Jon0/openage/milestones{/number}","notifications_url":"https://api.github.com/repos/Jon0/openage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jon0/openage/labels{/name}","releases_url":"https://api.github.com/repos/Jon0/openage/releases{/id}","created_at":"2014-10-27T04:28:20Z","updated_at":"2015-04-01T02:50:23Z","pushed_at":"2015-04-29T09:25:54Z","git_url":"git://github.com/Jon0/openage.git","ssh_url":"git@github.com:Jon0/openage.git","clone_url":"https://github.com/Jon0/openage.git","svn_url":"https://github.com/Jon0/openage","homepage":"http://openage.sft.mx","size":5119,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"SFTtech:master","ref":"master","sha":"9a7db5175ba8b7f8881d28ff026b50bffde841b5","user":{"login":"SFTtech","id":1783325,"avatar_url":"https://avatars.githubusercontent.com/u/1783325?v=3","gravatar_id":"","url":"https://api.github.com/users/SFTtech","html_url":"https://github.com/SFTtech","followers_url":"https://api.github.com/users/SFTtech/followers","following_url":"https://api.github.com/users/SFTtech/following{/other_user}","gists_url":"https://api.github.com/users/SFTtech/gists{/gist_id}","starred_url":"https://api.github.com/users/SFTtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SFTtech/subscriptions","organizations_url":"https://api.github.com/users/SFTtech/orgs","repos_url":"https://api.github.com/users/SFTtech/repos","events_url":"https://api.github.com/users/SFTtech/events{/privacy}","received_events_url":"https://api.github.com/users/SFTtech/received_events","type":"Organization","site_admin":false},"repo":{"id":14095175,"name":"openage","full_name":"SFTtech/openage","owner":{"login":"SFTtech","id":1783325,"avatar_url":"https://avatars.githubusercontent.com/u/1783325?v=3","gravatar_id":"","url":"https://api.github.com/users/SFTtech","html_url":"https://github.com/SFTtech","followers_url":"https://api.github.com/users/SFTtech/followers","following_url":"https://api.github.com/users/SFTtech/following{/other_user}","gists_url":"https://api.github.com/users/SFTtech/gists{/gist_id}","starred_url":"https://api.github.com/users/SFTtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SFTtech/subscriptions","organizations_url":"https://api.github.com/users/SFTtech/orgs","repos_url":"https://api.github.com/users/SFTtech/repos","events_url":"https://api.github.com/users/SFTtech/events{/privacy}","received_events_url":"https://api.github.com/users/SFTtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SFTtech/openage","description":"Free (as in freedom) open source clone of the Age of Empires II engine.","fork":false,"url":"https://api.github.com/repos/SFTtech/openage","forks_url":"https://api.github.com/repos/SFTtech/openage/forks","keys_url":"https://api.github.com/repos/SFTtech/openage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SFTtech/openage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SFTtech/openage/teams","hooks_url":"https://api.github.com/repos/SFTtech/openage/hooks","issue_events_url":"https://api.github.com/repos/SFTtech/openage/issues/events{/number}","events_url":"https://api.github.com/repos/SFTtech/openage/events","assignees_url":"https://api.github.com/repos/SFTtech/openage/assignees{/user}","branches_url":"https://api.github.com/repos/SFTtech/openage/branches{/branch}","tags_url":"https://api.github.com/repos/SFTtech/openage/tags","blobs_url":"https://api.github.com/repos/SFTtech/openage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SFTtech/openage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SFTtech/openage/git/refs{/sha}","trees_url":"https://api.github.com/repos/SFTtech/openage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SFTtech/openage/statuses/{sha}","languages_url":"https://api.github.com/repos/SFTtech/openage/languages","stargazers_url":"https://api.github.com/repos/SFTtech/openage/stargazers","contributors_url":"https://api.github.com/repos/SFTtech/openage/contributors","subscribers_url":"https://api.github.com/repos/SFTtech/openage/subscribers","subscription_url":"https://api.github.com/repos/SFTtech/openage/subscription","commits_url":"https://api.github.com/repos/SFTtech/openage/commits{/sha}","git_commits_url":"https://api.github.com/repos/SFTtech/openage/git/commits{/sha}","comments_url":"https://api.github.com/repos/SFTtech/openage/comments{/number}","issue_comment_url":"https://api.github.com/repos/SFTtech/openage/issues/comments{/number}","contents_url":"https://api.github.com/repos/SFTtech/openage/contents/{+path}","compare_url":"https://api.github.com/repos/SFTtech/openage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SFTtech/openage/merges","archive_url":"https://api.github.com/repos/SFTtech/openage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SFTtech/openage/downloads","issues_url":"https://api.github.com/repos/SFTtech/openage/issues{/number}","pulls_url":"https://api.github.com/repos/SFTtech/openage/pulls{/number}","milestones_url":"https://api.github.com/repos/SFTtech/openage/milestones{/number}","notifications_url":"https://api.github.com/repos/SFTtech/openage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SFTtech/openage/labels{/name}","releases_url":"https://api.github.com/repos/SFTtech/openage/releases{/id}","created_at":"2013-11-03T22:35:23Z","updated_at":"2015-04-29T15:28:50Z","pushed_at":"2015-04-30T08:00:41Z","git_url":"git://github.com/SFTtech/openage.git","ssh_url":"git@github.com:SFTtech/openage.git","clone_url":"https://github.com/SFTtech/openage.git","svn_url":"https://github.com/SFTtech/openage","homepage":"http://openage.sft.mx","size":8834,"stargazers_count":2962,"watchers_count":2962,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":265,"mirror_url":null,"open_issues_count":81,"forks":265,"open_issues":81,"watchers":2962,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/268"},"html":{"href":"https://github.com/SFTtech/openage/pull/268"},"issue":{"href":"https://api.github.com/repos/SFTtech/openage/issues/268"},"comments":{"href":"https://api.github.com/repos/SFTtech/openage/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SFTtech/openage/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/SFTtech/openage/statuses/196a0b3825e4607318e0cf329be7aaf833f34c07"}}}}