{"action":"opened","number":351,"pull_request":{"url":"https://api.github.com/repos/non/cats/pulls/351","id":37732163,"html_url":"https://github.com/non/cats/pull/351","diff_url":"https://github.com/non/cats/pull/351.diff","patch_url":"https://github.com/non/cats/pull/351.patch","issue_url":"https://api.github.com/repos/non/cats/issues/351","number":351,"state":"open","locked":false,"title":"better test coverage for kleisli","user":{"login":"woparry","id":11383686,"avatar_url":"https://avatars.githubusercontent.com/u/11383686?v=3","gravatar_id":"","url":"https://api.github.com/users/woparry","html_url":"https://github.com/woparry","followers_url":"https://api.github.com/users/woparry/followers","following_url":"https://api.github.com/users/woparry/following{/other_user}","gists_url":"https://api.github.com/users/woparry/gists{/gist_id}","starred_url":"https://api.github.com/users/woparry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woparry/subscriptions","organizations_url":"https://api.github.com/users/woparry/orgs","repos_url":"https://api.github.com/users/woparry/repos","events_url":"https://api.github.com/users/woparry/events{/privacy}","received_events_url":"https://api.github.com/users/woparry/received_events","type":"User","site_admin":false},"body":"As an aside, this test illustrates a general problem with the current architecture for test coverage.\r\n\r\nRather than having a single object/piece of code which is the typeclass instance for all typeclasses, we have separate implicit code/objects for each refinement. This means that we have to explicitly pull in and run the laws on each to get test coverage - something that discipline could normally take care of for us via 'parents' etc.\r\n\r\nWhat's the reasoning behind the disparate instances?\r\n\r\n(NB: please don't consider this a blocker for improving test coverage; I'm happy to add this code and remove it later if it turns out we don't need it. As long as the different instances have different implementations, we need to test them all.)","created_at":"2015-06-15T20:31:41Z","updated_at":"2015-06-15T20:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/non/cats/pulls/351/commits","review_comments_url":"https://api.github.com/repos/non/cats/pulls/351/comments","review_comment_url":"https://api.github.com/repos/non/cats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/non/cats/issues/351/comments","statuses_url":"https://api.github.com/repos/non/cats/statuses/f221f843b25bc8bf04ef81a8f8bb5cb9bace531a","head":{"label":"woparry:oparri/kleisli-coverage","ref":"oparri/kleisli-coverage","sha":"f221f843b25bc8bf04ef81a8f8bb5cb9bace531a","user":{"login":"woparry","id":11383686,"avatar_url":"https://avatars.githubusercontent.com/u/11383686?v=3","gravatar_id":"","url":"https://api.github.com/users/woparry","html_url":"https://github.com/woparry","followers_url":"https://api.github.com/users/woparry/followers","following_url":"https://api.github.com/users/woparry/following{/other_user}","gists_url":"https://api.github.com/users/woparry/gists{/gist_id}","starred_url":"https://api.github.com/users/woparry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woparry/subscriptions","organizations_url":"https://api.github.com/users/woparry/orgs","repos_url":"https://api.github.com/users/woparry/repos","events_url":"https://api.github.com/users/woparry/events{/privacy}","received_events_url":"https://api.github.com/users/woparry/received_events","type":"User","site_admin":false},"repo":{"id":36533466,"name":"cats","full_name":"woparry/cats","owner":{"login":"woparry","id":11383686,"avatar_url":"https://avatars.githubusercontent.com/u/11383686?v=3","gravatar_id":"","url":"https://api.github.com/users/woparry","html_url":"https://github.com/woparry","followers_url":"https://api.github.com/users/woparry/followers","following_url":"https://api.github.com/users/woparry/following{/other_user}","gists_url":"https://api.github.com/users/woparry/gists{/gist_id}","starred_url":"https://api.github.com/users/woparry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woparry/subscriptions","organizations_url":"https://api.github.com/users/woparry/orgs","repos_url":"https://api.github.com/users/woparry/repos","events_url":"https://api.github.com/users/woparry/events{/privacy}","received_events_url":"https://api.github.com/users/woparry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/woparry/cats","description":"Lightweight, modular, and extensible library for functional programming.","fork":true,"url":"https://api.github.com/repos/woparry/cats","forks_url":"https://api.github.com/repos/woparry/cats/forks","keys_url":"https://api.github.com/repos/woparry/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woparry/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woparry/cats/teams","hooks_url":"https://api.github.com/repos/woparry/cats/hooks","issue_events_url":"https://api.github.com/repos/woparry/cats/issues/events{/number}","events_url":"https://api.github.com/repos/woparry/cats/events","assignees_url":"https://api.github.com/repos/woparry/cats/assignees{/user}","branches_url":"https://api.github.com/repos/woparry/cats/branches{/branch}","tags_url":"https://api.github.com/repos/woparry/cats/tags","blobs_url":"https://api.github.com/repos/woparry/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woparry/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woparry/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/woparry/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woparry/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/woparry/cats/languages","stargazers_url":"https://api.github.com/repos/woparry/cats/stargazers","contributors_url":"https://api.github.com/repos/woparry/cats/contributors","subscribers_url":"https://api.github.com/repos/woparry/cats/subscribers","subscription_url":"https://api.github.com/repos/woparry/cats/subscription","commits_url":"https://api.github.com/repos/woparry/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/woparry/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/woparry/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/woparry/cats/issues/comments{/number}","contents_url":"https://api.github.com/repos/woparry/cats/contents/{+path}","compare_url":"https://api.github.com/repos/woparry/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woparry/cats/merges","archive_url":"https://api.github.com/repos/woparry/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woparry/cats/downloads","issues_url":"https://api.github.com/repos/woparry/cats/issues{/number}","pulls_url":"https://api.github.com/repos/woparry/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/woparry/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/woparry/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woparry/cats/labels{/name}","releases_url":"https://api.github.com/repos/woparry/cats/releases{/id}","created_at":"2015-05-29T23:01:18Z","updated_at":"2015-05-29T23:01:18Z","pushed_at":"2015-06-15T20:27:26Z","git_url":"git://github.com/woparry/cats.git","ssh_url":"git@github.com:woparry/cats.git","clone_url":"https://github.com/woparry/cats.git","svn_url":"https://github.com/woparry/cats","homepage":"http://non.github.io/cats/","size":3325,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"non:master","ref":"master","sha":"74a237fa9eca0b8c5c88bfec0d9ffc8b97406001","user":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"repo":{"id":29986727,"name":"cats","full_name":"non/cats","owner":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/non/cats","description":"Lightweight, modular, and extensible library for functional programming.","fork":false,"url":"https://api.github.com/repos/non/cats","forks_url":"https://api.github.com/repos/non/cats/forks","keys_url":"https://api.github.com/repos/non/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/non/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/non/cats/teams","hooks_url":"https://api.github.com/repos/non/cats/hooks","issue_events_url":"https://api.github.com/repos/non/cats/issues/events{/number}","events_url":"https://api.github.com/repos/non/cats/events","assignees_url":"https://api.github.com/repos/non/cats/assignees{/user}","branches_url":"https://api.github.com/repos/non/cats/branches{/branch}","tags_url":"https://api.github.com/repos/non/cats/tags","blobs_url":"https://api.github.com/repos/non/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/non/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/non/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/non/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/non/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/non/cats/languages","stargazers_url":"https://api.github.com/repos/non/cats/stargazers","contributors_url":"https://api.github.com/repos/non/cats/contributors","subscribers_url":"https://api.github.com/repos/non/cats/subscribers","subscription_url":"https://api.github.com/repos/non/cats/subscription","commits_url":"https://api.github.com/repos/non/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/non/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/non/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/non/cats/issues/comments{/number}","contents_url":"https://api.github.com/repos/non/cats/contents/{+path}","compare_url":"https://api.github.com/repos/non/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/non/cats/merges","archive_url":"https://api.github.com/repos/non/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/non/cats/downloads","issues_url":"https://api.github.com/repos/non/cats/issues{/number}","pulls_url":"https://api.github.com/repos/non/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/non/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/non/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/non/cats/labels{/name}","releases_url":"https://api.github.com/repos/non/cats/releases{/id}","created_at":"2015-01-28T20:26:48Z","updated_at":"2015-06-15T14:18:19Z","pushed_at":"2015-06-14T05:53:57Z","git_url":"git://github.com/non/cats.git","ssh_url":"git@github.com:non/cats.git","clone_url":"https://github.com/non/cats.git","svn_url":"https://github.com/non/cats","homepage":"http://non.github.io/cats/","size":5489,"stargazers_count":401,"watchers_count":401,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":50,"forks":75,"open_issues":50,"watchers":401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/non/cats/pulls/351"},"html":{"href":"https://github.com/non/cats/pull/351"},"issue":{"href":"https://api.github.com/repos/non/cats/issues/351"},"comments":{"href":"https://api.github.com/repos/non/cats/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/non/cats/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/non/cats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/non/cats/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/non/cats/statuses/f221f843b25bc8bf04ef81a8f8bb5cb9bace531a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":59,"deletions":7,"changed_files":1}}