{"action":"closed","issue":{"url":"https://api.github.com/repos/elixircnx/comeonin/issues/34","labels_url":"https://api.github.com/repos/elixircnx/comeonin/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/elixircnx/comeonin/issues/34/comments","events_url":"https://api.github.com/repos/elixircnx/comeonin/issues/34/events","html_url":"https://github.com/elixircnx/comeonin/issues/34","id":97299383,"number":34,"title":"Strong password should not check for digits","user":{"login":"josevalim","id":9582,"avatar_url":"https://avatars.githubusercontent.com/u/9582?v=3","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-07-26T08:58:57Z","updated_at":"2015-07-28T20:35:26Z","closed_at":"2015-07-28T20:35:26Z","body":"I was a bit surprised when the `comeonin` checked for certain digits:\r\n\r\nhttps://xkcd.com/936/\r\n\r\nAnd then I was even more surprised when disabling the strength also disabled the min length check.\r\n\r\nMy advice would be to make the API a little bit more flexible so:\r\n\r\n1. Minimum password length is configurable\r\n\r\n2. Checking for digits is opt-in and configurable\r\n\r\nHere is a proposed API:\r\n\r\n    create_hash \"some_string\", minimum: 8, check_digits: true\r\n\r\nAlso [avoid application configuration as much as possible](https://github.com/elixircnx/comeonin/blob/master/lib/comeonin/config.ex). The reason is that application configuration is singleton. For example, if project A configures application comeonin in a certain way, then project B configures it differently, when I use A and B together, I can get a clash. If those things can be given as options to function calls, it would be better.\r\n\r\n"}}