{"action":"created","issue":{"url":"https://api.github.com/repos/opencontainers/specs/issues/114","labels_url":"https://api.github.com/repos/opencontainers/specs/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/opencontainers/specs/issues/114/comments","events_url":"https://api.github.com/repos/opencontainers/specs/issues/114/events","html_url":"https://github.com/opencontainers/specs/issues/114","id":103140020,"number":114,"title":"Support for Quality of Service","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-08-25T23:48:57Z","updated_at":"2015-10-12T19:45:00Z","closed_at":null,"body":"The API has to let users express the notion of priority among containers. Consider the case when a web server is run alongside a logging container. The web-server is more important than the logging side-car container. When there is a resource crunch, the user doesn't mind killing one of the lower priority containers, which is logging in this case. Ideally, if all containers were to be run with limits, this might not be necessary. In reality though, setting limits is hard and users tend to over provision resources and that leads to poor resource utilization.\r\n\r\nSince this notion of priority can be expressed in different ways, I propose letting users handle cgroup management and only expose the following knobs:\r\n\r\n1. **CgroupsPath** - This lets users manage cgroup hierarchies. \r\n\r\n2. **OomScoreAdj** - Apply a custom 'oom_score_adj' to the init process of the container. "},"comment":{"url":"https://api.github.com/repos/opencontainers/specs/issues/comments/147501395","html_url":"https://github.com/opencontainers/specs/issues/114#issuecomment-147501395","issue_url":"https://api.github.com/repos/opencontainers/specs/issues/114","id":147501395,"user":{"login":"wking","id":209920,"avatar_url":"https://avatars.githubusercontent.com/u/209920?v=3","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T19:45:00Z","updated_at":"2015-10-12T19:45:00Z","body":"On Mon, Oct 12, 2015 at 12:39:39PM -0700, Vish Kannan wrote:\n> I take back my previous comment. How can we set `oom_score_adj` on\n> pre-start hooks if the intention is to set the `oom_score_adj` value\n> on the container's init process?\n\nWhat is the problem you expect?  Everything you need for this should\nbe in my #115 example [1], which worked (as far as I can tell).  Do\nyou see something wrong with that example?\n\n[1]: https://github.com/opencontainers/specs/issues/115#issuecomment-138104387\n\n"}}