{"action":"created","comment":{"url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/comments/47398957","id":47398957,"diff_hunk":"@@ -332,11 +331,11 @@ var Axis = React.createClass({\n module.exports = Axis;\n ```\n \n-Our strategy up to this point is letting React exclusively handle the DOM. This is a good general rule, but we need to leave room for nuance. Sometimes thought we have to make compromises. In this case, the math and work we would have to do for rendering an axis is really complicated, and D3 has abstracted that pretty nicely, so we're going to get D3 have access to the DOM in this case. Also, since we're only going to render a maximum of 2 axis, the performance tradeoff is almost non-existant. \n+Our strategy up to this point is letting React exclusively handle the DOM. This is a good general rule, but we need to leave room for nuance. Sometimes thought we have to make compromises. In this case, the math and work we would have to do for rendering an axis is really complicated, and D3 has abstracted that pretty nicely, so we're going to let D3 have access to the DOM in this case. Also, since we're only going to render a maximum of 2 axis, the performance tradeoff is almost non-existant. ","path":"README.md","position":136,"original_position":136,"commit_id":"d29f8f05bc7382574ae03ee21ac24ffd1cf34e54","original_commit_id":"d29f8f05bc7382574ae03ee21ac24ffd1cf34e54","user":{"login":"garronmichael","id":9438091,"avatar_url":"https://avatars.githubusercontent.com/u/9438091?v=3","gravatar_id":"","url":"https://api.github.com/users/garronmichael","html_url":"https://github.com/garronmichael","followers_url":"https://api.github.com/users/garronmichael/followers","following_url":"https://api.github.com/users/garronmichael/following{/other_user}","gists_url":"https://api.github.com/users/garronmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/garronmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garronmichael/subscriptions","organizations_url":"https://api.github.com/users/garronmichael/orgs","repos_url":"https://api.github.com/users/garronmichael/repos","events_url":"https://api.github.com/users/garronmichael/events{/privacy}","received_events_url":"https://api.github.com/users/garronmichael/received_events","type":"User","site_admin":false},"body":"Typo","created_at":"2015-12-11T20:06:20Z","updated_at":"2015-12-11T20:06:20Z","html_url":"https://github.com/freddyrangel/playing-with-react-and-d3/pull/1#discussion_r47398957","pull_request_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/comments/47398957"},"html":{"href":"https://github.com/freddyrangel/playing-with-react-and-d3/pull/1#discussion_r47398957"},"pull_request":{"href":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/1","id":53437516,"html_url":"https://github.com/freddyrangel/playing-with-react-and-d3/pull/1","diff_url":"https://github.com/freddyrangel/playing-with-react-and-d3/pull/1.diff","patch_url":"https://github.com/freddyrangel/playing-with-react-and-d3/pull/1.patch","issue_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/issues/1","number":1,"state":"open","locked":false,"title":"fix typos, add clarity","user":{"login":"garronmichael","id":9438091,"avatar_url":"https://avatars.githubusercontent.com/u/9438091?v=3","gravatar_id":"","url":"https://api.github.com/users/garronmichael","html_url":"https://github.com/garronmichael","followers_url":"https://api.github.com/users/garronmichael/followers","following_url":"https://api.github.com/users/garronmichael/following{/other_user}","gists_url":"https://api.github.com/users/garronmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/garronmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garronmichael/subscriptions","organizations_url":"https://api.github.com/users/garronmichael/orgs","repos_url":"https://api.github.com/users/garronmichael/repos","events_url":"https://api.github.com/users/garronmichael/events{/privacy}","received_events_url":"https://api.github.com/users/garronmichael/received_events","type":"User","site_admin":false},"body":"# Files Changed: 1\r\n\r\n## README.md\r\n* fixed typos\r\n  * ```heard``` to ```head```\r\n  * ```used``` to ```uses```\r\n  * ```get``` to ```let```\r\n  * the plural of axis is axes so ```XYAxis``` becomes ```XYAxes```, etc.\r\n* added clarity\r\n  * add file extension to require statements to identify files from node modules\r\n    * ```var App = require('./components/App')``` to ```var App = require('./components/App.jsx')```\r\n    * repeated change for requiring DataCircles.jsx, XYAxes.jsx and Axis.jsx\r\n  * remove unnecessary scale variable from Axis.jsx","created_at":"2015-12-11T20:02:59Z","updated_at":"2015-12-11T20:06:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b47bb62b01eb9e8eb336b7444b116371b7b68f1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/1/commits","review_comments_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/1/comments","review_comment_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/issues/1/comments","statuses_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/statuses/d29f8f05bc7382574ae03ee21ac24ffd1cf34e54","head":{"label":"garronmichael:readme","ref":"readme","sha":"d29f8f05bc7382574ae03ee21ac24ffd1cf34e54","user":{"login":"garronmichael","id":9438091,"avatar_url":"https://avatars.githubusercontent.com/u/9438091?v=3","gravatar_id":"","url":"https://api.github.com/users/garronmichael","html_url":"https://github.com/garronmichael","followers_url":"https://api.github.com/users/garronmichael/followers","following_url":"https://api.github.com/users/garronmichael/following{/other_user}","gists_url":"https://api.github.com/users/garronmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/garronmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garronmichael/subscriptions","organizations_url":"https://api.github.com/users/garronmichael/orgs","repos_url":"https://api.github.com/users/garronmichael/repos","events_url":"https://api.github.com/users/garronmichael/events{/privacy}","received_events_url":"https://api.github.com/users/garronmichael/received_events","type":"User","site_admin":false},"repo":{"id":47797628,"name":"playing-with-react-and-d3","full_name":"garronmichael/playing-with-react-and-d3","owner":{"login":"garronmichael","id":9438091,"avatar_url":"https://avatars.githubusercontent.com/u/9438091?v=3","gravatar_id":"","url":"https://api.github.com/users/garronmichael","html_url":"https://github.com/garronmichael","followers_url":"https://api.github.com/users/garronmichael/followers","following_url":"https://api.github.com/users/garronmichael/following{/other_user}","gists_url":"https://api.github.com/users/garronmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/garronmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garronmichael/subscriptions","organizations_url":"https://api.github.com/users/garronmichael/orgs","repos_url":"https://api.github.com/users/garronmichael/repos","events_url":"https://api.github.com/users/garronmichael/events{/privacy}","received_events_url":"https://api.github.com/users/garronmichael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garronmichael/playing-with-react-and-d3","description":"A tutorial on the basics of getting React to work with D3","fork":true,"url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3","forks_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/forks","keys_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/teams","hooks_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/hooks","issue_events_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/issues/events{/number}","events_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/events","assignees_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/assignees{/user}","branches_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/branches{/branch}","tags_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/tags","blobs_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/git/refs{/sha}","trees_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/statuses/{sha}","languages_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/languages","stargazers_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/stargazers","contributors_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/contributors","subscribers_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/subscribers","subscription_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/subscription","commits_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/commits{/sha}","git_commits_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/git/commits{/sha}","comments_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/comments{/number}","issue_comment_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/issues/comments{/number}","contents_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/contents/{+path}","compare_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/merges","archive_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/downloads","issues_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/issues{/number}","pulls_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/pulls{/number}","milestones_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/milestones{/number}","notifications_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/labels{/name}","releases_url":"https://api.github.com/repos/garronmichael/playing-with-react-and-d3/releases{/id}","created_at":"2015-12-11T01:28:13Z","updated_at":"2015-12-11T01:28:14Z","pushed_at":"2015-12-11T18:57:54Z","git_url":"git://github.com/garronmichael/playing-with-react-and-d3.git","ssh_url":"git@github.com:garronmichael/playing-with-react-and-d3.git","clone_url":"https://github.com/garronmichael/playing-with-react-and-d3.git","svn_url":"https://github.com/garronmichael/playing-with-react-and-d3","homepage":"","size":117,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freddyrangel:master","ref":"master","sha":"e0398504cddc6ca1e47dae63e4b2cd0bfc0f0232","user":{"login":"freddyrangel","id":4118813,"avatar_url":"https://avatars.githubusercontent.com/u/4118813?v=3","gravatar_id":"","url":"https://api.github.com/users/freddyrangel","html_url":"https://github.com/freddyrangel","followers_url":"https://api.github.com/users/freddyrangel/followers","following_url":"https://api.github.com/users/freddyrangel/following{/other_user}","gists_url":"https://api.github.com/users/freddyrangel/gists{/gist_id}","starred_url":"https://api.github.com/users/freddyrangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freddyrangel/subscriptions","organizations_url":"https://api.github.com/users/freddyrangel/orgs","repos_url":"https://api.github.com/users/freddyrangel/repos","events_url":"https://api.github.com/users/freddyrangel/events{/privacy}","received_events_url":"https://api.github.com/users/freddyrangel/received_events","type":"User","site_admin":false},"repo":{"id":43783149,"name":"playing-with-react-and-d3","full_name":"freddyrangel/playing-with-react-and-d3","owner":{"login":"freddyrangel","id":4118813,"avatar_url":"https://avatars.githubusercontent.com/u/4118813?v=3","gravatar_id":"","url":"https://api.github.com/users/freddyrangel","html_url":"https://github.com/freddyrangel","followers_url":"https://api.github.com/users/freddyrangel/followers","following_url":"https://api.github.com/users/freddyrangel/following{/other_user}","gists_url":"https://api.github.com/users/freddyrangel/gists{/gist_id}","starred_url":"https://api.github.com/users/freddyrangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freddyrangel/subscriptions","organizations_url":"https://api.github.com/users/freddyrangel/orgs","repos_url":"https://api.github.com/users/freddyrangel/repos","events_url":"https://api.github.com/users/freddyrangel/events{/privacy}","received_events_url":"https://api.github.com/users/freddyrangel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/freddyrangel/playing-with-react-and-d3","description":"A tutorial on the basics of getting React to work with D3","fork":false,"url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3","forks_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/forks","keys_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/teams","hooks_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/hooks","issue_events_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/issues/events{/number}","events_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/events","assignees_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/assignees{/user}","branches_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/branches{/branch}","tags_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/tags","blobs_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/git/refs{/sha}","trees_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/statuses/{sha}","languages_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/languages","stargazers_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/stargazers","contributors_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/contributors","subscribers_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/subscribers","subscription_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/subscription","commits_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/commits{/sha}","git_commits_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/git/commits{/sha}","comments_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/comments{/number}","issue_comment_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/issues/comments{/number}","contents_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/contents/{+path}","compare_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/merges","archive_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/downloads","issues_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/issues{/number}","pulls_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls{/number}","milestones_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/milestones{/number}","notifications_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/labels{/name}","releases_url":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/releases{/id}","created_at":"2015-10-06T22:46:12Z","updated_at":"2015-12-08T22:30:25Z","pushed_at":"2015-12-11T20:03:00Z","git_url":"git://github.com/freddyrangel/playing-with-react-and-d3.git","ssh_url":"git@github.com:freddyrangel/playing-with-react-and-d3.git","clone_url":"https://github.com/freddyrangel/playing-with-react-and-d3.git","svn_url":"https://github.com/freddyrangel/playing-with-react-and-d3","homepage":"","size":235,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/1"},"html":{"href":"https://github.com/freddyrangel/playing-with-react-and-d3/pull/1"},"issue":{"href":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/issues/1"},"comments":{"href":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/freddyrangel/playing-with-react-and-d3/statuses/d29f8f05bc7382574ae03ee21ac24ffd1cf34e54"}}}}