{"action":"created","comment":{"url":"https://api.github.com/repos/square/p2/pulls/comments/30921213","id":30921213,"diff_hunk":"@@ -32,6 +32,7 @@ type PreparerConfig struct {\n \tHooksDirectory       string                 `yaml:\"hooks_directory\"`\n \tCAPath               string                 `yaml:\"ca_path,omitempty\"`\n \tPodRoot              string                 `yaml:\"pod_root,omitempty\"`\n+\tStatusPort           int                    `yaml:\"status_port\"`","path":"pkg/preparer/setup.go","position":4,"original_position":4,"commit_id":"8c03bf51c7d3f562a03194866142c4505ce65ca6","original_commit_id":"8c03bf51c7d3f562a03194866142c4505ce65ca6","user":{"login":"anthonybishopric","id":540783,"avatar_url":"https://avatars.githubusercontent.com/u/540783?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonybishopric","html_url":"https://github.com/anthonybishopric","followers_url":"https://api.github.com/users/anthonybishopric/followers","following_url":"https://api.github.com/users/anthonybishopric/following{/other_user}","gists_url":"https://api.github.com/users/anthonybishopric/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonybishopric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonybishopric/subscriptions","organizations_url":"https://api.github.com/users/anthonybishopric/orgs","repos_url":"https://api.github.com/users/anthonybishopric/repos","events_url":"https://api.github.com/users/anthonybishopric/events{/privacy}","received_events_url":"https://api.github.com/users/anthonybishopric/received_events","type":"User","site_admin":false},"body":"In a future change, we should have the preparer write the status port from the root values of the pod manifest to the `PLATFORM_CONFIG_PATH`. As written, this requires the `status_port` field to be repeated as top-level conf and as a value in the config stanza. In general, we need to figure out how to address better port values.","created_at":"2015-05-22T18:49:28Z","updated_at":"2015-05-22T18:49:28Z","html_url":"https://github.com/square/p2/pull/175#discussion_r30921213","pull_request_url":"https://api.github.com/repos/square/p2/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/comments/30921213"},"html":{"href":"https://github.com/square/p2/pull/175#discussion_r30921213"},"pull_request":{"href":"https://api.github.com/repos/square/p2/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/175","id":36057752,"html_url":"https://github.com/square/p2/pull/175","diff_url":"https://github.com/square/p2/pull/175.diff","patch_url":"https://github.com/square/p2/pull/175.patch","issue_url":"https://api.github.com/repos/square/p2/issues/175","number":175,"state":"open","locked":false,"title":"Add status port for p2-preparer","user":{"login":"petertseng","id":9614791,"avatar_url":"https://avatars.githubusercontent.com/u/9614791?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"body":"This implementation counts consecutive errors from either hooks or pods. Status goes critical if the number of consecutive errors >= 10 (the constant tooManyErrors).\r\n\r\nI have been testing on a universe by stopping consul in the universe and seeing the errors count up. I then restart consul to see if it goes healthy again. I'm not 100% clear on whether I have the \"OK I'm healthy again\" part right. Going to do some more testing and report back on this PR.","created_at":"2015-05-22T18:38:47Z","updated_at":"2015-05-22T18:49:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"389bc7bbf0731dcc88bb11fb28b5c6a7e16cd428","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/p2/pulls/175/commits","review_comments_url":"https://api.github.com/repos/square/p2/pulls/175/comments","review_comment_url":"https://api.github.com/repos/square/p2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/p2/issues/175/comments","statuses_url":"https://api.github.com/repos/square/p2/statuses/8c03bf51c7d3f562a03194866142c4505ce65ca6","head":{"label":"petertseng:status","ref":"status","sha":"8c03bf51c7d3f562a03194866142c4505ce65ca6","user":{"login":"petertseng","id":9614791,"avatar_url":"https://avatars.githubusercontent.com/u/9614791?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"repo":{"id":26509651,"name":"p2","full_name":"petertseng/p2","owner":{"login":"petertseng","id":9614791,"avatar_url":"https://avatars.githubusercontent.com/u/9614791?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petertseng/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":true,"url":"https://api.github.com/repos/petertseng/p2","forks_url":"https://api.github.com/repos/petertseng/p2/forks","keys_url":"https://api.github.com/repos/petertseng/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petertseng/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petertseng/p2/teams","hooks_url":"https://api.github.com/repos/petertseng/p2/hooks","issue_events_url":"https://api.github.com/repos/petertseng/p2/issues/events{/number}","events_url":"https://api.github.com/repos/petertseng/p2/events","assignees_url":"https://api.github.com/repos/petertseng/p2/assignees{/user}","branches_url":"https://api.github.com/repos/petertseng/p2/branches{/branch}","tags_url":"https://api.github.com/repos/petertseng/p2/tags","blobs_url":"https://api.github.com/repos/petertseng/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petertseng/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petertseng/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/petertseng/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petertseng/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/petertseng/p2/languages","stargazers_url":"https://api.github.com/repos/petertseng/p2/stargazers","contributors_url":"https://api.github.com/repos/petertseng/p2/contributors","subscribers_url":"https://api.github.com/repos/petertseng/p2/subscribers","subscription_url":"https://api.github.com/repos/petertseng/p2/subscription","commits_url":"https://api.github.com/repos/petertseng/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/petertseng/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/petertseng/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/petertseng/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/petertseng/p2/contents/{+path}","compare_url":"https://api.github.com/repos/petertseng/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petertseng/p2/merges","archive_url":"https://api.github.com/repos/petertseng/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petertseng/p2/downloads","issues_url":"https://api.github.com/repos/petertseng/p2/issues{/number}","pulls_url":"https://api.github.com/repos/petertseng/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/petertseng/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/petertseng/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petertseng/p2/labels{/name}","releases_url":"https://api.github.com/repos/petertseng/p2/releases{/id}","created_at":"2014-11-11T23:21:20Z","updated_at":"2015-04-28T17:51:41Z","pushed_at":"2015-05-15T22:49:59Z","git_url":"git://github.com/petertseng/p2.git","ssh_url":"git@github.com:petertseng/p2.git","clone_url":"https://github.com/petertseng/p2.git","svn_url":"https://github.com/petertseng/p2","homepage":"","size":15988,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"51c595185e4af998daaefc1f03c63940e1506d81","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":25320424,"name":"p2","full_name":"square/p2","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":false,"url":"https://api.github.com/repos/square/p2","forks_url":"https://api.github.com/repos/square/p2/forks","keys_url":"https://api.github.com/repos/square/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/p2/teams","hooks_url":"https://api.github.com/repos/square/p2/hooks","issue_events_url":"https://api.github.com/repos/square/p2/issues/events{/number}","events_url":"https://api.github.com/repos/square/p2/events","assignees_url":"https://api.github.com/repos/square/p2/assignees{/user}","branches_url":"https://api.github.com/repos/square/p2/branches{/branch}","tags_url":"https://api.github.com/repos/square/p2/tags","blobs_url":"https://api.github.com/repos/square/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/square/p2/languages","stargazers_url":"https://api.github.com/repos/square/p2/stargazers","contributors_url":"https://api.github.com/repos/square/p2/contributors","subscribers_url":"https://api.github.com/repos/square/p2/subscribers","subscription_url":"https://api.github.com/repos/square/p2/subscription","commits_url":"https://api.github.com/repos/square/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/p2/contents/{+path}","compare_url":"https://api.github.com/repos/square/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/p2/merges","archive_url":"https://api.github.com/repos/square/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/p2/downloads","issues_url":"https://api.github.com/repos/square/p2/issues{/number}","pulls_url":"https://api.github.com/repos/square/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/square/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/square/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/p2/labels{/name}","releases_url":"https://api.github.com/repos/square/p2/releases{/id}","created_at":"2014-10-16T20:31:12Z","updated_at":"2015-05-22T18:32:42Z","pushed_at":"2015-05-22T18:38:48Z","git_url":"git://github.com/square/p2.git","ssh_url":"git@github.com:square/p2.git","clone_url":"https://github.com/square/p2.git","svn_url":"https://github.com/square/p2","homepage":"","size":18361,"stargazers_count":49,"watchers_count":49,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/175"},"html":{"href":"https://github.com/square/p2/pull/175"},"issue":{"href":"https://api.github.com/repos/square/p2/issues/175"},"comments":{"href":"https://api.github.com/repos/square/p2/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/square/p2/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/square/p2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/p2/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/square/p2/statuses/8c03bf51c7d3f562a03194866142c4505ce65ca6"}}}}