{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/38170484","id":38170484,"diff_hunk":"@@ -0,0 +1,249 @@\n+/*\n+** Copyright (c) 2012 The Khronos Group Inc.\n+**\n+** Permission is hereby granted, free of charge, to any person obtaining a\n+** copy of this software and/or associated documentation files (the\n+** \"Materials\"), to deal in the Materials without restriction, including\n+** without limitation the rights to use, copy, modify, merge, publish,\n+** distribute, sublicense, and/or sell copies of the Materials, and to\n+** permit persons to whom the Materials are furnished to do so, subject to\n+** the following conditions:\n+**\n+** The above copyright notice and this permission notice shall be included\n+** in all copies or substantial portions of the Materials.\n+**\n+** THE MATERIALS ARE PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n+** EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+** MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.\n+** IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY\n+** CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,\n+** TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE\n+** MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS.\n+*/\n+var TexImageUtils = (function() {","path":"sdk/tests/js/tests/tex-image-and-sub-image-2d-utils.js","position":23,"original_position":23,"commit_id":"5fcc639c0ca75828f1526ff65a42f0e9cf38be5f","original_commit_id":"5fcc639c0ca75828f1526ff65a42f0e9cf38be5f","user":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"body":"I feel this should be part of the WTU, so it can be used in tests other than texture ones.  But let's merge with the current design and we can iterate later.","created_at":"2015-08-28T04:35:10Z","updated_at":"2015-08-28T04:35:10Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/1170#discussion_r38170484","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1170","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/38170484"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1170#discussion_r38170484"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1170"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1170","id":43586824,"html_url":"https://github.com/KhronosGroup/WebGL/pull/1170","diff_url":"https://github.com/KhronosGroup/WebGL/pull/1170.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/1170.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1170","number":1170,"state":"open","locked":false,"title":"WebGL2 - Improve tex image and sub image tests","user":{"login":"djg","id":156077,"avatar_url":"https://avatars.githubusercontent.com/u/156077?v=3","gravatar_id":"","url":"https://api.github.com/users/djg","html_url":"https://github.com/djg","followers_url":"https://api.github.com/users/djg/followers","following_url":"https://api.github.com/users/djg/following{/other_user}","gists_url":"https://api.github.com/users/djg/gists{/gist_id}","starred_url":"https://api.github.com/users/djg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djg/subscriptions","organizations_url":"https://api.github.com/users/djg/orgs","repos_url":"https://api.github.com/users/djg/repos","events_url":"https://api.github.com/users/djg/events{/privacy}","received_events_url":"https://api.github.com/users/djg/received_events","type":"User","site_admin":false},"body":"I fixed up the texImage2D and texSubImage2D tests that work with various DOM elements to work with GL_RED as well as unsigned integer textures.\r\n\r\nI made some improvements to the tests taking `image data` to exercise that pre-multiplied alpha was applied.\r\n\r\nPTAL","created_at":"2015-08-28T02:03:58Z","updated_at":"2015-08-28T04:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bb5bbde9062d223da26a41f14dbc99b036e20ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1170/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1170/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1170/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/5fcc639c0ca75828f1526ff65a42f0e9cf38be5f","head":{"label":"djg:webgl2-improve-tex-image-and-sub-image-tests","ref":"webgl2-improve-tex-image-and-sub-image-tests","sha":"5fcc639c0ca75828f1526ff65a42f0e9cf38be5f","user":{"login":"djg","id":156077,"avatar_url":"https://avatars.githubusercontent.com/u/156077?v=3","gravatar_id":"","url":"https://api.github.com/users/djg","html_url":"https://github.com/djg","followers_url":"https://api.github.com/users/djg/followers","following_url":"https://api.github.com/users/djg/following{/other_user}","gists_url":"https://api.github.com/users/djg/gists{/gist_id}","starred_url":"https://api.github.com/users/djg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djg/subscriptions","organizations_url":"https://api.github.com/users/djg/orgs","repos_url":"https://api.github.com/users/djg/repos","events_url":"https://api.github.com/users/djg/events{/privacy}","received_events_url":"https://api.github.com/users/djg/received_events","type":"User","site_admin":false},"repo":{"id":12957298,"name":"WebGL","full_name":"djg/WebGL","owner":{"login":"djg","id":156077,"avatar_url":"https://avatars.githubusercontent.com/u/156077?v=3","gravatar_id":"","url":"https://api.github.com/users/djg","html_url":"https://github.com/djg","followers_url":"https://api.github.com/users/djg/followers","following_url":"https://api.github.com/users/djg/following{/other_user}","gists_url":"https://api.github.com/users/djg/gists{/gist_id}","starred_url":"https://api.github.com/users/djg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djg/subscriptions","organizations_url":"https://api.github.com/users/djg/orgs","repos_url":"https://api.github.com/users/djg/repos","events_url":"https://api.github.com/users/djg/events{/privacy}","received_events_url":"https://api.github.com/users/djg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djg/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/djg/WebGL","forks_url":"https://api.github.com/repos/djg/WebGL/forks","keys_url":"https://api.github.com/repos/djg/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djg/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djg/WebGL/teams","hooks_url":"https://api.github.com/repos/djg/WebGL/hooks","issue_events_url":"https://api.github.com/repos/djg/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/djg/WebGL/events","assignees_url":"https://api.github.com/repos/djg/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/djg/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/djg/WebGL/tags","blobs_url":"https://api.github.com/repos/djg/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djg/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djg/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/djg/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djg/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/djg/WebGL/languages","stargazers_url":"https://api.github.com/repos/djg/WebGL/stargazers","contributors_url":"https://api.github.com/repos/djg/WebGL/contributors","subscribers_url":"https://api.github.com/repos/djg/WebGL/subscribers","subscription_url":"https://api.github.com/repos/djg/WebGL/subscription","commits_url":"https://api.github.com/repos/djg/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/djg/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/djg/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/djg/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/djg/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/djg/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djg/WebGL/merges","archive_url":"https://api.github.com/repos/djg/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djg/WebGL/downloads","issues_url":"https://api.github.com/repos/djg/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/djg/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/djg/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/djg/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djg/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/djg/WebGL/releases{/id}","created_at":"2013-09-19T19:26:23Z","updated_at":"2015-04-01T02:01:17Z","pushed_at":"2015-08-28T01:59:24Z","git_url":"git://github.com/djg/WebGL.git","ssh_url":"git@github.com:djg/WebGL.git","clone_url":"https://github.com/djg/WebGL.git","svn_url":"https://github.com/djg/WebGL","homepage":null,"size":18947,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"d316a4bee2ec71824ad5b5b3311357c0de15a984","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","created_at":"2012-07-27T17:21:51Z","updated_at":"2015-08-27T04:57:20Z","pushed_at":"2015-08-28T02:03:59Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":30481,"stargazers_count":399,"watchers_count":399,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":224,"mirror_url":null,"open_issues_count":41,"forks":224,"open_issues":41,"watchers":399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1170"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1170"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1170"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1170/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1170/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1170/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/5fcc639c0ca75828f1526ff65a42f0e9cf38be5f"}}}}