{"action":"closed","number":4566,"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/4566","id":38138208,"html_url":"https://github.com/scala/scala/pull/4566","diff_url":"https://github.com/scala/scala/pull/4566.diff","patch_url":"https://github.com/scala/scala/pull/4566.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/4566","number":4566,"state":"closed","locked":false,"title":"SI-9359 Fix InnerClass entry flags for nested Java enums","user":{"login":"lrytz","id":119636,"avatar_url":"https://avatars.githubusercontent.com/u/119636?v=3","gravatar_id":"","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false},"body":"The access flags in InnerClass entries for nested Java enums were\r\nbasically completely off.\r\n\r\nA first step is to use the recently introduced backend method\r\n`javaClassfileFlags`, which is now moved to BCodeAsmCommon.\r\nSee its doc for an explanation.\r\n\r\nThen the flags of the enum class symbol were off. An enum is\r\n  - final if none of its values has a class body\r\n  - abstract if it has an abstract method\r\n(https://docs.oracle.com/javase/specs/jls/se7/html/jls-8.html#jls-8.9)\r\n\r\nWhen using the ClassfileParser:\r\n  - ENUM was never added. I guess that's just an oversight.\r\n  - ABSTRACT (together with SEALED) was always added. This is to\r\n    enable exhaustiveness checking, see 3f7b8b5. This is a hack and we\r\n    have to go through the class members in the backend to find out if\r\n    the enum actually has the `ACC_ABSTRACT` flag or not.\r\n\r\nWhen using the JavaParser:\r\n  - FINAL was never added.\r\n  - ABSTRACT was never added.\r\n\r\nThis commit fixes all of the above and tests cases (Java enum read\r\nfrom the classfile and from source).","created_at":"2015-06-19T19:08:49Z","updated_at":"2015-06-22T18:09:50Z","closed_at":"2015-06-22T18:09:50Z","merged_at":"2015-06-22T18:09:50Z","merge_commit_sha":"31823bff05884e94b09301d140e115cfe1f33c0a","assignee":null,"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/48","html_url":"https://github.com/scala/scala/milestones/2.11.7","labels_url":"https://api.github.com/repos/scala/scala/milestones/48/labels","id":985497,"number":48,"title":"2.11.7","description":"  - [X] unfork repl for spark\r\n\r\n","creator":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":155,"state":"open","created_at":"2015-02-19T00:12:20Z","updated_at":"2015-06-22T18:09:50Z","due_on":"2015-06-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scala/scala/pulls/4566/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/4566/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/4566/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/958e6259baf0ea303f6cee468be35b18107ffd41","head":{"label":"lrytz:t9359","ref":"t9359","sha":"958e6259baf0ea303f6cee468be35b18107ffd41","user":{"login":"lrytz","id":119636,"avatar_url":"https://avatars.githubusercontent.com/u/119636?v=3","gravatar_id":"","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false},"repo":{"id":2891199,"name":"scala","full_name":"lrytz/scala","owner":{"login":"lrytz","id":119636,"avatar_url":"https://avatars.githubusercontent.com/u/119636?v=3","gravatar_id":"","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lrytz/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/lrytz/scala","forks_url":"https://api.github.com/repos/lrytz/scala/forks","keys_url":"https://api.github.com/repos/lrytz/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lrytz/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lrytz/scala/teams","hooks_url":"https://api.github.com/repos/lrytz/scala/hooks","issue_events_url":"https://api.github.com/repos/lrytz/scala/issues/events{/number}","events_url":"https://api.github.com/repos/lrytz/scala/events","assignees_url":"https://api.github.com/repos/lrytz/scala/assignees{/user}","branches_url":"https://api.github.com/repos/lrytz/scala/branches{/branch}","tags_url":"https://api.github.com/repos/lrytz/scala/tags","blobs_url":"https://api.github.com/repos/lrytz/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lrytz/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lrytz/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/lrytz/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lrytz/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/lrytz/scala/languages","stargazers_url":"https://api.github.com/repos/lrytz/scala/stargazers","contributors_url":"https://api.github.com/repos/lrytz/scala/contributors","subscribers_url":"https://api.github.com/repos/lrytz/scala/subscribers","subscription_url":"https://api.github.com/repos/lrytz/scala/subscription","commits_url":"https://api.github.com/repos/lrytz/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/lrytz/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/lrytz/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/lrytz/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/lrytz/scala/contents/{+path}","compare_url":"https://api.github.com/repos/lrytz/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lrytz/scala/merges","archive_url":"https://api.github.com/repos/lrytz/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lrytz/scala/downloads","issues_url":"https://api.github.com/repos/lrytz/scala/issues{/number}","pulls_url":"https://api.github.com/repos/lrytz/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/lrytz/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/lrytz/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lrytz/scala/labels{/name}","releases_url":"https://api.github.com/repos/lrytz/scala/releases{/id}","created_at":"2011-12-01T13:16:01Z","updated_at":"2015-05-07T07:51:48Z","pushed_at":"2015-06-22T15:50:06Z","git_url":"git://github.com/lrytz/scala.git","ssh_url":"git@github.com:lrytz/scala.git","clone_url":"https://github.com/lrytz/scala.git","svn_url":"https://github.com/lrytz/scala","homepage":"http://www.scala-lang.org/","size":89166,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.11.x"}},"base":{"label":"scala:2.11.x","ref":"2.11.x","sha":"7383eda7d35525bcad70ef89d13a7037945283b4","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","created_at":"2011-12-01T05:02:34Z","updated_at":"2015-06-22T00:47:04Z","pushed_at":"2015-06-22T18:09:50Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":194211,"stargazers_count":4386,"watchers_count":4386,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1127,"mirror_url":null,"open_issues_count":17,"forks":1127,"open_issues":17,"watchers":4386,"default_branch":"2.11.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/4566"},"html":{"href":"https://github.com/scala/scala/pull/4566"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/4566"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/4566/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/4566/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/4566/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/958e6259baf0ea303f6cee468be35b18107ffd41"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":2,"additions":175,"deletions":66,"changed_files":15}}