{"action":"created","issue":{"url":"https://api.github.com/repos/onelogin/ruby-saml/issues/227","labels_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/227/comments","events_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/227/events","html_url":"https://github.com/onelogin/ruby-saml/pull/227","id":72284228,"number":227,"title":"Save bindings specified in IdP metadata","user":{"login":"justingaylor","id":635873,"avatar_url":"https://avatars.githubusercontent.com/u/635873?v=3","gravatar_id":"","url":"https://api.github.com/users/justingaylor","html_url":"https://github.com/justingaylor","followers_url":"https://api.github.com/users/justingaylor/followers","following_url":"https://api.github.com/users/justingaylor/following{/other_user}","gists_url":"https://api.github.com/users/justingaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/justingaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justingaylor/subscriptions","organizations_url":"https://api.github.com/users/justingaylor/orgs","repos_url":"https://api.github.com/users/justingaylor/repos","events_url":"https://api.github.com/users/justingaylor/events{/privacy}","received_events_url":"https://api.github.com/users/justingaylor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-30T21:19:56Z","updated_at":"2015-06-29T19:41:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/onelogin/ruby-saml/pulls/227","html_url":"https://github.com/onelogin/ruby-saml/pull/227","diff_url":"https://github.com/onelogin/ruby-saml/pull/227.diff","patch_url":"https://github.com/onelogin/ruby-saml/pull/227.patch"},"body":"This change adds two new fields to the settings object:\r\n- `idp_sso_target_url_bindings`\r\n- `idp_slo_target_url_bindings`\r\n\r\nThese new fields are populated from the IdP metadata and are Arrays of Strings whose values are the Binding descriptors (e.g. `\"urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect\"`) in the order they were specified in the metadata file.\r\n\r\nSigned-off-by: Justin Gaylor <justin@rightscale.com>"},"comment":{"url":"https://api.github.com/repos/onelogin/ruby-saml/issues/comments/116813051","html_url":"https://github.com/onelogin/ruby-saml/pull/227#issuecomment-116813051","issue_url":"https://api.github.com/repos/onelogin/ruby-saml/issues/227","id":116813051,"user":{"login":"pitbulk","id":600897,"avatar_url":"https://avatars.githubusercontent.com/u/600897?v=3","gravatar_id":"","url":"https://api.github.com/users/pitbulk","html_url":"https://github.com/pitbulk","followers_url":"https://api.github.com/users/pitbulk/followers","following_url":"https://api.github.com/users/pitbulk/following{/other_user}","gists_url":"https://api.github.com/users/pitbulk/gists{/gist_id}","starred_url":"https://api.github.com/users/pitbulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitbulk/subscriptions","organizations_url":"https://api.github.com/users/pitbulk/orgs","repos_url":"https://api.github.com/users/pitbulk/repos","events_url":"https://api.github.com/users/pitbulk/events{/privacy}","received_events_url":"https://api.github.com/users/pitbulk/received_events","type":"User","site_admin":false},"created_at":"2015-06-29T19:41:02Z","updated_at":"2015-06-29T19:41:02Z","body":"@stevecrozz \r\n\r\nmeans that right now, we only support HTTP-POST for ACS endpoint and HTTP-Redirect for the rest.\r\nSo I believe that this commit is not necessary at this moment since there are no alternatives for the bindings and adding 2 extra parameters to the settings only turn it more complex. Are you disagree?"}}