{"action":"opened","issue":{"url":"https://api.github.com/repos/torps/torps/issues/2","labels_url":"https://api.github.com/repos/torps/torps/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/torps/torps/issues/2/comments","events_url":"https://api.github.com/repos/torps/torps/issues/2/events","html_url":"https://github.com/torps/torps/issues/2","id":100308599,"number":2,"title":"Wrong values of bwweights when simulating with relay adversaries","user":{"login":"frochet","id":1092288,"avatar_url":"https://avatars.githubusercontent.com/u/1092288?v=3","gravatar_id":"","url":"https://api.github.com/users/frochet","html_url":"https://github.com/frochet","followers_url":"https://api.github.com/users/frochet/followers","following_url":"https://api.github.com/users/frochet/following{/other_user}","gists_url":"https://api.github.com/users/frochet/gists{/gist_id}","starred_url":"https://api.github.com/users/frochet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frochet/subscriptions","organizations_url":"https://api.github.com/users/frochet/orgs","repos_url":"https://api.github.com/users/frochet/repos","events_url":"https://api.github.com/users/frochet/events{/privacy}","received_events_url":"https://api.github.com/users/frochet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-08-11T13:16:46Z","updated_at":"2015-08-11T13:16:46Z","closed_at":null,"body":"Hello !\r\n\r\nThe bandwidth weights received from the consensuses don't take into account the bandwidth we add to the simulated network when we inject adversarial nodes. I think that this could have bad consequences, leading to false results when too much bandwidth is added.\r\nRegarding section 3.8.3 of Tor spec, the computation of bandwidth weights depends of the network load. \r\n1) It's possible that, depending of the amount of bandwidth added, the case of the network load change. In results, the bwweights need to be computed differently.\r\n2) Even if the added bandwidth does not modify the case of the network load, the bwweights needs to be recomputed to take into account these adversarial relays in the load balancing.\r\n\r\nI plan to modify network_modifiers.py to recompute bwweights. What do you think ?\r\n\r\nRegards,\r\n\r\nFlorentin"}}