{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/31179150","id":31179150,"diff_hunk":"@@ -59,78 +64,159 @@ public MetricsClient(ClientConfig config) {\n   }\n \n   /**\n-   * Gets the value of a particular metric.\n+   * Searches for metrics tags matching the given tags.\n    *\n-   * @param metric name of the metric\n-   * @param context context of the metric\n-   * @param groupBy how to group the metrics\n-   * @return value of the metric\n+   * @param tags the tags to match\n+   * @return the metrics matching the given tags\n    * @throws IOException if a network error occurred\n    * @throws UnauthorizedException if the request is not authorized successfully in the gateway server\n    */\n-  public MetricQueryResult query(String metric, @Nullable Map<String, String> context,\n-                                 @Nullable String start, @Nullable String end, @Nullable String groupBy)\n+  public List<MetricTagValue> searchTags(Map<String, String> tags)\n     throws IOException, UnauthorizedException {\n \n-    URL url = config.resolveURLV3(String.format(\"metrics/query?metric=%s%s%s%s%s\", metric,\n-                                                start == null ? \"\" : \"&start=\" + start,\n-                                                end == null ? \"\" : \"&end=\" + end,\n-                                                context == null ? \"\" : \"&context=\" + contextToPathParam(context),\n-                                                groupBy == null ? \"\" : \"&groupBy=\" + groupBy));\n+    List<String> queryParts = Lists.newArrayList();\n+    queryParts.add(\"target=tag\");\n+    addTags(tags, queryParts);\n+\n+    URL url = config.resolveURLV3(String.format(\"metrics/search?%s\", Joiner.on(\"&\").join(queryParts)));\n     HttpResponse response = restClient.execute(HttpMethod.POST, url, config.getAccessToken());\n-    return ObjectResponse.fromJsonBody(response, MetricQueryResult.class).getResponseObject();\n+    ObjectResponse<List<MetricTagValue>> result = ObjectResponse.fromJsonBody(\n+      response, new TypeToken<List<MetricTagValue>>() { }.getType());\n+    return result.getResponseObject();\n+  }\n+\n+  /**\n+   * Searches for metrics matching the given tags.\n+   *\n+   * @param tags the tags to match\n+   * @return the metrics matching the given tags\n+   * @throws IOException if a network error occurred\n+   * @throws UnauthorizedException if the request is not authorized successfully in the gateway server\n+   */\n+  public List<String> searchMetrics(Map<String, String> tags)\n+    throws IOException, UnauthorizedException {\n+\n+    List<String> queryParts = Lists.newArrayList();\n+    queryParts.add(\"target=metric\");\n+    addTags(tags, queryParts);\n+\n+    URL url = config.resolveURLV3(String.format(\"metrics/search?%s\", Joiner.on(\"&\").join(queryParts)));\n+    HttpResponse response = restClient.execute(HttpMethod.POST, url, config.getAccessToken());\n+    ObjectResponse<List<String>> result = ObjectResponse.fromJsonBody(\n+      response, new TypeToken<List<String>>() { }.getType());\n+    return result.getResponseObject();\n   }\n \n-  public MetricQueryResult query(String metric, Map<String, String> context)\n+  /**\n+   * Gets the value of the given metrics.","path":"cdap-client/src/main/java/co/cask/cdap/client/MetricsClient.java","position":87,"original_position":87,"commit_id":"a467a28855cad53d4c0913802bb3169f0eff96a5","original_commit_id":"a467a28855cad53d4c0913802bb3169f0eff96a5","user":{"login":"awholegunch","id":6394794,"avatar_url":"https://avatars.githubusercontent.com/u/6394794?v=3","gravatar_id":"","url":"https://api.github.com/users/awholegunch","html_url":"https://github.com/awholegunch","followers_url":"https://api.github.com/users/awholegunch/followers","following_url":"https://api.github.com/users/awholegunch/following{/other_user}","gists_url":"https://api.github.com/users/awholegunch/gists{/gist_id}","starred_url":"https://api.github.com/users/awholegunch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awholegunch/subscriptions","organizations_url":"https://api.github.com/users/awholegunch/orgs","repos_url":"https://api.github.com/users/awholegunch/repos","events_url":"https://api.github.com/users/awholegunch/events{/privacy}","received_events_url":"https://api.github.com/users/awholegunch/received_events","type":"User","site_admin":false},"body":"This and the next method have the same description; it would be good if that first sentence gave enough context to explain why there are two methods with otherwise the same description. I guess it's because you haven't detailed all the parameters in the second one. Maybe refer to the first as wrapper?","created_at":"2015-05-27T20:53:34Z","updated_at":"2015-05-27T20:53:34Z","html_url":"https://github.com/caskdata/cdap/pull/2687#discussion_r31179150","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/2687","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/31179150"},"html":{"href":"https://github.com/caskdata/cdap/pull/2687#discussion_r31179150"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2687"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/2687","id":35453598,"html_url":"https://github.com/caskdata/cdap/pull/2687","diff_url":"https://github.com/caskdata/cdap/pull/2687.diff","patch_url":"https://github.com/caskdata/cdap/pull/2687.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/2687","number":2687,"state":"open","locked":false,"title":"CDAP-2515: MetricsClient changes for query and search by tags","user":{"login":"jwang47","id":1084704,"avatar_url":"https://avatars.githubusercontent.com/u/1084704?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang47","html_url":"https://github.com/jwang47","followers_url":"https://api.github.com/users/jwang47/followers","following_url":"https://api.github.com/users/jwang47/following{/other_user}","gists_url":"https://api.github.com/users/jwang47/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang47/subscriptions","organizations_url":"https://api.github.com/users/jwang47/orgs","repos_url":"https://api.github.com/users/jwang47/repos","events_url":"https://api.github.com/users/jwang47/events{/privacy}","received_events_url":"https://api.github.com/users/jwang47/received_events","type":"User","site_admin":false},"body":"http://builds.cask.co/browse/CDAP-DUT1841\r\nhttps://issues.cask.co/browse/CDAP-2515","created_at":"2015-05-14T19:30:54Z","updated_at":"2015-05-27T20:53:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1be76bf7314520bce449c2bc577f5336f04455eb","assignee":null,"milestone":{"url":"https://api.github.com/repos/caskdata/cdap/milestones/6","html_url":"https://github.com/caskdata/cdap/milestones/3.1.0","labels_url":"https://api.github.com/repos/caskdata/cdap/milestones/6/labels","id":1099347,"number":6,"title":"3.1.0","description":null,"creator":{"login":"jwang47","id":1084704,"avatar_url":"https://avatars.githubusercontent.com/u/1084704?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang47","html_url":"https://github.com/jwang47","followers_url":"https://api.github.com/users/jwang47/followers","following_url":"https://api.github.com/users/jwang47/following{/other_user}","gists_url":"https://api.github.com/users/jwang47/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang47/subscriptions","organizations_url":"https://api.github.com/users/jwang47/orgs","repos_url":"https://api.github.com/users/jwang47/repos","events_url":"https://api.github.com/users/jwang47/events{/privacy}","received_events_url":"https://api.github.com/users/jwang47/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":16,"state":"open","created_at":"2015-05-06T23:17:15Z","updated_at":"2015-05-26T23:37:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/2687/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/2687/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/2687/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/a467a28855cad53d4c0913802bb3169f0eff96a5","head":{"label":"caskdata:feature/metrics-client","ref":"feature/metrics-client","sha":"a467a28855cad53d4c0913802bb3169f0eff96a5","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-05-27T04:29:46Z","pushed_at":"2015-05-27T20:53:21Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":879529,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":17,"forks":17,"open_issues":17,"watchers":49,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"f16ce0ce515193274a4d62839cce0f61aab742a0","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-05-27T04:29:46Z","pushed_at":"2015-05-27T20:53:21Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":879529,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":17,"forks":17,"open_issues":17,"watchers":49,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2687"},"html":{"href":"https://github.com/caskdata/cdap/pull/2687"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/2687"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/2687/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2687/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2687/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/a467a28855cad53d4c0913802bb3169f0eff96a5"}}}}