There is an ongoing debate in the area of teaching English to speakers of other languages (TESOL) about what should constitute the knowledge base of language teachers This article offers an analysis of the major opposing views in the debate and suggests an alternative critical approach to language teacher knowledge