Go ahead!

Sent from my iPhone. Excuse any typos....

Am 02.11.2012 um 02:21 schrieb Jeff Pinner notifications@github.com:

> According to the spec method should be case sensitive:
> 
> http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1
> 
> but the case is ignored in HttpMethod.java:
> 
> name = name.trim().toUpperCase();
> 
> If there are no objections, I'd like to drop the toUpperCase() in both 3.x and 4.0 in order to comply with the spec.
> 
> —
> Reply to this email directly or view it on GitHub.
 Both pull request merged... Thanks!

HTTP method should be case sensitive
According to the spec method should be case sensitive:

http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.1

but the case is ignored in HttpMethod.java:

name = name.trim().toUpperCase();

If there are no objections, I'd like to drop the toUpperCase() in both 3.x and 4.0 in order to comply with the spec.

codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java
codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java
index 6a97242a566..166df645c49 100644
--- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java
+++ b/codec-http/src/main/java/io/netty/handler/codec/http/HttpMethod.java
@@ -109,7 +109,7 @@ public static HttpMethod valueOf(String name) {
             throw new NullPointerException("name");
         }
 
-        name = name.trim().toUpperCase();
+        name = name.trim();
         if (name.length() == 0) {
             throw new IllegalArgumentException("empty name");
         }
@@ -136,7 +136,7 @@ public HttpMethod(String name) {
             throw new NullPointerException("name");
         }
 
-        name = name.trim().toUpperCase();
+        name = name.trim();
         if (name.length() == 0) {
             throw new IllegalArgumentException("empty name");
         }
